[Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Feb 2 08:53:21 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59749|0                           |1
        is obsolete|                            |

--- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 59766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59766&action=edit
Bug 17982: Fix the use of uniq in sub themelanguage

Doing uniq( \@themes ) is useless. It will just return to you the only
reference you gave it.
List::MoreUtils::uniq requires a list instead of an arrayref.
So it is a trivial fix that makes sub themelanguage return one theme instead
of three themes like [ 'prog', 'prog',  'prog' ].
Note that Template->new inserts one or two include paths to TT for each of
these three identical themes.

Test plan:
[1] Run t/db_dependent/Templates.t (should no longer fail)
[2] Run t/db_dependent/Auth.t (triggering themelanguage)
[3] Open a page on OPAC or intranet. (Did you restart Plack?)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

EDIT (Marcel): Amended test plan for additional unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list