[Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Feb 2 10:19:45 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 59753
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59753
[SIGNED-OFF] Bug 17934: Make t/db_dependent/www/auth_values_input_www.t awesome

Review of attachment 59753:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17934&attachment=59753)
-----------------------------------------------------------------

::: t/db_dependent/www/auth_values_input_www.t
@@ +167,4 @@
>  $add_form_link_exists = 0;
>  $delete_form_link_exists = 0;
>  for my $link ( $agent->links() ) {
> +    if ( $link->url =~ m/authorised_values.pl\x3Fop=add_form&category=$category/xsm ) {

Really? This is terrible.
I do not see the point to follow perlcritic -1 if it's to introduce such
things.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list