[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

--- Comment #16 from Aleisha Amohia <aleishaamohia at hotmail.com> ---
(In reply to Jonathan Druart from comment #12)
> Aleisha,
> I have rebased your patch on top of the ones I have submitted on bug 14224.
> You should take a look to apply some changes, for instance:
> 1/ Return a to_json
> 2/ Check the existence of the DB columns before inserting them
> 3/ Use "AFTER" in the ADD column sql query (to enforce fields order)
> 4/ I do not think checkout_notes should be a new module. I'd say it should
> go to circ
> 5/ Make sure the strings are translatable

(In reply to Jonathan Druart from comment #13)
> Something important: In svc/issue_notes you are not testing that the logged
> in user is allowed to call this script.

I have applied all of these changes and changed all instances (I think) of
'issue note' to 'checkout note'. This is ready to sign off

-- 
You are receiving this mail because:
You are watching all bug changes.