[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #146 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 59830
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59830
Bug 17855 - Follow up on copyright text, removal of summary info, removal of
duplicate js and improved js indentation, removed useless use pragmas

Review of attachment 59830:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=59830)
-----------------------------------------------------------------

Quick eyeball. If it behaves as before, I'll sign off.

::: installer/onboarding.pl
@@ +2,4 @@
>  
>  # This file is part of Koha.
>  #
> +# Copyright (C) 2017 Catalyst IT

Addresses point 4 in comment #133.

@@ -30,5 @@
> -use C4::Members::Attributes;
> -use C4::Members::AttributeTypes;
> -use C4::Log;
> -use Koha::AuthorisedValues;
> -use Koha::Patron::Debarments;

Addresses point 3 in comment #133.

@@ -39,5 @@
>  use Koha::DateUtils;
>  use Koha::Patron::Categories;
>  use Koha::Patron::Category;
> -use Koha::Patron::HouseboundRole;
> -use Koha::Patron::HouseboundRoles;

Addresses point 3 in comment #133.

@@ -44,4 @@
>  use Koha::ItemTypes;
>  use Koha::IssuingRule;
>  use Koha::IssuingRules;
> -use Data::Dumper;

Addresses point 3 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
@@ -42,5 @@
>                      <li><a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a></li>
>                      [% END %]
>                      <li><a href="/cgi-bin/koha/about.pl">About Koha</a></li>
> -                    <li><a href="/cgi-bin/koha/summary.pl">Summary</a></li>
> -

Removal deals with point 7-9 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt
@@ +5,5 @@
>  <title> Add a patron category</title>
>  [% INCLUDE 'installer-doc-head-close.inc' %]
>  [% INCLUDE 'calendar.inc' %]
> +[% INCLUDE 'js_includes.inc' %]
> +[% INCLUDE 'datatables.inc' %]

Good simplification to address point 5 in comment #133.

@@ +20,4 @@
>        } else {
>               return true;
>        }
> +    }, MSG_ONE_ENROLLMENTPERIOD

Because of using included javascripts, variable name changed. Related to point
5 in comment #133.

@@ +25,2 @@
>  </script>
> +<script type="text/javascript" src="[% themelang %]/js/categories.js"></script>

Addresses point 5 in comment #133.

::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ +7,4 @@
>  [% INCLUDE 'installer-doc-head-close.inc' %]
>  [% INCLUDE 'calendar.inc' %]
>  [% INCLUDE 'datatables.inc' %]
> +[% INCLUDE 'js_includes.inc' %]

Point 6 in comment #133.

@@ -21,5 @@
> -
> -
> -<script type="text/javascript">
> -jQuery.validator.addMethod( "password_match", function(value,element){
> -        var MSG_PASSWORD_MISMATCH = (_("The passwords entered do not match"));

I like the simplification, but I think this shorter message is better, rather
than the longer one above. But, not a Failed QA, in my mind.

@@ +174,4 @@
>                      <ol>
>                      <h3>OPAC/Staff Login</h3>
>                          <li>
> +                            <input type="hidden" name="BorrowerMandatoryField" value = "[% BorrowerMandatoryField %]" />

Not sure if the spacing will matter, but good HTML validation improvement by
including the double quotes.

-- 
You are receiving this mail because:
You are watching all bug changes.