[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 59911
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59911
Bug 18002 - Removed the Javascript preventing the display of currency and
acquisition setup messages at the same time

Review of attachment 59911:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18002&attachment=59911)
-----------------------------------------------------------------

::: acqui/acqui-home.pl
@@ +107,4 @@
>      push @budget_loop, $budget;
>  }
>  
> +warn \@budget_loop;

usually a plain warn is a bad idea. I believe other code looks like:
$debug && ...

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
@@ +103,4 @@
>      [% INCLUDE 'budgets-active-currency.inc' hide = 'yes' %]
>      [% UNLESS ( loop_budget ) %]
>          [% IF ( CAN_user_acquisition_period_manage ) %]
> +            <div id="acquisitionsModal" style="z-index:1;background-color:#EDF4F6;padding:20px;width:60%;height:30%;position:fixed;align:center;left:auto;top:auto;right:auto;bottom:10%;">

Inline styling is not really a good idea. Though, perhaps Owen can better speak
to that.

-- 
You are receiving this mail because:
You are watching all bug changes.