[Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59547|0                           |1
        is obsolete|                            |

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 59927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59927&action=edit
Bug 16018: [Follow-up] Code cleaning

It is not useful to postpone a merge to the cron job here, since the
old authority record is deleted. (Note that bug 9988 will address this
subject too.)

Removing the call to C4::ImportBatch::SetImportRecordStatus: Since
$recordid2 is not an import_record_id, this is useless and potentially wrong.
Removed the if statement for @errors, since it is not used at this point;
putting the result of a comparison into $error is not useful either.

Note: there is a lot of code in merge.pl around breeding that is actually
unused. Template tools/manage-marc-import.tt contains two unused blocks
final_match_link and match_link that contain a (unreachable) call to
authorities/merge.pl with parameters:
mergereference=breeding&authid=[% record_lis.match_id %]&authid=[%
record_lis.import_record_id %]
It seems that this would show the records correctly, but would not merge
them correctly since that code expects two authority records.

Leaving the signoff of Mehdi since he essentially tested the merge call.

Test plan: See first patch.

Signed-off-by: mehdi <mehdi at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested merging PERSO_NAME to PERSO_NAME and PERSO_NAME to CORPO_NAME.

-- 
You are receiving this mail because:
You are watching all bug changes.