[Koha-bugs] [Bug 18076] Error when placing a hold and holds per record is set to 999

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 8 22:49:12 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18076

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60021|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 60041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60041&action=edit
[SIGNED OFF] Bug 18076: Replace holds_to_place_count with an input type=text

>From http://www.template-toolkit.org/docs/manual/Directives.html#section_WHILE

"""
The Template Toolkit uses a failsafe counter to prevent runaway WHILE loops
which
 would otherwise never terminate. If the loop exceeds 1000 iterations then an
undef
exception will be thrown, reporting the error:

WHILE loop terminated (> 1000 iterations)

The $Template::Directive::WHILE_MAX variable controls this behaviour and can be
set
to a higher value if necessary.
"""

I do not think we want to increase this value, and I do not think we want to
display a
dropdown list with 1000 entries.

This patch replaces the dropdown list with an input text.

Test plan:
- Set circulation conditions - holds per record = 999
- Search for record with items
- Go to the holds tab
- Search for a patron
- Verify that when you send your search, the 'internal server error' is not
shown
and you see the input text.
You should be able to enter a value > than 999 and < 1

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list