[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 10 12:19:01 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60103|0                           |1
        is obsolete|                            |

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 60109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60109&action=edit
Bug 16749: Adjust xmlstarlet calls in koha-functions

In various scripts we use xmlstarlet to extract values from koha-conf.
If we call xmlstarlet on non-existing entries in koha-conf, this may
however result in silently failing scripts.
A function run_safe_xmlstarlet is added for situations where the entry
might not be there. No need to use it everywhere rightaway.

This patch only adjusts koha-functions and modifies the xmlstarlet calls
for dev_install and zebra_loglevels.

Test plan:
[1] Apply the patch for koha-plack too.
[2] Copy koha-functions.sh and koha-plack from clone to default locations.
[3] Start and stop koha-plack while you have dev_install in koha-conf.
    Verify with ps aux|grep plack.
[4] Rename dev_install to nodev_install and start/stop koha-plack.
    Verify with ps aux|grep plack.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested on a Debian VM and with a Windows kohadevbox :)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list