[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Feb 14 13:21:20 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60129|0                           |1
        is obsolete|                            |

--- Comment #42 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 60193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60193&action=edit
Bug 16749: Adjust xmlstarlet calls in koha-functions

In various scripts we use xmlstarlet to extract values from koha-conf.
If we call xmlstarlet on non-existing entries in koha-conf, this may
however result in silently failing scripts (when set -e is in effect).

A function run_safe_xmlstarlet is added for situations where the entry
might not exist. It will not halt execution.

This patch only adjusts koha-functions.sh and modifies the xmlstarlet calls
for dev_install and zebra_loglevels.

Note: The function does not need to check file existence. If the file does
not exist, xmlstarlet warns about it; the function returns empty string,
but does not set an error exit status.

Test plan: See second patch ("koha-plack adjustments").

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Tested in a package installation of master+16749

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list