[Koha-bugs] [Bug 18111] Import default framework is broken

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 15 01:15:29 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18111

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 60216
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60216
Bug 18111: Fix import of default framework

Review of attachment 60216:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18111&attachment=60216)
-----------------------------------------------------------------

Overall, I like this cleaner code.

::: admin/import_export_framework.pl
@@ +53,5 @@
>  ## Exporting
>  if ($action eq 'export' && $input->request_method() eq 'GET') {
>      my $strXml = '';
> +    my $format = $input->param('type_export_' . $framework_name);
> +    ExportFramework('', \$strXml, $format);

Shouldn't this be $frameworkcode? You split the code and name logic, so the
code is set properly.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list