[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Feb 22 12:08:37 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941

--- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 60546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60546&action=edit
Bug 17941 add tests to cover the optimization of the nested loop

the new code skip testing for more borrowers if the item can't be renewed
this require more tests for the case where 2+ items are reserved.

I tried to add 1 more reserve to the main test suit, but too many other tests
rely on specific holds, and I couldn't get around it.

Instead, I added a subtest that consider the specific simple case and leave the
other test cases exactly has they were designed.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended-patch: Just fix 3 indendations

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list