[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |In Discussion

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
This is the first column:

[% IF itemloo.not_holdable %]
    [% IF itemloo.not_holdable == 'damaged' %]
        Item damaged
    [% ELSIF itemloo.not_holdable == 'ageRestricted' %]
        Age restricted
    [% ELSIF itemloo.not_holdable == 'tooManyHoldsForThisRecord' %]
        Exceeded max holds per record
    [% ELSIF itemloo.not_holdable == 'tooManyReserves' %]
        Too many holds
    [% ELSIF itemloo.not_holdable == 'notReservable' %]
        Not holdable
    [% ELSIF itemloo.not_holdable == 'cannotReserveFromOtherBranches' %]
        Patron is from different library
    [% ELSIF itemloo.not_holdable == 'itemAlreadyOnHold' %]
        Patron already has hold for this item
    [% ELSE %]
        [% itemloo.not_holdable %]
    [% END %]
[% END %]

This is what Marc V added:

<td>
    [% IF ( itemloo.itemlost ) %]Lost[% END %]
    [% IF ( itemloo.damaged ) %]Damaged[% END %]
    [% IF ( itemloo.withdrawn ) %]Withdrawn[% END %]
</td>

I think there are some underlying design issues which require further thought
or at least explanation. It makes little sense to me to have two columns
displaying something about the fact that it is damaged. It also is confusing
that itemlost, damaged, and withdrawn would be in the same column. I didn't
read the code deeper.

-- 
You are receiving this mail because:
You are watching all bug changes.