[Koha-bugs] [Bug 17708] Renewal log seems empty

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17708

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The test does not pass for me, I guess it is because you forget to mock pref.
What you need to do is:

  mock_preference('RenewalLog', 0)
  AddRenewal
  test that there is no log added
  mock_preference('RenewalLog', 1)
  AddRenewal
  test that 1 log has been added

IMO the test should be
  is ($new_log_size, $old_log_size +1, '');
which make more sense than
  is ($new_log_size - 1, $old_log_size, '');

-- 
You are receiving this mail because:
You are watching all bug changes.