[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comments:

 FAIL   Koha/Patrons.pm
   FAIL   pod
                *** ERROR:
                empty =head3
                 in file Koha/Patrons.pm

The year 2999 in Patrons.pm should not be there. Joubu promises to fix it on a
new report. See IRC :) Please add a link.

tools/cleanborrowers.pl
+use C4::Members;        # GetBorrowersWhoHavexxxBorrowed.
Not sure if you need this module any more. Seems not.

search_patrons_to_anonymise
anonymise_issue_history
I'd rather have a parameter hash here now instead of these individual ones.
There will be another parameter some day.
Yes, article_requests_finished should have it too :)

Typo should return Koha::Patrons => Patron in t/db_dependent/Koha/Patrons.t

-- 
You are receiving this mail because:
You are watching all bug changes.