[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 24 12:37:56 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #39)
> QA Comments:
> 
>  FAIL   Koha/Patrons.pm
>    FAIL   pod
>                 *** ERROR:
>                 empty =head3
>                  in file Koha/Patrons.pm

Fixed!

> The year 2999 in Patrons.pm should not be there. Joubu promises to fix it on
> a new report. See IRC :) Please add a link.

It's not in module, but opac-privacy. I will!

> tools/cleanborrowers.pl
> +use C4::Members;        # GetBorrowersWhoHavexxxBorrowed.
> Not sure if you need this module any more. Seems not.

I remove the GetBorrowersWhoHavexxxBorrowed part, caused by a bad merge
conflict (re-edited original patch). C4::Members is still used
(GetBorrowersToExpunge)

> search_patrons_to_anonymise
> anonymise_issue_history
> I'd rather have a parameter hash here now instead of these individual ones.
> There will be another parameter some day.
> Yes, article_requests_finished should have it too :)

Done in last patch.

> Typo should return Koha::Patrons => Patron in t/db_dependent/Koha/Patrons.t

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list