From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 05:23:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2017 04:23:10 +0000 Subject: [Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 --- Comment #9 from M. Tompsett --- Comment on attachment 56662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56662 Bug 17467: Add koha-zebra script to handle Zebra daemons Review of attachment 56662: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17467&attachment=56662) ----------------------------------------------------------------- ::: debian/scripts/koha-zebra @@ +135,5 @@ > + > + if is_zebra_running ${name}; then > + > + stop_zebra ${name} && \ > + start_zebra ${name} This logic is failing. The stop always runs, but the start never does. Remember 0 success, but 0 && foo is short-circuited logic. Also, missing verbose check to print a nice informational message about Restarting Zebra. @@ +148,5 @@ > +zebra_status() > +{ > + local name=$1 > + > + if is_zebra_running; then missing $name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 05:24:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2017 04:24:44 +0000 Subject: [Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 05:27:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2017 04:27:42 +0000 Subject: [Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 --- Comment #10 from M. Tompsett --- Also, while I understand the change of logic makes sense in terms of the verbose switch, the script before defaulted to verbose, so perhaps the switch should be silent? That's not a Failed QA issue for me, but the ones in comment #9 are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 08:22:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2017 07:22:06 +0000 Subject: [Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 --- Comment #11 from M. Tompsett --- Created attachment 58550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58550&action=edit Bug 17467: Restart failing, missing instance parameter This follow up should make it work. Perhaps there is a more elegant way, but wanted to generate something that works. Before this patch, the --restart stops Zebra, but does not restart it. After, it does restart. Before this patch, the --status gives nasty long help. After this patch, reasonable output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 08:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2017 07:22:03 +0000 Subject: [Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 22:52:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2017 21:52:58 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris.kirby at ilsleypubliclib | |rary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 1 23:57:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jan 2017 22:57:59 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I am not sure if this is a change libraries want in general - libraries are handling holds on shelf items differently, like some say if a patron gets to it first, they should have it (I think that's a pref). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 10:44:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 09:44:45 +0000 Subject: [Koha-bugs] [Bug 13193] Discussion: strategy for diagnosing memcache issues. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #1 from Olli-Antti Kivilahti --- Interesting find. Do you know if memcached corrupted all the key-values inside it or if this was an isolated incident which only affected your specific data-structure? We could add a static checknumber (not calculated from the data) after every key and val we push to memcached. This shouldn't have much of an overhead and we could check that the last character in a key or a value must be for ex '!' This would protect against corruption. We can log the incident using log4perl and statistize it on a longer duration to find out if we need to further improve the reliability of memcached? Offtopic: Cache::Memcached::Fast doesn't have a maintainer any more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:22:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:22:02 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #22 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:22:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:22:48 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:38:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:38:03 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:38:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:38:19 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 --- Comment #52 from Jonathan Druart --- Created attachment 58552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58552&action=edit Bug 17234: Test the column and constraint non-existence Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:38:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:38:10 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58548|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 58551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58551&action=edit Bug 17234: Two new functions lack tests This adds two tests to t/db_dependent/Installer.t TEST PLAN --------- 1) Apply patch 2) prove -v t/db_dependent/Installer.t -- column and constraint tests were added. 3) run koha qa test tools Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:39:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:39:11 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #53 from Jonathan Druart --- Skipping SO for the 2 last patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:42:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:42:47 +0000 Subject: [Koha-bugs] [Bug 17550] Display additional patron data in patron suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |theod at lib.auth.gr |ity.org | Status|Signed Off |ASSIGNED --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > Theodoros, do you want me to change the name and email address used in the > patch? (In reply to Jonathan Druart from comment #14) > This value is not used anywhere else, why do you want to display it there? > To me it's not consistent to display the initials in only one place, I guess > the problem is the same on the other patron search results. Waiting for answers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:44:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:44:42 +0000 Subject: [Koha-bugs] [Bug 17164] Software error when enrolment fee or reserve fee are too high (Patron categories) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17164 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:43:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:43:39 +0000 Subject: [Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:45:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:45:00 +0000 Subject: [Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #23 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:45:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:45:11 +0000 Subject: [Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:51:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:51:13 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #26 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:55:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:55:14 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #10 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #9) > (In reply to Jonathan Druart from comment #8) > > Why don't you use intranetdir? > > dev_install tells you too that this is a gitified install In that case, does a boolean flag would be enough? If dev_install will always be equal to intranetdir it would make more sense to have a flag. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:57:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:57:24 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 --- Comment #7 from Julian Maurice --- Created attachment 58553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58553&action=edit [3.22.x] Bug 17744: Remove the oai_dc:dcCollection wrapper in OAI responses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 11:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 10:57:51 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:09:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:09:50 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #21 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:12:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:12:57 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:13:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:13:37 +0000 Subject: [Koha-bugs] [Bug 17833] New: Memcached silently fails to _initilize_memcached() on the second time it is invoked Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Bug ID: 17833 Summary: Memcached silently fails to _initilize_memcached() on the second time it is invoked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org When _initilize_memcached() is called the first time, it sets the 'ismemcached'-key and returns 1. When _initilize_memcached() is called the second time, the 'ismemcached'-key already exists and '' is returned (this default to False in Perl). Koha thinks that memcached is not in use and decides to use some other caching mechanism instead. Cache::Memcached::Fast returns undef on server error: https://metacpan.org/pod/Cache::Memcached::Fast#add Koha MUST listen to undefined, instead of False to define whether or not memcached is properly working. Also added simple helpful diagnostics to help identify and log when this memcached server connection problem arises. Here is a small test run to verify this behaviour: root at kohadev:~# echo "fresh memcached start" fresh memcached start root at kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '1' getkey: 'text' root at kohadev:~# echo "val already cached" val already cached root at kohadev:~# perl l.pl 127.0.0.1:4545 1.4.14 (Ubuntu) def : '' getkey: 'text' root at kohadev:~# echo "memcached killed and not responding" memcached killed and not responding root at kohadev:~# perl l.pl undef getkey: '' root at kohadev:~# echo "The return value is undefined" The return value is undefined root at kohadev:~# Here is the code snippet used to test the Memcached-server in the previous example output: kivilahtio at koha_ci_1 /h/k/Koha> cat t.pl use Cache::Memcached::Fast; use Modern::Perl; my $memd = new Cache::Memcached::Fast({ servers => [ '/lxcBindMount/tmp/memcached.sock' ], namespace => 'koha_ci_1:', connect_timeout => 0.2, io_timeout => 0.5, close_on_error => 1, max_failures => 3, failure_timeout => 2, ketama_points => 150, nowait => 1, hash_namespace => 1, }); # Get server versions. my $versions = $memd->server_versions; while (my ($server, $version) = each %$versions) { print "$server $version\n"; } # Store scalars. my $rv = $memd->add('skey', 'text'); print "undef\n" if not defined $rv; print "def : '$rv'\n" if defined $rv; print "getkey: '".$memd->get('skey')."'\n"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:22:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:22:52 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #19 from Jonathan Druart --- (In reply to Jonathan Druart from comment #18) > Does it make sense to add the autofill.js to opac-bottom.js when it's only > used once (in opac-suggestions.tt)? ping? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:28:11 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term link subfield 648$9 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:28:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:28:12 +0000 Subject: [Koha-bugs] [Bug 17833] Memcached silently fails to _initilize_memcached() on the second time it is invoked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 58554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58554&action=edit Bug 17833 - Memcached silently fails to _initilize_memcached() on the second time it is invoked When _initilize_memcached() is called the first time, it sets the 'ismemcached'-key and returns 1. When _initilize_memcached() is called the second time, the 'ismemcached'-key already exists and '' is returned (this default to False in Perl). Koha thinks that memcached is not in use and decides to use some other caching mechanism instead. Cache::Memcached::Fast returns undef on server error: https://metacpan.org/pod/Cache::Memcached::Fast#add Koha MUST listen to undefined, instead of False to define whether or not memcached is properly working. Also added simple helpful diagnostics to help identify and log when this memcached server connection problem arises. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:28:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:28:53 +0000 Subject: [Koha-bugs] [Bug 17833] Memcached silently fails to _initilize_memcached() on the second time it is invoked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:30:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:30:47 +0000 Subject: [Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:30:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:30:51 +0000 Subject: [Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49235|0 |1 is obsolete| | Attachment #56396|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58555&action=edit Bug 16083 Allow cli overrides for makefile settings. Currently the Makefile.pl script only accepts the '--prev-install-log' commandline flag for reading Koha configuration values from the previous installation. The Makefile does not have help output. The aim of this bug report is to add 2 things: - --help output - commandline parameters that should allow automating many of the common settings if desired - when commandline parameters are not passed we simply fall back to the interactive method of old Test Plan: - Run the Makefile without parameters ? the script should work as before. - Run the script with the '-h' flag ? it should output help. - Run the script with any number of additional legal flags ? the script should skip those questions in its interactive mode. Signed-off-by: Nicolas Legrand Reworked the log message with Bugzilla comments. Signed-off-by: Jonathan Druart Amended patch: perltidy GetOptions block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:30:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:30:56 +0000 Subject: [Koha-bugs] [Bug 17681] Existing typos might thow some fees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:31:34 +0000 Subject: [Koha-bugs] [Bug 17833] Memcached silently fails to _initilize_memcached() on the second time it is invoked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:33:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:33:54 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:35:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:35:10 +0000 Subject: [Koha-bugs] [Bug 17550] Display additional patron data in patron suggestion form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17550 --- Comment #16 from Theodoros Theodoropoulos --- > Theodoros, do you want me to change the name and email address used in the > patch? Hmmm... What is the common practice? To use the github (ie almost 'dummy') email or the bugzilla one? > This value is not used anywhere else, why do you want to display it there? > To me it's not consistent to display the initials in only one place, I guess > the problem is the same on the other patron search results. Well, this is the no.1 place where our librarians search manually for patrons to quickly check-out books to (if they don't have their library card with the barcode with them). If they manage to choose the proper patron from this screen (by verifying also the patron Initials -or the Father's name) they avoid unnecessary clicks and possibly-wrong checkouts. The initials are also displayed in the Patron Details screen, so it's not 'only' there... That said, indeed it would be better if this "Initials" information was concatenated in the "Name" column of the patron result list, but I suppose this would be a big change in Koha behavior and should(?) be documented... If, however, you consider that approach to be more consistent, I'll take a look and see how it could be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:43:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:43:44 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- (In reply to Katrin Fischer from comment #6) > This won't get backported to 16.11.x as it is an enhancement. This is actually a bug and was backported to 16.11.x http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=75c3cda017e4998974fad285e21bf63b08e4fce6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:44:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:44:05 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:49:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:49:16 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 12:56:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 11:56:26 +0000 Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:01:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:01:44 +0000 Subject: [Koha-bugs] [Bug 17833] Memcached silently fails to _initilize_memcached() on the second time it is invoked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- You are mixing add and set, replace ->add with ->set in your snippet and it will work as expected. Set will return 1 even if the key already exists. It seems that this is invalid, waiting for Olli's confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:03:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:03:24 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:21:56 +0000 Subject: [Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #25 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:21:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:21:58 +0000 Subject: [Koha-bugs] [Bug 17833] Memcached silently fails to _initilize_memcached() on the second time it is invoked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 --- Comment #3 from Olli-Antti Kivilahti --- Thanks for digging into this Jonathan! You are correct. The culprit was misconfigured socket permission. Same behaviour is expected on any connection issue to the memcached server. I changed the bug title and content to only add warnings when a server/connection problem occurs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:22:38 +0000 Subject: [Koha-bugs] [Bug 17833] Memcached silently fails to _initilize_memcached() on the second time it is invoked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 58556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58556&action=edit Bug 17833 - _initilize_memcached() warns if errors If memcached or the connection to it is misconfigured, show simple warnings to help identify the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:23:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:23:20 +0000 Subject: [Koha-bugs] [Bug 17833] Memcached silently fails to _initilize_memcached() on the second time it is invoked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58554|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:23:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:23:21 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- I get a menu with "Pay", an arrow to open the dropdown, but it is empty. To recreate: - Create a manual invoice - Account tab, click pay - Reverse the payment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:25:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:25:05 +0000 Subject: [Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Memcached silently fails to |_initilize_memcached() |_initilize_memcached() on |warns if errors |the second time it is | |invoked | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:36:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:36:31 +0000 Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Depends on| |12051 --- Comment #16 from Julian Maurice --- For reference, this shortcut has been introduced by bug 12051 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 [Bug 12051] add renew tab to top on staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:36:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:36:31 +0000 Subject: [Koha-bugs] [Bug 12051] add renew tab to top on staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:38:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:38:32 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Pushed to 3.22.x for 3.22.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 13:52:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 12:52:28 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 14:48:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 13:48:00 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #77 from Jonathan Druart --- The patch does not apply, please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 14:56:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 13:56:30 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the |Add the Koha::Patron->holds |Koha::Patron->get_holds |method |method | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 17:07:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 16:07:53 +0000 Subject: [Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 --- Comment #5 from M. Tompsett --- (In reply to M. Tompsett from comment #2) > What about the SRU Biblio and Authority port numbers? This question was never dealt with. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 19:17:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 18:17:23 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Tom?s Cohen Arazi --- This patch was wrong, re-doing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 20:02:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 19:02:39 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 20:02:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 19:02:59 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58526|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 58557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58557&action=edit Bug 17828: Unit tests for Koha::Patron::Attribute->store Unit tests for an overloaded Koha::Patron::Attribute->store that checks attribute type's uniqueness property and raises an exception conveniently. It also tests for repeatable attribute type's property. Test plan on the implementing patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 20:03:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 19:03:11 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58527|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 58558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58558&action=edit Bug 17828: Overload Koha::Patron::Attribute->store to check for unique_id and repeatable This patch introduces a Koha::Patron::Attribute->store method that does the required check for the corresponding Koha::Patron::Attribute::Type and raises an exception if trying to store more than one unique attribute code/value combination, and another exception for non-repeatable attribute types being stored while already existing on the DB. This patch introduces exception definitions for that purpose. To test: - Apply the unit tests patches - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => FAIL: Tests fail - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 20:03:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 19:03:42 +0000 Subject: [Koha-bugs] [Bug 17828] Koha::Patron::Attribute-> store should raise an exception if unique_id is being broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17828 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 21:15:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 20:15:11 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 --- Comment #8 from M. Tompsett --- Comment on attachment 54532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54532 Bug 17138 - UpdateFine() modyfies existing fine records even when there is no need Review of attachment 54532: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17138&attachment=54532) ----------------------------------------------------------------- ::: C4/Overdues.pm @@ +574,4 @@ > # we're updating an existing fine. Only modify if amount changed > # Note that in the current implementation, you cannot pay against an accruing fine > # (i.e. , of accounttype 'FU'). Doing so will break accrual. > + if ( $data->{'amount'} ne sprintf('%.6f', $amount) ) { While this does work, would not a compare_numbers($n1,$n2,$accuracy) function work better? Let's not rely on implicit type conversions for $data->{'amount'}. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 22:57:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 21:57:22 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 --- Comment #9 from Jacek Ablewicz --- (In reply to M. Tompsett from comment #8) > Comment on attachment 54532 [details] [review] > Bug 17138 - UpdateFine() modyfies existing fine records even when there is > no need > > Review of attachment 54532 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Overdues.pm > @@ +574,4 @@ > > # we're updating an existing fine. Only modify if amount changed > > # Note that in the current implementation, you cannot pay against an accruing fine > > # (i.e. , of accounttype 'FU'). Doing so will break accrual. > > + if ( $data->{'amount'} ne sprintf('%.6f', $amount) ) { > > While this does work, would not a compare_numbers($n1,$n2,$accuracy) > function work better? I'm not familiar with this function (compare_numbers), and google doesn't yield any (useful) results; from which module is it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 2 23:59:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jan 2017 22:59:38 +0000 Subject: [Koha-bugs] [Bug 15419] Sipserver problem with stale db handles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |FIXED --- Comment #10 from Srdjan Jankovic --- Closed. Will reopen if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 04:03:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 03:03:43 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett --- (In reply to Jacek Ablewicz from comment #9) > (In reply to M. Tompsett from comment #8) > > Comment on attachment 54532 [details] [review] [review] > > Bug 17138 - UpdateFine() modyfies existing fine records even when there is > > no need > > > > Review of attachment 54532 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: C4/Overdues.pm > > @@ +574,4 @@ > > > # we're updating an existing fine. Only modify if amount changed > > > # Note that in the current implementation, you cannot pay against an accruing fine > > > # (i.e. , of accounttype 'FU'). Doing so will break accrual. > > > + if ( $data->{'amount'} ne sprintf('%.6f', $amount) ) { > > > > While this does work, would not a compare_numbers($n1,$n2,$accuracy) > > function work better? > > I'm not familiar with this function (compare_numbers), and google doesn't > yield any (useful) results; from which module is it? I was implying writing it... like... wait for it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 04:05:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 03:05:01 +0000 Subject: [Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138 --- Comment #11 from M. Tompsett --- Created attachment 58559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58559&action=edit Bug 17138: Add and use comparison function and tests Added C4::Koha::compareNumbers($n1,$n2,$accuracy). Added corresponding tests to t/Koha.t Tweaked C4/Overdues to use the new function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 05:23:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 04:23:55 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #20 from Chris Cormack --- It could be in its own include I guess, but in the opac-bottom.js is better than having it in the template itself. One of things that are annoying about our template structure currently is the js is all over the place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 06:10:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 05:10:55 +0000 Subject: [Koha-bugs] [Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 06:10:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 05:10:58 +0000 Subject: [Koha-bugs] [Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58484|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 58560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58560&action=edit Bug 17824: Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed This subroutine is no longer in used and can be removed. Test plan: git grep GetBorrowersWhoHaveNeverBorrowed must not return any results NOTE: grep -i getborrowerswhohave `find . -type f` works well enough to find the cleanborrowers.pl too. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 06:17:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 05:17:30 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16690 CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- Bug 16690 would make testing this easier, I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 06:17:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 05:17:30 +0000 Subject: [Koha-bugs] [Bug 16690] Installing DB on remote server fails without *.* permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15427 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 07:24:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 06:24:19 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 --- Comment #9 from Katrin Fischer --- Julian, you are right - sorry for the mistake! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 09:27:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 08:27:45 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #16 from Jonathan Druart --- This has been fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 10:28:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 09:28:33 +0000 Subject: [Koha-bugs] [Bug 17291] Add ... syntax to advance_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17291 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- +1 - more consistency and better formatting options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 11:47:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 10:47:44 +0000 Subject: [Koha-bugs] [Bug 17834] New: Change library news text for single-branch libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Bug ID: 17834 Summary: Change library news text for single-branch libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If a library has only 1 branch the 'system-wide' in the text for the news RSS feed can be a bit confusing. Current text: RSS feed for system-wide library news. It would be nice to catch the case of single-branch and show a different text then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 11:47:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 10:47:50 +0000 Subject: [Koha-bugs] [Bug 17834] Change library news text for single-branch libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17834 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:04:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 11:04:00 +0000 Subject: [Koha-bugs] [Bug 17835] New: Move C4::Koha::GetItemTypes to Koha::ItemTypes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Bug ID: 17835 Summary: Move C4::Koha::GetItemTypes to Koha::ItemTypes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:04:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 11:04:10 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17627 [Bug 17627] Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:04:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 11:04:10 +0000 Subject: [Koha-bugs] [Bug 17627] Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17627 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:04:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 11:04:25 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 12:04:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 11:04:25 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17835 --- Comment #2 from Jonathan Druart --- Bug 17835 - Move C4::Koha::GetItemTypes to Koha::ItemTypes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:41:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:41:36 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #1 from Jonathan Druart --- Created attachment 58561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58561&action=edit Bug 17835: Create a ItemtypeLocalization view To properly move C4::Koha::GetItemTypes to Koha::ItemTypes we need DBIx::Class to make a join on the localization table to retrieve the possible translated description of the item types. To do so there are 2 possibilities. The first one would have been to rename the localization table to something like itemtype_localization. That way we could have had a relationship between itemtype_localization.code and itemtypes.itemtype That would have meant to create one table per "entity" (here an entity is itemtype) we allow the translability. There are pros and cons for this choice, so I opt for another solution. The other solution is to create a view on top of this localization table. With this new view we can define the missing relationship. That sounds like a quite clean solution and easy to implement. Once we have this relationship, the Koha::ItemTypes->search_with_localization will join on this view an return the same result as GetItemTypes( style => 'array' ). To replace GetItemtypes( style => 'hash' ) which is the default behavior of this subroutine, we can do something like: my $itemtypes = Koha::ItemTypes->search_with_localization; my %itemtypes = map { $_->{itemtype} => $_ } @{ $itemtypes->unblessed }; This patchset must not introduce big changes but it changes certain behaviors (which were wrong) in some scripts. Indeed sometimes the descriptions of the item types were not the translated ones. Moreover it happens that the item types displayed in a dropdown list were not ordered by translated description, but by description of code (itemtypes.itemtype value). These 2 behaviors are what we expect. Test plan: Bugs will be hard to catch since these patches change a lot of file, it will be easier to read the diff and catch possible typos or logic errors. However signoffers can focus on modified files and the item types values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:41:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:41:33 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:41:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:41:39 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #2 from Jonathan Druart --- Created attachment 58562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58562&action=edit Bug 17835: Do not reselect translated_description if comes from search_with_localization If the Koha::ItemType object has been instanciated from a call to Koha::ItemTypes->search_with_localization, we already have the translated_description value. So there is no need to fetch it again from the DB. This is what this trick does: if the translated_description column exist in the DBIx::Class result source's column list, that means the value has already been retrieved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:41:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:41:48 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #4 from Jonathan Druart --- Created attachment 58564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58564&action=edit Bug 17835: Remove the subroutine GetItemTypes At this point the subroutine is no longer in used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:41:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:41:43 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #3 from Jonathan Druart --- Created attachment 58563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58563&action=edit Bug 17835: Replace GetItemTypes with Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:41:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:41:51 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #5 from Jonathan Druart --- Created attachment 58565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58565&action=edit Bug 17835: Add an additional LEFT JOIN condition using DBIx::Class The previous query was wrong. If an item type did not contain the translation in the interface's language, the ->search_with_localization did not return it at all. What we need is definitely to add a second condition on the join. For reference: http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/Relationship/Base.pm#condition https://blog.afoolishmanifesto.com/posts/dbix-class-parameterized-relationships/ That sounds hacky but seems to be the DBIx::Class path to follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:47:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:47:32 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > (In reply to Marcel de Rooy from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > Why don't you use intranetdir? > > > > dev_install tells you too that this is a gitified install > > In that case, does a boolean flag would be enough? If dev_install will > always be equal to intranetdir it would make more sense to have a flag. What > do you think? That sounds reasonable ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 13:51:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 12:51:09 +0000 Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #8) > I think we could use this for now, and removed it later. Back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:14:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 14:14:32 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Owen Leonard --- Auto-merging Koha/Schema/Result/BorrowerModification.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/BorrowerModification.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:52:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 14:52:09 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:52:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 14:52:56 +0000 Subject: [Koha-bugs] [Bug 15277] Add Template Toolkit syntax for slips and notices to editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 15:53:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 14:53:36 +0000 Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:09:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:09:11 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Check out error made by the |Return focus to barcode |cursor not returning at |field after toggling |"enter item barcode" space |on-site checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:09:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:09:17 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:09:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:09:27 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:15:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:15:22 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:15:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:15:24 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 --- Comment #1 from Owen Leonard --- Created attachment 58566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58566&action=edit Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking the "on-site checkouts" box the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable the OnSiteCheckouts system preference. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the "On-site checkout" label or checkbox. - Confirm that the focus has moved to the barcode field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:28:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:28:43 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|make the 'print summary' a |Make the 'print summary' a |custom slip/notice |custom slip/notice -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:29:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:29:00 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 --- Comment #2 from Katrin Fischer --- Still valid and wanted :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:29:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:29:14 +0000 Subject: [Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:29:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:29:24 +0000 Subject: [Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:31:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:31:37 +0000 Subject: [Koha-bugs] [Bug 16922] Add RewriteRule to apache-shared-intranet for dev package installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16922 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #2 from Marcel de Rooy --- If nobody cares about it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:31:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:31:46 +0000 Subject: [Koha-bugs] [Bug 16922] Add RewriteRule to apache-shared-intranet for dev package installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16922 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:38:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:38:58 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480 ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #13 from Marcel de Rooy --- Have been asking assistance for months. Abandoning this development. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:39:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:39:08 +0000 Subject: [Koha-bugs] [Bug 13438] Convert normarc framework plugins to new style (see also 10480 ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13438 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:45:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:45:54 +0000 Subject: [Koha-bugs] [Bug 13479] Add option to add/ remove biblios from list of books with forced item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|BLOCKED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:46:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:46:03 +0000 Subject: [Koha-bugs] [Bug 13479] Add option to add/ remove biblios from list of books with forced item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:46:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:46:23 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:46:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:46:24 +0000 Subject: [Koha-bugs] [Bug 13479] Add option to add/ remove biblios from list of books with forced item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 Bug 13479 depends on bug 13478, which changed state. Bug 13478 Summary: Force item holds only for specific biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:46:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:46:32 +0000 Subject: [Koha-bugs] [Bug 13478] Force item holds only for specific biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:47:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:47:50 +0000 Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail cleanup_database.pl --mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:47:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:47:57 +0000 Subject: [Koha-bugs] [Bug 17159] Cron: whats the use of --noemail cleanup_database.pl --mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17159 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:51:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:51:58 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #50 from Owen Leonard --- (In reply to Owen Leonard from comment #46) > I tested this with a patron record which had two attributes with data > already stored: One editable in the OPAC, the other not. Editing is working correctly now, but now I don't see the value for my non-editable attribute. It only shows the label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:56:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:56:08 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:56:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:56:08 +0000 Subject: [Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15822 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:57:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:57:02 +0000 Subject: [Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WORKSFORME --- Comment #9 from Marcel de Rooy --- Main change has been used in 15822. So forget the rest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:57:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:57:02 +0000 Subject: [Koha-bugs] [Bug 17512] Improve handling dates in C4::Items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17512 Bug 17512 depends on bug 17502, which changed state. Bug 17502 Summary: Resolve internal server error on 0000-00-00 (with Plack) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 16:57:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 15:57:16 +0000 Subject: [Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:09:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:09:10 +0000 Subject: [Koha-bugs] [Bug 17836] New: (ILSDI) 'charges' always '1' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Bug ID: 17836 Summary: (ILSDI) 'charges' always '1' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Due to a typo, the 'charges' attribute will always return 1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:18:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:18:35 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 --- Comment #6 from Owen Leonard --- (In reply to Katrin Fischer from comment #5) > like some say if a patron gets to > it first, they should have it Yes, that's how it works at my library. > (I think that's a pref) AllowItemsOnHoldCheckout? Would it make sense if this change were tied to that preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:23:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:23:32 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:23:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:23:34 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58472|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 58567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58567&action=edit [SIGNED-OFF] Bug 17821 - due date in intranet search results should use TT date plugin Intranet search results displays due date from item onloan. This should use the TT date plugin. Test plan : - set syspref dateformat not on yyyy-mm-dd, for example dd/mm/yyyy - checkout an item - at intranet, perform a search where you see the item => You must see : "date due : dd/mm/yyyy" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:27:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:27:30 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 58568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58568&action=edit Bug 17836: (ILSDI) Regression test Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:28:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:28:17 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:28:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:28:33 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 58569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58569&action=edit Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly This trivial fix corrects a typo on C4/ILSDI/Services.pm. It was hidden because the tests for ILSDI only cover the 'attributes' portion of the response. I added regression tests for this. To test: - Have the regression test patch applied - Run: $ prove t/db_dependent/ILSDI_Services.t => FAIL: Tests fail because 'charges' is always set to 1 - Apply the patch - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:45:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:45:50 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45824|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 58570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58570&action=edit Bug 15253 - Add Koha::Logger based logging for SIP2 Original version from khall rebased and modified for Log::Log4perl MDC Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:46:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:46:18 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45825|0 |1 is obsolete| | --- Comment #12 from Olli-Antti Kivilahti --- Created attachment 58571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58571&action=edit Bug 15253 - Log stderr via Koha::Logger as well By logging stderr to the log file, we can much more easily find and debug errors in the SIP server. Stderr has its own category STDERR so these messages can easily be filtered out of the log if need be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:46:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:46:35 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45826|0 |1 is obsolete| | --- Comment #13 from Olli-Antti Kivilahti --- Created attachment 58572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58572&action=edit Bug 15253 - Remove use of syslog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 17:52:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 16:52:04 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58572|0 |1 is obsolete| | --- Comment #14 from Olli-Antti Kivilahti --- Created attachment 58573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58573&action=edit Bug 15253 - Remove use of syslog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:34:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 17:34:37 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #3 from M. Tompsett --- Comment on attachment 58569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58569 Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly Review of attachment 58569: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17836&attachment=58569) ----------------------------------------------------------------- ::: C4/ILSDI/Services.pm @@ -376,4 @@ > > # Cleaning the borrower hashref > my $flags = C4::Members::patronflags( $borrower ); > - $borrower->{'charges'} = $flags>{'CHARGES'}->{'amount'}; OH MY! What a horrid typo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:36:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 17:36:50 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58568|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 58574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58574&action=edit Bug 17836: (ILSDI) Regression test Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:37:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 17:37:02 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58569|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 58575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58575&action=edit Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly This trivial fix corrects a typo on C4/ILSDI/Services.pm. It was hidden because the tests for ILSDI only cover the 'attributes' portion of the response. I added regression tests for this. To test: - Have the regression test patch applied - Run: $ prove t/db_dependent/ILSDI_Services.t => FAIL: Tests fail because 'charges' is always set to 1 - Apply the patch - Run: $ prove t/db_dependent/ILSDI_Services.t => SUCCESS: Tests pass - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:38:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 17:38:11 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off --- Comment #6 from M. Tompsett --- Followed test plan in comment #5 and also ran koha-qa test tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 18:42:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 17:42:25 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:03:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:03:16 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #3) > Comment on attachment 58569 [details] [review] > Bug 17836: (ILSDI) Make GetPatronInfo fill 'charges' correctly > > Review of attachment 58569 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/ILSDI/Services.pm > @@ -376,4 @@ > > > > # Cleaning the borrower hashref > > my $flags = C4::Members::patronflags( $borrower ); > > - $borrower->{'charges'} = $flags>{'CHARGES'}->{'amount'}; > > OH MY! What a horrid typo. This should have been cough by our test suite, but we haven't reached ILSID yet in our attempt to improve coverage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:09:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:09:39 +0000 Subject: [Koha-bugs] [Bug 17837] New: Correct some authorised values in fr-FR Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 Bug ID: 17837 Summary: Correct some authorised values in fr-FR Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org Bug 17809 corrects ER, but missed CC, GQ, and PK. Remove and edit duplicates and correct typos. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:11:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:11:28 +0000 Subject: [Koha-bugs] [Bug 17837] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:11:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:11:30 +0000 Subject: [Koha-bugs] [Bug 17837] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 --- Comment #1 from M. Tompsett --- Created attachment 58576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58576&action=edit Bug 17837 correct authorisation values for fr-FR Bug 17809 corrected ER, but failed to correct: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:12:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:12:14 +0000 Subject: [Koha-bugs] [Bug 17837] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com Severity|enhancement |minor Depends on| |17809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 [Bug 17809] ER country twice in fr-FR database files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:12:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:12:14 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 [Bug 17837] Correct some authorised values in fr-FR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:27:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:27:00 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #4 from M. Tompsett --- Going to sign off and put the issues raised in comment #2 into bug 17837. Comment #3 may not have any relevance, as the two french words clearly refer to different things and very well may be valid. I'll leave that to a native French speaker to determine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:31:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:31:59 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:32:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:32:02 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58390|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 58577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58577&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythr?e" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / Erythr?e NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:39:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:39:05 +0000 Subject: [Koha-bugs] [Bug 16018] merges not modifying biblios properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 --- Comment #8 from M. Tompsett --- Created attachment 58578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58578&action=edit Bug 16018 - Merges in AuthoritiesMarc do not work Skip ModAuthority sub in AuthoritiesMarc.pm to make merges work properly. Test plan: 1) Go to authority, search for anything 2) Click merge on two authorities of the same type that are used at least one time 3) Validate which subfields are corresponding to each authorities in the biblios that uses them 4) Do the whole merge process 5) Validate that the biblios are updated properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:39:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:39:51 +0000 Subject: [Koha-bugs] [Bug 16018] merges not modifying biblios properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #48889|0 |1 is obsolete| | --- Comment #9 from M. Tompsett --- Comment on attachment 48889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48889 Bug16018 - Skip ModAuthority sub in AuthoritiesMarc.pm to make merges work properly This wasn't a proper patch format which was easy to test. I, Mark Tompsett, fixed that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:49:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:49:53 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 19:49:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 18:49:55 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58464|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 58579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58579&action=edit [SIGNED-OFF] Bug 17817: Temporarily remove select2 where is is used If you try to clone a field (or subfield) which contains at least a subfield linked to authorized values, you will get a JS error and the field will not be cloned. I have failed trying to propose a fix in a reasonable delay so I prefer to simply deactivate the feature. Test plan: Edit a bibliographic record, an item and use the batch item modification tool. You should see simple selects Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 20:45:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 19:45:12 +0000 Subject: [Koha-bugs] [Bug 14606] Donate to the Koha International Fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14606 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Liz Rea --- Still waiting for information, as the issues with THT are still ongoing. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:03:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:03:19 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:03:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:03:28 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56286|0 |1 is obsolete| | --- Comment #78 from Charles Farmer --- Created attachment 58580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58580&action=edit Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:03:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:03:42 +0000 Subject: [Koha-bugs] [Bug 14972] Limit by availability does not return results if *any* items are on-loan or lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14972 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in --- Comment #2 from Indranil Das Gupta --- This bug seems to be present in 16.11 as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:22:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:22:34 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #51 from Tom?s Cohen Arazi --- Created attachment 58581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58581&action=edit Bug 13757: (followup) Fix authorized value display when opac_display & not opac_editable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:26:19 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #79 from M. Tompsett --- Comment on attachment 58580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58580 Bug 11879: Add the "Main contact method" field in borrower informations. Review of attachment 58580: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11879&attachment=58580) ----------------------------------------------------------------- I don't believe the Borrower.pm, BorrowerModification.pm, and Deletedborrower.pm were generated using the appropriate scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:28:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:28:28 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:51:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:51:50 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 21:51:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 20:51:45 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 22:36:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 21:36:32 +0000 Subject: [Koha-bugs] [Bug 17838] New: Availability limit broken until an item has been checked out Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Bug ID: 17838 Summary: Availability limit broken until an item has been checked out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The availability limit in the OPAC will return on results, until an item has been checked out for the first time. >From the mailing list: The index doesn't exist, so the query fails, the index just has to exist (which it does as soon as something is circulated, it will continue to work if you return that item, the index doesn't go away, unless you do a full reindex and have not circulated anything ever) In practice people don't run into this much at all. However the fix is just in the ccl.properties file /etc/koha/zebradb/ccl.properties change line 1032 From onloan 1=8024 to onloan 1=8024 14=1 And it will work even if you library has never done a circulation operation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 22:37:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 21:37:53 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 22:49:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 21:49:20 +0000 Subject: [Koha-bugs] [Bug 17839] New: 'Print summary' totals charges and fines, but only shows charges Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17839 Bug ID: 17839 Summary: 'Print summary' totals charges and fines, but only shows charges Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When printing the summary from a patron account the table of checkouts has a column 'charges' that is totaled in the last line of the table. It shows the rental charges for each item, but the total also includes the overdue fines, so that the column doesn't add up. It would be better to have a separate column for the fines and have correct totals for each column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 22:54:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 21:54:36 +0000 Subject: [Koha-bugs] [Bug 17840] New: Add classes to internal and public notes in checkouts table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Bug ID: 17840 Summary: Add classes to internal and public notes in checkouts table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In order to be able to style the internal and public notes so they stand out more, it would be good if each of them had their own class. At the moment, there seems something not quite right, as both have an empty class="". To test: 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 22:54:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 21:54:44 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 22:55:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 21:55:34 +0000 Subject: [Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 23:18:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 22:18:48 +0000 Subject: [Koha-bugs] [Bug 17841] New: Can't use indexname "acqdate, st-date-normalized" in keyword search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17841 Bug ID: 17841 Summary: Can't use indexname "acqdate,st-date-normalized" in keyword search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It is possible to search for acquisition date from the advanced search in staff. But if you try to use the index name for an 'expert search' in the keyword search field, no results will come up. Example: Advanced search > acquisition date: 2016-12* (or whatever works for you) This should give correct results. Enter acqdate,st-date-normalized: 2016-12* into the keyword search - no results will appear. Something seems to be missing in order to make it possible to construct the same search manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 23:18:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 22:18:57 +0000 Subject: [Koha-bugs] [Bug 17841] Can't use indexname "acqdate, st-date-normalized" in keyword search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17841 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 3 23:36:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 22:36:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #342 from Katrin Fischer --- It would be nice to get an update on the history.txt file with the recent releases, devs, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:08:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 23:08:55 +0000 Subject: [Koha-bugs] [Bug 17842] New: Broken diacritics on records exported as MARC from cart on reimport Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Bug ID: 17842 Summary: Broken diacritics on records exported as MARC from cart on reimport Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I have experienced this problem for a while now in different versions, but I am not quite sure what's going wrong: - Add a records with diacritics, such as German umlauts ??? to your cart - Download the record from the cart in MARC - Import the record into Koha using the staged MARC import - Verify that the MARC preview doesn't work in the staged MARC import table - Verify that the umlauts didn't import correctly When using the 'import record' feature in Rancor, the diacritics also appear broken, fields containing diacritics get cut off and other oddities happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:11:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 23:11:21 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:36:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 23:36:52 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- These patches have been pushed to 16.11.x, will be in 16.11.02 . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 00:40:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jan 2017 23:40:51 +0000 Subject: [Koha-bugs] [Bug 17246] GetPreparedLetter should not allow multiple FK defined in arrayref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x, will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 08:12:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 07:12:51 +0000 Subject: [Koha-bugs] [Bug 17520] Add serialsUpdate.pl to the list of regular cron jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- It appears to me that with this patch the job would be automatically be activated for package installations? I think this makes it more suitable for a feature release. Please let me know, if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 08:27:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 07:27:32 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 08:50:05 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #15 from Olli-Antti Kivilahti --- Created attachment 58582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58582&action=edit Bug 15253 - Add Koha::Logger based logging for SIP2 - Revert testing changes Remove changes intended to help test the feature. -Put Koha::Logger back to silently failing mode -Revert to log using syslog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:53:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 08:53:33 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #80 from Jonathan Druart --- - Schema files should be moved to a separate patch - Changes to kohastructure are wrong, please double check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 08:59:47 +0000 Subject: [Koha-bugs] [Bug 14972] Limit by availability does not return results if *any* items are on-loan or lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17278 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 09:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 08:59:47 +0000 Subject: [Koha-bugs] [Bug 17278] Limit to available items returns 0 results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14972 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:30:01 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:30:01 +0000 Subject: [Koha-bugs] [Bug 17843] New: Move C4::Koha::getitemtypeinfo to Koha::ItemTypes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Bug ID: 17843 Summary: Move C4::Koha::getitemtypeinfo to Koha::ItemTypes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:30:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:30:35 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17843 --- Comment #3 from Jonathan Druart --- Bug 17843 - Move C4::Koha::getitemtypeinfo to Koha::ItemTypes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:30:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:30:35 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:34:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:34:32 +0000 Subject: [Koha-bugs] [Bug 15329] Show budget in addition to fund for late orders in acquisition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15329 --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:43:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:43:58 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 --- Comment #1 from Jonathan Druart --- Created attachment 58583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58583&action=edit Bug 17843: Repace C4::Koha::getitemtypeinfo with Koha::ItemTypes The C4::Koha::getitemtypeinfo subroutine did the almost same job as GetItemTypes. On top of that it returned the imageurl value processed by C4::Koha::getitemtypeimagelocation. This value is only used from the 2 [opac-]shelves.pl scripts. Then it's better not retrieve it only when we need it. Test plan: Play with the different scripts touched by this patch and focus on item types. The same description as prior to this patch must be displayed. Note that sometimes it is not the translated description which is displayed, but that should be fixed on another bug report. Indeed we do not expect this patch to change any behaviors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:43:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:43:53 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:44:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:44:04 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 --- Comment #2 from Jonathan Druart --- Created attachment 58584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58584&action=edit Bug 17843: Remove C4::Koha::getitemtypeinfo At this point there should not be any calls to this subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:45:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:45:48 +0000 Subject: [Koha-bugs] [Bug 3150] Text of any email sent from Koha should be editable from web interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #4 from Katrin Fischer --- *** Bug 7983 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:45:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:45:48 +0000 Subject: [Koha-bugs] [Bug 7983] Emailing lists text should be controlled by notices & slips tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7983 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 3150 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:53:02 +0000 Subject: [Koha-bugs] [Bug 6392] Highlighting hold requests upon checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6392 --- Comment #2 from Katrin Fischer --- Is this still valid with the new modal windows? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:57:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:57:42 +0000 Subject: [Koha-bugs] [Bug 10164] way to do substrings on notices/slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14757 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:57:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:57:42 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10164 --- Comment #62 from Katrin Fischer --- Once implemented shoudl also fix bug 10164. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:58:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:58:05 +0000 Subject: [Koha-bugs] [Bug 10164] way to do substrings on notices/slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10164 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- That should be possible with the TT syntax for slips and notices - bug 14757. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 10:58:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 09:58:38 +0000 Subject: [Koha-bugs] [Bug 9599] printable work slip on receive in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9599 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|printable work slip on |printable work slip on |receipt |receive in acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:02:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:02:10 +0000 Subject: [Koha-bugs] [Bug 6392] Highlighting hold requests upon checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I think bug 11360 addressed this. *** This bug has been marked as a duplicate of bug 11360 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:02:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:02:10 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bedmondsfcl at gmail.com --- Comment #63 from Katrin Fischer --- *** Bug 6392 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:02:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:02:56 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:03:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:03:44 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:05:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:05:17 +0000 Subject: [Koha-bugs] [Bug 5851] SIP Slips printed in wrong circumstances -- Local hold and no hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5851 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- There is not enough information here to make it possible to reproduce the problem. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:12:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:12:14 +0000 Subject: [Koha-bugs] [Bug 17795] Exporting late orders from translated templates is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17795 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #4 from Katrin Fischer --- Marking duplicate - patch on 16914 fixed both problems! *** This bug has been marked as a duplicate of bug 16914 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:12:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:12:14 +0000 Subject: [Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 --- Comment #26 from Katrin Fischer --- *** Bug 17795 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:16:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:16:20 +0000 Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 --- Comment #21 from Katrin Fischer --- Wondering if we should change this to a bug report instead of enh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:36:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:36:31 +0000 Subject: [Koha-bugs] [Bug 17844] New: Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Bug ID: 17844 Summary: Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:38:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:38:18 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:38:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:38:18 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17844 --- Comment #12 from Jonathan Druart --- Bug 17844 - Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:55:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:55:55 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:56:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:56:04 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 --- Comment #1 from Jonathan Druart --- Created attachment 58585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58585&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 11:56:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 10:56:13 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 --- Comment #2 from Jonathan Druart --- Created attachment 58586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58586&action=edit Bug 17844: Remove C4::Koha::get_notforloan_label_of -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:27:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:27:47 +0000 Subject: [Koha-bugs] [Bug 2045] Network Printers Setting Does Nothing? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17845 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:27:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:27:47 +0000 Subject: [Koha-bugs] [Bug 17845] New: Remove printer related code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Bug ID: 17845 Summary: Remove printer related code Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org It seems that we want to keep this code, just open this bug report for reference. See Bug 8352 - Add automatic printing of 'hold to pull' notices Bug 16764 - Update printers administration page Bug 2045 - Network Printers Setting Does Nothing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:27:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:27:47 +0000 Subject: [Koha-bugs] [Bug 16764] Update printers administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17845 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:27:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:27:47 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17845 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:28:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:28:39 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17845 --- Comment #4 from Jonathan Druart --- Bug 17845 - Remove printer related code (Not valid?) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 [Bug 17845] Remove printer related code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:28:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:28:39 +0000 Subject: [Koha-bugs] [Bug 17845] Remove printer related code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:37:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:37:22 +0000 Subject: [Koha-bugs] [Bug 17846] New: Remove C4::Koha::get_infos_of Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Bug ID: 17846 Summary: Remove C4::Koha::get_infos_of Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:38:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:38:20 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:38:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:38:20 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17844 --- Comment #5 from Jonathan Druart --- Bug 17844 - Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha::AuthorisedValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:48:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:48:45 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:48:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:48:49 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 --- Comment #1 from Jonathan Druart --- Created attachment 58587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58587&action=edit Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 12:50:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 11:50:04 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58587|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 58588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58588&action=edit Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:28:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:28:10 +0000 Subject: [Koha-bugs] [Bug 17847] New: Move C4::Koha::GetAuthvalueDropbox to Koha:: AuthorisedValues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Bug ID: 17847 Summary: Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:29:12 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:29:12 +0000 Subject: [Koha-bugs] [Bug 15779] Remove unnecessary parts of C4::Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17847 --- Comment #6 from Jonathan Druart --- Bug 17847 - Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:29:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:29:37 +0000 Subject: [Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17847 --- Comment #13 from Jonathan Druart --- Bug 17847 - Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:29:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:29:37 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:36:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:36:53 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com --- Comment #81 from Charles Farmer --- Mark, when you say the schema files were not generated correctly, do you mean that you want to see the file hash change in the patch? I know you can't override it afterwards if you decide to regenerate them again because the script doesn't allow it, but I thought these files were generated again by the RM upon release. Anyway, I'll submit a separate patch for the schemas with the output of the script _as is_. And sorry for that messy rebase, that borrower table appearing a thousand lines before caught me by surprise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:41:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:41:56 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:41:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:41:58 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 --- Comment #1 from Jonathan Druart --- Created attachment 58589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58589&action=edit Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues The C4::Koha::GetAuthvalueDropbox subroutine does the same job as Koha::AuthorisedValues->search We should then replace the different calls to this subroutine to finally remove it. There were 2 calls to this subroutine: - from the AuthorisedValues TT plugin (called from av-build-dropbox.inc and members/housebound.tt) - from the acqui/ajax-getauthvaluedropbox.pl ajax script To make sure that this patchset does not introduce regressions, we will have to test that the TT plugin and the ajax script still behave as before. Test plan: 1/ Test acqui/ajax-getauthvaluedropbox.pl - Link a fund to an authorised value category - Create a new order => When you select a fund linked to AV category, the sort1 (and/or sort2, depending on what you set) should be replaced with a dropdown list populated with the authorised values 2/ Test av-build-dropbox.inc - Create some authorised values for Bsort1 - Edit a patron => The sort1 should be a dropdown list populated with the Bsort1 AV 3/ Test members/housebound.tt - Enable the housebound module (pref HouseboundModule) - On the patron detail page, click on the "Housebound" tab => The frequency dropdown list should be populated with the different HSBND_FREQ AV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 15:42:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 14:42:02 +0000 Subject: [Koha-bugs] [Bug 17847] Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 --- Comment #2 from Jonathan Druart --- Created attachment 58590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58590&action=edit Bug 17847: Remove C4::Koha::GetAuthvalueDropbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:02:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 15:02:12 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58580|0 |1 is obsolete| | --- Comment #82 from Charles Farmer --- Created attachment 58591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58591&action=edit Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:02:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 15:02:29 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58591|0 |1 is obsolete| | --- Comment #83 from Charles Farmer --- Created attachment 58592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58592&action=edit Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:02:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 15:02:35 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #84 from Charles Farmer --- Created attachment 58593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58593&action=edit Bug 11879: Changes to Koha's schemas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:03:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 15:03:55 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:22:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 15:22:55 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48297|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 58594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58594&action=edit Bug 15879: Allow multiple plugin directories to be defined in koha-conf.xml It would be very useful to be able to define multiple plugin directories in the Koha conf file. This would allow for ease of plugin development so that each plugin installed can live in its own git repository. For compatibility, the first plugindir instance defined should be the one used for uploading plugins via the web interface. Test Plan: 1) Apply this patch 2) Define a second pluginsdir line in your koha-conf.xml 3) Clone the kitchen sink plugin to this new path like this: git clone https://github.com/bywatersolutions/koha-plugin-kitchen-sink.git /path/to/new/plugins/dir 4) Restart memcached if you are running it 5) The Kitchen Sink plugin should now appear in your list of plugins! Signed-off-by: Tomas Cohen Arazi I rebased it against master and tested it on a kohadevbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 15:22:38 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 16:22:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 15:22:50 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:00:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 16:00:38 +0000 Subject: [Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- (In reply to Marcel de Rooy from comment #9) > Main change has been used in 15822. > So forget the rest. What is the status then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:09:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 16:09:23 +0000 Subject: [Koha-bugs] [Bug 17502] Resolve internal server error on 0000-00-00 (with Plack) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17502 --- Comment #11 from Marcel de Rooy --- Closed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:12:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 16:12:34 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 --- Comment #3 from M. Tompsett --- Created attachment 58595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58595&action=edit Bug 17846: Remove get_infos_of declaration The function which was removed was still being exported. This removes it completely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:13:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 16:13:26 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58588|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 58596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58596&action=edit [SIGNED-OFF] Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:13:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 16:13:53 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58595|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 58597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58597&action=edit Bug 17846: Remove get_infos_of declaration The function which was removed was still being exported. This removes it completely. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 17:20:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 16:20:18 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- Test plan for my patch amendment: apply patch 1 git grep get_infos_of -- still one line apply patch 2 git grep get_infos_of -- no lines Left as needs sign off, because of my amendment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:20:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 17:20:15 +0000 Subject: [Koha-bugs] [Bug 17825] Remove C4::Members::AttributeTypes::AttributeTypeExists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58491|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 58598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58598&action=edit [SIGNED-OFF] Bug 17825: Remove the use of AttributeTypeExists from opac-user.pl With the introducion of Koha::Object-based Koha::Patron::Attribute::Type(s) there's no need for using this function. This patch replaces it with a regular ->search + ->count call. To test: - Have a user with checkouts logged into the OPAC on the opac-user.pl page - Set the SHOW_BCODE attribute to 'no' on the staff interface for the user. - Reload opac-user.pl => SUCCESS: The barcode is not shown for checked out items. - Set the SHOW_BCODE atttribute to 'yes' on the staff interface for the user. - Reload opac-user.pl => SUCCESS: The barcode is shown for checked out items. - Delete the Patron attribute type SHOW_BCODE - Reload opac-user.pl => SUCCESS: No barcode is shown for checked out items - Sign off :-D Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:20:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 17:20:21 +0000 Subject: [Koha-bugs] [Bug 17825] Remove C4::Members::AttributeTypes::AttributeTypeExists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58492|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 58599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58599&action=edit [SIGNED-OFF] Bug 17825: (followup) Remove unused function AttributeTypeExists Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:20:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 17:20:33 +0000 Subject: [Koha-bugs] [Bug 17825] Remove C4::Members::AttributeTypes::AttributeTypeExists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17825 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 18:54:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 17:54:16 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- I tested this by looking at all the pages modified and making sure the item type information or form fields displayed correctly on each. I found two problems: - No item types display in the dropdown on reports/reserves_stats.pl - Error on suggestion/suggestion.pl: "Undefined subroutine &main::GetAuthorisedValues" Everywhere else I could see no problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:18:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 18:18:37 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 19:18:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 18:18:40 +0000 Subject: [Koha-bugs] [Bug 17835] Move C4::Koha::GetItemTypes to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17835 --- Comment #7 from Jonathan Druart --- Created attachment 58600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58600&action=edit Bug 17835: follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 20:52:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 19:52:41 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- (In reply to Jonathan Druart from comment #1) > => The staff description of NFL1 will always be used, even for the OPAC I find that after applying the patch the OPAC description is used on the place hold page instead of the staff one. I also find that the staff client search results page shows the NFL1 description for both records. The OPAC shows the NFL2 description for both records when placing an item-level hold. Very confusing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 21:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 20:29:30 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58585|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58601&action=edit Bug 17844: Replace C4::Koha::get_notforloan_label_of with Koha::AuthorisedValues This patch is more a bugfix than a refactoring. Indeed the C4::Koha::get_notforloan_label_of behaviors were buggy: 1/ It does not display the opac description at the OPAC, but always the staff description 2/ It does not care of the framework of the biblio, but retrieve the first row of the marc_subfield_structure mapped with items.notforloan These 2 bugs can easily be fixed using the Koha::AuthorisedValues->search_by_koha_field Steps to recreate the issues: - Create 2 authorised value categories for not for loan (NFL1 and NFL2) with the same values. Define a different description for the OPAC. - Define link 952$7 to NFL1 for the default framework and to NFL2 for the BK framework - Create 2 bibliographic records (B1 using NFL1 and B2 using NFL2) with 2 items each (1 item should have a not for loan value) - Go to the "Place a hold" view for this record. - In the item list, you should see the not for loan value => The staff description of NFL1 will always be used, even for the OPAC Test plan: - Recreate the issues without this patchset - Apply this patchset - Recreate the steps to recreate the issues => The staff description of NFL2 should be displayed for the B2 item => The opac description of NFL2 should be displayed for the B2 item at the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 21:33:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 20:33:49 +0000 Subject: [Koha-bugs] [Bug 17844] Move C4::Koha::get_notforloan_label_of to Koha:: AuthorisedValues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17844 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Jonathan Druart --- (In reply to Owen Leonard from comment #3) > (In reply to Jonathan Druart from comment #1) > > => The staff description of NFL1 will always be used, even for the OPAC > > I find that after applying the patch the OPAC description is used on the > place hold page instead of the staff one. Arg, stupid c/p from the opac-reserve.pl script. Fixed! > I also find that the staff client search results page shows the NFL1 > description for both records. Yes, I guess we have this problem on several different places. I would prefer to stick on the get_notforloan_label_of removing and address a complete fix on another bug report, if it makes sense. > The OPAC shows the NFL2 description for both records when placing an > item-level hold. I do not recreate that, could you double check or detail? On /cgi-bin/koha/opac-reserve.pl?biblionumber=1, when I click "show more options" then "A specific item", I see the correct AV opac description (depending on what is defined in the framework) in the "information" column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 21:41:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 20:41:53 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 21:58:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 20:58:45 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:36:20 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:36:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:36:35 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:43:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:43:12 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.02. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:44:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:44:36 +0000 Subject: [Koha-bugs] [Bug 16072] Include only one small spinner gif in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #7 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:45:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:45:16 +0000 Subject: [Koha-bugs] [Bug 17209] Remove use of onclick from masthead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:45:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:45:58 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug 17588 depends on bug 17584, which changed state. Bug 17584 Summary: Add the Koha::Patron->checkouts method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:45:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:45:57 +0000 Subject: [Koha-bugs] [Bug 17584] Add the Koha::Patron->checkouts method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:51:23 +0000 Subject: [Koha-bugs] [Bug 17679] C4::Circulation - Remove unused GetItemIssues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:51:23 +0000 Subject: [Koha-bugs] [Bug 17677] Move C4::Circulation code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17677 Bug 17677 depends on bug 17679, which changed state. Bug 17679 Summary: C4::Circulation - Remove unused GetItemIssues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:51:23 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Bug 17680 depends on bug 17679, which changed state. Bug 17679 Summary: C4::Circulation - Remove unused GetItemIssues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17679 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:52:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:52:40 +0000 Subject: [Koha-bugs] [Bug 17767] Let Koha::Patron::Modification handle extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #24 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:52:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:52:40 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Bug 13757 depends on bug 17767, which changed state. Bug 17767 Summary: Let Koha::Patron::Modification handle extended attributes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17767 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:55:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:55:24 +0000 Subject: [Koha-bugs] [Bug 17820] Do not use search->next when find can be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:58:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:58:39 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Severity|normal |enhancement Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #27 from Katrin Fischer --- This appears to dangerous for stable being part of the API rewrite - changing it to enh. As enh this won't be ported back to 16.11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:58:40 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Bug 15449 depends on bug 13726, which changed state. Bug 13726 Summary: Koha::Acquisition::Bookseller should use Koha::Object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:58:40 +0000 Subject: [Koha-bugs] [Bug 16017] Currency constraints and poorly named prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 Bug 16017 depends on bug 13726, which changed state. Bug 13726 Summary: Koha::Acquisition::Bookseller should use Koha::Object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:58:40 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Bug 17691 depends on bug 13726, which changed state. Bug 13726 Summary: Koha::Acquisition::Bookseller should use Koha::Object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:59:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:59:33 +0000 Subject: [Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #33 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 22:59:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 21:59:33 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 17569, which changed state. Bug 17569 Summary: Move GetUpcomingMembershipExpires to Koha::Patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:02:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:02:49 +0000 Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:07:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:07:15 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #262 from Katrin Fischer --- Follow-up 6b0562eee87e80532d6abb423177c76062be84cc has been pushed to 16.11.x and will be in 16.11.2. Please don't reuse bug numbers like this - it will make release notes be wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:26:19 +0000 Subject: [Koha-bugs] [Bug 17317] Adding "bib" type to GetAvailability method for ILSDI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17317 --- Comment #19 from Katrin Fischer --- I tested this feature to see if it was safe to go in by not changing the existing behaviour of GetAvailability for 'item'. return_type doesn't seem to be implemented as well? I think that the error page doesn't look good when you give an invalid bibnumber: .../cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=20000&id_type=bib For item it looks like this: 20000unknownError: could not retrieve availability for this ID What do you think? return_type doesn't seem to be implemented as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:33:58 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:34:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:34:03 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #6 from Aleisha Amohia --- Created attachment 58602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58602&action=edit Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:47:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:47:13 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45968|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 58603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58603&action=edit Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:47:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:47:25 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45969|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia --- Created attachment 58604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58604&action=edit Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:47:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:47:35 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58602|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 58605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58605&action=edit Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:48:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:48:24 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #10 from Aleisha Amohia --- This patch should now apply cleanly and is ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:50:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:50:46 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 4 23:50:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jan 2017 22:50:51 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58372|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia --- Created attachment 58606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58606&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database - perl installer/data/mysql/updatedatabase.pl 3) (You may have to rebuild schema but I think the patch should apply the schema changes for you) 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 01:09:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 00:09:04 +0000 Subject: [Koha-bugs] [Bug 17848] New: Count not updated in digest-only notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17848 Bug ID: 17848 Summary: Count not updated in digest-only notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: rbit at rbit.cz QA Contact: testopia at bugs.koha-community.org When using > in CHECKIN/CHECKOUT/RENEWAL notices, its value is not correctly updated. A letter is prepared during the first round and then its updated with iterated data items as they come. This means that placeholders like <> are not updated anymore so we can see letters saying eg. "you returned 3 items", but in the fact there is much more of them listed in: ---- <> ---- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 01:55:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 00:55:37 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Attachment #45621|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 01:55:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 00:55:53 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58272|Bug 15326: Add CMS feature |Bug 15326: [FOLLOW-UP] Add description| |CMS feature -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 02:03:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 01:03:51 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45621|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 58607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58607&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 02:04:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 01:04:58 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58607|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia --- Created attachment 58608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58608&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 02:05:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 01:05:05 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58272|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 58609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58609&action=edit Bug 15326: [FOLLOW-UP] Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 02:06:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 01:06:31 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Large patch --- Comment #8 from Aleisha Amohia --- The patch was not applying because I accidentally obsoleted Martin's initial patch, which is required! I have fixed any merge conflicts. This should apply cleanly and is now ready to test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 03:04:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 02:04:49 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 03:04:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 02:04:31 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 03:04:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 02:04:35 +0000 Subject: [Koha-bugs] [Bug 15738] Summary page says item has no fines, but Fines tab says otherwise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 --- Comment #6 from Aleisha Amohia --- Created attachment 58610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58610&action=edit Bug 15738: Show rental fees on OPAC summary page This patch adds a few lines that check for a rental fee on an item. If yes, it will show in brackets as a rental fee on the OPAC summary page. To test: 1) Have a borrower with an overdue item accruing fines, a lost item and an item with a rental fee. Confirm the Fines column on the OPAC summary page now shows you what you may expect to see for each item. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:37:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:37:48 +0000 Subject: [Koha-bugs] [Bug 13193] Discussion: strategy for diagnosing memcache issues. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Also saw some strange things coming from the cache incidentally, but it seems that just flushing the cache would be enough instead of restarting memcache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:49:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:49:00 +0000 Subject: [Koha-bugs] [Bug 10167] payment not showing what's paid for if not an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10167 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 2696 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:49:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:49:00 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #12 from Katrin Fischer --- *** Bug 10167 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:51:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:51:47 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15273 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:51:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:51:47 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2696 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:54:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:54:07 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com, | |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:55:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:55:14 +0000 Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz --- Comment #9 from Katrin Fischer --- *** Bug 7565 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 10:55:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 09:55:14 +0000 Subject: [Koha-bugs] [Bug 7565] Fee/fines receipt for printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 15273 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 11:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 10:31:25 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #14 from Alex Sassmannshausen --- Test Plan - Ensure the patch applies cleanly - Run unit tests, and ensure no regression (especially t/db_dependent/Circulation/transfers.t) - Set in motion a branch transfer (e.g. check in an item at a branch that is not it's home branch when floating stock is switched off) - Receive a branch transfer (check in an item previously in branch transfer) Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 11:32:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 10:32:15 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 11:46:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 10:46:30 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #21 from Alex Sassmannshausen --- Test Plan ========= Setup ----- - Ensure the patches apply cleanly and without problems - Run the unit tests, and ensure no regressions. In particular: * t/db_dependent/Stockrotationitems.t * t/db_dependent/Stockrotationrotas.t * t/db_dependent/Stockrotationstages.t * t/db_dependent/Items.t * t/db_dependent/Koha/Libraries.t User Interface -------------- - Enable the stockrotation system preference - A new menu, "stockrotation" should have appeared under the "tools" page. Test: * creating rota * editing rota * adding stages * adding items * removing items * "move item to next stage" - Any biblio should now have a "rotas" tab in the biblio view - From there any items attached to that biblio can be added/removed to/from rotas Cron Script ----------- The task of the cron script is to traverse all the items in all rotas and to see whether any of them need to be moved on to the next stage. It does this by, for each item, checking whether it has spent more days than "duration" at the current branch since it's last (stockrotation) branch transfer. To test the script, run it with the "-h" flag. You should get documentation. If you want to see the script actually do something, you should: - setup an item as described above - run the script to create initial stock rotation branch transfers (don't forget the "-x" flag!) - fiddle the database, so that the initial stock rotation branch transfer is in the past by at least the "duration" of the stage that the item is currently at - run the script again (without the "-x" flag): you should see that the cron script would now move the item to the next stage - running it with the "-x" flag will create the new branch transfer and will emit a report for the library currently holding the item to inform them it needs to be fetched from shelf to be put in transit. If you prefer you can have the script send emails. Follow the documentation for this. Please let me know if you have any questions! I'll be happy to help :-) Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 12:14:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 11:14:21 +0000 Subject: [Koha-bugs] [Bug 17849] New: Show only unpaid fees/fines in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17849 Bug ID: 17849 Summary: Show only unpaid fees/fines in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Currently all payments, credits, paid and unpaid fine entries are shown in the OPAC. It would be less confusing, if we only showed unpaid fines and credits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 12:21:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 11:21:16 +0000 Subject: [Koha-bugs] [Bug 17850] New: ManInvInNoissuesCharge does not seem to work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17850 Bug ID: 17850 Summary: ManInvInNoissuesCharge does not seem to work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: - set noissuecharge to 5 - set ManInvInNoissuesCharge to 'Don't include' - in a patron profile, generate a manual invoice for 8 - set AllowFineOverride to 'Don't allow' - open the patron details page. it says > "Fees & Charges: Patron has outstanding fees & charges of 8.00. Checkouts are BLOCKED because fine balance is OVER THE LIMIT." Expected: Display of fees and charges, but not blocked from checkouts. With AllowFineOverride set to "Allow", there is no mention of being blocked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 12:39:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 11:39:06 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #28 from Olli-Antti Kivilahti --- Maybe this Bug can help with availability calculations? Bug 17712 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 12:52:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 11:52:00 +0000 Subject: [Koha-bugs] [Bug 15775] User should know when they are blocked from checkouts on OPAC + Translatability fixes for OPAC Summary page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15775 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 12:55:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 11:55:37 +0000 Subject: [Koha-bugs] [Bug 11653] For tag "020" only subfields "a" is displayed in MARC XSLT OPAC's detail template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11653 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Owen Leonard --- No further comments, so I'm going to consider this settled for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:05:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 12:05:45 +0000 Subject: [Koha-bugs] [Bug 17851] New: Add elasticsearch config to koha-conf.xml Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Bug ID: 17851 Summary: Add elasticsearch config to koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Following the Elasticsearch installation instructions from: https://wiki.koha-community.org/wiki/Elasticsearch the config seems to be missing. This patch adds interactive Elasticsearch-questions to the Makefile.PL to configure ES. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:14:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 12:14:51 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 58611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58611&action=edit Bug 17851 - Add elasticsearch config to koha-conf.xml Missing installer for debian packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:15:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 12:15:38 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17851 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:15:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 12:15:38 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:26:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 12:26:15 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:27:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 12:27:03 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 13:35:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 12:35:53 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:22:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 13:22:06 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #54 from Matthias Meusburger --- Benjamin, about the problems you had, as I used a fresh koha install database and faced no problem at all, do you think maybe it could have something to do with your database specifically? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 13:26:24 +0000 Subject: [Koha-bugs] [Bug 8628] Add digital signs to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 14:26:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 13:26:49 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:25:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 14:25:46 +0000 Subject: [Koha-bugs] [Bug 14614] Multiple URLs (856) in cart email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple URLs (856) in |Multiple URLs (856) in cart |cart/list email are broken |email are broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:26:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 14:26:52 +0000 Subject: [Koha-bugs] [Bug 17852] New: Multiple URLs (856) in list email are broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Bug ID: 17852 Summary: Multiple URLs (856) in list email are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Same bug as bug 14614, but for list emails send from staff and intranet. If there are multiple URLs (865 fields), the URLs get squashed together into 'one URL' in the email sent and are broken therefore. Same fix as for the other bugs should work nicely here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:27:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 14:27:15 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14614 Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 15:27:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 14:27:15 +0000 Subject: [Koha-bugs] [Bug 14614] Multiple URLs (856) in cart email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14614 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17852 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:52:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 15:52:28 +0000 Subject: [Koha-bugs] [Bug 17853] New: MARC21: Don't remove () from link text for 780 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Bug ID: 17853 Summary: MARC21: Don't remove () from link text for 780 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org To test: - Catalogue a record with 780, Indicators 00 and $a some text including parentheses. - Verify that the () are not shown in the link text and are not part of the URL. Problem: It's correct to remove () from the link, but the link text should still include them. Problem exists in staff and OPAC. >From the detail page XSLT, problem is in lines 1149 and 1154: 1146 1147 1148 /cgi-bin/koha/opac-search.pl?q=Control-number: 1149 1150 1151 1152 1153 /cgi-bin/koha/opac-search.pl?q=ti,phr: 1154 1155 1156 1157 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:52:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 15:52:36 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:56:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 15:56:03 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #1 from Katrin Fischer --- Ah, same problem appears to exist for 785. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 16:56:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 15:56:11 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC21: Don't remove () |MARC21: Don't remove () |from link text for 780 |from link text for 780/785 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:16:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 16:16:38 +0000 Subject: [Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 --- Comment #6 from Alex Sassmannshausen --- Created attachment 58612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58612&action=edit Bug 16083: [QA FOLLOWUP] Add more cli arguments. * Makefile.PL: Add `zebra_sru_host`, `zebra_sru_biblios_port` & `zebra_sru_authorities_port` as possible command line arguments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:17:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 16:17:41 +0000 Subject: [Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 --- Comment #7 from Alex Sassmannshausen --- (In reply to M. Tompsett from comment #5) > (In reply to M. Tompsett from comment #2) > > What about the SRU Biblio and Authority port numbers? > > This question was never dealt with. My latest patch adds SRU Biblio and Authority port numbers as well as SRU Host commandline arguments. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:29:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 16:29:00 +0000 Subject: [Koha-bugs] [Bug 11523] Make framework code available to stylesheets to allow for more customized display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11523 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Version|unspecified |master Assignee|oleonard at myacpl.org |gmcharlt at gmail.com Component|OPAC |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 17:54:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 16:54:03 +0000 Subject: [Koha-bugs] [Bug 17695] Frameworks not saving in IE11 when editing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17695 Emma Perks changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.perks at heartofengland.n | |hs.uk --- Comment #1 from Emma Perks --- also autocomplete fields are not populating in a new biblio record when using IE11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 18:21:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 17:21:31 +0000 Subject: [Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 --- Comment #8 from M. Tompsett --- (In reply to Alex Sassmannshausen from comment #7) > My latest patch adds SRU Biblio and Authority port numbers as well as SRU > Host commandline arguments. Thanks that looks great. I'm happy to leave this at Passed QA now. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:39:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:39:25 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57751|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 58613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58613&action=edit Bug 17501: Introduce Koha::Object[s] classes for UploadedFile(s) In the next set of patches we will start using these new classes in Koha::Upload, and scripts using it. This is just the starting point of that migration. Test plan: [1] Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:39:30 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57752|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 58614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58614&action=edit Bug 17501: Use Koha::Object in Koha::Upload::_register The _register routine basically inserts a new record in uploaded_files. It should use Koha::UploadedFile now. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file via Tools/Upload. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:39:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:39:36 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57753|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 58615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58615&action=edit Bug 17501: Use Koha::Object in Koha::Upload::_lookup The _lookup routine performs a few select statements on uploaded_files. In this patch the SQL statements are replaced with Koha::Object calls. One call of _lookup is replaced directly by Koha::UploadedFiles. Note: _lookup can be removed in a later stage. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file in some upload category [3] Try to upload the same file into the same category. Error? [4] Try to upload the same file in another category. Should work. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:39:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:39:41 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57754|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 58616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58616&action=edit Bug 17501: Use Koha::Object in Koha::Upload::_delete Note: This is the last occurrence where we use DBI to perform a CRUD operation. In this case a delete from uploaded_files. We now call Koha::UploadedFile[s]->delete to only delete the record from the table. A next step will be moving the additional functionality of removing the file(s) too. Test plan: [1] Run t/db_dependent/Upload.t [2] Delete an upload from tools/upload.pl Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:39:47 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57755|0 |1 is obsolete| | --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 58617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58617&action=edit Bug 17501: Move Koha::Upload::delete to Koha::UploadedFile[s] Since delete is not part of the upload process, we will move it now to Koha::UploadedFile[s]. Deleting the file will be done in UploadedFile. The (multiple) delete method in UploadedFiles refers to the single delete. Test plan: [1] Run t/db_dependent/Upload.t The warning ("but file was missing") in the last subtest is fine; the file did not exist. Will be addressed in a follow-up. [2] Search for uploads on Tools/Upload. Clone this tab (repeat search on a new tab in your browser). [3] Delete an existing upload on the first tab. [4] Try to delete it again on the second tab. Error message? [5] Bonus points: Add an upload. Mark the file immutable with chattr +i. Try to delete the file. You should see a "Could not be deleted"-message. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:39:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:39:57 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57756|0 |1 is obsolete| | --- Comment #16 from Tom?s Cohen Arazi --- Created attachment 58618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58618&action=edit Bug 17501: Remove Koha::Upload::get from Koha::Upload The get routine actually returns records from uploaded_files. It should be possible to replace its calls by direct calls of Koha::UploadedFiles. This patch is the crux of this patch set. It deals with all scripts that use Koha::Upload. In the process we do: [1] Add a file_handle method to Koha::UploadedFile. This was previously arranged via the fh parameter of get. [2] Add a full_path method to UploadedFile. Previously returned in the path hash key of get. (Name is replaced by filename.) [3] Add a search_term method too (implementing get({ term => .. }). This logic came from _lookup. [4] Add a keep_file parameter to delete method. Only used in test now. Test plan: [1] Run t/db_dependent/Upload.t [2] Go to Tools/Upload. Add an upload, download and delete. [3] Add another public upload , search for it. Use the hashvalue to download via opac with URL: cgi-bin/koha/opac-retrieve-file.pl?id=[hashvalue] [4] Go to Tools/Stage MARC for import. Import a marc file. [5] Go to Tools/Upload local cover image. Import an image file. Enable OPACLocalCoverImages to see result. [6] Test uploading a offline circulation file: Enable AllowOfflineCirculation, and create a koc file (plain text): Line1: Version=1.0\tA=1\tB=2 Line2: 2016-11-23 16:00:00 345\treturn\t[barcode] Note: Replace tabs and barcode. The number of tabs is essential! Checkout the item with your barcode. Go to Circulation/Offline circulation file upload. Upload and click Apply directly. Checkout again. Repeat Offline circulation file upload. Now click Add to offline circulation queue. [7] Connect the upload plugin to field 856$u. Enable HTML5MediaEnabled. Upload a webm file via the plugin. Click Choose to save the URL, and put 'video/webm' into 856$q. Save the biblio record. Check if you see the media tab with player on staff detail. (See also: Bug 17673 about empty OPACBaseURL.) Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:40:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:40:02 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57757|0 |1 is obsolete| | --- Comment #17 from Tom?s Cohen Arazi --- Created attachment 58619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58619&action=edit Bug 17501: Move getCategories and httpheaders from Upload.pm Class method getCategories has no strict binding to Upload.pm. While Upload.pm is now restricted to the actual uploading process with CGI hook, this routine fits better in the UploadedFile package. Class method httpheaders can be moved as well for the same reason. Note that it actually is an instance method. The parameter $name is dropped. Test plan: [1] Run t/db_dependent/Upload.t. [2] Check the categories in the combo box of tools/upload. [3] Check a download via tools/upload and opac-retrieve-file. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:40:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:40:11 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57758|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 58620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58620&action=edit Bug 17501: Rename Upload to Uploader Why? Koha::Uploader now only contains the actual CGI upload. The new name better reflects its handler status. Pragmatically, the difference between Uploaded and Uploader makes it easier to specifically search for them in the codebase. Test plan: [1] Run t/db_dependent/Upload.t. [2] Add an upload via the interface. [3] Check the code: git grep "Koha::Upload;" git grep "Koha::Upload\->" Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:40:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:40:20 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57759|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 58621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58621&action=edit Bug 17501: Additional polishing (POD, unit tests) This patch adds some documentation lines. And mainly rearrangs the tests in Upload.t. The 'basic CRUD testing' is not needed separately any more. A new test catches the "file missing" warn. Test plan: [1] Run perldoc on UploadedFile[s].pm [2] Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 19:40:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 18:40:44 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 21:17:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 20:17:38 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 --- Comment #5 from M. Tompsett --- Comment on attachment 51101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51101 Bug 16413: Change prototype of GetSoonestRenewDate Review of attachment 51101: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16413&attachment=51101) ----------------------------------------------------------------- ::: circ/renew.pl @@ +78,5 @@ > > if ( $error && ($error eq 'too_soon' or $error eq 'auto_too_soon') ) { > $soonest_renew_date = C4::Circulation::GetSoonestRenewDate( > + { > + borrower => $borrower->unblessed, shouldn't this be: patron => $borrower->unblessed, ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 21:18:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 20:18:41 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 --- Comment #6 from M. Tompsett --- Comment on attachment 51100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51100 Bug 16413: Change prototype GetLatestAutoRenewDate Review of attachment 51100: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16413&attachment=51100) ----------------------------------------------------------------- ::: circ/renew.pl @@ +84,5 @@ > } > if ( $error && ( $error eq 'auto_too_late' ) ) { > $latest_auto_renew_date = C4::Circulation::GetLatestAutoRenewDate( > + { > + borrower => $borrower->unblessed, shouldn't this be: patron => $borrower->unblessed, ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 22:55:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 21:55:21 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58606|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia --- Created attachment 58622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58622&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 22:56:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 21:56:14 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #39 from Aleisha Amohia --- I realised I had taken some shortcuts with the object-oriented stuff and wasn't doing it properly. The latest patch fixes that. This is ready to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 5 23:26:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jan 2017 22:26:22 +0000 Subject: [Koha-bugs] [Bug 17854] New: Print Slip and Close button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Bug ID: 17854 Summary: Print Slip and Close button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would like to see an enhancement on the clear screen (X) button on patron records. It would be great if it were replaced with a button with preference settings that would have the following options: Close Print Slip and Close Print Quick Slip and Close It would also be great if it could have a side action arrow giving you access to the other options that are not defaulted. This feature would help with staff closing accounts (clearing screen) when done, and making slip printing stand out a little better. It would also be a streamlined workflow. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 02:55:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 01:55:19 +0000 Subject: [Koha-bugs] [Bug 17855] New: Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Bug ID: 17855 Summary: Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Updated the Koha web installer so that it has two setup modes: Basic and Advanced. The basic mode limits the control the user has over the data they choose to install into the database. They can only choose whether to install optional data; all default data is installed by default. The advanced mode gives the user greater control to choose whether or not to install default AND optional data. After the web installer has finished the user is redirected to the onboarding tool (with no authentication required in between). In the onboarding tool they create a: Library, Patron category Item type (if they were not installed in the web installer), In addition to always creating a: Patron (which has super librarian privileges which the user will use to log into Koha with) Circulation rule Then the user is redirected to a login page where they login using the patron they just created. If they entered the correct patron account credentials the Koha homepage will appear, and the user can start using Koha as intended due to all necessary data being installed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 08:11:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 07:11:50 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 --- Comment #20 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #19) > Signed-off-by: Tomas Cohen Arazi Great, Tomas. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 08:29:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 07:29:56 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- QA: Looking here now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:12:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:12:54 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 --- Comment #9 from Marcel de Rooy --- Created attachment 58624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58624&action=edit Bug 17486: [QA Follow-up] Changes as to set_userenv Add shibboleth parameter to POD of set_userenv. Removed a 12th set_userenv parameter from Borrower_Discharge.t. Replaced set_userenv call in PatronLists.t looking like a fortunate typo. Test plan: Run the two corrected tests. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:12:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:12:46 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58485|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 58623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58623&action=edit Bug 17486: Remove Mozilla Persona Persona never really took off, and although many browsers currently support it, very few services actually implement it. This has lead to it's founders, Mozilla, to end the project. In their own words: ============================================================================= Persona is no longer actively developed by Mozilla. Mozilla has committed to operational and security support of the persona.org services until November 30th, 2016. On November 30th, 2016, Mozilla will shut down the persona.org services. Persona.org and related domains will be taken offline. If you run a website that relies on Persona, you need to implement an alternative login solution for your users before this date. For more information, see this guide to migrating your site away from Persona: https://wiki.mozilla.org/Identity/Persona_Shutdown_Guidelines_for_Reliers ============================================================================= Given the above, and that the Persona authentication methods as a whole are no longer being actively maintained by anyone anywhere to ensure ongoing security, we should deprecate the option from koha. Test plan: Apply this patch and make sure you do not find any references of Persona Have a look at patches from bug 9587 and confirm that everything has been reverted Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Code looks good to me. Also ran several tests including: Auth.t, Auth_with_shibboleth.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:13:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:13:16 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:20:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:20:52 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #27 from Marcel de Rooy --- Martin: Please answer Mirko's question on the last patch and signoff on that one. After that set status back to SO. Thanks ! Temporarily moving out of the SO queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:45:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:45:04 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:45:07 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57970|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 58625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58625&action=edit Bug 17629: Koha::Biblio - Remove ModBiblioframework There is only one call to C4::Biblio::ModBiblioframework, it's called just before C4::Biblio::ModBiblio in cataloguing/addbiblio.pl At first glance this call does not seems useful: all the subroutines called from ModBiblio send the frameworkcode in parameter. I'd go to remove it, but I'd like to get confirmation by others. No test plan here, you need a good pair of eyes and deep into the C4::Biblio code. Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:45:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:45:22 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 09:59:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 08:59:39 +0000 Subject: [Koha-bugs] [Bug 12026] Shibboleth auto-provisioning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026 --- Comment #28 from Mirko Tietgen --- (In reply to Marcel de Rooy from comment #27) > Martin: Please answer Mirko's question on the last patch and signoff on that > one. After that set status back to SO. Thanks ! > > Temporarily moving out of the SO queue. Martin replied on IRC saying they make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:01:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:01:05 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:01:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:01:08 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58035|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 58626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58626&action=edit Bug 17740: Add the Koha::Patron->holds method The goal of this method is to replace C4::Reserves::GetReservesFromBorrowernumber but could be reused for something else, that's why it has its own bug report. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy Rebased. Edited two test descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:01:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:01:22 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:20:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:20:41 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:20:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:20:43 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58034|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 58627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58627&action=edit Bug 17741: Use Koha::Patron->holds when deleting a patron There is a TODO in Koha::Patron->delete, this method should call the Koha::Patron->holds to retrieve the holds made by the patron we are removing instead of calling Koha::Holds->search Test plan: prove t/db_dependent/Koha/Patrons.t Should return green Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:21:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:21:03 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:28:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:28:55 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- Testing this now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:51:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:51:12 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #11 from Marcel de Rooy --- I would rather rename the sub. It is not about when the hold was 'placed' but if the hold pertains to the future or not. So my suggestion would be: Koha::Biblio->current_holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:57:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:57:21 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #12 from Marcel de Rooy --- Created attachment 58628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58628&action=edit Bug 17736: [Follow-up] Rename to current_holds It is not about when the hold was 'placed' but if the hold pertains to the future or not. Test plan: [1] Git grep on holds_placed_before_today. [2] Run t/db_dependent/Koha/Biblios.t [3] Run t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 10:59:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 09:59:58 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #13 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > I would rather rename the sub. It is not about when the hold was 'placed' > but if the hold pertains to the future or not. > So my suggestion would be: Koha::Biblio->current_holds. And also note that before today is not correct: should include today too. Added a proposal patch. Still testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 11:24:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 10:24:45 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #14 from Marcel de Rooy --- Resolving a few errors like this too: Use of inherited AUTOLOAD for non-method Koha::Biblio::GetMarcBiblio() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. Use of inherited AUTOLOAD for non-method Koha::Biblio::GetRecordValue() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. This happens because perl is looking first in Koha::Object (with AUTOLOAD) before it checks C4/Biblio. Rearranging the module order did not help either (moving C4/Biblio). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 11:27:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 10:27:57 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #15 from Marcel de Rooy --- Created attachment 58629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58629&action=edit Bug 17736: [Follow-up] Resolve inherited AUTOLOAD for non-method errors Like: Use of inherited AUTOLOAD for non-method Koha::Biblio::GetMarcBiblio() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. Use of inherited AUTOLOAD for non-method Koha::Biblio::GetRecordValue() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. Resolved by not importing them but fully qualifying them. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 11:46:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 10:46:52 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #16 from Marcel de Rooy --- Created attachment 58630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58630&action=edit Bug 17736: [QA Follow-up] Solve warning from qa tools on Holds.t FAIL t/db_dependent/Holds.t "my" variable $hold masks earlier declaration in same scope Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:00:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:00:16 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #17 from Marcel de Rooy --- Ha: my $biblio = Koha::Biblios->find( $order->{ordernumber} ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:00:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:00:30 +0000 Subject: [Koha-bugs] [Bug 17856] New: Add API endpoint for item types Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17856 Bug ID: 17856 Summary: Add API endpoint for item types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:00:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:00:53 +0000 Subject: [Koha-bugs] [Bug 17856] Add API endpoint for item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17856 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com Assignee|koha-bugs at lists.koha-commun |mail at jkozlovsky.cz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:04:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:04:31 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #18 from Marcel de Rooy --- Created attachment 58631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58631&action=edit Bug 17736: [QA Follow-up] Wrong biblionumber in acqui/parcel Trivial fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:26:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:26:13 +0000 Subject: [Koha-bugs] [Bug 11761] Multiple notifications for borrowers if checked out from many branches during one day. (caused by overdue_notifications.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11761 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:26:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:26:28 +0000 Subject: [Koha-bugs] [Bug 17614] Introduce multiple fine charging intervals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17614 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:50:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:50:12 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #19 from Marcel de Rooy --- Bug party! Do not assume that find gives you a Koha Object. Just see the following examples :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 12:50:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 11:50:30 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #20 from Marcel de Rooy --- Created attachment 58632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58632&action=edit Bug 17736: [QA Follow-up] Crashes in basket.pl and parcel.pl Crash in basket.pl: Can't call method "holds" on an undefined value at /usr/share/koha/masterclone/acqui/basket.pl line 466. Comes from a biblionumber == NULL in aqorders where I cancelled the order and deleted the biblio. Crash in parcel.pl: Can't call method "holds" on an undefined value at /usr/share/koha/masterclone/acqui/parcel.pl line 246. Similar fix. Trivial fixes indeed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:26:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:26:30 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #21 from Marcel de Rooy --- Created attachment 58633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58633&action=edit Bug 17736: [QA Follow-up] We do not need GetItemHolds in acqui The solution of Jonathan can be applied in two other cases, effectively making GetItemHolds obsolete. Test plan: [1] Git grep on GetItemHolds [2] Add an order, place a hold, delete order. [3] Add an order, receive, place hold, delete order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:50:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:50:29 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #22 from Marcel de Rooy --- Created attachment 58634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58634&action=edit Bug 17736: [QA Follow-up] Script basket.pl is not Plack compliant Several warnings like: Variable "$confirm_pref" is not available at /usr/share/koha/masterclone/acqui/basket.pl line 507. Primarily caused by sub edi_close_and_order. Easy fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:07 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58106|0 |1 is obsolete| | Attachment #58107|0 |1 is obsolete| | Attachment #58108|0 |1 is obsolete| | Attachment #58628|0 |1 is obsolete| | Attachment #58629|0 |1 is obsolete| | Attachment #58630|0 |1 is obsolete| | Attachment #58631|0 |1 is obsolete| | Attachment #58632|0 |1 is obsolete| | Attachment #58633|0 |1 is obsolete| | Attachment #58634|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy --- Created attachment 58635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58635&action=edit Bug 17736: Add the Koha::Biblio->holds_placed_before_today method Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:12 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #24 from Marcel de Rooy --- Created attachment 58636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58636&action=edit Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds The C4::Reserve::GetReservesFromBiblionumber took 3 parameters, the biblionumber, an optional itemnumber and a "all_dates" flag. If set, the subroutine returned all the holds placed on a given bibliographic record, even the ones placed in the future. Almost all of the calls had this flag set, they will be replaced with a call to Koha::Biblio->holds. But 5 did not have it: - C4::Biblio::DelBiblio -tools/batch_delete_records.pl => These 2 were wrong, we want to retrieve the holds to cancel them before deleting the record. We need to get all the holds, even the ones placed in the future /!\ CHANGE IN THE BEHAVIOR - acqui/parcel.pl => 1 call per item were made to this subroutine. They have been replaced with only 1 call to the new method Koha::Biblios->holds_placed_before_today Then we filter on the itemnumbers. I think this is wrong: we need the number of holds to know if the record can be deleted, so even if future holds exist, the deletion should not be possible. - serials/routing-preview.pl - C4::ILSDI::Services::GetRecords - C4::SIP::ILS::Item->new => Seems ok, we just one to display holds placed before today Test plan: I would suggest to test this patch with patches from bug 17737 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:16 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #25 from Marcel de Rooy --- Created attachment 58637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58637&action=edit Bug 17736: Remove C4::Reserves::GetReservesFromBiblionumber At this point, there should not be any occurrences of GetReservesFromBiblionumber left in the codebase Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:19 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #26 from Marcel de Rooy --- Created attachment 58638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58638&action=edit Bug 17736: [Follow-up] Rename to current_holds It is not about when the hold was 'placed' but if the hold pertains to the future or not. Test plan: [1] Git grep on holds_placed_before_today. [2] Run t/db_dependent/Koha/Biblios.t [3] Run t/db_dependent/Reserves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:23 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #27 from Marcel de Rooy --- Created attachment 58639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58639&action=edit Bug 17736: [Follow-up] Resolve inherited AUTOLOAD for non-method errors Like: Use of inherited AUTOLOAD for non-method Koha::Biblio::GetMarcBiblio() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. Use of inherited AUTOLOAD for non-method Koha::Biblio::GetRecordValue() is deprecated at /usr/share/koha/masterclone/Koha/Biblio.pm line 60. Resolved by not importing them but fully qualifying them. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:27 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #28 from Marcel de Rooy --- Created attachment 58640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58640&action=edit Bug 17736: [QA Follow-up] Solve warning from qa tools on Holds.t FAIL t/db_dependent/Holds.t "my" variable $hold masks earlier declaration in same scope Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:31 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #29 from Marcel de Rooy --- Created attachment 58641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58641&action=edit Bug 17736: [QA Follow-up] Wrong biblionumber in acqui/parcel Trivial fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:34 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #30 from Marcel de Rooy --- Created attachment 58642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58642&action=edit Bug 17736: [QA Follow-up] Crashes in basket.pl and parcel.pl Crash in basket.pl: Can't call method "holds" on an undefined value at /usr/share/koha/masterclone/acqui/basket.pl line 466. Comes from a biblionumber == NULL in aqorders where I cancelled the order and deleted the biblio. Crash in parcel.pl: Can't call method "holds" on an undefined value at /usr/share/koha/masterclone/acqui/parcel.pl line 246. Similar fix. Trivial fixes indeed. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:38 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #31 from Marcel de Rooy --- Created attachment 58643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58643&action=edit Bug 17736: [QA Follow-up] We do not need GetItemHolds in acqui The solution of Jonathan can be applied in two other cases, effectively making GetItemHolds obsolete. Test plan: [1] Git grep on GetItemHolds [2] Add an order, place a hold, delete order. [3] Add an order, receive, place hold, delete order. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:55:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:55:42 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #32 from Marcel de Rooy --- Created attachment 58644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58644&action=edit Bug 17736: [QA Follow-up] Script basket.pl is not Plack compliant Several warnings like: Variable "$confirm_pref" is not available at /usr/share/koha/masterclone/acqui/basket.pl line 507. Primarily caused by sub edi_close_and_order. Easy fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:56:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:56:37 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #33 from Marcel de Rooy --- This got out of hand somewhere in the process ;) But it works now (imo). The logic in basket.tt about showing hold numbers is still not working as it should. But should be further dealt with on another report. In parcel I used holds now instead of current_holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:56:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:56:50 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:58:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:58:04 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- Please see 17736 and use something like current_holds ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 13:59:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 12:59:54 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58644|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 58645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58645&action=edit Bug 17736: [QA Follow-up] Script basket.pl is not Plack compliant Several warnings like: Variable "$confirm_pref" is not available at /usr/share/koha/masterclone/acqui/basket.pl line 507. Primarily caused by sub edi_close_and_order. Easy fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 14:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 13:00:24 +0000 Subject: [Koha-bugs] [Bug 17736] Move GetReservesFromBiblionumber to Koha::Biblio->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17736 --- Comment #35 from Marcel de Rooy --- Removed a debug warn. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 14:54:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 13:54:24 +0000 Subject: [Koha-bugs] [Bug 17857] New: Show checkouts when anchor to overdues is clicked Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17857 Bug ID: 17857 Summary: Show checkouts when anchor to overdues is clicked Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/circulation.pl#checkouts OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron has overdues a message on the circulation screen notifies the librarian: "Overdues: Patron has ITEMS OVERDUE. " Clicking the "See highlighted items below" link should trigger the display of checkouts if they are hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:03:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 14:03:31 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:03:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 14:03:34 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58123|0 |1 is obsolete| | --- Comment #15 from Owen Leonard --- Created attachment 58646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58646&action=edit [SIGNED-OFF] Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. Signed-off-by: Owen Leonard Test plan successful on all steps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:03:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 14:03:51 +0000 Subject: [Koha-bugs] [Bug 17452] Checking in item at remote location via SIP does not trigger branch transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17452 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Barton Chittenden --- This was happening because AutomaticItemReturn was not enabled. Closing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:31:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 14:31:23 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:31:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 14:31:26 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 --- Comment #1 from Magnus Enger --- Created attachment 58647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58647&action=edit Bug 17778 - Make "Earliest Registered Date" in OAI dynamic This was hardcoded to 0001-01-01. To test: - Make sure you have a couple of records, with different timestamps - Enable OAI-PMH - Check http://localhost:2201/cgi-bin/koha/oai.pl?verb=Identify and verify that "Earliest Registered Date" is 0001-01-01 - Apply the patch - Re-check the "Earliest Registered Date" and verify that it is now the lowest timestamp in your biblio table - Manipulate the timestamps and verify that "Earliest Registered Date" changes accordingly - Sign off! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:52:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 14:52:39 +0000 Subject: [Koha-bugs] [Bug 11523] Make framework code available to stylesheets to allow for more customized display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11523 --- Comment #3 from Eugene Espinoza --- As posted in the koha-community list to which Galen Charlton replied, it can be possible. Where to put the settings is probably in framework editing where one can assign xslt for a particular framework. This since the feature enhancement asked is to let a user choose an xslt for MARC frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 15:59:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 14:59:46 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Owen Leonard --- I've done a quick run-through of this and nothing looks broken. The tests all pass. I think the biggest gap is documentation. There should be a help file for the whole process, especially the things which aren't self-explanatory. For instance: - What does the 'cyclical' setting do? - What is the purpose of the "Start" item in the stages and duration column of the manage items table? - What does the "In demand" setting do? I take it the process is: Create rota -> Add items -> Wait for cron job to put items in transit? I'm curious whether available items should be put in transit automatically after putting them on a rota. Minor problems: - Our capitalization rules say the heading should say "Stock rotation" instead of "Stock Rotation" https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lower_cases_in_strings - I don't the the alert-style div is correct for showing a confirmation of items added. I would put the confirmation message in a
and show a table of results below that. - In the manage items table, there is no wrapping . - The page title and breadcrumbs should be made more specific for each page. For instance, when on the manage items page the breadcrumbs should be: Home ? Tools ? Stock rotation > Manage items This provides an easily accessible link back to the main stock rotation page. Suggestions: - Add a toolbar to the manage items page with a 'New rota' and 'Edit rota' buttons. - Move the add items forms to the top of the - In the manage items table, I think title and barcode should link to the bibliographic record and items page, respectively. - Make the manage items table a DataTable with sorting and searching. Unless you think the items table will typically hold so much data this would become cumbersome? - Should item status information be displayed in the manage items table? Is it relevant to the process to know whether something is checked out, lost, etc? - Since the drag-to-sort interaction is new to Koha it probably needs a hint at the top to suggest it. (Looks good and work well, though). I'm marking this as failed for now for the minor fixes and to get more information. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:29:16 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:29:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:29:19 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58647|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 58648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58648&action=edit [SIGNED-OFF] Bug 17778 - Make "Earliest Registered Date" in OAI dynamic This was hardcoded to 0001-01-01. To test: - Make sure you have a couple of records, with different timestamps - Enable OAI-PMH - Check http://localhost:2201/cgi-bin/koha/oai.pl?verb=Identify and verify that "Earliest Registered Date" is 0001-01-01 - Apply the patch - Re-check the "Earliest Registered Date" and verify that it is now the lowest timestamp in your biblio table - Manipulate the timestamps and verify that "Earliest Registered Date" changes accordingly - Sign off! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:45:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:45:48 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:45:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:45:48 +0000 Subject: [Koha-bugs] [Bug 17858] New: Omnibus: Move staff client JavaScript to the footer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug ID: 17858 Summary: Omnibus: Move staff client JavaScript to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 17418 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This omnibus bug will collect reports which modify subsets of the staff client templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:46:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:46:51 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #55 from Kyle M Hall --- Matthias, could you please rebase your patches? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:57:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:57:03 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 [Bug 17859] Move JavaScript to the footer on about and auth pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:57:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:57:03 +0000 Subject: [Koha-bugs] [Bug 17859] New: Move JavaScript to the footer on about and auth pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Bug ID: 17859 Summary: Move JavaScript to the footer on about and auth pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 17418 Blocks: 17858 Two "standalone" templates which can have the JavaScript moved to the footer: The about page and the login page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 16:57:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 15:57:03 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 [Bug 17859] Move JavaScript to the footer on about and auth pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 16:07:11 +0000 Subject: [Koha-bugs] [Bug 17860] New: MARC records will stage, but Manage for import shows ' no data in table' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 Bug ID: 17860 Summary: MARC records will stage, but Manage for import shows 'no data in table' Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: gale at rabbat.net QA Contact: testopia at bugs.koha-community.org I have no difficulty staging bibliographic or authority records, but using management, yields 'no data in table'. Have tried the files on demo systems and they work. Don't understand what the trouble is. Have deleted and reinstalled Koha, have dumped mysql data and recreated database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:26:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 16:26:48 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 17:26:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 16:26:50 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 --- Comment #1 from Owen Leonard --- Created attachment 58649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58649&action=edit Bug 17859 - Move JavaScript to the footer on about and auth pages This patch modifies the about page and the login page templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test each page to confirm that JavaScript-based interactions are unaffected: - On the About page tabs and header menu dropdowns should work correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 19:35:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 18:35:34 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #2 from Claire Gravely --- Hiya. On the Koha About page I found that all the tabs were missing and being listed as bullet points. The content from all the tabs was being displayed in one go on the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:14:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 22:14:54 +0000 Subject: [Koha-bugs] [Bug 17860] MARC records will stage, but Manage for import shows ' no data in table' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 gale at rabbat.net changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 6 23:24:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jan 2017 22:24:34 +0000 Subject: [Koha-bugs] [Bug 17861] New: I cant install Koha on Debian Wheezy-Unmet dependences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17861 Bug ID: 17861 Summary: I cant install Koha on Debian Wheezy-Unmet dependences Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: felixchisoni at gmail.com QA Contact: testopia at bugs.koha-community.org Hello, I am installing Koha on Debian Wheezy (Fresh Installation). However, I have experienced the following error when I run "sudo apt-get install koha-common" The following packages have unmet dependencies: koha-common : Depends: libarchive-extract-perl but it is not installable Depends: libgd-perl but it is not installable Depends: libwww-youtube-download-perl but it is not installable E: Unable to correct problems, you have held broken packages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:34:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 09:34:05 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58649|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 58650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58650&action=edit [SIGNED-OFF] Bug 17859 - Move JavaScript to the footer on about and auth pages This patch modifies the about page and the login page templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test each page to confirm that JavaScript-based interactions are unaffected: - On the About page tabs and header menu dropdowns should work correctly Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:34:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 09:34:02 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:41:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 09:41:54 +0000 Subject: [Koha-bugs] [Bug 17861] I cant install Koha on Debian Wheezy-Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17861 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Marcel de Rooy --- Hi Felix, Wheezy is no longer supported. Please try Jessie. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:42:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 09:42:03 +0000 Subject: [Koha-bugs] [Bug 17861] I cant install Koha on Debian Wheezy-Unmet dependences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17861 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:54:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 09:54:30 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 10:54:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 09:54:33 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58566|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 58651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58651&action=edit [SIGNED-OFF] Bug 17812 - Return focus to barcode field after toggling on-site checkouts This patch changes the behavior of the checkout form so that after checking the "on-site checkouts" box the cursor focus is automatically moved to the barcode field. To test, apply the patch and enable the OnSiteCheckouts system preference. - Open any patron account in circulation. - Expand the "Checkout settings" panel. - Click the "On-site checkout" label or checkbox. - Confirm that the focus has moved to the barcode field. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 19:45:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 18:45:53 +0000 Subject: [Koha-bugs] [Bug 17752] Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17752 Cab Vinton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 21:46:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 20:46:41 +0000 Subject: [Koha-bugs] [Bug 17862] New: Misleading error message if Apache config is invalid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17862 Bug ID: 17862 Summary: Misleading error message if Apache config is invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: danmichaelo+kohabugs at gmail.com QA Contact: testopia at bugs.koha-community.org When I ran `koha_create`, I got the error message "Koha requires mpm_itk to be enabled within Apache in order to run." from the `check_apache_config` method even though I had mpm_itk enabled. The real problem was a typo in one of my Apache config file, but the test on line 148 in `koha_create` doesn't distinguish between an invalid Apache config and a valid Apache config with mpm_itk missing: /usr/sbin/apachectl -M 2> /dev/null | grep -q 'mpm_itk' I suggest to check for a valid Apache config before checking for mpm_itk. For instance like so: if ! /usr/sbin/apachectl configtest 2> /dev/null ; then cat 1>&2 < References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- If there is a rental fee and an overdue fine on the item the line will read: Yes (Item overdue or lost) Maybe, instead of showing yes or no, would it make more sense to show the amount? Then the user can check the fine display for details. Or we could keep the general (yes/no), but have it say as soon as there is any kind of fee/fine on the item? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:04:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:04:17 +0000 Subject: [Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|String change, message |When editing circulation |showing for confirm edit |conditions, only ask for |rule |confirmation when there is | |already a rule selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:10:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:10:14 +0000 Subject: [Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:10:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:10:17 +0000 Subject: [Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58408|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 58652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58652&action=edit [SIGNED OFF] Bug 17808: Fix behavior when editing a circ rule The original behavior is broken, see https://stackoverflow.com/questions/21410484/jquery-selector-to-find-out-count-of-non-empty-inputs Test plan: Edit a circ rule => Without this patch you get a useless message => With this patch, no message Edit a circ rule with content in inputs => With or without this patch you get a useful message Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:28:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:28:50 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I have tried testing this, but I had a lot of problems. My configuration: I created a new field and subfield 991$a, linked to CCODE for testing. The field and the subfield are marked as repeatable. Problem 0: - Try to repeat the field without filling in a value - It will not work, there is a JavaScript error message: TypeError: divs[i].getAttribute(...) is null cataloging.js:100:12 Problem 1: - Select a value for the subfield - Repeat the field - The value is copied form the original field into the repeated field (should be empty) Problem 2: - Try to clear the value in the repeated field using the X in the pull down. - It won't work. Problem 3: - Try to open the pull down in the repeated field - It won't work. I am not sure what's going on there, but something appears seriously wrong and makes it impossible to test this. I have restarted Plack, memcached and reloaded the page multiple times clearing the cache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:32:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:32:56 +0000 Subject: [Koha-bugs] [Bug 17863] New: Problems with repeating subfields linked to an authorised value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17863 Bug ID: 17863 Summary: Problems with repeating subfields linked to an authorised value Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I kinda hope it's only me, but this is what happens: I created a new field and subfield 991$a, linked to CCODE for testing. The field and the subfield are marked as repeatable. Problem 0: - Try to repeat the field without filling in a value - It will not work, there is a JavaScript error message: TypeError: divs[i].getAttribute(...) is null cataloging.js:100:12 Problem 1: - Select a value for the subfield. - Repeat the field. - The value is copied form the original field into the repeated field (should be empty). Problem 2: - Try to clear the value in the repeated field using the X in the pull down. - It won't work. Problem 3: - Try to open the pull down in the repeated field - It won't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:33:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:33:07 +0000 Subject: [Koha-bugs] [Bug 17860] MARC records will stage, but Manage for import shows ' no data in table' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 --- Comment #1 from gale at rabbat.net --- Created attachment 58653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58653&action=edit error log produced after attempt to stage and manage MARC records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:33:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:33:39 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17863 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:33:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:33:39 +0000 Subject: [Koha-bugs] [Bug 17863] Problems with repeating subfields linked to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17863 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17818 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:34:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:34:27 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 --- Comment #5 from Katrin Fischer --- I filed a separate bug for the behaviour I saw - bug 17863. Would be nice if someone could retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:39:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:39:01 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:39:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:39:05 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58331|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 58654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58654&action=edit [SIGNED OFF] Bug 17794: Menu items in Tools menu and Admin menu not showing bold when active but not on linked page To reproduce: admin-menu 1) Go to a page like admin/categories.pl 2) Click New Category 3) Notice Patron categories in the sidebar menu is no longer bold tools-menu 4) Go to a page like reviews/reviewswaiting.pl 5) Notice bold Comments in sidebar menu 6) Click Approved Comments tab 7) Notice no longer bold in sidebar menu To test: 8) Apply patch and refresh page 9) Follow above steps to reproduce bug, confirm that active links are always bold 10) Test with other links to confirm nothing has broken Special cases 11) Go To admin -> MARC bibliographic frameworks -> Actions for any framework -> MARC structure 12) Confirm sidebar menu link is still bold 13) Go to admin -> Authority types -> Actions for any auth type -> MARC structure 14) Confirm sidebar menu link is still bold 15) Click Actions for any tag -> Subfields 16) Confirm sidebar menu link is still bold 17) Go to admin -> OAI sets config -> Actions for any set -> Define mappings 18) Confirm sidebar menu link is still bold Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:43:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:43:50 +0000 Subject: [Koha-bugs] [Bug 17703] Add ISSN column in serials claims table - fix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17703 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Fridolin, can you check your test plan? I have tested, but didn't manage to not have the ISSN column filled on claim serials page. In your test plan you say: 2/ Do not choose a vendor and submit But this is not possible int he GUI - there is no empyt entry in the pull down and an entry there only appears for a vendor with late serial issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 7 23:55:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 22:55:38 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer --- Marc, your tests don't work for me in koha-shell on kohadevbox, but the feature itself works nicely. not ok 191 - Expecting no \#checkin_search # Failed test 'Expecting no #checkin_search' # at t/db_dependent/www/prefs-admin_search.t line 99. # searched: "\x{0a} https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58655&action=edit Test Cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:12:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:12:59 +0000 Subject: [Koha-bugs] [Bug 17864] Increase coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58655|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Comment on attachment 58655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58655 Test Cases Wrong patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:13:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:13:43 +0000 Subject: [Koha-bugs] [Bug 17864] Increase coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 --- Comment #3 from M. Tompsett --- Created attachment 58656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58656&action=edit Test Cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:14:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:14:22 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Serhij, can you please try to make a valid git patch file? You can use the git format-patch command or tCan you detail the problem a bit more? I am not sure why the mapping should be a problem.he git bz tool described in our wiki. Maybe the by should still be wrapped in a class? That way we could hide the whole line still without the by remaining. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:14:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:14:24 +0000 Subject: [Koha-bugs] [Bug 17864] Increase coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |17793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 [Bug 17793] Make sysprefs search show on all Administration pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:14:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:14:24 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17864 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 [Bug 17864] Increase coverage on admin pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:15:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:15:29 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58406|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Comment on attachment 58406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58406 Bug 17793: Test Cases moved to bug 17864, as per Katrin's suggestion. I'll tweak up the test coverage once the other two cases Katrin mentioned are dealt with. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:17:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:17:16 +0000 Subject: [Koha-bugs] [Bug 17612] Vocative version of name and surname: database and form field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Mike, I have never heard of this, can you maybe add an example so we get an idea how this looks like? Can the vocative version be generated or has it to be entered separately when the patron is registered? Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:22:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:22:40 +0000 Subject: [Koha-bugs] [Bug 17707] Check out and due date are same In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Can't reproduce this problem. Vimal, could it be: - a hard due date was set? - the patron expires on the due date and loan period is shortened? - was the due date shortened because the first item is on hold for another patron? This might be good to discuss on the mailing list first to narrow it down some more. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:27:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:27:03 +0000 Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to marc-subfields-structure.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800 --- Comment #5 from Katrin Fischer --- I like the consistency - we already have the sidebar menu for subfields on authority types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:32:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:32:23 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I can confirm. In my case it was a transfer slip, but the item didn't get changed to the transport status and the hold remains pending. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:44:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:44:11 +0000 Subject: [Koha-bugs] [Bug 17621] API: Should the 'updated_on' Patron field really be a datetime ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17621 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- (In reply to Jonathan Druart from comment #3) > It makes sense to me to have a datetime for this kind of info. You can > easily imagine a script processing the patron modified the last X hours, > instead of days. +1, I think it's also consistent with similar fields on other tables (items, issues, currency) and helps when trying to diagnose problems, say with a patron import script or similar. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:52:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:52:13 +0000 Subject: [Koha-bugs] [Bug 16584] All SQL queries should be compatible to 'ONLY_FULL_GROUP_BY'. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16584 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED Version|3.22 |master --- Comment #2 from Katrin Fischer --- Marking this duplicate to the omnibus bug for supporting newer MySQL versions. *** This bug has been marked as a duplicate of bug 17258 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 00:52:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jan 2017 23:52:13 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ngson2000 at yahoo.com --- Comment #4 from Katrin Fischer --- *** Bug 16584 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 11:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 10:24:21 +0000 Subject: [Koha-bugs] [Bug 17612] Vocative version of name and surname: database and form field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17612 --- Comment #4 from Radek ?iman (R-Bit Technology, s.r.o.) --- Hi Katrin, I believe Mike will agree with my answer so here it is... Let's say I want to call Katrin Fischer in a well-formed czech letter. Please allow me to rename you as Katka Fischerov?. Then I would call you as "Ahoj Katko Fischerov?". My name is Radek ?iman and I would be called as "Ahoj Radku ?imane". So some simple examples include: Mike => Miku Michal => Michale Karel Nov? => Karle Nov? Karel Nov?k => Karle Nov?ku And so on, and so on... There's no simple rule for it. There are to ways to solve this issue. The best one is to use a database (we have it as a free service for libraries - please see bug 17718) of *all* known firstnames and surenames to query for appropriate results or the other solution is to simply enter the right version manually in (currently missing) fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 11:25:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 10:25:51 +0000 Subject: [Koha-bugs] [Bug 17612] Vocative version of name and surname: database and form field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17612 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17718 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 11:25:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 10:25:51 +0000 Subject: [Koha-bugs] [Bug 17718] Allow usage of Smartform API (Czech only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17718 Radek ?iman (R-Bit Technology, s.r.o.) changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 12:18:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 11:18:43 +0000 Subject: [Koha-bugs] [Bug 17612] Vocative version of name and surname: database and form field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17612 --- Comment #5 from Katrin Fischer --- Hi Radek, thx for the examples, that's very interesting! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 8 22:07:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 21:07:23 +0000 Subject: [Koha-bugs] [Bug 17860] MARC records will stage, but Manage for import shows ' no data in table' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 gale at rabbat.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gale at rabbat.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:24:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:24:04 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #1 from Alex Buckley --- Created attachment 58657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58657&action=edit Bug 17855- In web installer step 3, automatically selected default data values are successfully being inserted into the database. These default data values are now displayed in step 3 with bulletpoints Bug 17855- Removed loop in web installer forcing users to update their database version. Changed default data values in web installer to be displayed with disabled selected checkboxes rather than bulletpoints The web installer step 3 now has disabled selected checkboxes. Bug 17855- Implemented automatic selection of all default data in web installer which are shown with non-editable bulletpoints Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt Changed mandatory in If statement to default for MARC flavours Changed the radiobuttons to bulletpoints for default settings Changed a few file name descriptions to reduce spacing in installer step 3 screen. removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:25:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:25:41 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #2 from Alex Buckley --- Created attachment 58658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58658&action=edit Bug 17855 - As with the last patch the updated web installers step 3 is showing bulletpoints for default data values which stops the user being able to unselect data neccisary to use Koha. Both the optional and default data in installer step 3 are being successfully inserted into the database. Unlike the previous patch the first three screens of the onboarding tool are not working successfully, but are fixed in later patches. Bug 17855 - All web installer data inserting successfully, along with initial 3 screens of onboarding tool which is not yet avaliable from web installer. In web installer step 3 MARC21 flavour selected by default. All web installer data inserting successfully Working insertion of default and optional options Correctly selected default marc flavour of marc21 Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Removed test text Non working first 3 screens and perl script of onboarding tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:26:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:26:09 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #3 from Alex Buckley --- Created attachment 58659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58659&action=edit Bug 17855 - Implemented basic and advanced setup modes in the web installer avalable on the MARC flavour selection page of step 3. The two setup modes change how the data installation page of step 3 looks: Basic setup displays all default data values with bulletpoints, and optional data values with a checkbox. Advanced setup displays default and optional data values with a checkbox. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:26:35 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #4 from Alex Buckley --- Created attachment 58660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58660&action=edit Bug 17855 - Finished front end of onboarding tool which user is redirected to (after authentication) after finishing the web installer. Finished and working front and backend of updated web installer, with basic and advanced setup modes. Bug 17855 - Finished updated web installer, onboarding tool displayed after installer finished. Front end of first two onboarding tool screens finished. Summary page available from Koha main page. Bug 17855 - Onboarding tool (not working yet) integrated with finished web installer. After finishing the web installer a login page will appear, enter the database administrator account credentials then the onboarding tool will appear. Working first screen of the onboarding tool accessed after web installer is finished Finished web installer with working first two screens of the onboarding tool with no database functionality backend Create a patron page is under way. Created a summary page of the onboarding tutorial. Link in More will take you to it. Visually working first 5 screens of the onboarding tool (no database functionality yet) and finished web installer Working visual front end of the first 7 screens of the onboarding tool working with a finished web installer Finished working front end of the onboarding tool and finished web installer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:27:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:27:20 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #5 from Alex Buckley --- Created attachment 58661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58661&action=edit Bug 17855 - Create library, patron category, and item type backends working successfully inserting into the database. Dropdown boxes of create circulation rule screen are now populated with values. Patron and circulation rule not yet inserting into the database. Bug 17855 - Checking if library, patron category, and item type have already been inserted into the database and if they have then the step to create them in the onboarding tool is skipped. Create a patron onboarding page now has populated dropdown boxes. Successful insertion of library and patron category from onboarding.pl (onboarding tool). Patron, item type and circulation rule not yet inserting into the database from onboarding.pl (onboarding tool). Bug 17855 - Fixed merge conflict in onboardstep0.tt. Library and patron category are being successfully inserted into the database from onboarding.pl, same as the previous patch. Bug 17855 - Finished front end of onboarding tool. Initial two screens of onboarding tool also have successful insertion into the database. Successfully working backend of create library and patron category pages. Thus library and patron cataegory are being inserted into the database from the onboarding.pl script Working front end of the onboarding tool with the correct button names and header names. And finished web installer Increased font size in summary page Working backend of the create library. With a check to determine if the library already exists before allowing the user to create a library. With finished web installer Created backend of patron category. Moved files around from default to optional for configuration settings. Fixed merge commit with onboardstep0.tt file Working library, and patron category checks and inserts into the koha database in the koha onboarding tool Working checks on the library, patron category, and item type with working library and patron category insertion to the database Drop downs are correctly showing existing information when creating a new patron. Still working on backend to add the patron to the database. Item type backend created and working as expected. Added drop down boxes in create circulation rule. Working on creating a circulation rule. Not yet complete. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:27:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:27:38 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #6 from Alex Buckley --- Created attachment 58662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58662&action=edit Bug 17855 - Working insertion of library, patron category, patron (with superlibrarian permissions asssigned), and item type Create circulation screens backend code to insert a circulation rule into the database not yet working. Bug 17855 - Same as previous patch with some minor changes to the code for step 2 (creating a patron category) in onboarding.pl Bug 17855 - Same as previous patch except made changes to the perl code for creating a patron category which is step 2 in the onboarding.pl script Bug 17855 - Successful insertion from onboarding tool of library, patron category, patron and item type. Successful checking if library, patron category and item type has been installed with web installer, and if they have been installed then the appropriate onboarding tool step is skipped. Bug 17855 - Working insertion of library, patron category and patron as well as checks for library, patron category, and item type in the onboarding tool. i.e. Very similar to the previous patch Error messages working for create library. In progress for patron category. Fixing the item type error handling. Still in progress. Correctly inserting patron so they can now log in with the patron account they create on the onboarding tool (no superlibrarian permissions yet) but the dropdown boxes on the create circulation rule screen no longer work Fixed some things I broke in patron category Fixed more of patron category. Should be working normally but error handling still not implemented. Same as previous Working insertion of the patron into the borrowers table and setting of superlibrarian permissions so the user can log in with the patron they create in the onboarding tool however the dropdown boxes in the create circulation rule screen now do not work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:28:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:28:12 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #7 from Alex Buckley --- Created attachment 58663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58663&action=edit Bug 17855 - Similar to the previous patch Have fixed the incorrect insertion of patron into the database Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Check the database to see that the library, patron category, patron, and item type are now being inserted successfully. bug 17855 - Similar to the previous patch, except perl code to prevent card number duplication is in the process of beign added to step 3 in the onboarding.pl script. Same test plan as previous patch Bug 17855 - Similar to the previous patch. Library, patron category, patron (with superlibrarian permissions) and item type are all being inserted from the onboarding.pl script into the database. Removed the error that was being displayed after the first of the two create circulation rule screens. Test plan 1. Run through the web installer and onboarding tool as outlined in: https://koha-community.org/manual/installation/html/ 2. Notice there is no error after the first of the two create circulation rule screens. 3. Check the database and you should see the library, patron category, patron, and item type have been inserted. Bug 17855 - Refined text inputs to numerical inputs in onboarding tool. Set minimum card number allowed to 1 for creating a patron screen. In addition to displaying patron category descriptions instead of codes in the dropdown boxes of the aforementioned screen. Implemented months and date check in the create patron category screen. Bug 17855 - Similar to the previous patch except for additional perl code for step 5 (create circulation rule) in the onboarding.pl script Months or dates check implemented in the create patron category screen 1 Changed patron category codes to descriptions in create a new patron Trying to fix default_privacy error Updated text input fields to transform text to capitalize or upper case as appropriate. Changed input fields to number rather than text where appropriate, minimum set to 0 Same as previous. Changed minimum to 1 for card number Working insertion of the item types with working dropdown boxes in the circulation rules screen Changed text to number input type Error no longer showing after the first create circulation rule screen. The patron is also being inserted to the database correctly with the superlibrarian privilages. Working on preventing card number duplication fixed minor error where i was incorrectly inserted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:28:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:28:59 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #8 from Alex Buckley --- Created attachment 58664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58664&action=edit Bug 17855 - Implemented a minimum and maximum card number allowed for the create patron screen of the onboarding tool. Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Notice on the first create patron screen you cannot enter a value lower than 1 for the card number 3.Check the database and you should see that the library, patron category, patron (with superlibrarian permissions), item type and circulation rule are all being successfully inserted into the database. Bug 17855 - Made card number required for the create patron screen to be submitted. Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Notice that you must enter a card number to submit the first create patron screen 3. Check the database to see that the library, patron category, patron, item type and circulation rule are all successfully inserting into the datbase. Bug 17855 - Circulation rule is now inserting into the database successfully. Therefore all 5 steps of the onboarding tool (creating a library, patron category, patron, item type and circulation rule) are successfully inserting into the database. Test plan: 1. Go through the web installer and onboarding tool as outlined in the below link: https://koha-community.org/manual/installation/html/ 2. Check the database to see that the library, patron category, patron, item type and circulation rule are all inserting correctly. 3. Notice there are no html regexes implemented on text input fields yet of the onboarding tool. Made card number required Added max and min length for card number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:29:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:29:53 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #9 from Alex Buckley --- Created attachment 58665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58665&action=edit Bug 17855 - The 'All' dropdown box option is working for patron categories, item types, and libraries for the create circulation rule screen of the onboarding tool. Test plan: 1. Go through the web installer and the onboarding tool (up to the point of creating a circulation rule in the onboarding tool) as outlined here: https://koha-community.org/manual/installation/html/ 2. When creating a circulation rule using the onboarding tool apply it to all patron categories, libraries and item types by leaving the default 'All' option in the respective dropdown boxes selected. 3.Having finished the onboarding tool log into the staff interface and go to Checkouts 4. Check out 2 items (of differing item types, e.g. book and cd) to 2 different patrons (these patrons need to be of different patron types to test the circulation rule properly), in two two different libraries 5. Notice that the due date for all the checkouts is the same. This is because the 'All' dropdown option is successfully applying the circulation rule to all libraries, item types, and patron categories as intended. Bug 17855 - 'All' option is working to select for a circulation rule to apply to all patron categories. Tested where there were two circulation rules; 'All, Books' as 5 days and 'All, Computer Files' as 2 days. Checked out each to 5 different types of borrowers, due date reflects the specified loan period. Test plan: 1. Go through the web installer and the onboarding tool (up to the point of creating a circulation rule in the onboarding tool) as outlined here: https://koha-community.org/manual/installation/html/ 2. When creating a circulation rule using the onboarding tool apply it to all patron categories by leaving the default 'All' option in the Patron categories dropdown box selected. 3.Having finished the onboarding tool log into the staff interface and go to Checkouts 4. Check out an item (this item must be the same item type that you applied the aforementioned circulation rule to) to 2 different patrons (these patrons need to be of different patron types to test the circulation rule properly). 5. Notice that the due date is the same for both patrons. This is because the 'All' dropdown button for patron categories in the onboarding tool is successfully applying the circulation rule to all patron categories. Bug 17855 - Working login of the web installer and onboarding tool Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Notice that the you can login after the onboarding tool in order to access the Koha main page Item type 'All' choice now working also. Tested same as previous. Library 'All' option now working for circulation rule, though more testing is needed. Cleaned up some other text and added a description to Create a Patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:36:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:36:32 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #10 from Alex Buckley --- Created attachment 58666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58666&action=edit Bug 17855 - Implemented minimum password length check, which will not allow a user to create a patron in the create patron screen of the onboarding tool if the patrons password is less than 3 characters. Test plan: 1. Go through the web installer and onboarding tool (up to the first create patron screen) as outlined here: https://koha-community.org/manual/installation/html/ 2. In the first create patron screen write in the same 2 character password into the 'Password' and 'Confirm Password' text inputs and submit the form 3. Notice that there is an error message telling you the password is too short Bug 17855 - Implemented properly formatted errors to be shown after submitting the first create patron screen in the onboarding tool if the inputted passwords do not match and/or the inputted card number already exists. This prevents a software error being displayed to the user. Test plan: 1. Go through the web installer (keeping the MACR21 and basic setup default options selected) 2. Select to install sample libraries, patron categories and patrons in the web installer step 3 3. Finish the remainder of the web installer as outlined in the above link 4. Go through the onboarding tool noticing that the forms to create a library, and patron category are skipped (with a skip message being displayed in their place). 5. On the create patron screen enter in the card number of 1 (which already exists because you added sample patrons in the web installer) and write in different passwords into the 'Password' and 'Confirm password' input fields. 6. Submit the Create patron form 7. Notice the error messages in a properly formatted onboarding tool screen. I.e. not software error messages. Click the 'Try again' button which returns you to the create patron screen to refill out the form again Bug 17855 - removed test displays of template variables in the second create patron screen of the onboarding tool Test plan: 1. Go through the web installer and onboarding tool (up to the second create patron screen) as outlined here: https://koha-community.org/manual/installation/html/ 2. Notice that there is no text saying 'nok is ' at the top of the second create patron screen Bug 17855 - Implemented html validation on the text input boxes for the create library screen in the onboarding tool. Test plan: 1. Go through the web installer and up to the create a library screen of the onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. In the onboarding tool enter special characters into the two text input boxes of the create library screen and try to submit the form. 3. Notice that the form will not submit until the special characters have been removed from the two text input fields Bug 17855 - Implemented a password check into the create patron screen so that when the user writes the patron password into the 'Password' and 'Confirm password' input boxes the password inputs are checked to make sure they are consistent. If the passwords are not the same then the patron record is not inserted into the datbase. Test plan: 1. Go through the web installer and onboarding tool (up to the first create a patron screen) as outlined here: https://koha-community.org/manual/installation/html/ 2. Enter in a different password in the 'Confirm Password' input to the 'Password' input. 3. Notice that the patron record is not instered into the borrowers table of the database when the passwords are not the same. HTML data validation of the library Trying to work out errors Working errors for password mismatch Password min length check is working for create a patron. Still need to fix user ID check and test if card number length is working. FOr now, Mika out! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:36:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:36:59 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #11 from Alex Buckley --- Created attachment 58667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58667&action=edit Bug 17855 - Tidied up the blank spaces and unnecessary comments in the onboarding.pl script Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. After finishing the onboarding tool login using the patron credentials of the patron you just created using the onboarding tool 3. Check you can create a library, patron category, item type, patron category, and circulation rule using the patron account you are currently logged in with Bug 17855 - Same as the previous patch Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Test the password and card number check and error display in the create patron screen of the onboarding tool by entering in different passwords in the two password fields and/or entering an existing password (which will only work if you installed sample patrons in the web installer). When you do this and submit the form errors should appear and you should be able to select the 'try again' button to get back to the first create patron screen. 3. After finishing the onboarding tool check the following tables of the database, they should all have records in them: branches, categories, borrowers, itemtypes and issuingrules Bug 17855 - Similar to previous patch All fields of the onboarding tool have been tested and they are all inserting correctly into the database Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. After finishing the onboarding tool write in the username and password of the patron you created using the onboarding tool, into the login page 3. Check your user has superlibrarian privilages by going to: 'Patron'-> click on the first letter of your logged in patron surname->'More'->'Set Permissions' You should see the patron has superlibrarian privilages. 4. Search in the database to make sure: *The library you created is in the borrowers table. *The patron category is in the categories table *The item type is in the itemtypes table *The circulation rule is in the issuingrules table Error messages working correctly and all objects being inserted correctly Start of onboarding.pl code tidied up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:37:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:37:32 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #12 from Alex Buckley --- Created attachment 58668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58668&action=edit Bug 17855 - Finished updated web installer and onboarding tool. Test plan: 1. Go through the web installer as outlined in the below link. But go through the web installer 4 times to test the basic and advanced setup modes of the web installer: https://koha-community.org/manual/installation/html/ Note: Each time you have finished the web installer restart memcached service with: sudo service memcached restart and drop and recreate the database. 2. Attempt 1 : Choose basic and MARC21. Notice the bulletpoints for default sample data on web installer step 3, and unticked checkboxes for optional data values. Attempt 2: Choose basic and UNIMARC, make the same observation as above. Attempt 3: Choose advanced and MACR21 notice all data values have unticked checkboxes (including the default data values) Attempt 4: Choose advanced and UNIMARC and make same observation as above. 3. After your fourth attempt do not restart memcached or drop and recreate the database. You will be redirected to the onboarding tool automatically after finishing the web installer. 4. Go through the onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 5. Whilst going through the onboarding tool write in special characters to all text input fields of the onboarding tool and try to submit the form. You should not be able to, due to html regexes being implemented. 6. In the create patron category form try to input a value into both the 'Months:' and 'Until date:' input fields. A message should appear beside the input boxes telling the you to only write in one date value 7. Select a date from the datepicker of the create patron category form 8. Continue through the rest of the onboarding tool as outlined in that above link 9. Once you have finished the onboarding tool and have logged in with the patron account you created in the onboarding tool, try to create a library, patron category, patron, item type and circulation rule. If you can create these then you know that the onboarding tool has successfully set up Koha for you. Therefore the onboarding tool is working as intended. Bug 17855 - In the onboarding tool the following has been implemented: * Pre-filled card number input field to prevent the user having to write in a number which could already exist thereby causing a duplicate cardnumber entry error. * Working html regexes on all inputs in the create patron category form as well as all other input fields in the onboarding tool. * Working datepicker in the create patron category form. It is working because when the user clicks on the calendar icon by the 'Until date:' input box a calendar appears and the user may select a date which is displayed in the said input box. * Working detection of invalid dates in the create patron category form * Fixed the bug in categories.pl which allowed users to write in an invalid date to the date input box and submit the form So now if the user writes in an invalid date a message box appears telling them what they entered was invalid Test plan: 1. Go through the web installer and onboarding tool (further instructions for onboaridng tool below) as outlined here: https://koha-community.org/manual/installation/html/ 2. Test every text input fields html regex in the onboarding tool by writing in special characters and then trying to submit the form. None of the forms should submit with special characters in any of the text input fields 3. Use the datepicker in the first create patron category screen, to choose a date from the calendar. 4. Try writing in an invalid date (e.g. 40/20/2018) to the 'Until Date:' field of the create patron category form. A messagebox should appear immediately and tell you the date you entered is invalid 5. Try writing a date in the 'Until date:' input and a number of months in the 'Months:' input. Because only one of these two fields should contain a value a message should appear alongside these fields to tell you to only input one date value. 6. Continue the onboarding tool as specified in the above link 7. Login using the newly created patron account 8. Go to More->Administration->Patron categories->New category try writing an invalid date into the 'Until date:' input. As with the onboarding tool a messagebox should appear asutomatically to tell you that the date you entered was invalid Bug 17855 - Implemented in the onboarding tool working html validation on all fields except the text inputs fields in the create patron category screen Test plan: 1. Go through the web installer as outlined here: https://koha-community.org/manual/installation/html/ 2. Try writing in special characters to all text input fields in the onboarding tool (except the create patron form text input fields which do not yet have working html regexes) You should not be able to submit the form with special characters in the text input fields Working html data validation of all onboarding tool steps Testing of the onboarding version Testing of version (second test) Working data validation of the patron categories Testing of version (second test) Testing the patron category Working insertion of all fields, and all except patron categories have successful data validation Tidied code with additional comments added and test text removed Valid cardnumber pre-written into patron form Prevents duplicate cardnumber entry Working regex on patron catgeory form Working patron category datepicker Does not allow user to use datepicker Working datepicker and month input check Form now only allows only one dateperiod input Working detection of invalid dates Fixed categories.pl invalid date check All neccisary functionality in onboarding tool User can still choose any patron category in patron form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:37:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:37:51 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #13 from Alex Buckley --- Created attachment 58669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58669&action=edit Finished initial web installer and onboarding tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 00:40:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 08 Jan 2017 23:40:44 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #14 from Alex Buckley --- I apologize that some of the commit messages have duplicates of other commit messages inside of them making them very long. I am still learning git and so will fix this as soon as possible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 02:18:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 01:18:26 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 07:59:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 06:59:17 +0000 Subject: [Koha-bugs] [Bug 17621] API: Should the 'updated_on' Patron field really be a datetime ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17621 --- Comment #5 from Martin Renvoize --- OK, I think my point here was more about the api returnter_capitadiscoverytnr field than the database field itself. a) If we're wanting to keep this as a datetime as opposed to a date without time then we really need to ensure we return a timezone along with it. b) The field name is misleading and non-standard for this sort of thing, 'updated_on' suggests a 'date' not a datetime.. 'updated' is a less specific term which commonly denotes a timestamp as opposed to a date. My point really is that the API should NOT simply reflect the database.. an API is meant to hide the data storage details and rather expose the 'objects' and 'methods' an api consumer can work with. Understanding of implementation details should not be required or indeed cared about by an api consumer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 08:00:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 07:00:52 +0000 Subject: [Koha-bugs] [Bug 17621] API: Should the 'updated_on' Patron field really be a datetime ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17621 --- Comment #6 from Martin Renvoize --- Man I hate not being able to edit comments in bugzilla! s/returnter_capitadiscoverytnr/return/g No idea how that crap got into that string. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 08:25:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 07:25:48 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #11 from Josef Moravec --- Created attachment 58670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58670&action=edit [SIGNED-OFF] Bug 17793: Test Cases There was no form of testing for the change. In order to test the perl-side of the changes, I just went to a variety of URLs to see if they have the expected three tabs. TEST PLAN --------- 1) Apply this patch 2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/ -- Or whatever yours is. With or without the trailing / 3) prove -v t/db_dependent/www/prefs-admin_search.t -- before applying the other patch, there should be failures. 4) Apply both patches 5) prove -v t/db_dependent/www/prefs-admin_search.t -- there should be no failures now. 6) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 08:26:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 07:26:26 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Attachment #58670|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 08:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 07:29:12 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #12 from Josef Moravec --- Sorry, I didn't notice, the changes here... Katrin, the test is working fine in koha-shell on kohadevbox for me... I noticed the missing elasticsearch mapping page, and think we should add it to clone-rules.pl too - it's not used directly, but can be, so for the case, it doesn't hurt to make the same change I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 08:32:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 07:32:03 +0000 Subject: [Koha-bugs] [Bug 17864] Increase coverage on admin pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Josef Moravec --- I think that should also test: searchengine/elasticsearch/mappings.pl clone-rules.pl (see comment 12 on bug 17793) preferences.pl systempreferences.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:05:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 08:05:20 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51100|0 |1 is obsolete| | Attachment #51101|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 58671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58671&action=edit Bug 16413: Change prototype of GetLatestAutoRenewDate Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate subroutines takes $borrowernumber and $itemnumber in parameter. They refetch the patron, item and issue information but they already are available from where they are called. It would make sense to change the prototype of these 2 subroutines to accept the patron, item and issue information directly to avoid unnecessary refetches. Test plan: Make sure this change does not introduce regressions on bug 15581 and bug 16344. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 08:05:23 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 --- Comment #8 from Jonathan Druart --- Created attachment 58672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58672&action=edit Bug 16413: Change prototype of GetSoonestRenewDate Same change as previous patch for the GetSoonestRenewDate subroutine. Test plan: Make sure this change does not introduce regressions on bug 7413. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:13:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 08:13:37 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #5 from Jonathan Druart --- Created attachment 58674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58674&action=edit Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber At this point, there should not be any occurrences of GetReservesFromItemnumber anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:13:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 08:13:41 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 --- Comment #6 from Jonathan Druart --- Created attachment 58675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58675&action=edit Bug 17737: Rename holds_placed_before_today with current_holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:13:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 08:13:33 +0000 Subject: [Koha-bugs] [Bug 17737] Move GetReservesFromItemnumber to Koha::Item->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58018|0 |1 is obsolete| | Attachment #58019|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58673&action=edit Bug 17737: Replace GetReservesFromItemnumber with Koha::Item->get_holds_placed_before_today On the same way of Koha::Biblio->get_holds, Koha::Biblio->get_holds_placed_before_today and Koha::Patron->get_holds, this new subroutin will permit to retrieve the holds placed on a specific item. Note that at the moment we do not need a Koha::Item->get_holds method: we do not want to display future holds placed in the future. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17738, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 09:55:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 08:55:42 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #4 from Claire Gravely --- tests failed for me: t/db_dependent/DecreaseLoanHighHolds.t (Wstat: 768 Tests: 17 Failed: 3) Failed tests: 6-8 Non-zero exit status: 3 Files=1, Tests=17, 5 wallclock secs ( 0.04 usr 0.00 sys + 4.19 cusr 0.36 csys = 4.59 CPU) Result: FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:01:04 +0000 Subject: [Koha-bugs] [Bug 17863] Problems with repeating subfields linked to an authorised value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- This looks like a duplicate of bug 17817. *** This bug has been marked as a duplicate of bug 17817 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:01:04 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Jonathan Druart --- *** Bug 17863 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:05:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:05:10 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 --- Comment #10 from Jonathan Druart --- Freerk, did you fix your problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:08:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:08:14 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17754 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:08:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:08:14 +0000 Subject: [Koha-bugs] [Bug 17754] MARCXML upload in Intranet is broken (encoding) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17754 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17842 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:20:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:20:06 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #1 from Jonathan Druart --- This seems to work for me, I have exported a record with 245$a "??? ? ?" from the cart and then reimported it (do not look for matching records, add incoming record, add items). The title appears ok during the whole import process. Do you mean you do not get this problem when exporting using the export records tool? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:21:18 +0000 Subject: [Koha-bugs] [Bug 17706] MARC staging fails with "Upload status: Denied" when memcached is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Lowering the severity as it's not confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:26:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:26:58 +0000 Subject: [Koha-bugs] [Bug 17865] New: If a subscription has no history end date, it shows as expired today in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Bug ID: 17865 Summary: If a subscription has no history end date, it shows as expired today in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If there is no subscription histenddate (NULL) in subscriptionhistory, the subscription will show as expired today in the OPAC. I think this happens becasue of this bit in GetSubscriptionsFromBiblionumber: 451 if ( $subs->{enddate} eq '0000-00-00' ) { 452 $subs->{enddate} = ''; 453 } else { 454 $subs->{enddate} = output_pref( { dt => dt_from_string( $subs->{enddate}), dateonly => 1 } ); 455 } I am not sure why this appears to return the current date, but it seems a good candidate to start the search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:27:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:27:15 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:47:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:47:06 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #12 from Marcel de Rooy --- test: obsoleted comment 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:47:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:47:46 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #13 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #12) > test: obsoleted comment 2 does not seem to work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:57:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:57:40 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 --- Comment #5 from Jonathan Druart --- See https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16.04_and_MySQL_5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:57:58 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > See > https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16. > 04_and_MySQL_5.7 On Ubuntu 16.04 (and others recent distro) now (Nov. 2016) is present MySQL 5.7. All version of Koha (3.x, 16.05, 16.11) are not compatible with default config of MySQL 5.7. To bypasss the problem you can: Install MariaDB instead of MySQL [ sudo apt-get install mariadb-server] OR Insert in your /etc/mysql/my.conf: [mysqld] sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION After save the changes and restart mysql. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:59:06 +0000 Subject: [Koha-bugs] [Bug 17258] [OMIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 [Bug 17860] MARC records will stage, but Manage for import shows 'no data in table' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:59:06 +0000 Subject: [Koha-bugs] [Bug 17860] MARC records will stage, but Manage for import shows ' no data in table' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |17258 --- Comment #2 from Jonathan Druart --- Hello, The relevant message is "stage-marc-import.pl: DBD::mysql::st execute failed: Field 'marcxml_old' doesn't have a default value". Indeed we have a sql query inserting a row in the import_records without specifying a value for this marcxml_old column (C4/ImportBatch.pm:1560 in _create_import_record). Take a look at this entry on the wiki page to know how to fix this problem: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16.04_and_MySQL_5.7 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 10:59:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 09:59:39 +0000 Subject: [Koha-bugs] [Bug 17860] MARC records will stage, but Manage for import shows ' no data in table' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |unspecified Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:01:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:01:01 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #2 from Katrin Fischer --- Hm, no. I get this when I export using the MARC option from the download menu. The attachement to the email (send cart) is fine. Which encoding did you pick for importing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:10:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:10:31 +0000 Subject: [Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #6 from Claire Gravely --- I have also been unable to reproduce the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:23:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:23:35 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Where is it displayed? On opac-detail I see "Subscription from: 01/01/2017 to: now (current)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:31:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:31:13 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 --- Comment #2 from Jonathan Druart --- Ok click on "More details" and arrived on /opac-serial-issues.pl Since 3.00.00.106 we should not have 0000-00-00 anymore in subscription.enddate, so 451 if ( $subs->{enddate} eq '0000-00-00' ) { should be 451 if ( not defined $subs->{enddate} ) { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:36:20 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Is this a regression or a behaviour change request? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:46:14 +0000 Subject: [Koha-bugs] [Bug 17774] Acquisitions module getting internal server error when adding orders to basket - a case of barcode not autoincrementing (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14752 --- Comment #2 from Jonathan Druart --- I cannot recreate. I have used the default configuration (ie. 952$p has plugin barcode.pl). When I order my first item, I get "No existing hbyymmincr barcodes found. Reverting to initial value. at /home/vagrant/kohaclone/C4/Barcodes/hbyymmincr.pm line 62." in the log, but the barcode field has correctly been set to CPL17010002. Then I ordered 2 more items, and got CPL17010003 and CPL17010004 generated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:46:14 +0000 Subject: [Koha-bugs] [Bug 14752] Add multiple copies to a basket at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17774 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 11:47:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 10:47:15 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Nick, is this ready to be tested? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:52:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 12:52:42 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #3 from Katrin Fischer --- I think the button was introduced not so long ago - not sure if it ever worked differently, but it should work differently. Does that make sense? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 13:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 12:53:02 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #4 from Katrin Fischer --- Having a book with the hold slip in it... that is not actually waiting is bound to cause you a lot of headache. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:02:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:02:13 +0000 Subject: [Koha-bugs] [Bug 17600] Standardize the EXPORT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 --- Comment #15 from M. Tompsett --- (In reply to Jonathan Druart from comment #14) > Maybe it would be easier not to export anything and use fully qualified > names instead? If someone has "use Foo;" in their code, they probably would rather write Bar() than Foo::Bar(); in their code. I know I would. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:03:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:03:21 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Patch doesn't apply --- Comment #76 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:09:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:09:21 +0000 Subject: [Koha-bugs] [Bug 17866] New: Change sender for serial claim notifications Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Bug ID: 17866 Summary: Change sender for serial claim notifications Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Currently, the From field uses the emailaddress of the staff client member from the user context. This is exceptional in Koha. And might very well, as in our case, be the cause of fraud detection warnings. We should branch email address or fallback to KohaAdminEmailAddress, as we do (almost) everywhere else. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:14:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:14:48 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:15:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:15:12 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:15:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:15:14 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 --- Comment #1 from Marcel de Rooy --- Created attachment 58676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58676&action=edit Bug 17866: Change sender for serial claim notifications Currently, the From field uses the emailaddress of the staff client member from the user context. This is exceptional in Koha. And might very well, as in our case, be the cause of fraud detection warnings. We should branch email address or fallback to KohaAdminEmailAddress, as we do (almost) everywhere else. Test plan: Go to subscription detail in Koha. Go to Claims. Select a missing issue and click Send notification. Verify the sender address in the generated notification. (Make sure that you receive this mail.) 0003-Bug-17736-Remove-C4-Reserves-GetReservesFromBiblionu.patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:15:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:15:33 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:16:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:16:04 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58676|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 58677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58677&action=edit Bug 17866: Change sender for serial claim notifications Currently, the From field uses the emailaddress of the staff client member from the user context. This is exceptional in Koha. And might very well, as in our case, be the cause of fraud detection warnings. We should branch email address or fallback to KohaAdminEmailAddress, as we do (almost) everywhere else. Test plan: Go to subscription detail in Koha. Go to Claims. Select a missing issue and click Send notification. Verify the sender address in the generated notification. (Make sure that you receive this mail.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:17:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:17:37 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #3 from Marcel de Rooy --- Oops, old function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:36:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:36:03 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58318|0 |1 is obsolete| | --- Comment #77 from Owen Leonard --- Created attachment 58678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58678&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:36:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:36:14 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58319|0 |1 is obsolete| | --- Comment #78 from Owen Leonard --- Created attachment 58679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58679&action=edit Bug 16239: Update templates Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:36:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:36:22 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58320|0 |1 is obsolete| | --- Comment #79 from Owen Leonard --- Created attachment 58680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58680&action=edit Bug 16239: Update css files Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:36:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:36:40 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58322|0 |1 is obsolete| | --- Comment #81 from Owen Leonard --- Created attachment 58682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58682&action=edit Bug 16239: Use inline-block for split buttons only in tables Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:36:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:36:32 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58321|0 |1 is obsolete| | --- Comment #80 from Owen Leonard --- Created attachment 58681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58681&action=edit Bug 16239: Update javascript files Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 15:36:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 14:36:48 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58323|0 |1 is obsolete| | --- Comment #82 from Owen Leonard --- Created attachment 58683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58683&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the
 tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 15:37:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 14:37:36 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 15:56:00 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 14:56:00 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #13 from M. Tompsett  ---
I ran:
$ git grep -l cat-search.inc | grep admin

This means I believe the outstanding ones are
(koha-tmpl/intranet-tmpl/prog/en/modules/):
- admin/auth_subfields_structure.tt
- admin/clone-rules.tt
- admin/marc_subfields_structure.tt
- admin/searchengine/elasticsearch/mappings.tt
- plugins/plugins-home.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 15:58:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 14:58:42 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 15:58:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 14:58:45 +0000
Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all
	Administration pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

--- Comment #14 from M. Tompsett  ---
Created attachment 58684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58684&action=edit
Bug 17793: Follow up for identified missing changes

I ran:
$ git grep -l cat-search.inc | grep admin

This means I believe the outstanding ones are
(koha-tmpl/intranet-tmpl/prog/en/modules/):
- admin/auth_subfields_structure.tt
- admin/clone-rules.tt
- admin/marc_subfields_structure.tt
- admin/searchengine/elasticsearch/mappings.tt

One other was recommended by Katrin in comment #9:
- plugins/plugins-home.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:02:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:02:23 +0000
Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792

--- Comment #13 from Tom?s Cohen Arazi  ---
Note for testers: this patches need to be tested with 13757 applied on top of
them. Otherwise some tests will be skipped.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:03:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:03:43 +0000
Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not
 bold when active but not on linked page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

--- Comment #7 from Owen Leonard  ---
These comments are not a criticism of this patch, but just something I've been
thinking about with regard to this area of the templates:

1. This is starting to get convoluted. At what point should we try to
reevaluate how we highlight menu items? Eventually the JavaScript becomes
almost as complicated as doing the logic in the template.

2. This way of doing things is going to create a problem for Bug 17858 because
these menu templates include jQuery JavaScript which the browser will attempt
to run before jQuery has loaded. We will need to figure out a way to make it
not break.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:20:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:20:57 +0000
Subject: [Koha-bugs] [Bug 17864] Increase coverage on admin pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

--- Comment #5 from M. Tompsett  ---
Created attachment 58685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58685&action=edit
Bug 17864: Test Cases

There was no form of testing for the change. In order to test
the perl-side of the changes, I just went to a variety of
URLs to see if they have the expected three tabs.

TEST PLAN
---------
1) Apply this patch
2) At the bash prompt, export KOHA_INTRANET_URL=http://localhost:8080/
   -- Or whatever yours is. With or without the trailing /
3) prove -v t/db_dependent/www/prefs-admin_search.t
   -- before applying the other patch, there should be failures.
4) Apply both patches
5) prove -v t/db_dependent/www/prefs-admin_search.t
   -- there should be no failures now.
6) run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:21:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:21:06 +0000
Subject: [Koha-bugs] [Bug 17864] Increase coverage on admin pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

--- Comment #6 from M. Tompsett  ---
Created attachment 58686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58686&action=edit
Bug 17864: Follow up to add missing tests

This adds tests for the missing items.
Remember the kohadevbox has annoying caching issues,
so close tab, vagrant halt, vagrant up just to be
certain you are not failing because of caching.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:22:53 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:22:53 +0000
Subject: [Koha-bugs] [Bug 17864] Increase coverage on admin pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58656|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:34:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:34:18 +0000
Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in
 authority-linked fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788

Hugo Agud  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Hugo Agud  ---
I have checked that all those fields are now indexed and this bugs it is signed
off BUT under  my undestading this opens a new bug regarding the authorities

For example 650  SUBJECT ADDED ENTRY--TOPICAL TERM and 690 - LOCAL SUBJECT
ADDED ENTRY--TOPICAL TERM (OCLC, RLIN)  POINTS TO the same authority base -->
TOPIC_TERM

Under my understanding Koha should have new authority for cocver 690, 691,
692...If I am not wrong, If we don't add new authotiries, the official and
local authorities will be the at the TOPIC_TERM and it is little weird

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:57:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:57:44 +0000
Subject: [Koha-bugs] [Bug 17867] New: Improve display of source (MARC21 773)
 in result list
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867

            Bug ID: 17867
           Summary: Improve display of source (MARC21 773) in result list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Currently only $t is shown. If there is no author in $a, the title goes in $a
and there is no $t. We should also catch this case and show at least a and t.

>From the XSLT:
 928     
 929         
 930             
 931     
 932     Source: 
 933             
 934     
 935             
 936         
 937     

Note: if there were multiple 773, the lable would be printed mulitple times.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 16:58:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 15:58:50 +0000
Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new
 onboarding tool feature to guide users through setting up Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

M. Tompsett  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #15 from M. Tompsett  ---
I was hoping to test this, but got:
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17855- In web installer step 3, automatically selected default
data values are successfully being inserted into the database.
Applying: Bug 17855 - As with the last patch the updated web installers step 3
is showing bulletpoints for default data values which stops the user being able
to unselect data neccisary to use Koha.
Applying: Bug 17855 - Implemented basic and advanced setup modes in the web
installer avalable on the MARC flavour selection page of step 3.
Applying: Bug 17855 - Finished front end of onboarding tool which user is
redirected to (after authentication) after finishing the web installer.
/home/vagrant/kohaclone/.git/rebase-apply/patch:391: trailing whitespace.

/home/vagrant/kohaclone/.git/rebase-apply/patch:402: trailing whitespace.
            
/home/vagrant/kohaclone/.git/rebase-apply/patch:410: trailing whitespace. /home/vagrant/kohaclone/.git/rebase-apply/patch:416: trailing whitespace. [% ELSE %] /home/vagrant/kohaclone/.git/rebase-apply/patch:470: trailing whitespace. [% END %] fatal: sha1 information is lacking or useless (installer/onboarding.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17855 - Finished front end of onboarding tool which user is redirected to (after authentication) after finishing the web installer. The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17855---Finished-front-end-of-onboarding-tool--YKACAI.patch Perhaps you have forgotten to obsolete older patches on this bug as well? Click Details, Edit details, check obsolete, and everything else is hopefully obvious. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 16:59:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 15:59:00 +0000 Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 --- Comment #14 from Chris Kirby --- (In reply to Tom?s Cohen Arazi from comment #13) > Note for testers: this patches need to be tested with 13757 applied on top > of them. Otherwise some tests will be skipped. applied the following patches:17755, 17813 (followed by updatedatabase.pl), 17792, (followed by updatedatabase.pl), 13757. 13757 doesn't apply cleanly over 17792: https://snag.gy/q4co8z.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:17:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:17:39 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:17:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:17:42 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58215|0 |1 is obsolete| | --- Comment #23 from Andrew Isherwood --- Created attachment 58687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58687&action=edit Bug 11897: Add Stockrotation CSS rules * koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:23:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:23:47 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58146|0 |1 is obsolete| | Attachment #58412|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 58688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58688&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:23:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:23:54 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #22 from Kyle M Hall --- Created attachment 58689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58689&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:24:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:24:46 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 --- Comment #26 from Olli-Antti Kivilahti --- Created attachment 58690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58690&action=edit Bug 17255 - Upgrade Elastic Search code to work with version 2.4+ - rebased wip -Changed deprecated facets to aggregations -Fixed boolean datatypes not allowing analyzers to be specified -Fixed deprecated '_id' to 'es_id'. Now the ES-index has the correct id==biblionumber ZE TEST PLAN 1. Reset Zebra index since facets are hard coded to dynamic search_marc_mappings. 2. perl misc/search_tools/rebuild_elastic_search.pl 3. Fetch all indexed records and the facet for subject__facet curl -XGET localhost:9200/koha_biblios/data/_search?pretty -d '{ "aggregations": { "my_agg": { "terms": { "field": "subject__facet" } } } }' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:24:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:24:55 +0000 Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:26:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:26:15 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:26:19 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58683|0 |1 is obsolete| | --- Comment #83 from Claire Gravely --- Created attachment 58691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58691&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the
 tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

Signed-off-by: Claire 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:26:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:26:18 +0000
Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with
	version 2.4+
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #27 from Olli-Antti Kivilahti  ---
Has there been any discussion about migrating to ElasticSearch 5.1 instead of
2.4?

I ran a small test setup back home (using Ubuntu16.04) during the weekends and
discovered that I had accidentally installed ElasticSearch 5.1 and Catmandu
dependencies from cpan, and that indexing and searching and deleting worked
with no probs using the Catmandu::Store::Elasticsearch perldoc examples with
"the" compatibility patch in the perldoc.

Will look into that tomorrow and hopefully provide a patch for running with ES
5.1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:26:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:26:30 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58216|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:26:35 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:26:35 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58217|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:26:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:26:40 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58280|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:26:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:26:44 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Andrew Isherwood  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58281|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:27:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:27:40 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #24 from Andrew Isherwood  ---
Created attachment 58692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58692&action=edit
Bug 11897: Add Stockrotation CSS rules

* koha-tmpl/intranet-tmpl/prog/css/staff-global.css: New rules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:28:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:28:49 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #25 from Andrew Isherwood  ---
Created attachment 58693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58693&action=edit
Bug 11897: Add Stock Rotation permissions to list

* koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: Add new
permissions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:29:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:29:30 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #26 from Andrew Isherwood  ---
Created attachment 58694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58694&action=edit
Bug 11897: Interface for rotas from Tools menu

* tools/stockrotation.pl: New file
* koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt: New file
* koha-tmpl/intranet-tmpl/prog/en/includes/stockrotation-toolbar.inc:

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:29:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:29:57 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #27 from Andrew Isherwood  ---
Created attachment 58695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58695&action=edit
Bug 11897: Interface for rota items from biblio

* catalogue/stockrotation.pl: New file
* koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/stockrotation.tt:
New file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:30:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:30:19 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #28 from Andrew Isherwood  ---
Created attachment 58696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58696&action=edit
Bug 11897: Add menu options for Stock Rotation

* koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc: Add
menu option
* koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc: Add menu
option
* koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt: Add menu
option

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:31:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:31:15 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Claire Gravely  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58691|0                           |1
        is obsolete|                            |

--- Comment #84 from Claire Gravely  ---
Created attachment 58697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58697&action=edit
Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client

This followup tweaks some CSS and markup in order to correct conflicts
between default Bootstrap styles and the expected (previous) style of
the staff client. Included:

- Corrections to the widths of some modals.
- Corrections to the style of the 
 tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:35:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:35:59 +0000
Subject: [Koha-bugs] [Bug 17868] New: Improve display of authors in cart and
	list emails
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17868

            Bug ID: 17868
           Summary: Improve display of authors in cart and list emails
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Lists
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The cart and list emails display a lot of subfields for the author. Example:

Author: Seemann, Christian --Bearb. --adp
$a $e $4

It would be nice to not display $4 (relator code) if there is $e (relator
term).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan  9 17:39:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 09 Jan 2017 16:39:05 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #29 from Andrew Isherwood  ---
(In reply to Owen Leonard from comment #22)

Hi Owen

Thanks *very* much for your feedback, hugely useful. I've just attached a bunch
of modified patches that address most of the points, pertinent comments below
each of your points.

> I've done a quick run-through of this and nothing looks broken. The tests
> all pass. I think the biggest gap is documentation. There should be a help
> file for the whole process, especially the things which aren't
> self-explanatory. For instance:
> 
> - What does the 'cyclical' setting do?
> - What is the purpose of the "Start" item in the stages
>   and duration column of the manage items table?
> - What does the "In demand" setting do?

Excellent point, we'll address that.

> Minor problems:
> 
> - Our capitalization rules say the heading should say
>   "Stock rotation" instead of "Stock Rotation"

Fixed  

> 
> - I don't the the alert-style div is correct for showing
>   a confirmation of items added. I would put the confirmation
>   message in a 
and show a > table of results below that. Yes, agreed, fixed. > - In the manage items table, there is no wrapping . I couldn't replicate this. I looked in the markup for the manage items table and there was definitely a wrapping . I'm not sure if I'm misunderstanding where you mean. > - The page title and breadcrumbs should be made more specific > for each page. For instance, when on the manage items page > the breadcrumbs should be: > > Home ? Tools ? Stock rotation > Manage items > > This provides an easily accessible link back to the main > stock rotation page. Yes, excellent point. This has now been addressed throughout. > Suggestions: > > - Add a toolbar to the manage items page with a 'New rota' > and 'Edit rota' buttons. Done. > - Move the add items forms to the top of the [items table] Done. > - In the manage items table, I think title and barcode > should link to the bibliographic record and items page, > respectively. Done. > - Make the manage items table a DataTable with sorting and > searching. Unless you think the items table will typically > hold so much data this would become cumbersome? I don't imagine it will, good suggestion. Done. > - Should item status information be displayed in the manage > items table? Is it relevant to the process to know whether > something is checked out, lost, etc? Not sure how immediately useful this will be, particularly as we're linking directly to the item from the barcode in the row. I got a consensus of opinions here and the majority felt it wasn't necessary. Thanks for the suggestion though. > - Since the drag-to-sort interaction is new to Koha it > probably needs a hint at the top to suggest it. (Looks > good and work well, though). Done. Again, thanks for your feedback. If you find time to go through the latest changes, I'd be very grateful. I'll update this bug when we have some accompanying docs. Cheers Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:46:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:46:25 +0000 Subject: [Koha-bugs] [Bug 17869] New: Don' t show pick-up library for holds in OPAC account when there is only one branch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Bug ID: 17869 Summary: Don't show pick-up library for holds in OPAC account when there is only one branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When there is only one branch in an installation, it makes no sense to show a pick-up library column in the holds list in the patron account in OPAC. We should remove it from display, as we do in other spots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 17:48:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 16:48:37 +0000 Subject: [Koha-bugs] [Bug 17869] Don' t show pick-up library for holds in OPAC account when there is only one branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17869 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:20:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:20:51 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58092|0 |1 is obsolete| | Attachment #58094|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 58698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58698&action=edit Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:20:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:20:48 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:25:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:25:24 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58698|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 58699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58699&action=edit Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:25:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:25:40 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58699|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 58700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58700&action=edit Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:25:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:25:47 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 --- Comment #13 from Kyle M Hall --- Created attachment 58701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58701&action=edit Bug 15897 - Folowup Revert "Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect" This reverts commit b6d5748c001febc5acd67938d12ba25844d11fbc. As this bug report no more uses the accounline_id parameter to identify account lines to pay in Koha::Account->pay, it should revert this, to use the new notation everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:25:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:25:50 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 --- Comment #14 from Kyle M Hall --- Created attachment 58702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58702&action=edit Bug 15897 [QA Followup] - Update unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:29:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:29:35 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58357|0 |1 is obsolete| | --- Comment #52 from Tom?s Cohen Arazi --- Created attachment 58703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58703&action=edit Bug 13757: (followup) Staff interface changes This patch adds proper extended attributes display and handling on the patron modifications moderation page (members-update.pl). It also adds changes checking to the opac-memberentry.pl page so it only saves a modification request if there are changes (it only checked regular fields and not the extended ones). Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:30:03 +0000 Subject: [Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:30:03 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:30:03 +0000 Subject: [Koha-bugs] [Bug 17870] New: Call to include file incorrectly moved into the footer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Bug ID: 17870 Summary: Call to include file incorrectly moved into the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: bouzid.fergani at inlibro.com, jonathan.druart at bugs.koha-community.org, katrin.fischer at bsz-bw.de, kyle at bywatersolutions.com, philippe.blouin at inlibro.com, testopia at bugs.koha-community.org Depends on: 17416, 17418 Blocks: 17858, 17859 In Bug 17418 I moved a line from doc-head-close.inc to js_includes.inc which I shouldn't have: -[% PROCESS 'html_helpers.inc' %] That file isn't JS and many pages depend on it being defined at the top of the page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416 [Bug 17416] Move javascript in doc-head-close.inc into a separate include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 [Bug 17859] Move JavaScript to the footer on about and auth pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:30:03 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:30:03 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:31:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:31:50 +0000 Subject: [Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 --- Comment #7 from Claire Gravely --- (In reply to Claire Gravely from comment #6) > I have also been unable to reproduce the issue. have now reproduced - will retest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:34:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:34:05 +0000 Subject: [Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:34:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:34:08 +0000 Subject: [Koha-bugs] [Bug 16984] Standing orders - when ordering a JS error is raised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16984 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57695|0 |1 is obsolete| | --- Comment #8 from Claire Gravely --- Created attachment 58704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58704&action=edit Bug 16984: Do not clone the item block for standing orders If AcqCreateItem is set to ordering and the basket is marked as "standing orders", when ordering a JS error is raised: additem.js:176 Uncaught TypeError: window[events[i]] is not a function The item block should not be displayed in that case. Test plan: - Set AcqCreateItem to "ordering" - Create a basket and tick the "Standing orders" checkbox - Add an order to this basket => Without this patch you get the JS error => With this patch applied you will not get it Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:36:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:36:01 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 --- Comment #1 from Owen Leonard --- Affected would be any templates which include: [% PROCESS options_for_libraries... or [% PROCESS options_for_authorised_value_categories... ...because those blocks are defined in html_helpers.inc. The breakage would only occur if you tried to add [% SET footerjs = 1 %] to any of those templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:44:27 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 --- Comment #2 from Owen Leonard --- Created attachment 58705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58705&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:44:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:44:23 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:58:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:58:35 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58657|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:58:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:58:52 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58658|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:59:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:59:25 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58659|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 18:59:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 17:59:41 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:00:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:00:03 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58661|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:01:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:01:39 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58351|0 |1 is obsolete| | --- Comment #53 from Tom?s Cohen Arazi --- Created attachment 58706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58706&action=edit Bug 13757: Add the option to set patron attributes editable in the OPAC Note: this is a squashed version of the original patchset, because it was needed This patch adds an opac_editable property of borrower attribute types that can be set in the interface. I'm removing work on OPAC and will refactor it, keeping the author attribution. Test plan: 1. Repeat the following with a new and existing borrower attribute type: 2. Verify that "Editable in OPAC" can only be checked if "Display in OPAC" is checked. 3. Verify that this new property is correctly saved. Signed-off-by: Aleisha Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:01:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:01:45 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58352|0 |1 is obsolete| | --- Comment #54 from Tom?s Cohen Arazi --- Created attachment 58707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58707&action=edit Bug 13757: DB update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:01:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:01:52 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58353|0 |1 is obsolete| | --- Comment #55 from Tom?s Cohen Arazi --- Created attachment 58708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58708&action=edit Bug 13757: OPAC changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:01:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:01:58 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58354|0 |1 is obsolete| | --- Comment #56 from Tom?s Cohen Arazi --- Created attachment 58709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58709&action=edit Bug 13757: DBIC update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:02:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:02:04 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58355|0 |1 is obsolete| | --- Comment #57 from Tom?s Cohen Arazi --- Created attachment 58710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58710&action=edit Bug 13757: Add extended attributes to the patron modification Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:02:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:02:12 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58356|0 |1 is obsolete| | --- Comment #58 from Tom?s Cohen Arazi --- Created attachment 58711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58711&action=edit Bug 13757: (followup) Remove warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:02:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:02:19 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58703|0 |1 is obsolete| | --- Comment #59 from Tom?s Cohen Arazi --- Created attachment 58712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58712&action=edit Bug 13757: (followup) Staff interface changes This patch adds proper extended attributes display and handling on the patron modifications moderation page (members-update.pl). It also adds changes checking to the opac-memberentry.pl page so it only saves a modification request if there are changes (it only checked regular fields and not the extended ones). Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:02:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:02:26 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58428|0 |1 is obsolete| | --- Comment #60 from Tom?s Cohen Arazi --- Created attachment 58713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58713&action=edit Bug 13757: (followup) Only touch opac_editable attributes As reported by Owen, the members-update.pl was showing every attributes the patron has (display issue) instead of showing only those affected by the changes. This patch fixes this by filtering the patron's attributes by opac editability. It also fixes Koha::Patron::Modification->approve so it only clears the attributes with the updating 'code' and leaves the others untouched. As its been coded so far (until someone refactors it all) the Koha::Patron::Modification object needs to contain all the attributes for a specific code. And it comes from parsing the UI's input. Tests for Koha::Patron::Modification->approve to come. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:02:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:02:31 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58429|0 |1 is obsolete| | --- Comment #61 from Tom?s Cohen Arazi --- Created attachment 58714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58714&action=edit Bug 13757: (followup) Regression tests for ->approve changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:02:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:02:39 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58581|0 |1 is obsolete| | --- Comment #62 from Tom?s Cohen Arazi --- Created attachment 58715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58715&action=edit Bug 13757: (followup) Fix authorized value display when opac_display & not opac_editable Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:03:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:03:38 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #16 from Alex Buckley --- M. Tompsett. Thank you of informing me of this. I have now gone through and obsoleted older patches including the patch that was causing the failure. So try seeing if it will apply for you now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:25:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:25:35 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #17 from M. Tompsett --- (In reply to Alex Buckley from comment #16) > M. Tompsett. Thank you of informing me of this. > > I have now gone through and obsoleted older patches including the patch that > was causing the failure. > > So try seeing if it will apply for you now. Still fails. I'm thinking you are patching an old version of master. You may need to rebase. $ git checkout master $ git pull $ git checkout -b bug_17855_retest1 origin/master $ git bz apply 17855 -- This should fail. $ git bz apply --abort $ git checkout bug_17855 -- probably discover your are out some changes, not just these. -- I'm assuming you generally name your branches bug_#####. $ git rebase origin/master $ git bz attach -e HEAD^^^^^^^^..HEAD -- there are 8 ^'s. That should get all your patches. $ git checkout bug_17855_retest1 -- probably some messages about being out of sync, doesn't matter. $ git reset --hard origin/master $ git bz apply 17855 -- hopefully this will work now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 19:35:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 18:35:13 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #3 from Barton Chittenden --- I think that --restart also has this issue. Here's a paste from a recent restart: sudo koha-plack --restart glenoaks [....] Restarting Plack daemon for glenoaks:[....] Stopping Plack daemon for gle[ ok :. [FAIL] Error: Plack already running for glenoaks: failed! failed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 20:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 19:43:06 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- There was another plug in that did a really cool single line at the top and highlight and update thing, but this generally works. An improvement would be highlighting changes, because if I put an invalid value in the field and then call up the builder, it defaults to a valid value in the part that is invalid. But I don't think this is a reason to block this. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 20:43:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 19:43:33 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 20:43:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 19:43:36 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 --- Comment #3 from M. Tompsett --- Created attachment 58716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58716&action=edit [SIGNED-OFF] Bug 17233 - Add 008 value builder plugin for MARC21 classifications This patch adds 008 cataloguing value builder for MARC21 classifications records (LCC, DDC/Dewey, UDC and so on). For most practical purposes, MARC21 classification records () are quite similar to regular MARC21 authority records, so handling them in Koha is (almost) achievable by means of the built-in 'regular' MARC21 authority records related functionalities, but there are some notable differences - in particular, 008 field length and format is not the same. To test: 1) apply patch 2) link the new plugin (marc21_field_008_classifications.pl) to the 008 field in the existing (or cloned, ..) authority framework of your choice 3) try to add, edit, re-edit 008 field using this "authority" framework, ensure that the new plugin behaves as it should according to the Library of Congress specifications for MARC21 classification records 008 field format (). Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 20:44:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 19:44:04 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55098|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 20:53:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 19:53:37 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #18 from Alex Buckley --- I will go through and rebase shortly and then push up the commits again for testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 21:05:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 20:05:07 +0000 Subject: [Koha-bugs] [Bug 17233] Add 008 value builder plugin for MARC21 classifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17233 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 21:29:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 20:29:43 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Linking the same authority type to multiple bibliographic fields should not cause any problem. As those are custom use fields, I think it's ok as it is. If someone needs a different framework for them, it can be added via the configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 21:30:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 20:30:52 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 9 22:02:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 21:02:27 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 --- Comment #28 from Chris Cormack --- (In reply to Olli-Antti Kivilahti from comment #27) > Has there been any discussion about migrating to ElasticSearch 5.1 instead > of 2.4? > > I ran a small test setup back home (using Ubuntu16.04) during the weekends > and discovered that I had accidentally installed ElasticSearch 5.1 and > Catmandu dependencies from cpan, and that indexing and searching and > deleting worked with no probs using the Catmandu::Store::Elasticsearch > perldoc examples with "the" compatibility patch in the perldoc. > > Will look into that tomorrow and hopefully provide a patch for running with > ES 5.1 Nope no discussion yet (5.1 only came out in December) But I think going to 5.1 seems sensible enough to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 00:23:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 09 Jan 2017 23:23:52 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 --- Comment #5 from M. Tompsett --- Comment on attachment 52152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52152 Bug 15908 - Remove use of recordpayment_selectaccts Review of attachment 52152: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15908&attachment=52152) ----------------------------------------------------------------- Perhaps it is an extra constraint, but the code isn't identical without it. Results should be identical though. ::: C4/Accounts.pm @@ -372,5 @@ > - > - my @lines = Koha::Account::Lines->search( > - { > - borrowernumber => $borrowernumber, > - amountoutstanding => { '<>' => 0 }, Why is... ::: members/paycollect.pl @@ +135,5 @@ > + > + my @lines = Koha::Account::Lines->search( > + { > + borrowernumber => $borrowernumber, > + accountno => { 'IN' => \@acc }, ... this not here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 01:16:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 00:16:55 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 --- Comment #5 from M. Tompsett --- Created attachment 58717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58717&action=edit Bug 15702: Trim whitespace from fields with non-whitespace data Since space may be a valid value for something, trimming what has non-whitespace was done. TEST PLAN --------- 1) Enter patron with spaces before, after, and both. 2) Apply patch. 3) Attempt to enter another patron with spaces before, after, and both. -- attempting to edit after saving will demonstrate the spaces were trimmed. 4) Attempt to edit the patron initially entered. -- while there may be spaces before, after, and both initially, after saving and trying to edit again, there will not be. 5) run koha qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 01:16:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 00:16:52 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 01:36:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 00:36:57 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |mtompset at hotmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 02:03:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 01:03:24 +0000 Subject: [Koha-bugs] [Bug 17871] New: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Bug ID: 17871 Summary: Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Colin Campbell and Fr?d?ric Demians mentioned in 2015 that Zebra facets don't work with YAZ 5.8.1: https://lists.katipo.co.nz/public/koha/2015-February/041987.html In 2016, Zeno said he couldn't get zebra::snippet to work: http://koha.1045719.n5.nabble.com/Zebra-the-elements-zebra-snippet-doesn-t-work-td5871444.html I've looked at Indexdata's YAZ git repo for 5.8.1: https://github.com/indexdata/yaz/blame/v5.8.1/src/retrieval.c And I think the problem is this commit: https://github.com/indexdata/yaz/commit/f24766f1e9fc5404fc0b512af8607d7f7054f4be At first, I thought the problem was with yaz_match_glob, but I've tested this function independently, and I think it's OK. I think the problem might be with how "el_best" is getting set. In theory, should be selected as el_best first... then zebra::* should be selected as it should have a true value returned from yaz_match_glob. (Note that "return 0" appears to indicate success for yaz_retrieval_request.) So if you try to use facets with YAZ 5.8.1, you get the following from Zebra: [25] Specified element set name not valid for specified database -- v2 addinfo ''. That makes it seem like el_best isn't being set at all... but I don't know. I'm going to email Indexdata and see what they come up with for this one. But in any case... I have a solution for now. If we remove the line and restart Zebra, we can get results using zebra::facet and zebra::snippet. I've tested this change with OpenSuse Leap 42.2 with Zebra 2.0.60 and YAZ 5.8.1, and it works, but I'd be interested in hearing about other people's experiences with older (and newer) versions of YAZ. With commit 67abcc64, Marcel actually removed most unnecessary retrieval elements, but Tomas added them back with ca074c92 along with the zebra::* line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 02:35:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 01:35:43 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #1 from David Cook --- I've sent emails to Adam Dickmeiss and info at indexdata.com, so hopefully IndexData can shine some light on this one. In the meantime, I think a configuration change would be acceptable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 02:37:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 01:37:30 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 02:37:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 01:37:33 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #2 from David Cook --- Created attachment 58718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58718&action=edit Bug 17871 - Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 Remove line , which causes retrieval failures for zebra::* elements when using YAZ 5.8.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 02:40:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 01:40:05 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 04:42:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 03:42:55 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 --- Comment #4 from Pongtawat --- Won't --restart work properly if stop work properly? >From the code, it seems that --restart just call stop and then start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 04:58:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 03:58:03 +0000 Subject: [Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814 --- Comment #5 from Pongtawat --- TEST PLAN --------- 1) Login to staff client and do something that will hold connection for a long time, e.g. a batch import or a slow report. 2) sudo koha-plack --stop mykoha 3) ps aux | grep plack <-- a Plack process will still running work in 1) 4) wait for 1) to finish and all Plack processes exit 5) sudo koha-plack --start mykoha 6) apply the patch 7) repeat step 1)-2) 8) ps aux | grep plack <-- There should be no Plack process running now 9) Note that work in step 1) might get terminated midway. Since we force Plack to stop after some wait. Alternatively, I think we can test with --restart too. Before patch, it should behave like in comment 3. After patch, it should restart properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 07:10:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 06:10:55 +0000 Subject: [Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- With plack changes and the like, this no longer applies. :( Tinkered with getting it up, but not finished, so marking does not apply until someone rebases or fixes it. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 07:53:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 06:53:49 +0000 Subject: [Koha-bugs] [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search ( histsearch.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13528 CC| |magnus at libriotech.no Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 [Bug 13528] Ability to search on the different isbn variations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 07:53:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 06:53:49 +0000 Subject: [Koha-bugs] [Bug 13528] Ability to search on the different isbn variations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17457 [Bug 17457] Use SearchWithISBNVariations in acquisition advanced search (histsearch.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 08:17:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 07:17:06 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 08:17:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 07:17:09 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58705|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 58719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58719&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 08:57:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 07:57:54 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 08:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 07:57:57 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58719|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58720&action=edit Bug 17870 - Call to include file incorrectly moved into the footer This patch moves a line of template code from js_includes.inc back into doc-head-close.inc where it belongs. To test, apply the patch and view a page which uses a template that depends on html_helpers.inc being processed. For example: - The set library page - The holds queue report - The new patron form The pages should work correctly. Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 09:16:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 08:16:01 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 09:16:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 08:16:04 +0000 Subject: [Koha-bugs] [Bug 17866] Change sender for serial claim notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58677|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 58721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58721&action=edit Bug 17866: Change sender for serial claim notifications Currently, the From field uses the emailaddress of the staff client member from the user context. This is exceptional in Koha. And might very well be, as in our case, the cause of fraud detection warnings. We should use branch email address or fallback to KohaAdminEmailAddress, as we do (almost) everywhere else. Test plan: Go to subscription detail in Koha. Go to Claims. Select a missing issue and click Send notification. Verify the sender address in the generated notification. (Make sure that you receive this mail.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 09:29:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 08:29:41 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #85 from Jonathan Druart --- Some quick remarks and questions: - Is it expected to have these "big" buttons everywhere? Why do we want to have bigger buttons? Note that some buttons have not been converted. - Some JS code have been commented in cateditor-ui.inc. I did not get why it is for. We should either add a comment to explain why it is commented, remove the code or let it as before. Otherwise everything looks fine, great job! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 09:30:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 08:30:01 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #86 from Jonathan Druart --- Created attachment 58722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58722&action=edit Bug 16239: Update Bootstrap's license on the about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:03:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:03:23 +0000 Subject: [Koha-bugs] [Bug 17872] New: Fix small error in GetBudgetHierarchy and one of its calls Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Bug ID: 17872 Summary: Fix small error in GetBudgetHierarchy and one of its calls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:09:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:09:58 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:10:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:10:01 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 --- Comment #1 from Marcel de Rooy --- Created attachment 58723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58723&action=edit Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls In aqbudgetperiods.pl a commented line is removed that contains a wrong userenv hash key. Should be branch instead of branchcode. In aqbudgets GetBudgetHierarchy is called with the same wrong userenv hash key. Should be userenv->{branch}. This made another bug visible: if you call GetBudgetHierarchy with a branch and without owner, the where clause should take into account that the branchcode can be empty (not null). Test plan: [1] Run Budgets.t [2] Run aqbudgets.pl from Administration [3] Add the show_mine=1 parameter in the URL [4] Change owner of one of the funds and repeat step 2 and 3. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:10:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:10:25 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Patch complexity|--- |Small patch Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:21:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:21:51 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:21:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:21:54 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58700|0 |1 is obsolete| | Attachment #58701|0 |1 is obsolete| | Attachment #58702|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 58724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58724&action=edit Bug 15897 - Use Koha::Account::pay internally for recordpayment_selectaccts This is the third patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:21:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:21:58 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 --- Comment #16 from Jonathan Druart --- Created attachment 58725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58725&action=edit Bug 15897 - Folowup Revert "Bug 15896: [QA Follow-up] Add accountlines_id parameter in paycollect" This reverts commit b6d5748c001febc5acd67938d12ba25844d11fbc. As this bug report no more uses the accounline_id parameter to identify account lines to pay in Koha::Account->pay, it should revert this, to use the new notation everywhere. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:22:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:22:02 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 --- Comment #17 from Jonathan Druart --- Created attachment 58726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58726&action=edit Bug 15897 [QA Followup] - Update unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:22:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:22:40 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 --- Comment #18 from Jonathan Druart --- Created attachment 58727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58727&action=edit Bug 15897: Update ->pay POD Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:29:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:29:03 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 [Bug 11882] Add a new button to the checkout confirmation dialog when checking out an on hold item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:29:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:29:03 +0000 Subject: [Koha-bugs] [Bug 11882] Add a new button to the checkout confirmation dialog when checking out an on hold item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17798 --- Comment #34 from Jonathan Druart --- @InLibro: It seems that the behaviour of this new button is not what people expects. Can you take a look at bug 17798? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:47:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:47:19 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #39 from Nick Clemens --- I no longer get an error when cancelling a hold, but the hold is not cancelled either. 'Safe in his arms' is a title in the bywater library which can be placed on hold (In reply to Srdjan Jankovic from comment #38) > I've fixed wrong descriptions in handlers. > > Unfortunately, I could not find a title that I could place a hold on. I've > made a "blind"-ish change for returns, works for checked out items, so I'd > imagine it would work with hold returns (cancellations). Can you please try > it with this patch. Also, can you please let me know which title could be > placed on hold so I can play with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:59:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:59:45 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 10:59:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 09:59:48 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58650|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58728&action=edit Bug 17859 - Move JavaScript to the footer on about and auth pages This patch modifies the about page and the login page templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test each page to confirm that JavaScript-based interactions are unaffected: - On the About page tabs and header menu dropdowns should work correctly Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:00:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:00:18 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- (In reply to Claire Gravely from comment #2) > Hiya. > On the Koha About page I found that all the tabs were missing and being > listed as bullet points. The content from all the tabs was being displayed > in one go on the page. It works for me, I suppose you did not correctly refreshed your browser cache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:19:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:19:50 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- Testing this with the OneClick digital credentials shared between ByWater/Catalyst I am not able to get any search results, I either get an error or a constant spin - does this work in your testing currently? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:52:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:52:38 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #87 from Josef Moravec --- Thanks for testing and feedback Jonathan! (In reply to Jonathan Druart from comment #85) > Some quick remarks and questions: > - Is it expected to have these "big" buttons everywhere? Why do we want to > have bigger buttons? The buttons in bootstrap 3 are a bit bigger than in version 2 by default. So button "levels" in Koha remains the same, but the absolute size of button is different. We can shift it down in Koha if we really wan't, but I don't think it is neccesary - from my point of view it more comfortable to use bigger buttons, but it's just my opinion, I don't have any data about that for now... > Note that some buttons have not been converted. Many buttons weren't transformed to bootstrap ever yet, I plan to make followup (omnibus) bug for using bootstrap everywhere where it makes sense. Mayby some buttons which are new due to continuing the work on Koha master, I updated this patchset about a month ago - I can make a followup, or we can decide to make it on another bug, what do you think? > - Some JS code have been commented in cateditor-ui.inc. I did not get why it > is for. We should either add a comment to explain why it is commented, > remove the code or let it as before. > Yep, we should remove this code, it was for styling of modals, which is now made differently. I'll add the followup patch > Otherwise everything looks fine, great job! Thanks! ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:53:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:53:22 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #88 from Josef Moravec --- Created attachment 58729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58729&action=edit Bug 16239: Followup - remove unusable js from cateditor-ui.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:56:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:56:34 +0000 Subject: [Koha-bugs] [Bug 17873] New: Make all buttons Bootstrap styled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 Bug ID: 17873 Summary: Make all buttons Bootstrap styled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Omnibus for making all buttons in Koha staff client styled by Bootstrap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:57:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:57:37 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #21 from Jonathan Druart --- Code review: 1/ Koha::UploadedFile a. Koha::UploadedFile->delete is weird, I'd suggest to call and return $self->SUPER::delete in any cases and warn only `unless -e $file`. As Koha::Object->delete returns 1 on success, I don't think you should return anything else. b. getCategories - use C4::Koha; is missing - The methods in itself should be moved to Koha::UploadedFiles. I'd even suggest to remove it, and call GetAuthorisedValues only once in tools/upload.pl. It does not make sense to call it 3 times in the same script. 2/ Koha::UploadedFiles a. ->delete should not be called after ->new, but directly (Koha::UploadedFiles->delete). I am wondering if what you are doing in this method should not be moved to Koha::Objects->delete because actually it is the expected behaviour I think. 3/ in tools/upload.pl, it's certainly better to use ->find($id) and then check if the public method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:57:58 +0000 Subject: [Koha-bugs] [Bug 17873] Make all buttons Bootstrap styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16239, 16545, 16542 Assignee|oleonard at myacpl.org |josef.moravec at gmail.com CC| |oleonard at myacpl.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 [Bug 16239] Upgrade Bootstrap in the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16542 [Bug 16542] Make edit and delete links styled buttons in patron categories administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 [Bug 16545] Make edit link a styled button in item search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:57:58 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 [Bug 17873] Make all buttons Bootstrap styled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:57:58 +0000 Subject: [Koha-bugs] [Bug 16542] Make edit and delete links styled buttons in patron categories administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16542 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 [Bug 17873] Make all buttons Bootstrap styled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:57:58 +0000 Subject: [Koha-bugs] [Bug 16545] Make edit link a styled button in item search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16545 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 [Bug 17873] Make all buttons Bootstrap styled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:58:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:58:57 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #89 from Josef Moravec --- (In reply to Josef Moravec from comment #87) > > Many buttons weren't transformed to bootstrap ever yet, I plan to make > followup (omnibus) bug for using bootstrap everywhere where it makes sense. > Bug 17873 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 11:59:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 10:59:20 +0000 Subject: [Koha-bugs] [Bug 17695] Frameworks not saving in IE11 when editing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17695 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:00:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:00:43 +0000 Subject: [Koha-bugs] [Bug 14448] Hypnotoad and Nginx config for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #11 from Olli-Antti Kivilahti --- Hi! I managed to get starman, the plack-server to do hot-reloads, so we might not be interested in maintaining Hypnotoad. Community runs the REST API on starman and this is the most convenient thing to do. I tried to get rid of Apache by running only starman behind haproxy, but starman couldn't beat apache2 in static content delivery so we still have apace2 around. The less services we need to run Koha, the better. So this feature is not maintained by us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:00:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:00:44 +0000 Subject: [Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 Bug 14747 depends on bug 14448, which changed state. Bug 14448 Summary: Hypnotoad and Nginx config for REST API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14448 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:06:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:06:00 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #91 from Olli-Antti Kivilahti --- Since the other one went to master, I dont see a point in this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:09:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:09:10 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:09:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:09:31 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58124|0 |1 is obsolete| | Attachment #58646|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 58730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58730&action=edit Bug 14187 - branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. Signed-off-by: Owen Leonard Test plan successful on all steps. Signed-off-by: Jonathan Druart Amended patch: Remove Schema changes from this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:13:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:13:00 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58678|0 |1 is obsolete| | --- Comment #90 from Jonathan Druart --- Created attachment 58731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58731&action=edit Bug 16239: Update Bootstrap to 3.3.7 Customization tool used. Javascript modules: alert button dropdown modal tooltip popover transition CSS modules: type code grid tables forms buttons responsive-utilities button-groups input-groups navs navbar breadcrumbs pagination pager labels badges thumbnails alerts progress-bars media list-group panels responsive-embed close component-animations dropdowns tooltip popovers modals Test plan: 1) Apply the patch 2) Try to go through interface to find problems, inconsistencies, etc. 3) Read the diff Migration guide for bootstrap: http://getbootstrap.com/migration/ Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:13:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:13:06 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58679|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart --- Created attachment 58732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58732&action=edit Bug 16239: Update templates Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:13:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:13:14 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58681|0 |1 is obsolete| | --- Comment #93 from Jonathan Druart --- Created attachment 58734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58734&action=edit Bug 16239: Update javascript files Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:13:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:13:10 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58680|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart --- Created attachment 58733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58733&action=edit Bug 16239: Update css files Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:13:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:13:18 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58682|0 |1 is obsolete| | --- Comment #94 from Jonathan Druart --- Created attachment 58735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58735&action=edit Bug 16239: Use inline-block for split buttons only in tables Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 12:13:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 11:13:22 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58697|0 |1 is obsolete| | --- Comment #95 from Jonathan Druart --- Created attachment 58736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58736&action=edit Bug 16239 [CSS Follow-up] Upgrade Bootstrap in the staff client This followup tweaks some CSS and markup in order to correct conflicts between default Bootstrap styles and the expected (previous) style of the staff client. Included: - Corrections to the widths of some modals. - Corrections to the style of the
 tag, seen often in MARC preview
  modals.
- Corrections to the default active and hover states for dropdown menus.

To test, apply the patch and view various pages which use Bootstrap
modals, confirming that they look correct.

- Add order from staged file MARC preview
- Add order from external source MARC preview
- Cataloging record merge MARC preview
- Batch record modification MARC preview
- Authorities Z39.50 search MARC preview

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:13:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:13:26 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58722|0                           |1
        is obsolete|                            |

--- Comment #96 from Jonathan Druart  ---
Created attachment 58737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58737&action=edit
Bug 16239: Update Bootstrap's license on the about page

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:13:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:13:30 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58729|0                           |1
        is obsolete|                            |

--- Comment #97 from Jonathan Druart  ---
Created attachment 58738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58738&action=edit
Bug 16239: Followup - remove unusable js from cateditor-ui.inc

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:14:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:14:58 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #98 from Jonathan Druart  ---
Josef,
Yes, everything else on another bug report :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:27:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:27:06 +0000
Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with
	Bootstrap modals
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:28:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:28:10 +0000
Subject: [Koha-bugs] [Bug 17874] New: Bug 16239 followup - update bootstrap
	3 usage
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874

            Bug ID: 17874
           Summary: Bug 16239 followup - update bootstrap 3 usage
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: josef.moravec at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:29:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:29:08 +0000
Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3
	usage
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16239
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |oleonard at myacpl.org
           Assignee|oleonard at myacpl.org         |josef.moravec at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239
[Bug 16239] Upgrade Bootstrap in the staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:29:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:29:08 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17874


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874
[Bug 17874] Bug 16239 followup - update bootstrap 3 usage
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:40:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:40:06 +0000
Subject: [Koha-bugs] [Bug 17875] New: Linking to series authority records
 fails when a space precedes the semicolon
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875

            Bug ID: 17875
           Summary: Linking to series authority records fails when a space
                    precedes the semicolon
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: lucy.vaux-harvey at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

A customer has reported that the automatic linking of series authority records
to series fields in the bib record (440 and 830) fails due to the space added
before the semicolon when series numbering is present.  Prescribed punctuation
for series fields requires a space before the semicolon so this space should be
ignored.

Example: 830 Series Added Entry ? Uniform title
Alcuin Club collections
links to authority record

Alcuin club collections ;
does not link to authority record

Background: ISBD punctuation, which is used in the most recent cataloguing
standard (RDA) and in the  preceding standard (AACR2), requires a space
semicolon at the end of a series statement if it is followed by series
numbering (cf.
http://www.ifla.org/files/assets/cataloguing/isbd/isbd-cons_2007-en.pdf , RDA
0.3.3 and AACR2 1.6 A1).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:48:26 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:48:26 +0000
Subject: [Koha-bugs] [Bug 17875] Linking to series authority records fails
 when a space precedes the semicolon
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875

Fiona Borthwick  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:50:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:50:23 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
	to a record
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570

--- Comment #23 from Nick Clemens  ---
Created attachment 58739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58739&action=edit
Bug 14570 - Followup

Fix small errors in update child script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:57:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:57:01 +0000
Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Claire Gravely  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 12:57:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 11:57:04 +0000
Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Claire Gravely  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57562|0                           |1
        is obsolete|                            |

--- Comment #2 from Claire Gravely  ---
Created attachment 58740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58740&action=edit
Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date
not on closed day (depending on useDaysMode)

Test plan:
1. ReturnBeforeExpiry is activated
2. useDaysMode is different from "circulation rules only"
3. Set expiry date of a patron to a near date
4. Set a closed day on calendar for this date
5. Do a checkout

Without patch, return date will be patron expiration date
With the patch, return date will be last open day before patron expiration day

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 13:21:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 12:21:58 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50224|0                           |1
        is obsolete|                            |

--- Comment #44 from Julian Maurice  ---
Created attachment 58741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58741&action=edit
Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved

- Check if borrower already has reserved the same biblio (or item).
- Check if borrower has reached the maximum number of holds allowed
  (syspref maxreserves)

The goal of this patch is to do these checks also when using ILS-DI
services HoldTitle and HoldItem

Test plan:
----------
Before patch:
1/ Set syspref maxreserves to 1
2/ Place some holds through ILS-DI and note that you can place more than
   1 hold for a borrower
3/ Try to hold the same biblio/item with the same borrower through
   ILS-DI and note that you can

Apply the patch
4/ Place some holds through ILS-DI, you shouldn't be able to place more
   than 1 hold for a borrower
5/ Try to hold the same biblio/item with the same borrower through
   ILS-DI. You shouldn't be able to do that.
6/ Try to place holds on staff interface and OPAC. The behaviour must be
   identical than before the patch.

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Sassmannshausen 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 13:22:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 12:22:07 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50225|0                           |1
        is obsolete|                            |

--- Comment #45 from Julian Maurice  ---
Created attachment 58742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58742&action=edit
Bug 11999: Check for age restriction in CanBookBeReserved

+ improve t/db_dependent/Reserves.t to make tests pass on UNIMARC
installation

Maxreserves and alreadyreserved works on ILSDI
Maxreserves works also on staff and opac
Already reserves works also on staff and opac
tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using
koha_ut db)

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 13:22:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 12:22:15 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

--- Comment #46 from Julian Maurice  ---
Created attachment 58743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58743&action=edit
Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved

Since bug 14695 it is possible to reserve more than one item per biblio

Also fix bad use of $item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 13:22:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 12:22:36 +0000
Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3
	usage
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874

--- Comment #1 from Josef Moravec  ---
Created attachment 58744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58744&action=edit
Bug 17874: Bug 16239 followup - polishing things

This patch is made on top of bug 16239 to polish things.

Makes these changes:
- Buttons on add circulation message modal
- Dropdowns has top and bottom margin 4px instead of 3px
- btn-link class (for example in toolbar on advanced search pages)
- Delete circ message is btn-link
- Add new circ message is btn-link

Test plan:
- Confirm that all changes are as described above and that they make sense

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 13:24:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 12:24:13 +0000
Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3
	usage
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Josef Moravec  ---
First followup for bug 16239, I am sure there are many other things to do, but
it would be useful to have any feedback on this and on the other possible
changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 13:26:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 12:26:09 +0000
Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239

--- Comment #99 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #98)
> Josef,
> Yes, everything else on another bug report :)

;)

I started working on it ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 13:26:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 12:26:48 +0000
Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and
 CanItemBeReserved
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 14:19:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 13:19:59 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40136|0                           |1
        is obsolete|                            |

--- Comment #74 from Julian Maurice  ---
Created attachment 58745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58745&action=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 14:20:07 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 13:20:07 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40137|0                           |1
        is obsolete|                            |

--- Comment #75 from Julian Maurice  ---
Created attachment 58746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58746&action=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 14:20:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 13:20:23 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40139|0                           |1
        is obsolete|                            |

--- Comment #76 from Julian Maurice  ---
Created attachment 58747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58747&action=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 14:20:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 13:20:32 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40161|0                           |1
        is obsolete|                            |

--- Comment #77 from Julian Maurice  ---
Created attachment 58748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58748&action=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 14:20:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 13:20:41 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43951|0                           |1
        is obsolete|                            |

--- Comment #78 from Julian Maurice  ---
Created attachment 58749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58749&action=edit
Bug 12395: QA follow-up - Add class/id to body tag

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 10 14:20:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 10 Jan 2017 13:20:49 +0000
Subject: [Koha-bugs] [Bug 12395] Save order line's creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45387|0                           |1
        is obsolete|                            |

--- Comment #79 from Julian Maurice  ---
Created attachment 58750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58750&action=edit
Bug 12395: Use standard 
+
    markup for showorder.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:22:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:22:00 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:25:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:25:59 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #80 from Julian Maurice --- Rebased on master. Bug 16592 already added the bootstrap modal to the parcel.pl page so I removed the related code from this bug's patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:30:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:30:36 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #92 from Kyle M Hall --- (In reply to Olli-Antti Kivilahti from comment #91) > Since the other one went to master, I dont see a point in this bug. Yeah, this should have been closed a long time ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:30:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:30:50 +0000 Subject: [Koha-bugs] [Bug 8809] Cascading Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8809 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Depends on|7710 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 [Bug 7710] multiple holds per title -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:30:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:30:50 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8809 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8809 [Bug 8809] Cascading Holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:34:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:34:35 +0000 Subject: [Koha-bugs] [Bug 17873] Make all buttons Bootstrap styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 --- Comment #1 from Owen Leonard --- I would like to hear about the plan for this. Should we try to create a style guide for buttons in toolbars vs. search header vs. standard submit buttons? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:35:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:35:19 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:35:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:35:39 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:48:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:48:43 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52153|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 58751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58751&action=edit Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:51:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:51:13 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52152|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 58752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58752&action=edit Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:56:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:56:04 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52153|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:56:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:56:17 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:56:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:56:37 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52152|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 14:56:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 13:56:49 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:04:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:04:28 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:05:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:05:28 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:08:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:08:42 +0000 Subject: [Koha-bugs] [Bug 17712] Move availability calculation to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:08:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:08:51 +0000 Subject: [Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:08:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:08:50 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52153|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 58753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58753&action=edit Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:11:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:11:42 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52152|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 58754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58754&action=edit Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:16:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:16:21 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:16:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:16:24 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58754|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 58755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58755&action=edit Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Laura Slavin Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:18:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:18:05 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58753|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 58756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58756&action=edit Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount Signed-off-by: Laura Slavin Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:18:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:18:03 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:27:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:27:41 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #21 from Andreas Hedstr?m Mace --- (In reply to Marcel de Rooy from comment #19) > Hi Andreas, > Thx for your feedback. > I read it again too now. This patch tries to achieve its goal by modifying > the expirationdate, while it actually should change this select in > CancelExpiredReserves? > > my $query = "SELECT * FROM reserves WHERE TO_DAYS( NOW() ) - TO_DAYS( > waitingdate ) > ? AND found = 'W' AND priority = 0"; > > If the holiday stuff is taken into account here, I am having the impression > that we achieve the same. Mabye Sonia or Alex can respond to that? Any word from Sonia or Alex regarding this (the suggestion from Marcel?)? We would very much like this to move forward, as is holiday is now creating problems with holds waiting on the shelves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:45:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:45:11 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 --- Comment #29 from Olli-Antti Kivilahti --- Created attachment 58757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58757&action=edit Bug 17255 - Upgrade Elastic Search code to work with version 5.1 Builds on top of commit: Bug 17255 - Upgrade Elastic Search code to work with version 2.4+ - rebased wip -Fix data type 'string' to 'keyword' and 'text' -index: not_analyzed deprecated, replaced with type: keyword which is equivalent -store: yes was deprecated, use store: true TODO: Installer bindings to both the debian package install and the raw developer install. A taster in Buug 17851 ZE TEST PLAN 0. Remove existing ES and reinstall ES 5.1 apt-get purge elasticsearch Follow instruction here: https://www.elastic.co/guide/en/elasticsearch/reference/current/deb.html 1. Reset Elasticsearch index since facets are hard coded to dynamic search_marc_mappings. 1a. perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings();' 1b. If you get trouble, simply DELETE FROM [search_fields|search_marc_to_fields|search_marc_mapping]; and retry 1a. 1c. Destroy elasticsearch index curl -XDELETE localhost:9200/koha_biblios so it can be recreated 2. Recreate the index: perl misc/search_tools/rebuild_elastic_search.pl 2a. Add something to index if your koha.biblio-table is empty 3. Fetch all indexed records and the facet for subject__facet curl -XGET localhost:9200/koha_biblios/data/_search?pretty -d '{ "aggregations": { "my_agg": { "terms": { "field": "subject__facet" } } } }' 4. Run the included tests: perl t/db_dependent/Koha_Elasticsearch_Indexer.t perl t/db_dependent/Koha_Elasticsearch.t perl t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t Have fun with your new ES 5.1 cluster! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:46:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:46:24 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Upgrade Elastic Search code |Upgrade Elastic Search code |to work with version 2.4+ |to work with version 5.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:49:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:49:05 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 --- Comment #30 from Olli-Antti Kivilahti --- Tested on Ubuntu16.04 with: -ES from their own apt-repo. -cpanm Catmandu::Store::Elasticsearch intra search works, facets work, adding records works, full reindex works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:53:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:53:33 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 --- Comment #3 from Jonathan Druart --- Created attachment 58758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58758&action=edit Bug 17778: Simplify fetch date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:57:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:57:35 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:57:38 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57992|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 58759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58759&action=edit [SIGNED-OFF] Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:57:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:57:49 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57993|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 58760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58760&action=edit [SIGNED-OFF] Bug 17588: get_account_lines->get_balance has been replace with account->balance On previous bugs Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 15:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 14:57:57 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58430|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 58761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58761&action=edit [SIGNED-OFF] Bug 17588: ->get_issues has been replaced with ->checkouts Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 16:27:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 15:27:56 +0000 Subject: [Koha-bugs] [Bug 17876] New: Show more invoice information in subscription details Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17876 Bug ID: 17876 Summary: Show more invoice information in subscription details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When using the acquisitions and the 'order from subscription' feature, there is an acquisition details block visible on the subscription detail page. This block shows the current order and the amount spent for the last order. In some cases, there are multiple invoices for a serial subscription during the year, for example, if they are paid quarterly. It would be helpful for the library if we could show all 'amounts spend' for the last and current year, to be able to compare and easily spot price changes. It might also be nice to have a 'show all' feature that gives you a complete overview. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 16:32:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 15:32:53 +0000 Subject: [Koha-bugs] [Bug 17877] New: Show internal and vendor note in acquisition info on subscription detail page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17877 Bug ID: 17877 Summary: Show internal and vendor note in acquisition info on subscription detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When using the 'order from subscription' feature in the acquisitions module, Koha shows acquisitions information on the subscription detail page in serials. It would be helfpul to also show the vendor and internal note from the acquisition order on this page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:16:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:16:04 +0000 Subject: [Koha-bugs] [Bug 17878] New: 008 tag editor not working with IE11 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17878 Bug ID: 17878 Summary: 008 tag editor not working with IE11 Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: lucy.vaux-harvey at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl A customer has reported that since upgrading to 16.05 the tag editor for the 008 field does not open when clicked when using Internet Explorer 11. It works correctly on other browsers such as Chrome. This was reported at a similar time to bug 17695 - also an IE11 browser issue in cataloguing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:25:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:25:17 +0000 Subject: [Koha-bugs] [Bug 17878] 008 tag editor not working with IE11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17878 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:28:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:28:39 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58688|0 |1 is obsolete| | Attachment #58689|0 |1 is obsolete| | Attachment #58739|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 58762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58762&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:28:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:28:46 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #25 from Kyle M Hall --- Created attachment 58763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58763&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:28:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:28:49 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #26 from Kyle M Hall --- Created attachment 58764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58764&action=edit Bug 14570 - Followup Fix small errors in update child script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:32:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:32:28 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58095|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 58765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58765&action=edit Bug 15898 - Use Koha::Account::pay internally for makepartialpayment This is the fourth patch in a series to unify all payment functions into a single mathod Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:33:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:33:27 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:33:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:33:30 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58756|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 58766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58766&action=edit Bug 15909 - Remove the use of makepartialpayment Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay" button, but make the payment for less then the full amount Signed-off-by: Laura Slavin Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:34:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:34:23 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 17:34:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 16:34:26 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58755|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 58767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58767&action=edit Bug 15908 - Remove use of recordpayment_selectaccts Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t 3) Test fine payment via the "Pay selected" button Signed-off-by: Laura Slavin Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 18:02:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 17:02:35 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58717|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 58768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58768&action=edit [SIGNED-OFF] Bug 15702: Trim whitespace from fields with non-whitespace data Since space may be a valid value for something, trimming what has non-whitespace was done. TEST PLAN --------- 1) Enter patron with spaces before, after, and both. 2) Apply patch. 3) Attempt to enter another patron with spaces before, after, and both. -- attempting to edit after saving will demonstrate the spaces were trimmed. 4) Attempt to edit the patron initially entered. -- while there may be spaces before, after, and both initially, after saving and trying to edit again, there will not be. 5) run koha qa test tools. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 18:02:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 17:02:32 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 18:20:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 17:20:09 +0000 Subject: [Koha-bugs] [Bug 17831] Item Search fails on custom subject search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #4 from Nick Clemens --- Created attachment 58769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58769&action=edit Bug 17831 - Item Search fails on custom subject search field This patch removes the assignment of non-existent koha field 'bibliosubject.subject' to MARC subject fields in the installer data for koha To test: You'll want a new fresh db 1 - Apply patch 2 - Run websintaller 3 - Ensure that thigns go smoothly 4 - Add/delete/edit some records and ensure that things are working with the installed frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 18:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 17:21:56 +0000 Subject: [Koha-bugs] [Bug 17831] Item Search fails on custom subject search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #5 from Nick Clemens --- (In reply to Katrin Fischer from comment #3) > Can you detail the problem a bit more? Should we change this bug to be a > clean-up bug for bibliosubject.subject in our default files? Yes, I think that is what we need to do, I threw it together quikc but haven't tested - wondering if I need to do '' instead of null - need to test but thought the patch would better illustrate the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:38:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:38:41 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52417|0 |1 is obsolete| | --- Comment #144 from Julian Maurice --- Created attachment 58770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58770&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:39:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:39:03 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52419|0 |1 is obsolete| | --- Comment #146 from Julian Maurice --- Created attachment 58772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58772&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:38:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:38:52 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52418|0 |1 is obsolete| | --- Comment #145 from Julian Maurice --- Created attachment 58771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58771&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:39:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:39:13 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52420|0 |1 is obsolete| | --- Comment #147 from Julian Maurice --- Created attachment 58773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58773&action=edit Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi Patch updated: use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:39:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:39:24 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52421|0 |1 is obsolete| | --- Comment #148 from Julian Maurice --- Created attachment 58774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58774&action=edit Bug 11708: Place "Basket groups" menu entry on top of the side navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:39:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:39:38 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55277|0 |1 is obsolete| | --- Comment #149 from Julian Maurice --- Created attachment 58775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58775&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:39:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:39:51 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55278|0 |1 is obsolete| | --- Comment #150 from Julian Maurice --- Created attachment 58776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58776&action=edit Bug 11708: UT: Replace 'ok' by 'is' where appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:39:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:39:58 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55279|0 |1 is obsolete| | --- Comment #151 from Julian Maurice --- Created attachment 58777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58777&action=edit Bug 11708: UT: Use DateTime instead of localtime+sprintf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:40:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:40:09 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #152 from Julian Maurice --- Created attachment 58778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58778&action=edit Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:40:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:40:34 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:52:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:52:37 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58662|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:52:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:52:54 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58663|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:53:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:53:19 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58664|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:53:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:53:36 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:53:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:53:52 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:54:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:54:08 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58667|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:54:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:54:20 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58668|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 19:54:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 18:54:33 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58669|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:08:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:08:25 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth at kul.oslo.k | |ommune.no --- Comment #2 from Benjamin Rokseth --- I notice this bug is rather old, but we actually suffered badly from this, as we have several fully automated branches that are open 24/7 without staff. Self service machines with reservation boxes often resulted in things checked in and patrons then turning up to collect their long-awaited material which is locked up in reservation boxes until next day. Our solution, by any mean not ideal, was to have separated branches for automated selfcheck machines, a SIP translation proxy that fixes the items that are NOT reserved so they can be put directly on the shelf, and finally a cronjob to clean up the branchtransfer mess. We (Oslo Public Library) would gladly cooperate on this if any good ideas turn up! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:10:05 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords|Academy | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:16:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:16:44 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:19:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:19:19 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:19:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:19:43 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #3 from Nick Clemens --- (In reply to Jonathan Druart from comment #2) > Nick, is this ready to be tested? Yes, should be, forgot to change status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:21:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:21:07 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #39 from Chris Cormack --- Kyle, we would like to get the academy students testing this again, but the patches do not apply. If you have a chance to rebase before Monday please do, otherwise please remove the Academy tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:21:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:21:43 +0000 Subject: [Koha-bugs] [Bug 9488] way to track who placed a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9488 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:23:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:23:01 +0000 Subject: [Koha-bugs] [Bug 7039] Link to existing record from result list in acquisition search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:23:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:23:20 +0000 Subject: [Koha-bugs] [Bug 17289] Holds awaiting pickup shows date unformatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17289 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:23:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:23:24 +0000 Subject: [Koha-bugs] [Bug 16816] Duplicate button on report results copies parameters used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16816 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:26:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:26:46 +0000 Subject: [Koha-bugs] [Bug 12374] Add koha-mqsqldump script, analagous to koha-mysql In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12374 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:27:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:27:58 +0000 Subject: [Koha-bugs] [Bug 17873] Make all buttons Bootstrap styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 --- Comment #2 from Josef Moravec --- (In reply to Owen Leonard from comment #1) > I would like to hear about the plan for this. Should we try to create a > style guide for buttons in toolbars vs. search header vs. standard submit > buttons? Plan is to make all buttons looks consistant. I think some style guide could be useful, size and other button styles should be same for buttons in same place and role, and should be written down for future reference... I could try write something on top of existing wiki pages... And we can discuss than. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:28:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:28:09 +0000 Subject: [Koha-bugs] [Bug 15195] patron details should open in tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15195 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:28:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:28:32 +0000 Subject: [Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:30:43 +0000 Subject: [Koha-bugs] [Bug 15571] reserveforothers permission does not remove Search to hold button from patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15571 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:31:08 +0000 Subject: [Koha-bugs] [Bug 14810] Improve messages in patron anonymizing tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14810 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:31:12 +0000 Subject: [Koha-bugs] [Bug 15598] Typo in subscription-add.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15598 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:31:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:31:24 +0000 Subject: [Koha-bugs] [Bug 15602] Accessibility: Can' t tab to add link in patron card creator add patrons popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15602 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:31:34 +0000 Subject: [Koha-bugs] [Bug 15600] System preferences broken toolbar looks broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15600 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:33:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:33:50 +0000 Subject: [Koha-bugs] [Bug 14538] POD for CalcFine is incomplete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14538 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:33:58 +0000 Subject: [Koha-bugs] [Bug 14406] When adding messages in patron account, only first name is shown in pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14406 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:34:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:34:03 +0000 Subject: [Koha-bugs] [Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:34:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:34:11 +0000 Subject: [Koha-bugs] [Bug 14624] <> for advance_notices.pl wrongly documented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14624 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:34:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:34:16 +0000 Subject: [Koha-bugs] [Bug 14613] Send cart window is too small in staff and hides 'send' button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14613 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:34:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:34:21 +0000 Subject: [Koha-bugs] [Bug 15579] records_batchmod permission doesn' t allow access to batch modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:36:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:36:08 +0000 Subject: [Koha-bugs] [Bug 15603] Accessibility: Can' t tab to select link in budgets add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15603 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:36:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:36:12 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can' t tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:36:20 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:36:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:36:29 +0000 Subject: [Koha-bugs] [Bug 15468] Search links on callnumbers with parentheses fails on OPAC results page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:36:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:36:33 +0000 Subject: [Koha-bugs] [Bug 15597] Typo in opac-auth-detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15597 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:36:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:36:39 +0000 Subject: [Koha-bugs] [Bug 15298] z39.50 admin setup, options column suggested changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:36:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:36:59 +0000 Subject: [Koha-bugs] [Bug 15560] Multiple holding branchs and locations not displaying in pending holds report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15560 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:37:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:37:04 +0000 Subject: [Koha-bugs] [Bug 14193] Accessibility: Searching patrons using the alphabetic index doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14193 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:37:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:37:09 +0000 Subject: [Koha-bugs] [Bug 11937] opac link doesn't open in new window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:37:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:37:14 +0000 Subject: [Koha-bugs] [Bug 15631] Move the cities related code to Koha::Cities - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:39:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:39:13 +0000 Subject: [Koha-bugs] [Bug 13527] Mixed content warnings in results and detail with Google images on https In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13527 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:40:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:40:14 +0000 Subject: [Koha-bugs] [Bug 15604] Accessibility: Can' t tab to select link in acquisitions basket add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15604 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:57:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:57:12 +0000 Subject: [Koha-bugs] [Bug 15515] Date of Birth gadget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15515 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Chris Cormack --- *** This bug has been marked as a duplicate of bug 12342 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 20:57:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 19:57:12 +0000 Subject: [Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com --- Comment #16 from Chris Cormack --- *** Bug 15515 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:23:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:23:41 +0000 Subject: [Koha-bugs] [Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #10 from Benjamin Rokseth --- reverting the 'in discussion' status as the discussion died. The patch is still valid as the initial SIP2 checkin code is flawed. Alert type CV04 (transfer with no holds) needs to be accompanied with CT destination branch. This patch fixes this in the cases where permanent location is not the right return branch (AddReturn returns messages WrongBranch, WrongTransfer or NeedsTransfer) If AutomaticItemReturn is disabled, return branch is given as value of NeedsTransfer, so test plan is still valid before patch 1) Switch off AutomaticItemReturn 2) Checkin item at a different branch than home or holding branch 3) observe CV04 but no CT field in SIP response after patch repeat 1-2 3) observe CT branch according to circulation policies in preferences 4) checkin item at wrong branch, observe again CV04 and CT with correct branch even if it was originally signed off it might need an extra pair of eyes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:29:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:29:45 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:29:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:29:48 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57851|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 58779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58779&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'issue notes pending'. 14) Go to circulation home page. There should be no link to Issue notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Issue notes pending: 2' 17) Go to circulation home page. There should be a link to Issue notes. Click Issue notes 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 22) Confirm the barcode link to the item works as expected. 23) Confirm the cardnumber link to the user works as expected. 24) Confirm all table details show correctly. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:35:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:35:12 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58779|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 58780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58780&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'issue notes pending'. 14) Go to circulation home page. There should be no link to Issue notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Issue notes pending: 2' 17) Go to circulation home page. There should be a link to Issue notes with a 2 next to it. Click Issue notes 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 22) Confirm the barcode link to the item works as expected. 23) Confirm the cardnumber link to the user works as expected. 24) Confirm all table details show correctly. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:46:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:46:23 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #19 from Alex Buckley --- Created attachment 58781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58781&action=edit Bug 17855 - Finished updated web installer (basic and advanced setup modes have not yet been implemented). Bulletpoints are now being displayed for all default data values in both the UNIMARC and MARC21 setups. Test plan: 1. Go through the web installer as outlined in this guide: https://koha-community.org/manual/installation/html/ Note: The basic and advanced setup modes on the MARC falvour selection page have not yet been implemented. Notice during your testing: The default data values for both the UNIMARC and MARC21 are displayed with bulletpoints whilst the optional data values are displayed with checkboxes. Bug 17855 - Initial updated web installer implemented with mandatory data values moved to the default folder and changed the checkbox display to bulletpoints for the default data values. Test plan: 1. Go through the web installer up to step 3, as outlined in this guide: https://koha-community.org/manual/installation/html/ Notice in web installer step that the header "mandatory" has been replaced with "default". These default data values are displayed with bulletpoints rather than checkboxes. Changed a few file name descriptions to reduce spacing in installer step 3 screen. removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Working insertion of default and optional options -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:46:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:46:49 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #20 from Alex Buckley --- Created attachment 58782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58782&action=edit Bug 17855 - onboarding.pl script created Initial 3 screens of the onboarding tool have been created Test plan: 1. Go through the web installer are outlined in this guide: https://koha-community.org/manual/installation/html/ 2. Because the onboarding tool and web installer have not yet been implemented to see the first screen of the onboarding tool write in the URL localhost:8081//cgi-bin/koha/installer/onboarding.pl?step=1 Then just select the 'Submit' or 'Next>>' buttons to see the subsequent two pages of the onboarding tool Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:47:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:47:30 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #21 from Alex Buckley --- Created attachment 58783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58783&action=edit Correctly selected default marc flavour of marc21 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:48:53 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:49:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:49:30 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #22 from Alex Buckley --- Created attachment 58784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58784&action=edit Bug 17855-Same as previous Test plan: 1. Go through web installer and onboarding tool as outlined in this guide: https://koha-community.org/manual/installation/html/ This is a combination of 2 commits. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:50:05 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #23 from Alex Buckley --- Created attachment 58785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58785&action=edit Bug 17855 - Finished updated web installer and onboarding tool Test plan: 1. Go through the web installer and onboarding tool as outlined in this guide: https://koha-community.org/manual/installation/html/ This is a combination of 6 commits. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 22:50:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 21:50:37 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58780|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 58786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58786&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'issue notes pending'. 14) Go to circulation home page. There should be no link to Issue notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Issue notes pending: 2' 17) Go to circulation home page. There should be a link to Issue notes with a 2 next to it. Click Issue notes 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 22) Confirm the barcode link to the item works as expected. 23) Confirm the cardnumber link to the user works as expected. 24) Confirm all table details show correctly. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 23:02:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 22:02:38 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58609|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia --- Created attachment 58787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58787&action=edit Bug 15326: [FOLLOW-UP] Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 23:20:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 22:20:31 +0000 Subject: [Koha-bugs] [Bug 17879] New: Possible to upload images with no image name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Bug ID: 17879 Summary: Possible to upload images with no image name Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org This is a problem because the image name is used in the patron card layout editor, and if a person uploads a bunch of images with no names then it will be difficult to tell which image is which. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 23:23:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 22:23:29 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 23:23:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 22:23:33 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 --- Comment #1 from Aleisha Amohia --- Created attachment 58788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58788&action=edit Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 23:23:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 22:23:41 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |aleishaamohia at hotmail.com |u | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 10 23:34:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 22:34:14 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #3 from David Cook --- I've received a reply from Adam at IndexData, and he's included a fix in YAZ 5.20.0: --- 5.20.0 2017/01/10 yaz-url: ignore content-length for HTTP method HEAD YAZ-878 retrieval: fix incorrect backend schema YAZ-877. Should fix https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 record_conv: allow HTTP method to be set for authority lookup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 00:16:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 10 Jan 2017 23:16:07 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #4 from David Cook --- Here's the contents of the email that Adam sent me: Hi David, we've looked at this and it should be fixed as part of YAZ [5.20.0] which will be released shortly. For a configuration like this: and using elem zebra::snippet the backend_schema i set to the name attribute zebra::* . The expected result is that the backend schema is set to the used element set zebra::snippet (Zebra issues error when getting zebra::*, but supports zebra::snippet). For YAZ 5.8.0 and earlier, the first rule was matched .. For YAZ 5.8.1 the 2nd rule is matched when using zebra::snippet. So to some extend this error was hidden by the first rule, but the bug has probably always been there. -- So in 5.8.0, the second rule wasn't being used anyway, so I think we're safe to remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:22:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:22:27 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #24 from M. Tompsett --- (In reply to Alex Buckley from comment #23) > This is a combination of 6 commits. And it still doesn't apply. I attempted interactively to apply each of the patches individually just to master, and none of them do. I was thinking they are out of order, did you git pull AND git rebase origin/master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:36:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:36:39 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #25 from Alex Buckley --- Did you get the same 'fatal: sha1 information is lacking or useless' error stopping the patch apply? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:43:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:43:19 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:43:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:43:23 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 --- Comment #1 from Aleisha Amohia --- Created attachment 58789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58789&action=edit Bug 17181: Check for duplicate image names when uploading image to patron card creator This patch adds a check for duplicates before uploading the image. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) If you haven't already, upload an image 3) Try to upload another image with the same image name 4) Notice the first image is replaced with the second image, with no warning. 5) Apply patch and refresh page 6) Try to upload an image with the same image name again 7) Notice you are now warned about a duplicate image name. 8) Check that uploading an image with a unique name still works. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:43:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:43:31 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|cnighswonger at foundations.ed |aleishaamohia at hotmail.com |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:44:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:44:59 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:45:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:45:04 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58520|0 |1 is obsolete| | Attachment #58522|0 |1 is obsolete| | --- Comment #40 from Srdjan Jankovic --- Created attachment 58790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58790&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:46:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:46:06 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58521|0 |1 is obsolete| | --- Comment #41 from Srdjan Jankovic --- Created attachment 58791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58791&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 01:49:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 00:49:06 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #42 from Srdjan Jankovic --- Sorry Nick, was a bug. Fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 02:30:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 01:30:42 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #26 from M. Tompsett --- (In reply to Alex Buckley from comment #25) > Did you get the same 'fatal: sha1 information is lacking or useless' error > stopping the patch apply? $ git checkout -b bug_17855_round2 origin/master $ git pull $ git remote update -p -- now I know this new branch is up to date. -- this is the beginning of a looping block $ git bz apply 17855 ... i -- for interactive -- There are 4 patches, comment out all but the first, the first time. -- Comment out all but the second, the second time. -- Comment out all but the third, the third time. -- Comment out all but the fourth, the fourth time. -- comments are lines beginning with # :wq -- I use vim, so whatever writes and quits is what you want -- now you will see the massive failure to apply $ git bz apply --abort $ git reset --hard origin/master -- loop 4 times from the beginning of the looping block And yes, yes it was. Attempting all four patches individually means I know that you didn't accidentally screw up the order of the patches on this bug, which is way to easy to do. Looking forward to testing something once it applies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 02:31:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 01:31:28 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | --- Comment #27 from M. Tompsett --- Seeing as it is your bug, Alex, I fixed the assignee. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:23:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:23:53 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #28 from Alex Buckley --- Created attachment 58792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58792&action=edit bug 17855 - Updated web installer finished Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer as outlined in this guide: https://koha-community.org/manual/installation/html/ Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:24:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:24:43 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:25:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:25:03 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:25:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:25:17 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:25:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:25:32 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:26:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:26:08 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #29 from Alex Buckley --- Created attachment 58793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58793&action=edit Bug 17855 - onboarding.pl script has been created. The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:26:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:26:48 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #30 from Alex Buckley --- Created attachment 58794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58794&action=edit Finished initial web installer and onboarding tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 04:33:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 03:33:08 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #31 from Alex Buckley --- (In reply to M. Tompsett in comment 27) Thanks for doing that. I gone through and pulled the master, rebased, and attached the patches. I have just applied the bug in a new branch off the master and it applied successfully for me. So it will hopefully work for you now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 05:35:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 04:35:31 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 --- Comment #2 from David Cook --- I've written a patch, but not sure how to write the test plan for this one. C4::ImportBatch::GetBestRecordMatch achieves its sort via SQL rather than Perl, so it's not like a common function could be used between them. I suppose I could refactor the sorting as a little function, but that doesn't really help with testing C4::Matcher::get_matches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 05:35:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 04:35:38 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 06:15:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 05:15:44 +0000 Subject: [Koha-bugs] [Bug 17880] New: C4::Installer:: PerlModules lexicographical comparison is incorrect Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Bug ID: 17880 Summary: C4::Installer::PerlModules lexicographical comparison is incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org C4::Installer::PerlModules compares a modules VERSION against the min_version specified in C4::Installer::PerlDependencies using the lexicographical comparison "lt". This means that 0.9.12 will be considered to be less than 0.9.3: PDF::Table 0.9.12 0.9.3 Yes The above line shows up in koha_perl_deps.pl when I look to see what modules I need to upgrade. It doesn't prevent me from installing/running Koha, but it's wrong. In theory, we could use version.pm for our comparisons (http://search.cpan.org/~jpeacock/version-0.9917/lib/version.pod#How_to_compare_version_objects). I think it can sometimes have surprising results, although in this case it should be OK since we're comparing version numbers against version numbers of the same module. So in theory it should have a consistent scheme... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 06:17:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 05:17:04 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #32 from M. Tompsett --- Oh wow! Okay, I didn't understand the coolness of this until I started testing. It's going to take too long to test, and I need sleep, but so far so good. Oh no! Spoke too soon. Seriously?! What is it with programmers taking away my symbols as part of passwords? Sorry, but I experienced this on another website (www.scene.ca) that I use as well, so the issue is a hot spot for me right now. https://www.owasp.org/index.php/Password_special_characters http://www.ibm.com/support/knowledgecenter/SSEQTP_8.5.5/com.ibm.websphere.base.doc/ae/csec_chars.html I can't enter a password for Koha that I have used before. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 06:21:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 05:21:41 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #33 from M. Tompsett --- Comment on attachment 58794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58794 Finished initial web installer and onboarding tool Review of attachment 58794: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58794) ----------------------------------------------------------------- ::: installer/onboarding.pl @@ +22,2 @@ > use strict; > use warnings; https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL2:_Modern::Perl use Modern::Perl; instead of strict and warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 06:30:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 05:30:21 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #34 from M. Tompsett --- Comment on attachment 58793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58793 Bug 17855 - onboarding.pl script has been created. Review of attachment 58793: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58793) ----------------------------------------------------------------- ::: installer/install.pl @@ +14,5 @@ > +# # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# # GNU General Public License for more details. > +# # > +# # You should have received a copy of the GNU General Public License > +# # along with Koha; if not, see . Not quite right. Just #, not "# #". ::: installer/onboarding.pl @@ +18,5 @@ > +# # You should have received a copy of the GNU General Public License > +# # along with Koha; if not, see . > + > +use strict; > +use warnings; Not needed, since use Modern::Perl is below. @@ +59,5 @@ > +use Koha::IssuingRules; > + > +#Setting variables > +my $input = new CGI; > +my $query = new CGI; Is this right? Why two? @@ +332,5 @@ > + if($op eq 'add_validate'){ > + my %newdata; > + > +#Store the template form values in the newdata hash > + $newdata{borrowernumber} = $input->param('borrowernumber'); Try to avoid excess whitespace. Check the wiki for git bz configuration for some git commands related to whitespace. @@ +386,5 @@ > + > + #Error handling checking if the patron was created successfully > + if(!$borrowernumber){ > + push @messages, {type=> 'error', code => 'error_on_insert'}; > + }else{ spacing makes code more readable. Consider running a perl tidy as a separate patch. ::: summary.pl @@ +24,5 @@ > + > +use CGI qw ( -utf8 ); > +use List::MoreUtils qw/ any /; > +use LWP::Simple; > +use XML::Simple; Please check the necessity of all these "use"s. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:10:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:10:43 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #1 from David Cook --- I've actually written a patch for this, but I found another bug in C4::Installer::PerlModules::version_info() while writing a unit test, so I'll open another bug for that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:11:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:11:49 +0000 Subject: [Koha-bugs] [Bug 17881] New: I have problem in koha i think the database for Zebra not updating. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17881 Bug ID: 17881 Summary: I have problem in koha i think the database for Zebra not updating. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: mshami at mcst.edu.sa QA Contact: testopia at bugs.koha-community.org I'm create some of new category (books) in koha and saved it , but when i search it this book the massage appear no result found ,but when i need to barrow the same books, i can barrow from koka admin. how can update database for zebra . Note, i don't have any problem in old book , i can do search and the result appear . The Second Problem, all the user he can access from the own gmail for the college without register in koha all the gmail account coped to koha automatically , but now, all the new user in gmail he can't login and barrow book until i do for him a new user manually from admin . note, i don't have instance the database name koha not like koha_koha. i not find file /etc/cron.d/koha-common . that men this problem. the koha Version 3.12. thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:15:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:15:17 +0000 Subject: [Koha-bugs] [Bug 17882] New: C4::Installer::PerlModules::version_info() drops data during error handling Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 Bug ID: 17882 Summary: C4::Installer::PerlModules::version_info() drops data during error handling Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org If you try something like the following when DateTime isn't installed, instead of seeing the Perl dependency information, you'll see nulls and hard-coded defaults. my $version_check = $modules->version_info('module'=>"DateTime"); This is only a problem when using version_info with the module parameter. The "all" parameter (as used by koha_perl_deps.pl) works fine. It looks like a simple copy/paste error, so I'll post a patch for this too soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:15:35 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17882 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:15:35 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 [Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:15:45 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:15:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:15:48 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:18:22 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #5 from David Cook --- Adam from Indexdata has confirmed via email that we only need the line and that it will work with all YAZ versions. So there should be no barriers to removing . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:18:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:18:31 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 07:22:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 06:22:13 +0000 Subject: [Koha-bugs] [Bug 17881] I have problem in koha i think the database for Zebra not updating. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17881 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- For problems like yours, I would suggest contacting one of the Koha listservs: https://koha-community.org/support/koha-mailing-lists/, or going to the #koha channel on the OFTC IRC network. Bugzilla is usually used by developers for tracking bugs that we find based on problems like yours that we hear on IRC, the listserv, in-person, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 08:16:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 07:16:55 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think the nicest thing to do might be a separate status or a flag? We always get asked how to identify books on hold that have been returned, so they can be pulled off the cart. Or even that an email is sent to the circulation desk so they can go and pick it up from the return station. Currently you can't really make that happen and it would be nice if we could. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 08:51:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 07:51:44 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 08:51:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 07:51:46 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58788|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 58795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58795&action=edit Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:03:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:03:34 +0000 Subject: [Koha-bugs] [Bug 1707] Search for patron '%' returns all results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:04:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:04:06 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:04:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:04:16 +0000 Subject: [Koha-bugs] [Bug 17664] Silence non-zebra warnings in t/db_dependent/Search.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17664 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:04:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:04:24 +0000 Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3 usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:04:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:04:50 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:05:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:05:10 +0000 Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:14:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:14:46 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #4 from Claire Gravely --- Hi Nick After applying the patch, the updated_on field in deletedborrowers hasn't been populated after deleting the patron. They appear in the table, but the field is blank. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:15:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:15:50 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- To be consistent should not we have the same behaviour for "Automatic renewal"? I personally don't really like that kind of custom javascript, especially when that can be achieve by filling the intranet js pref. But I am not behind a circulation desk :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:20:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:20:33 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- I think this should be done in ModMember and AddMember, covered by tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:22:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:22:13 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:22:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:22:18 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58648|0 |1 is obsolete| | Attachment #58758|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58796&action=edit Bug 17778 - Make "Earliest Registered Date" in OAI dynamic This was hardcoded to 0001-01-01. To test: - Make sure you have a couple of records, with different timestamps - Enable OAI-PMH - Check http://localhost:2201/cgi-bin/koha/oai.pl?verb=Identify and verify that "Earliest Registered Date" is 0001-01-01 - Apply the patch - Re-check the "Earliest Registered Date" and verify that it is now the lowest timestamp in your biblio table - Manipulate the timestamps and verify that "Earliest Registered Date" changes accordingly - Sign off! Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:22:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:22:25 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 --- Comment #5 from Jonathan Druart --- Created attachment 58797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58797&action=edit Attachment to Bug 17778 - Make "Earliest Registered Date" in OAI-PMH dynamic Bug 17778: Simplify fetch date Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:24:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:24:31 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:28:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:28:17 +0000 Subject: [Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Hi Sophie, Please provide tests for this change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:30:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:30:28 +0000 Subject: [Koha-bugs] [Bug 17379] Add a man page for koha-passwd In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17379 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:38:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:38:05 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- I think we need to provide a version using column_exists, from bug 17234. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:42:29 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #14 from Josef Moravec --- Kyle, I could be wrong, but, shouldn't it be better (just for being on the safe side) to make the array of account lines objects and then call the Koha::Account->pay just once on top of it? Because this way you call pay method with whole amount on each of the accountline... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:42:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:42:55 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #5 from Jonathan Druart --- Nick, I did not test, but it does not work that way. If you want DBIx::Class to use the default value you must not pass the key. So: delete $patron_infos->{updated_on}; should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:43:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:43:03 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:50:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:50:34 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Josef Moravec --- Started testing... For first koha-qa complains: FAIL Koha/REST/V1/Suggestions.pm FAIL valid Smartmatch is experimental -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:51:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:51:05 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Fridolin, how this is useful? I understand the consistency point of view, but I do not think it is really valuable. Did you check the other calls to this subroutine to make sure that will not affect another script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:53:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:53:08 +0000 Subject: [Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #10 from Josef Moravec --- prove t/db_dependent/api/v1/swagger/definitions.t says: # Failed test 'Columns is nullable in DB, not in swagger file for suggestion: publicationyear, suggesteddate' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:55:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:55:29 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Frido, I think it would be great to have a update DB entry to check if this value exists. If it does, I do not think we should remove it, but at least warn the administrator that there is something wrong and something should be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:59:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:59:03 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 09:59:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 08:59:08 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58795|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 58798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58798&action=edit Bug 17879: Use image filename if no image name is entered This patch changes the code to use the filename of the uploaded image if no specific image name is entered. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) Upload an image and leave the image name field empty 3) Notice this works and 'Name' is left empty. 4) Apply patch and refresh page 5) Upload an image and leave the image name field empty 6) Notice the image name is given the filename so that 'Name' is no longer empty. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:00:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:00:52 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:13:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:13:01 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #12 from Jonathan Druart --- Would not it make more sense to make library_limits returns Koha::Libraries instead of \@branchcodes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:31:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:31:21 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55768|0 |1 is obsolete| | --- Comment #46 from Julian Maurice --- Created attachment 58799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58799&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:31:25 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55769|0 |1 is obsolete| | --- Comment #47 from Julian Maurice --- Created attachment 58800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58800&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:31:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:31:29 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55770|0 |1 is obsolete| | --- Comment #48 from Julian Maurice --- Created attachment 58801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58801&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:31:34 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55771|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 58802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58802&action=edit Bug 15516: Set reserve-group.pl to be executable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:31:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:31:38 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55772|0 |1 is obsolete| | --- Comment #50 from Julian Maurice --- Created attachment 58803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58803&action=edit Bug 15516: Reword 'reserve group' to 'hold group' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:32:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:32:03 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:40:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:40:01 +0000 Subject: [Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions ( using an Ajax-request) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Jonathan Druart --- Chris, Where does come from the autofill.js file (ie. do we need to add it to the license section of the about page)? Moreover the 2 strings ("Undo" and "Search Google Books") are not translatable. They should be moved out from the js file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:48:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:48:02 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #22 from Alex Arnaud --- For me there is two case: 1) The expiration date set by the patron is higher than the calculated expiration date (that take into account pickup delay and holiday). In this case, i think it is quite fair to overwrite the patron expiration date since he is not supposed to keep the item waiting beyond the library delay. This is what this patch does. 2) The patron expiration date is before the calculated expiration date. As the patron don't need the item after its own date, we could overwrite expirationdate with the one calculated. We need a adjustment to have this behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:53:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:53:26 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:53:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:53:30 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58654|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 58804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58804&action=edit Bug 17794: Menu items in Tools menu and Admin menu not showing bold when active but not on linked page To reproduce: admin-menu 1) Go to a page like admin/categories.pl 2) Click New Category 3) Notice Patron categories in the sidebar menu is no longer bold tools-menu 4) Go to a page like reviews/reviewswaiting.pl 5) Notice bold Comments in sidebar menu 6) Click Approved Comments tab 7) Notice no longer bold in sidebar menu To test: 8) Apply patch and refresh page 9) Follow above steps to reproduce bug, confirm that active links are always bold 10) Test with other links to confirm nothing has broken Special cases 11) Go To admin -> MARC bibliographic frameworks -> Actions for any framework -> MARC structure 12) Confirm sidebar menu link is still bold 13) Go to admin -> Authority types -> Actions for any auth type -> MARC structure 14) Confirm sidebar menu link is still bold 15) Click Actions for any tag -> Subfields 16) Confirm sidebar menu link is still bold 17) Go to admin -> OAI sets config -> Actions for any set -> Define mappings 18) Confirm sidebar menu link is still bold Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:58:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:58:04 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to Owen Leonard from comment #7) > These comments are not a criticism of this patch, but just something I've > been thinking about with regard to this area of the templates: > > 1. This is starting to get convoluted. At what point should we try to > reevaluate how we highlight menu items? Eventually the JavaScript becomes > almost as complicated as doing the logic in the template. Yes, it's hard to say. We use another method to do that in members-menu.inc, but that requires a new line per script + 1 check per entry in the menu. So much more code to maintain. > 2. This way of doing things is going to create a problem for Bug 17858 > because these menu templates include jQuery JavaScript which the browser > will attempt to run before jQuery has loaded. We will need to figure out a > way to make it not break. Indeed, and it will not be the only one: git grep '$(document).ready' ../includes/ | wc -l => 20 Not all of them are relevant, but some are. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 10:58:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 09:58:14 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 11:43:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 10:43:25 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #13 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Would not it make more sense to make library_limits returns Koha::Libraries > instead of \@branchcodes? I'm not sure. It takes its data from borrower_attribute_types_branch Maybe you can check how it is used and see if the overhead is worth. Once I get to the office we can discuss it, but I'm not against this. I'm not specially attached to this api. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 11:53:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 10:53:42 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #54 from Kyle M Hall --- Pushed to master for 17.05, thanks Philippe, Mark, and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:04:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:04:41 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:04:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:04:46 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58594|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 58805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58805&action=edit Bug 15879: Allow multiple plugin directories to be defined in koha-conf.xml It would be very useful to be able to define multiple plugin directories in the Koha conf file. This would allow for ease of plugin development so that each plugin installed can live in its own git repository. For compatibility, the first plugindir instance defined should be the one used for uploading plugins via the web interface. Test Plan: 1) Apply this patch 2) Define a second pluginsdir line in your koha-conf.xml 3) Clone the kitchen sink plugin to this new path like this: git clone https://github.com/bywatersolutions/koha-plugin-kitchen-sink.git /path/to/new/plugins/dir 4) Restart memcached if you are running it 5) The Kitchen Sink plugin should now appear in your list of plugins! Signed-off-by: Tomas Cohen Arazi I rebased it against master and tested it on a kohadevbox Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:04:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:04:50 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 --- Comment #7 from Jonathan Druart --- Created attachment 58806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58806&action=edit Bug 15879: Add Tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:09:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:09:46 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Hum, it seems that the kpz in t/db_dependent is wrong, it contains a ctags file which is not removed on delete. Kyle, do you want me to open a bug report for that problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:19:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:19:02 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 --- Comment #9 from Jonathan Druart --- Something else, if I uninstall the KitchenSink plugin, it is still listed in the plugin list until I restart Plack. Is it a known bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:24:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:24:29 +0000 Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:33:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:33:37 +0000 Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3 usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 12:33:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 11:33:39 +0000 Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3 usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58744|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 58807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58807&action=edit Bug 17874: Bug 16239 followup - polishing things This patch is made on top of bug 16239 to polish things. Makes these changes: - Buttons on add circulation message modal - Dropdowns has top and bottom margin 4px instead of 3px - btn-link class (for example in toolbar on advanced search pages) - Delete circ message is btn-link - Add new circ message is btn-link Test plan: - Confirm that all changes are as described above and that they make sense Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 13:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 12:35:32 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 13:47:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 12:47:44 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #7 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #6) > Frido, I think it would be great to have a update DB entry to check if this > value exists. > If it does, I do not think we should remove it, but at least warn the > administrator that there is something wrong and something should be fixed. If I create a db update, simply replace in COUNTRY authorized value the description for "ER" into "Erythr?e" if it is "Allemagne" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 13:51:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 12:51:16 +0000 Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 --- Comment #15 from Tom?s Cohen Arazi --- (In reply to Chris Kirby from comment #14) > (In reply to Tom?s Cohen Arazi from comment #13) > > Note for testers: this patches need to be tested with 13757 applied on top > > of them. Otherwise some tests will be skipped. > > applied the following patches:17755, 17813 (followed by updatedatabase.pl), > 17792, (followed by updatedatabase.pl), 13757. > > 13757 doesn't apply cleanly over 17792: > https://snag.gy/q4co8z.jpg Chris, I fixed that already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 13:52:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 12:52:49 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58789|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 58808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58808&action=edit Bug 17181: Check for duplicate image names when uploading image to patron card creator This patch adds a check for duplicates before uploading the image. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) If you haven't already, upload an image 3) Try to upload another image with the same image name 4) Notice the first image is replaced with the second image, with no warning. 5) Apply patch and refresh page 6) Try to upload an image with the same image name again 7) Notice you are now warned about a duplicate image name. 8) Check that uploading an image with a unique name still works. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 13:52:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 12:52:47 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:05:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:05:49 +0000 Subject: [Koha-bugs] [Bug 17881] I have problem in koha i think the database for Zebra not updating. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17881 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard --- Other support options are here: http://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:15:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:15:25 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > 1/ Koha::UploadedFile > a. Koha::UploadedFile->delete is weird, I'd suggest to call and return > $self->SUPER::delete in any cases and warn only `unless -e $file`. > As Koha::Object->delete returns 1 on success, I don't think you should > return anything else. Calling SUPER::delete always now. Leave two warns. Return false if deleting the file fails. > b. getCategories > - use C4::Koha; is missing > - The methods in itself should be moved to Koha::UploadedFiles. Agreed > I'd even suggest to remove it, and call GetAuthorisedValues only once in > tools/upload.pl. It does not make sense to call it 3 times in the same > script. These three times made sense, but nevertheless moved them up into one call. I want to keep getCategories, since it hides the implementation from the script and can be changed easier (say moving it from auth values to separate table). > 2/ Koha::UploadedFiles > a. ->delete should not be called after ->new, but directly > (Koha::UploadedFiles->delete). > I am wondering if what you are doing in this method should not be moved to > Koha::Objects->delete because actually it is the expected behaviour I think. Changed new->delete into delete. Removed delete_errors as a consequence for now. I suggest to keep delete here now, but we could open a new report to move it to Koha::Objects. > 3/ in tools/upload.pl, it's certainly better to use ->find($id) and then > check if the public method. Adjusted three calls. All adjustments in the last follow-up. Thanks for reviewing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:15:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:15:49 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 --- Comment #23 from Marcel de Rooy --- Created attachment 58809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58809&action=edit Bug 17501: [Follow-up] QA Requests This patch makes the following changes, as requested by QA: [1] UploadedFile->delete always calls SUPER::delete. The return value normally comes from SUPER::delete; if removing the file failed, we return false. Two warns are kept. Since delete does no longer return the filename, a few changes were needed in tools/upload.pl. [2] Method getCategories is moved to UploadedFiles. Script tools/upload.pl now only contains one call. Added a use C4::Koha. [3] Calls UploadedFiles->delete as class method. As a result I removed method delete_errors for now; may be reconsidered on a new report. [4] Adjusted three ->search calls for id and public to ->find calls. [5] If you pass no id to upload.pl when deleting, you don't get an alert. All by all, we got rid of 15 lines ! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:26:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:26:41 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58177|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 58810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58810&action=edit Bug 17669: Add delete_temporary method with unit tests Test plan: Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:26:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:26:45 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58178|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 58811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58811&action=edit Bug 17669: Incorporate the changes in cleanup_database Two command line options are added: [1] -temp-uploads to indicate that you want to purge these uploads, [2] -temp-uploads-override DAYS to (optionally) tell that you want to override the corresponding pref value. Test plan: [1] Check the modified usage statement. [2] If needed, backup your temporary uploads :) In case you do not have one, add a temporary one with Tools/Upload. Note: Do not choose an upload category. [3] Set pref to 0, and run cleanup_database with only --temp-uploads. No files should be deleted. [4] Check number of "old" temp uploads. Set pref to nonzero value. Verify that the oldest are gone (depending on the value chosen). [5] Set pref to 0 again. If all uploads are gone now, add a new one with Tools/Upload. Run cleanup_database with --temp-uploads --temp-uploads-override -1 All temporary files are gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:26:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:26:48 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58179|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 58812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58812&action=edit Bug 17669: Add new switch to crontab example and debian daily cron file The new switch for deleting temporary uploads in cleanup_database can be added to cron. Note: Since the option --temp-uploads does only purge temporary uploads when triggered by the preference Upload_PurgeTemporaryFiles_Days, it can be safely added here. Test plan: There is actually nothing to test here if you followed the preceding test plans. Just verify that the switch is inserted ocrrectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:27:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:27:45 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #9 from Marcel de Rooy --- Rebased on top of changes to 17501 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:30:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:30:47 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #8 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #7) > (In reply to Jonathan Druart from comment #6) > > Frido, I think it would be great to have a update DB entry to check if this > > value exists. > > If it does, I do not think we should remove it, but at least warn the > > administrator that there is something wrong and something should be fixed. > > If I create a db update, simply replace in COUNTRY authorized value the > description for "ER" into "Erythr?e" if it is "Allemagne" ? Nope, I'd suggest just to display a warning message if (ER, Allemagne) exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:36:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:36:06 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #97 from Marcel de Rooy --- Still applies. If it does on early Friday morning, I will have a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:39:30 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #23 from Marcel de Rooy --- (In reply to Alex Arnaud from comment #22) > For me there is two case: > > 1) The expiration date set by the patron is higher than the calculated > expiration date (that take into account pickup delay and holiday). In this > case, i think it is quite fair to overwrite the patron expiration date since > he is not supposed to keep the item waiting beyond the library delay. This > is what this patch does. > > 2) The patron expiration date is before the calculated expiration date. As > the patron don't need the item after its own date, we could overwrite > expirationdate with the one calculated. We need a adjustment to have this > behavior. As indicated before, I would not overwrite the expiration date. What about comment19 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:58:40 +0000 Subject: [Koha-bugs] [Bug 17883] New: Manage Patron Lists Permission incorrectly displaying hidden columns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 Bug ID: 17883 Summary: Manage Patron Lists Permission incorrectly displaying hidden columns Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Users who do NOT have the permission ?Manage Patron Lists? are able to see and edit columns in a patron search result list which have been set to ?hidden? by default. This should not be the case. To reproduce: 1. Go to > Administration > Column Settings > Patrons 2. In member (id = memberresultst) set ?library? to ?hidden by default? and ?cannot be toggled?. 3. Log in as user with permission ?manage patron lists?. Perform patron search ? ?library? column is hidden and cannot be toggled. 4. Log in as user without permission ?manage patron lists?. Perform same patron search ? ?library? column is visible and can be toggled. - written by my dear colleague Claire, thanks :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 14:59:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 13:59:55 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > Hum, it seems that the kpz in t/db_dependent is wrong, it contains a ctags > file which is not removed on delete. > > Kyle, do you want me to open a bug report for that problem? Yes please! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:01:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:01:40 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > Something else, if I uninstall the KitchenSink plugin, it is still listed in > the plugin list until I restart Plack. Is it a known bug? Hmm, that is interesting. Definitely not a bug known to myself at least. Plack must be doing some kind of in memory caching perhaps? None of the code indicates the list of plugins is cached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:04:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:04:35 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:07:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:07:47 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #15 from Kyle M Hall --- (In reply to Josef Moravec from comment #14) > Kyle, I could be wrong, but, shouldn't it be better (just for being on the > safe side) to make the array of account lines objects and then call the > Koha::Account->pay just once on top of it? Because this way you call pay > method with whole amount on each of the accountline... I see what you mean. Yes, what I did here seems a bit silly, I'll put up a followup asap! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:10:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:10:59 +0000 Subject: [Koha-bugs] [Bug 17883] Manage Patron Lists Permission incorrectly displaying hidden columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:12:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:12:19 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45776|0 |1 is obsolete| | --- Comment #13 from Julian Maurice --- Created attachment 58813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58813&action=edit Bug 7728: fix subs history end date consistency Without this patch, there is an inconsistency in subscriptions: * a new subscription has no history end date set (as expected) * if you renew it, a date is set. This patch removes the setting of the history end date during renewal Test plan: * create a subscription, go to subscription-detail.pl page, tab "Summary". No History end date is set * renew the subscription => a date has been set * apply the patch * create another subscription * renew it => no history end date has been set * sign-off Signed-off-by: beroud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:12:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:12:23 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47303|0 |1 is obsolete| | --- Comment #14 from Julian Maurice --- Created attachment 58814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58814&action=edit BZ 7728 adding unit test test plan: * run without the patch, the test will fail * run with the patch, the test will pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:12:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:12:27 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 --- Comment #15 from Julian Maurice --- Created attachment 58815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58815&action=edit Bug 7728: QA fixes - Remove useless comments - Use Koha::Objects::find instead of Koha::Objects::search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:15:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:15:42 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 --- Comment #16 from Kyle M Hall --- Created attachment 58816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58816&action=edit Bug 15907 [QA Followup] - Simplify code and call pay() only once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:18:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:18:54 +0000 Subject: [Koha-bugs] [Bug 17883] Manage Patron Lists Permission incorrectly displaying hidden columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17883 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de Version|3.22 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:21:18 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:21:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:21:20 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58465|0 |1 is obsolete| | Attachment #58579|0 |1 is obsolete| | --- Comment #5 from Patricio Marrone --- Created attachment 58817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58817&action=edit Bug 17817: Fix cloning subfields using select2 Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix. What was changed is that select2 is reinitialized only after the cloned element has been appended to the DOM (so that select2 can correctly calculate the field's width). Also, I changed the selectors that searched for the line divs (for reordering) and for the subfield's input element (for erasing the field's value) to be more specific, since select2 introduced divs that broke some assumptions about the expected HTML structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:26:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:26:54 +0000 Subject: [Koha-bugs] [Bug 7728] Fixing subscription endddate inconsistency: should be empty when the subscription is running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |julian.maurice at biblibre.com --- Comment #16 from Julian Maurice --- (In reply to Jonathan Druart from comment #12) > 1/ Should not we update the histenddate if it has been set? I don't know what the expected behaviour is here. Any serials expert around ? > 2/ Could we imagine fixing existing DB entries? We could imagine, but is it possible to know if an histenddate has been set by a renewal or by hand ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:31:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:31:18 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #24 from Alex Arnaud --- (In reply to Marcel de Rooy from comment #23) > (In reply to Alex Arnaud from comment #22) > > For me there is two case: > > > > 1) The expiration date set by the patron is higher than the calculated > > expiration date (that take into account pickup delay and holiday). In this > > case, i think it is quite fair to overwrite the patron expiration date since > > he is not supposed to keep the item waiting beyond the library delay. This > > is what this patch does. > > > > 2) The patron expiration date is before the calculated expiration date. As > > the patron don't need the item after its own date, we could overwrite > > expirationdate with the one calculated. We need a adjustment to have this > > behavior. > > As indicated before, I would not overwrite the expiration date. > What about comment19 ? Not sure to understand. (In reply to Marcel de Rooy from comment #19) > (In reply to Andreas Hedstr?m Mace from comment #18) > > Without having actually tested this bug, only reading the discussion, I > > would say that I have to agree with Sonia. > > > > As this new date is set after the material is checked in, it doesn't appear > > (at least to me) that the expire date set by the patron would be valuable > > anymore. And the added value of excluding dates that the library is closed > > from the number of day in ReservesMaxPickUpDelay, seem greater than any > > negative impact. > > Hi Andreas, > Thx for your feedback. > I read it again too now. This patch tries to achieve its goal by modifying > the expirationdate, while it actually should change this select in > CancelExpiredReserves? > > my $query = "SELECT * FROM reserves WHERE TO_DAYS( NOW() ) - TO_DAYS( > waitingdate ) > ? AND found = 'W' AND priority = 0"; > > If the holiday stuff is taken into account here, I am having the impression > that we achieve the same. Mabye Sonia or Alex can respond to that? The code here is just simplified since the expirationdate (with max pickup delay + holiday) has already been set at the check in time. So we just need to fetch reserves whose expirationdate is over. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:32:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:32:08 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #6 from Jonathan Druart --- (In reply to Patricio Marrone from comment #5) Hi Patricio, Can you confirm that your patch fixes the following: - width is wrongly calculated - "Move up" raises a JS error ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:35:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:35:56 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:36:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:36:00 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50422|0 |1 is obsolete| | Attachment #50427|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 58818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58818&action=edit Bug 12461 [QA Followup] - Changes based on suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:36:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:36:34 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #42 from Kyle M Hall --- Created attachment 58820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58820&action=edit Bug 12461 [QA Followup] - Changes based on suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:36:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:36:25 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58818|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall --- Created attachment 58819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58819&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:37:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:37:05 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #43 from Kyle M Hall --- (In reply to Chris Cormack from comment #39) > Kyle, we would like to get the academy students testing this again, but the > patches do not apply. If you have a chance to rebase before Monday please > do, otherwise please remove the Academy tag Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:39:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:39:56 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:40:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:40:47 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:41:15 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:47:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:47:10 +0000 Subject: [Koha-bugs] [Bug 17873] Make all buttons Bootstrap styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17873 --- Comment #3 from Owen Leonard --- For reference, this wiki page talks about existing styles: https://wiki.koha-community.org/wiki/Interface_patterns#Buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:50:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:50:17 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marrone.patricio at gmail.com --- Comment #7 from Patricio Marrone --- (In reply to Jonathan Druart from comment #6) > (In reply to Patricio Marrone from comment #5) > > Hi Patricio, > Can you confirm that your patch fixes the following: > - width is wrongly calculated > - "Move up" raises a JS error > ? Hi Jonathan! Short answer: yes. I checked that - The width is the same as the one from the cloned line. This was fixed by first appending the cloned element to the dom and then reactivating select2, so that it can calculate the width. - Moving up should work. select2 introduces some divs which broke the present assumptions that all divs were lines. I added more specific selectors to choose what's a line and what's not. This could use some regression testing to check that other kind of fields still work correctly (that is, textfields, textareas...). I did test that they worked to the limits of my not very extensive Koha knowledge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:51:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:51:11 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 --- Comment #43 from Nick Clemens --- Awesome, checking out and in and placing/cancelling a hold all work well now. When I click 'Logout from OverDrive account' the response seems to always be "Internal server error" can you check on that? POD still fails QA Additionally - two things would be nice: 1 - When you click to Sign In to OverDrive - this link should open in a new tab/window 2 - It would be nice to have a link to your overdrive account from the account page so that you can view the overdrive site if you wish to. (In reply to Srdjan Jankovic from comment #42) > Sorry Nick, was a bug. Fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:57:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:57:47 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:57:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:57:50 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52150|0 |1 is obsolete| | Attachment #52151|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 58821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58821&action=edit Bug 15905 - Update unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 15:57:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 14:57:57 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #11 from Kyle M Hall --- Created attachment 58822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58822&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:03:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:03:30 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- There is a regression on moving subfields up to the top. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:11:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:11:28 +0000 Subject: [Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240 --- Comment #13 from Fridolin SOMERS --- I should split this into several bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:35:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:35:52 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #25 from Viccy Kemp --- I do not understand what Alex and Marcel are working on here. All I know is it appears that reserves do not take into account the dates when the library is closed. Today, the holds are showing they expire on January 16, but the library is closed that day and this is defined in the calendar. WHY IS THIS NOT TAKEN INTO ACCOUNT ON THE EXPIRY DATE? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:49:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:49:14 +0000 Subject: [Koha-bugs] [Bug 17884] New: troubles with syspref AllowHoldPolicyOverride on return Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Bug ID: 17884 Summary: troubles with syspref AllowHoldPolicyOverride on return Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: christophe.croullebois at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com 1? with syspref AllowHoldPolicyOverride ON 2? in "Holds policy by item type" (in smart-rules.pl) with "no holds allowed" selected for an itype. 3? create an hold on an item of this itype 4? return this item 5? you have no message about the hold and the hold is not in status waiting Due to the lack of the check about the syspref during the check in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:49:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:49:39 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58817|0 |1 is obsolete| | --- Comment #9 from Patricio Marrone --- Created attachment 58823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58823&action=edit Bug 17817: Fix cloning subfields using select2 Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix. What was changed is that select2 is reinitialized only after the cloned element has been appended to the DOM (so that select2 can correctly calculate the field's width). Also, I changed the selectors that searched for the line divs (for reordering) and for the subfield's input element (for erasing the field's value) to be more specific, since select2 introduced divs that broke some assumptions about the expected HTML structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:49:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:49:51 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #10 from Patricio Marrone --- Created attachment 58824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58824&action=edit Bug 17817: (Follow up) Fix reordering subfields issues Authority controlled subfields have invisible divs which produced a strange behavior when reordering (multiple clicks were needed to push a subfield up over an authority controlled subfield) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:50:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:50:35 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:50:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:50:50 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:52:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:52:35 +0000 Subject: [Koha-bugs] [Bug 17885] New: Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Bug ID: 17885 Summary: Koha::SearchEngine::Elasticsearch->reset_elasticsearch _mappings throws DBD::mysql Duplicate entry exceptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:53:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:53:19 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 58825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58825&action=edit Bug 17885 - Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions When executing Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings() against populated search engine mappings tables, one gets this exception: DBD::mysql::st execute failed: Duplicate entry '388-73' for key 'PRIMARY' [for Statement \"INSERT INTO `search_marc_to_field` ( `facet`, `search_field_id`, `search_marc_map_id`, `sort`, `suggestible`) VALUES ( ?, ?, ?, ?, ? )\" with ParamValues: 0='', 1='73', 2='388', 3=undef, 4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '388-73' for key 'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line 38" This patch fixes this, by upserting those entries instead of adding them. Also adds a Koha::SearchMappingManager to manage the complexities of CRUD:ing these search mappings Also adds nice tests to make sure the Manager and the reset_elasticsearch_mappings() keep working as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:53:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:53:30 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 --- Comment #1 from Fridolin SOMERS --- Created attachment 58826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58826&action=edit Bug 17884 - troubles with syspref AllowHoldPolicyOverride on return Test plan : 1? with syspref AllowHoldPolicyOverride O. 2? in "Holds policy by item type" (in smart-rules.pl) with "no holds allowed" selected for an itype. 3? create an hold on an item of this ityp. 4? return this ite. 5? you have no message about the hold and the hold is not in status waitin, due to the lack of the check about the syspref during the check in. 6? with this patch you get the message about the existing hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:53:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:53:54 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 [Bug 17255] Upgrade Elastic Search code to work with version 5.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:53:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:53:54 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:54:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:54:12 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:55:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:55:40 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 16:55:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 15:55:55 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:02:30 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #26 from Alex Arnaud --- (In reply to Viccy Kemp from comment #25) > I do not understand what Alex and Marcel are working on here. All I know is > it appears that reserves do not take into account the dates when the library > is closed. Today, the holds are showing they expire on January 16, but the > library is closed that day and this is defined in the calendar. > WHY IS THIS NOT TAKEN INTO ACCOUNT ON THE EXPIRY DATE? Hello Viccy, The purpose of this patch is that the expiration date of reserves being calculated one time when the item is checked in and that this date take into account the pickup delay set by the library *AND* the potential closed days during the period until the delay. Let's admit: - a pickup delay set to 10 (days), - an item checked in at 01/01/2017, - so hold expires at 11/01/2017, - but library is closed from 04/01/2017 to 06/01/2017 (3 days), - if ExcludeHolidaysFromMaxPickUpDelay system preference is enabled, the expiration date will be extended with these 3 days. So until 14/01/2017. But, the case of holds expiring on a closed day is already handled in koha by disabling ExpireReservesOnHolidays if i'm not wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:07:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:07:05 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58823|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 58827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58827&action=edit Bug 17817: Fix cloning subfields using select2 Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix. What was changed is that select2 is reinitialized only after the cloned element has been appended to the DOM (so that select2 can correctly calculate the field's width). Also, I changed the selectors that searched for the line divs (for reordering) and for the subfield's input element (for erasing the field's value) to be more specific, since select2 introduced divs that broke some assumptions about the expected HTML structure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:07:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:07:17 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58824|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 58828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58828&action=edit Bug 17817: (Follow up) Fix reordering subfields issues Authority controlled subfields have invisible divs which produced a strange behavior when reordering (multiple clicks were needed to push a subfield up over an authority controlled subfield) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:07:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:07:21 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:07:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:07:24 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57194|0 |1 is obsolete| | --- Comment #17 from Josef Moravec --- Created attachment 58829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58829&action=edit [SIGNED-OFF] Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Test Plan: 1) Apply this patch 2) Make a payment via PayPal in sandbox mode 3) Note the payment succeeds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:07:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:07:32 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58816|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 58830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58830&action=edit [SIGNED-OFF] Bug 15907 [QA Followup] - Simplify code and call pay() only once Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:07:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:07:55 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Tom?s Cohen Arazi --- Works as expected. Nice catch with reordering! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:10:30 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58821|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 58831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58831&action=edit Bug 15905 - Update unit tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:10:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:10:35 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58822|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 58832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58832&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:11:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:11:08 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:11:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:11:42 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #14 from M. Tompsett --- Bug 15907 hasn't been pushed yet, so had to apply first before testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:24:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:24:29 +0000 Subject: [Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57428|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 58833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58833&action=edit [SIGNED-OFF] Bug 4126 - Exit bulkmarcimport if -a and -b given Currently it is possible to spceify both --biblios and --authorities as command line switches to bulkmarcimport.pl. This does not make sense so we should exit early and explain that these switches are mutually exclusive. To test: - Run one of these and check that there is no complaint about missing options: perl misc/migration_tools/bulkmarcimport.pl -a -b sudo koha-shell -c "perl misc/migration_tools/bulkmarcimport.pl -a -b" kohadev - Observe that this displays the perldoc, but does not complain about mutually exclusive switches. - Apply the patch - Rerun the command(s) from earlier. - Verify that the script is now halted and a small explanation given. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:24:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:24:27 +0000 Subject: [Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:32:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:32:35 +0000 Subject: [Koha-bugs] [Bug 7046] subscription renewal period should be a pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:37:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:37:32 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5620 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 17:37:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 16:37:32 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15894 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:00:55 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #136 from Paul Poulain --- OK, guys, I've a functional question: * I'm a chooser = how do I know that today (or tomorrow, or next weeks) I'll have to do some choices ? * I'm a deliverer = same question : how do I know I've to deliver ? * I want to take profit of this service, can I register from the OPAC ? Thank you for any answer/feedback ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:02:14 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #137 from Paul Poulain --- PS : sorry Claire, I know you're not a guy ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:02:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:02:25 +0000 Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:03:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:03:54 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:16:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:16:29 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:16:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:16:46 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #28 from Kyle M Hall --- Created attachment 58835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58835&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:16:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:16:35 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58762|0 |1 is obsolete| | Attachment #58763|0 |1 is obsolete| | Attachment #58764|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 58834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58834&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:16:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:16:49 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #29 from Kyle M Hall --- Created attachment 58836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58836&action=edit Bug 14570 - Followup Fix small errors in update child script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:22:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:22:05 +0000 Subject: [Koha-bugs] [Bug 12353] Reserves last pickup date needs to respect holidays, and everybody need to know the last pickup date for reserves, even notices. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12353 David Kuhn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |techservspec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:30:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:30:32 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17855 --- Comment #22 from M. Tompsett --- (In reply to Owen Leonard from comment #17) > I would like to see a new last step at the end of the installation process > where the usage statistics preferences could be saved directly. That is, > show the whole form from admin/usage_statistics.pl. In bug 17855, the whole onboarding (must be regional or expertise lingo) process could deal with that. (In reply to Jonathan Druart from comment #21) > That was the first idea, but finally I don't know if it is a good one. > For instance if we want to add geoloc info (bug 17802) or other info at > branch level, the form will not be complete at the end of the installer > (branches do not exist yet). But they could, if they were onboard'd. See bug 17855 for some enhancement dreaming. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:30:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:30:32 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14608 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:34:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:34:19 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #31 from Kyle M Hall --- Created attachment 58838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58838&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:34:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:34:11 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58834|0 |1 is obsolete| | Attachment #58835|0 |1 is obsolete| | Attachment #58836|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 58837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58837&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:34:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:34:23 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #32 from Kyle M Hall --- Created attachment 58839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58839&action=edit Bug 14570 - Followup Fix small errors in update child script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:50:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:50:34 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #138 from Jonathan Druart --- (In reply to Paul Poulain from comment #136) > OK, guys, I've a functional question: > * I'm a chooser = how do I know that today (or tomorrow, or next weeks) > I'll have to do some choices ? > * I'm a deliverer = same question : how do I know I've to deliver ? The information is only displayed on the patron detail pages at the intranet (show+edit views) and on the housebound page (tab HouseBound in the member module). Nothing at the OPAC. > * I want to take profit of this service, can I register from the OPAC ? Nope :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:53:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:53:16 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #23 from Jonathan Druart --- (In reply to M. Tompsett from comment #22) > But they could, if they were onboard'd. See bug 17855 for some enhancement > dreaming. :) Bug 17855 is huge and does not seem to be ready to be pushed. I'd prefer not to wait for it to get this one in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:53:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:53:39 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #139 from Paul Poulain --- thx for your quick answer joubu. Then, in my opinion, it lowers a lot the interest of the feature. Anyone around planning/thinking of adding this kind of feature (a kind of "housebound dashboard") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 18:59:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 17:59:39 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- Still 2 regressions: 1/ On the add item form, it does not work 2/ Try to clone a whole field containing select2: TypeError: divs[i].getAttribute(...) is null You know, I really think that we should go first with my patch, then try to fix it on another bug report. This is critical as it impacts stable releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:01:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:01:20 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #35 from Chris Cormack --- (In reply to M. Tompsett from comment #32) > Oh wow! Okay, I didn't understand the coolness of this until I started > testing. It's going to take too long to test, and I need sleep, but so far > so good. > > Oh no! Spoke too soon. Seriously?! What is it with programmers taking away > my symbols as part of passwords? Sorry, but I experienced this on another > website (www.scene.ca) that I use as well, so the issue is a hot spot for me > right now. > > https://www.owasp.org/index.php/Password_special_characters > http://www.ibm.com/support/knowledgecenter/SSEQTP_8.5.5/com.ibm.websphere. > base.doc/ae/csec_chars.html > This must be just a JavaScript regex Alex, I'd drop that part of the check. > I can't enter a password for Koha that I have used before. :( Mark what? Koha can't possibly know what you old password was. Do you mean you can't enter a password that is already in use? That's way outside the scope of this then. Please remember too to keep chill when you are dealing with a first time commiter. Or we will never have 2nd time commiters :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:05:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:05:22 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #140 from Jonathan Druart --- Yep, IIRC the goal with this first patch was to get a first shoot in. As you can see with the quantity of patches and the low number of this bug report, it was a long standing one. AFAIK there is nothing planned yet to improve this feature. But Alex must know better than me: ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:17:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:17:21 +0000 Subject: [Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Should not we also add the same exit if none are given instead of assuming it's biblio? I can provide a patch if you agree with that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:17:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:17:33 +0000 Subject: [Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |magnus at libriotech.no -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:25:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:25:02 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:25:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:25:10 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58829|0 |1 is obsolete| | Attachment #58830|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 58840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58840&action=edit Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl Test Plan: 1) Apply this patch 2) Make a payment via PayPal in sandbox mode 3) Note the payment succeeds Signed-off-by: Josef Moravec Bug 15907 [QA Followup] - Simplify code and call pay() only once Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:25:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:25:56 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58831|0 |1 is obsolete| | Attachment #58832|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 58841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58841&action=edit Bug 15905 - Update unit tests Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:25:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:25:51 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:26:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:26:02 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #16 from Jonathan Druart --- Created attachment 58842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58842&action=edit Bug 15905 - Remove use of makepayment Test Plan: 1) Apply these patches 2) prove t/db_dependent/Accounts.t 3) 'git grep makepayment' should return no results Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:26:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:26:13 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #20 from Jonathan Druart --- I have squashed the 2 patches. I did not test the paypal payment but the code looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:26:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:26:17 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #17 from Jonathan Druart --- Created attachment 58843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58843&action=edit Bug 15905: Remove one last occurrence of makepayment in comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 19:30:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 18:30:07 +0000 Subject: [Koha-bugs] [Bug 17886] New: Don' t show option to add to existing list if there are no lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Bug ID: 17886 Summary: Don't show option to add to existing list if there are no lists Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/virtualshelves/addbybiblionumber.pl?bibl ionumber=X OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you add a title to a list by choosing 'Add To' -> 'List' from the toolbar on the detail page, a pop-up window is triggered. This window has a section for "Select an existing list" and "Add to a new list." The first should not display if there are no existing lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:22:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:22:48 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #9 from M. Tompsett --- (In reply to Jonathan Druart from comment #8) > Nope, I'd suggest just to display a warning message if (ER, Allemagne) > exists. So, don't correct it. Just give pretty red upgrade messages? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:44:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:44:51 +0000 Subject: [Koha-bugs] [Bug 9157] Enhance inventory tool to skip checked out barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9157 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC| |josef.moravec at gmail.com --- Comment #7 from Josef Moravec --- (In reply to Marc V?ron from comment #6) > Still valid? I don't think so, we have "Skip items on loan" option in inventory tool, it should do the trick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:45:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:45:57 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #10 from Jonathan Druart --- yep -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:49:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:49:10 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #7 from Josef Moravec --- It's still an issue, also after bug 14057. I did just few thousands inventory, and I faced time out (version 16.05.04). I like the background job idea... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:50:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:50:12 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58827|0 |1 is obsolete| | --- Comment #15 from Patricio Marrone --- Created attachment 58844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58844&action=edit Bug 17817: Fix cloning subfields using select2 Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix. What was changed is that select2 is reinitialized only after the cloned element has been appended to the DOM (so that select2 can correctly calculate the field's width). Also, I changed the selectors that searched for the line divs (for reordering) and for the subfield's input element (for erasing the field's value) to be more specific, since select2 introduced divs that broke some assumptions about the expected HTML structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:50:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:50:32 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58828|0 |1 is obsolete| | --- Comment #16 from Patricio Marrone --- Created attachment 58845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58845&action=edit Bug 17817: (Follow up) Fix reordering subfields issues Authority controlled subfields have invisible divs which produced a strange behavior when reordering (multiple clicks were needed to push a subfield up over an authority controlled subfield) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:50:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:50:59 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Patricio Marrone changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 20:57:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 19:57:50 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #17 from Patricio Marrone --- I added fixes to the regressions discovered by Jonathan. Are there more places where these select2 fields need to be cloned? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 21:38:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 20:38:20 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #36 from Alex Buckley --- Created attachment 58846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58846&action=edit Bug 17855 - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script These changes are based on feedback from testing. Test plan: 1. Go through the web installer and onboarding tool as outlined in this guide: https://koha-community.org/manual/installation/html/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 21:43:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 20:43:37 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #37 from Alex Buckley --- I have gone through and made the changes recommended in comments 33, 34, and 35, and attached the commit (see its name below) to this bug: Bug 17855 - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script I have tested the bug in a clean branch and it applies successfully for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:10:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:10:05 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:10:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:10:12 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58844|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 58847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58847&action=edit [SIGNED-OFF] Bug 17817: Fix cloning subfields using select2 Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix. What was changed is that select2 is reinitialized only after the cloned element has been appended to the DOM (so that select2 can correctly calculate the field's width). Also, I changed the selectors that searched for the line divs (for reordering) and for the subfield's input element (for erasing the field's value) to be more specific, since select2 introduced divs that broke some assumptions about the expected HTML structure Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:10:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:10:51 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58847|0 |1 is obsolete| | --- Comment #19 from Josef Moravec --- Created attachment 58848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58848&action=edit [SIGNED-OFF] Bug 17817: Fix cloning subfields using select2 Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix. What was changed is that select2 is reinitialized only after the cloned element has been appended to the DOM (so that select2 can correctly calculate the field's width). Also, I changed the selectors that searched for the line divs (for reordering) and for the subfield's input element (for erasing the field's value) to be more specific, since select2 introduced divs that broke some assumptions about the expected HTML structure Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:11:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:11:12 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58845|0 |1 is obsolete| | --- Comment #20 from Josef Moravec --- Created attachment 58849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58849&action=edit [SIGNED-OFF] Bug 17817: (Follow up) Fix reordering subfields issues Authority controlled subfields have invisible divs which produced a strange behavior when reordering (multiple clicks were needed to push a subfield up over an authority controlled subfield) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:31:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:31:19 +0000 Subject: [Koha-bugs] [Bug 12733] Interactive inventory tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12733 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:31:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:31:59 +0000 Subject: [Koha-bugs] [Bug 10707] inventory not removing lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:32:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:32:14 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:35:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:35:51 +0000 Subject: [Koha-bugs] [Bug 14677] Inventory: Compare Barcodes List to Result function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14677 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:37:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:37:07 +0000 Subject: [Koha-bugs] [Bug 4037] Inventory Tool Missing Item Type Filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4037 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:37:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:37:54 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 22:40:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 21:40:08 +0000 Subject: [Koha-bugs] [Bug 14398] Duplicate inventory results when an item is in the wrong place ( ie using branch/location filter) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14398 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 23:12:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 22:12:40 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #38 from M. Tompsett --- Comment on attachment 58846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58846 Bug 17855 - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script Review of attachment 58846: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58846) ----------------------------------------------------------------- Nice improvements. Sorry if I was a little harsh before. You are doing great for your first major attempt. I say major, because you are affecting more than one file and adding a really nice pre-configuration setup. The fact that you are trying and listening to feedback is plus in my books! Keep up the effort. :) I'll test it in a bit. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt @@ -43,4 @@ > > > [%ELSE %] > - I'm just eyeballing this right now, but was this already dealt with? Why remove it? ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt @@ -191,4 @@ > >
  1. > > - Thank you for removing this pattern stuff. The alternative was to include those special characters, but then you would have to escape some of them. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt @@ +42,5 @@ >

    To create another item type later and for more setttings
    > + go to:

    > + More->Administration->Item types
    > + or
    > + Administration->Item types Everything with - or not. And if there are things without, then without is the way you should do it to maintain consistency. Plus, I do not think the or part is necessary. ::: koha-tmpl/intranet-tmpl/prog/en/modules/summary.tt @@ +16,5 @@ >

    >

    Library

    >

    To add another library and for more settings, go to
    > + More > Administration > Libraries and groups

    OR
    > + Administration->Libraries and groups There is no - in the original line. Also, no need for this change. @@ +21,5 @@ > >

    Patron Category

    >

    To add another patron category and for more settings, go to
    > + More > Administration > Patron Categories

    OR
    > + Administration->Patron categories There is no - in the original line. Also, no need for this change. @@ +30,5 @@ > >

    Item Type

    >

    To create another item type and for more settings, go to
    > + More > Administration > Item types

    OR
    > + Administration->Item types There is no - in the original line. Also, no need for this change. ::: summary.pl @@ -21,5 @@ > # along with Koha; if not, see . > > use Modern::Perl; > - > -use CGI qw ( -utf8 ); I would have kept this, since you have my $query = new CGI; later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 23:20:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 22:20:54 +0000 Subject: [Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- (In reply to Jonathan Druart from comment #4) > Should not we also add the same exit if none are given instead of assuming > it's biblio? > > I can provide a patch if you agree with that. While I agree that for clarity sake forcing people to specify is good, that seems to be a problem beyond the scope of this bug. Also, one has to consider: do you really want to have to type an extra 3 characters to run the command when, for the most part, it will likely be biblios? I think the default behaviour is adequate and see no reason to change it, unless there is going to be a sweeping "we must be explicit about everything" in all the parameters for all scripts. I vote for keeping it moving on to Pass QA. :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 23:34:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 22:34:35 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Christopher Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgdavis at uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 23:37:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 22:37:30 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #343 from rjb --- Created attachment 58850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58850&action=edit update history file -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 23:54:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 22:54:19 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #1 from David Cook --- Created attachment 58851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58851&action=edit Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 23:54:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 22:54:17 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 11 23:58:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 22:58:49 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #2 from David Cook --- Created attachment 58852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58852&action=edit Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:09:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:09:24 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58852|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 58853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58853&action=edit Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:10:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:10:25 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58851|0 |1 is obsolete| | --- Comment #4 from David Cook --- Created attachment 58854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58854&action=edit Bug 17882 - Add missing module test to Installer_PerlModules.t Adds a test that checks the values declared for a missing Perl dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:10:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:10:32 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58853|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 58855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58855&action=edit Bug 17882 - Fix C4::Installer::PerlModules::version_info() If you're doing version_info() for a single uninstalled module, you'll currently get null values and default values instead of the values defined in C4::Installer::PerlDependencies. This patch fixes the variable name for the module, and that allows the correct data to be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:18:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:18:59 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #6 from David Cook --- Test Plan: 1) Apply patch "Bug 17882 - Add missing module test to Installer_PerlModules.t". 2) Run "perl t/Installer_PerlModules.t" 3) Note the following at the end of the test output: not ok 18 - Minimum version found for missing module # Failed test 'Minimum version found for missing module' # at t/Installer_PerlModules.t line 48. # got: undef # expected: '0.9.3' # Looks like you planned 17 tests but ran 18. # Looks like you failed 1 test of 18 run. 4) Apply patch "Bug 17882 - Fix C4::Installer::PerlModules::version_info()". 5) Run "perl t/Installer_PerlModules.t" 6) Note the following at the end of the test output: ok 18 - Minimum version found for missing module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:19:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:19:28 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:19:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:19:54 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #344 from rjb --- Created attachment 58856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58856&action=edit update about.tt with new devs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:23:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:23:37 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 rjb changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |rjb-dev at yandex.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:32:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:32:33 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17880 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 [Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:32:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:32:33 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17882 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:32:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:32:53 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #2 from David Cook --- Removed the dependency on bug 17882 as they can actually be done separately... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 00:33:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 11 Jan 2017 23:33:19 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #3 from David Cook --- (In reply to David Cook from comment #2) > Removed the dependency on bug 17882 as they can actually be done > separately... Although whichever one comes second will need to be rebased... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:07:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:07:29 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 --- Comment #7 from David Cook --- Arg... just noticed the usage doesn't show up for upgrades and installed modules... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:18:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:18:27 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #5 from David Cook --- Created attachment 58858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58858&action=edit Bug 17880 - Use version.pm to parse version numbers in C4::Installer::PerlModules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:18:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:18:21 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #4 from David Cook --- Created attachment 58857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58857&action=edit Bug 17880 - Add test to check version number comparison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:18:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:18:46 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from David Cook --- Test Plan: 1) Apply patch "Bug 17880 - Add test to check version number comparison" 2) Run "perl t/Installer_PerlModules.t" 3) Note the following output: not ok 19 - Version 0.9.13 is greater than 0.9.3, so no upgrade needed # Failed test 'Version 0.9.13 is greater than 0.9.3, so no upgrade needed' # at t/Installer_PerlModules.t line 51. # got: '1' # expected: '0' # Looks like you failed 1 test of 19. 4) Apply patch "Bug 17880 - Use version.pm to parse version numbers in C4::Installer::PerlModules" 5) Run "perl t/Installer_PerlModules.t" 6) Note the following output: ok 19 - Version 0.9.13 is greater than 0.9.3, so no upgrade needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:20:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:20:49 +0000 Subject: [Koha-bugs] [Bug 17887] New: Dependency usage doesn' t show for upgrades or installed modules using version_info Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17887 Bug ID: 17887 Summary: Dependency usage doesn't show for upgrades or installed modules using version_info Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org When using version_info with the module parameter, the usage information won't show for modules that are installed or needing upgrade. The cause is the same as bug 17882. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:20:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:20:59 +0000 Subject: [Koha-bugs] [Bug 17887] Dependency usage doesn' t show for upgrades or installed modules using version_info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17887 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17882 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:20:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:20:59 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17887 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:25:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:25:24 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:25:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:25:28 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 --- Comment #3 from David Cook --- Created attachment 58859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58859&action=edit Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should use same logic C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending then candidate_match_id descending. With C4::Matcher::get_matches, I implement the same sort but use Perl code to do it, since we're sorting search results. It's a simple change, but it's in a big block of code, so I don't have unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:26:19 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:27:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:27:53 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:39:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:39:36 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #39 from Alex Buckley --- Created attachment 58860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58860&action=edit Bug 17855 - Second update following testing feedback Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' Added the use CGI qw ( -utf8 ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 01:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 00:51:23 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #40 from Alex Buckley --- In reply to M. Tompsett from comment 38) I removed that comment because I had already added that if statement to check if the creation of the library was successful, see line 27 of onboardingstep1.tt I have now made all arrows -> throughout the onboarding tool, thank you for noticing that. The reason I added the additional paths in the summary.tt is because I wanted to make the summary.tt consistent with the onboarding tool pages outlining how to create a new library, patron category, patron, item type and circulation rule. I have added back in the 'use CGI qw ( -utf8 );' into summary.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 02:04:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 01:04:47 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #41 from M. Tompsett --- Comment on attachment 58860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58860 Bug 17855 - Second update following testing feedback Review of attachment 58860: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58860) ----------------------------------------------------------------- Very close! I can feel it. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt @@ +37,1 @@ > Administration->Libraries and groups Sorry I was unclear, I mean this line too. The More->Administration->Libraries and groups is part of the top of practically every page. Administration is only on the main page. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt @@ -298,1 @@ > Administration->Patron categories

    This line too. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt @@ +105,5 @@ >

    New Patron

    >
    >

    Success: New patron created!

    > +

    To create another patron, go to Patrons -> New Patron.
    > + More->Set Permissions in a user page to gain superlibrarian permissions. Top line has spaces, bottom line doesn't with respect to ->. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt @@ -46,1 @@ > Administration->Item types This line too. ::: koha-tmpl/intranet-tmpl/prog/en/modules/summary.tt @@ +16,4 @@ >

    >

    Library

    >

    To add another library and for more settings, go to
    > + More -> Administration -> Libraries and groups

    OR
    Okay. Standardized on ->, that's okay with me. But now this has spaces before and after the ->, while the others don't. Choose how to make them consistent. I personally like the lack of space, but it really doesn't matter. With spaces is a quicker fix, so I'll understand. I may be being a tad pedantic in this matter. And, the whole "OR ..." pieces (part of this line at the end, and the next line) don't make sense to me, here and in the sections below. @@ +25,1 @@ > Administration->Patron categories "OR ..." here. @@ +25,5 @@ > Administration->Patron categories > >

    Patron

    > +

    To create another patron, go to Patrons -> New Patron. To set the
    > + permissions of the patron, go to the patron's page and More -> Set Permissions

    YAY! See? Consistent. Nice! @@ +34,1 @@ > Administration->Item types "OR ..." here. @@ +34,5 @@ > Administration->Item types > >

    Circulation Rule

    >

    To create another circulation rule, go to
    > + More -> Administration -> Circulation and Fine Rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 02:35:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 01:35:19 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #42 from Alex Buckley --- Created attachment 58861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58861&action=edit Bug 17855 -Third update follwing testing feedback Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt Fixed typo in summary.tt Made consistent single space before and after -> in all onboarding .tt and summary.tt files. Made single
    tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 03:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 02:05:23 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #20 from David Cook --- I like this idea, but I don't use Debian often enough to be useful in terms of testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 03:14:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 02:14:00 +0000 Subject: [Koha-bugs] [Bug 12930] Web installer does not show login errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 04:02:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 03:02:50 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #6 from David Cook --- Found the original email I wrote about this last year: http://www.mail-archive.com/koha-devel at lists.koha-community.org/msg08132.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 04:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 03:29:12 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #43 from Alex Buckley --- Created attachment 58862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58862&action=edit Bug 17855- Fourth update following testing feedback. Changed button and link names in web installer and onboarding tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 04:46:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 03:46:02 +0000 Subject: [Koha-bugs] [Bug 17888] New: quickbooks enterprise support phone number 1 8884364111 quickbooks error support phone number Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17888 Bug ID: 17888 Summary: quickbooks enterprise support phone number 1 8884364111 quickbooks error support phone number Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: adam00663 at yopmail.com QA Contact: testopia at bugs.koha-community.org quickbooks enterprise support phone number 1 8884364111 quickbooks error support phone number tum jo ho mere quickbooks enterprise support phone number 1 8884364111 quickbooks error support phone number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 05:55:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 04:55:47 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #44 from M. Tompsett --- Last piece... better handling of when passwords mismatch. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 06:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 05:49:02 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 --- Comment #27 from David Cook --- Hurray! Take that invalid local time for date in time zone... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 06:55:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 05:55:14 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 06:56:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 05:56:25 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #31 from David Cook --- (In reply to Katrin Fischer from comment #30) > Hm, tested this on a 3.22 database with the example from the test plan: > > Search from advanced search by accession date: > 2011-09-01 - 2011-09-30 > 9461 results > > Searched with SQL: > select distinct biblionumber from items where dateaccessioned between > '2011-09-01' and '2011-09-30' > 805 results > > The date range search doesn't seem to work right. > > The search for a single date seems to work correctly. You can also truncate > with *. > > Also filed this as a new bug report: bug 17815. I'll comment there. Sounds interesting! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 06:58:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 05:58:27 +0000 Subject: [Koha-bugs] [Bug 17815] Problems with search for dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I don't have time to look at this one at the moment, but it sounds interesting... Can you give us any more data? I trust with the SQL that the dateaccessioned would be between '2011-09-01' and '2011-09-30', but what about those 9461 results? If you look at a sample of them, do they all have dateaccessioned within that range, or do they have different data? Can you share a link to your results? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 07:00:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 06:00:45 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #43 from David Cook --- (In reply to Chris Cormack from comment #42) > Yes, bug 9850 meets all the requirements of this. We have it in production > for our sites. So we will not be doing any more work on this. > > Our recommendation is to use coce for book covers Bug 9850 is about Koha 3.12 help files. Was that a typo, Chris? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 07:01:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 06:01:24 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #44 from David Cook --- Ah, bug 9580 I'm guessing. I really need to look into Coce... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 07:06:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 06:06:13 +0000 Subject: [Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #3 from David Cook --- Just a note that I have no plans to work on this currently, so I'm happy for someone else to work on fixing this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 09:52:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 08:52:08 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 09:52:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 08:52:12 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58848|0 |1 is obsolete| | Attachment #58849|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 58863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58863&action=edit Bug 17817: Fix cloning subfields using select2 Based on Jonathan's patch (the DO NOT PUSH one), I put together this fix. What was changed is that select2 is reinitialized only after the cloned element has been appended to the DOM (so that select2 can correctly calculate the field's width). Also, I changed the selectors that searched for the line divs (for reordering) and for the subfield's input element (for erasing the field's value) to be more specific, since select2 introduced divs that broke some assumptions about the expected HTML structure Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart I confirm that these 2 patches fix the add item and mod biblio views as well as the batch item modification tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 09:52:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 08:52:18 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #22 from Jonathan Druart --- Created attachment 58864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58864&action=edit Bug 17817: (Follow up) Fix reordering subfields issues Authority controlled subfields have invisible divs which produced a strange behavior when reordering (multiple clicks were needed to push a subfield up over an authority controlled subfield) Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 09:58:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 08:58:28 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |marrone.patricio at gmail.com |ommunity.org | --- Comment #23 from Jonathan Druart --- Great job Patricio! Do not forget to add a test plan, for you next patches :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 10:07:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 09:07:28 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- What are the steps to recreate? select count(*) from search_marc_to_field; 476 Hit /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 => no error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 10:11:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 09:11:32 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #141 from Alex Sassmannshausen --- Hello Paul, Jonathan, Jonathan mostly covered the facts in his response. To confirm: (In reply to Paul Poulain from comment #136) > OK, guys, I've a functional question: > * I'm a chooser = how do I know that today (or tomorrow, or next weeks) > I'll have to do some choices ? > * I'm a deliverer = same question : how do I know I've to deliver ? The primary workflow here is that choosers and deliverers work in close concert with the library anyway: they have a weekly day, where they all get together and work through their respective tasks for instance. I like what you're proposing, which is, by the sound of it, a decentralised version of the above. > * I want to take profit of this service, can I register from the OPAC ? Again, currently this is managed by staff at the branch, or even indirectly, by the library service as a whole. It would be nice to allow people to sign up to it. At present we don't have specific time-scales to further develop those features ? but the architecture certainly should make the above options easy to implement, and I'm happy to provide guidance to anyone seeking to do so. HTH, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 10:19:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 09:19:31 +0000 Subject: [Koha-bugs] [Bug 17890] New: quickbooks techsupport number 18(884)364-111 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17890 Bug ID: 17890 Summary: quickbooks techsupport number 18(884)364-111 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: jonhson.baby at mail.com QA Contact: testopia at bugs.koha-community.org Quickbooks tech support number help to resolve numerous problem of any kinds of account software package for more information connect with us quickbooks enterprise support phone number, quickbooks tech support phone number and quickbooks error support phone number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 10:40:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 09:40:47 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 --- Comment #55 from Jonathan Druart --- There is something wrong here, I will open a new bug report soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 10:51:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 09:51:30 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 --- Comment #56 from Jonathan Druart --- Created attachment 58865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58865&action=edit Bug 17234: Need to separate KEY and FOREIGN KEY checks In the previous patch we use the constraint_exists subroutine to verify if an index or a foreign key exists. But the `SHOW INDEX` query does not return foreign keys (as its name suggests!). We need another subroutine foreign_key_exists to check the FK existence. I have found that because t/db_dependent/TestBuilder.t fails on oai_sets_biblios, because oai_sets_biblios_ibfk_1 has not been removed. Test plan: 0/ Do not apply this patch 1/ Use a 3.20 DB 2/ update the DB 3/ SHOW CREATE TABLE oai_sets_biblios will display oai_sets_biblios_ibfk_1 Apply the patch and repeat 1, 2, 3 => Will not display oai_sets_biblios_ibfk_1 It has been removed as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 10:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 09:52:25 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 --- Comment #57 from Jonathan Druart --- (In reply to Jonathan Druart from comment #55) > There is something wrong here, I will open a new bug report soon. I finally did not, we really cannot wait 3 months to get this followup in... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:01:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:01:35 +0000 Subject: [Koha-bugs] [Bug 17773] Not able to add or edit a record; error on screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #11 from Jonathan Druart --- Lowering the severity as it's not confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:02:46 +0000 Subject: [Koha-bugs] [Bug 17745] Notices does not generate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|major |normal --- Comment #2 from Jonathan Druart --- Hi Vimal, Could you give us more information to recreate this problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:10:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:10:23 +0000 Subject: [Koha-bugs] [Bug 11988] Display basket group close date on late orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11988 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27285|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 58866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58866&action=edit Bug 11988: Display aqbasketgroup.closeddate on late orders table Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:15:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:15:58 +0000 Subject: [Koha-bugs] [Bug 17891] New: typo in housebound.tt div tag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Bug ID: 17891 Summary: typo in housebound.tt div tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In housebound.tt there is a end tag div missing closing character '>'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:16:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:16:04 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:19:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:19:09 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:19:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:19:12 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #1 from Jonathan Druart --- Created attachment 58867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58867&action=edit Bug 17725: Do not copy subfield's content when cloning To replicate: - Open an existing record in your catalog - Create another field or subfield of a field/subfield already used using the icon to repeat it - Verify that the content is copied over - Verify this happens for input (one line) and textare (multiple lines) I can't make this happen for when creating a new record, but more consistently on editing existing records. This is rather annoying when cataloguing in Koha, as the cataloguer has to empty the field first and that adds an extra step for each repeated field. Test plan: Confirm than the content is not copied when you clone a field or a subfield. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:19:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:19:34 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 [Bug 17725] Repeating a field or subfield clones content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:19:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:19:34 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |17817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 [Bug 17817] Repeat this Tag (cloning) not working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:24:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:24:14 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:24:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:24:16 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 --- Comment #1 from Fridolin SOMERS --- Created attachment 58868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58868&action=edit Bug 17891 - typo in housebound.tt div tag In housebound.tt there is a end tag div missing closing character '>'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:26:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:26:55 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- >From /cgi-bin/koha/basket/basket.pl?bib_list=1/ I used Download > iso2709 Then import with the default character encoding option: UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:31:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:31:47 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 --- Comment #2 from Fridolin SOMERS --- BTW there is maybe a problem with this page, circ-menu.inc should be inside

    . Maybe the corrected tag should be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:35:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:35:15 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart on reimport In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #4 from Katrin Fischer --- I tested this on master before filing, but will test again and try to attach the exported files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 12:43:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 11:43:42 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:05:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:05:48 +0000 Subject: [Koha-bugs] [Bug 7654] Add location and callnumber at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #20 from Julian Maurice --- Callnumber is already displayed in master, but we can still add the location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:07:20 +0000 Subject: [Koha-bugs] [Bug 7654] Add location and callnumber at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16677|0 |1 is obsolete| | Attachment #16678|0 |1 is obsolete| | --- Comment #21 from Julian Maurice --- Created attachment 58869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58869&action=edit Bug 7654: Add location at opac subscription view Also fix a bug that prevent branch name to be displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:07:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:07:41 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add location and callnumber |Add location at opac |at opac subscription view |subscription view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:08:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:08:15 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:08:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:08:25 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:16:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:16:56 +0000 Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3 usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:17:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:17:00 +0000 Subject: [Koha-bugs] [Bug 17874] Bug 16239 followup - update bootstrap 3 usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17874 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58807|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 58870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58870&action=edit Bug 17874: Bug 16239 followup - polishing things This patch is made on top of bug 16239 to polish things. Makes these changes: - Buttons on add circulation message modal - Dropdowns has top and bottom margin 4px instead of 3px - btn-link class (for example in toolbar on advanced search pages) - Delete circ message is btn-link - Add new circ message is btn-link Test plan: - Confirm that all changes are as described above and that they make sense Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:18:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:18:37 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41072|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 58871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58871&action=edit Bug 14560: Rameau authorities Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:18:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:18:46 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41342|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 58872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58872&action=edit Bug 14560 [Follow-up]: Compatible with DOM indexing. Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:18:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:18:56 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43124|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 58873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58873&action=edit Bug 14560 [Follow-up]: QA: Add debug warnings and get biblionumber with GetMarcFromKohaField Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:19:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:19:11 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:19:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:19:45 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 --- Comment #3 from Jonathan Druart --- Comment on attachment 58808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58808 Bug 17181: Check for duplicate image names when uploading image to patron card creator Review of attachment 58808: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17181&attachment=58808) ----------------------------------------------------------------- ::: patroncards/image-manage.pl @@ +49,5 @@ > if ($op eq 'upload') { > + # Checking for duplicate image name > + my $duplicate; > + my $dbh = C4::Context->dbh; > + my $query = "SELECT image_name FROM creator_images"; What you want here is to select the number of images with the $image_name: SELECT COUNT(*) FROM creator_images WHERE image_name=? That will simplify this part of code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:19:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:19:52 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:43:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:43:20 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 --- Comment #58 from Kyle M Hall --- Followup "Bug 17234: Need to separate KEY and FOREIGN KEY checks" has been pushed to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:50:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:50:56 +0000 Subject: [Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- This bug has been in discussion for almost 4 years. I don't see why a discussion is needed here. According to comments, either the patch fixes a bug or it changes nothing, depending on the database content. Switching back to Needs signoff (patch still applies correctly) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 13:58:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 12:58:04 +0000 Subject: [Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 --- Comment #9 from Julian Maurice --- Created attachment 58874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58874&action=edit Bug 8306: Patrons statistics, fix for patron activity choice The "inactive" for "patron activity" choice is now effective. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:03:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:03:05 +0000 Subject: [Koha-bugs] [Bug 8306] Patron stats, patron activity : no active doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Julian Maurice --- My test plan: 1. Create a borrower X 2. Check out an item to borrower X 3. Check in the same item 4. Delete borrower X So now, I have an old_issues line with borrowernumber = NULL 5. Go to patron stats, Row = category, Column = library, Patron activity filter = no active ==> no results 6. Apply patch 7. Repeat 5 ==> results! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:42:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:42:20 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:44:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:44:07 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:44:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:44:47 +0000 Subject: [Koha-bugs] [Bug 15897] Use Koha::Account:: pay internally for recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:44:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:44:48 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Bug 15165 depends on bug 15897, which changed state. Bug 15897 Summary: Use Koha::Account::pay internally for recordpayment_selectaccts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:44:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:44:48 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Bug 15898 depends on bug 15897, which changed state. Bug 15897 Summary: Use Koha::Account::pay internally for recordpayment_selectaccts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:44:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:44:49 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Bug 15907 depends on bug 15897, which changed state. Bug 15897 Summary: Use Koha::Account::pay internally for recordpayment_selectaccts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15897 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:44:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:44:56 +0000 Subject: [Koha-bugs] [Bug 15907] Remove use of makepayment in opac/ opac-account-pay-paypal-return.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:44:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:44:56 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Bug 15905 depends on bug 15907, which changed state. Bug 15907 Summary: Remove use of makepayment in opac/opac-account-pay-paypal-return.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15907 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:45:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:45:09 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:45:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:45:09 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Bug 15894 depends on bug 15905, which changed state. Bug 15905 Summary: Remove use of makepayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:46:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:46:13 +0000 Subject: [Koha-bugs] [Bug 15898] Use Koha::Account::pay internally for makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:46:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:46:19 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:46:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:46:13 +0000 Subject: [Koha-bugs] [Bug 15909] Remove the use of makepartialpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 Bug 15909 depends on bug 15898, which changed state. Bug 15898 Summary: Use Koha::Account::pay internally for makepartialpayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15898 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:46:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:46:20 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Bug 15908 depends on bug 15909, which changed state. Bug 15909 Summary: Remove the use of makepartialpayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15909 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:46:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:46:27 +0000 Subject: [Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 14:46:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 13:46:28 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Bug 15894 depends on bug 15908, which changed state. Bug 15908 Summary: Remove use of recordpayment_selectaccts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:04:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:04:46 +0000 Subject: [Koha-bugs] [Bug 12584] koha-conf.xml for package installations get out of sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12584 --- Comment #8 from Magnus Enger --- Here is another example. The part of koha-conf.xml got drastically simplified by bug 9612 (in 2014): http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=etc/koha-conf.xml;h=26f53b729d11936e2f5488c5dfb13ca043540856;hp=72da2de9f8db9c279f72f917b7e4f414248fe094;hb=67abcc64433ba945416c7c8e8bf8aecc8c932f14;hpb=036f2a50e11dab97ef8509f2f585c4cc407ea728 But this was never carried over to debian/templates/koha-conf-site.xml.in: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=debian/templates/koha-conf-site.xml.in;h=7f13c6411530615fbe7867b2ccc71ef97bd728c9;hb=HEAD -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:29:12 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 --- Comment #5 from Marcel de Rooy --- Created attachment 58875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58875&action=edit Bug 17273: Add records to modify via shelf or search This patch adds two new ways to add records via two new URL parameters: [1] from_shelf allows you to pass a list number, [2] from_search allows you to pass a search expression. They are added now in the same way as bib_list was done earlier. A future report should incorporate them into the interface. Adding a new method to Virtualshelf along the way. Unit test in followup. Note: I copied the sub _extract_biblionumbers from a new report still in progress. I will move the sub to a module on a new report. Test plan: [1] Pick a list number (you should be allowed to see). And try this URL: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX where XX obviously is your list number. [2] Pick a search expression that does not generate too much records. And similarly try: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:29:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:29:33 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 --- Comment #6 from Marcel de Rooy --- Created attachment 58876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58876&action=edit Bug 17273: Add tests for Virtualshelf->list_biblionumbers Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:30:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:30:07 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:31:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:31:01 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58875|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 58877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58877&action=edit Bug 17273: Add records to modify via shelf or search This patch adds two new ways to add records via two new URL parameters: [1] from_shelf allows you to pass a list number, [2] from_search allows you to pass a search expression. They are added now in the same way as bib_list was done earlier. A future report should incorporate them into the interface. Adding a new method to Virtualshelf along the way. Unit test in followup. Note: I copied the sub _extract_biblionumbers from a new report still in progress. I will move the sub to a module on a new report. Test plan: [1] Pick a list number (you should be allowed to see). And try this URL: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX where XX obviously is your list number. [2] Pick a search expression that does not generate too much records. And similarly try: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:31:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:31:05 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58876|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 58878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58878&action=edit Bug 17273: Add tests for Virtualshelf->list_biblionumbers Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:32:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:32:59 +0000 Subject: [Koha-bugs] [Bug 17892] New: Move _extract_biblionumbers to a module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17892 Bug ID: 17892 Summary: Move _extract_biblionumbers to a module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 17273 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:33:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:33:10 +0000 Subject: [Koha-bugs] [Bug 17892] Move _extract_biblionumbers to a module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17892 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17273 Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 [Bug 17273] Batch MARC Modification - improve options to define which records to modify -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:33:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:33:10 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17892 [Bug 17892] Move _extract_biblionumbers to a module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:36:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:36:24 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #3 from Olli-Antti Kivilahti --- Hi. You can recreate the problem with this: perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings' Your solution looks very simple :) Unfortunately there is a bunch of business logic clumped together in the /admin/searchengine/elasticsearch/mappings.pl And I don't think business logic belongs to a controller module. Simply because that functionality is needed when writing tests. When writing tests it is better to call that one subroutine reset_elasticsearch_mappings instead of the bunch of code in mappings.pl If a subroutine says reset_elasticsearch_mappings(), I expect it to reset the elasticsearch mappings without errors. A simple solution would be to move: Koha::SearchMarcMaps->search->delete; inside Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings; which might be a better one than the DBIC-monster I created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:39:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:39:32 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #4 from Olli-Antti Kivilahti --- My modification preserves existing changes. The way it works in the mappings.pl, is to drop all changes and add the defaults. I guess the original one is the desired behaviour. But I strongly feel that the reset_elasticsearch_mappings()-subroutine needs to perform on its own. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 15:50:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 14:50:48 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #5 from Jonathan Druart --- Ok got it, so I guess it would be better to simply move the delete inside the reset_elasticsearch_mappings. And move the refactoring to another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:11:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:11:41 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 58879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58879&action=edit Bug 17813: (QA followup) Properly check DB structure before altering it This patch makes the atomic update use the new functions introduced by bug 17234 for checking the structure before attempting to call ALTER TABLE. It checks for the column existence, and also if it is a primary key. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:18:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:18:26 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #4 from Olli-Antti Kivilahti --- (In reply to Benjamin Rokseth from comment #2) > I notice this bug is rather old, but we actually suffered badly from this, > as we have several fully automated branches that are open 24/7 without staff. > They get better with age, like good wine and other stuff. Sorry to hear about your misery. We can completely relate to that :) > Our solution, by any mean not ideal, was to have separated branches for > automated selfcheck machines, a SIP translation proxy that fixes the items > that are NOT reserved so they can be put directly on the shelf, and finally > a cronjob to clean up the branchtransfer mess. > Our self-service libraries are separate branches and strangely I haven't heard of this problem manifesting yet for us, but I know sooner or later someone will notice. > We (Oslo Public Library) would gladly cooperate on this if any good ideas > turn up! You could attach the opening hours of the pickup library in the hold notification? Maybe this would help? Tinker a bit with the Letters-module. The C4::Letters::GetPreparedLetter() is very very hairy tho. Also you would need to add the library opening hours somewhere. Easiest thing to do is to make a YAML-config syspref with those opening hours per branch. Super fast GUI-replacement and will get this problem solved in no time. No need for DB or GUI code. >Instead of an email being sent immediately at that point to the patron next in >line for the request, the item would have a new circulation status e.g. ?In >SelfService? this removes the item from the patron?s record but does not >trigger the next hold until it is checked-in by a member of the library, at >which point the item moves onto the next circulation status that it would have >had before going into ?In SelfService? (e.g. ?On hold? or ?in transit? etc.) >However if the limbo-available-state between check-in can be fixed, (this >might be more trouble than it's worth) I guess this would make sense. Maybe this idea is a good solution? Put all SIP2-server checkouts to a Limbo-state Skip catching holds and transfers when put to a 'Limbo'-status? But relinguish ties to the previous borrower. Show in OPAC/Intra the status as Limbo, this is more brittle to program. Shouldn't be too difficult to test and program in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:20:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:20:29 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #6 from Olli-Antti Kivilahti --- Any suggestions for the title of the new refactorings bug? It is all closely related to this if you take a loot at the tests. Refactorings have been done so I can test this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:21:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:21:31 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 --- Comment #7 from Olli-Antti Kivilahti --- I am not sure that separating them to separate bugs is the correct solution here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:43:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:43:28 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #17 from Tom?s Cohen Arazi --- Created attachment 58880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58880&action=edit Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:44:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:44:29 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58730|0 |1 is obsolete| | --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 58881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58881&action=edit Bug 14187: branchtransfer needs a primary key (id) for DBIx and common sense. * C4/Circulation.pm (GetTransfers, GetTransfersFromTo): Also return branchtransfer_id in return columns. * installer/data/mysql/atomicupdate/14187.perl: New file. * installer/data/mysql/kohastructure.sql: Modify branchtransfers structure. * t/db_dependent/Circulation/transfers.t: Update tests to expect branchtransfer_id. Signed-off-by: Owen Leonard Test plan successful on all steps. Signed-off-by: Jonathan Druart Amended patch: Remove Schema changes from this patch Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:44:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:44:37 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58880|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi --- Created attachment 58882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58882&action=edit Bug 14187: (QA followup) Properly check DB structure before altering it Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:52:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:52:48 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17813 CC| |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:52:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:52:48 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:53:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:53:19 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:53:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:53:19 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:53:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:53:34 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14187 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:53:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:53:34 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14187 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 16:53:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 15:53:34 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17813 |17234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 [Bug 17813] Table borrower_attributes needs a primary key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 17:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 16:43:51 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 17:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 16:43:51 +0000 Subject: [Koha-bugs] [Bug 17893] New: Move JavaScript to the footer on staff client catalog pages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 Bug ID: 17893 Summary: Move JavaScript to the footer on staff client catalog pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: claire_gravely at hotmail.com, jonathan.druart at bugs.koha-community.org, testopia at bugs.koha-community.org Depends on: 17870, 17418 Blocks: 17858 This patch will move JavaScript to the footer on a number of pages in the catalog module of the staff client: basket/basket.tt catalogue/ISBDdetail.tt catalogue/MARCdetail.tt catalogue/advsearch.tt catalogue/detail.tt catalogue/imageviewer.tt catalogue/issuehistory.tt catalogue/itemsearch.tt catalogue/labeledMARCdetail.tt catalogue/moredetail.tt catalogue/results.tt catalogue/search-history.tt In the process I will be consolidating JS from several of those templates into one separate JavaScript file. Other modifications will be required in order for JavaScript to be able to be called from catalog-related include files. Since include files are parsed before jQuery is loaded in the footer, jQuery-specific code will have to be adapted or moved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 [Bug 17418] Move staff client home page JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 [Bug 17870] Call to include file incorrectly moved into the footer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 17:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 16:43:51 +0000 Subject: [Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 17:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 16:43:51 +0000 Subject: [Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17893 [Bug 17893] Move JavaScript to the footer on staff client catalog pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 18:03:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 17:03:38 +0000 Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 --- Comment #8 from M. Tompsett --- Comment on attachment 44132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44132 Bug 13146 UT Review of attachment 44132: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13146&attachment=44132) ----------------------------------------------------------------- Test::DBIx::Class isn't required to run Koha, just the tests, correct? Probably should skip tests we know we can't run. This will run fine on kohadevbox, but not necessarily on another users koha git box. ::: t/db_dependent/FieldMapping.t @@ +21,5 @@ > +use File::Basename; > +use File::Path; > +use DateTime; > +use Test::MockModule; > +use Test::More tests => 18; Just use Test::More; because of suggested change below. @@ +25,5 @@ > +use Test::More tests => 18; > +use C4::Biblio; > +use Koha::Schema; > + > + use Module::Load::Conditional qw/check_install/; BEGIN { if ( check_install( module => 'Test::DBIx::Class' ) ) { plan tests => 18; # or is it 19... whatever works. } else { plan skip_all => "Need Test::DBIx::Class" } } @@ +43,5 @@ > + _new_schema => sub { return Schema(); } > +); > + > + > +if (0) { What is the point of keeping the code, if it isn't run? @@ +55,5 @@ > +} > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) Multiple side-effects on the same line of code is more difficult to read. @@ +56,5 @@ > + > + > +SetFieldMapping('', 'maintitle', '245', 'a'); > +ok my $fm = Fieldmapping->find( {field => 'maintitle'} ) > + => 'maintitle field mapping properly set for default framework'; While this is valid, given that you did the simpler version of is() below, could this not be: my $fm = Fieldmapping->find( {field => 'maintitle'} ); ok( defined $fm, 'maintitle field mapping properly set for default framework'); instead? This is more readable. @@ +60,5 @@ > + => 'maintitle field mapping properly set for default framework'; > + > +SetFieldMapping('', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {field => 'subtitle'} ) > + => 'subtitle field mapping properly set for default framework'; same here. @@ +70,5 @@ > +}, 'expected fields are there'; > + > +SetFieldMapping('BOOK', 'subtitle', '245', 'b'); > +ok $fm = Fieldmapping->find( {frameworkcode => 'BOOK', field => 'subtitle'} ) > + => 'subtitle field mapping properly set for BOOK framework'; same here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 18:27:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 17:27:42 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOUserHTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca --- Comment #1 from Agnes Rivers-Moore --- I would love this - just setting up SCO and noted the need for a bit more on screen help. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 18:33:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 17:33:08 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOUserHTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #2 from Agnes Rivers-Moore --- I would love this option! Just setting up SCO and noted the need for a bit more user interface on screen help. It could be Library specific, so an HTML section would be very useful. I have help until end March 2017 - if anyone has time to introduce him to the code used we might be able to contribute, or to test. I would also like to change the text of the Print prompt - Cancel or OK is not very helpful in answer to "Do you want to print?" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 18:36:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 17:36:01 +0000 Subject: [Koha-bugs] [Bug 17449] Let users choose action in self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 18:37:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 17:37:29 +0000 Subject: [Koha-bugs] [Bug 16732] Add audio alerts (custom sound notifications) to web based self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16732 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 18:39:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 17:39:19 +0000 Subject: [Koha-bugs] [Bug 5250] Various enhancements to web based checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 19:48:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 18:48:22 +0000 Subject: [Koha-bugs] [Bug 17894] New: Remove and Replace WriteOffFee Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Bug ID: 17894 Summary: Remove and Replace WriteOffFee Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org WriteOffFee is the last of the "payment" subroutines that need to be merged into Koha::Account::pay ( as a writeoff is really just a special case payment ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 19:48:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 18:48:27 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 [Bug 15894] Unify all account fine payment functions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 19:48:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 18:48:27 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 [Bug 17894] Remove and Replace WriteOffFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 19:57:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 18:57:27 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 19:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 18:57:29 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #1 from Kyle M Hall --- Created attachment 58883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58883&action=edit Bug 17894 - Update pay() and use it internally for WriteOffFee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 19:57:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 18:57:35 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #2 from Kyle M Hall --- Created attachment 58884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58884&action=edit Bug 17894 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 19:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 18:57:38 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #3 from Kyle M Hall --- Created attachment 58885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58885&action=edit Bug 17894 - Remove and replace WriteOffFee WriteOffFee is the last of the "payment" subroutines that need to be merged into Koha::Account::pay ( as a writeoff is really just type of payment ). Test Plan: 1) Apply this patch 2) Verify the writeoff, and writeoff all buttons still work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 20:11:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 19:11:46 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #2 from Claire Gravely --- I have been unable to fully replicate the issue, but have found one occurance of an "input" field including content when copied. I have successfully replicated the issue with texarea fields (multiple lines). When testing I find the patch has fixed my single "input" field issue. But the "textarea" field still includes content when cloned. Specifically this was 520 $a. Content is still copying across -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 20:40:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 19:40:13 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #22 from M. Tompsett --- Comment on attachment 58869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58869 Bug 7654: Add location at opac subscription view Review of attachment 58869: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7654&attachment=58869) ----------------------------------------------------------------- Here are some untested thoughts. :) ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +796,4 @@ >

    There are [% subscriptionsnumber %] subscription(s) associated with this title.

    > [% FOREACH subscription IN subscriptions %] > [% IF ( subscription.branchcode ) %] > +

    At library: [% Branches.GetName( subscription.branchcode ) %]

    What if it gets a branch, but someone failed to enter a description or it is blank? Displaying the branchcode in that case would make sense. I do not think this correction is correct. [% at_library = Branches.GetName( subscription.branchcode ) %] [% SET at_library = subscription.branchcode IF at_library.length=0 %] [% IF at_library %]

    At library: [% at_library ) %]

    [% END %] @@ -799,5 @@ > -

    At library: [% Branches.GetName( subscription.branchname ) %]

    > - [% ELSE %] > - [% IF ( subscription.branchcode ) %] > -

    At library: [% subscription.branchcode %]

    > - [% END %] I'm pretty sure this code was intending to display a branch name if possible, but if not just the branch code. And clearly, it is wrong about that. @@ +813,5 @@ >

    [% subscription.opacnote FILTER html_line_break %]

    > [% END %] > + [% IF subscription.location_description || subscription.location %] > +

    Location: [% IF subscription.location_description %][% subscription.location_description %][% ELSE %][% subscription.location %][% END %]

    > + [% END %] [% location_description = subscription.location_description %] [% SET location_description = subscription.location IF ! defined location_description || location_description.length=0 %] [% IF location_description %]

    Location: [% location_description %]

    [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 20:45:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 19:45:43 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 --- Comment #23 from Katrin Fischer --- (In reply to M. Tompsett from comment #22) > Comment on attachment 58869 [details] [review] > Bug 7654: Add location at opac subscription view > > Review of attachment 58869 [details] [review]: > ----------------------------------------------------------------- > > Here are some untested thoughts. :) > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt > @@ +796,4 @@ > >

    There are [% subscriptionsnumber %] subscription(s) associated with this title.

    > > [% FOREACH subscription IN subscriptions %] > > [% IF ( subscription.branchcode ) %] > > +

    At library: [% Branches.GetName( subscription.branchcode ) %]

    > > What if it gets a branch, but someone failed to enter a description or it is > blank? Displaying the branchcode in that case would make sense. I do not > think this correction is correct. That's actually not a problem. The branchcode and branchname are both mandatory. It's not possible to have a branch without a branchname in Koha. Using the TT plugin like this is common in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 21:14:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 20:14:38 +0000 Subject: [Koha-bugs] [Bug 9594] order item subfields in framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9594 --- Comment #2 from Marjorie Barry-Vila --- +1 Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 22:16:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 21:16:18 +0000 Subject: [Koha-bugs] [Bug 17752] Fast add record & item with populating fields from Z39.50 with prompts for barcode and patron for ILL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17752 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 22:21:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 21:21:43 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #45 from Nick Clemens --- (In reply to David Cook from comment #44) > Ah, bug 9580 I'm guessing. > > I really need to look into Coce... ByWater has a coce server that anyone is welcome to use (the more users the more images ready for use) https://coce.bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 12 22:26:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 21:26:20 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #45 from Alex Buckley --- Created attachment 58886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58886&action=edit Bug 17855 -Fifth update following tester feedback. Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:00:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:00:38 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #46 from M. Tompsett --- Comment on attachment 58886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58886 Bug 17855 -Fifth update following tester feedback. Review of attachment 58886: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=58886) ----------------------------------------------------------------- This is from my quick eyeball check. Now to test. ::: installer/onboarding.pl @@ -143,4 @@ > $template->param( itemtypes => $itemtypes, ); > } > elsif ( $step && $step == 1 ) { > - my $createlibrary = $input->param('createlibrary'); #Store the inputted library branch code and name in $createlibrary variable Not a biggie, but in the future put comments above, so that perl tidy doesn't put the semi-colon on the next line which is harder to read. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt @@ -40,5 @@ > - }, > - userid: { > - required: true; > - letters_numbers: true > - }, Why is this removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:03:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:03:39 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:03:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:03:43 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #2 from Aleisha Amohia --- Created attachment 58887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58887&action=edit Bug 4461: Add a context-sensitive 'Report a Problem' feature to OPAC This patch adds a 'Report a problem' link to the bottom of every page in the OPAC. The user can choose to submit their report to the library or Koha administrator. The report will store the user's problem message, but also their username and the page they were on when they clicked the 'report a problem' link. The patch adds a table 'problem_reports' to the db. To test: 1) Apply patch, update database, rebuild schema 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that one of your libraries has an branch email address. 5) Confirm that the syspref KohaAdminEmailAddress has been filled out. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) First try submitting a problem to the library. Confirm that the fields for 'Problem found on page' and 'Username' are correct, then fill out the 'Subject' and 'Message' and click Submit. 9) Confirm a message shows at the top of the page to show success. 10) Go into mysql and display records from the message_queue table. Confirm that the borrowernumber and subject are correct. Confirm that content shows the message from the problem report, but also the user's username and the problem page. Confirm that the to_address shows the library's email address and the from_address shows the user's email address. 11) Now try submitting a problem to the Koha Admin. Fill fields and click Submit. Confirm message shows at top to show success again. 12) Check message_queue for new problem report. Confirm that the to_address shows the email address from the syspref KohaAdminEmailAddress. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:03:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:03:56 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:07:27 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #47 from Alex Buckley --- I removed the userid javascript validation because it is unnecessary, due to the following reasons: *There is already a html required="required" attribute on this input field *And a html regex on this field Therefore javascript validation is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:09:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:09:33 +0000 Subject: [Koha-bugs] [Bug 5272] can't import just patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- Is this still valid? I don't see the patron attributes options as shown in the screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:09:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:09:50 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #48 from Alex Buckley --- And thankyou for the note about the comments position, would you like me to change that now or just remember it for future commits? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:30:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:30:33 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:30:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:30:37 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58808|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 58888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58888&action=edit Bug 17181: Check for duplicate image names when uploading image to patron card creator This patch adds a check for duplicates before uploading the image. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) If you haven't already, upload an image 3) Try to upload another image with the same image name 4) Notice the first image is replaced with the second image, with no warning. 5) Apply patch and refresh page 6) Try to upload an image with the same image name again 7) Notice you are now warned about a duplicate image name. 8) Check that uploading an image with a unique name still works. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:37:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:37:41 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |aleishaamohia at hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 00:55:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 12 Jan 2017 23:55:32 +0000 Subject: [Koha-bugs] [Bug 6393] ability to edit staged records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6393 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:12:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:12:44 +0000 Subject: [Koha-bugs] [Bug 6507] Renew ALL from self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6507 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:19:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:19:29 +0000 Subject: [Koha-bugs] [Bug 17895] New: Small typo -'re-set' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Bug ID: 17895 Summary: Small typo -'re-set' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Triggered when resetting password and current password is entered incorrectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:22:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:22:54 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 --- Comment #1 from Aleisha Amohia --- Created attachment 58889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58889&action=edit Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:22:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:22:50 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:23:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:23:03 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:43:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:43:17 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58203|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 58890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58890&action=edit Bug 17782 - Patron updated_on field should be set to current timestamp when borrower is deleted To test: 01 Find a patron 02 Get the updated_on value from the db in borrowers table 03 Delete the patron 04 Get the update_on value from the db on deletedborrowers table 05 Values from 02 and 04 are the same 06 Apply patch 07 Repeat 01-04 08 Values should now be different -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:43:14 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:43:51 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #7 from Nick Clemens --- I thought it worked the other way, this is better though :-) Updated patch (In reply to Jonathan Druart from comment #5) > Nick, I did not test, but it does not work that way. If you want DBIx::Class > to use the default value you must not pass the key. > So: > delete $patron_infos->{updated_on}; > should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:56:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:56:06 +0000 Subject: [Koha-bugs] [Bug 17896] New: Enabling syspref 'BakerTaylorEnabled' causes software error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Bug ID: 17896 Summary: Enabling syspref 'BakerTaylorEnabled' causes software error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org This error: Undefined subroutine &CGI::Compile::ROOT::home_vagrant_kohaclone_opac_opac_2dreadingrecord_2epl::image_url called at /home/vagrant/kohaclone/opac/opac-readingrecord.pl line 125. is triggered when I enable BakerTaylorEnabled and look at my reading history on the OPAC because subroutines it needs aren't imported until after they are called. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:57:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:57:48 +0000 Subject: [Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:57:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:57:52 +0000 Subject: [Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 --- Comment #1 from Aleisha Amohia --- Created attachment 58891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58891&action=edit Bug 17896: Rearranging code in opac-readingrecord.pl so BakerTaylorEnabled works To test: 1) Enable BakerTaylorEnabled and attempt to view reading history in OPAC 2) Notice error 3) Apply patch and refresh page 4) Notice error is gone and page works Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 01:58:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 00:58:47 +0000 Subject: [Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 02:42:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 01:42:59 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #49 from Alex Buckley --- Created attachment 58892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58892&action=edit Bug 17855 - Fixed the errors from the koha qa test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 02:43:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 01:43:29 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #50 from Alex Buckley --- Created attachment 58893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58893&action=edit Bug 17855- Sixth update following testing feedback. Changes following errors from qa tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:23:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:23:03 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #51 from Alex Buckley --- Created attachment 58894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58894&action=edit Bug 17855 - Removed use:C4/Auth from the onboarding.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:35:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:35:36 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58792|0 |1 is obsolete| | Attachment #58793|0 |1 is obsolete| | --- Comment #52 from M. Tompsett --- Created attachment 58895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58895&action=edit bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged the first two commits Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:35:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:35:52 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58794|0 |1 is obsolete| | --- Comment #53 from M. Tompsett --- Created attachment 58896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58896&action=edit Finished initial web installer and onboarding tool https://bugs.koha-community.org/show_bug.cgi?id=17855 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:36:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:36:00 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58846|0 |1 is obsolete| | --- Comment #54 from M. Tompsett --- Created attachment 58897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58897&action=edit Bug 17855 - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script These changes are based on feedback from testing. Test plan: 1. Go through the web installer and onboarding tool as outlined in this guide: https://koha-community.org/manual/installation/html/ Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:36:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:36:07 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58860|0 |1 is obsolete| | --- Comment #55 from M. Tompsett --- Created attachment 58898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58898&action=edit Bug 17855 - Second update following testing feedback Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' Added the use CGI qw ( -utf8 ); Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:36:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:36:14 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58861|0 |1 is obsolete| | --- Comment #56 from M. Tompsett --- Created attachment 58899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58899&action=edit Bug 17855 -Third update follwing testing feedback Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt Fixed typo in summary.tt Made consistent single space before and after -> in all onboarding .tt and summary.tt files. Made single
    tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:36:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:36:27 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58886|0 |1 is obsolete| | --- Comment #58 from M. Tompsett --- Created attachment 58901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58901&action=edit Bug 17855 -Fifth update following tester feedback. Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:36:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:36:21 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58862|0 |1 is obsolete| | --- Comment #57 from M. Tompsett --- Created attachment 58900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58900&action=edit Bug 17855- Fourth update following testing feedback. Changed button and link names in web installer and onboarding tool Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:36:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:36:33 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58892|0 |1 is obsolete| | --- Comment #59 from M. Tompsett --- Created attachment 58902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58902&action=edit Bug 17855 - Fixed the errors from the koha qa test Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:37:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:37:26 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58901|0 |1 is obsolete| | --- Comment #60 from M. Tompsett --- Created attachment 58903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58903&action=edit Bug 17855 -Fifth update following tester feedback. Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:37:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:37:32 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58902|0 |1 is obsolete| | --- Comment #61 from M. Tompsett --- Created attachment 58904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58904&action=edit Bug 17855 - Fixed the errors from the koha qa test Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:38:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:38:57 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58894|0 |1 is obsolete| | --- Comment #62 from M. Tompsett --- Created attachment 58905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58905&action=edit Bug 17855 - Removed use:C4/Auth from the onboarding.pl Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:40:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:40:23 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58893|0 |1 is obsolete| | --- Comment #63 from M. Tompsett --- Comment on attachment 58893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58893 Bug 17855- Sixth update following testing feedback. Whitespace fixes generate empty patch from my install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:41:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:41:40 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58905|0 |1 is obsolete| | --- Comment #64 from M. Tompsett --- Created attachment 58906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58906&action=edit Bug 17855- Sixth update following testing feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:42:28 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:42:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:42:32 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #65 from M. Tompsett --- Created attachment 58907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58907&action=edit Bug 17855 - Removed use:C4/Auth from the onboarding.pl Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 03:50:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 02:50:54 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #66 from M. Tompsett --- Squashed first two patches to solve koha qa test tool issue. Ran basic/advanced unimarc/marc combinations. Looks great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 04:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 03:00:24 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #67 from Alex Buckley --- I have retested this bug 17855 and it works as I intend it to do so -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 04:24:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 03:24:08 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #24 from M. Tompsett --- (In reply to Jonathan Druart from comment #23) > (In reply to M. Tompsett from comment #22) > > But they could, if they were onboard'd. See bug 17855 for some enhancement > > dreaming. :) > > Bug 17855 is huge and does not seem to be ready to be pushed. > I'd prefer not to wait for it to get this one in. It is ready for QA now. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:26:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:26:34 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:26:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:26:36 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58883|0 |1 is obsolete| | Attachment #58884|0 |1 is obsolete| | Attachment #58885|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 58908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58908&action=edit [SIGNED-OFF] Bug 17894 - Update pay() and use it internally for WriteOffFee Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:26:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:26:43 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #5 from Josef Moravec --- Created attachment 58909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58909&action=edit [SIGNED-OFF] Bug 17894 - Add unit tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:26:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:26:49 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #6 from Josef Moravec --- Created attachment 58910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58910&action=edit [SIGNED-OFF] Bug 17894 - Remove and replace WriteOffFee WriteOffFee is the last of the "payment" subroutines that need to be merged into Koha::Account::pay ( as a writeoff is really just type of payment ). Test Plan: 1) Apply this patch 2) Verify the writeoff, and writeoff all buttons still work Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:39:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:39:10 +0000 Subject: [Koha-bugs] [Bug 17896] Enabling syspref 'BakerTaylorEnabled' causes software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:39:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:39:28 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:40:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:40:42 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:48:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:48:18 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:48:21 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58877|0 |1 is obsolete| | Attachment #58878|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 58911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58911&action=edit [SIGNED-OFF] Bug 17273: Add records to modify via shelf or search This patch adds two new ways to add records via two new URL parameters: [1] from_shelf allows you to pass a list number, [2] from_search allows you to pass a search expression. They are added now in the same way as bib_list was done earlier. A future report should incorporate them into the interface. Adding a new method to Virtualshelf along the way. Unit test in followup. Note: I copied the sub _extract_biblionumbers from a new report still in progress. I will move the sub to a module on a new report. Test plan: [1] Pick a list number (you should be allowed to see). And try this URL: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX where XX obviously is your list number. [2] Pick a search expression that does not generate too much records. And similarly try: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:48:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:48:26 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 --- Comment #10 from Josef Moravec --- Created attachment 58912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58912&action=edit [SIGNED-OFF] Bug 17273: Add tests for Virtualshelf->list_biblionumbers Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 07:57:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 06:57:09 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #3 from Josef Moravec --- Yes there still remains last occurence of this bug - textareas when clonning whole field - typically 5xx in MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:01:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:01:16 +0000 Subject: [Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273 --- Comment #11 from Marcel de Rooy --- (In reply to Josef Moravec from comment #10) > Signed-off-by: Josef Moravec Thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:09:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:09:51 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:09:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:09:54 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58890|0 |1 is obsolete| | --- Comment #8 from Claire Gravely --- Created attachment 58913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58913&action=edit Bug 17782 - Patron updated_on field should be set to current timestamp when borrower is deleted To test: 01 Find a patron 02 Get the updated_on value from the db in borrowers table 03 Delete the patron 04 Get the update_on value from the db on deletedborrowers table 05 Values from 02 and 04 are the same 06 Apply patch 07 Repeat 01-04 08 Values should now be different Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:11:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:11:20 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #4 from Katrin Fischer --- Something that might be good to test: When an input field contains a lot of text, next time you open the record it will be shown as a textarea. The 5xx seem to always display as a textarea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:18:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:18:37 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #98 from Marcel de Rooy --- QA: Working on this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:46:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:46:44 +0000 Subject: [Koha-bugs] [Bug 7654] Add location at opac subscription view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at bugs.koha-c | |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:52:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:52:58 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #5 from Jonathan Druart --- Created attachment 58914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58914&action=edit Bug 17725: Same for textarea when cloning a field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:53:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:53:52 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- (In reply to Josef Moravec from comment #3) > Yes there still remains last occurence of this bug - textareas when clonning > whole field - typically 5xx in MARC21 Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 08:56:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 07:56:12 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #68 from Jonathan Druart --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:04:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:04:11 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:04:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:04:13 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58867|0 |1 is obsolete| | Attachment #58914|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 58915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58915&action=edit [SIGNED-OFF] Bug 17725: Do not copy subfield's content when cloning To replicate: - Open an existing record in your catalog - Create another field or subfield of a field/subfield already used using the icon to repeat it - Verify that the content is copied over - Verify this happens for input (one line) and textare (multiple lines) I can't make this happen for when creating a new record, but more consistently on editing existing records. This is rather annoying when cataloguing in Koha, as the cataloguer has to empty the field first and that adds an extra step for each repeated field. Test plan: Confirm than the content is not copied when you clone a field or a subfield. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:04:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:04:19 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #8 from Josef Moravec --- Created attachment 58916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58916&action=edit [SIGNED-OFF] Bug 17725: Same for textarea when cloning a field Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:04:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:04:52 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #9 from Josef Moravec --- (In reply to Katrin Fischer from comment #4) > Something that might be good to test: When an input field contains a lot of > text, next time you open the record it will be shown as a textarea. The 5xx > seem to always display as a textarea. Tested, and looks fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:11:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:11:00 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:11:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:11:47 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #69 from Jonathan Druart --- Ok, fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:18:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:18:00 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Josef Moravec --- could you rebase please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:31:12 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 --- Comment #10 from Katrin Fischer --- (In reply to Josef Moravec from comment #9) > (In reply to Katrin Fischer from comment #4) > > Something that might be good to test: When an input field contains a lot of > > text, next time you open the record it will be shown as a textarea. The 5xx > > seem to always display as a textarea. > > Tested, and looks fine Thx, Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:39:47 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:39:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:39:49 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58888|0 |1 is obsolete| | --- Comment #5 from Claire Gravely --- Created attachment 58917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58917&action=edit Bug 17181: Check for duplicate image names when uploading image to patron card creator This patch adds a check for duplicates before uploading the image. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) If you haven't already, upload an image 3) Try to upload another image with the same image name 4) Notice the first image is replaced with the second image, with no warning. 5) Apply patch and refresh page 6) Try to upload an image with the same image name again 7) Notice you are now warned about a duplicate image name. 8) Check that uploading an image with a unique name still works. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 09:52:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 08:52:38 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|Signed Off |Failed QA --- Comment #70 from Jonathan Druart --- Hi Alex, This looks great, good job! In my opinion, this is not ready yet to be pushed. I have a few questions and remarks: 1/ I have tried the basic and advanced mode, the only difference I noticed is that checkboxes do not appear on the next screen. If it is the only difference, I do not see the point of that parameter. 2/ Before your patch, the "Select all options" was a button. It was intended and is the correct element to use 3/ When all the default data are select, we get pages saying "there is nothing to do because the data are already inserted". I think it would be better to skip these screen and not to see them at all. 4/ The forms are not using the usual Koha style 5/ About the circulation rule, how did you pick the value to define? For instance "Current on-site checkouts allowed" is not configurable and the default value becomes "unlimited". I do not think it is the desirable behavior. 6/ I would suggest to add an option to skip the onboarding Should be an option, we need a way to skip it 7/ At the end of the installer, the button "finish" has been replaced with "set koha version system preference". The wording sounds wrong. Maybe we need to have 2 choices at that point: - Set up Koha with the onboarding tool - Finish (and skip the onboarding tool) 8/ Cardnumber: >From the template you use "minlength_cardnumber", but it's not pass from the script (I may missed something). The behavior of the validation is not correct, a cardnumber can be composed with alpha chars. I think it would be good to get Owen point of views about this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:13:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:13:50 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:13:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:13:54 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58431|0 |1 is obsolete| | Attachment #58433|0 |1 is obsolete| | Attachment #58501|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 58918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58918&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls C4::Circulation::GetItemIssue returned all the issue and item informations for a given issue. Moveover it also did some date manipulations. Most of the time this subroutine was called, there additional information were useless as the caller usually just needed the basic issue's infos 'from the issue table). This first patch updates the simple calls, ie. the ones that just need the issue's infomations. Test plan: The following operations should success: - transfer a book - create a rule for on-site checkouts and confirm that a patron cannot check more items out that it's defined in the rule. - Renew an issue using ILSDI - Using SIP confirm that you are able to see your issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:13:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:13:59 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #14 from Jonathan Druart --- Created attachment 58919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58919&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue This patch simply removes the C4::Circulation::GetItemIssue subroutine Test plan: At this point, `git grep GetItemIssue` should not return any occurrence in the codebase Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:14:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:14:04 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #15 from Jonathan Druart --- Created attachment 58920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58920&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls There are a few calls to GetItemIssue where it's not as easy to make sure everything will be fine just replacing the calls with a Koha::Issues->find - In AddReturn the overdue flag is used (that's why this patch depends on bug 17689) - In CanBookBeRenewed, as well as the overdue flag the dates converted to DateTime were used. It's now our job to convert them when we need them. - Same in AddRenewal but we also call _CalculateAndUpdateFine, so we need to update the variables in this subroutine. Note that, prior to this patch, AddReturn returned the GetItemIssue hashref in the $iteminformation. Most of the time this variable is not used, I have found only 1 place where it's used: circ/returns.pl TODO: In this script we should call ->is_overdue instead of the DateTime->compare calls Test plan: All the circulation tests must pass (it's how I have caught the specific cases). Do some checkins/checkouts/renewal and focus on the due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:24:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:24:41 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58917|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 58921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58921&action=edit Bug 17181: Check for duplicate image names when uploading image to patron card creator This patch adds a check for duplicates before uploading the image. To test: 1) Go to Tools -> Patron card creator -> Manage images 2) If you haven't already, upload an image 3) Try to upload another image with the same image name 4) Notice the first image is replaced with the second image, with no warning. 5) Apply patch and refresh page 6) Try to upload an image with the same image name again 7) Notice you are now warned about a duplicate image name. 8) Check that uploading an image with a unique name still works. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:24:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:24:45 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 --- Comment #7 from Jonathan Druart --- Created attachment 58922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58922&action=edit Bug 17181: Simplify code - do not prepare statement when used only once - remove use of Data::Dumper - remove $duplicate, not needed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:24:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:24:37 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:40:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:40:49 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58505|0 |1 is obsolete| | --- Comment #99 from Marcel de Rooy --- Created attachment 58923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58923&action=edit Bug 17196: Move marcxml out of the biblioitems table Two discussions on koha-devel lead to the same conclusion: biblioitems.marcxml should be moved out this table - biblio and biblioitems http://lists.koha-community.org/pipermail/koha-devel/2013-April/039239.html - biblioitems.marcxml & biblioitems.marc / HUGE performance issue ! http://lists.koha-community.org/pipermail/koha-devel/2016-July/042821.html There are several goals to do it: - Performance As Paul Poulain wrote, a simple query like SELECT publicationyear, count(publicationyear) FROM biblioitems GROUP BY publicationyear; takes more than 10min on a DB with more than 1M bibliographic records but only 3sec (!) on the same DB without the biblioitems.marcxml field Note that priori to this patch set, the biblioitems.marcxml was not retrieved systematically, but was, at least, in C4::Acquisition::GetOrdersByBiblionumber and C4::Acquisition::GetOrders - Flexibility Storing the marcxml in a specific table would allow use to store several kind of metadata (USMARC, MARCXML, MIJ, etc.) and different formats (marcflavour) - Clean code It would be a first step toward Koha::MetadataRecord for bibliographic records (not done in this patch set). Test plan: - Update the DBIC Schema - Add / Edit / Delete / Import / Export bibliographic records - Add items - Reindex records using ES - Confirm that the following scripts still work: * misc/cronjobs/delete_records_via_leader.pl * misc/migration_tools/build_oai_sets.pl - Look at the reading history at the OPAC (opac-readingrecord.pl) - At the OPAC, click on a tag, you must see the result Note: Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108. Signed-off-by: Mason James Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:40:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:40:54 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58506|0 |1 is obsolete| | --- Comment #100 from Marcel de Rooy --- Created attachment 58924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58924&action=edit Bug 17196: Fix query builder for item search The item search needs to join on biblio_metadata to allow search on marcxml field Test plan: Launch complex item searches (using marc fields). Signed-off-by: Mason James Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:00 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58507|0 |1 is obsolete| | --- Comment #101 from Marcel de Rooy --- Created attachment 58925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58925&action=edit Bug 17196: Update misc/maintenance/sanitize_records.pl Test plan: Use the sanitize_records.pl maintenance script with the --auto-search option Signed-off-by: Mason James Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:06 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58508|0 |1 is obsolete| | --- Comment #102 from Marcel de Rooy --- Created attachment 58926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58926&action=edit Bug 17196: Update switch_marc21_series_info.pl Not sure if this script is still used, could someone confirm? Test plan: If you know how to test it, please do Signed-off-by: Mason James Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:12 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58509|0 |1 is obsolete| | --- Comment #103 from Marcel de Rooy --- Created attachment 58927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58927&action=edit Bug 17196: DB Changes Remove biblioitems.marcxml and deletedbiblioitems.marcxml and adds 2 table biblio_metadata and deletedbiblio_metadata Signed-off-by: Mason James Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:18 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58510|0 |1 is obsolete| | --- Comment #104 from Marcel de Rooy --- Created attachment 58928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58928&action=edit Bug 17196: Simplify tests for the different marc flavours centralize the way MARC field are set. Signed-off-by: Mason James Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:24 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58511|0 |1 is obsolete| | --- Comment #105 from Marcel de Rooy --- Created attachment 58929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58929&action=edit Bug 17196: Fix - Update metadata on update Signed-off-by: Mason James Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:29 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58512|0 |1 is obsolete| | --- Comment #106 from Marcel de Rooy --- Created attachment 58930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58930&action=edit Bug 17196: follow-up for bug 17088 If bug 17088 is pushed first, we will need this patch. Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:35 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58513|0 |1 is obsolete| | --- Comment #107 from Marcel de Rooy --- Created attachment 58931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58931&action=edit Bug 17196: Fix build_oai_sets.pl The wrong value was retrieved. Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:40 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58514|0 |1 is obsolete| | --- Comment #108 from Marcel de Rooy --- Created attachment 58932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58932&action=edit Bug 17196: Update POD of sanitise_records.pl Signed-off-by: Josef Moravec Signed-off-by: Zeno Tajoli Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:46 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58516|0 |1 is obsolete| | --- Comment #109 from Marcel de Rooy --- Created attachment 58933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58933&action=edit Bug 17196: Fix delete_records_via_leader.pl Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:52 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #110 from Marcel de Rooy --- Created attachment 58934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58934&action=edit Bug 17196 - (QA Followup) Use items from Koha::Biblio Signed-off-by: Nick Clemens Signed-off-by: Marcel de Rooy Amended: Using items from Koha::Biblio seems better :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:41:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:41:59 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #111 from Marcel de Rooy --- Created attachment 58935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58935&action=edit Bug 17196: [QA Follow-up] Correct POD in ILSDI/Services.pm QA tools complains about: Apparent command =cut not preceded by blank line. Trivial fix. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:42:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:42:04 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #112 from Marcel de Rooy --- Created attachment 58936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58936&action=edit Bug 17196: [QA Follow-up] DBIx schema changes Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:42:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:42:10 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #113 from Marcel de Rooy --- Created attachment 58937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58937&action=edit Bug 17196: [QA Follow-up] Wrong module in Record.t Should be the singular version instead of the plural one. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:42:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:42:16 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #114 from Marcel de Rooy --- Created attachment 58938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58938&action=edit Bug 17196: [QA Follow-up] Missing unique key in kohastructure See the atomic update. Signed-off-by: Marcel de Rooy Tested on command line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:43:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:43:16 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #115 from Marcel de Rooy --- Still working on it little bit, but looks good. Please wait.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:44:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:44:04 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58517|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:45:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:45:04 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #116 from Marcel de Rooy --- Some preliminary findings: opac/opac-readingrecord.pl: Calling GetXmlBiblio seems useless here. Probably should be GetMarcBiblio. opac-search.pl: map { (C4::Context->config('zebra_bib_index_mode') eq 'dom')? $_->{marcxml}: $_->{marc}; } This marc reference should not have been there anymore? C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if they are needed. Does item search actually looks into the xml? Seems not. New report?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:56:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:56:23 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #117 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #116) > Some preliminary findings: > > opac/opac-readingrecord.pl: Calling GetXmlBiblio seems useless here. > Probably should be GetMarcBiblio. GetMarcBiblio does much more stuffs than GetXmlBiblio. Since we just want the metadata it's better like that. > opac-search.pl: map { (C4::Context->config('zebra_bib_index_mode') eq > 'dom')? $_->{marcxml}: $_->{marc}; } This marc reference should not have > been there anymore? Nope, the column does no longer exist. > C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if > they are needed. Does item search actually looks into the xml? Seems not. > New report?? I don't think so, it uses it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 10:58:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 09:58:27 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #118 from Jonathan Druart --- (In reply to Jonathan Druart from comment #117) > > C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if > > they are needed. Does item search actually looks into the xml? Seems not. > > New report?? > > I don't think so, it uses it. See C4::Items::_SearchItems_build_where_fragment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:04:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:04:45 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #119 from Marcel de Rooy --- > C4/Items.pm: changes aimed for catalogue/itemsearch.pl, but I am not sure if > they are needed. Does item search actually looks into the xml? Seems not. > New report?? So that is wrong. You can do it via dmin/items_search_fields.pl. Works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:05:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:05:27 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #120 from Marcel de Rooy --- dmin -> admin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:19:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:19:46 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17818 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:19:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:19:46 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17725 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:38:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:38:22 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #121 from Jonathan Druart --- Created attachment 58939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58939&action=edit Bug 17196: Remove occurrence of marcxml in columns.def Also remove a wrong ref to the marc column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:43:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:43:59 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart --- Please provide tests (t/db_dependent/Koha/Patrons.t -> move_to_deleted). Note that at one test does not pass on my devbox: # Failed test 'Koha::Patron->move_to_deleted should have correctly moved the patron to the deleted table' # at t/db_dependent/Koha/Patrons.t line 331. # Structures begin differing at: # $got->{updated_on} = '2017-01-13 11:42:27' # $expected->{updated_on} = '2017-01-13 10:42:26' system date is 2017-01-13 11:42:27 I do not understand what's going on actually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:44:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:44:03 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hagud at orex.es --- Comment #63 from Hugo Agud --- I have tested the patch and it works, BUT I am still learning and I do not know how to create the signed patch, sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:45:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:45:38 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #3 from Jonathan Druart --- Is anybody interested in fixing this bad bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:49:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:49:03 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:50:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:50:59 +0000 Subject: [Koha-bugs] [Bug 17897] New: Koha:: SearchMappingManager - Simplify search mapping modifications Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 Bug ID: 17897 Summary: Koha::SearchMappingManager - Simplify search mapping modifications Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Currently there is a lot of DBIC-magic everywhere where search mappings (search_fields, search_marc_to_field, search_marc_map -tables) are CRUD:ed. Encapsulate this hard-to-read DBIC-magic into a Manager class which promotes code-reusability and thus, simpler test case writing. Includes tests for Bug 17885 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:52:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:52:11 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58825|0 |1 is obsolete| | --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 58940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58940&action=edit Bug 17885 - Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions When executing Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings() against populated search engine mappings tables, one gets this exception: DBD::mysql::st execute failed: Duplicate entry '388-73' for key 'PRIMARY' [for Statement \"INSERT INTO `search_marc_to_field` ( `facet`, `search_field_id`, `search_marc_map_id`, `sort`, `suggestible`) VALUES ( ?, ?, ?, ?, ? )\" with ParamValues: 0='', 1='73', 2='388', 3=undef, 4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '388-73' for key 'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line 38" This patch fixes this, by first deleting all entries, then adding the default ones. If a subroutine says reset_elasticsearch_mappings(), I expect it to reset the elasticsearch mappings without errors. When writing tests it is better to call that one subroutine reset_elasticsearch_mappings instead of the bunch of code in admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 Also this promotes code reuse. TEST PLAN: a. perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings' b. Run misc/devel/populate_db.pl on an already populated DB and you eventually face this problem. After this patch, step a. works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:52:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:52:36 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58940|0 |1 is obsolete| | --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 58941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58941&action=edit Bug 17885 - Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions When executing Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings() against populated search engine mappings tables, one gets this exception: DBD::mysql::st execute failed: Duplicate entry '388-73' for key 'PRIMARY' [for Statement \"INSERT INTO `search_marc_to_field` ( `facet`, `search_field_id`, `search_marc_map_id`, `sort`, `suggestible`) VALUES ( ?, ?, ?, ?, ? )\" with ParamValues: 0='', 1='73', 2='388', 3=undef, 4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '388-73' for key 'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line 38" This patch fixes this, by first deleting all entries, then adding the default ones. If a subroutine says reset_elasticsearch_mappings(), I expect it to reset the elasticsearch mappings without errors. When writing tests it is better to call that one subroutine reset_elasticsearch_mappings instead of the bunch of code in admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 Also this promotes code reuse. TEST PLAN: a. perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings' b. Run misc/devel/populate_db.pl on an already populated DB and you eventually face this problem. After this patch, step a. works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:53:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:53:03 +0000 Subject: [Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 58942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58942&action=edit Bug 17897 - Koha::SearchMappingManager - Simplify search mapping modifications Currently there is a lot of DBIC-magic everywhere where search mappings (search_fields, search_marc_to_field, search_marc_map -tables) are CRUD:ed. Encapsulate this hard-to-read DBIC-magic into a Manager class which promotes code-reusability and thus, simpler test case writing. Includes tests for Buug 17885 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:54:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:54:08 +0000 Subject: [Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Olli-Antti Kivilahti --- Test plan is to run the elasticsearch-dependent tests in t/db_dependent/Koha* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:54:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:54:22 +0000 Subject: [Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:54:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:54:22 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:57:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:57:22 +0000 Subject: [Koha-bugs] [Bug 6710] lists of lists in Alpha order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6710 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 11:59:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 10:59:26 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58939|0 |1 is obsolete| | --- Comment #122 from Marcel de Rooy --- Created attachment 58943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58943&action=edit Bug 17196: Remove occurrence of marcxml in columns.def Also remove a wrong ref to the marc column Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:07:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:07:14 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:07:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:07:17 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58915|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 58944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58944&action=edit Bug 17725: Do not copy subfield's content when cloning To replicate: - Open an existing record in your catalog - Create another field or subfield of a field/subfield already used using the icon to repeat it - Verify that the content is copied over - Verify this happens for input (one line) and textare (multiple lines) I can't make this happen for when creating a new record, but more consistently on editing existing records. This is rather annoying when cataloguing in Koha, as the cataloguer has to empty the field first and that adds an extra step for each repeated field. Test plan: Confirm than the content is not copied when you clone a field or a subfield. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:07:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:07:23 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58916|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 58945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58945&action=edit Bug 17725: Same for textarea when cloning a field Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:15:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:15:31 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #123 from Marcel de Rooy --- Created attachment 58946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58946&action=edit Bug 17196: [QA Follow-up] Adjust some text on marcxml No code changes here, just text. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:15:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:15:36 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #124 from Marcel de Rooy --- Created attachment 58947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58947&action=edit Bug 17196: [QA Follow-up] Additional fix on acqui/basketgroup acqui/basketgroup calls GetOrders and expects marcxml in the results. Fixing it by an additional call of GetXmlBiblio. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:17:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:17:59 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #125 from Marcel de Rooy --- Last comments: > Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108. Failed QA several weeks ago. The author did not respond until now. [OK] t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t [OK] t/db_dependent/Holds/HoldFulfillmentPolicy.t [OK] t/db_dependent/Holds/HoldItemtypeLimit.t [OK} t/db_dependent/HoldsQueue.t [OK] t/db_dependent/UsageStats.t [OK] t/db_dependent/Members/GetAllIssues.t [OK] t/db_dependent/Items.t [OK] t/ImportBatch.t [OK] t/db_dependent/OAI/Server.t [OK] t/db_dependent/Record/Record.t [OK] t/db_dependent/Record.t [OK] t/db_dependent/Search.t [OK] t/db_dependent/Acquisition/GetOrdersByBiblionumber.t [OK] t/db_dependent/Acquisition/TransferOrder.t misc/migration_tools/koha-svc.pl: Did not verify it this still works. koha-svc.pl http://koha-dev:8080/cgi-bin/koha/svc svc-user svc-password $biblionumber [bib-42.xml] Did not check REST API. Well finally, we know about Reports. Should we still warn somewhere about that ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:19:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:19:41 +0000 Subject: [Koha-bugs] [Bug 17897] Koha:: SearchMappingManager - Simplify search mapping modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17855 |17885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 [Bug 17885] Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:19:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:19:41 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17897 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:19:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:19:41 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:25:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:25:16 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #24 from Kyle M Hall --- Pushed to master for 17.05, thanks Patricia! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:26:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:26:25 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:27:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:27:26 +0000 Subject: [Koha-bugs] [Bug 17870] Call to include file incorrectly moved into the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17870 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:28:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:28:06 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #126 from Josef Moravec --- (In reply to Marcel de Rooy from comment #125) > Last comments: > > > Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108. > Failed QA several weeks ago. The author did not respond until now. > Ere Maijala is primerly working on VuFind development, so probably we could try to contact them by e-mail directly to ask if he is plannig to work a bit on this OAI enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:29:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:29:19 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58536|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 58948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58948&action=edit Bug 17766 - Patron notification does not work with multi item holds This patch fixes notification when same biblio has multiple reserves with same borrower, introduced in Bug 14695. C4::Reserves::ModReserveAffect uses internal method _koha_notify_reserve but sends itemnumber and biblionumber instead of record_id. To test: Prerequisites: - One biblio with two items attached - A patron with hold_filled notification activated - A letter for HOLD with <> in it 1) Place two reservations on same biblio 2) checkin item x on pickup branch, observe patron message generated 3) checkin item y on pickup branch, observe patron message generated 4) note that reserve_id is the same on both messages, which is wrong 5) apply this patch and repeat 1-3 6) now observe notifications have correct (different) reserve_id Signed-off-by: Hugo Agud Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:31:12 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Benjamin! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:32:38 +0000 Subject: [Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults less greedy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:33:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:33:59 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Magnus, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:34:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:34:59 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:36:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:36:52 +0000 Subject: [Koha-bugs] [Bug 17447] Remove unused vars from batchRebuildItemsTables.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:39:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:39:09 +0000 Subject: [Koha-bugs] [Bug 17740] Add the Koha::Patron->holds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:40:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:40:16 +0000 Subject: [Koha-bugs] [Bug 17741] Use Koha::Patron->holds in Koha::Patron->delete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17741 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:41:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:41:04 +0000 Subject: [Koha-bugs] [Bug 17800] Add admin sidebar menu to marc-subfields-structure.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17800 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:41:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:41:37 +0000 Subject: [Koha-bugs] [Bug 15108] OAI-PMH provider improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17778 --- Comment #75 from Josef Moravec --- Needs rebase due to bug 17778 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:41:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:41:37 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 [Bug 15108] OAI-PMH provider improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:43:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:43:10 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #25 from Kyle M Hall --- Apologies, thanks Patricio! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:44:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:44:07 +0000 Subject: [Koha-bugs] [Bug 17859] Move JavaScript to the footer on about and auth pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17859 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:45:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:45:32 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:46:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:46:55 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #17 from Kyle M Hall --- Pushed to master for 17.05, thanks Meenakshi! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:47:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:47:05 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #26 from Patricio Marrone --- (In reply to Jonathan Druart from comment #23) > Great job Patricio! > Do not forget to add a test plan, for you next patches :) Thanks Jonathan :) . I'm glad to help. I'll try to put together the steps needed to test the changes and won't forget to add them next time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:48:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:48:01 +0000 Subject: [Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:49:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:49:06 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #27 from Patricio Marrone --- (In reply to Kyle M Hall from comment #24) > Pushed to master for 17.05, thanks Patricia! (In reply to Kyle M Hall from comment #25) > Apologies, thanks Patricio! Thanks Kyle! No problem :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:50:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:50:58 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58837|0 |1 is obsolete| | Attachment #58838|0 |1 is obsolete| | Attachment #58839|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 58949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58949&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:51:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:51:06 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #34 from Kyle M Hall --- Created attachment 58950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58950&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:51:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:51:10 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #35 from Kyle M Hall --- Created attachment 58951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58951&action=edit Bug 14570 - Followup Fix small errors in update child script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:56:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:56:03 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58949|0 |1 is obsolete| | Attachment #58950|0 |1 is obsolete| | Attachment #58951|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 58952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58952&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:56:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:56:10 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #37 from Kyle M Hall --- Created attachment 58953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58953&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 12:56:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 11:56:13 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #38 from Kyle M Hall --- Created attachment 58954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58954&action=edit Bug 14570 - Followup Fix small errors in update child script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:00:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:00:57 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #127 from Marcel de Rooy --- (In reply to Josef Moravec from comment #126) > (In reply to Marcel de Rooy from comment #125) > > Last comments: > > > > > Changes in Koha/OAI/Server/ListRecords.pm is planned on bug 15108. > > Failed QA several weeks ago. The author did not respond until now. > > > > Ere Maijala is primerly working on VuFind development, so probably we could > try to contact them by e-mail directly to ask if he is plannig to work a bit > on this OAI enhancement. Josef, If you know him, could you please ask him for rebase and feedback. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:04:12 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:24:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:24:19 +0000 Subject: [Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Kyle M Hall --- Pushed to master for 17.11, thanks Olli, Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:28:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:28:45 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:29:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:29:32 +0000 Subject: [Koha-bugs] [Bug 17466] Show number of outstanding issues when checking in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:35:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:35:09 +0000 Subject: [Koha-bugs] [Bug 17486] Remove 'Mozilla Persona' as an authentication method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:36:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:36:29 +0000 Subject: [Koha-bugs] [Bug 17629] Koha::Biblio - Remove ModBiblioframework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17629 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 13:37:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 12:37:07 +0000 Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs broken for Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 14:10:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 13:10:31 +0000 Subject: [Koha-bugs] [Bug 4031] Expand EnableOpacSearchHistory options for controlling search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4031 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Magnus Enger --- What is the default behaviour today? Looking at the search_history table of one of my sites it looks like logging is only done for logged in users? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 14:12:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 13:12:23 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 14:18:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 13:18:31 +0000 Subject: [Koha-bugs] [Bug 4461] Context-sensitive report a problem screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- I think this looks good, but there are some issues that need to be looked at: I think that if there is no email address for the logged-in user's library the page should not offer to email the librarian. In my test if I submit a report to the librarian and there is no email address for my home library, the entry saved in message_queue has an empty 'to_address' field. There are HTML validation errors triggered by duplicate id attributes on form fields. The form fields on the two different tabs should not have the same ids (note that input name and id attributes do not have to match); Also, in the OPAC (and soon to be the case in the staff client), page-specific JavaScript goes into a special BLOCK which is processed in the footer include. So instead of this, at the end of opac-reportaproblem.tt: [% BLOCK jsinclude %][% END %] It should be: [% BLOCK jsinclude %] [% END %] -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 14:18:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 13:18:42 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es Status|Needs Signoff |Signed Off --- Comment #25 from Hugo Agud --- I have tested and it works fine! I have not activated the cronjobs because we're on development environment. I have not create the signed patch, because I stll doesn'r know how to do it, soon I will do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 13 14:38:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 13 Jan 2017 13:38:53 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Owen Leonard --- Can I add one small request before this goes to QA? In the form, instead of: Your country: It should be a real
  2. > +
  3. By default all item types and all patrons are notified of check ins and check outs. To change this, click on the item/patron category combination that you would like to stop notices for.
  4. We have patron categories and item types in Koha, so maybe it would read a little better as: item type/patron category ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/members/boraccount.tt @@ +10,4 @@ > >
      >
    • Fines will be charged based on your Circulation & Fines Rules
    • > +
    • Hold fees will be charged based on the rules you set in the Patron Categories & Categories administration area
    • I think the original read a little oddly as we don't have a section in administration that reads like the help suggests. My suggestion is to write something like: Hold fees will be charged based on the rules you set for the patron category in administration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:00:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:00:52 +0000 Subject: [Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:04:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:04:36 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOUserHTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Agnes, maybe sent them to the IRC chat - there is almost always someone around to help out and answer questions. For a development setup, you can point them to https://github.com/digibib/kohadevbox. For other information on the development process the wiki is a helpful resource, especially the pages linked to the Developer handbook: https://wiki.koha-community.org/wiki/Developer_handbook. Good luck! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:15:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:15:50 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #21 from Claudio --- Hi Katrin! I attached a PDF with a test about this bug (item type descriptions). It is running in a production environment of mine and works fine. If you agree I can sign this bug off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:17:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:17:27 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #22 from Claudio --- Created attachment 59123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59123&action=edit Item type description in OPAC search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:19:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:19:45 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #23 from Katrin Fischer --- Hi Claudio, first we need a patch :) Would you be able to provide one? I have added the 'Academy' keyword, as there are some students working on bugs at Catalyst IT in NZ this week, but not sure if they will get to take a look at it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:22:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:22:47 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:22:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:22:49 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 --- Comment #1 from Zoe Schoeler --- Created attachment 59124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59124&action=edit Bug 17784 Ability to see funds with an amount of 0.00 when doing a new order TEST PLAN 1. Go to the acquisition module and create budget with fund of 0.00 and another fund of 1.00. 2. On acquisitions use a vendor to create a new basket and add an order to that basket. 3.Find a record and order it. 4. Under accounting details the fund with 0 in it won't be visable. 5. Apply patch and refresh, then it should be. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:29:25 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59033|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer --- Created attachment 59125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59125&action=edit Bug 17469: Add missing sample notices fr-CA test Add fr-CA installer to xt/sample_letter.t To test: - Verify xt/sample_letter.t test checks fr-CA now and fails for just fr-CA. Signed-off-by: Mark Tompsett Signed-off-by: Caitlin Goodger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:29:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:29:30 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #22 from Katrin Fischer --- Created attachment 59126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59126&action=edit [SIGNED OFF] Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP TEST PLAN --------- 1) Apply the first patch 2) prove xt/sample_notices.t -- it should fail for fr-CA. 3) Apply the second patch 4) prove xt/sample_notices.t -- it should pass. 5) run all tests (prove t; prove xt) -- they should generally pass 6) run koha qa test tools NOTE: Split test patch from fix patch, so could prove problem exists easily. Signed-off-by: Mark Tompsett Signed-off-by: Caitlin Goodger Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:29:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:29:34 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #23 from Katrin Fischer --- Created attachment 59127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59127&action=edit [SIGNED OFF] Bug 17469: Follow-up adding hold print notice Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:30:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:30:39 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:30:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:30:36 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:30:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:30:42 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:32:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:32:17 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #24 from Katrin Fischer --- Signed off on the follow-ups - thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:38:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:38:05 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:38:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:38:09 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59116|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 59128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59128&action=edit [SIGNED OFF] Bug 17771: Add link to bibliographic record on spent/ordered lists in acquisitions ==TEST PLAN== 1) Open Acquisitions and click on the ordered link under the fund 2) There will be no link on the title 3) Go back and click on thespent link 4) There will be no link on the title 5) Apply patch 6) Go to Acquisitions and click on ordered 7) There will now be a link that takes the user to the book catelog page 8) Go back and click on sent 9) There will be a link that takes the user to the book catelog Signed-off-by: Katrin Fischer Works like a charm! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:38:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:38:19 +0000 Subject: [Koha-bugs] [Bug 17928] Updating sounds for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17928 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59120|0 |1 is obsolete| | --- Comment #2 from Emma --- Created attachment 59129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59129&action=edit Bug 17928 Updating sounds for circulation Test Plan: 1) Enable AudioAlerts in System Preferences 2) Edit Audio alerts section under Koha Administration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:39:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:39:00 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 --- Comment #4 from Katrin Fischer --- Thx for fixing this! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:40:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:40:26 +0000 Subject: [Koha-bugs] [Bug 9388] Accessibility - No feedback when returning book. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9388 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 01:55:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 00:55:34 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 --- Comment #9 from Agnes Rivers-Moore --- Hi Katrin Version 3.22.07. Yes, using Plack I believe. Galen could tell you more- we're hosted & supported by Equinox. Which part should I submit a new bug for - the very slow or failed updates to notice templates? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 02:09:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 01:09:03 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 02:09:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 01:09:05 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 --- Comment #1 from Zoe Schoeler --- Created attachment 59130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59130&action=edit Bug 17838 Availability limit broken until an item has been checked out. TEST PLAN 1. Make sure you have no items checked out. 2. Run sudo koha-rebuild-zebra -f -v kohadev. 3. Go to search the catalog and search. 4. Check items availability and then click on limit to currently available items. 5. This should return no results. 6. Apply patch and reload. 7. Results should show. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 02:32:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 01:32:28 +0000 Subject: [Koha-bugs] [Bug 16108] XSLT and CSS - additional ids and classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16108 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karenliang.student at wegc.sch | |ool.nz --- Comment #3 from Karen --- Hello, I cannot find any problems either. Can you please provide specific examples? Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 02:40:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 01:40:45 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 --- Comment #10 from Katrin Fischer --- Hi Agnes, we have seen problems with changes not taking effect for a while on 3.22.8 - I am not sure yet if it is to be expected or a problem with how Plack/caching works. As 3.22 is very old now, it would be good to confirm the behaviour in newer versions first. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 02:56:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 01:56:22 +0000 Subject: [Koha-bugs] [Bug 13498] ISSUESLIP, ISSUEQSLIP use 'email' template for print. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 --- Comment #11 from Agnes Rivers-Moore --- Agreed, thanks Karin. I have reported this to Equinox for comment also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 02:59:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 01:59:09 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 02:59:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 01:59:13 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59117|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 59131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59131&action=edit [SIGNED OFF] Bug 17823: Add label for MARC 583 - Action note test plan Edit a record Edit field 583a to add an action note Save the record and confirm that the note does not show up in staff client or opac Apply patch and refresh page Action note should now show up in staff client and opac Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:01:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:01:45 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 --- Comment #3 from Katrin Fischer --- This is definitely a nice improvement :) There is one issue left - if 583 is repeated, the label will appear multiple times. I suggest dealing with this on a new bug report building on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:01:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:01:58 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- Hi, I'm not sure how to reproduce this because the 773a and 773t fields show for me in both staff client and OPAC. Can you please provide a test plan on how to reproduce? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:10:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:10:45 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59094|0 |1 is obsolete| | --- Comment #2 from Zoe Schoeler --- Created attachment 59132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59132&action=edit Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off Signed-off-by: Zoe Schoeler -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:10:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:10:41 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:13:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:13:34 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 --- Comment #2 from Katrin Fischer --- To test: - Add a record with 773$a (no $t!) and a record with 773$a and $t - View it on the detail pages and result lists in staff and OPAC - On the detail pages, 773 should show in both cases - On the result lists, 773 doesn't appear to show (another enh for later maybe?) - Put the records on a list - On the list result list Source: only shows for record with $t So $a is usually the author, but if there is no author, it will have the title, and $t is empty (cataloguing rules... can't really explain better). Just saying it's totally valid that there is only $a and no $t, so we should account for this case :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:14:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:14:33 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com --- Comment #8 from Gracie --- This patch will never apply without a rewrite because Koha/Borrower.pm has been moved to Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:14:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:14:41 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:14:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:14:44 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59130|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 59133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59133&action=edit [SIGNED OFF] Bug 17838 Availability limit broken until an item has been checked out. TEST PLAN 1. Make sure you have no items checked out. 2. Run sudo koha-rebuild-zebra -f -v kohadev. 3. Go to search the catalog and search. 4. Check items availability and then click on limit to currently available items. 5. This should return no results. 6. Apply patch and reload. 7. Results should show. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:20:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:20:35 +0000 Subject: [Koha-bugs] [Bug 17929] New: You can't edit indicators in the cataloging screen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Bug ID: 17929 Summary: You can't edit indicators in the cataloging screen Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: caitlingoodger.student at wegc.school.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl As the bug suggest you can no longer edit indicators in the cataloging screen. This used to work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:23:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:23:21 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I can confirm this. Entering indicators in master is currently not possible. The cursor appears, but you are not able to enter anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:23:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:23:40 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 --- Comment #2 from Karen --- Created attachment 59134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59134&action=edit Bug 15179 -Field 084 doesnt show on bibliographic record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:25:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:25:03 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:25:06 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59134|0 |1 is obsolete| | --- Comment #3 from Karen --- Created attachment 59135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59135&action=edit Bug 15179 -Field 084 doesnt show on bibliographic record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:29:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:29:42 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 --- Comment #2 from Katrin Fischer --- Hi Caitlin, this is good, but can you please take a look at the corresponding file for the OPAC (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt)? It needs the same fix and I could then test and sign-off on both fixes together. Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:30:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:30:51 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karenliang.student at wegc.sch | |ool.nz --- Comment #4 from Karen --- Test Plan Make sure the editor is checked for 084 in MARC frameworks Edit field 084 Save the record and confirm that the note does not show up in staff client or opac Apply patch and refresh page Field 084 should now show up in staff client and opac -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:41:06 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer --- I am not sure why, but Jonathan's suggested change doesn't seem to do the trick: For the subscription without history end date, it still shows the current date in the OPAC for me. For a subscription with an end date in the past, the display is correct. For a subscription end date in the future, the note shows as well. I have restarted Plack to make sure that's not the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:54:53 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 03:54:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 02:54:56 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58957|0 |1 is obsolete| | --- Comment #2 from Zoe Schoeler --- Created attachment 59136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59136&action=edit Bug 17899 - Show only mine does not work in newordersuggestion.pl Bug 12775 added a link "Show only mine" in newordersuggestion.pl. This does not work, no results. Also corrects the fact that click must not do default action by adding e.preventDefault(). Test plan : - You must have suggestions you have accepted - Create a new order from suggestion : /cgi-bin/koha/acqui/newordersuggestion.pl - Click on Show only mine => Without patch the table is empty showing "No matching records found" => With patch you see only suggestions you have accpeted Signed-off-by: Zoe Schoeler -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:08:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:08:25 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #94 from M. Tompsett --- (In reply to Alex Buckley from comment #91) > (in reply to M.Tompsett in comment 90) > And that regex will accept special characters as part of the cardnumber, > which is obviously not what we want. "obviously not what we want" -- sounds a little dictatorial in how people generate their data. That's not what Koha is about. ;) Remember the fuss I had because I couldn't use my previous Koha password due to pattern matching? You'll likely get the same fuss from other libraries about card numbers and descriptions. If Katrin in comment #93 recommends removing the pattern matching to keep it simple, it probably is best. We have been rather lax in our data validation previously. It doesn't make sense to start. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:16:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:16:52 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:16:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:16:55 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 --- Comment #3 from Gracie --- Created attachment 59137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59137&action=edit Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:27:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:27:34 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:27:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:27:36 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #1 from Caitlin Goodger --- Created attachment 59138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59138&action=edit Bug 17886 Don't show option to add to existing list if there are no lists Test Plan 1: Make sure that you don't have any lists and then add a Biblical Record to a list 2: You should see that you can add it to an existing list even though you don't have one. 3: Apply patch 4: Add a Biblical record and if you don't have a list then you shouldn't see the add to existing list. 5: Create a list and then add a Bibical Record and you should see the add to existing list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:29:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:29:38 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I really like the idea! Looking at this from the view of translators, I'd like to make a suggestion: +

      Subscription Details

      +

      This vender has: [% subscriptioncount %] + [% IF subscriptioncount == 1 %] subscription [% ELSE %] subscriptions [% END %] +

      + The h2 is cool, but capitalization should be: Subscription details The paragraph will be turned into 2 strings by the translation tools: - This vendor has - subscription subscriptions (with some additional markup %s in between) Strings show up out of context for translators and in alphabetical order - so that makes it really hard to 'get it right' - depending on the language it's also often hard to predict, what the right sequence of words/grammar should be like. My suggestion would be to make it: Number of subscriptions: [% subscriptioncount %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:38:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:38:33 +0000 Subject: [Koha-bugs] [Bug 17930] New: Errors in the manual in self-checkout section Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17930 Bug ID: 17930 Summary: Errors in the manual in self-checkout section Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: nengard at gmail.com Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org There are two errors that have been spotted in the manual in Chapter 5, Section 12 (Self-checkout) 1) "There is no link to the Self Checkout module, but a simple addition to the IntranetUserJS system preference can add one." - This should say 'OPACUserJS', not 'IntranetUserJS'. 2) The JS script that is provided does not work with the #submit bit, but works without it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:43:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:43:02 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #25 from Chris Cormack --- Well done Caitlin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:44:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:44:28 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |caitlingoodger.student at wegc | |.school.nz CC| |caitlingoodger.student at wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:50:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:50:28 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crazy.mental.onion at gmail.co | |m Assignee|gmcharlt at gmail.com |crazy.mental.onion at gmail.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:50:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:50:28 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com Assignee|koha-bugs at lists.koha-commun |grace.mcky at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:51:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:51:03 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caitlingoodger.student at wegc | |.school.nz Assignee|crazy.mental.onion at gmail.co |caitlingoodger.student at wegc |m |.school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:50:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:50:48 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crazy.mental.onion at gmail.co | |m Assignee|gmcharlt at gmail.com |crazy.mental.onion at gmail.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:51:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:51:05 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karenliang.student at wegc.sch | |ool.nz Assignee|m.de.rooy at rijksmuseum.nl |karenliang.student at wegc.sch | |ool.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:51:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:51:19 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |karenliang.student at wegc.sch | |ool.nz CC| |karenliang.student at wegc.sch | |ool.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:51:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:51:21 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caitlingoodger.student at wegc | |.school.nz Assignee|oleonard at myacpl.org |caitlingoodger.student at wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:51:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:51:29 +0000 Subject: [Koha-bugs] [Bug 17885] Koha::SearchEngine::Elasticsearch-> reset_elasticsearch_mappings throws DBD::mysql Duplicate entry exceptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |crazy.mental.onion at gmail.co | |m CC| |crazy.mental.onion at gmail.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:51:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:51:59 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |caitlingoodger.student at wegc | |.school.nz CC| |caitlingoodger.student at wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:52:06 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Zoe Schoeler changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |crazy.mental.onion at gmail.co |ity.org |m CC| |crazy.mental.onion at gmail.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:52:17 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caitlingoodger.student at wegc | |.school.nz Assignee|gmcharlt at gmail.com |caitlingoodger.student at wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:56:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:56:09 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 04:56:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 03:56:11 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59137|0 |1 is obsolete| | --- Comment #5 from Gracie --- Created attachment 59139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59139&action=edit Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 05:27:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 04:27:33 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #95 from Alex Buckley --- (In reply to Owen Leonard in comment 92 and M.Tompsett in comment 94) Apologies if it sounded dictatorial that is certainly never my intent. I was thinking that special characters should not be permitted due to the security implications of the user being able to input code into these input fields. Regarding the server-side validation of entered cardnumbers in memberentry.pl if the user entered the form with a blank cardnumber field then the cardnumber is treated as null, as the below code shows: 298 # If the cardnumber is blank, treat it as null. 299 $newdata{'cardnumber'} = undef if $newdata{'cardnumber'} =~ /^\s*$/; Then if there is an error from the checkcardnumber function the error is handed to the @errors array, which I have already implemented in my bug. In the template memberentrygen.tt the html inputs value attribute has a '| html' in it (e.g. , as I understand it this stops any special characters entered into the input field from being executed as code. Therefore I will implement this in the cardnumber field and remove the html regex so that the same level of data validation in the staff interface and onboarding tool exists. I personally do not believe we have been lax in our data validation, for the following reason: All text input fields have had html regexs on them in the onboarding tool from the start, to prevent users from inputting special characters to fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 06:12:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 05:12:01 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #96 from Alex Buckley --- Created attachment 59140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59140&action=edit Bug 17855 - Removed the html regex from the cardnumber field in the 'Create patron administrator' page of the onboarding tool. Added '|html' into the the value attribute of the cardnumber input field to filter the inputted cardnumber. So now the same level of validation exists for validating the inputted cardnumber in the staff interface and the onboarding tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 06:12:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 05:12:42 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #97 from Alex Buckley --- Created attachment 59141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59141&action=edit Bug 17855 - Removed the unnecessary javascript cardnumber validation code from onboardingstep3.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 06:28:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 05:28:30 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 07:00:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 06:00:21 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #98 from M. Tompsett --- (In reply to Alex Buckley from comment #95) > Apologies if it sounded dictatorial that is certainly never my intent. I was > thinking that special characters should not be permitted due to the security > implications of the user being able to input code into these input fields. *sigh* No, you are forcing Romanized a-zA-Z. What about accented characters? > I personally do not believe we have been lax in our data validation, -- With respect to unusual characters like ?. Now you are enforcing a-zA-Z. I think we had some cross talk. I get wanting to clean inputs so you don't get the equivalent of SQL Injections and the like, but I don't get forcing a specific range that excludes diacritics. The description, which I hinted at in comment #94, found in onboarding step 4 may contain diacritics, may it not? And what about the {0,10} issue I raised in comment #88 also in onboarding step 4? And please, don't think my "it's in onboarding step 4" means it isn't elsewhere. Treat it as a class of problem, and look for it elsewhere too, because I haven't. Sorry, setting to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 07:06:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 06:06:16 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #10 from George Williams (NEKLS) --- This failed the test when I tried to sign off this evening. The timestamp didn't change on the second deletion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 07:06:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 06:06:39 +0000 Subject: [Koha-bugs] [Bug 17216] Add a new table to store authorized value categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:22:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:22:42 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59138|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 59142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59142&action=edit Bug 17886 Don't show option to add to existing list if there are no lists Test Plan 1: Make sure that you don't have any lists and then add a Biblical Record to a list 2: You should see that you can add it to an existing list even though you don't have one. 3: Apply patch 4: Add a Biblical record and if you don't have a list then you shouldn't see the add to existing list. 5: Create a list and then add a Bibical Record and you should see the add to existing list Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:23:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:23:03 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |claire_gravely at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:31:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:31:44 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Turns out you can type, you just can't see what you are typing. It is the indicator class in the css that is causing it. For some reason it now doesn't like 1em as a width, it is too small. (At least in firefox) It seems to work ok in chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:34:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:34:43 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:34:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:34:46 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59113|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 59143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59143&action=edit Bug 5784 - link to aq from budgets & funds 1. Go to /cgi-bin/koha/admin/aqbudgets.pl and notice that there is no link to the aq home, there are other aq links but not back to the home 2. Apply the patch 3. Reload the page and notice there is link Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:36:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:36:50 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 [Bug 17929] You can't edit indicators in the cataloging screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:36:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:36:50 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16239 --- Comment #3 from Chris Cormack --- It is caused by bug 16239 So I am not sure how to fix it, but it will need to be fixed before release or you can't catalogue with firefox Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 [Bug 16239] Upgrade Bootstrap in the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:41:14 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #34 from Marcel de Rooy --- (In reply to Josef Moravec from comment #33) > Signed-off-by: Josef Moravec Great! Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:42:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:42:09 +0000 Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined value at C4/ Search.pm line 806 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123 --- Comment #10 from Jonathan Druart --- Gabrielo, did you fully rebuild your zebra index using the koha-rebuild-zebra command? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:46:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:46:25 +0000 Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:46:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:46:28 +0000 Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59121|0 |1 is obsolete| | --- Comment #7 from Claire Gravely --- Created attachment 59144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59144&action=edit Bug 8266 - remove location from pulldown Found shelving location in html and removed To test - Go to the advanced search in the OPAC - Click on 'more options' (this changes the pull downs) - Check the pull downs with search options, there is now "shelving location" - Apply the patch - Refresh the page and notice the option is gone Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 08:51:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 07:51:05 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #99 from Jonathan Druart --- (In reply to Alex Buckley from comment #95) > In the template memberentrygen.tt the html inputs value attribute has a '| > html' in it (e.g. , as I > understand it this stops any special characters entered into the input field > from being executed as code. Nope it's a protection to XSS attacks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 09:09:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 08:09:24 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #100 from Jonathan Druart --- I do not really understand why this is Failed QA, Marc could you detail? The check on the cardnumber has been removed. There was far too much discussion about the cardnumber validation check, I'd suggest now to have one *at all* and deal with it on another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 09:12:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 08:12:05 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Lowering the severity a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 09:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 08:17:20 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |oleonard at myacpl.org --- Comment #5 from Jonathan Druart --- Weird indeed. We could simply remove the width for .indicator, that does the trick (i.e. we see what we type). Ccing Owen and Josef to get a better solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 09:36:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 08:36:09 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 --- Comment #6 from Jonathan Druart --- Actually it's histenddate that is displayed, not enddate. Katrin, what's the expected behaviour? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 09:39:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 08:39:52 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:08:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:08:42 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:13:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:13:49 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #37 from Josef Moravec --- This patch need rebase and adjusment due to bug 17557. And minor adjustment due to bug 16239, but I can attach followup after... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:14:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:14:16 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:14:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:14:19 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59124|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 59145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59145&action=edit Bug 17784 Ability to see funds with an amount of 0.00 when doing a new order TEST PLAN 1. Go to the acquisition module and create budget with fund of 0.00 and another fund of 1.00. 2. On acquisitions use a vendor to create a new basket and add an order to that basket. 3.Find a record and order it. 4. Under accounting details the fund with 0 in it won't be visable. 5. Apply patch and refresh, then it should be. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:40:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:40:41 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:41:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:41:25 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #6 from Josef Moravec --- It is caused by different box-sizing in bootstrap 3 (border-box) We have to options: 1) remove width: 1em styling for indicators - the width calculation will fallback to size parameter of input tag 2) or change the box-sizing to content-box for indicators a have no strong opinion on this, probably would go with 2) as it looks more similar to pre-16239 ages ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:48:53 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:48:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:48:58 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53384|0 |1 is obsolete| | Attachment #53385|0 |1 is obsolete| | Attachment #53386|0 |1 is obsolete| | Attachment #53387|0 |1 is obsolete| | Attachment #55491|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 59146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59146&action=edit Bug 16733: Add adjust_paths_dev_install to koha-functions.sh This new function checks koha-conf.xml for a given instance and if it contains a dev_install line, it adjusts PERL5LIB and KOHA_HOME accordingly. Otherwise it does not touch the values of these variables as normally read from /etc/default/koha-common. The function will be used in various debian scripts to allow for more flexibility with dev installs. And at the same time aiming to make better use of PERL5LIB and KOHA_HOME. Test plan: [1] Add /not/there to your koha-conf.xml. [2] Run on the command line: PERL5LIB=test source [path-to-your-instance]/debian/scripts/koha-functions.sh echo $PERL5LIB adjust_paths_dev_install [name-of-your-instance] echo $PERL5LIB The last echo should be: /not/there [3] Remove the line and repeat step 2. The last echo should be: test Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:49:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:49:03 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #22 from Jonathan Druart --- Created attachment 59147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59147&action=edit Bug 16733: Adjust koha-indexer [1] Add a call to the new adjust_paths_dev_install [2] Differentiate location of rebuild_zebra.pl NOTE: The scripts assume koha-functions.sh to be in /usr/share/koha/bin. Finding a better location for this shell library may be hard. Test plan: Run koha-indexer for a regular package install or a dev install. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:49:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:49:08 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #23 from Jonathan Druart --- Created attachment 59148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59148&action=edit Bug 16733: Adjust koha-rebuild-zebra [1] Add a call to the new adjust_paths_dev_install [2] Differentiate location of rebuild_zebra.pl [3] Replace a hardcoded path by $PERL5LIB Test plan: Adjust a biblio record in package or dev install. Run koha-rebuild-zebra -b -z for same instance. Verify that the change has been indexed. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:49:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:49:13 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #24 from Jonathan Druart --- Created attachment 59149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59149&action=edit Bug 16733: Adjust other debian scripts using PERL5LIB This patch makes the following changes: koha-foreach, koha-upgrade-schema (shell scripts): [1] Read default file [2] Include helper functions [3] Add call to adjust_paths_dev_install [4] Replace hardcoded path by $PERL5LIB koha-shell (perl script): [1] Remove hardcoded lib path [2] Add a sub that reads PERL5LIB from default or koha-conf, just as the shell scripts do. koha-plack (shell script), plack.psgi: [1] Add call to adjust_paths_dev_install [2] Remove hardcoded lib path [3] Add installer path to PERL5LIB, remove it from plack.pgsi koha-sitemap (shell script): [1] Add call to adjust_paths_dev_install [2] Remove hardcoded lib path [3] Add installer path to PERL5LIB [4] Adjust path for call to sitemap cron job koha-start-sip (shell script): [1] Read default file [2] Include helper functions [3] Add call to adjust_paths_dev_install [4] Adjust path to C4/SIP koha-stop-sip (shell script): [1] Remove KOHA_CONF and PERL5LIB (not needed to stop the daemon) [2] Same for paths in daemon client options NOTE: Script debian/scripts/koha-upgrade-to-3.4 has been left out intentionally. Test plan: [1] Regular install: Run koha-foreach echo Hi Run koha-upgrade-schema yourinstance Run koha-shell yourinstance If you have plack, run koha-plack --start|--stop yourinstance Run koha-sitemap --generate yourinstance Run koha-start-sip yourinstance Run koha-stop-sip yourinstance [2] Dev install [yourinstance] with in koha-conf.xml: Run koha-upgrade-schema yourinstance Run koha-shell yourinstance If you have plack: koha-plack --start|--stop yourinstance Run koha-sitemap --generate yourinstance Run koha-start-sip yourinstance Run koha-stop-sip yourinstance [3] Git grep on koha/lib You should no longer see occurrences in debian/scripts except: koha-translate: see report 16749 koha-upgrade-to-3.4: left out intentionally [4] Git grep on koha/bin You should only see hits for lines with koha-functions in the debian scripts except: koha-upgrade-to-3.4: left out intentionally Signed-off-by: Marcel de Rooy Most scripts tested on Wheezy (although it would not matter much). Plack script tested on Jessie. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 10:49:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 09:49:18 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #25 from Jonathan Druart --- Created attachment 59150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59150&action=edit Bug 16733: [Follow-up] Add $home to api path too In the meantime api was enabled in plack.psgi and needs a little tweak too for a dev install. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:32:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:32:23 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 --- Comment #1 from Julian Maurice --- Created attachment 59151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59151&action=edit Bug 17922: Use correct number of digits when replacing date placeholders This patch also fixes a typo ("<<" should be "<>") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:37:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:37:35 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice --- Test plan: 1. In your MARC framework, set a default value of "<><><
      >" for a biblio subfield and an item subfield. 2. Create a new biblio record then check that the value of subfield is 20170118 and not 2017118 (value can change obviously) 3. Create a new item record then check that the default value is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:40:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:40:18 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #3 from Julian Maurice --- Increasing severity as this can cause software errors for fixed length fields: Unsupported UNIMARC character encoding [05] for XML output for UNIMARC; 100$a -> 2017118d u||y0frey5050 ba at /usr/share/perl5/MARC/File/XML.pm line 568. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:43:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:43:29 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:43:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:43:32 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59054|0 |1 is obsolete| | --- Comment #3 from Claire Gravely --- Created attachment 59152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59152&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:45:07 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 --- Comment #7 from Katrin Fischer --- You are right, I was not clear in my description, we are always talking about the history end date here. If it's empty, it should not display the subscription as expired - that still happened to my surprised when I applied the patch. I was wondering if we should also check for a subscription history end date in the future, but that seems outside of scope here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:53:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:53:32 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #24 from Claudio --- Line 614 in /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: ($error, $results_hashref, $facets) = $searcher->search_compat($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$itemtypes,$query_type,$scan,1); should be replaced by this: ($error, $results_hashref, $facets) = $searcher->search_compat($query,$simple_query,\@sort_by,\@servers,$results_per_page,$offset,$expanded_facet,undef,$itemtypes_nocategory,$query_type,$scan,1); ====== Tested in 16.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:59:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:59:13 +0000 Subject: [Koha-bugs] [Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58560|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 59153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59153&action=edit Bug 17824: Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed This subroutine is no longer in used and can be removed. Test plan: git grep GetBorrowersWhoHaveNeverBorrowed must not return any results NOTE: grep -i getborrowerswhohave `find . -type f` works well enough to find the cleanborrowers.pl too. Signed-off-by: Mark Tompsett Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:59:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:59:22 +0000 Subject: [Koha-bugs] [Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 11:59:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 10:59:36 +0000 Subject: [Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 12:14:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 11:14:21 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #26 from Marcel de Rooy --- Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 12:47:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 11:47:34 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 --- Comment #22 from Kyle M Hall --- Followup pushed to master! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 12:48:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 11:48:41 +0000 Subject: [Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 12:49:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 11:49:55 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|karenliang.student at wegc.sch |m.de.rooy at rijksmuseum.nl |ool.nz | --- Comment #5 from Marcel de Rooy --- Karen: do not change the assignee please. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 12:57:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 11:57:16 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #73 from Josef Moravec --- This will need to adapt for recently pushed bug 16239, See https://wiki.koha-community.org/wiki/Interface_patterns especially buttons and modals section. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:00:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:00:27 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:00:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:00:32 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #8 from Julian Maurice --- Created attachment 59154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59154&action=edit Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:00:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:00:36 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #9 from Julian Maurice --- Created attachment 59155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59155&action=edit Bug 17588: get_account_lines->get_balance has been replace with account->balance On previous bugs Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:00:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:00:39 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #10 from Julian Maurice --- Created attachment 59156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59156&action=edit Bug 17588: ->get_issues has been replaced with ->checkouts Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:00:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:00:57 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:12:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:12:05 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > Patch looks ok but I do not recreate: > sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev > Error: The instance doesn't exist: prove t/db_dependent/Sitemapper.t > > With -c: > sudo koha-shell -c "prove t/db_dependent/Sitemapper.t" kohadev > > The tests pass, even without the patch. Depends on your permissions, but the patch is definitely an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:12:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:12:23 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59067|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 59157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59157&action=edit Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions The directory it attempts to create an xml file may not be writable for the user running the test. By changing the directory from the current directory to a temporary one, the test runs. After all 'chmod 777 t/db_dependent' is a bad idea. TEST PLAN --------- 1) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- fails 2) apply patch 3) sudo koha-shell "prove t/db_dependent/Sitemapper.t" kohadev -- succeeds 4) run koha qa test tools Tested without qa tools Signed-off-by: Claire Gravely Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:12:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:12:42 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:13:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:13:12 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 --- Comment #6 from Marcel de Rooy --- Mark, Here are a few other potential candidates: t/db_dependent/SuggestionEngine_ExplodedTerms.t: my $location = File::Spec->rel2abs(dirname(__FILE__)); t/db_dependent/www/auth_values_input_www.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/www/batch.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/www/search_utf8.t:my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); t/db_dependent/zebra_config.pl:my $source = File::Spec->rel2abs('.'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:21:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:21:38 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #102 from Jonathan Druart --- Update your QA tests repo! commit 89a86cceb79b412a26b68cd8c2e4907060af2f6d Author: Jonathan Druart Date: Wed Jan 18 13:16:57 2017 +0100 Add checkts for Bootstrap v3 (bug 16239) (arf typo) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:39:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:39:18 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #6 from Marcel de Rooy --- >From Zeno on the dev ml: === in fact we partialy trust the indicators from the authority record tag 110 'A' + tag 111 'B' = tag 100 'CC' an tag 100 'CC' is connect with biblios 100s, 700s, 600s, etc. I hope that before to definitily save I can fix indicators in auth. I think is mandatory to have 'change-by-hand' in merge. After I save; now modifications start on biblios records and tags. What we want ? Knowing that auth tag = 100, I know that I can copy 1? auth indicator into 1? bib tag indicator. And for the second bib tag indicator ? Two option: -1) default of bib tag framewok [your solution] -2) mantain what is still present [I prefer this option]. I think that the selection between the two option could by done by a system preference. === -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:46:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:46:12 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #7 from Marcel de Rooy --- (In reply to Zeno Tajoli from comment #6) This makes me think about a solution with a table like below. You check the table with the new biblio field number. If there is no entry in the table, pick a default behavior (could be the current behavior: oldbiblio). Table Where_should_i_get_the_indicators_when_changing_authtype :) column field column marcflavour column ind1 column ind2 ind1 and ind2 should have the options: auth|oldbiblio|bibframework Here auth should mean: trust the new authority here, oldbiblio means pick from old biblio field and bibframework means use the default indicator for this biblio field. (As long as the new development is not ready, hardcode a simple hash somewhere.) Note that number of auth fields is limited. Could be extendend by users for custom purposes. Would that address all possibilities? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:47:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:47:49 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- I think we should fall back to /tmp, and take care of creating a per-instance directory in /var/somewhere for each instance. I think the patchset is incomplete! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:48:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:48:33 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 --- Comment #13 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #12) > I think we should fall back to /tmp, and take care of creating a > per-instance directory in /var/somewhere for each instance. > > I think the patchset is incomplete! I agree, but did not want to block this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 13:56:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 12:56:24 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 --- Comment #103 from Josef Moravec --- (In reply to Jonathan Druart from comment #102) > Update your QA tests repo! > > commit 89a86cceb79b412a26b68cd8c2e4907060af2f6d > Author: Jonathan Druart > Date: Wed Jan 18 13:16:57 2017 +0100 > > Add checkts for Bootstrap v3 (bug 16239) > > (arf typo) Great, thank you Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:02:30 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #6 from Marcel de Rooy --- Created attachment 59158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59158&action=edit Bug 9988: Database revision for AuthorityMergeLimit Introduce the new preference and remove dontmerge. If dontmerge was enabled, the new pref will be set to a lower number. Test plan: Run the database revision or a new install. In case of an upgrade, check the new pref value. Should be 10 when dontmerge was enabled, otherwise 50. Signed-off-by: Marcel de Rooy Also tested sysprefs.sql on a new database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:03:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:03:51 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #7 from Marcel de Rooy --- Created attachment 59159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59159&action=edit Bug 9988: Add Koha objects for table need_merge_authorities Test plan: Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:06:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:06:48 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authority cronjob ( pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 --- Comment #8 from Marcel de Rooy --- Just a run-up. More patches coming, but needing rebase on other work coming from the omnibus bug 17908. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:08:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:08:27 +0000 Subject: [Koha-bugs] [Bug 17931] New: Remove unused vars from reserves_stats.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Bug ID: 17931 Summary: Remove unused vars from reserves_stats.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:18:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:18:27 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 --- Comment #1 from Marcel de Rooy --- Created attachment 59160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59160&action=edit Bug 17931: Remove unused vars from reserves_stats Change to Modern::Perl. Remove null_to_zzempty and add a few blank lines between subs. Remove unused vars: $podsp, $type, $daysel, $monthsel and $mime. Removing trailing 1; Test plan: Run a few reports from reports/reserves_stats.pl Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:18:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:18:23 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:19:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:19:03 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 14:51:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 13:51:53 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 --- Comment #7 from M. Tompsett --- (In reply to Marcel de Rooy from comment #6) > Mark, > Here are a few other potential candidates: > > t/db_dependent/SuggestionEngine_ExplodedTerms.t: my $location = > File::Spec->rel2abs(dirname(__FILE__)); > t/db_dependent/www/auth_values_input_www.t:my $testdir = > File::Spec->rel2abs( dirname(__FILE__) ); > t/db_dependent/www/batch.t:my $testdir = File::Spec->rel2abs( > dirname(__FILE__) ); > t/db_dependent/www/search_utf8.t:my $testdir = File::Spec->rel2abs( > dirname(__FILE__) ); > t/db_dependent/zebra_config.pl:my $source = File::Spec->rel2abs('.'); Since you mentioned these, I'll put these on a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:14:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:14:47 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53100|0 |1 is obsolete| | --- Comment #32 from Alex Arnaud --- Created attachment 59161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59161&action=edit Bug 12063: Change date calculation for reserve expiration to skip all holiday This patch makes koha automatically set expiration date when reserves become waitting. Also it adds a new syspref "ExcludeHolidaysFromMaxPickUpDelay" that allows to take holidays into account while calculating expiration date. Test plan: - Install this patch and run updatedatabase.pl script, - allow ExpireReservesMaxPickUpDelay in system preferences, - set ReservesMaxPickUpDelay to 5. - Place an hold on a checked out item and check in this item: The hold's expiration date should be today + 5. - Allow ExcludeHolidaysFromMaxPickUpDelay in system preferences, - add holiday during this pickup delay period, - Create a new hold and make it comes waitting: The hold's expiration date should be today + 5 + number of closed day(s). Also: - Check that ExpireReservesOnHolidays syspref works again without ExcludeHolidaysFromMaxPickUpDelay. - Check that cancel fees apply again if wanted. Signed-off-by: sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:14:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:14:56 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53101|0 |1 is obsolete| | --- Comment #33 from Alex Arnaud --- Created attachment 59162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59162&action=edit Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database Signed-off-by: sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:15:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:15:04 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #34 from Alex Arnaud --- Created attachment 59163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59163&action=edit Bug 12063 - Keep patron's requested expiration date if it is prior to the calculated one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:16:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:16:37 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:25:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:25:34 +0000 Subject: [Koha-bugs] [Bug 17810] Add a button to navigate between records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17810 --- Comment #3 from Alexandre --- Hi Katryn, Sorry for my answering time, I have some troubles to log at my account in the last weeks. Thanks Mr Cormack, it?s works now. To answer your question, yes you?re right, I used ? notice ? but in english it?s ? record ?. It?s not really a problem, it?s more an add-on asked by someone here. It?s in the Lists Module from the start then go to ? Public lists ?. You must have at least one public list created. When we are consulting a record of a normal search, we have the ? prev./next ? (record) option, this one will be nice to have when consulting a record of a public list. This missing function could help navigate more easily between records of a public list. I put another screenshot with the missing option in a record from a public list. Thanks again, Alexandre from CCSR -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:25:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:25:45 +0000 Subject: [Koha-bugs] [Bug 17932] New: Koha::Object should provide a TO_JSON method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Bug ID: 17932 Summary: Koha::Object should provide a TO_JSON method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The Koha::Object class should provide a TO_JSON method that prepares data for JSON output. Right now, booleans are returned as integer values, and thus invalid for JSON output as boolean values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:29:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:29:18 +0000 Subject: [Koha-bugs] [Bug 17810] Add a button to navigate between records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17810 --- Comment #4 from Alexandre --- Created attachment 59164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59164&action=edit the space where the missing option is cercled in red -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:37:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:37:22 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #35 from Marcel de Rooy --- I would like to QA this patch set. Setting QA contact -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:55:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:55:07 +0000 Subject: [Koha-bugs] [Bug 17933] New: Prevent internal software error when searching patron with invalid birth date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Bug ID: 17933 Summary: Prevent internal software error when searching patron with invalid birth date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It seems that Bug 17557 reintroduced problem with invalid birth dates fixed by Bug 17375. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:55:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:55:49 +0000 Subject: [Koha-bugs] [Bug 17933] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17375 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 15:55:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 14:55:49 +0000 Subject: [Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17933 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:01:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:01:40 +0000 Subject: [Koha-bugs] [Bug 17933] Prevent internal software error when searching patron with invalid birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #1 from Dobrica Pavlinusic --- Our current problem are patrons without date of birth, which isn't covered by tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:17:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:17:32 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #8 from Kyle M Hall --- (In reply to Jonathan Druart from comment #7) > Before this patch, the action logged contained the itemnumber, not now. > Would it make sense to keep it? > We have the accountlines_id, so we could get the itemnumber from it. But it > could be handy to have it directly. > I am not sure this is relevant but I prefer to ask. After serious consideration, I think we should *not* be logging the itemnumber directly . This was actually making the logs messier. It is predicated on the assumption that a single writeoff action only affects a single fee. Basically, a "write off all" action was indistinguishable to making many individual writeoffs in the way it was coded. Now the writeoff all action works in a more sensible manner, it makes no sense to have an itemnumber key. For these reasons I recommend do not add itemnumber directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:21:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:21:10 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59163|0 |1 is obsolete| | --- Comment #36 from Alex Arnaud --- Created attachment 59165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59165&action=edit Bug 12063 - Keep patron's requested expiration date if it is prior to the calculated one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:21:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:21:39 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #13 from Oliver Bock --- Hi guys, any update on this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:30:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:30:38 +0000 Subject: [Koha-bugs] [Bug 17934] New: Various issues with auth_values_input_www.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 Bug ID: 17934 Summary: Various issues with auth_values_input_www.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: gmcharlt at gmail.com Kohadevbox is the best way to duplicate this problem, as tests need to be run in a koha-shell to work, and running from the kohaclone directory owned by vagrant as kohadev means hitting them. Bug 17920 dealt with Sitemapper which I encountered. Marcel suggested in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920#c6 to potentially fix: t/db_dependent/SuggestionEngine_ExplodedTerms.t -- nope t/db_dependent/www/auth_values_input_www.t -- Yes (unused line) t/db_dependent/www/batch.t -- No, but some mrc test files in path might be useful t/db_dependent/www/search_utf8.t -- Hmmm, same issue as batch.t t/db_dependent/zebra_config.pl -- Why are __FOOBAR__ items in this file? This means I will fix the similar problem to Sitemapper in this bug, and push the missing MRC files and confusing file to another bug, which someone else can submit if they wish. Short version: make t/db_dependent/www/auth_values_input_www.t more awesome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:31:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:31:01 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17934 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:31:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:31:01 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:38:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:38:22 +0000 Subject: [Koha-bugs] [Bug 17815] Problems with search for dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815 --- Comment #5 from Barton Chittenden --- (In reply to Katrin Fischer from comment #4) > (In reply to Barton Chittenden from comment #2) > > Numeric searches in Koha are possible using the syntax > > > > NNN-MMM > > > > Where NNN and MMM are numeric, and there are no spaces between the numerals > > and the dashes... so > > > > 1970-1980 > > > > will work as a numeric search, but I'm not sure about searching for date > > ranges in other formats. > > The help on the search option states to enter a date in the format of > YYYY-MM-DD and there are examples with this syntax in the test plan on bug > 14861. Would be good to get to the bottom of this somehow, but not sure > where to start. The available CCL attributes are documented at http://www.indexdata.com/yaz/doc/tools.html#ccl.qualifiers in "Table 7.2. Special attribute combos". We use "r=r" for numeric searches, creating the behavior above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:50:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:50:51 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent internal software |Internal software error |error when searching patron |when searching patron |with invalid birth date |without birth date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:56:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:56:06 +0000 Subject: [Koha-bugs] [Bug 17935] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 Bug ID: 17935 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 16:57:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 15:57:13 +0000 Subject: [Koha-bugs] [Bug 17914] The installer process tries to create borrowers.updated_on twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17914 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:11:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:11:47 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:11:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:11:49 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #6 from Mehdi Hamidi --- Created attachment 59166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59166&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:20:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:20:21 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54419|0 |1 is obsolete| | Attachment #59166|0 |1 is obsolete| | --- Comment #7 from Mehdi Hamidi --- Created attachment 59167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59167&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:20:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:20:36 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #8 from Mehdi Hamidi --- Created attachment 59168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59168&action=edit Bug 17015 - Tests for DiscreteCalendar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:20:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:20:55 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #9 from Mehdi Hamidi --- Created attachment 59169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59169&action=edit Bug 17015 - Koha now uses the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:21:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:21:06 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #10 from Mehdi Hamidi --- Created attachment 59170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59170&action=edit Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:21:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:21:21 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #11 from Mehdi Hamidi --- Created attachment 59171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59171&action=edit Bug 17015 - Peformance tests for Koha::DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:23:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:23:05 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #12 from Mehdi Hamidi --- Hello everyone, this is our new Calendar. This calendar is the combination of Koha::Calendar and C4::Calendar. The current calendar is very slow, especially for returns past due date. DateTime Objects are very huge and resource consuming. Our new calendar creates a Database Table to keep track of dates, holidays, open and close hours per branch. This way we can keep information about past, current and future dates/holidays. We also depend on the database to make the calculations instead of DateTime Objects which makes our new calendar incredibly faster than the current one for fines and check-ins. The last patch if for performance purposes and it show improvement in comparison to the current calendar -What we added/changed: 1- New UI 2- Change open and close hours for single and on range dates. - Holiday types: - Float : like Thanksgiving, holiday without a fixed date (same as exception, might be removed) - Needs validation : When a day is added in the future and it was an Exception or Floating holiday 365 days in the past. This day is considered opened, so if the holiday still applies, it needs to be changed to correct holiday. - Change holiday type, override existing holiday. - Copy range of holidays : - 1 day to multiple dates. - 7 days to another 7 days , apply day of the week to the same day of the week. - Any number of dates to the same number of dates. PS: This will copy everything, isopened, open/close hours and notes. - Delete repeated and weekly holidays for a single date or all of them. - Delete holidays on the range without a type. - Calculate hours opened between dates based on open and close hours of the branch. - Copy calendar to another branch. UI tips and tricks: - Open/close hour, date type inputs will be emptied when selecting a range that doesn't share the same values. Only different values will be emptied. - Leaving one these (open/close hour, date type) inputs empty means they won't be updated. - Leaving the title input empty means it will be empty/deleted. - Only dates in discrete_calendar table are selectable on the calendar. - You can't update the information about a past date, meaning you can only update today and future dates. This also applies to weekly holidays - Checking delete type, will delete all : - Weekly holidays of that day, example : all Sundays. - Repeatable holidays, example : all 1 of January. - Weekly holidays will apply the same open/close hours for all the dates affected unless these inputs are left empty, this can be used to update all open/close hours of a given day of the week, then removing the holiday. Scripts : - misc/generate_discrete_calendar.pl This script fills the table discrete_calendar based on tables : repeatable_holidays, special_holidays and branches. The script, by default, will add 2 years from the past and 1 year in the future in the table discrete_calendar. It also has an option to add more than 1 year in the future. Opening and closing hours are by default 9:00 and 17:00 respectively, they can be changed using the UI - add_days_discrete_calendar.pl This script will be used to add days in the future for the calendar, default is 1 day, this can be changed using -n option for the script. The add day will have the following values: - Open/close hours based on the same day of the week, a week beofre it. Example : new day : Friday 2018-01-19, a week before Friday 2018-01-12 - HolidayType based on the same day a year ago, however if the holiday type was : Float/Exception : the holidaytype of the the new day will be marked as Needs validation. Weekly : the new day will be marked as normal day(To discuss further). Fixed : the new day will be closed as fixed holiday. Test plan : 1- Apply patch 2- Run installer/data/mysql/updatedatabase.pl 3- Have atleast these branches CPL, FFL, LPL for test purposes (specific test : t/db_dependent/HoldsQueue.t) 4- Run the script misc/generate_discrete_calendar.pl (one time only, this may take a while) 5- Run the script add_days_discrete_calendar.pl to add days into the future - Check if the max date is now today + 1 day 6- Generate schemas by running misc/devel/update_dbix_class_files.pl 7- Run test t/db_dependent/DiscreteCalendar.t 8- Run all koha test t/ Use Discrete Calendar in Tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 17:50:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 16:50:11 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 18:13:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 17:13:17 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 18:14:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 17:14:52 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 18:14:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 17:14:54 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #2 from Dobrica Pavlinusic --- Created attachment 59172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59172&action=edit Bug 17933 - Internal software error when searching patron without birth date When patrons don't have date of birth (which is not required) patron search results on moremember page produce internal server error since we can't convert MySQL invalid date 0000-00-00 to datetime object and call strfdate on it. Additionally, since we assign dates to template variables and after than assign whole $data hash to template, later assigment overrides previous one, so we see birth date field even for patrons which don't have one. This patch fixes both of those problems. Test: 1. edit patron and remove it's birth date 2. try to search for it, and verify server error 3. apply patch 4. repeat search for patron and verify that it works and doesn't have enpty birth date field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 18:19:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 17:19:02 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 18:40:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 17:40:02 +0000 Subject: [Koha-bugs] [Bug 17810] Add a button to navigate between records coming from a list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17810 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a button to navigate |Add a button to navigate |between records |between records coming from | |a list --- Comment #5 from Katrin Fischer --- Thx for explaining - I have amended the title of the bug accordingly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 18:41:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 17:41:22 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #13 from Josef Moravec --- I am always for making Koha faster ;) I just did first round of testing: scripts generate_discrete_calendar.pl and add_days_discrete_calendar.pl needs to have set execution permission in filesystem the need to run generate_discrete_calendar.pl should be somehow documented in UI, adding holidays does not work without it and the can't know why qa tools complain: FAIL C4/Circulation.pm FAIL forbidden patterns forbidden pattern: tab char (line 3418) forbidden pattern: tab char (line 394) forbidden pattern: tab char (line 676) forbidden pattern: tab char (line 3575) forbidden pattern: tab char (line 3553) FAIL Koha/DiscreteCalendar.pm FAIL critic Variable declared in conditional statement at line 862, column 5. Declare variables outside of the condition. Variable declared in conditional statement at line 861, column 5. Declare variables outside of the condition. FAIL forbidden patterns forbidden pattern: tab char (line 413) forbidden pattern: tab char (line 412) forbidden pattern: tab char (line 411) FAIL pod Spurious text after =cut Spurious =cut command *** ERROR: in file Koha/DiscreteCalendar.pm FAIL spelling differnt ==> different FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/discrete_calendar.tt FAIL forbidden patterns forbidden pattern: tab char (line 440) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 7) forbidden pattern: tab char (line 439) forbidden pattern: tab char (line 441) FAIL misc/cronjobs/staticfines.pl FAIL valid Can't locate C4/DiscreteCalendar.pm in @INC (you may need to install the C4::DiscreteCalendar module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) Ad point 3 in your test plan: It would be better not to rely on existing branchcodes, but use TestBuilder to make one you need -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 18:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 17:42:29 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- The patch currently doesn't apply, we are waiting for a rebase to the current code base. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 19:27:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 18:27:44 +0000 Subject: [Koha-bugs] [Bug 17926] REST API: Boolean values should be coerced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17926 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Tom?s Cohen Arazi --- Adding a TO_JSON method seems a better approach as it won't hide data issues (which could happen if coercing values into booleans). *** This bug has been marked as a duplicate of bug 17932 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 19:27:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 18:27:44 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #1 from Tom?s Cohen Arazi --- *** Bug 17926 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 19:30:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 18:30:56 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 --- Comment #1 from M. Tompsett --- Created attachment 59173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59173&action=edit Bug 17934: Make t/db_dependent/www/auth_values_input_www.t awesome There were two lines of code which declared unused variables. They were removed. Next, the issue of double planning encountered on bug 17540 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540#c3) was encountered. So this corrects that and adds a little more error handling into the whole C4::Context using process so that perlcritic -4 is achieved. Also typo on Korean in a comment. TEST PLAN --------- 2) follow these commands: $ mv C4/Context.pm C4/Context_backup.pm $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ mv C4/Context_backup.pm C4/Context.pm $ sudo koha-shell -c "export PERL5LIB=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ sudo koha-shell -c "export KOHA_CONF=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- Nasty fail $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"http://localhost:8080/\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should work. $ perlcritic -4 t/db_dependent/www/auth_values_input_www.t -- This should fail 2) apply patch 3) follow these commands: $ mv C4/Context.pm C4/Context_backup.pm $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should trigger the C4::Context not working message $ mv C4/Context_backup.pm C4/Context.pm $ sudo koha-shell -c "export PERL5LIB=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should trigger the C4::Contxt not loading message $ sudo koha-shell -c "export KOHA_CONF=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should trigger the KOHA_CONF not set message $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"\";prove t/db_dependent/www/auth_values_input_www.t" kohadev $ sudo koha-shell -c "prove t/db_dependent/www/auth_values_input_www.t" kohadev -- These should both trigger the KOHA_INTRANET_URL not set message $ sudo koha-shell -c "export KOHA_INTRANET_URL=\"http://localhost:8080/\";prove t/db_dependent/www/auth_values_input_www.t" kohadev -- This should work. $ perlcritic -4 t/db_dependent/www/auth_values_input_www.t -- This should be OK 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 19:35:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 18:35:31 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 19:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 18:42:57 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 --- Comment #2 from M. Tompsett --- Comment on attachment 59173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59173 Bug 17934: Make t/db_dependent/www/auth_values_input_www.t awesome Review of attachment 59173: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17934&attachment=59173) ----------------------------------------------------------------- After rereading the code changes, perhaps enhancement is better. You'll note that perlcritic -1 on this will be nice and short. ::: t/db_dependent/www/auth_values_input_www.t @@ -30,2 @@ > > -my $testdir = File::Spec->rel2abs( dirname(__FILE__) ); not used. @@ +35,5 @@ > + $skip_all = "Tests skipped. You must have a working C4::Context.\n"; > +} > +elsif ( ! can_load( modules => { 'C4::Context' => undef } ) ) { > + $skip_all = "Tests skipped. You must be able to load C4::Context.\n"; > +} Added to determine cause of failure better. @@ +45,5 @@ > + $user = $ENV{KOHA_USER} || $xml->{config}->{user}; > + $password = $ENV{KOHA_PASS} || $xml->{config}->{pass}; > +} > +elsif ($skip_all eq q{}) { > + $skip_all = "Tests skipped. You must set env. variable KOHA_CONF to run tests.\n"; Added check. @@ +56,4 @@ > } > > +if (length $skip_all > 0) { > + croak $skip_all; # to keep Test Summary output Any failures due to prerequisites will happen here. @@ +63,3 @@ > my $dbh = C4::Context->dbh; > > +$intranet =~ s/\/$//xsm; perlcritic -1 prefers /'s and xsm added. @@ -54,3 @@ > > my $agent = Test::WWW::Mechanize->new( autocheck => 1 ); > -my $jsonresponse; Not used. @@ +72,5 @@ > $agent->get_ok( "$intranet/cgi-bin/koha/mainpage.pl", 'connect to intranet' ); > $agent->form_name('loginform'); > $agent->field( 'password', $password ); > $agent->field( 'userid', $user ); > +$agent->field( 'branch', q{} ); q{} is perlcritic -1 friendly. @@ +78,3 @@ > $agent->get_ok( "$intranet/cgi-bin/koha/mainpage.pl", 'load main page' ); > > +#--------------------------------------------------- Test with Korean and greek chars Typo! @@ +88,4 @@ > $agent->get_ok( "$intranet/cgi-bin/koha/admin/authorised_values.pl?op=add_form", 'Open to create a new category' ); > $agent->form_name('Aform'); > $agent->field('category', $category); > +$agent->click_ok( q{}, 'Create new AV category ' ); Using single quotes for non-interpolated strings is perlcritic friendlier. @@ +94,3 @@ > $add_form_link_exists = 0; > for my $link ( $agent->links() ) { > + if ( $link->url =~ m/authorised_values.pl\x3Fop=add_form&category=$category/xsm ) { perlcritic didn't like \?, so I hex'd it. @@ +123,5 @@ > $agent->get_ok( "$intranet/cgi-bin/koha/admin/authorised_values.pl", 'Return to Authorized values page' ); > $agent->get_ok( "$intranet/cgi-bin/koha/admin/authorised_values.pl?searchfield=?????&offset=0", 'Search the values inserted' ); > my $text = $agent->text() ; > #Tests on UTF-8 > +ok ( ( length Encode::encode('UTF-8', $text) != length $text ) , 'UTF-8 are multi-byte. Good') ; length is a built in function, no need for brackets on it. Removed brackets for perlcritic friendliness. @@ +173,5 @@ > $delete_form_link_exists = 1; > } > } > +is( $add_form_link_exists, 1, 'Add form link exists'); > +is( $delete_form_link_exists, 1, 'Delete form link exists'); Added a reasonable test description string to make perlcritic happier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 19:43:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 18:43:06 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 19:53:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 18:53:32 +0000 Subject: [Koha-bugs] [Bug 17934] Various issues with auth_values_input_www.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17934 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 20:48:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 19:48:43 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:03:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:03:49 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #101 from Alex Buckley --- Created attachment 59174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59174&action=edit Bug 17855 -Removed HTML regexes from all fields on all screens of onboarding tool except branchcode, patron category code and item type code. Also ensured these three remaining regexes are all {1,10} for length as they are all required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:04:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:04:10 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:18:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:18:40 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59028|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 59175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59175&action=edit Bug 17917: Fix Jenkins for t/db_dependent/Holds.t This changes AddMember into TestBuilder calls. TEST PLAN --------- 1) prove -v t/db_dependent/Holds.t -- fails 2) apply this patch 3) prove -v t/db_dependent/Holds.t -- works 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:30:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:30:06 +0000 Subject: [Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:30:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:30:09 +0000 Subject: [Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59119|0 |1 is obsolete| | --- Comment #5 from Gracie --- Created attachment 59176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59176&action=edit Bug 17290 - Standardize on "Patron Categories" We need to standardize on terminology, this changes all instances of patron types to be patron categories. To text, just view the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:36:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:36:18 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |grace.mcky at gmail.com --- Comment #21 from Gracie --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13219: Charts: Added Charts.js javascript charting library Applying: Bug 13219: Added Charts to issues report Applying: Bug 13219: Added color to charts fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13219: Added color to charts The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-13219-Added-color-to-charts-_jxQr5.patch I would like to work on this, but patch does not apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:37:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:37:41 +0000 Subject: [Koha-bugs] [Bug 13219] Add graphs to guided reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |grace.mcky at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:44:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:44:22 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #7 from Caitlin Goodger --- Created attachment 59177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59177&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:44:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:44:19 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:44:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:44:41 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #14 from Mehdi Hamidi --- (In reply to Josef Moravec from comment #13) Hello Josef, thank you for testing our patches. I will push a fix for errors you mentioned very soon. As for your concerns : >- the need to run generate_discrete_calendar.pl should be somehow documented in >UI, adding holidays does not work without it and the can't know why I added a warning to let the user know about that. As for why you can't add holidays, it's because we need to have the date in the database beforehand, which means if the table is empty, there's date to edit. Holidays are just date where the column isopen=0. >Ad point 3 in your test plan: It would be better not to rely on existing >branchcodes, but use TestBuilder to make one you need Our calendar needs to have valid branchcodes where their date are already in table discrete_calendar. Using TestBuilder gives random branchcodes so the dates cannot be retrieved from database since they are generated by generate_discrete_calendar.pl and add_days_discrete_calendar.pl. If you have a suggestion to bypass the hard coded branchcodes, let us know! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:53:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:53:59 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:54:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:54:03 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59139|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 59178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59178&action=edit [SIGNED OFF] Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details Signed-off-by: Katrin Fischer Fixed a missing
-- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:58:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:58:54 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59050|0 |1 is obsolete| | --- Comment #8 from Luke Honiss --- Created attachment 59179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59179&action=edit Bug 17865 'If a subscription has no history end date, it shows as expired today in OPAC' fixed --TEST PLAN-- 1) View a subscription with no history end date 2) Search for an item with a subcription in OPAC 3) Under subscription tab click more details 4) The end date will be the current date 5) Apply patch and refresh 6) The end date will be replaced with a message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 21:58:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 20:58:51 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:01:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:01:05 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Linking some other bugs to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:02:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:02:45 +0000 Subject: [Koha-bugs] [Bug 17884] troubles with syspref AllowHoldPolicyOverride on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11512, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13559 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:02:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:02:45 +0000 Subject: [Koha-bugs] [Bug 13559] Forced item level hold should be highlighted on return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13559 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17884 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:02:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:02:45 +0000 Subject: [Koha-bugs] [Bug 11512] Forced holds that violate issuing rules will never be filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17884 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:08:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:08:59 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 --- Comment #3 from Caitlin Goodger --- Created attachment 59180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59180&action=edit Bug 17437 MARC21: Show $i for 780/785 Test Plan 1: Inside Administration go to MARC bibliographic framework and on the default framework under Actions click on MARC structure 2: Search for 780 under search tag and under actions click subfields 3: Find i and click on edit. 4: Under Advanced Constraints select editor and save the changes. 5: Repeat for 785. 6: Find a Bibliograpical record and under Edit select edit record. 7: Under the 7 put values into 780 and 785. For this to work it is dependant on the patch 17929 so that you can type into the indicators 8: When you save the changes you won't be able to see 780 or 785 on the Bibliographical details 8: Apply the patch 9: Refresh and 780 and 785 should be there at the bottom under the content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:08:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:08:56 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:32:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:32:48 +0000 Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Gracie --- While testing this bug I came across the fact that in the 'Add Item' form there are no repeatable fields, what "clone" button are you referring to? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:36:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:36:15 +0000 Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53884|0 |1 is obsolete| | --- Comment #5 from Gracie --- Created attachment 59181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59181&action=edit Bug 16962 - Remove the use of "onclick" from serial collection and serial edit templates This patch removes the use of event attributes like "onclick" from the serial collection and serial edit templates. Events are now defined in JavaScript. Also changed: Converted "create routing list," "edit routing list," and "Renew" links to Bootstrap buttons. The "select all" and "clear all" links have Font Awesome icons added. To test, apply the patch and go to Serials - Locate or create a subscription for which an item record is NOT created when receiving. - On the serial collection page for this subscription, test that the "Multi receiving" button works correctly. - For any subscription, test that the "Generate next" button works correctly. - In each tab, test that the "select all" and "clear all" links work correctly. - On a subscription which has expired, test that the "Renew" button works correctly. - On the serial collection page, select multiple issues and click the "Edit serials" button. - Testing with a subscription for which an item record is NOT created when receiving: - Changing the status to "Arrived" or "Claimed" should change the "Expected on" date to today's date. Selecting any other status should leave the "expected on" date as it was or return it to its original value. - Test that the "Multi receiving" button works correctly. - Testing with a subscription for which an item record IS created when receiving: - Changing the status of an issue should work as above but should also trigger the appearance of the item add form when the status is "Arrived" or "Claimed," and hide the form otherwise. - Cliking the "Item" link at the top of the item add form should hide it. - Clicking the "Add item" link under any issue should display the item add form. - In the item add form, test that repeatable fields are correctly duplicated when you click the "clone" button. - On the "Supplemental issue" line, changing the status to "Arrived" should work as described above. Changing the status on this line to "Claimed" should only change the "Expected on" date. - Adding regular and supplemental issues should work correctly. Signed-off-by: Fr?d?ric Demians Works as described. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:40:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:40:54 +0000 Subject: [Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |grace.mcky at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:45:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:45:37 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:45:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:45:40 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #25 from Emma --- Created attachment 59182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59182&action=edit Bug 17134: Replace item types codes with category To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:56:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:56:59 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 22:57:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 21:57:03 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47081|0 |1 is obsolete| | --- Comment #20 from Gracie --- Created attachment 59183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59183&action=edit Bug 15584 - Staff client list errors are incorrectly styled I have fixed the conflict when applying this patch for those who wish to work more on it To Test- 1-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that it has some red in it like an error 2- apply patch 3-In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that now it should be just yellow with black writing as an alert Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:01:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:01:06 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #14 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Would not it make more sense to make library_limits returns Koha::Libraries > instead of \@branchcodes? What behaviour would you expect when assigning library_limits? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:02:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:02:33 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:02:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:02:36 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59036|0 |1 is obsolete| | Attachment #59101|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 59184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59184&action=edit [SIGNED OFF] Bug 17891 - typo in housebound.tt div tag In housebound.tt there is a end tag div missing closing character '>'. Signed-off-by: Zoe Schoeler Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:03:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:03:06 +0000 Subject: [Koha-bugs] [Bug 15269] Layout tweaks for the opac-detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15269 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com --- Comment #30 from Gracie --- I tried to resolve the conflict that occurs while applying this patch, the conflict is very big and confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:03:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:03:21 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 --- Comment #7 from Katrin Fischer --- Created attachment 59185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59185&action=edit [SIGNED OFF] Bug 17891: Followup This fixes the menu layout issue. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:06:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:06:17 +0000 Subject: [Koha-bugs] [Bug 17936] New: Search bar not aligned on right in small screen sizes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17936 Bug ID: 17936 Summary: Search bar not aligned on right in small screen sizes Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: Linux Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kathryn at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Created attachment 59186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59186&action=edit screen shot of search bar not aligned on rhs When viewing the home page in a mobile-phone sized screen the search is not aligned with the items above and below it on the right hand side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:10:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:10:32 +0000 Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:10:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:10:34 +0000 Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 --- Comment #1 from Caitlin Goodger --- Created attachment 59187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59187&action=edit Bug 16606 Checkout settings dropdown should have a preference to stay open all the time Test Plan 1: Update database 2: Turn on the CheckoutSettingsVisibility syspref 3: Go to your checkouts 4: COnfirm that the checkout settings is open 5: Turn the syspref and go back to your checkouts 6: Confirm that the Checkout settings are closed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:20:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:20:18 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #102 from M. Tompsett --- Comment on attachment 59174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59174 Bug 17855 -Removed HTML regexes from all fields on all screens of onboarding tool except branchcode, patron category code and item type code. Also ensured these three remaining regexes are all {1,10} for length as they are all required. Review of attachment 59174: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=59174) ----------------------------------------------------------------- Thanks for removing the pattern= and tweaking some regexp's to be 1,10. In some cases you removed the title= piece, which means no tooltip. Tooltips are great to have. I would have left them, just without the length specification stuff. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt @@ +65,4 @@ >
    >
  1. > > + Never hurts to have a |html, just to make sure no injections could accidentally happen. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt @@ +128,4 @@ >

    Patron identity

    >
  2. > > + Probably should have |html in the surname too. @@ -156,5 @@ > Required >
  3. >
  4. > > - |html was okay. @@ -214,5 @@ > Required >
  5. >
  6. > > - This was probably okay to leave with the |html. ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt @@ -55,5 @@ >
  7. > >
  8. > > - Probably okay to leave the |html. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:28:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:28:14 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com --- Comment #3 from Gracie --- I followed your test plan and I cannot reproduce the bug. Can someone else test to confirm that this a valid bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:34:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:34:13 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #9 from Katrin Fischer --- This is much better, I think the date checking now works correctly. I have a bit worried that patrons won't know what "The subscription has no history end date" means. If the date is empty, it means that the subsription is possibly still active - I think it would be better not to display something in this case. What do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:43:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:43:11 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I found a way to reproduce it. It happens when 0000-00-00 is in the dateofbirth field in the borrowers table, not with NULL or ''. But the only way I managed to put the invalid date there was SQL. Dobrica, could this be old data we are dealing with here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:54:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:54:46 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #103 from Alex Buckley --- Created attachment 59188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59188&action=edit Bug 17855 - Added |html and added in input title attribute to input fields where it existed previously -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:57:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:57:36 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- Sorry, but there are some problems with this solution: The patch removes the class 'indicator', but classes are not only used for styling, but also for targetting elements in Javascript. One negative side effect of removing the class is, that the authority linking plugin does not correctly work anymore (a white window remains, Javascript error indicates problem with filling indicators). I think it would be a safer and nicer solution to keep the class, but change the CSS tied to it. I did some experimentation with the browser tools - maybe another solution to explore could be to change the width. I turned it up to 2 em and was able to enter indicators again. We will also need the same fix for the authority record editor - it shows the same bad symptoms right now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:57:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:57:45 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:57:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:57:48 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 --- Comment #3 from Karen --- Created attachment 59189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59189&action=edit Bug 17867 Improve display of MARC21 773 in result list Test Plan: 1) Add a record with 773$a (no $t!) and another record with 773$a and $t 2) View it on the detail pages and result lists in staff and OPAC 3) Confirm that 773$a and $t show on the detail page 4) Confirm that 773$a doesn't show on the results list but $t does. 5) Apply patch and refresh the result list page 6) 733$a and $t should now both show on the result list page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:58:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:58:50 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:58:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:58:52 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 --- Comment #2 from Gracie --- Created attachment 59190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59190&action=edit Bug 17853 - Don't remove () from link text I have followed your test plan, applied the patch and have noticed that there are now brackets around the link text. Is this what you were looking for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 18 23:59:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 22:59:02 +0000 Subject: [Koha-bugs] [Bug 17937] New: Adding item description to Twitter Summary Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 Bug ID: 17937 Summary: Adding item description to Twitter Summary Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: caitlingoodger.student at wegc.school.nz QA Contact: testopia at bugs.koha-community.org When a user posts a link to an item in their library's catalog on Twitter the description will show in the Twitter card. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:06:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:06:41 +0000 Subject: [Koha-bugs] [Bug 17928] Updating sounds for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17928 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Emma, I am not sure what to look out for here, can you explain a bit more? What are we changing here and why? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:09:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:09:28 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:09:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:09:31 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59160|0 |1 is obsolete| | --- Comment #2 from Emma --- Created attachment 59191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59191&action=edit Bug 17931: Remove unused vars from reserves_stats Change to Modern::Perl. Remove null_to_zzempty and add a few blank lines between subs. Remove unused vars: $podsp, $type, $daysel, $monthsel and $mime. Removing trailing 1; Test plan: Run a few reports from reports/reserves_stats.pl Signed-off-by: Marcel de Rooy Signed-off-by: Emma Smith -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:11:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:11:41 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 --- Comment #1 from Caitlin Goodger --- Created attachment 59192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59192&action=edit Bug 17937 Adding item description to Twitter Summary Test Plan to be revised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:18:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:18:34 +0000 Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59189|0 |1 is obsolete| | --- Comment #4 from Karen --- Created attachment 59193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59193&action=edit Bug 17867 Improve display of MARC21 773 in result list I had to undo the changes I made previously in file MARC21slim2intranetResults.xsl. Only change the MARC21slim2OPACResults.xsl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:24:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:24:26 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:24:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:24:28 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59172|0 |1 is obsolete| | --- Comment #5 from Gracie --- Created attachment 59194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59194&action=edit Bug 17933 - Internal software error when searching patron without birth date When patrons don't have date of birth (which is not required) patron search results on moremember page produce internal server error since we can't convert MySQL invalid date 0000-00-00 to datetime object and call strfdate on it. Additionally, since we assign dates to template variables and after than assign whole $data hash to template, later assigment overrides previous one, so we see birth date field even for patrons which don't have one. This patch fixes both of those problems. Test: 1. edit patron and remove it's birth date 2. try to search for it, and verify server error 3. apply patch 4. repeat search for patron and verify that it works and doesn't have enpty birth date field Signed-off-by: Grace McKenzie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:25:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:25:04 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #15 from Mehdi Hamidi --- (In reply to Josef Moravec from comment #13) > >Ad point 3 in your test plan: It would be better not to rely on existing >branchcodes, but use TestBuilder to make one you need > > Our calendar needs to have valid branchcodes where their date are already in > table discrete_calendar. Using TestBuilder gives random branchcodes so the > dates cannot be retrieved from database since they are generated by > generate_discrete_calendar.pl and add_days_discrete_calendar.pl. > > If you have a suggestion to bypass the hard coded branchcodes, let us know! Please discard this part. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:30:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:30:03 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:30:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:30:07 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59177|0 |1 is obsolete| | --- Comment #9 from Caitlin Goodger --- Created attachment 59195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59195&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. On my window you still can't see the indicator properly so you can choose what looks better between the 2em and the 3em one. This is the 2em one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:34:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:34:18 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59195|0 |1 is obsolete| | --- Comment #10 from Caitlin Goodger --- Created attachment 59196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59196&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. I have made a patch for 2em and 3em and this is the 3em one because the 2em is still too small on my screen. Choose which one works better for you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 00:57:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 18 Jan 2017 23:57:24 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss at gmail.com --- Comment #10 from Luke Honiss --- I thought it may be a bit confusing. In the staff checkout it shows a similar field as being blank, but having the title for that field is "History end date" which is why I put the message as that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:02:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:02:41 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 --- Comment #11 from Katrin Fischer --- I think for the librarians it probably makes sense - more or less. Serials is one of the more complicated modules of Koha. I think for the patrons it might be confusing, that's why I think maybe only show the expired message, but not the other message. I was also pondering to rephrase it to something like "The library still subscribes to this serial", but I am not sure if the history end date is always set if a subscription is not renewed - so that might not be right in all cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:41:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:41:03 +0000 Subject: [Koha-bugs] [Bug 17815] Problems with search for dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #4) > The help on the search option states to enter a date in the format of > YYYY-MM-DD and there are examples with this syntax in the test plan on bug > 14861. Would be good to get to the bottom of this somehow, but not sure > where to start. The search help is often quite incorrect. I've been meaning to update it for a while. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:42:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:42:45 +0000 Subject: [Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 [Bug 17929] You can't edit indicators in the cataloging screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:42:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:42:45 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437 [Bug 15437] MARC21: Show $i for 780/785 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:50:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:50:14 +0000 Subject: [Koha-bugs] [Bug 17815] Problems with search for dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815 --- Comment #7 from David Cook --- As for bug 14861, you'll notice the CCL qualifiers are "acqdate,st-date-normalized". That st-date-normalized gives it a structure attribute of "date". If we follow the spec for "date", we find: The day, month, year and time when a (normalized) transaction or event takes place. The date search term structure is as defined for Generalized Time in ASN.1 (ISO 8824) except that the only mandatory portion of the string is the four-digit representation of the year. http://www.loc.gov/z3950/agency/bib1.html Some Googling suggests ISO 8824 might use the following format: Format: YYYY[MM[DD[HHMM[SS[.S[S[S[S]]]]]]]][+/-ZZZZ]^ Of course, I don't know how ICU and CHR normalization rules factor in with the "2011-09-01 - 2011-09-30" search string... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:53:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:53:44 +0000 Subject: [Koha-bugs] [Bug 17815] Problems with search for dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815 --- Comment #8 from David Cook --- (In reply to Katrin Fischer from comment #3) > > Can you give us any more data? > > > > I trust with the SQL that the dateaccessioned would be between '2011-09-01' > > and '2011-09-30', but what about those 9461 results? If you look at a sample > > of them, do they all have dateaccessioned within that range, or do they have > > different data? > > They have different data. I verified the results with SQL, the Zebra results > were clearly wrong. I was not able to verify which items actually showed up > in the search. > > > Can you share a link to your results? > > It won't help. I filed a separate bug for the dateaccessioned search not > working by entering the index name in keyword search and the search option > is only available from the staff side of Koha. It would be interesting tho > if someone can see similar (wrong) results on a different data set. It would be nice to see even a small selection of data to see if anything jumps out at me, but OK. I don't have time to work on this, but maybe Barton can make some headway? I'd try to reproduce the situation, and then maybe use zebra::snippet to see why I'm getting matches which don't make sense for our understanding of the query. Could be that the staff client search template isn't using st-date-normalized, or that the query is processed differently than we expect, or a bug in YAZ/Zebra.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:54:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:54:02 +0000 Subject: [Koha-bugs] [Bug 17815] Problems with search for dateaccessioned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17815 --- Comment #9 from David Cook --- Oh that might be useful to know. Katrin: What version of Zebra and YAZ are you using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 01:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 00:57:29 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 --- Comment #3 from Caitlin Goodger --- Created attachment 59197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59197&action=edit Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:04:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:04:04 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59190|0 |1 is obsolete| | --- Comment #3 from Gracie --- Created attachment 59198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59198&action=edit Bug 17853 - Don't remove () from link text I have followed your test plan, applied the patch and have noticed that there are now brackets around the link text. Is this what you were looking for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:07:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:07:37 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 --- Comment #12 from Luke Honiss --- I'll just remove the line. There should hopefully be no confusion that way -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:10:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:10:40 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Eyeballs well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:22:09 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:22:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:22:12 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 --- Comment #13 from Luke Honiss --- Created attachment 59199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59199&action=edit Bug 17865 'If a subscription has no history end date, it shows as expired today in OPAC' --TEST PLAN-- 1) View a subscription with no history end date 2) Search for an item with a subcription in OPAC 3) Under subscription tab click more details 4) The end date will be the current date 5) Apply patch and refresh 6) The end date will not be shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:22:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:22:59 +0000 Subject: [Koha-bugs] [Bug 17938] New: XSLT: if 583 is repeated, the label will appear multiple times. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Bug ID: 17938 Summary: XSLT: if 583 is repeated, the label will appear multiple times. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: karenliang.student at wegc.school.nz QA Contact: testopia at bugs.koha-community.org This will build on the patch bug 17823. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:25:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:25:18 +0000 Subject: [Koha-bugs] [Bug 15590] Next issue skipped if planned date is 1/1/2016 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15590 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss at gmail.com --- Comment #2 from Luke Honiss --- This bug does not apply for 2017 or 2018. I could reproduce it but could not reproduce for more current years. I think this bug is now irrelevant? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:30:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:30:51 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59195|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:34:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:34:28 +0000 Subject: [Koha-bugs] [Bug 6507] Renew ALL from self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6507 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:37:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:37:27 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #21 from M. Tompsett --- (In reply to Jonathan Druart from comment #19) > Why do you want to replace AddMember calls with TestBuilder? 1) Because it fixes the failed tests. 2) Because none of the tests actually are testing whether a member was added correctly or not. (i.e. not t/db_dependent/Members.t) 3) Because putting in the userenv logic method seemed like the wrong fix compared to switching to TestBuilder. 4) Because TestBuilder generates a nicer patron record than the userenv logic that would have been added. 5) even with your change from bug 6782, there are still failures. TEST PLAN --------- vagrant up jessie cd kohaclone git checkout -b bug_17917 origin/master git bz apply 17917 y git checkout master sudo koha-shell -c "prove t/db_dependent" kohadev # This has faillures git checkout bug_17917 sudo koha-shell -c "prove t/db_dependent" kohadev # This drastically reduces the problems. Still kind of bummed about check_sysprefs failing when t/db_dependent, but not when individually. And, Reserves.t needs a patch from 13113 applied, because it got missed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:49:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:49:41 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #22 from M. Tompsett --- (In reply to M. Tompsett from comment #21) > And Reserves.t needs a patch from 13113 applied, > because it got missed. Or my lack of sleep made me misread code. but some how it is failing too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:56:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:56:07 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:56:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:56:09 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59192|0 |1 is obsolete| | --- Comment #2 from Caitlin Goodger --- Created attachment 59200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59200&action=edit Bug 17937 Adding item description to Twitter Summary Test Plan 1: Apply Patch 2: Enable Twitter Summary and enter a Twitter account 3: To test you can go to this site. https://cards-dev.twitter.com/validator 4: When you tweet about the book it should show the description of the book -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 02:56:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 01:56:28 +0000 Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |caitlingoodger.student at wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 03:41:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 02:41:03 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58889|0 |1 is obsolete| | --- Comment #2 from Caitlin Goodger --- Created attachment 59201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59201&action=edit Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT Signed-off-by: Caitlin Goodger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 03:59:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 02:59:08 +0000 Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 --- Comment #8 from Emma --- Created attachment 59202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59202&action=edit Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 03:59:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 02:59:05 +0000 Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:00:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:00:43 +0000 Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emma.nakamura.smith at gmail.c | |om --- Comment #9 from Emma --- I was able to fix the merge conflicts and points 1 and 3 in Jonathan's comment, but I didn't understand point 2. This is ready to test if point 2 isn't a block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:02:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:02:38 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:02:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:02:42 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 --- Comment #6 from Luke Honiss --- Created attachment 59203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59203&action=edit Bug 11450: Hold Request Confirm Deletion ==TEST PLAN== 1) Go to an item with a hold and click on the holds tab on the left 2) Click the red 'X' 3) The hold will be deleted immediately 4) Apply patch 5) Return to an item with a hold and click the 'X' 6) There will now be a confirmation dialog 7) Click cancel and the dialog will disappear and the hold will not be deleted 8) Click OK and the hold will be deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:04:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:04:52 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com Status|In Discussion |Failed QA --- Comment #23 from Gracie --- I have tested this patch and the second Koha-shell command does give a distractingly less amount of failures, however there are still many failures: This is the end result of the test plan Test Summary Report ------------------- t/db_dependent/00-strict.t (Wstat: 256 Tests: 661 Failed: 1) Failed test: 368 Non-zero exit status: 1 t/db_dependent/Koha_Elasticsearch_Indexer.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 5 tests but ran 2. t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t (Wstat: 2816 Tests: 11 Failed: 2) Failed tests: 1, 11 Non-zero exit status: 11 t/db_dependent/Reserves.t (Wstat: 65280 Tests: 52 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 72 tests but ran 52. t/db_dependent/Sitemapper.t (Wstat: 65280 Tests: 3 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 3. t/db_dependent/TestBuilder.t (Wstat: 256 Tests: 10 Failed: 1) Failed test: 3 Non-zero exit status: 1 t/db_dependent/check_sysprefs.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=87, Tests=3228, 1056 wallclock secs ( 0.98 usr 0.29 sys + 960.02 cusr 58.44 csys = 1019.73 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:28:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:28:06 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mubassir Ahsan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mahsandu at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:28:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:28:30 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |grace.mcky at gmail.com --- Comment #39 from Gracie --- The patch was successful for the acquisitions but not for the cataloging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:43:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:43:56 +0000 Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated, the label will appear multiple times. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:43:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:43:58 +0000 Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated, the label will appear multiple times. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 --- Comment #1 from Karen --- Created attachment 59204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59204&action=edit Bug 17938 - XSLT: if 583 is repeated, the label will appear multiple times Test plan 1) Edit a record 2) Repeat the Action note tag to add another Action note 3) Save record and confirm that the Action note label appears multiple times. 4) Apply patch and refresh page 5) All Action notes should now be on one line and separated by "|" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:45:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:45:50 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Assignee|gmcharlt at gmail.com |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:46:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:46:31 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:47:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:47:39 +0000 Subject: [Koha-bugs] [Bug 12832] Basketgroup printing doesn't support non-latin characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12832 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |caitlingoodger.student at wegc | |.school.nz --- Comment #5 from Caitlin Goodger --- I was able to apply the patch after fixing a merge conflict. CONFLICT (content): Merge conflict in acqui/pdfformat/layout3pages.pm With the patch exporting basketgroups with no latin characters in the title of an order doesn't work but exporting other basketgroups does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:50:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:50:53 +0000 Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated, the label will appear multiple times. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 [Bug 17823] XSLT: Add label for MARC 583 - Action note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:50:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:50:53 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Karen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 [Bug 17938] XSLT: if 583 is repeated, the label will appear multiple times. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:51:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:51:40 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #24 from M. Tompsett --- Here is an test run of mine, demonstrating only two known issues, which are technically beyond the AddMember scope of the other ones. I would be willing to open another bug for those, if these would Pass QA. vagrant at kohadevbox:kohaclone(bug_17917)$ git fetch [My guess is the latest master wasn't pulled down when you applied and tested these] vagrant at kohadevbox:kohaclone(bug_17917)$ git checkout -b bug_17917_v2 origin/master Branch bug_17917_v2 set up to track remote branch master from origin. Switched to a new branch 'bug_17917_v2' vagrant at kohadevbox:kohaclone(bug_17917_v2)$ git bz apply 17920 Bug 17920 - t/db_dependent/Sitemapper.t fails because of permissions 59157 - Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions [This is because Sitemapper is a permissions issue, and not an AddMember issue] vagrant at kohadevbox:kohaclone(bug_17917_v2)$ git bz apply 17917 Bug 17917 - Jenkins tests failing because test suite not logged in user 59029 - Bug 17917: Fix Jenkins for t/db_dependent/Members/IssueSlip.t 59030 - Bug 17917: Fix Jenkinds for t/db_dependent/Holds/LocalHoldsPriority.t 59031 - Bug 17917: Fix Jenkins for t/db_dependent/Letters.t 59039 - Bug 17917: Fix Jenkins for t/db_dependent/Circulation/issue.t 59040 - Bug 17917: Fix Jenkins for t/db_dependent/Circulation/MarkIssueReturned.t 59041 - Bug 17917: Fix Jenkins for t/db_dependent/Members/GetAllIssues.t 59042 - Bug 17917: Fix Jenkins for t/db_dependent/Serials_2.t 59044 - Bug 17917: Fix Jenkin for t/db_dependent/Members/GetOverdues.t 59045 - Bug 17917: Fix Jenkins for t/db_dependent/Members/GetPendingIssues.t 59046 - Bug 17917: Fix Jenkins for t/db_dependent/Circulation/Branch.t 59052 - Bug 17917: Fix Jenkins for t/db_dependent/Reserves.t 59062 - Bug 17917: fix Jenkins for t/db_dependent/Suggestions.t 59175 - Bug 17917: Fix Jenkins for t/db_dependent/Holds.t Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17917: Fix Jenkins for t/db_dependent/Members/IssueSlip.t Applying: Bug 17917: Fix Jenkinds for t/db_dependent/Holds/LocalHoldsPriority.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Letters.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Circulation/issue.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Circulation/MarkIssueReturned.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Members/GetAllIssues.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Serials_2.t Applying: Bug 17917: Fix Jenkin for t/db_dependent/Members/GetOverdues.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Members/GetPendingIssues.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Circulation/Branch.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Reserves.t Applying: Bug 17917: fix Jenkins for t/db_dependent/Suggestions.t Applying: Bug 17917: Fix Jenkins for t/db_dependent/Holds.t vagrant at kohadevbox:kohaclone(bug_17917_v2)$ sudo koha-shell -c "prove t/db_dependent" kohadev [SNIP ok's] t/db_dependent/FrameworkPlugin.t ......................... 1/5 oAuth error: Database unavailable (109) authorities Bib-1 t/db_dependent/FrameworkPlugin.t ......................... ok [This bug is about AddMember triggered errors] [SNIP ok's] t/db_dependent/ILSDI_Services.t .......................... 1/3 Odd number of elements in anonymous hash at /usr/share/koha/lib/C4/ILSDI/Services.pm line 379. Use of uninitialized value in numeric gt (>) at /usr/share/koha/lib/C4/ILSDI/Services.pm line 379. t/db_dependent/ILSDI_Services.t .......................... ok [This is fixed by 17836] [SNIP ok's] t/db_dependent/Koha_Authority.t .......................... 1/? Use of uninitialized value $authid in addition (+) at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 672, line 1. t/db_dependent/Koha_Authority.t .......................... ok [SNIP ok's] t/db_dependent/Reserves.t ................................ 8/72 Use of uninitialized value $tagno in concatenation (.) or string at /usr/share/perl5/MARC/Field.pm line 83. Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 544. # Looks like your test exited with 255 just after 52. t/db_dependent/Reserves.t ................................ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 20/72 subtests [Still not solved yet] [SNIP ok's] t/db_dependent/Search.t .................................. The syspref casAuthentication was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref casLogout was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref casServerUrl was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref template was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. ERROR DECODING RECORD - Tag "50%" is not a valid tag. at /usr/share/perl5/MARC/File/USMARC.pm line 223. : 00295nam a22001217a 450000300040000000500170000400800410002110000180006224500570008050%001100137942001200148999001300160OSt20111207151138.0111207t xxu||||| |||| 00| 0 eng d aGanser, Helen aA record containing a punctuation character as a tag aa note 2ddccBK c214d214 at /usr/share/koha/lib/C4/Search.pm line 680. t/db_dependent/Search.t .................................. 1/4 The syspref template was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. t/db_dependent/Search.t .................................. ok [This bug is about AddMember triggered errors] [SNIP ok's] t/db_dependent/check_sysprefs.t .......................... readline() on closed filehandle $ref_fh at t/db_dependent/check_sysprefs.t line 57. t/db_dependent/check_sysprefs.t .......................... 1/? # Failed test 'Found 0 sysprefs' # at t/db_dependent/check_sysprefs.t line 40. # '-1' # >= # '0' # Looks like you failed 1 test of 2. t/db_dependent/check_sysprefs.t .......................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests [Still not solved yet. Something about intranet config being a /tmp/... directory] [SNIP ok's] Test Summary Report ------------------- t/db_dependent/Reserves.t (Wstat: 65280 Tests: 52 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 72 tests but ran 52. t/db_dependent/check_sysprefs.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=87, Tests=3244, 618 wallclock secs ( 0.66 usr 0.07 sys + 561.44 cusr 28.40 csys = 590.57 CPU) Result: FAIL [As expected just these two fails, because they are not AddMember issues] [However, it would be nice to fix them here] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 04:53:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 03:53:05 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss at gmail.com --- Comment #44 from Luke Honiss --- There are a large amount of conflicts when applying patch which makes it rather difficult to test. If these could be fixed that would help. Cheers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:18:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:18:28 +0000 Subject: [Koha-bugs] [Bug 17939] New: Local Cover Images options not available as Coce Cover images cache options appear instead (non en only) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17939 Bug ID: 17939 Summary: Local Cover Images options not available as Coce Cover images cache options appear instead (non en only) Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: dilan at calyx.net.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 59205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59205&action=edit screenshot Local Cover Images option under Enhanced content tab in System Preferences is displaying settings from Coce Cover images cache option instead of its own. The manual states the settings should instead be: - AllowMultipleCovers - LocalCoverImages - OPACLocalCoverImages There is no option listed at all for Coce Cover images cache. This issue has been observed to disappear when the language is switched to en from en-nz for the staff interface. Please see the attached image for a screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:20:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:20:06 +0000 Subject: [Koha-bugs] [Bug 17939] Local Cover Images options not available as Coce Cover images cache options appear instead (non en only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17939 dilan at calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan at calyx.net.au Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:24:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:24:58 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #25 from M. Tompsett --- Created attachment 59206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59206&action=edit Bug 17917: Fix Cache issue with t/db_dependent/Reserves.t Forcing a cache flush makes the age restriction tests work. TEST PLAN --------- $ sudo koha-shell -c "prove t/db_dependent/Reserves.t" kohadev -- fails -- apply this patch $ sudo koha-shell -c "prove t/db_dependent/Reserves.t" kohadev -- succeeds -- run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:32:38 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15555 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:32:38 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other: u url register when source $2 is uri In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:01 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17318 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:01 +0000 Subject: [Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:22 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:22 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:36 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|dependency | Depends on|15541, 15555, 17318, 15745 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 [Bug 15541] Prevent normalization during matching/import process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? (question mark) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318 [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:36 +0000 Subject: [Koha-bugs] [Bug 15555] Index 024$a into Identifier-other: u url register when source $2 is uri In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15555 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10662 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:36 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10662 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:36 +0000 Subject: [Koha-bugs] [Bug 15745] C4::Matcher gets CCL parsing error if term contains ? ( question mark) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15745 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10662 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:33:36 +0000 Subject: [Koha-bugs] [Bug 17318] Make 'Normalization rule' configurable on matchpoint definition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17318 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10662 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 06:42:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 05:42:59 +0000 Subject: [Koha-bugs] [Bug 17939] Local Cover Images options not available as Coce Cover images cache options appear instead (non en only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17939 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 07:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 06:31:34 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 07:31:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 06:31:37 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #26 from M. Tompsett --- Created attachment 59207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59207&action=edit Bug 17917: Fix path issue in t/db_dependent/check_sysprefs.t C4::Context->config('intranet') is returning different values based on whether it is a full t/db_dependent test or a specific check_sysprefs.t test run. Tests are only run in kohaclone, so it makes no sense to reference config at all. Brought in rel2abs logic to build a reasonable $root_dir. TEST PLAN --------- git checkout master git pull sudo koha-shell -c "prove t/db_dependent" kohadev -- this should have a check_sysprefs.t failure git checkout -b bug_17917 origin/master git bz apply 17920 git bz apply 17917 sudo koha-shell -c "prove t/db_dependent" kohadev -- There should be no issues. -- If there are, it should be intermittent. -- run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 07:55:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 06:55:50 +0000 Subject: [Koha-bugs] [Bug 17837] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss at gmail.com --- Comment #4 from Luke Honiss --- That would probably be a good idea. It is the same file anyway. This patch was created to address the missed duplicates as well as typos so it may be better to close this one and edit 17809 to include all the changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 08:36:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 07:36:42 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 --- Comment #3 from Marcel de Rooy --- (In reply to Emma from comment #2) > Signed-off-by: Emma Smith Thanks, Emma. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 08:44:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 07:44:30 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #27 from Jonathan Druart --- I don't understand why you remove the AddMember calls. AddMember does much more than inserting a row in the borrowers using TestBuilder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 08:51:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 07:51:56 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #15 from Jonathan Druart --- To return $self I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:13:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:13:21 +0000 Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Jonathan Druart --- Hi Emma, CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt First patch does not apply, could you send the patch you rebased please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:13:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:13:34 +0000 Subject: [Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59096|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 59208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59208&action=edit Bug 17925: Disable debugging in reports/bor_issues_top.pl Remove setting $debug to 1. This prevents creation of file tmp/bor_issues_top.debug.log. Enable warnings pragma. Resolve a uninitialized warning on $sep like: Use of uninitialized value $CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66. Test plan: Restart Plack (as you always do when testing). Remove file /tmp/bor_issues_top.debug.log. Open Reports/Patrons with the most checkouts. Check if the file in /tmp has not been created again. Check the log for warnings after you restarted Plack. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:17:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:17:11 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #15 from Oliver Bock --- That's what I meant by "this" :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:29:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:29:38 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #16 from Jonathan Druart --- (In reply to Oliver Bock from comment #15) > That's what I meant by "this" :-) This bug report is assignee to you, so we are waiting for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:34:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:34:40 +0000 Subject: [Koha-bugs] [Bug 17935] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:34:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:34:43 +0000 Subject: [Koha-bugs] [Bug 17935] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 --- Comment #1 from Marcel de Rooy --- Created attachment 59209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59209&action=edit Bug 17935: Adjust some POD lines, fix a few typos This patch does the following: [1] Move some POD lines from Cache to Caches. [2] Correct C4::Plugins to Koha::Plugins in POD line of Koha::Plugins [3] POD Koha/AuthorisedValue.pm: lib_opac moved to opac_description [4] The POD in Koha/Patron.pm uses head2 and head3 inconsistently. Ran s/^=head2/=head3/ on those lines (7 substitutions on 7 lines) [5] Correct a copied POD line from reports/issues_stats.pl in reports/reserve_stats.pl. [6] Correct a test description in t/db_dependent/Koha/Authorities.t. You should never delete the library :) [7] Correct typo shouild in a comment of rebuild_zebra.pl Test plan: [1] Read the patch. Does it make sense? [2] Run perldoc Koha/Cache.pm and Koha/Caches.pm [3] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:35:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:35:17 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |Adjust some POD lines, fix | |a few typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:35:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:35:27 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:35:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:35:57 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #17 from Oliver Bock --- Sorry, but I'm not the patch author. The author should rebase his patch, right? Cheers, Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:40:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:40:53 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #18 from Chris Cormack --- (In reply to Oliver Bock from comment #17) > Sorry, but I'm not the patch author. The author should rebase his patch, > right? > > Cheers, > Oliver Yep thats right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:43:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:43:54 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #19 from Oliver Bock --- Ok, so just to confirm: you're not waiting for me but for Martin. Should the bug thus be assigned to him? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 09:46:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 08:46:59 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oliver.bock at aei.mpg.de |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:01:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:01:59 +0000 Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides AutoLocation security feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569 --- Comment #17 from Jonathan Druart --- Created attachment 59210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59210&action=edit Bug 9569: Update warning message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:08:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:08:29 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #4 from Alex Arnaud --- Hello Jonathan, We plan to work on this bug with Fridolin during our tech camp (30/01 -> 03/02). I'm comfortable with LDAP things and Fridolin with plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:11:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:11:28 +0000 Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides AutoLocation security feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569 --- Comment #18 from Jonathan Druart --- Nick, How did you fill the ip range? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:12:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:12:43 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:12:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:12:47 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58908|0 |1 is obsolete| | Attachment #58909|0 |1 is obsolete| | Attachment #58910|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 59211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59211&action=edit Bug 17894 - Update pay() and use it internally for WriteOffFee Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:12:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:12:52 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #10 from Jonathan Druart --- Created attachment 59212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59212&action=edit Bug 17894 - Add unit tests Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:12:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:12:56 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 --- Comment #11 from Jonathan Druart --- Created attachment 59213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59213&action=edit Bug 17894 - Remove and replace WriteOffFee WriteOffFee is the last of the "payment" subroutines that need to be merged into Koha::Account::pay ( as a writeoff is really just type of payment ). Test Plan: 1) Apply this patch 2) Verify the writeoff, and writeoff all buttons still work Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 10:21:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 09:21:03 +0000 Subject: [Koha-bugs] [Bug 17939] Local Cover Images options not available as Coce Cover images cache options appear instead (non en only) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- If it's language specific, it might be a translation issue. Sometimes something gets into the po files that should not be translated and can cause strange issues. Have you tried to compare the templates? Updating the templates manually might also be a good step (with koha-translate). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:01:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:01:50 +0000 Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides AutoLocation security feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569 --- Comment #19 from Nick Clemens --- (In reply to Jonathan Druart from comment #18) > Nick, How did you fill the ip range? I tried with wildcards and a full IP 11.*.*.* then 11.1.1.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:21:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:21:13 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #6 from Jonathan Druart --- Created attachment 59214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59214&action=edit Bug 17933: Add test and return unless defined dob Without this patch get_age return actually 0 instead of -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:21:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:21:40 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #7 from Jonathan Druart --- Created attachment 59215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59215&action=edit Bug 17933: Do not instanciate a patron if not needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:25:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:25:16 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Hi Dobrica! Since 3.21.00.023 you should not have any 0000-00-00 values in the borrowers table. We should no longer deal with these values in our code. However undef must be handled in the ->get_age method. I also agree with the change in the pl script. Note that these 2 last patches will break again 0000-00-00, will you agree with that? Do you know why you still get these invalid values in DB? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:25:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:25:52 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major --- Comment #9 from Jonathan Druart --- Lowering the severity as it should not happen with valid data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:33:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:33:59 +0000 Subject: [Koha-bugs] [Bug 1442] AutoLocation does not actually work as advertised In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9569 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:33:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:33:59 +0000 Subject: [Koha-bugs] [Bug 9569] IndependentBranches preference overrides AutoLocation security feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=1442 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:50:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:50:27 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:50:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:50:34 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58850|0 |1 is obsolete| | Attachment #58856|0 |1 is obsolete| | --- Comment #345 from Marcel de Rooy --- Created attachment 59216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59216&action=edit Bug 7143: Update history file Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:50:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:50:45 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #346 from Marcel de Rooy --- Created attachment 59217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59217&action=edit Bug 7143: Update about.tt with new devs Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:50:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:50:53 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #347 from Marcel de Rooy --- Created attachment 59218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59218&action=edit Bug 7143: [QA Follow-up] Correcting dates for first patch pushed The date first patch pushed is not the date the patch was written. The Bugzilla reports tell us when the patch got actually pushed. Adjusting the developer numbers accordingly. Authors radiuscz and Radek Siman are actually the same person. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:51:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:51:03 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #348 from Marcel de Rooy --- Created attachment 59219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59219&action=edit Bug 7143: [QA Follow-up] Handling tabs Editing spaces before releases and developer: 876,$s/ \+releases$/^Ireleases/ (20 substitutions) 876,$s/ \+developer$/^Ideveloper/ (7 substitutions on 7 lines) Editing spaces between date and text: 876,$s/2016 \+/2016^I/ 876,$s/2017 \+/2017^I/ Fixed a few single spaces too. Signed-off-by: Marcel de Rooy Display on Timeline tab looks good now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:52:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:52:22 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57619|0 |1 is obsolete| | --- Comment #20 from Alex Arnaud --- Created attachment 59220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59220&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap Signed-off-by: Oliver Bock Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:52:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:52:58 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:53:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:53:03 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #349 from Marcel de Rooy --- Thanks, Rebecca. You are going to be the next new developer! Had to some tweaking in two follow-ups. Take care next time. Combining SO + QA now in this run. Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:54:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:54:01 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #350 from Marcel de Rooy --- If this got pushed, we also need some KohaCons into the history file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 11:57:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 10:57:18 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #21 from Katrin Fischer --- Was it a complex rebase? Maybe we can keep the sign-offs on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:00:24 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #22 from Oliver Bock --- Yes, please. The actual change is a single word :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:01:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:01:16 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:14:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:14:39 +0000 Subject: [Koha-bugs] [Bug 17177] [3.20.x] Can't locate Koha/Config/ SysPrefs.pm in @INC on intranet about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17177 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't locate |[3.20.x] Can't locate |Koha/Config/SysPrefs.pm in |Koha/Config/SysPrefs.pm in |@INC on intranet about page |@INC on intranet about page Status|Passed QA |Pushed to Stable CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- I am changing the status of this patch. It is aimed for 3.20 only. But I do NOT see it in that branch. As far as I know, nobody maintains the version anymore? No use to keep it in the PQA queue for master. Setting the status to Stable, just as if it had been pushed to 3.22. So, the RMaint for 3.20.x should act now ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:15:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:15:10 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:15:35 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:15:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:15:35 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Bug 15894 depends on bug 17894, which changed state. Bug 17894 Summary: Remove and Replace WriteOffFee https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:15:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:15:56 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:15:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:15:57 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Bug 15165 depends on bug 15894, which changed state. Bug 15894 Summary: Unify all account fine payment functions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:15:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:15:57 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Bug 14826 depends on bug 15894, which changed state. Bug 15894 Summary: Unify all account fine payment functions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:22:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:22:06 +0000 Subject: [Koha-bugs] [Bug 17487] Improper placement of select/clear all in Z39.50/ SRU search dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #10 from Marcel de Rooy --- This applies to 16.05, but also to 16.11 or master. Version is set to 16.05. What should be done? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:23:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:23:40 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:24:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:24:20 +0000 Subject: [Koha-bugs] [Bug 17487] Improper placement of select/clear all in Z39.50/ SRU search dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 --- Comment #11 from Marcel de Rooy --- Kyle: should be for master too, as confirmed by Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:27:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:27:09 +0000 Subject: [Koha-bugs] [Bug 17487] Improper placement of select/clear all in Z39.50/ SRU search dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:28:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:28:29 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:30:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:30:10 +0000 Subject: [Koha-bugs] [Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:31:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:31:50 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Version|unspecified |master --- Comment #11 from Marcel de Rooy --- Does not apply ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:35:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:35:00 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:35:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:35:06 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:35:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:35:11 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:35:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:35:38 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |emma.nakamura.smith at gmail.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:35:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:35:49 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #12 from Julian Maurice --- Previous patches were not obsoleted. Sorry for that. This should apply correctly now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:37:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:37:31 +0000 Subject: [Koha-bugs] [Bug 17215] Cardnumbers of patrons created using LDAP Replication not using autoMemberNum if configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17215 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ldjamison at marywood.edu |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:38:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:38:08 +0000 Subject: [Koha-bugs] [Bug 16825] REST API: Add API route for getting an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:39:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:39:13 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:39:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:39:50 +0000 Subject: [Koha-bugs] [Bug 17006] REST API: add route to change patron's password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:40:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:40:20 +0000 Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron ( Single Sign On - SSO) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:40:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:40:54 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:41:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:41:41 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:41:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:41:44 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59145|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 59222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59222&action=edit Bug 17784 Ability to see funds with an amount of 0.00 when doing a new order TEST PLAN 1. Go to the acquisition module and create budget with fund of 0.00 and another fund of 1.00. 2. On acquisitions use a vendor to create a new basket and add an order to that basket. 3.Find a record and order it. 4. Under accounting details the fund with 0 in it won't be visable. 5. Apply patch and refresh, then it should be. Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:41:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:41:47 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |luke.honiss at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:42:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:42:22 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #37 from Josef Moravec --- Dependencies are pushed to master, marking back to need signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:42:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:42:33 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Zoe! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:42:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:42:37 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:46:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:46:46 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:46:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:46:59 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59128|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 59223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59223&action=edit Bug 17771: Add link to bibliographic record on spent/ordered lists in acquisitions ==TEST PLAN== 1) Open Acquisitions and click on the ordered link under the fund 2) There will be no link on the title 3) Go back and click on thespent link 4) There will be no link on the title 5) Apply patch 6) Go to Acquisitions and click on ordered 7) There will now be a link that takes the user to the book catelog page 8) Go back and click on sent 9) There will be a link that takes the user to the book catelog Signed-off-by: Katrin Fischer Works like a charm! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:47:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:47:16 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 --- Comment #6 from Jonathan Druart --- Created attachment 59224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59224&action=edit Bug 17771: aqorders.biblionumber was already part of the query Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:48:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:48:14 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59223|0 |1 is obsolete| | Attachment #59224|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 59225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59225&action=edit Bug 17771: Add link to bibliographic record on spent/ordered lists in acquisitions ==TEST PLAN== 1) Open Acquisitions and click on the ordered link under the fund 2) There will be no link on the title 3) Go back and click on thespent link 4) There will be no link on the title 5) Apply patch 6) Go to Acquisitions and click on ordered 7) There will now be a link that takes the user to the book catelog page 8) Go back and click on sent 9) There will be a link that takes the user to the book catelog Signed-off-by: Katrin Fischer Works like a charm! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:48:21 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 --- Comment #8 from Kyle M Hall --- Created attachment 59226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59226&action=edit Bug 17771 [QA Followup] - Tidy table html Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:51:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:51:05 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:52:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:52:04 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 --- Comment #9 from Jonathan Druart --- Created attachment 59227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59227&action=edit Bug 17771: aqorders.biblionumber was already part of the query Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:54:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:54:28 +0000 Subject: [Koha-bugs] [Bug 17940] New: Holds not going to waiting state after having been transferred Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Bug ID: 17940 Summary: Holds not going to waiting state after having been transferred Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: stefan.berndtsson at ub.gu.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We seem to have found an issue with holds after transfers. Steps to reproduce (everything done by staff): Allow for On shelf holds. Have library branch A and B. Have one biblio with one item located at library A. Have one patron able to have holds placed on them. 1. Place a hold on biblio for patron, select pickup at library B. 2. Check in item on library A (get a transfer notice). 3. Check in item on library B (another transfer notice). 4. Item is not waiting properly on pickup location. If pickup was set to library A (same as item), it would be properly set to waiting. Expected outcome would be that the item is set to waiting at library B. After step 1, the reserves table contains "NULL" in "found" column. After step 2, "found" contains "T" After step 3, "found" still contains "T", where it should really contain "W". This has been tested with both 16.11.00 and 16.11.01. Thank you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:56:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:56:14 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59225|0 |1 is obsolete| | Attachment #59226|0 |1 is obsolete| | Attachment #59227|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 59228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59228&action=edit Bug 17771: Add link to bibliographic record on spent/ordered lists in acquisitions ==TEST PLAN== 1) Open Acquisitions and click on the ordered link under the fund 2) There will be no link on the title 3) Go back and click on thespent link 4) There will be no link on the title 5) Apply patch 6) Go to Acquisitions and click on ordered 7) There will now be a link that takes the user to the book catelog page 8) Go back and click on sent 9) There will be a link that takes the user to the book catelog Signed-off-by: Katrin Fischer Works like a charm! Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:56:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:56:12 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:56:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:56:22 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 --- Comment #11 from Kyle M Hall --- Created attachment 59229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59229&action=edit Bug 17771 [QA Followup] - Tidy table html Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:56:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:56:24 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 --- Comment #12 from Kyle M Hall --- Created attachment 59230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59230&action=edit Bug 17771: aqorders.biblionumber was already part of the query Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:56:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:56:53 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:57:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:57:11 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59184|0 |1 is obsolete| | Attachment #59185|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 59231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59231&action=edit Bug 17891: Remove extra div tag Followup This fixes the menu layout issue. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:58:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:58:28 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |crazy.mental.onion at gmail.co |y.org |m --- Comment #9 from Jonathan Druart --- I removed the first patch as it was wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:58:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:58:46 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |crazy.mental.onion at gmail.co |m |m QA Contact|crazy.mental.onion at gmail.co |jonathan.druart at bugs.koha-c |m |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 12:59:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 11:59:41 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Luke! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:01:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:01:11 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:01:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:01:27 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59191|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 59232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59232&action=edit Bug 17931: Remove unused vars from reserves_stats Change to Modern::Perl. Remove null_to_zzempty and add a few blank lines between subs. Remove unused vars: $podsp, $type, $daysel, $monthsel and $mime. Removing trailing 1; Test plan: Run a few reports from reports/reserves_stats.pl Signed-off-by: Marcel de Rooy Signed-off-by: Emma Smith Signed-off-by: Jonathan Druart Wrongly pasted from reports/issues_stats.pl initially -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:03:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:03:30 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:03:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:03:33 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59132|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 59233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59233&action=edit Bug 17924 - Fix error in password recovery To test: - Set OpacResetPassword = allowed - Make sure you have a user with a username and email - Go to the OPAC and make sure you are not logged in - Click on the "Forgot your password?" link - Fill in "Login" and "Email" and click on "Submit" - You will get an error that says: Undefined subroutine &C4::Letters::GetPreparedLetter called at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 142. - Apply the patch - The steps above will have added your user to the borrower_password_recovery table in the database. Delete it from there to make sure you start a fresh reset request. - Repeat the steps above and notice that the error is gone. You should get a nice message instead that says "An email has been sent to [your email]". - Sign off Signed-off-by: Zoe Schoeler Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:04:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:04:26 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- I don't actually get the error, but better to add the use explicitly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:05:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:05:19 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:05:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:05:22 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59143|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 59234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59234&action=edit Bug 5784 - link to aq from budgets & funds 1. Go to /cgi-bin/koha/admin/aqbudgets.pl and notice that there is no link to the aq home, there are other aq links but not back to the home 2. Apply the patch 3. Reload the page and notice there is link Signed-off-by: Claire Gravely Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:05:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:05:29 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 --- Comment #4 from Kyle M Hall --- Created attachment 59235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59235&action=edit Bug 5784 [QA Followup] - Move link to breadcrumbs Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:05:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:05:55 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Grace! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:05:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:05:54 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- There is a test just after, if true the "circ-hlt" class name will be used. I guess we want the 2 new classes in any cases. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:06:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:06:32 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 --- Comment #5 from Jonathan Druart --- Emma, you should also change the author's name of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:06:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:06:53 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:08:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:08:34 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:08:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:08:36 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59131|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 59236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59236&action=edit Bug 17823: Add label for MARC 583 - Action note test plan Edit a record Edit field 583a to add an action note Save the record and confirm that the note does not show up in staff client or opac Apply patch and refresh page Action note should now show up in staff client and opac Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:09:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:09:11 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Karen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:14:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:14:11 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Hello Caitling, we have the same problem at the OPAC, could you fix it as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:14:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:14:21 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:24:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:24:45 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59231|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 59237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59237&action=edit Bug 17891: Remove extra div tag in the housebound module This fixes the menu layout issue. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:45:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:45:27 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall --- Pushed to master for Koha 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:46:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:46:09 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 13:59:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 12:59:13 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart --- Does not work for me: sudo koha-mysql kohadev < installer/data/mysql/fr-CA/obligatoire/sample_notices.sql ERROR 1062 (23000) at line 1: Duplicate entry 'circulation-CHECKIN--email' for key 'PRIMARY' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:04:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:04:27 +0000 Subject: [Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:04:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:04:30 +0000 Subject: [Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59038|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 59238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59238&action=edit Bug 17731: Remove noxml option from rebuild_zebra.pl The removal of the noxml is a logical follow-up of bug 16506 (which make xml the default). Actually this option should have been removed by bug 10455 (it removes the biblioitem.marc field). Test plan: Make sure the rebuild_zebra.pl script works as before. Signed-off-by: Emma Smith Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:04:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:04:47 +0000 Subject: [Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:14:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:14:49 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57843|0 |1 is obsolete| | --- Comment #38 from Josef Moravec --- Created attachment 59239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59239&action=edit Bug 15165 - Add API route to list accountlines GET /accountlines (list) GET /accountlines?borrowernumber=X (list) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Go to http://yourlibrary/api/v1/accountlines?borrowernumber=XXX (replace XXX with a borrowernumber that has accountlines) and check you receive correct data 3. Go to http://yourlibrary/api/v1/accountlines and check that you receive all accountlines 4. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:14:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:14:55 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57844|0 |1 is obsolete| | --- Comment #39 from Josef Moravec --- Created attachment 59240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59240&action=edit Bug 15165 - Add API route to edit accountlines PUT /accountlines/{accountlines_id} (edit) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission updatecharges. 2. Send PUT request to http://yourlibrary/api/v1/accountlines/YYY where YYY is one of your accountlines_id. See the body definition in definitions/editAccountlineBody.json and use this in your PUT request. 3. Run unit tests in t/db_dependent/api/v1/accountlines.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:15:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:15:00 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57845|0 |1 is obsolete| | --- Comment #40 from Josef Moravec --- Created attachment 59241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59241&action=edit Bug 15165 - Add API routes to pay accountlines POST /accountlines/(:accountlines_id)/payment (pay towards accountline) POST /patrons/(:borrowernumber)/payment (pay towards borrower) Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You must have permission updatecharges. 2. Create a fine to any patron and get the accountlines_id. 3. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment without body where YYY is the accountlines_id you created in step 2. 4. Check that the accountline that you created in step 2 is paid. 5. Create two payments with amount 5.00 (with no other outstanding payments) 6. Send POST request to http://yourlibrary/api/v1/patrons/ZZZ/payment with body {"amount": 10} Replace ZZZ with the borrowernumber for which you have created two fines 7. Check that the two accountlines are paid. 8. Repeat step 2. 9. Send POST request to http://yourlibrary/api/v1/accountlines/YYY/payment with body {"amount": XXX} Replace YYY with the accountlines_id you created in step 8. Set amount (XXX) to the half of the amount of the fine you created in step 8. 10. Check that the fine is still outstanding with half of the original amount. 11. Run unit tests at t/db_dependent/api/v1/accountlines.t and t/db_dependent/api/v1/patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:15:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:15:07 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57846|0 |1 is obsolete| | --- Comment #41 from Josef Moravec --- Created attachment 59242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59242&action=edit Bug 15165: followup - fix definitions, and passing amount parameter in pay method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:15:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:15:19 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 --- Comment #42 from Josef Moravec --- Just a rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:25:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:25:22 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:28:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:28:25 +0000 Subject: [Koha-bugs] [Bug 17941] New: CanBookBeRenewed is very inefficient/slow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Bug ID: 17941 Summary: CanBookBeRenewed is very inefficient/slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I started investigating why populating the checkout list in the patron view sometimes took ages (minutes), and on occations even causing the system to almost halt because of DB overload. It turned out that reason is calls to C4::Circulation::CanBookBeRenewed. The critical factor is whether an item has many holds on it, and if there are many items that can fill the hold. Briefly looking at the code it seems obvious that the time spent grows exponentially with the number of holds and items. As one example, checking if an item with 111 holds (and 12 items on the biblio) can be renewed takes around 25 sec and generates over 18,000 SQL queries. I can't help to think there must be some missed "early returns" opportunities in the loops somewhere. For example, if there are more unfulfilled holds than available items, can the item ever be renewed? If no, return before even begin to calculate.. However, I know holds are full of complexities and things I probably haven't thought about so I need to dig into the code more. I would be very gratefull if anyone knowledgeable about this part of the code could help me find some ways to optimize this! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:28:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:28:43 +0000 Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59144|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 59243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59243&action=edit Bug 8266 - remove location from pulldown Found shelving location in html and removed To test - Go to the advanced search in the OPAC - Click on 'more options' (this changes the pull downs) - Check the pull downs with search options, there is now "shelving location" - Apply the patch - Refresh the page and notice the option is gone Signed-off-by: Claire Gravely Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:28:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:28:41 +0000 Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:29:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:29:23 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:29:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:29:29 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59178|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 59244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59244&action=edit Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details Signed-off-by: Katrin Fischer Fixed a missing Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:29:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:29:37 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 --- Comment #8 from Jonathan Druart --- Created attachment 59245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59245&action=edit Bug 17691: Does not repeat "subscriptions" Number of subscriptions: X subscriptions Sound like we repeat "subscriptions" Replaced with Number of subscriptions: X Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:33:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:33:38 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:33:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:33:51 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59125|0 |1 is obsolete| | Attachment #59126|0 |1 is obsolete| | Attachment #59127|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 59246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59246&action=edit Bug 17469: Add missing sample notices fr-CA test Add fr-CA installer to xt/sample_letter.t To test: - Verify xt/sample_letter.t test checks fr-CA now and fails for just fr-CA. Signed-off-by: Mark Tompsett Signed-off-by: Caitlin Goodger Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:34:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:34:05 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #28 from Jonathan Druart --- Created attachment 59247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59247&action=edit Bug 17469: Add missing sample notices to fr-CA web installer Adds missing notices to the fr-CA web installer: - MEMBERSHIP_EXPIRY - PASSWORD_RESET Renames RESERVESLIP to HOLD_SLIP TEST PLAN --------- 1) Apply the first patch 2) prove xt/sample_notices.t -- it should fail for fr-CA. 3) Apply the second patch 4) prove xt/sample_notices.t -- it should pass. 5) run all tests (prove t; prove xt) -- they should generally pass 6) run koha qa test tools NOTE: Split test patch from fix patch, so could prove problem exists easily. Signed-off-by: Mark Tompsett Signed-off-by: Caitlin Goodger Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:34:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:34:19 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #29 from Jonathan Druart --- Created attachment 59248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59248&action=edit Bug 17469: Follow-up adding hold print notice Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:34:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:34:33 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #30 from Jonathan Druart --- Created attachment 59249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59249&action=edit Bug 17469: Fix number of values Will fix ERROR 1136 (21S01) at line 57: Column count doesn't match value count at row 2 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:35:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:35:11 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #26) > Does not work for me: > > sudo koha-mysql kohadev < > installer/data/mysql/fr-CA/obligatoire/sample_notices.sql > ERROR 1062 (23000) at line 1: Duplicate entry 'circulation-CHECKIN--email' > for key 'PRIMARY' Fixed with the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:35:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:35:32 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:35:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:35:35 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 --- Comment #6 from Kyle M Hall --- Created attachment 59250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59250&action=edit Bug 15460 Adding spaces after subfields c and h of 245 Test Plan 1: Add something inside c and h of 245 on a Bibliographic Record. There won't be a space between the c and h 2: This will occur on both the search results and the details pages of the record in both the intranet and opac. 3: Apply the patch 4: Refresh and see that there is now a space between c and h. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:35:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:35:55 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall --- Pushed to master for 17.05, thanks Caitlin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:36:13 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59122|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:37:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:37:20 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall --- Pushed to master for 17.05, thanks Grace! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:37:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:37:47 +0000 Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall --- Pushed to master for Koha 17.05, thanks Grace! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:38:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:38:45 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #32 from Kyle M Hall --- Pushed to master for Koha 17.05, thanks Katrin, Caitlin, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:41:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:41:54 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #351 from Kyle M Hall --- 4 patches pushed to master, thanks Marcel, Rebecca! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:42:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:42:09 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59219|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:42:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:42:13 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59218|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:42:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:42:18 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:42:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:42:22 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59216|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:50:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:50:10 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #104 from Owen Leonard --- I notice that onboarding.pl has a lot of SQL operations. This is a violation of our coding guidelines: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts I also notice that there are quite a lot of "use" statements at the top of that script. Are they all really necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:55:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:55:32 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #23 from Jonathan Druart --- Alex, 1 test fail for me: t/db_dependent/Auth_with_ldap.t .. 1/4 # Failed test 'Mapped attribute is BAR' # at t/db_dependent/Auth_with_ldap.t line 199. # got: undef # expected: 'BAR' # Looks like you failed 1 test of 9. # Failed test 'auth_by_bind = 1 tests' # at t/db_dependent/Auth_with_ldap.t line 243. # Looks like you failed 1 test of 4. # Failed test 'checkpw_ldap tests' # at t/db_dependent/Auth_with_ldap.t line 309. # Looks like you failed 1 test of 4. Does it pass for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:57:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:57:11 +0000 Subject: [Koha-bugs] [Bug 17942] New: Update style of the web installer with Bootstrap 3 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Bug ID: 17942 Summary: Update style of the web installer with Bootstrap 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 17855 I'm working on a markup and style overhaul of the web installer and the new onboarding templates. One preliminary screenshot: http://zivotdesign.com/p/#1/14847560123053 I'm hoping that this patch and those for Bug 17855 can be (eventually) pushed at the same time. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 14:57:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 13:57:11 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 [Bug 17942] Update style of the web installer with Bootstrap 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:08:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:08:13 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:08:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:08:24 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59136|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59251&action=edit Bug 17899 - Show only mine does not work in newordersuggestion.pl Bug 12775 added a link "Show only mine" in newordersuggestion.pl. This does not work, no results. Also corrects the fact that click must not do default action by adding e.preventDefault(). Test plan : - You must have suggestions you have accepted - Create a new order from suggestion : /cgi-bin/koha/acqui/newordersuggestion.pl - Click on Show only mine => Without patch the table is empty showing "No matching records found" => With patch you see only suggestions you have accpeted Signed-off-by: Zoe Schoeler Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:10:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:10:55 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I am sure the link used to work. I don't know for how long it has been broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:13:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:13:23 +0000 Subject: [Koha-bugs] [Bug 15702] Trim whitespace from patron details upon submission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:19:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:19:37 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53546|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 59252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59252&action=edit Bug 15545: Add routine IsHoldNoteRequired to Reserves module This routine will be used to determine if a hold note is required. In the current approach this is implemented by use of Koha plugins. A former approach included a syspref. This is no longer needed. This approach is even more flexible. The routine will use all plugins it finds with metadata tag 'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a check method that returns true, the hold note should be regarded as required. The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an implementation where the value of the leader or MARC21 300$a determines if the hold note is required. Similarly, any other field of the bibliographic record could be used in a new plugin. Test plan: Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:19:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:19:42 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53547|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy --- Created attachment 59253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59253&action=edit Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl This patch implements use of the new Reserves routine IsHoldNoteRequired, making it possible to require a note when placing a hold. Only a very small change in opac-reserve.pl is needed. As well as corresponding changes in the template. I am removing some unused template code related to a former approach. Test plan: [1] Disable UseKohaPlugins, enable OpacHoldNotes. [2] Place a hold on a serial record (leader pos 7 == s). Verify that the hold note is not required. [3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins. (Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz. This file can be found as an attachment to this BZ report.) [4] Again place a hold on a serial record. The hold note should be required. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:20:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:20:10 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #36 from Marcel de Rooy --- Rebase for C4/Reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:24:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:24:49 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #24 from Alex Arnaud --- (In reply to Jonathan Druart from comment #23) > Alex, 1 test fail for me: > > t/db_dependent/Auth_with_ldap.t .. 1/4 > # Failed test 'Mapped attribute is BAR' > # at t/db_dependent/Auth_with_ldap.t line 199. > # got: undef > # expected: 'BAR' > # Looks like you failed 1 test of 9. > > # Failed test 'auth_by_bind = 1 tests' > # at t/db_dependent/Auth_with_ldap.t line 243. > # Looks like you failed 1 test of 4. > > # Failed test 'checkpw_ldap tests' > # at t/db_dependent/Auth_with_ldap.t line 309. > # Looks like you failed 1 test of 4. > > Does it pass for you? Yes it passes successfully. Weird you got this, all seems to be mocked as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:30:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:30:28 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #25 from Alex Arnaud --- (In reply to Alex Arnaud from comment #24) > (In reply to Jonathan Druart from comment #23) > > Alex, 1 test fail for me: > > > > t/db_dependent/Auth_with_ldap.t .. 1/4 > > # Failed test 'Mapped attribute is BAR' > > # at t/db_dependent/Auth_with_ldap.t line 199. > > # got: undef > > # expected: 'BAR' > > # Looks like you failed 1 test of 9. > > > > # Failed test 'auth_by_bind = 1 tests' > > # at t/db_dependent/Auth_with_ldap.t line 243. > > # Looks like you failed 1 test of 4. > > > > # Failed test 'checkpw_ldap tests' > > # at t/db_dependent/Auth_with_ldap.t line 309. > > # Looks like you failed 1 test of 4. > > > > Does it pass for you? > > Yes it passes successfully. Weird you got this, all seems to be mocked as > expected. Oops, using another database (the one provided by BZ 10337) it don't pass anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:43:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:43:42 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53602|0 |1 is obsolete| | Attachment #53603|0 |1 is obsolete| | Attachment #53604|0 |1 is obsolete| | Attachment #53605|0 |1 is obsolete| | Attachment #53607|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 59254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59254&action=edit Bug 14826 - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:43:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:43:48 +0000 Subject: [Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults less greedy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Pushed to 3.22.x for 3.22.15 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:43:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:43:39 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:43:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:43:50 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #18 from Kyle M Hall --- Created attachment 59255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59255&action=edit Bug 14826 - Add Koha modules for offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:43:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:43:56 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #20 from Kyle M Hall --- Created attachment 59257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59257&action=edit Bug 14826 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:43:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:43:53 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #19 from Kyle M Hall --- Created attachment 59256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59256&action=edit Bug 14826 - Resurrect account offsets table The account offsets table should be used to track increments and decrements of fines via payments and credits, as well as fine accruals. It should be able to match fees to payments and visa versa, so we can know which fee was paid by a given payment, and which payments applied to a given fee. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Note the table accountoffsets has been renamed to account_offsets 4) Ensure fine generation creates offsets 5) Ensure creating a manual invoice creates an offset 6) Ensure a lost item charge creates an offset 7) Ensure Reverse Payment creates an offset 8) Ensure a payment creates an offset 9) Ensure a payment for multiple fees creates an offset for each 10) Ensure writeoffs create offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:44:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:44:00 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #21 from Kyle M Hall --- Created attachment 59258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59258&action=edit Bug 14826 - Update table schemas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:46:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:46:08 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #11 from M. Tompsett --- Created attachment 59259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59259&action=edit Bug 17809: Add upgrade warning messages TEST PLAN --------- 0) backup db 1) drop db and recreate empty 2) run fr-FR web install 3) update systempreferences set Value='16.00003' where variable='Version'; -- it is currently 16.00004 as of this writing 4) run fr-FR web install -- bottom of red warnings should be the check messages. 5) perlcritic -1 installer/data/mysql/atomic_update/bug_17809_pretty_red.perl -- $VERSION message, which we don't care about -- maybe a message about return value of print ignored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:46:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:46:10 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #352 from Marcel de Rooy --- Created attachment 59260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59260&action=edit Bug 7143: Replace Santallan by Santellan Missed one typo in about.tt. Can go along with the next patch here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:46:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:46:18 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #12 from M. Tompsett --- Created attachment 59261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59261&action=edit Bug 17809 correct authorisation values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:46:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:46:35 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58577|0 |1 is obsolete| | --- Comment #13 from M. Tompsett --- Created attachment 59262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59262&action=edit Bug 17809 - ER country twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythr?e" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / Erythr?e NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:47:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:47:29 +0000 Subject: [Koha-bugs] [Bug 17837] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17837 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #5 from M. Tompsett --- As per Jonathan's suggestion in comment #3, I've moved this to bug 17809. *** This bug has been marked as a duplicate of bug 17809 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:47:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:47:29 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #14 from M. Tompsett --- *** Bug 17837 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:48:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:48:17 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59220|0 |1 is obsolete| | --- Comment #26 from Alex Arnaud --- Created attachment 59263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59263&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:49:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:49:12 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:49:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:49:35 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from M. Tompsett --- The first patch written by me needs signing off. The second patch written by me was signed off by Luke Honiss. The third patch written by Fridolin SOMERS was signed off by me. In short, I am setting this to needs sign off, because of the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:50:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:50:04 +0000 Subject: [Koha-bugs] [Bug 17809] ER country twice in fr-FR database files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:50:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:50:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #353 from Tom?s Cohen Arazi --- On 2017-01-10 15:53, Patricio Marrone got his first couple commits and is missing from history.txt, thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 15:52:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 14:52:34 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ER country twice in fr-FR |Correct some authorised |database files |values in fr-FR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:09:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:09:21 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:22:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:22:09 +0000 Subject: [Koha-bugs] [Bug 17799] MARC bibliographic frameworks breadcrumbs broken for Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17799 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Pushed to 3.22.x for 3.22.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:22:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:22:42 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59263|0 |1 is obsolete| | --- Comment #27 from Alex Arnaud --- Created attachment 59264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59264&action=edit Bug 17615 - Fix updating borrower attributes in checkpw_ldap Signed-off-by: Oliver Bock Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:22:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:22:49 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #28 from Alex Arnaud --- Created attachment 59265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59265&action=edit Bug 17615 - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:26:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:26:02 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59265|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 59266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59266&action=edit Bug 17615 - Fix unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:27:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:27:14 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #30 from Jonathan Druart --- I confirm that the tests now pass. If the patch was ok before the rebase, it must still be. Passing QA, trusting author and previous signoffs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:27:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:27:21 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:31:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:31:25 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #18 from Julian Maurice --- Pushed to 3.22.x for 3.22.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:33:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:33:11 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59167|0 |1 is obsolete| | Attachment #59168|0 |1 is obsolete| | Attachment #59169|0 |1 is obsolete| | Attachment #59170|0 |1 is obsolete| | --- Comment #16 from Mehdi Hamidi --- Created attachment 59267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59267&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:33:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:33:08 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:33:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:33:27 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #17 from Mehdi Hamidi --- Created attachment 59268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59268&action=edit Bug 17015 - Tests for DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:33:35 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #18 from Mehdi Hamidi --- Created attachment 59269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59269&action=edit Bug 17015 - Koha now uses the new DiscreteCalendar module C4/Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:33:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:33:41 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #19 from Mehdi Hamidi --- Created attachment 59270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59270&action=edit Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:33:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:33:54 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #20 from Mehdi Hamidi --- Created attachment 59271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59271&action=edit Bug 17015 - Peformance tests for Koha::DiscreteCalendar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:44:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:44:27 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #21 from Mehdi Hamidi --- Hello everyone, I fixed the problems mentioned by Josef Moravec above, thank you once again! Also, you no longer need to have valid branchcodes to run tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 16:50:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 15:50:56 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #62 from Julian Maurice --- Pushed to 3.22.x for 3.22.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 17:18:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 16:18:28 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #24 from Barton Chittenden --- (In reply to paxed from comment #6) > "Title" - is this the title of a book? (usually it is) ...or does it mean > the name of a holiday? (as it is in the holidays calendar) There's also a title in the borrowers table -- as in "Mr.", "Mrs.", "Dr." etc. I don't think that this is likely to cause problems with translation; the context is entirely different, but it's annoying when you join borrowers to a query that already has "title" in the select statement, and suddenly need to qualify that... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 17:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 16:33:03 +0000 Subject: [Koha-bugs] [Bug 17943] New: "make test" failed when upgrading from koha-3.22.10 to 3-22.14 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Bug ID: 17943 Summary: "make test" failed when upgrading from koha-3.22.10 to 3-22.14 Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: michael.r.gendy at gmail.com QA Contact: testopia at bugs.koha-community.org /Downloads/koha-3.22.14$ make test PERL_DL_NONLAZY=1 KOHA_CONF=blib/KOHA_CONF_DIR/koha-conf.xml /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/PERL_MODULE_DIR', 'blib/arch')" t/*.t t/00-checkdatabase-version.t ........ ok t/00-deprecated.t ................... ok t/00-load.t ......................... Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.18/fields.pm line 135. Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.18/fields.pm line 135. Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.18/fields.pm line 135. DBIx::Class::Storage::DBI::_warn_undetermined_driver(): This version of DBIC does not yet seem to supply a driver for your particular RDBMS and/or connection method ('Mock'). While we will attempt to continue anyway, the results are likely to be underwhelming. Please upgrade DBIC, and if this message does not go away, file a bugreport including the following info: { DBIC_DRIVER => "DBIx::Class::Storage::DBI", DBIC_DSN => "DBI:Mock:", DBIC_VER => "0.08250", DBI_VER => "1.63" } DBIx::Class::Storage::DBI::sql_maker(): Your storage class (DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI' at /home/koha-admin/Downloads/koha-3.22.14/blib/PERL_MODULE_DIR/Koha/Objects.pm line 83 t/00-load.t ......................... 9/? Subroutine main::checkauth redefined at /usr/share/perl/5.18/Exporter.pm line 66. at t/00-load.t line 47. Subroutine main::get_template_and_user redefined at /usr/share/perl/5.18/Exporter.pm line 66. at t/00-load.t line 47. "my" variable $DEBUG masks earlier declaration in same scope at /home/koha-admin/Downloads/koha-3.22.14/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 43. "my" variable $DEBUG masks earlier declaration in same scope at /home/koha-admin/Downloads/koha-3.22.14/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 85. # Failed test 'use Koha::AudioAlert;' # at t/00-load.t line 63. # Tried to use 'Koha::AudioAlert'. # Error: Can't locate Koha/Patron/Modifications.pm in @INC (you may need to install the Koha::Patron::Modifications module) (@INC contains: /home/koha-admin/Downloads/koha-3.22.14/blib/PERL_MODULE_DIR /home/koha-admin/Downloads/koha-3.22.14/blib/arch /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl . /var/lib/koha/plugins) at /home/koha-admin/Downloads/koha-3.22.14/blib/PERL_MODULE_DIR/Koha/AudioAlert.pm line 26. # BEGIN failed--compilation aborted at /home/koha-admin/Downloads/koha-3.22.14/blib/PERL_MODULE_DIR/Koha/AudioAlert.pm line 26. # Compilation failed in require at t/00-load.t line 63. # BEGIN failed--compilation aborted at t/00-load.t line 63. Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::AudioAlert' FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::AudioAlert' make: *** [test_dynamic] Error 255 system details 4.4.0-59-generic #80~14.04.1-Ubuntu SMP Fri Jan 6 18:02:02 UTC 2017 x86_64 MySQL version: mysql Ver 14.14 Distrib 5.5.53, for debian-linux-gnu (x86_64) using readline 6.3 Perl version: 5.018002 all perl's packages looks fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 17:35:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 16:35:54 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Michael changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"make test" failed when |"make test" failed when |upgrading from koha-3.22.10 |upgrading from koha-3.22.10 |to 3-22.14 |to 3-22.14 , also fresh | |installation of | |koha-3.22.14 made the same | |"make test" failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 17:48:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 16:48:34 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #28 from M. Tompsett --- Looking at trimming some of my overzealous efforts. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:02:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:02:42 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59029|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:02:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:02:47 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:02:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:02:54 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59031|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:03:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:03:19 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59039|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:03:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:03:30 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59040|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:03:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:03:40 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:03:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:03:50 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:03:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:03:59 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59044|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:04:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:04:10 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59045|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:04:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:04:21 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:04:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:04:31 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:04:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:04:47 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:14:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:14:34 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58819|0 |1 is obsolete| | Attachment #58820|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall --- Created attachment 59272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59272&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:14:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:14:42 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #46 from Kyle M Hall --- Created attachment 59273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59273&action=edit Bug 12461 [QA Followup] - Changes based on suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:36:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:36:56 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59052|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:37:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:37:07 +0000 Subject: [Koha-bugs] [Bug 17917] Jenkins tests failing because test suite not logged in user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:38:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:38:31 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Jenkins tests failing |t/db_dependent/check_syspre |because test suite not |fs.t fails on kohadev |logged in user |strangely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 18:46:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 17:46:07 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 --- Comment #25 from Katrin Fischer --- > (In reply to paxed from comment #6) > > "Title" - is this the title of a book? (usually it is) ...or does it mean > > the name of a holiday? (as it is in the holidays calendar) > > There's also a title in the borrowers table -- as in "Mr.", "Mrs.", "Dr." > etc. I don't think that this is likely to cause problems with translation; > the context is entirely different, but it's annoying when you join borrowers > to a query that already has "title" in the select statement, and suddenly > need to qualify that... The problem is, that there is no context in translation. A string like "Title: " could mean all 3 things, but we'd like to translate it differently. This is currently not possible - you can only have one translation for identical strings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 19:34:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 18:34:19 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 19:34:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 18:34:22 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59207|0 |1 is obsolete| | --- Comment #29 from M. Tompsett --- Created attachment 59274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59274&action=edit Bug 17917: Fix path issue in t/db_dependent/check_sysprefs.t C4::Context->config('intranet') is returning different values based on whether it is a full t/db_dependent test or a specific check_sysprefs.t test run. Tests are only run in kohaclone, so it makes no sense to reference config at all. Brought in rel2abs logic to build a reasonable $root_dir. TEST PLAN --------- -- on a kohadevbox sudo apt-get update sudo apt-get upgrade -- need to make sure the koha-commonpackage is more current git checkout master git pull sudo koha-shell -c "prove t/db_dependent" kohadev -- this should have a check_sysprefs.t failure sudo koha-shell -c "prove t/db_dependent/check_sysprefs.t" kohadev -- this should strangely pass git checkout -b bug_17917 origin/master git bz apply 17917 sudo koha-shell -c "prove t/db_dependent" kohadev -- there will not be a check_sysprefs.t failure sudo koha-shell -c "prove t/db_dependent/check_sysprefs.t" kohadev -- this should pass -- run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 19:48:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 18:48:44 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- (In reply to Marcel de Rooy from comment #5) > Karen: do not change the assignee please. Thanks. Ahh I told them too, because they weren't getting any mail otherwise. I wanted them to get the emails telling them they were pushed, there is a bug somewhere in bugzilla at the moment when you attach a patch you dont get added to the cc. (Of course the patch author is what really matters I guess) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:15:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:15:34 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #105 from Alex Buckley --- (in reply to Owen Leonard in comment 104) When writing this script I noticed that several of the administration scripts (itemtypes.pl (to create an item type)and smart-rules.pl ( to create a circulation rule)) had significant amounts of sql in them. Therefore what I am planning to do is if we can get this patch signed off I will have time to be able to go through and move the sql code from the onboarding.pl, itemtypes.pl, and smart-rules.pl. Additionally in that second patch I would be able to go through and see which of the 'use's I can remove from onboarding.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:21:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:21:09 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:21:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:21:12 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #1 from Owen Leonard --- Created attachment 59275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59275&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:26:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:26:36 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17944 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 [Bug 17944] Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:26:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:26:36 +0000 Subject: [Koha-bugs] [Bug 17944] New: Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Bug ID: 17944 Summary: Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 17855 After the bug 17855 is signed off then writing a patch for this bug can start. The aim of this bug is to remove all sql code from onboarding.pl, smart-rules.pl and itemtypes.pl scripts. Additionally all unnecessary use pragmas in the onboarding.pl script will be removed. This will make all three of the aforementioned perl scripts meet the Koha coding guidelines. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:29:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:29:06 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:29:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:29:16 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:29:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:29:29 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #106 from Alex Buckley --- I have written this bug report (bug 17944) which I will work on immediately after this bug (17855) is signed off. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:29:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:29:45 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |luke.honiss at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:30:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:30:31 +0000 Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined value at C4/ Search.pm line 806 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123 --- Comment #11 from gabrielo --- Hi, Yes, look: sudo apt-get update sudo koha-rebuild-zebra -f -v sudo service apache2 restart But, the update is not done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:53:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:53:02 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #107 from M. Tompsett --- Can we push this through first, and then discuss what to fix on it in another bug? I'm almost done my sign off testing. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 20:55:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 19:55:44 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- This looks fine, it just needs one small change. You don't need to define MSG_CONFIRM_CANCEL_HOLD in your patch because MSG_CONFIRM_DELETE_HOLD is already defined at the top. You can use MSG_CONFIRM_DELETE_HOLD instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:02:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:02:43 +0000 Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined value at C4/ Search.pm line 806 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123 --- Comment #12 from Tom?s Cohen Arazi --- (In reply to gabrielo from comment #11) > Hi, > > Yes, look: > > sudo apt-get update > sudo koha-rebuild-zebra -f -v > sudo service apache2 restart > > But, the update is not done. sudo koha-rebuild-zebra -f -a -b -v $(koha-list) Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:03:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:03:35 +0000 Subject: [Koha-bugs] [Bug 17928] Updating sounds for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17928 --- Comment #4 from Emma --- Hi Katrin, nothing to look out for, just changed up the alert sounds for a more pleasant Koha experience. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:06:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:06:18 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59203|0 |1 is obsolete| | --- Comment #8 from Luke Honiss --- Created attachment 59276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59276&action=edit Bug 11450: Hold Request Confirm Deletion ==TEST PLAN== 1) Go to an item with a hold and click on the holds tab on the left 2) Click the red 'X' 3) The hold will be deleted immediately 4) Apply patch 5) Return to an item with a hold and click the 'X' 6) There will now be a confirmation dialog 7) Click cancel and the dialog will disappear and the hold will not be deleted 8) Click OK and the hold will be deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:06:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:06:14 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:07:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:07:37 +0000 Subject: [Koha-bugs] [Bug 17945] New: Breadcrumbs broken on opac-serial-issues.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17945 Bug ID: 17945 Summary: Breadcrumbs broken on opac-serial-issues.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To see bug: Set up a subscription with a record Go to that record page in OPAC Click Subscriptions tab, then 'More details' Notice breadcrumbs are missing the record title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:16:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:16:50 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58895|0 |1 is obsolete| | Attachment #58896|0 |1 is obsolete| | Attachment #58897|0 |1 is obsolete| | Attachment #58898|0 |1 is obsolete| | Attachment #58899|0 |1 is obsolete| | Attachment #58900|0 |1 is obsolete| | Attachment #58903|0 |1 is obsolete| | Attachment #58904|0 |1 is obsolete| | Attachment #58907|0 |1 is obsolete| | Attachment #59037|0 |1 is obsolete| | --- Comment #108 from M. Tompsett --- Created attachment 59277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59277&action=edit [SIGNED-OFF] Bug 17855 - Other followups - Removed the html regex from the cardnumber field in the 'Create patron administrator' page of the onboarding tool. Added '|html' into the the value attribute of the cardnumber input field to filter the inputted cardnumber. So now the same level of validation exists for validating the inputted cardnumber in the staff interface and the onboarding tool. - Removed the unnecessary javascript cardnumber validation code from onboardingstep3.tt - Removed HTML regexes from all fields on all screens of onboarding tool except branchcode, patron category code and item type code. Also ensured these three remaining regexes are all {1,10} for length as they are all required. - Added |html and added in input title attribute to input fields where it existed previously Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:17:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:17:00 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:17:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:17:03 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58127|0 |1 is obsolete| | --- Comment #5 from Gracie --- Created attachment 59278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59278&action=edit Bug 16387: Fix default shortened loan period time When a loan period is shortened due to using decreaseLoanHighHolds* the time is always set to the current time in X days, even if the original loan period is given in days and not in hours. It should default to 23:59 as is normal for loan periods given in days. As original due date time defaults to 23:59 when given in days, this patch modifies the hours and minutes of shortened due date to be equal to original due date. To test: 1. prove t/db_dependent/DecreaseLoanHighHolds.t Signed-off-by: Grace McKenzie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:17:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:17:51 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com --- Comment #6 from Gracie --- The test plan passed for me t/db_dependent/DecreaseLoanHighHolds.t .. ok All tests successful. Files=1, Tests=14, 4 wallclock secs ( 0.05 usr 0.01 sys + 3.42 cusr 0.14 csys = 3.62 CPU) Result: PASS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:18:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:18:05 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59277|0 |1 is obsolete| | --- Comment #109 from M. Tompsett --- Created attachment 59279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59279&action=edit [SIGNED-OFF] bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged several commits - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script - Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' - Added the use CGI qw ( -utf8 ); - Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt - Fixed typo in summary.tt - Made consistent single space before and after -> in all onboarding .tt and summary.tt files. - Made single
    tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) - Changed button and link names in web installer and onboarding tool - Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. - Fixed the errors from the koha qa test - Removed use:C4/Auth from the onboarding.pl - Moved the "select all options" button down to just above the selectable options in the basic setup, and positioned at the top of the page for the advanced setup. - Removed the "there is nothing to do because the sample data is already installed" page so if the user has install sample data in the web installer then the step to create that object in the onboarding tool is skipped altogether. - Removed the "We're just going to setup a few more things" page - Changed the title of the 'Create patron page' - Added clarifying information to the "Add a patron category" page - Added clarifying information to the "Create item type" page - Fixed the capitalization in the onboarding tool - Removed the BackupStep3.tt file which was un-used - Changed the redirect time displayed to user in step3.tt to 10 - Changed the cardnumber on the create patron administrator page so that it is only populated when the user installed sample patrons. Also changed the regex so that it allows letters and number. - Used the HTMl validator to identify errors in the template and have corrected all possible in the onboarding templates. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:18:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:18:12 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #110 from M. Tompsett --- Created attachment 59280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59280&action=edit [SIGNED-OFF] Bug 17855 - removing some errant warns Just removing some warns that crept in during debugging. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:18:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:18:55 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59140|0 |1 is obsolete| | Attachment #59141|0 |1 is obsolete| | Attachment #59174|0 |1 is obsolete| | Attachment #59188|0 |1 is obsolete| | --- Comment #111 from M. Tompsett --- Created attachment 59281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59281&action=edit [SIGNED-OFF] Bug 17855 - Other followups - Removed the html regex from the cardnumber field in the 'Create patron administrator' page of the onboarding tool. Added '|html' into the the value attribute of the cardnumber input field to filter the inputted cardnumber. So now the same level of validation exists for validating the inputted cardnumber in the staff interface and the onboarding tool. - Removed the unnecessary javascript cardnumber validation code from onboardingstep3.tt - Removed HTML regexes from all fields on all screens of onboarding tool except branchcode, patron category code and item type code. Also ensured these three remaining regexes are all {1,10} for length as they are all required. - Added |html and added in input title attribute to input fields where it existed previously Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:19:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:19:32 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:23:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:23:56 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #112 from M. Tompsett --- I tested this in conjunction with bug 17942. There are only a couple things on 17942 holding me back from signing off on that too. Make sure to test by selecting but all sample data and not selecting it, so as to trigger the onboarding steps or to skip them nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:26:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:26:42 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- Why is "select all data" a link and not a button? Next why are the texts staff and superlibrarian (different pages) differing styles? Don't you love the set koha version text? :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:28:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:28:24 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:28:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:28:29 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59142|0 |1 is obsolete| | --- Comment #4 from Caitlin Goodger --- Created attachment 59282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59282&action=edit Bug 17886 Don't show option to add to existing list if there are no lists Test Plan 1: Make sure that you don't have any lists and then add a Bibliographical Record to a list in OPAC 2: You should see that you can add it to an existing list even though you don't have one. 3: Apply patch 4: Add a Bibliographical record in OPAC and if you don't have a list then you shouldn't see the add to existing list. 5: Create a list and then add a Bibiographical Record in OPAC and you should see the add to existing list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:41:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:41:04 +0000 Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:41:06 +0000 Subject: [Koha-bugs] [Bug 9692] Add a checkbox to display statistical fields in basket.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59202|0 |1 is obsolete| | --- Comment #11 from Emma --- Created attachment 59283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59283&action=edit Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:44:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:44:05 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59152|0 |1 is obsolete| | --- Comment #6 from Emma --- Created attachment 59284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59284&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:44:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:44:03 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:44:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:44:42 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:54:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:54:40 +0000 Subject: [Koha-bugs] [Bug 17123] Can't call method "raw" on an undefined value at C4/ Search.pm line 806 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17123 --- Comment #13 from gabrielo --- Did not updated...(In reply to Tom?s Cohen Arazi from comment #12) > (In reply to gabrielo from comment #11) > > Hi, > > > > Yes, look: > > > > sudo apt-get update > > sudo koha-rebuild-zebra -f -v > > sudo service apache2 restart > > > > But, the update is not done. > > sudo koha-rebuild-zebra -f -a -b -v $(koha-list) > > Regards ... Does not work anyway -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 21:56:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 20:56:26 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #153 from Aleisha Amohia --- Patch does not apply Applying: Bug 11708: Add aqbasketgroups.closeddate Applying: Bug 11708: Unit tests for aqbasketgroups.closeddate Applying: Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Using index info to reconstruct a base tree... M acqui/basketgroup.pl M koha-tmpl/intranet-tmpl/prog/css/datatables.css M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:06:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:06:29 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 --- Comment #7 from Gracie --- Created attachment 59285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59285&action=edit Bug 17917: Fix path issue in t/db_dependent/check_sysprefs.t C4::Context->config('intranet') is returning different values based on whether it is a full t/db_dependent test or a specific check_sysprefs.t test run. Tests are only run in kohaclone, so it makes no sense to reference config at all. Brought in rel2abs logic to build a reasonable $root_dir. TEST PLAN --------- -- on a kohadevbox sudo apt-get update sudo apt-get upgrade -- need to make sure the koha-commonpackage is more current git checkout master git pull sudo koha-shell -c "prove t/db_dependent" kohadev -- this should have a check_sysprefs.t failure sudo koha-shell -c "prove t/db_dependent/check_sysprefs.t" kohadev -- this should strangely pass git checkout -b bug_17917 origin/master git bz apply 17917 sudo koha-shell -c "prove t/db_dependent" kohadev -- there will not be a check_sysprefs.t failure sudo koha-shell -c "prove t/db_dependent/check_sysprefs.t" kohadev -- this should pass -- run koha qa test tools Signed-off-by: Grace McKenzie Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:09:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:09:33 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #47 from Luke Honiss --- You have left in the '>>>>>>> BUG XXXXX' when resolving the conflicts in Koha/Patron.pm (line 644) and installer/data/mysql/kohastructure.sql (lines 4077 and 4078). I cannot work out how to add a patron to a club however. If you could walk me through the process that would be awesome. Also when adding another field in the creation of a template there is no colon after the field name unlike the default fields when editing the club. There is also an extra full stop in the tools homepage under the 'Patron clubs' link. Looks like it will be a great feature when finished! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:20:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:20:12 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:20:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:20:15 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Emma changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59284|0 |1 is obsolete| | --- Comment #7 from Emma --- Created attachment 59286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59286&action=edit bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:22:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:22:47 +0000 Subject: [Koha-bugs] [Bug 15590] Next issue skipped if planned date is 1/1/2016 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15590 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:33:20 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:33:23 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59274|0 |1 is obsolete| | --- Comment #30 from Gracie --- Created attachment 59287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59287&action=edit Bug 17917: Fix path issue in t/db_dependent/check_sysprefs.t C4::Context->config('intranet') is returning different values based on whether it is a full t/db_dependent test or a specific check_sysprefs.t test run. Tests are only run in kohaclone, so it makes no sense to reference config at all. Brought in rel2abs logic to build a reasonable $root_dir. TEST PLAN --------- -- on a kohadevbox sudo apt-get update sudo apt-get upgrade -- need to make sure the koha-commonpackage is more current git checkout master git pull sudo koha-shell -c "prove t/db_dependent" kohadev -- this should have a check_sysprefs.t failure sudo koha-shell -c "prove t/db_dependent/check_sysprefs.t" kohadev -- this should strangely pass git checkout -b bug_17917 origin/master git bz apply 17917 sudo koha-shell -c "prove t/db_dependent" kohadev -- there will not be a check_sysprefs.t failure sudo koha-shell -c "prove t/db_dependent/check_sysprefs.t" kohadev -- this should pass -- run koha qa test tools Signed-off-by: Grace McKenzie https://bugs.koha-community.org/show_bug.cgi?id=16387 Signed-off-by: Grace McKenzie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:51:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:51:37 +0000 Subject: [Koha-bugs] [Bug 17946] New: Show number of subscriptions on tab in OPAC record details Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Bug ID: 17946 Summary: Show number of subscriptions on tab in OPAC record details Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org The OPAC detail page for a biblio shows the number Items, Holdings etc in brackets after the tab title (like 'Holdings ( 1 )'), it should do the same for subscriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:56:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:56:10 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:56:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:56:14 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #1 from Aleisha Amohia --- Created attachment 59288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59288&action=edit Bug 17946: Show number of subscriptions on tab in OPAC record details To test: 1) Edit at least one subscription (or add a new one) to have a record 2) Find that record on the OPAC 3) Confirm that the Subscriptions tab reads the correct number of subscriptions attached to the record Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 22:56:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 21:56:25 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:16:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:16:19 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke.honiss at gmail.com Status|Needs Signoff |Failed QA --- Comment #42 from Luke Honiss --- Tests on db_dependent/Letters.t and b_dependent/Members.t failed when I tested this. Setting to failed QA for now. Everything else seemed to work fine though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:21:56 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:21:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:21:58 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 --- Comment #4 from Gracie --- Created attachment 59289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59289&action=edit Bug 7556 - Use "preventDoubleFormSubmit()" more in the OPAC Test Plan: - Look at commit to see file changes and then test each form making sure you can't double submit This is for the OPAC side -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:23:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:23:47 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 Gracie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky at gmail.com --- Comment #5 from Gracie --- The above patch is only for half of the bug, I decided to separate the OPAC and Staff sides of the bug to make it easier to see the changes made -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:56:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:56:41 +0000 Subject: [Koha-bugs] [Bug 7556] Use "preventDoubleFormSubmit()" more in the OPAC and Intranet to prevent duplicate data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7556 --- Comment #6 from Gracie --- Created attachment 59290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59290&action=edit Bug 7143: [QA Follow-up] Handling tabs Editing spaces before releases and developer: 876,$s/ \+releases$/^Ireleases/ (20 substitutions) 876,$s/ \+developer$/^Ideveloper/ (7 substitutions on 7 lines) Editing spaces between date and text: 876,$s/2016 \+/2016^I/ 876,$s/2017 \+/2017^I/ Fixed a few single spaces too. Signed-off-by: Marcel de Rooy Display on Timeline tab looks good now. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:57:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:57:53 +0000 Subject: [Koha-bugs] [Bug 17947] New: Searching my library first shows the branchcode by the search bar rather than branchname Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Bug ID: 17947 Summary: Searching my library first shows the branchcode by the search bar rather than branchname Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org To trigger, turn on syspref "SearchMyLibraryFirst" and go back to OPAC. You'll see by the search bar it now says 'Search (in only), which isn't very user-friendly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:58:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:58:59 +0000 Subject: [Koha-bugs] [Bug 17945] Breadcrumbs broken on opac-serial-issues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17945 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 19 23:59:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 22:59:02 +0000 Subject: [Koha-bugs] [Bug 17945] Breadcrumbs broken on opac-serial-issues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17945 --- Comment #1 from Luke Honiss --- Created attachment 59291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59291&action=edit Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl ==TEST PLAN== 1) Make a subscription with a record 2) Search and view the record in OPAC 3) Click on the subscription tab and click more details 4) The breadcrumb will say 'Detals for' without the record name 5) Apply patch 6) Refresh the page 7) The breadcrumb will display the name of the record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:02:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:02:16 +0000 Subject: [Koha-bugs] [Bug 17945] Breadcrumbs broken on opac-serial-issues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17945 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59291|0 |1 is obsolete| | --- Comment #2 from Luke Honiss --- Created attachment 59292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59292&action=edit Bug 17945 - Breadcrumbs broken on opac-serial-issues.pl ==TEST PLAN== 1) Make a subscription with a record 2) Search and view the record in OPAC 3) Click on the subscription tab and click more details 4) The breadcrumb will say 'Detals for' without the record name 5) Apply patch 6) Refresh the page 7) The breadcrumb will display the name of the record (fixed small error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:04:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:04:58 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 --- Comment #1 from Caitlin Goodger --- Created attachment 59293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59293&action=edit Bug 17947 Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in Only) 3: Apply patch and refresh page. It should now say Search (in only) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:04:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:04:55 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:06:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:06:22 +0000 Subject: [Koha-bugs] [Bug 17945] Breadcrumbs broken on opac-serial-issues.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17945 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |luke.honiss at gmail.com CC| |luke.honiss at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:06:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:06:25 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caitlingoodger.student at wegc | |.school.nz Assignee|oleonard at myacpl.org |caitlingoodger.student at wegc | |.school.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:25:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:25:29 +0000 Subject: [Koha-bugs] [Bug 17948] New: Link to make a new list in masthead in OPAC does not take you straight to add form Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948 Bug ID: 17948 Summary: Link to make a new list in masthead in OPAC does not take you straight to add form Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org Clicking Lists at the top of the page, then New List, takes you to the Lists page, but you'd expect it to take you to the add form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:33:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:33:28 +0000 Subject: [Koha-bugs] [Bug 17948] Link to make a new list in masthead in OPAC does not take you straight to add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948 Caitlin Goodger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 00:33:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 19 Jan 2017 23:33:31 +0000 Subject: [Koha-bugs] [Bug 17948] Link to make a new list in masthead in OPAC does not take you straight to add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948 --- Comment #1 from Caitlin Goodger --- Created attachment 59294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59294&action=edit Bug 17948 Link to make a new list in masthead in OPAC does not take you straight to add form Test Form 1: Go to OPAC and click on add new list. 2: It takes you to Your Lists and not straight to add a new list 3: Apply patch 4: Refresh and when you click on new list it should take you straight to add a new list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 01:10:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 00:10:20 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57852|0 |1 is obsolete| | --- Comment #34 from Alex Buckley --- Created attachment 59295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59295&action=edit Bug 15541 - Prevent normalization during matching/import process This patch allows you to use the "qualifier,qualifier" syntax in the Record Matching Rules "Search Index" when using the QueryParser. While QueryParser doesn't support this syntax, it will now fallback correctly to non-QueryParser functionality. Without the patch, your search will just fail silently. This patch also adds a "skip_normalize" option to C4::Search::SimpleSearch(), and uses the option during C4::Matcher::get_matches. This prevents the s/:/=/g and s/=/:/g normalization. This normalization is heavy-handed, and while it is necessary sometimes to generate a valid CCL query or QueryParser query, C4::Matcher::get_matches() already produces a valid CCL query, so we don't need to do this normalization. Additionally, this normalization causes problems when you use a Zebra register which isn't normalized: namely the "u" register. Strings are stored "as is", so http://localhost/koha/resource/1 is stored as is during indexing. When you search, you need to pass the exact same thing through the query to get a match. Using http=//localhost/koha/resource/1 in your query will yield zero results. _TEST PLAN_ 0) Apply patch 1) Create a Record Matching Rule in Koha with the following details: Matching rule code: TEST Description: Test Match threshold: 100 Record type: Bibliographic Match point 1: Search index: id-other,st-urx Score: 100 Tag: 024 Subfields: a Normalization rule: None 2) Create a record in Koha with an indexable URI 2a) Default framework 2b) 024 $a http://koha-community.org/test $2 uri 2c) 040 $c test 2d) 245 $a This is a test record 2e) 942 $c Books 2f) Save (save again if cautioned about missing fields as these should autofill) 3) Do a full re-index of Zebra 4) Download your record from Koha as a .mrc file (ie isomarc, binary marc, etc) 5) Go to "Stage MARC records for import" 5a) Upload your .marc file. 5b) Change your "Record matching rule" to "Test" 5c) Click Stage for import 9) It should say "1 records with at least one match in catalog per matching rule "Test". NOTE: For completeness, you can go through this process on a clean master branch, and note that it will say '0 records with at least one match in catalog per matching rule "TEST"' Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 01:10:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 00:10:48 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 01:33:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 00:33:51 +0000 Subject: [Koha-bugs] [Bug 17948] Link to make a new list in masthead in OPAC does not take you straight to add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 01:33:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 00:33:54 +0000 Subject: [Koha-bugs] [Bug 17948] Link to make a new list in masthead in OPAC does not take you straight to add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59294|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 59296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59296&action=edit [SIGNED-OFF] Bug 17948 Link to make a new list in masthead in OPAC does not take you straight to add form Test Form 1: Go to OPAC and click on add new list. 2: It takes you to Your Lists and not straight to add a new list 3: Apply patch 4: Refresh and when you click on new list it should take you straight to add a new list Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 01:59:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 00:59:04 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 --- Comment #2 from M. Tompsett --- Comment on attachment 59293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59293 Bug 17947 Searching my library first shows the branchcode by the search bar rather than branchname Review of attachment 59293: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17947&attachment=59293) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ +155,4 @@ >
  9. [% ELSE %]
  10. [% END %] > + Subscriptions ( [% subscriptions.size || 0 %] ) Why not just subscriptionsnumber? See line 796ish where it puts it in the sentence. There is no need for || 0, because subscriptions.size should be equal to subscriptionsnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 02:25:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 01:25:28 +0000 Subject: [Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 02:39:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 01:39:02 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 02:39:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 01:39:46 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 02:55:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 01:55:01 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- Start with onboarding in this bug. Put smart rules and itemtypes in separate bugs. Smaller bugs get QA'd faster. Link them in the see alsos. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 03:48:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 02:48:50 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #5 from Liz Rea --- A slightly more concerning part of this, is after you fix the more obvious problem of C4::AddMember being undefined (even though it's technically there), there is a problem with the sessions between the OPAC and the intranet - i.e. the next action a logged in staff user will make is "permission denied" requiring them to log in again. I'm still testing to see if this is specifically to do with "replicate" or if it happens with LDAP logins generally. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 03:56:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 02:56:09 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #6 from Liz Rea --- and when that ldap user logs out, the staff user, no matter who it is, is logged out as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 05:11:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 04:11:34 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #1 from Alex Buckley --- Created attachment 59297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59297&action=edit Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 05:11:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 04:11:53 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 05:19:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 04:19:59 +0000 Subject: [Koha-bugs] [Bug 15541] Prevent normalization during matching/import process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #35 from David Cook --- Cheers Alex :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 08:45:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 07:45:22 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 08:56:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 07:56:35 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #31 from Marcel de Rooy --- Can reproduce the problem. But I think that we want to know why test fails under prove, instead of just building the path some other way. We should be able to rely on config You say: "C4::Context->config('intranet') is returning different values ..." Could you detail what these different values are? And can we reconstruct where they come from? I checked a few combinations of "prove [some_tests] check_syspref" but could not find the trigger yet. Parking in Blocked for the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:05:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:05:55 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #9 from Marcel de Rooy --- Joubu: Please adjust in view of marcxml not being in Biblioitem any more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:11:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:11:40 +0000 Subject: [Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #43 from Josef Moravec --- Test t/db_dependent/api/v1/accountlines.t fails: Use of uninitialized value $amount in subtraction (-) at /home/vagrant/kohaclone/Koha/Account.pm line 178. Use of uninitialized value $amount in subtraction (-) at /home/vagrant/kohaclone/Koha/Account.pm line 205. # Failed test at t/db_dependent/api/v1/accountlines.t line 178. # Looks like you failed 1 test of 37. it's because the Koha::Account->pay always need an amount... so when api doesn't get an amount parameter, it can't have anything to pass - I think the API should return an error then -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:51:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:51:34 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #32 from Marcel de Rooy --- Problems are caused by Search.t (still looking a bit) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:52:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:52:08 +0000 Subject: [Koha-bugs] [Bug 17949] New: [3.22.x] Batch patron deletion tool is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 Bug ID: 17949 Summary: [3.22.x] Batch patron deletion tool is broken Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org The filter 'who have not borrowed since' is ignored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:53:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:53:20 +0000 Subject: [Koha-bugs] [Bug 17949] [3.22.x] Batch patron deletion tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 --- Comment #1 from Julian Maurice --- Created attachment 59298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59298&action=edit Bug 17949: Fix batch patron deletion tool The filter 'who have not borrowed since' was ignored Reword 'not_borrowered_since' to 'not_borrowed_since' This patch is originally a followup of bug 10612 Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:53:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:53:33 +0000 Subject: [Koha-bugs] [Bug 17949] [3.22.x] Batch patron deletion tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:53:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:53:39 +0000 Subject: [Koha-bugs] [Bug 17949] [3.22.x] Batch patron deletion tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 09:54:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 08:54:00 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:06:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:06:34 +0000 Subject: [Koha-bugs] [Bug 17949] [3.22.x] Batch patron deletion tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10612 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:06:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:06:34 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17949 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:15:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:15:18 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #33 from Marcel de Rooy --- Created attachment 59299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59299&action=edit Bug 17917: [QA Follow-up] Reprove Search.t The config tweaks from Search.t break check_sysprefs.t later on. Clearing the cache resolves that. Test plan: [1] Run prove t/db_dependent/Search.t t/db_dependent/check_sysprefs.t (in one statement) before and after applying this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:18:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:18:00 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #10 from Jonathan Druart --- Created attachment 59300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59300&action=edit Bug 17726: biblioitems.marc has been moved to biblio_metadata.metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:20:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:20:26 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58770|0 |1 is obsolete| | --- Comment #154 from Julian Maurice --- Created attachment 59301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59301&action=edit Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:20:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:20:33 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58771|0 |1 is obsolete| | --- Comment #155 from Julian Maurice --- Created attachment 59302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59302&action=edit Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:20:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:20:40 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58772|0 |1 is obsolete| | --- Comment #156 from Julian Maurice --- Created attachment 59303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59303&action=edit Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:20:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:20:46 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58773|0 |1 is obsolete| | --- Comment #157 from Julian Maurice --- Created attachment 59304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59304&action=edit Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi Patch updated: use atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:20:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:20:52 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58774|0 |1 is obsolete| | --- Comment #158 from Julian Maurice --- Created attachment 59305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59305&action=edit Bug 11708: Place "Basket groups" menu entry on top of the side navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:20:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:20:59 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58775|0 |1 is obsolete| | --- Comment #159 from Julian Maurice --- Created attachment 59306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59306&action=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:21:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:21:07 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58776|0 |1 is obsolete| | --- Comment #160 from Julian Maurice --- Created attachment 59307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59307&action=edit Bug 11708: UT: Replace 'ok' by 'is' where appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:21:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:21:14 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58777|0 |1 is obsolete| | --- Comment #161 from Julian Maurice --- Created attachment 59308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59308&action=edit Bug 11708: UT: Use DateTime instead of localtime+sprintf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:21:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:21:21 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58778|0 |1 is obsolete| | --- Comment #162 from Julian Maurice --- Created attachment 59309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59309&action=edit Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:21:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:21:39 +0000 Subject: [Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:27:04 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59299|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy --- Created attachment 59310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59310&action=edit Bug 17917: [QA Follow-up] Reprove Search.t The config tweaks from Search.t break check_sysprefs.t later on. Clearing the cache resolves that. Test plan: [1] Run prove t/db_dependent/Search.t t/db_dependent/check_sysprefs.t (in one statement) before and after applying this patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:27:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:27:09 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #35 from Marcel de Rooy --- Created attachment 59311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59311&action=edit Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t EDIT (from Marcel:) Previous patch fixes issue caused by Search.t. This patch still adds some small changes to check_sysprefs.t. Signed-off-by: Grace McKenzie Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:27:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:27:31 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:42:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:42:47 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55978|0 |1 is obsolete| | --- Comment #74 from Julian Maurice --- Created attachment 59312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59312&action=edit Bug 13371: Add filters on the supplier list view This patch adds the ability to filter the basket list depending on its creator name, basketgroup name, dates (creation, close), etc. It also adds a new link to filter on opened baskets only and the ability to switch to a simple view if the complete view is to complex Test plan: Go on the supplier list view (acqui/booksellers.pl) and confirm that the view is more ergonomic and the filters permit to the librarians to find a basket more easily than before. Signed-off-by: Paola Rossi Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:43:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:43:11 +0000 Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371 --- Comment #75 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:46:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:46:25 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:46:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:46:28 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59311|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 59313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59313&action=edit Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t EDIT (from Marcel): Previous patch fixes issue caused by Search.t. This patch still adds some small changes to check_sysprefs.t. Signed-off-by: Grace McKenzie Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:47:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:47:24 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58799|0 |1 is obsolete| | --- Comment #51 from Julian Maurice --- Created attachment 59314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59314&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:47:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:47:29 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58800|0 |1 is obsolete| | --- Comment #52 from Julian Maurice --- Created attachment 59315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59315&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:47:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:47:33 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58801|0 |1 is obsolete| | --- Comment #53 from Julian Maurice --- Created attachment 59316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59316&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:47:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:47:38 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58802|0 |1 is obsolete| | --- Comment #54 from Julian Maurice --- Created attachment 59317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59317&action=edit Bug 15516: Set reserve-group.pl to be executable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:47:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:47:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58803|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 59318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59318&action=edit Bug 15516: Reword 'reserve group' to 'hold group' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:48:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:48:47 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #37 from Marcel de Rooy --- Created attachment 59319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59319&action=edit Bug 7143: [QA Follow-up] Handling tabs Editing spaces before releases and developer: 876,$s/ \+releases$/^Ireleases/ (20 substitutions) 876,$s/ \+developer$/^Ideveloper/ (7 substitutions on 7 lines) Editing spaces between date and text: 876,$s/2016 \+/2016^I/ 876,$s/2017 \+/2017^I/ Fixed a few single spaces too. Signed-off-by: Marcel de Rooy Display on Timeline tab looks good now. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:48:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:48:51 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59310|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy --- Created attachment 59320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59320&action=edit Bug 17917: [QA Follow-up] Reprove Search.t The config tweaks from Search.t break check_sysprefs.t later on. Clearing the cache resolves that. Test plan: [1] Run prove t/db_dependent/Search.t t/db_dependent/check_sysprefs.t (in one statement) before and after applying this patch. Signed-off-by: Marcel de Rooy A prove t/db_dependent did not fail check_sysprefs.t (only skipping two tests: 00-strict.t and Koha/IssuingRules.t; not enough patience) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:50:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:50:11 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59319|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy --- Comment on attachment 59319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59319 Bug 7143: [QA Follow-up] Handling tabs Making a mess here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:51:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:51:39 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59313|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy --- Created attachment 59321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59321&action=edit Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t EDIT (from Marcel): Previous patch fixes issue caused by Search.t. This patch still adds some small changes to check_sysprefs.t. Signed-off-by: Grace McKenzie Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:53:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:53:40 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 10:53:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 09:53:55 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:02:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:02:12 +0000 Subject: [Koha-bugs] [Bug 17878] 008 tag editor not working with IE11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17878 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #1 from Mirko Tietgen --- Created attachment 59322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59322&action=edit Screenshot IE11 Developer Tools >From what I found in the depths of IE Developer Tools, it seems like this breaks it for IE11: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400#c25 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:05:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:05:21 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #10) > Created attachment 59300 [details] [review] > Bug 17726: biblioitems.marc has been moved to biblio_metadata.metadata Thanks. But we still have a problem, Houston: # Subtest: Build all sources 1..1 DBD::mysql::st execute failed: Column 'metadata' cannot be null [for Statement "INSERT INTO `biblio_metadata` ( `biblionumber`, `format`, `marcflavour`, `metadata`) VALUES ( ?, ?, ?, ? )" with ParamValues: 0='5051', 1='wjOZm7m', 2='r8zqCCTHTdruku', 3=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. We have a constraint here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:14:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:14:41 +0000 Subject: [Koha-bugs] [Bug 17878] 008 tag editor not working with IE11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17878 --- Comment #2 from Mirko Tietgen --- Indeed, removing $('#toolbar').fixFloat(); from addbiblio.tt brings back the value builders in IE11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:31:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:31:07 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #18 from Marcel de Rooy --- Created attachment 59323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59323&action=edit Bug 17909: [Follow-up] Quick fix for UNIMARC UNIMARC inserts field 100. This interferes the field count and order in the test. Note: This is a quick fix. Will polish it after bug 17913. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:38:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:38:36 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 --- Comment #26 from Paul Poulain --- (In reply to Barton Chittenden from comment #24) > (In reply to paxed from comment #6) > > "Title" - is this the title of a book? (usually it is) ...or does it mean > > the name of a holiday? (as it is in the holidays calendar) > > There's also a title in the borrowers table -- as in "Mr.", "Mrs.", "Dr." > etc. I don't think that this is likely to cause problems with translation; > the context is entirely different, but it's annoying when you join borrowers > to a query that already has "title" in the select statement, and suddenly > need to qualify that... In french we use the word "civilit?". google translate says it can be translated to "civility". Is it a valid possibility ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:38:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:38:54 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59323|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy --- Created attachment 59324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59324&action=edit Bug 17909: [Follow-up] Quick fix for UNIMARC UNIMARC inserts field 100. This interferes the field count and order in the test. Note: This is a quick fix. Will polish it after bug 17913. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:45:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:45:36 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #35 from Marcel de Rooy --- Created attachment 59325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59325&action=edit Bug 17913: Add AuthorityMergeMode preference Original patch from bug 5572, dating back to 2011! Amended by Marcel de Rooy January 2017. Renamed the pref. The fix on this report is based on this preference. Depending on the pref, subfields will be deleted or kept. Test plan: Run the dbrev. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:45:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:45:40 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #36 from Marcel de Rooy --- Created attachment 59326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59326&action=edit Bug 17913: Use replace_with instead of insert_grouped_field Original fix from a patch on bug 5572. Amended by Marcel de Rooy January 2017. Note: This does not yet resolve the field order when merging to another auth type, but is a good start. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:45:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:45:44 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #37 from Marcel de Rooy --- Created attachment 59327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59327&action=edit Bug 17913: Use AuthorityMergeMode pref in sub merge Original fix from a patch on bug 11315. Amended by Marcel de Rooy January 2017. Test plan: If you set mode to loose, the test will still pass. If you set mode to strict, one test will fail. (Fixed later.) Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:45:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:45:48 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #38 from Marcel de Rooy --- Created attachment 59328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59328&action=edit Bug 17913: Adjust merge test for AuthorityMergeMode Original fix from a patch on bug 11315. Amended by Marcel de Rooy January 2017. Test plan: Run t/db_dependent/Authorities/Merge.t in both loose and strict mode. Should no longer make a difference. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:45:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:45:56 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #40 from Marcel de Rooy --- Created attachment 59330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59330&action=edit Bug 17913: Do not keep a cleared subfield in loose merge mode If you modify an authority and clear a specific subfield, you expect that merge respects your edit and clears this subfield too in the biblio records. It does in the new strict mode, but it does not yet in the default loose mode. This patch fixes that by adjusting the code around $exclude so that it uses a new hash skip_subfields, built from the reporting tags from the old and the new authority record. This is supported again by some changes in the unit test. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:45:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:45:52 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #39 from Marcel de Rooy --- Created attachment 59329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59329&action=edit Bug 17913: Fix the new field tag in merge when changing type Originally aimed for 9988, adjusted for this report. Old behavior was: pick the first tag. This is definitely wrong. If you (would) merge 610 to 611, you don't want to get a 111. This patch resolves the problem by determining the new tag in a small helper routine _merge_newtag, and corrects the position of the new field in the MARC record with append_fields_ordered. Too bad that MARC::Record does not have such a function; it looks like insert_fields_ordered, but it is different in case of multiple fields with the same tag. Note: These two small helper functions are not tested separately, since they should not be called outside of merge. They are implicitly tested by the adjusted tests in Merge.t. Note: In adding tests for this fix, I chose to simplify compare_field_count (no need for the pass parameter), and replace the pass parameter of sub compare_field_order by an exclude parameter, a hash of fields to exclude in counting fields. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:46:00 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #41 from Marcel de Rooy --- Created attachment 59331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59331&action=edit Bug 17913: Remove possible duplicates in strict merge mode Since strict mode does not allow additional subfields that would make identical fields linked to the same authority different, there is no need to keep them while merging. We achieve this goal by simply: [1] Count the number of same fields linked to mergefrom in strict mode to eliminate duplicates. [2] Replaces the if-statement on auth_number by a next. (Tidy follows.) Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:46:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:46:04 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #42 from Marcel de Rooy --- Created attachment 59332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59332&action=edit Bug 17913: We always need some housekeeping Remove some commented warnings Remove the commented old code at the end of sub merge Explicitly set merge mode in the first subtest Move the return to loose mode from the second subtest to the third Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:46:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:46:08 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #43 from Marcel de Rooy --- Created attachment 59333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59333&action=edit Bug 17913: Run perltidy on the inner foreach loop Kept the same number of lines. You could verify with diff -w. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] As the last patch in this series, also test the interface: Set AuthorityMergeMode to loose. Set dontmerge to Do. Modify an authority record attached to multiple biblios. Edit a subfield, clear a subfield and add a subfield. Save. Wait a bit for the merge and Zebra update. Verify that the changes are merged properly into biblio records. [3] Repeat step 2 with AuthorityMergeMode to strict. Remember that this affects the extra subfields in biblio records. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:46:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:46:52 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #44 from Marcel de Rooy --- Rebased on top of the UNIMARC fix on 17909 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:22 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:25 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:27 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:29 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:30 +0000 Subject: [Koha-bugs] [Bug 17878] Tag editors (and floating toolbar in MARC editor) not working with IE11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17878 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|008 tag editor not working |Tag editors (and floating |with IE11 |toolbar in MARC editor) not | |working with IE11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:33 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:31 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:35 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:37 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:39 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 11:47:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 10:47:41 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:24:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:24:36 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59011|0 |1 is obsolete| | --- Comment #20 from Julian Maurice --- Created attachment 59334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59334&action=edit Bug 17909: Add unit tests for C4::AuthoritiesMarc::merge Original patch from Julian Maurice on bug 11700. With sign offs by: Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall Amended by Marcel de Rooy on report 17909. EDIT (January 2017): Removed some tests not related to merge. Put remaining tests in a subtest, made them working on current merge. Slightly revised the mocking. Note: I plan to move the zebra retrieval stuff outside merge in one of the next stages, and replace it by calling Koha::SearchEngine. This will reduce mocking complexity here. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:24:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:24:46 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59012|0 |1 is obsolete| | --- Comment #21 from Julian Maurice --- Created attachment 59335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59335&action=edit Bug 17909: Adding tests from bug 11315 Based on original patch from Maxime Beaulieu on bug 11315. Amended by Marcel de Rooy on report 17909. EDIT: Original tests have been adjusted in view of: [1] Test on bug 11315 heavily leaned on DBD::Mock. Since we are using Test::DBIx::Class on such tests now, this would need attention. Moreover, the advantage of mocking the database in this case is at least arguable. [2] Matching the first (somewhat older) subtest of 11700. [3] Simplification and readability. Look e.g. at the use of $MARCto and $MARCfrom on 11315. This made me merge them in the db_dependent counterpart. Also note that this subtest adds another needed test case: the merge from auth1 to modified auth1, while 11700 tested auth1 to auth2. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:24:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:24:55 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59013|0 |1 is obsolete| | --- Comment #22 from Julian Maurice --- Created attachment 59336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59336&action=edit Bug 17909: Add tests for merging with another authtype Originally aimed for bug 9988. Adjusted in line with other subtests. Will polish the three subtests a little more on a follow-up. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:25:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:25:05 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59014|0 |1 is obsolete| | --- Comment #23 from Julian Maurice --- Created attachment 59337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59337&action=edit Bug 17909: Additional polishing No spectacular things: [1] Move the framework modifications to a sub. Use same style to create auth types and linked fields. [2] Change some new Object occurrences to Object->new. [3] Add tests for field count and field order in the first two subsets. [4] Few whitespace changes (sorry) and comment lines. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:25:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:25:13 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59088|0 |1 is obsolete| | --- Comment #24 from Julian Maurice --- Created attachment 59338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59338&action=edit Bug 17909: Followup - fix typos Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy EDIT: Adjusted three small typos that did not disturb the test in its current form, but do when we are fixing bugs on bug 17913. Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:25:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:25:19 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59324|0 |1 is obsolete| | --- Comment #25 from Julian Maurice --- Created attachment 59339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59339&action=edit Bug 17909: [Follow-up] Quick fix for UNIMARC UNIMARC inserts field 100. This interferes the field count and order in the test. Note: This is a quick fix. Will polish it after bug 17913. Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:25:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:25:25 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #26 from Julian Maurice --- Created attachment 59340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59340&action=edit Bug 17909: QA followup: remove unused var and move global var Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:25:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:25:39 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:28:11 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59300|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 59341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59341&action=edit Bug 17726: biblioitems.marc has been removed We will certainly have to do something with the biblio_metadata.metadata field later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:28:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:28:26 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:29:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:29:06 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #13 from Jonathan Druart --- Not sure that will be enough, but I do not see a quick solution for now. Tests seem to pass now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:17 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58613|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 59342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59342&action=edit Bug 17501: Introduce Koha::Object[s] classes for UploadedFile(s) In the next set of patches we will start using these new classes in Koha::Upload, and scripts using it. This is just the starting point of that migration. Test plan: [1] Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:22 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58614|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 59343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59343&action=edit Bug 17501: Use Koha::Object in Koha::Upload::_register The _register routine basically inserts a new record in uploaded_files. It should use Koha::UploadedFile now. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file via Tools/Upload. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:27 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58615|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 59344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59344&action=edit Bug 17501: Use Koha::Object in Koha::Upload::_lookup The _lookup routine performs a few select statements on uploaded_files. In this patch the SQL statements are replaced with Koha::Object calls. One call of _lookup is replaced directly by Koha::UploadedFiles. Note: _lookup can be removed in a later stage. Test plan: [1] Run t/db_dependent/Upload.t [2] Upload a file in some upload category [3] Try to upload the same file into the same category. Error? [4] Try to upload the same file in another category. Should work. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:31 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58616|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 59345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59345&action=edit Bug 17501: Use Koha::Object in Koha::Upload::_delete Note: This is the last occurrence where we use DBI to perform a CRUD operation. In this case a delete from uploaded_files. We now call Koha::UploadedFile[s]->delete to only delete the record from the table. A next step will be moving the additional functionality of removing the file(s) too. Test plan: [1] Run t/db_dependent/Upload.t [2] Delete an upload from tools/upload.pl Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:36 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58617|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 59346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59346&action=edit Bug 17501: Move Koha::Upload::delete to Koha::UploadedFile[s] Since delete is not part of the upload process, we will move it now to Koha::UploadedFile[s]. Deleting the file will be done in UploadedFile. The (multiple) delete method in UploadedFiles refers to the single delete. Test plan: [1] Run t/db_dependent/Upload.t The warning ("but file was missing") in the last subtest is fine; the file did not exist. Will be addressed in a follow-up. [2] Search for uploads on Tools/Upload. Clone this tab (repeat search on a new tab in your browser). [3] Delete an existing upload on the first tab. [4] Try to delete it again on the second tab. Error message? [5] Bonus points: Add an upload. Mark the file immutable with chattr +i. Try to delete the file. You should see a "Could not be deleted"-message. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:41 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58618|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 59347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59347&action=edit Bug 17501: Remove Koha::Upload::get from Koha::Upload The get routine actually returns records from uploaded_files. It should be possible to replace its calls by direct calls of Koha::UploadedFiles. This patch is the crux of this patch set. It deals with all scripts that use Koha::Upload. In the process we do: [1] Add a file_handle method to Koha::UploadedFile. This was previously arranged via the fh parameter of get. [2] Add a full_path method to UploadedFile. Previously returned in the path hash key of get. (Name is replaced by filename.) [3] Add a search_term method too (implementing get({ term => .. }). This logic came from _lookup. [4] Add a keep_file parameter to delete method. Only used in test now. Test plan: [1] Run t/db_dependent/Upload.t [2] Go to Tools/Upload. Add an upload, download and delete. [3] Add another public upload , search for it. Use the hashvalue to download via opac with URL: cgi-bin/koha/opac-retrieve-file.pl?id=[hashvalue] [4] Go to Tools/Stage MARC for import. Import a marc file. [5] Go to Tools/Upload local cover image. Import an image file. Enable OPACLocalCoverImages to see result. [6] Test uploading a offline circulation file: Enable AllowOfflineCirculation, and create a koc file (plain text): Line1: Version=1.0\tA=1\tB=2 Line2: 2016-11-23 16:00:00 345\treturn\t[barcode] Note: Replace tabs and barcode. The number of tabs is essential! Checkout the item with your barcode. Go to Circulation/Offline circulation file upload. Upload and click Apply directly. Checkout again. Repeat Offline circulation file upload. Now click Add to offline circulation queue. [7] Connect the upload plugin to field 856$u. Enable HTML5MediaEnabled. Upload a webm file via the plugin. Click Choose to save the URL, and put 'video/webm' into 856$q. Save the biblio record. Check if you see the media tab with player on staff detail. (See also: Bug 17673 about empty OPACBaseURL.) Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:45 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58619|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 59348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59348&action=edit Bug 17501: Move getCategories and httpheaders from Upload.pm Class method getCategories has no strict binding to Upload.pm. While Upload.pm is now restricted to the actual uploading process with CGI hook, this routine fits better in the UploadedFile package. Class method httpheaders can be moved as well for the same reason. Note that it actually is an instance method. The parameter $name is dropped. Test plan: [1] Run t/db_dependent/Upload.t. [2] Check the categories in the combo box of tools/upload. [3] Check a download via tools/upload and opac-retrieve-file. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:40:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:40:54 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58620|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart --- Created attachment 59349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59349&action=edit Bug 17501: Rename Upload to Uploader Why? Koha::Uploader now only contains the actual CGI upload. The new name better reflects its handler status. Pragmatically, the difference between Uploaded and Uploader makes it easier to specifically search for them in the codebase. Test plan: [1] Run t/db_dependent/Upload.t. [2] Add an upload via the interface. [3] Check the code: git grep "Koha::Upload;" git grep "Koha::Upload\->" Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:41:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:41:06 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58809|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 59351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59351&action=edit Bug 17501: [Follow-up] QA Requests This patch makes the following changes, as requested by QA: [1] UploadedFile->delete always calls SUPER::delete. The return value normally comes from SUPER::delete; if removing the file failed, we return false. Two warns are kept. Since delete does no longer return the filename, a few changes were needed in tools/upload.pl. [2] Method getCategories is moved to UploadedFiles. Script tools/upload.pl now only contains one call. Added a use C4::Koha. [3] Calls UploadedFiles->delete as class method. As a result I removed method delete_errors for now; may be reconsidered on a new report. [4] Adjusted three ->search calls for id and public to ->find calls. [5] If you pass no id to upload.pl when deleting, you don't get an alert. All by all, we got rid of 15 lines ! Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:41:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:41:00 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58621|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 59350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59350&action=edit Bug 17501: Additional polishing (POD, unit tests) This patch adds some documentation lines. And mainly rearrangs the tests in Upload.t. The 'basic CRUD testing' is not needed separately any more. A new test catches the "file missing" warn. Test plan: [1] Run perldoc on UploadedFile[s].pm [2] Run t/db_dependent/Upload.t Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:41:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:41:38 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:49:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:49:14 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |julian.maurice at biblibre.com |y.org | --- Comment #27 from Marcel de Rooy --- Thanks, Julian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:50:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:50:32 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 --- Comment #34 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #33) > Signed-off-by: Jonathan Druart Thanks, Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 12:56:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 11:56:07 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #45 from Marcel de Rooy --- Created attachment 59352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59352&action=edit Bug 17913: [Follow-up] Another small fix for UNIMARC Adding another delete for field 100. Will mock GetMarcBiblio on a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:12:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:12:11 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59341|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy --- Created attachment 59353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59353&action=edit Bug 17726: biblioitems.marc has been removed We will certainly have to do something with the biblio_metadata.metadata field later. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:15:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:15:40 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Marcel de Rooy --- Taking the liberty to pass qa for this one now. No problems detected with this change in the t/db_dependent tests. Does not interfere with the interface, only TestBuilder and tests; not used outside t/db_dependent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:34:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:34:57 +0000 Subject: [Koha-bugs] [Bug 17949] [3.22.x] Batch patron deletion tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Passed QA --- Comment #2 from Marcel de Rooy --- Looks good to me. Moving it to Stable for the RMaint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:35:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:35:06 +0000 Subject: [Koha-bugs] [Bug 17949] [3.22.x] Batch patron deletion tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:43:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:43:54 +0000 Subject: [Koha-bugs] [Bug 17949] [3.22.x] Batch patron deletion tool is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17949 --- Comment #3 from Julian Maurice --- Thanks Marcel. Pushed to 3.22.x for 3.22.15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:45:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:45:06 +0000 Subject: [Koha-bugs] [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 --- Comment #16 from Tom?s Cohen Arazi --- Created attachment 59354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59354&action=edit Bug 17755: (QA followup) Return $self when appropriate As failure situations raise exceptions that should be handled outside the object class, methods should return $self so successive calls can be chained nicely. This patch makes methods return $self and adjusts the tests to reflect this change. Make sure tests pass: - Run: $ prove t/db_dependent/Koha/Patron/Attribute/Types.t => SUCCESS: Tests return green - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:50:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:50:21 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59195|0 |1 is obsolete| | Attachment #59196|0 |1 is obsolete| | --- Comment #11 from Mirko Tietgen --- Created attachment 59355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59355&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. On my window you still can't see the indicator properly so you can choose what looks better between the 2em and the 3em one. This is the 2em one Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:51:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:51:34 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #12 from Mirko Tietgen --- Created attachment 59356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59356&action=edit Bug 17929 You can't edit indicators in the cataloging screen Test Plan 1: Find a Bibiographical record and go to edit record 2: You won't be able to type into the indicators 3: Apply the patch 4: Refresh the page and now the boxes should be bigger so that you can type into there. I have made a patch for 2em and 3em and this is the 3em one because the 2em is still too small on my screen. Choose which one works better for you Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:52:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:52:29 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #13 from Mirko Tietgen --- Both patches make indicators work. The second one works better for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 13:58:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 12:58:30 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #46 from Marcel de Rooy --- Created attachment 59358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59358&action=edit Bug 17913: [Follow-up] Fix duplicate $9s after merging in loose mode We need to add $9 to the skip_subfields hash too. Formerly, it was added to $exclude as well. Thanks, Julian, for catching this one. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:09:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:09:20 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59325|0 |1 is obsolete| | --- Comment #47 from Julian Maurice --- Created attachment 59360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59360&action=edit Bug 17913: Add AuthorityMergeMode preference Original patch from bug 5572, dating back to 2011! Amended by Marcel de Rooy January 2017. Renamed the pref. The fix on this report is based on this preference. Depending on the pref, subfields will be deleted or kept. Test plan: Run the dbrev. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:09:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:09:27 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59326|0 |1 is obsolete| | --- Comment #48 from Julian Maurice --- Created attachment 59361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59361&action=edit Bug 17913: Use replace_with instead of insert_grouped_field Original fix from a patch on bug 5572. Amended by Marcel de Rooy January 2017. Note: This does not yet resolve the field order when merging to another auth type, but is a good start. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:09:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:09:33 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59327|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 59362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59362&action=edit Bug 17913: Use AuthorityMergeMode pref in sub merge Original fix from a patch on bug 11315. Amended by Marcel de Rooy January 2017. Test plan: If you set mode to loose, the test will still pass. If you set mode to strict, one test will fail. (Fixed later.) Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:09:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:09:39 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59328|0 |1 is obsolete| | --- Comment #50 from Julian Maurice --- Created attachment 59363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59363&action=edit Bug 17913: Adjust merge test for AuthorityMergeMode Original fix from a patch on bug 11315. Amended by Marcel de Rooy January 2017. Test plan: Run t/db_dependent/Authorities/Merge.t in both loose and strict mode. Should no longer make a difference. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:09:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:09:44 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59329|0 |1 is obsolete| | --- Comment #51 from Julian Maurice --- Created attachment 59364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59364&action=edit Bug 17913: Fix the new field tag in merge when changing type Originally aimed for 9988, adjusted for this report. Old behavior was: pick the first tag. This is definitely wrong. If you (would) merge 610 to 611, you don't want to get a 111. This patch resolves the problem by determining the new tag in a small helper routine _merge_newtag, and corrects the position of the new field in the MARC record with append_fields_ordered. Too bad that MARC::Record does not have such a function; it looks like insert_fields_ordered, but it is different in case of multiple fields with the same tag. Note: These two small helper functions are not tested separately, since they should not be called outside of merge. They are implicitly tested by the adjusted tests in Merge.t. Note: In adding tests for this fix, I chose to simplify compare_field_count (no need for the pass parameter), and replace the pass parameter of sub compare_field_order by an exclude parameter, a hash of fields to exclude in counting fields. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:09:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:09:50 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59330|0 |1 is obsolete| | --- Comment #52 from Julian Maurice --- Created attachment 59365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59365&action=edit Bug 17913: Do not keep a cleared subfield in loose merge mode If you modify an authority and clear a specific subfield, you expect that merge respects your edit and clears this subfield too in the biblio records. It does in the new strict mode, but it does not yet in the default loose mode. This patch fixes that by adjusting the code around $exclude so that it uses a new hash skip_subfields, built from the reporting tags from the old and the new authority record. This is supported again by some changes in the unit test. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:09:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:09:55 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59331|0 |1 is obsolete| | --- Comment #53 from Julian Maurice --- Created attachment 59366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59366&action=edit Bug 17913: Remove possible duplicates in strict merge mode Since strict mode does not allow additional subfields that would make identical fields linked to the same authority different, there is no need to keep them while merging. We achieve this goal by simply: [1] Count the number of same fields linked to mergefrom in strict mode to eliminate duplicates. [2] Replaces the if-statement on auth_number by a next. (Tidy follows.) Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:00 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59332|0 |1 is obsolete| | --- Comment #54 from Julian Maurice --- Created attachment 59367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59367&action=edit Bug 17913: We always need some housekeeping Remove some commented warnings Remove the commented old code at the end of sub merge Explicitly set merge mode in the first subtest Move the return to loose mode from the second subtest to the third Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:06 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59333|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 59368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59368&action=edit Bug 17913: Run perltidy on the inner foreach loop Kept the same number of lines. You could verify with diff -w. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] As the last patch in this series, also test the interface: Set AuthorityMergeMode to loose. Set dontmerge to Do. Modify an authority record attached to multiple biblios. Edit a subfield, clear a subfield and add a subfield. Save. Wait a bit for the merge and Zebra update. Verify that the changes are merged properly into biblio records. [3] Repeat step 2 with AuthorityMergeMode to strict. Remember that this affects the extra subfields in biblio records. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:13 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59352|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 59369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59369&action=edit Bug 17913: [Follow-up] Another small fix for UNIMARC Adding another delete for field 100. Will mock GetMarcBiblio on a new report. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:08 +0000 Subject: [Koha-bugs] [Bug 17950] New: Additional housekeeping on Merge.t (after 17913) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Bug ID: 17950 Summary: Additional housekeeping on Merge.t (after 17913) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:18 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:20 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59358|0 |1 is obsolete| | --- Comment #57 from Julian Maurice --- Created attachment 59370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59370&action=edit Bug 17913: [Follow-up] Fix duplicate $9s after merging in loose mode We need to add $9 to the skip_subfields hash too. Formerly, it was added to $exclude as well. Thanks, Julian, for catching this one. Signed-off-by: Marcel de Rooy Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:40 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:40 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 [Bug 17950] Additional housekeeping on Merge.t (after 17913) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:10:54 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:11:51 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com --- Comment #58 from Julian Maurice --- Everything looks good. Tested strict and loose mode. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:12:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:12:54 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #59 from Marcel de Rooy --- (In reply to Julian Maurice from comment #58) > Everything looks good. Tested strict and loose mode. > Passed QA Thanks, Julian ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:15:45 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 --- Comment #11 from Marcel de Rooy --- Bug 17909 and 17913 moved to PQA now with thanks to Josef and Julian! I added a intermediate report for the Merge.t test after a quick fix for UNIMARC field 100. That is bug 17950. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:37:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:37:38 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Kyle M Hall --- Pushed to master for 17.05, thanks Alex! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:40:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:40:13 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #41 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:41:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:41:17 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:42:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:42:55 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:44:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:44:19 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:47:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:47:43 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:47:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:47:49 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:47:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:47:51 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59151|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 59373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59373&action=edit [SIGNED-OFF] Bug 17922: Use correct number of digits when replacing date placeholders This patch also fixes a typo ("<<" should be "<>") Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:53:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:53:38 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #28 from Kyle M Hall --- Pushed to master for 17.05, thanks Julian, Maxime, Marcel, Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:55:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:55:22 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #60 from Kyle M Hall --- Pushed to master for 17.05, thanks Frederic, Maxime, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:56:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:56:22 +0000 Subject: [Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:57:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:57:29 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59171|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 14:57:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 13:57:45 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #6 from Josef Moravec --- I can't reproduce it on current master... can someone confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:00:24 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #64 from Tom?s Cohen Arazi --- Created attachment 59376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59376&action=edit Bug 13757: (QA followup) Check DB structure before altering table Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:02:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:02:48 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:06:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:06:40 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:09:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:09:19 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #4 from Mirko Tietgen --- Gracie: Yes, they should be around the link text, but not part of the URL. If that is what you see you should sign off. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:09:59 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall --- Pushed to master for 17.05, thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:11:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:11:24 +0000 Subject: [Koha-bugs] [Bug 17487] Improper placement of select/clear all in Z39.50/ SRU search dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05, thanks Radek! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:13:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:13:32 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! Would you be able to add a followup bug to store the cache in /var/lib/koha/$site/template_cache or something like that for packages? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:14:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:14:30 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #27 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:22:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:22:18 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #35 from Kyle M Hall --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:23:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:23:56 +0000 Subject: [Koha-bugs] [Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:25:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:25:24 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:28:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:28:49 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:32:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:32:29 +0000 Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:32:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:32:33 +0000 Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57490|0 |1 is obsolete| | --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 59377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59377&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: 75 4 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall Signed-off-by: Larry Baerveldt Signed-off-by: Tomas Cohen Arazi Rebased against master and added a description for the new configuration entries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:35:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:35:04 +0000 Subject: [Koha-bugs] [Bug 17951] New: koha-create should create the template cache dir and configure it in koha-conf.xml Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Bug ID: 17951 Summary: koha-create should create the template cache dir and configure it in koha-conf.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:35:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:35:24 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17951 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:35:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:35:24 +0000 Subject: [Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7533 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 [Bug 7533] Add template_cache_dir to the koha-conf.xml file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:37:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:37:26 +0000 Subject: [Koha-bugs] [Bug 17952] New: Lost items not skipped by overdue_notices.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Bug ID: 17952 Summary: Lost items not skipped by overdue_notices.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a library does not use --mark-returned when running longoverdue.pl, all those lost item checkouts are selected by overdue_notices.pl. This causes much unnecessary overhead. In addition Koha::Calendar is instantiated many times for each branchcode which is not necessary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:37:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:37:36 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:37:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:37:42 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:43:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:43:58 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 15:44:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 14:44:01 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 --- Comment #1 from Kyle M Hall --- Created attachment 59378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59378&action=edit Bug 17952 - Lost items not skipped by overdue_notices.pl If a library does not use --mark-returned when running longoverdue.pl, all those lost item checkouts are selected by overdue_notices.pl. This causes much unnecessary overhead. In addition Koha::Calendar is instantiated many times for each branchcode which is not necessary. Test Plan: 1) Run overdue_notices.pl, note output 2) Apply this patch 3) Run overdue_notices.pl again, note output is the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:08:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:08:53 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59297|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 59379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59379&action=edit [SIGNED-OFF] Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. NOTE: TT variable is excessive. I'll let QA tweak. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:10:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:10:30 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:19:20 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #17 from Josef Moravec --- Jonathan, could you add followup due to bug 16239? Updated wiki page for reference: https://wiki.koha-community.org/wiki/Interface_patterns Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:21:29 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59135|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen --- Created attachment 59380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59380&action=edit Bug 15179 -Field 084 doesnt show on bibliographic record Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:21:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:21:42 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #18 from Josef Moravec --- Ah, looks like it probably will need rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:22:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:22:43 +0000 Subject: [Koha-bugs] [Bug 15179] Marc field 084 does not show on bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15179 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #6 from Mirko Tietgen --- Karen, thanks for your patch! One tiny thing: in the comment (first line) you copied "DDC Classification". You could change this to "Other classification" in a follow-up patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:25:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:25:29 +0000 Subject: [Koha-bugs] [Bug 17027] control file update for 3.22 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17027 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #2 from Mirko Tietgen --- There is no package support for 3.22.x anymore so I will close this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:25:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:25:54 +0000 Subject: [Koha-bugs] [Bug 17066] build-git-snapshot: add basetgz parameter and update master version number for 3.22.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Needs Signoff |RESOLVED --- Comment #3 from Mirko Tietgen --- There is no package support for 3.22.x anymore so I will close this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:37:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:37:08 +0000 Subject: [Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely at hotmail.com --- Comment #4 from Claire Gravely --- I'm seeing the same Syntaxerror as Owen after performing an item search and the results are being displayed below the search options, instead of on a clean page. SyntaxError: expected expression, got '}' /cgi-bin/koha/catalogue/itemsearch.pl Line 396 This occurs for us when no LOC value is present, which is the case for a number of libraries. If the library happens to have another custom authorised value, the error does not occur and in another case the use of bsort2 also removed the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:50:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:50:29 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Mirko Tietgen --- This needs a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 16:55:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 15:55:04 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 --- Comment #8 from Mirko Tietgen --- Caused by changes in bug 13669. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 17:18:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 16:18:39 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Attachment #59282|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Comment on attachment 59282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59282 Bug 17886 Don't show option to add to existing list if there are no I believe this is the wrong solution. It is much simpler. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 17:19:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 16:19:06 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #6 from M. Tompsett --- Created attachment 59381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59381&action=edit Bug 17886: Forgot to count the lists shared to patron The private_shelves_shared_with_me structure is defined, but has 0 entries. The missing .count is the issue. TEST PLAN --------- 1) Make sure no lists exist at all. 2) Make there is at least one findable biblio record entered 3) Find that biblio record in the OPAC 4) Click 'Save to your lists' -- Notice that the whole save to list section is there. 5) apply this patch 6) Click 'Cancel' 7) Click 'Save to your lists' -- Notice you can only add now, which makes sense. 8) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 17:39:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 16:39:08 +0000 Subject: [Koha-bugs] [Bug 17928] Updating sounds for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17928 --- Comment #5 from M. Tompsett --- Created attachment 59382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59382&action=edit Bug 17928: Follow up: tweak template. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 17:41:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 16:41:05 +0000 Subject: [Koha-bugs] [Bug 17928] Updating sounds for circulation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17928 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |In Discussion --- Comment #6 from M. Tompsett --- Emma, quick question: Where did you get the sound files? Koha is GPML 3. Some sound files are licensed in a manner which is not compatible with GPML 3. So, where did you get the sound files? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 18:10:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 17:10:08 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45992|0 |1 is obsolete| | --- Comment #9 from Mirko Tietgen --- Created attachment 59383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59383&action=edit Bug 15427 : Enable TLS support for MySQL In summary, changes are: 1) If you have chosen MySQL, Makefile.PL will ask you if you want TLS (default: "no"), and then the locations for CA cert, client cert and client key (reasonable defaults are provided). Settings , , and are added in koha-conf.xml 2) If yes in koha-conf.xml, the installer and database connection scripts add the TLS options in both DBI connection strings and mysql command line To test 1/ Apply patch 2/ Check everything still works and db connections are the same as before 3/ Either run Makefile.PL and step through the options or edit your koha-conf.xml to enable TLS 4/ Check db connections are still working Patch provided to me by Dimitris Kamenopoulos and I reformatted it into a git patch, any errors are probably mine Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 18:11:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 17:11:25 +0000 Subject: [Koha-bugs] [Bug 15427] Allow db connections using TLS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15427 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Mirko Tietgen --- I rebased it and tested using tcpdump. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 18:12:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 17:12:18 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42450|0 |1 is obsolete| | --- Comment #16 from Julian Maurice --- Created attachment 59384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59384&action=edit Bug 12460: Allow to start a new search from multiple search history lines This patch regroups searches of current and previous sessions to allow selecting lines from both groups. It adds a new column (session date) to allow to differentiate searches of current session from other sessions. Patch is for Intranet and OPAC (bootstrap only) Test plan: 1/ Login to intranet interface 2/ Do some biblio searches 3/ Go to the search history page 4/ See you have a new action available "Start a new search", grayed beacause you haven't selected any line 5/ Select two or more searches 6/ "Start a new search" is now enabled, click it. 7/ A dropdown list appears, asking you to chose between a "Match any" search and a "Match all" search. There is also a new column in the table ("Not") allowing you to apply a NOT to the corresponding line. 8/ Make your choice, and then click on Go button, next to the dropdown list. You will be redirected to the catalogue search results. 9/ Confirm that the results are correct. 10/ Set syspref opacthemes to 'bootstrap' 11/ Go to OPAC interface anonymously and repeat steps 2-9 12/ Login to OPAC interface and repeat steps 2-9 13/ Check that authority search history still works as before the patch (except that there is only one table instead of two) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 18:12:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 17:12:48 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #17 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 18:31:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 17:31:57 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 --- Comment #2 from M. Tompsett --- Comment on attachment 59209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59209 Bug 17935: Adjust some POD lines, fix a few typos Review of attachment 59209: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17935&attachment=59209) ----------------------------------------------------------------- Eyeballs well. ::: Koha/AuthorisedValue.pm @@ +135,2 @@ > > +my $description = $av->opac_description(); Yep. ::: Koha/Plugins.pm @@ +54,4 @@ > This will return a list of all available plugins, optionally limited by > method or metadata value. > > + my @plugins = Koha::Plugins::GetPlugins({ Yikes! Good catch. ::: misc/migration_tools/rebuild_zebra.pl @@ +187,4 @@ > }; > > # Protect again simultaneous update of the zebra index by using a lock file. > +# Create our own lock directory if it is missing. This should be created its vs "it is" -- nice fix. @@ +187,5 @@ > }; > > # Protect again simultaneous update of the zebra index by using a lock file. > +# Create our own lock directory if it is missing. This should be created > +# by koha-zebra-ctl.sh or at system installation. If the desired directory Yep, 2 spaces after a period is old school punctuation. ::: reports/reserves_stats.pl @@ +43,4 @@ > > =head1 DESCRIPTION > > + Plugin that shows reserve stats Doh! Good catch. ::: t/db_dependent/Koha/Authorities.t @@ +49,4 @@ > is( Koha::Authorities->search->count, $nb_of_authorities + 2, 'The 2 authorities should have been added' ); > > $new_authority_1->delete; > +is( Koha::Authorities->search->count, $nb_of_authorities + 1, 'Delete should have deleted the authority' ); Nice catch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:28:11 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 --- Comment #3 from M. Tompsett --- Created attachment 59385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59385&action=edit Bug 17935: Follow up for C4::Plugin... TEST PLAN --------- -- apply first patch git grep "C4::Plugin" -- still two references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- apply this patch git grep "C4::Plugin" -- no references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- should look fixed Please enter the commit message for your changes. Lines starting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:52:25 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 59386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59386&action=edit Bug 17927: Fix /holds and /patrons data types This patch changes current Swagger definitions for patrons and holds to have data types corresponding to column data types in their database tables. To test: 1. GET http://yourlibrary/api/v1/patrons/YYY where YYY is existing borrowernumber 2. Observe that numbers / integers are in string data type. 3. Apply this patch 4. Repeat step 1. 5. Observe that numbers / integers are now actually numbers / integers. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:52:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:52:30 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 59387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59387&action=edit Bug 17927: (followup) Fix /cities cityid type Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:52:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:52:35 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 59388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59388&action=edit Bug 17927: (QA followup) Fix boolean types Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:54:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:54:40 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:55:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:55:04 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |lari.taskula at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:55:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:55:10 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:55:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:55:19 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 19:58:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 18:58:19 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Tom?s Cohen Arazi --- This patches are taken from bug 17008, which got splitted into other bugs that take care of smaller problems. They where signed by Josef, and I'm passing them along with a small followup for bookeans. Note for the QA team: the current API tests are failing. And this patch is not touching them. I'm working on a solution for the tests and the API as a whole on another bugs. Notably on bug 17932 which will allow us to actually have the API return the data types this patches explicitly define on the swagger files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 20:13:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 19:13:16 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 20:13:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 19:13:18 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59201|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 59389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59389&action=edit [SIGNED-OFF] Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT Signed-off-by: Caitlin Goodger Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 21:03:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 20:03:07 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 --- Comment #2 from M. Tompsett --- Comment on attachment 58723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58723 Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls Review of attachment 58723: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17872&attachment=58723) ----------------------------------------------------------------- ::: admin/aqbudgets.pl @@ +237,4 @@ > ); > > my @budgets = @{ > + GetBudgetHierarchy( $$period{budget_period_id}, C4::Context->userenv->{branch}, ( $show_mine ? $borrower_id : 0 )) Really don't like C4::Context->userenv->{branch}! Can this code be triggered by a test which isn't "logged in"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 21:46:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 20:46:52 +0000 Subject: [Koha-bugs] [Bug 17711] Add othermirror option to build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17711 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 21:48:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 20:48:39 +0000 Subject: [Koha-bugs] [Bug 17085] Specify libmojolicious-perl min version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17085 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 23:23:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 22:23:26 +0000 Subject: [Koha-bugs] [Bug 17066] build-git-snapshot: add basetgz parameter and update master version number for 3.22.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17066 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 23:23:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 22:23:20 +0000 Subject: [Koha-bugs] [Bug 17711] Add othermirror option to build-git-snapshot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17711 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 20 23:23:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 20 Jan 2017 22:23:35 +0000 Subject: [Koha-bugs] [Bug 17019] debian/changelog update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 21 08:31:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Jan 2017 07:31:24 +0000 Subject: [Koha-bugs] [Bug 17953] New: Blank Gedit Text Editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17953 Bug ID: 17953 Summary: Blank Gedit Text Editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: asifcp80 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When the koha installation from web i get the blank 'Gedit text editor'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 21 09:55:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Jan 2017 08:55:29 +0000 Subject: [Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #8 from Zeno Tajoli --- (In reply to Marcel de Rooy from comment #7) > This makes me think about a solution with a table like below. ... > Would that address all possibilities? I think that a table like this is a good tool, I will write defaults for this table for Unimarc an MARC21. I think the problem are the classic problems to setup confing in Koha: -- SQL table with web interface ? Or only command line? -- YAML / XML FILE ? Web interface ? Or only command line ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 21 10:45:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Jan 2017 09:45:36 +0000 Subject: [Koha-bugs] [Bug 17745] Notices does not generate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17745 Litty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amalalib09 at gmail.com --- Comment #3 from Litty --- Created attachment 59390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59390&action=edit 3 books check in message is not possible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 21 14:37:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 21 Jan 2017 13:37:00 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 --- Comment #26 from Claudio --- I have already tested it in 2 production installations and in a local development one. May I sign-off this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:04:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:04:48 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove the sql code from |Remove the sql code from |onboarding and |itemtypes.pl administrative |administrative perl |perl script |scripts, and remove | |unnecessary use pragmas | |from onboarding.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:05:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:05:39 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #2 from Alex Buckley --- Created attachment 59391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59391&action=edit Bug 17944 - Moved the sql code from itemtypes.pl into Koha/ItemTypes.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:14:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:14:58 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Alex Buckley --- Test plan: 1. View the admin/itemtypes.pl script and confirm that sql code is written in this file 2. Apply this patch 3. View admin/itemtypes.pl script notice the sql code has been removed and replaced with the perl module call (on line 142): my $total = Koha::ItemTypes->check_items_and_biblioitems($itemtype_code); 4. View Koha/ItemTypes.pm and observe the subroutine check_items_and_biblioitems (This subroutine contains the sql code that was in itemtypes.pl) 5. Now to check that the deletion of an item type still works with the sql code moved out of the itemtypes.pl script, log into the Koha staff interface 6. Visit Administration->Item type. Select the 'Delete' button next to an item type 7. Select the 'Yes, delete this item type' button 8. Observe the message informing you the item type has been deleted. Thus the patch works as intended. Note: as I understand it placing the sql code into a perl module in the Koha directory is acceptable, because sql code exists in the perl modules in the C4 directory. Please advise me if this isn't the case and I will move this code again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:19:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:19:27 +0000 Subject: [Koha-bugs] [Bug 17954] New: Remove the sql code from the smart-rules.pl administrative script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 Bug ID: 17954 Summary: Remove the sql code from the smart-rules.pl administrative script Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 17855 The purpose of this bug is to remove the sql code from the smart-rules.pl administrative perl script thereby aligning it with the Koha coding guidelines. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:19:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:19:27 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 [Bug 17954] Remove the sql code from the smart-rules.pl administrative script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:19:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:19:27 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17954 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:25:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:25:26 +0000 Subject: [Koha-bugs] [Bug 17955] New: Remove the sql code and unnecessary use pragmas from the onboarding.pl script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Bug ID: 17955 Summary: Remove the sql code and unnecessary use pragmas from the onboarding.pl script Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 17855 The purpose of this bug is to remove the sql code and unnecessary use pragmas from the onboarding.pl script thereby aligning it with the Koha coding guidelines. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:25:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:25:26 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:25:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:25:26 +0000 Subject: [Koha-bugs] [Bug 17954] Remove the sql code from the smart-rules.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17955 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:25:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:25:26 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17955 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:25:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:25:52 +0000 Subject: [Koha-bugs] [Bug 17954] Remove the sql code from the smart-rules.pl administrative script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:36:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:36:57 +0000 Subject: [Koha-bugs] [Bug 17956] New: Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956 Bug ID: 17956 Summary: Provide additional functionality in the onboarding tool through configuring z-targets, and providing information on setting up SIP and LDAP services Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 17855 This bug depends on bug 17855 because this bug adds additional functionality to the onboarding tool. The additional features are: 1. A tickbox to check if the user is using SIP, LDAP. If this tickbox is selected then information on how to set up these services is displayed. 2. A z-target configuration form (which is displayed if the user did not install sample z-targets in the web installer). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 03:36:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 02:36:57 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956 [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets, and providing information on setting up SIP and LDAP services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 17:45:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 16:45:44 +0000 Subject: [Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 --- Comment #133 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 17:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 16:51:52 +0000 Subject: [Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Depends on bug 17466 which is not in 16.11.x - won't be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 17:51:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 16:51:59 +0000 Subject: [Koha-bugs] [Bug 17919] circ/returns.pl caught in Object Name crossfire In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 17:53:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 16:53:51 +0000 Subject: [Koha-bugs] [Bug 17914] The installer process tries to create borrowers.updated_on twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17914 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #7 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 17:54:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 16:54:40 +0000 Subject: [Koha-bugs] [Bug 17894] Remove and Replace WriteOffFee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17894 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 17:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 16:58:42 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 18:00:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 17:00:26 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 18:01:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 17:01:29 +0000 Subject: [Koha-bugs] [Bug 17771] Add link to bibliographic record on spent/ ordered lists in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 18:01:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 17:01:33 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #4 from M. Tompsett --- Comment on attachment 59391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59391 Bug 17944 - Moved the sql code from itemtypes.pl into Koha/ItemTypes.pm Review of attachment 59391: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17944&attachment=59391) ----------------------------------------------------------------- ::: Koha/ItemTypes.pm @@ +53,5 @@ > + ) AS tmp > + WHERE tmp.t=? > + ', {}, $itemtype_code ); > + return $total; > +} While not an easy thing, I don't even know how to do it off the top of my head, consider reworking in DBIx. Also, wouldn't this partially double count? Don't worry, this is a pre-existing issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 19:26:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 18:26:18 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I am not sure about the follow-up - + Budgets administration I wouldn't expect "Budgets administration" to lead to the acquisition start page - but to the budgets page. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 19:33:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 18:33:22 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #7 from Katrin Fischer --- I think the follow-up is not correct. - The last bit of the breadcrumb is the page you are on - so that should not be linked to the acquisition home page. - It only appears on budgets, but not on funds, the original patch was in the include for all the pages. Also not on currencies. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 19:36:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 18:36:06 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 19:41:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 18:41:15 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 19:41:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 18:41:48 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 --- Comment #7 from Katrin Fischer --- Sorry, that was a wrong C&P. Correct one: This patch has been pushed to 16.11.x and will be in 16.11.02. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 19:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 18:42:57 +0000 Subject: [Koha-bugs] [Bug 17823] XSLT: Add label for MARC 583 - Action note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |Pushed to Master --- Comment #8 from Katrin Fischer --- Ok, still not correct - this will be in 16.11.03 and not in 16.11.02 as it contains a new string to be translated. Sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 19:54:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 18:54:08 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #12 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. Fixed author's name - Emma Smith -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:03:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:03:58 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:14:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:14:14 +0000 Subject: [Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I think there is still some trace left of the -x: vagrant at kohadevbox:~$ sudo koha-rebuild-zebra -f kohadev Warning: You passed -x which is already the default and is now deprecated Waiting for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:15:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:15:34 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. Thx Caitlin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:15:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:15:59 +0000 Subject: [Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:17:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:17:17 +0000 Subject: [Koha-bugs] [Bug 8266] remove location from pull down on search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:22:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:22:43 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #33 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.02. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:29:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:29:39 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #354 from Katrin Fischer --- Decided to push latest updates to stable as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:30:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:30:12 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:33:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:33:03 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #32 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:33:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:33:29 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #33 from Katrin Fischer --- I couldn't test this, trusting the tests, please don't disappoint! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:38:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:38:34 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #42 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.02. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:39:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:39:53 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- Contains strings - will check later if this is a candidate for 16.11.03. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:45:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:45:26 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer --- I am in doubt about the last patch here - description says marc (true for 16.11) but patch says marcxml (untrue for 16.11). Can someone clarify if this should be included in the next 16.11.x release? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:53:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:53:17 +0000 Subject: [Koha-bugs] [Bug 17836] (ILSDI) 'charges' always '1' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer --- Error doesn't exist in 16.11.x - it looks like it has been introduced by http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=41493004f69caf471e8d73b7db2a64e433f57465#patch2 which was after the release of 16.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:56:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:56:03 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.02. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 20:59:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 19:59:35 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #29 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.02. . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:07:27 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #61 from Katrin Fischer --- This adds a new system preference, but is marked as a bug (not enh). I think too dangerous now to push right before release as I lack time for properly testing this myself. Please find me and let's talk about what this patch set does fix, if you want it included in 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:09:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:09:33 +0000 Subject: [Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:12:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:12:49 +0000 Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Bug 17792 depends on bug 17813, which changed state. Bug 17813 Summary: Table borrower_attributes needs a primary key https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:12:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:12:49 +0000 Subject: [Koha-bugs] [Bug 17813] Table borrower_attributes needs a primary key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17813 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #11 from Katrin Fischer --- I have changed this to 'enh' as I think while it's needed to move forward it's not fixing a bug at the moment (false testable behaviour). Not including this in 16.11.2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:16:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:16:51 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.02. Couldn't reproduce the error on kohadevbox, but patches still pass after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:25:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:25:24 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer --- This definitely works better than before, but there is an oddness. For testing this, I set 'acceptedby' to another use. This made no difference. I had to change 'managedby' as well, then it worked. It appears that the 'order by suggestion' page uses managedby instead of acceptedby for determining if you can see the suggestion? Anyway, improvement! This patch has been pushed to 16.11.x and will be in 16.11.02. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:28:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:28:33 +0000 Subject: [Koha-bugs] [Bug 17487] Improper placement of select/clear all in Z39.50/ SRU search dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- Contains strings - holding this back for possible inclusion in 16.11.3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:29:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:29:47 +0000 Subject: [Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Bug 17951 depends on bug 7533, which changed state. Bug 7533 Summary: Add template_cache_dir to the koha-conf.xml file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:29:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:29:47 +0000 Subject: [Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819 Bug 17819 depends on bug 7533, which changed state. Bug 7533 Summary: Add template_cache_dir to the koha-conf.xml file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:29:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:29:46 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #15 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:31:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:31:03 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Bug 16749 depends on bug 16733, which changed state. Bug 16733 Summary: More flexible paths in debian scripts (for dev installs) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:31:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:31:02 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #28 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:31:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:31:03 +0000 Subject: [Koha-bugs] [Bug 17049] Improve PERL5LIB handling for packaged dev install ( follow-up for 16733) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17049 Bug 17049 depends on bug 16733, which changed state. Bug 16733 Summary: More flexible paths in debian scripts (for dev installs) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:32:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:32:15 +0000 Subject: [Koha-bugs] [Bug 17501] Koha Objects for uploaded files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #36 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:32:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:32:15 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Bug 15449 depends on bug 17501, which changed state. Bug 17501 Summary: Koha Objects for uploaded files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:32:16 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Bug 17669 depends on bug 17501, which changed state. Bug 17501 Summary: Koha Objects for uploaded files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:32:16 +0000 Subject: [Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673 Bug 17673 depends on bug 17501, which changed state. Bug 17501 Summary: Koha Objects for uploaded files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:33:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:33:25 +0000 Subject: [Koha-bugs] [Bug 17824] Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:33:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:33:26 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 17824, which changed state. Bug 17824 Summary: Remove C4::Members::GetBorrowersWhoHaveNeverBorrowed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17824 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:33:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:33:56 +0000 Subject: [Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 21:33:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 20:33:56 +0000 Subject: [Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Bug 16846 depends on bug 17588, which changed state. Bug 17588 Summary: Move GetMemberIssuesAndFines to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 23:51:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 22:51:50 +0000 Subject: [Koha-bugs] [Bug 17745] Notices does not generate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17745 --- Comment #4 from Katrin Fischer --- Make your your notice templates are correct - reset to the standard one if possible and try it again. It might be you are missing that you are missing the markers for the repeating section with the list of items, it should be something like: ---- <> ---- Not having the ---- will cause problems with formatting for the CHECKIN and CHECKOUT notices. If that isn't the problem, please send an email to the mailing list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 23:55:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 22:55:06 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #7 from David Cook --- _TEST PLAN_ #NOTE: You won't be able to test this using a Gitifid Koha, since it's an update to Zebra files. If you're using a Gitifid Koha, you'll have to apply the patch manually. 0) Install YAZ with a version >= 5.8.1 and < 5.20.0*. 1) Build Koha from source using "make" 2) Ensure that Zebra facets are turned on in koha-conf.xml 3) Try to search in the OPAC, and note that no facets appear 4) Apply th patch 5) Build Koha from source using "Make" 6) Try to search in the OPAC, and note that facets now appear *If you're using Indexdata's Debian repository, you'll need to pin the package so that you don't install the 5.20.0 where the software bug in YAZ itself is actually fixed, since we're testing configuration as a fix here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 22 23:55:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 22:55:32 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 --- Comment #7 from Katrin Fischer --- Hi Joseph, we fixed Bug 17817 - Repeat this Tag (cloning) not working after I tested this, it's possible that this fixed the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 00:06:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 22 Jan 2017 23:06:42 +0000 Subject: [Koha-bugs] [Bug 17953] Blank Gedit Text Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Hi Asif, please send your question to the koha mailing list as much more people will read it there and can help you find a solution. - Bugzilla is for tracking bugs and enhancement requests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 02:05:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 01:05:45 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au --- Comment #7 from Bob Birchall --- (In reply to Alex Sassmannshausen from comment #6) > Hello, > > PTFS Europe is working on ILL functionality within Koha. See the URL above > for a link to the RFC. > > Best wishes, > > Alex Is there any update here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 02:41:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 01:41:29 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59055|0 |1 is obsolete| | --- Comment #48 from Srdjan Jankovic --- Created attachment 59392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59392&action=edit bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron * Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 02:41:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 01:41:45 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59056|0 |1 is obsolete| | --- Comment #49 from Srdjan Jankovic --- Created attachment 59393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59393&action=edit bug_16034 Adding a new syspref - OverDriveCirculation If set to true, Opac will integrate OverDrive patron services Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 02:42:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 01:42:03 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59057|0 |1 is obsolete| | --- Comment #50 from Srdjan Jankovic --- Created attachment 59394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59394&action=edit bug_16034 Add overdrive info to the users page in the public interface Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 02:42:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 01:42:16 +0000 Subject: [Koha-bugs] [Bug 16034] Integration with OverDrive Patron API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59058|0 |1 is obsolete| | --- Comment #51 from Srdjan Jankovic --- Created attachment 59395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59395&action=edit Bug 16034 follow-up: added WebService::ILS to PerlDependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 08:32:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 07:32:38 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #62 from Marcel de Rooy --- Makes sense not to push it one day before release. But apart from the new syspref, it might well be a patch set to consider for backporting. Solves several authority merge errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 08:35:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 07:35:18 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #18 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #17) > I am in doubt about the last patch here - description says marc (true for > 16.11) but patch says marcxml (untrue for 16.11). > > Can someone clarify if this should be included in the next 16.11.x release? The last patch is not for 16.11. If you have a failing Circulation test in 16.11, the first two might help you solve it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 08:53:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 07:53:59 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 --- Comment #3 from Marcel de Rooy --- (In reply to M. Tompsett from comment #2) > Comment on attachment 58723 [details] [review] > Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls > > Review of attachment 58723 [details] [review]: > ----------------------------------------------------------------- > > ::: admin/aqbudgets.pl > @@ +237,4 @@ > > ); > > > > my @budgets = @{ > > + GetBudgetHierarchy( $$period{budget_period_id}, C4::Context->userenv->{branch}, ( $show_mine ? $borrower_id : 0 )) > > Really don't like C4::Context->userenv->{branch}! > Can this code be triggered by a test which isn't "logged in"? Corrects the even worse userenv->{branchcode}. This code cannot be reached when you are not logged in. Would you feel better with: my $userenv = C4::Context->userenv; my $branch = $userenv ? $userenv->{branch} : undef; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 08:56:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 07:56:24 +0000 Subject: [Koha-bugs] [Bug 17957] New: template_cache_dir should be better configured for package Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17957 Bug ID: 17957 Summary: template_cache_dir should be better configured for package Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This is a follow-up of bug 7533. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 08:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 07:57:51 +0000 Subject: [Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- *** Bug 17957 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 08:57:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 07:57:51 +0000 Subject: [Koha-bugs] [Bug 17957] template_cache_dir should be better configured for package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17957 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 17951 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 08:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 07:58:42 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 --- Comment #16 from Jonathan Druart --- (In reply to Kyle M Hall from comment #14) > Pushed to master for 17.05, thanks Jonathan! Would you be able to add a > followup bug to store the cache in /var/lib/koha/$site/template_cache or > something like that for packages? Tomas opened bug 17951. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:00:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:00:16 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > This won't get ported back to 16.11.x as it is an enhancement. I think this one should be backported to the stable branches, it will not hurt and could highlight performance boost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:06:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:06:40 +0000 Subject: [Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE --- Comment #42 from Marcel de Rooy --- Can be closed now: see omnibus bug 17908 and especially bug 17913 *** This bug has been marked as a duplicate of bug 17913 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:06:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:06:40 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #63 from Marcel de Rooy --- *** Bug 5572 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:06:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:06:42 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Bug 17908 depends on bug 5572, which changed state. Bug 5572 Summary: Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:07:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:07:38 +0000 Subject: [Koha-bugs] [Bug 5572] Improve C4::AuthoritiesMarc->merge() + syspref AuthCleanBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:09:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:09:09 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|BLOCKED |RESOLVED --- Comment #13 from Marcel de Rooy --- Can be closed now: see omnibus bug 17908 and especially 17913 *** This bug has been marked as a duplicate of bug 17913 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:09:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:09:09 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla at live.ca --- Comment #64 from Marcel de Rooy --- *** Bug 11315 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:09:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:09:11 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Bug 17908 depends on bug 11315, which changed state. Bug 11315 Summary: Add support for subfield deletion when doing authority merges. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:09:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:09:21 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:09:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:09:59 +0000 Subject: [Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > I think there is still some trace left of the -x: > > vagrant at kohadevbox:~$ sudo koha-rebuild-zebra -f kohadev > Warning: You passed -x which is already the default and is now deprecated > > Waiting for feedback. You are not using the patched scripts if you did not copy the debian scripts. sudo which koha-rebuild-zebra /usr/sbin/koha-rebuild-zebra -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:10:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:10:27 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #72 from Marcel de Rooy --- Can be closed now: see omnibus bug 17908 and bug 17913 *** This bug has been marked as a duplicate of bug 17913 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:10:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:10:27 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #65 from Marcel de Rooy --- *** Bug 11700 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:10:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:10:29 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Bug 7419 depends on bug 11700, which changed state. Bug 11700 Summary: C4::AuthoritiesMarc::merge enhancements/fixes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:10:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:10:31 +0000 Subject: [Koha-bugs] [Bug 13706] Deduping authorities script (dedup_authorities.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Bug 13706 depends on bug 11700, which changed state. Bug 11700 Summary: C4::AuthoritiesMarc::merge enhancements/fixes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:10:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:10:31 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Bug 17908 depends on bug 11700, which changed state. Bug 11700 Summary: C4::AuthoritiesMarc::merge enhancements/fixes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:10:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:10:53 +0000 Subject: [Koha-bugs] [Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:18:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:18:13 +0000 Subject: [Koha-bugs] [Bug 17872] Fix small error in GetBudgetHierarchy and one of its calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 --- Comment #4 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > Really don't like C4::Context->userenv->{branch}! > Can this code be triggered by a test which isn't "logged in"? You have to be logged in to see this view. That would be a completely unnecessary test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:27:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:27:06 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #29 from Jonathan Druart --- (In reply to Katrin Fischer from comment #28) > This won't get ported back to 16.11.x as it is an enhancement. It would be very useful for devs to get it backported to stable releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:30:43 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 --- Comment #18 from Paul Poulain --- (In reply to Jonathan Druart from comment #17) > (In reply to Katrin Fischer from comment #15) > > This won't get ported back to 16.11.x as it is an enhancement. > > I think this one should be backported to the stable branches, it will not > hurt and could highlight performance boost. I agree with Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:39:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:39:17 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #30 from Marcel de Rooy --- I have no strong opinion on it, but I am using a rebased version on 3.22 in production. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 09:40:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 08:40:07 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart --- Please see comment 6 for a better solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 10:00:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 09:00:06 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #19 from Katrin Fischer --- We got a happy Jenkins for 16.11.x and locally the tests pass for me as well - so there seems no need atm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 10:06:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 09:06:13 +0000 Subject: [Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 10:06:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 09:06:22 +0000 Subject: [Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 --- Comment #5 from Jonathan Druart --- Created attachment 59396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59396&action=edit Bug 16115: Remove JS error on item search if LOC does not exist If LOC is not present, the item search form will raise a JS error: SyntaxError: expected expression, got '}' This patch fixes it by handling this specific case. Note that the "Status" column is still displayed. Test plan: Remove your LOC authorised values Go on the item search form => You will not get the JS error and the "Status" bloc is no longer displayed. There is no need to display it if empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 10:20:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 09:20:15 +0000 Subject: [Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 10:38:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 09:38:35 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |synapse.ova at gmail.com --- Comment #148 from Oleg Vasilenko --- In UNIMARC XSLT trasformation on page opac-detail.pl fails with software error Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> at /usr/share/perl5/MARC/File/XML.pm line 568. Error occurs if subfield 100$a is made invisible in OPAC. Yet there is no problem with MARC-view and ISBD view Should this be a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 10:48:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 09:48:25 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 10:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 09:50:05 +0000 Subject: [Koha-bugs] [Bug 17726] TestBuilder's refactoring removed default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17726 --- Comment #20 from Jonathan Druart --- They certainly fail if SearchEngine == ElasticSearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:02:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:02:11 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #149 from Jonathan Druart --- (In reply to Oleg Vasilenko from comment #148) > Should this be a new bug? Hi Oleg, This bug report is marked as pushed to master and the error you got does not seem related. So yes, please open a new bug report or email the list if you have a specific problem. Your problem is usually caused by the fact to have the "marcflavour" system preference set to UNIMARC but you have MARC21 records in your DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:06:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:06:29 +0000 Subject: [Koha-bugs] [Bug 17731] Remove the noxml option from rebuild_zebra.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17731 --- Comment #7 from Katrin Fischer --- I will try that, thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:14:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:14:14 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #31 from Katrin Fischer --- Can you explain why this is helpful? More worried about breaking something for the non-devs to be honest - devs always find a way ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:18:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:18:00 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 --- Comment #19 from Katrin Fischer --- After looking at the patches they seem safe, so I will probably push in the next few days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:18:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:18:19 +0000 Subject: [Koha-bugs] [Bug 17819] Performance 16.11 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17819 Bug 17819 depends on bug 7533, which changed state. Bug 7533 Summary: Add template_cache_dir to the koha-conf.xml file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:18:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:18:19 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:18:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:18:20 +0000 Subject: [Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Bug 17951 depends on bug 7533, which changed state. Bug 7533 Summary: Add template_cache_dir to the koha-conf.xml file https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:18:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:18:29 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:18:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:18:49 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:18:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:18:57 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:19:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:19:16 +0000 Subject: [Koha-bugs] [Bug 7533] Add template_cache_dir to the koha-conf.xml file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7533 --- Comment #20 from Katrin Fischer --- Wow, it's hard to get from RESOLVED FIXED back to "Pushed to master"! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:33:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:33:09 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #32 from Jonathan Druart --- (In reply to Katrin Fischer from comment #31) > Can you explain why this is helpful? > More worried about breaking something for the non-devs to be honest - devs > always find a way ;) Typically to avoid the issue you just got on bug 17731 :) With these patches the debian script will execute the rebuild_zebra script from the gitified repo and not from the /usr/share/koha dir. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:48:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:48:49 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 --- Comment #2 from Marcel de Rooy --- Created attachment 59398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59398&action=edit Bug 17950: Merge.t: Improve variable handling at top level This patch does: [1] Remove unused $dbh. [2] Move all mocking statements to one sub. [3] Promote a few lexicals to globals when used in the subtests. Test plan: Run t/db_dependent/Authorities/Merge.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:48:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:48:46 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 --- Comment #1 from Marcel de Rooy --- Created attachment 59397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59397&action=edit Bug 17950: Improve quick UNIMARC fix in Merge.t Bug 17909 and 17913 added a quick fix for Merge.t on UNIMARC records. This patch improves that fix with the sub compare_fields, a merge from compare_field_count and compare_field_order. Also it adds the option to test MARC21/UNIMARC by adding a command line switch that triggers mocking the marcflavour preference. The test on a cleared field 609 in strict mode has been broken up in two tests: first a count without 609 and then counting 609s only. Note: Could have mocked GetMarcBiblio too, but decided to go this way. Test plan: [1] Run perl t/db_dependent/Authorities/Merge.t [2] (For UNIMARC users:) Run perl Merge.t -flavour MARC21 [3] (For others:) Run perl Merge.t -flavour UNIMARC Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:50:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:50:18 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #150 from Oleg Vasilenko --- Hi Jonathan, This the problem with UNIMARC 100$a is connected with this patch, because this problem started after this bug 11592 was pushed to master. Removing this patch solved problem until I found the reason why it happens. It appears, that after filtering (rows 92-100), record is passed to XSLT processing (rows 152-163), and it already lacks field 100$a (it was filtered before). SetUTF8Flag (row 147) does not add filtered 100$a. So right now turning 100$a OPAC visibility off leads to error when user accesses opac-detail.pl. There is no problems with opac-MARCdetail.pl and opac-ISBDdetail.pl???subfield is hidden correctly. So should I create a new bug? (In reply to Jonathan Druart from comment #149) > (In reply to Oleg Vasilenko from comment #148) > > Should this be a new bug? > > Hi Oleg, > This bug report is marked as pushed to master and the error you got does not > seem related. So yes, please open a new bug report or email the list if you > have a specific problem. > Your problem is usually caused by the fact to have the "marcflavour" system > preference set to UNIMARC but you have MARC21 records in your DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:50:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:50:49 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59398|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 59399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59399&action=edit Bug 17950: Merge.t: Improve variable handling at top level This patch does: [1] Remove unused $dbh. [2] Move all mocking statements to one sub. [3] Promote a few lexicals to globals when used in the subtests. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:51:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:51:20 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:51:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:51:47 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:52:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:52:13 +0000 Subject: [Koha-bugs] [Bug 17891] typo in housebound.tt div tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 [Bug 5670] Housebound Readers Module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:52:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:52:13 +0000 Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891 [Bug 17891] typo in housebound.tt div tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:52:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:52:29 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 --- Comment #4 from Marcel de Rooy --- Julian: Would the second patch meet your concerns sufficiently? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:54:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:54:51 +0000 Subject: [Koha-bugs] [Bug 16018] merges not modifying biblios properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 --- Comment #11 from Marcel de Rooy --- Planning to get back here this week -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:56:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:56:06 +0000 Subject: [Koha-bugs] [Bug 17958] New: Add the Koha::Letter[s] packages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Bug ID: 17958 Summary: Add the Koha::Letter[s] packages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Just add basic Koha::Letter[s] packages using Koha::Object[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 11:57:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 10:57:20 +0000 Subject: [Koha-bugs] [Bug 17959] New: Add the Koha::MessageQueue[s] packages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 Bug ID: 17959 Summary: Add the Koha::MessageQueue[s] packages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Just add basic Koha::MessageQueue[s] packages using Koha::Object[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:01:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:01:03 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 --- Comment #8 from Kyle M Hall --- (In reply to Katrin Fischer from comment #7) > I think the follow-up is not correct. > > - The last bit of the breadcrumb is the page you are on - so that should not > be linked to the acquisition home page. > - It only appears on budgets, but not on funds, the original patch was in > the include for all the pages. Also not on currencies. Agreed. The problem is that the budget and fund links are technically administration sections, where the rest are actually acquisitions. This make the breadcrumb linked more complicated than it should be ; ) Katrin, would you recommend I simply revert the followup, or do you have another recommendation? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:01:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:01:59 +0000 Subject: [Koha-bugs] [Bug 17960] New: Rename opac_news.new Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Bug ID: 17960 Summary: Rename opac_news.new Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The field opac_news.new is very confusing and should be renamed. If you want to access it via Koha::NewsItem you will have trouble: use Koha::News; my $news_item = Koha::News->next; say $news_item->new; => Attempt to bless into a reference at /home/vagrant/kohaclone/Koha/Object.pm line 78. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:02:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:02:01 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58718|0 |1 is obsolete| | CC| |colin.campbell at ptfs-europe. | |com --- Comment #8 from Colin Campbell --- Created attachment 59400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59400&action=edit Signed off patch Signed off - tested patch worked both against versions of yaz exhibiting the bug and an older release which did not exhibit it both provided facets with the config change in place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:02:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:02:52 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Colin Campbell --- Update status to Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:08:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:08:36 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #151 from Jonathan Druart --- (In reply to Oleg Vasilenko from comment #150) > So should I create a new bug? Yes please, and link it ("Depends on") to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:29:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:29:36 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 --- Comment #5 from Julian Maurice --- (In reply to Marcel de Rooy from comment #4) > Julian: Would the second patch meet your concerns sufficiently? Absolutely :) Having the mock objects initialized in the sub where they are used looks better IMO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:37:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:37:17 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Letter[s] packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 --- Comment #1 from Jonathan Druart --- Created attachment 59401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59401&action=edit Bug 17958: Add Koha::Letter[s] packages This just add Koha::Letter[s] for later uses. Test plan: prove t/db_dependent/Koha/Letters.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:37:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:37:11 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Letter[s] packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:37:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:37:25 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Letter[s] packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 --- Comment #2 from Jonathan Druart --- Created attachment 59402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59402&action=edit Bug 17958: Add tests for Koha::Letter[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:44:06 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #9 from Katrin Fischer --- Funds, budgets and currencies being in administration and not in acquisitions is a problem we run into every now and then - like with permissions or now the breadcrumbs. I have seen people get stuck there, so a link could indeed be helpful. I think the first patch would work for now, but we should fix capitalization in a follow-up :) Maybe we could divide the side navigation into 'Administration' and 'Acquisitions' sections to make it a little easier to understand the differences? Adding Owen in hope he has an idea. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 12:53:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 11:53:05 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle.m.hall at gmail.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:03:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:03:22 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Letter[s] packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17959 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:03:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:03:22 +0000 Subject: [Koha-bugs] [Bug 17959] Add the Koha::MessageQueue[s] packages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:03:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:03:38 +0000 Subject: [Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the |Add the |Koha::MessageQueue[s] |Koha::Notice::Message[s] |packages |packages (message_queue | |table) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:04:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:04:19 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the Koha::Letter[s] |Add the |packages |Koha::Notice::Template[s] | |packages (letter table) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:14:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:14:00 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59401|0 |1 is obsolete| | Attachment #59402|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59403&action=edit Bug 17958: Add Koha::Notice::Template[s] packages (letter table) This just add Koha::Letter[s] for later uses. Test plan: prove t/db_dependent/Koha/Notices.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:14:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:14:25 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 --- Comment #4 from Jonathan Druart --- Created attachment 59404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59404&action=edit Bug 17958: Add tests for Koha::Notice::Template[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:20:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:20:05 +0000 Subject: [Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 --- Comment #1 from Jonathan Druart --- Created attachment 59405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59405&action=edit Bug 17959 - Add the Koha::Notice::Message[s] packages (message_queue table) This just add Koha::Notice::Message[s] for later uses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:19:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:19:59 +0000 Subject: [Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:26:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:26:23 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:26:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:26:23 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 [Bug 17960] Rename opac_news.new -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:46:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:46:17 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 [Bug 17927] REST API: /holds and /patrons attributes have wrong types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:46:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:46:17 +0000 Subject: [Koha-bugs] [Bug 17927] REST API: /holds and /patrons attributes have wrong types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 [Bug 17932] Koha::Object should provide a TO_JSON method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:58:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:58:27 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:58:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:58:33 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #1 from Jonathan Druart --- Created attachment 59406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59406&action=edit Bug 17960: Add a test to highlight the issue With only this patch applied, proving t/db_dependent/Koha/News.t will return "Attempt to bless into a reference at /home/vagrant/kohaclone/Koha/Object.pm line 78." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:58:40 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #2 from Jonathan Druart --- Created attachment 59407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59407&action=edit Bug 17960: Rename opac_news.new with opac_news.content The field opac_news.new is very confusing and should be renamed. If you want to access it via Koha::NewsItem you will have trouble: use Koha::News; my $news_item = Koha::News->next; say $news_item->new; => Attempt to bless into a reference at /home/vagrant/kohaclone/Koha/Object.pm line 78. This patchset is going to rename this DB field to opac_news_content instead. Since the opac_news.new can be used in notice templates, we need to warn the user during the update DB process that some templates must be updated. Test plan: 0/ Apply the first patch "Add a test to highlight the issue" and confirm that the test fail 1/ Apply this second patch 2/ Execute the DB entry 3/ Confirm that you get a warning if at least one of your notice templates is using opac_news.new 4/ Confirm that the test new pass 5/ Add/update and delete a news 6/ Confirm that the RSS new feed still works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:58:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:58:58 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #4 from Jonathan Druart --- Created attachment 59409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59409&action=edit Bug 17960: DBIC Schema changes for opac_news.content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 13:58:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 12:58:51 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #3 from Jonathan Druart --- Created attachment 59408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59408&action=edit Bug 17960: Update installed files git grep opac_news.new installer should not return any occurrences in sql files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:00:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:00:11 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename opac_news.new |Rename opac_news.new with | |opac_news.content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:07:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:07:26 +0000 Subject: [Koha-bugs] [Bug 17961] New: TT syntax for notices - Prove we have an equivalent for our historical custom syntax Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Bug ID: 17961 Summary: TT syntax for notices - Prove we have an equivalent for our historical custom syntax Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 15278 This bug report is an omnibus. It will link to bug reports which take care of the migration to the TT syntax for notices. For each special marker we have in our historical custom syntax, an equivalence will be provided. Moreover tests will cover all the changes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:07:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:07:26 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:08:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:08:56 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 --- Comment #1 from Jonathan Druart --- To achieve this work, I used the notices from the wiki: https://wiki.koha-community.org/wiki/Notices_and_Slips_Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:10:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:10:03 +0000 Subject: [Koha-bugs] [Bug 17962] New: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Bug ID: 17962 Summary: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:11:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:11:50 +0000 Subject: [Koha-bugs] [Bug 17963] New: TT syntax for notices - Prove that AR_* are compatible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Bug ID: 17963 Summary: TT syntax for notices - Prove that AR_* are compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:12:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:12:08 +0000 Subject: [Koha-bugs] [Bug 17964] New: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Bug ID: 17964 Summary: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:12:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:12:27 +0000 Subject: [Koha-bugs] [Bug 17965] New: TT syntax for notices - Prove that DUEGST is compatible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Bug ID: 17965 Summary: TT syntax for notices - Prove that DUEGST is compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:13:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:13:44 +0000 Subject: [Koha-bugs] [Bug 17966] New: TT syntax for notices - Prove that ISSUESLIP is compatible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Bug ID: 17966 Summary: TT syntax for notices - Prove that ISSUESLIP is compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:16:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:16:33 +0000 Subject: [Koha-bugs] [Bug 17967] New: TT syntax for notices - Prove that ODUE is compatible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Bug ID: 17967 Summary: TT syntax for notices - Prove that ODUE is compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:20:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:20:37 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #3 from Owen Leonard --- (In reply to M. Tompsett from comment #2) > Why is "select all data" a link and not a button? Because everywhere else in Koha "select all" is a link. > Next why are the texts staff and superlibrarian (different pages) differing > styles? Since I'm not following along with you I don't know what screen you're looking at when you make comments. Can you please be specific about where you're seeing these issues? > Don't you love the set koha version text? :( Can you please explain this comment? Are you making a suggestion? Pointing out a mistake? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:20:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:20:55 +0000 Subject: [Koha-bugs] [Bug 17968] New: Remove useless variable in C4::Overdues:: parse_overdues_letter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Bug ID: 17968 Summary: Remove useless variable in C4::Overdues::parse_overdues_letter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org There is a $item_format which is never used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:21:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:21:15 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 [Bug 12933] Add ability to print overdue slip from staff intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:21:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:21:15 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:25:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:25:23 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:25:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:25:30 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 --- Comment #1 from Jonathan Druart --- Created attachment 59410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59410&action=edit Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep ` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:30:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:30:11 +0000 Subject: [Koha-bugs] [Bug 17969] New: Refactor the way <> is generated Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Bug ID: 17969 Summary: Refactor the way <> is generated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org <> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:51:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:51:27 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #66 from Marcel de Rooy --- Created attachment 59411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59411&action=edit Bug 17913: [16.11.x] Authority merge fix [PUSHED_17.05] Squashed into one patch for 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:52:06 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #67 from Marcel de Rooy --- Created attachment 59412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59412&action=edit Bug 17913: [16.05.x] Authority merge fix [PUSHED_17.05] Squashed into one patch for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:52:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:52:37 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #68 from Marcel de Rooy --- Created attachment 59413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59413&action=edit Bug 17913: [3.22.x] Authority merge fix [PUSHED_17.05] Squashed into one patch for 3.22.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:53:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:53:20 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:53:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:53:31 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:53:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:53:37 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:53:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:53:43 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:53:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:53:49 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:53:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:53:54 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:53:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:53:59 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:54:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:54:04 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:56:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:56:34 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #69 from Marcel de Rooy --- NOTE FOR RELEASE MAINTAINERS: I backported the master version to my own 3.22.x branch. Have tested it on 3.22.x. Will start using it in production soon. Have rebased it afterwards on 16.05 and 16.11 WITHOUT testing it. It still needs a DBREV that adds the pref. You can copy that from the first master patch here. Please verify the patch by 1) using the Merge.t and 2) following the test plan on the "Run perltidy" master patch. Note: The patches for housekeeping and perltidy have not been applied to the AuthoritiesMarc.pm code. Hope this is helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 14:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 13:59:06 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #70 from Marcel de Rooy --- And obviously, please push 17909 to 3.22/16.05 before trying the above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:02:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:02:01 +0000 Subject: [Koha-bugs] [Bug 17969] Refactor the way <> is generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:02:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:02:09 +0000 Subject: [Koha-bugs] [Bug 17969] Refactor the way <> is generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 --- Comment #1 from Jonathan Druart --- Created attachment 59414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59414&action=edit Bug 17969: Refactor the way <> is generated <> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <> tag for advance and overdue notices. The generated notices must be the same as before this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:04:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:04:39 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55928|0 |1 is obsolete| | Attachment #56851|0 |1 is obsolete| | Attachment #56852|0 |1 is obsolete| | Attachment #57125|0 |1 is obsolete| | Attachment #58132|0 |1 is obsolete| | Attachment #59093|0 |1 is obsolete| | Attachment #59097|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall --- Created attachment 59415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59415&action=edit Bug 15503: Grab Item Information from Order Files The goal of this development is to automatically generate items in Koha with populated information based on a 9XX field and subfield, with the new syspref MarcItemFieldsToOrder. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:04:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:04:48 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #61 from Kyle M Hall --- Created attachment 59416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59416&action=edit Bug 15503 - Fix adding multiple items in multiple biblios. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:04:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:04:52 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #62 from Kyle M Hall --- Created attachment 59417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59417&action=edit Bug 15503 [QA Followup] - Remove the use of GetBranchesLoop Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:04:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:04:56 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #63 from Kyle M Hall --- Created attachment 59418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59418&action=edit Bug 15503 [Followup] - Add replacementprice and itemcallnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:05:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:05:01 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #64 from Kyle M Hall --- Created attachment 59419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59419&action=edit Bug 15503 [QA Followup] - Display "uneven number of fields" error only in relevant biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:05:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:05:06 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #65 from Kyle M Hall --- Created attachment 59420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59420&action=edit Bug 15503 [QA Followup] - Set itype and ccode properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:05:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:05:11 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #66 from Kyle M Hall --- Created attachment 59421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59421&action=edit Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch notforloan values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:26:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:26:10 +0000 Subject: [Koha-bugs] [Bug 17970] New: GetPreparedLetter does not warn when expected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Bug ID: 17970 Summary: GetPreparedLetter does not warn when expected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org >From C4::Letters::GetPreparedLetter: my $tables = $params{tables}; my $substitute = $params{substitute}; $tables || $substitute || $repeat or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute' are empty" ), return; So if the parameter tables or substitute is passed but does not contain anything, it will not warn as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:28:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:28:07 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:28:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:28:12 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 --- Comment #1 from Jonathan Druart --- Created attachment 59422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59422&action=edit Bug 17970: Add tests to highlight the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:28:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:28:19 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 --- Comment #2 from Jonathan Druart --- Created attachment 59423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59423&action=edit Bug 17970: Fix GetPreparedLetter behavior if nothing to substitute >From C4::Letters::GetPreparedLetter: my $tables = $params{tables}; my $substitute = $params{substitute}; $tables || $substitute || $repeat or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute' are empty" ), return; So if the parameter tables or substitute is passed but does not contain anything, it will not warn as expected. Test plan: 1/ Apply the patch with tests 2/ Confirm that they do not pass 3/ Apply this patch 4/ Confirm that the tests now pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:31:12 +0000 Subject: [Koha-bugs] [Bug 17971] New: TT syntax for notices - Add support for plurals Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Bug ID: 17971 Summary: TT syntax for notices - Add support for plurals Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org On of the awesome things we will be able to do with the TT syntax is the support of plurals. For instance we will be able to send a list of items, checkouts, etc. to the notice template. That way we will get rid of our custom syntax like <> or for instance. The existing code already has the playground for that but it is not used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:35:20 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 --- Comment #27 from Barton Chittenden --- (In reply to Paul Poulain from comment #26) > (In reply to Barton Chittenden from comment #24) > > There's also a title in the borrowers table -- as in "Mr.", "Mrs.", "Dr." > > etc. I don't think that this is likely to cause problems with translation; > > the context is entirely different, but it's annoying when you join borrowers > > to a query that already has "title" in the select statement, and suddenly > > need to qualify that... > > In french we use the word "civilit?". google translate says it can be > translated to "civility". Is it a valid possibility ? Unfortunately that doesn't work in English, but 'appelation' or 'honorific' might work (I feel like there's another common term besides title... it's on the tip of my tongue, but I can't seem to find it). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:37:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:37:30 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #3 from Owen Leonard --- > - (in [% mylibraryfirst %] only) > + (in [% LibraryNameTitle %] only) As M. Tompsett says, [% LibraryNameTitle %] is not going to show you the name of the user's library branch, but the name of the library "system" in a multi-branch situation. The suggestion is to use this instead: (in [% Branches.GetName( mylibraryfirst ) %] only) This uses a template plugin to pull the correct library branch name based on the branchcode output by 'mylibraryfirst' Because this patch doesn't work as expected, I'm setting this to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:42:28 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59422|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59424&action=edit Bug 17970: Add tests to highlight the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:43:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:43:31 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59424|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 59425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59425&action=edit Bug 17970: Add tests to highlight the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:52:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:52:54 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 [Bug 17971] TT syntax for notices - Add support for plurals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:52:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:52:54 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17958, 17970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 [Bug 17970] GetPreparedLetter does not warn when expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 15:52:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 14:52:54 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 [Bug 17971] TT syntax for notices - Add support for plurals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:05:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:05:06 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:05:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:05:14 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 --- Comment #1 from Jonathan Druart --- Created attachment 59426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59426&action=edit Bug 17971: TT syntax for notices - Add support for plurals On of the awesome things we will be able to do with the TT syntax is the support of plurals. For instance we will be able to send a list of items, checkouts, etc. to the notice template. That way we will get rid of our custom syntax like <> or for instance. The existing code already has the playground for that but it is not used. Basically the idea is to add a "loops" key which can contain a list of object to retrieve from the DB and send to the template. For instance: loops => { overdues => [ $itemnumber_1, .., $itemnumber_N ] } will send a variable "overdues" to the template. It will contain the Koha::Checkout objects relative to the id passed. There is one quite big inconvenient to this approach so far: since we are still supporting the historical syntax, the objects can be fetch by a script, then the script will send the id to GetPreparedLetter which will refetch them. This must be improved, but I suggest to do that later. Test plan: prove t/db_dependent/Letters/TemplateToolkit.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:05:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:05:21 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 --- Comment #2 from Jonathan Druart --- Created attachment 59427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59427&action=edit Bug 17971: Add support for objects represented by fk For instance an issue is not fetch from its fk but using the fk itemnumber. We need to support them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:11:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:11:31 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17962 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:11:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:11:31 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:25:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:25:27 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:25:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:25:33 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 --- Comment #1 from Jonathan Druart --- Created attachment 59428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59428&action=edit Bug 17962: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible To make ACQ_NOTIF_ON_RECEIV TT compatible, we need to expose data from the aqorders table. We already have a package for it in the Koha namespace but it is based on Koha::Object[s]. The other path creates dummy Koha::Tmp::Order[s] packages to make it usable. Of course we should use a valid Koha::Acquisition::Order[s] based on Koha::Object, but it's outside the scope of this bug report. This notice template is quite simple, and it's a good one to start. >From C4::Acq::NotifyOrderUsers, GetPreparedLetter is called with 4 elements: the library, the patron to notify, the biblio and the order information. Note that prior to this patch aqorders was filled from GetOrder, which retrieved a lot of information from the acquisition table (aqbasket, aqbookseller). The idea with the TT syntax is to access the data from where it really exists. So if a user wants to display the basket name, [% order.basket.basketname %] should be used instead. Note that this will not work at the moment, the basket method is not defined in the order package. However the basic template should work as before. The test added to TemplateToolkit proves that. Test plan: Use the default ACQ_NOTIF_ON_RECEIV to notify a patron that an order has been received. That generated template should be exactly the same as prior to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:25:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:25:41 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 --- Comment #2 from Jonathan Druart --- Created attachment 59429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59429&action=edit Bug 17962: Add Koha::Tmp::Order[s] These packages should not be used outside the TT syntax scope. A rewrite of Koha::Acquisition::Order[s] should be considered instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:39:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:39:18 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17962, 17959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:39:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:39:18 +0000 Subject: [Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 [Bug 17963] TT syntax for notices - Prove that AR_* are compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:39:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:39:18 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 [Bug 17963] TT syntax for notices - Prove that AR_* are compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:42:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:42:04 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 --- Comment #10 from Owen Leonard --- (In reply to Kyle M Hall from comment #8) > Katrin, would you recommend I simply revert the followup, or do you have > another recommendation? I would revert the followup. (In reply to Katrin Fischer from comment #9) > I think the first patch would work for now, > but we should fix capitalization in a follow-up :) I agree. > Maybe we could divide the side navigation into 'Administration' and > 'Acquisitions' sections to make it a little easier to understand the > differences? I'm going to submit a patch on a separate bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:42:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:42:36 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #4 from M. Tompsett --- (In reply to Owen Leonard from comment #3) > Because everywhere else in Koha "select all" is a link. Hmmm... it wasn't previously, but I see that has changed. Could we style it pretty like: Select all (grabbed from /cgi-bin/koha/members/members-home.pl) No biggie on this. > Since I'm not following along with you I don't know what screen you're > looking at when you make comments. Can you please be specific about where > you're seeing these issues? With just 17855 applied: Create a new patron category (staff) Create koha administrator patron (superlibrarian) With this applied as well: Web installer ? Create a patron category (staff) Web installer ? Create Koha administrator patron (superlibrarian) Is there a reason to have them differing styles? I sort of expected them the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:45:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:45:51 +0000 Subject: [Koha-bugs] [Bug 17972] New: Reformat acquisitions sidebar menu with acquisitions and administration sections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 Bug ID: 17972 Summary: Reformat acquisitions sidebar menu with acquisitions and administration sections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Created attachment 59430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59430&action=edit Screenshot of the proposed change Inspired by the discussion on Bug 5784 I propose reformatting the acquisitions sidebar menu so that /acqui link are in one section and /admin links are in another, with added links to the respective home pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:45:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:45:52 +0000 Subject: [Koha-bugs] [Bug 5784] link to acq from budgets & funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17972 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:48:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:48:14 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 59431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59431&action=edit Bug 17932: Add a TO_JSON method to Koha::Object(s) Bug 17927 fixes data types on the current REST endpoints. If you test those endpoints, you will notice trying to access them (for listing or retrieving single objects yields a data type error. Notably on booleans but also on integers. Integers fail due to https://rt.cpan.org/Ticket/Display.html?id=119904 but it needs some global solution until there's a DBD::mysql release backported to the supported distros. There's the option to use http://search.cpan.org/~frew/DBIx-Class-Helpers-2.033002/lib/DBIx/Class/Helper/Row/NumifyGet.pm to get the integer columns fixed as a workaround: __PACKAGE__->add_columns( borrowernumber => { data_type => 'integer', is_nullable => 0, is_numeric => 1, } ); I didn't find bug reports related to this (maybe because we don't use warnings everywhere) But I don't think is worth going such a heavy overhead. A similar situation takes place for Boolean values. They need to be prepared for JSON output. This could have been done using DBIx filters as pointed out by Martin: __PACKAGE__->filter_column( lost => { filter_to_storage => sub { $_[1] ? 1 : 0 }, filter_from_storage => sub { $_[1] ? Mojo::JSON->true : Mojo::JSON->false } } ); but this could have other consequences that are worth exploring on another bug (i.e. it would mean we need to take care of every place where this boolean data is used/set needs to handle this data types nicely. Such would be the case if we were a Mojo-only app, but we aren't. We use Koha::Obect(s) in the whole app. Period. This patch adds the need to specify on the schema files, columns that are actually boolean, because we have no way to detect them for now (i.e. they are all tinyint, but we use tinyint for non-boolean stuff too). So if this patch is accepted, we would need to specify boolean columns like this: __PACKAGE__->add_columns( '+lost' => { is_boolean => 1 } ); This patch adds a TO_JSON method for Koha::Object(s) to be used for serializing Koha::Object-derived objects into JSON strings. To test it (as Koha::Object(s) need to be instantiated) I provide tests on top of the Koha::Patron(s) classes in the followup patches. [1] Yes, we use TINYINT(1) for booleans, but from DBIC's perspective there's no way to read the (1) in runtime. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:48:21 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 59432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59432&action=edit Bug 17932: (followup) Fix /patrons endpoint Bug 17927 introduced data type fixes on the /patrons endpoint (integer and boolean types got fixed). This led to the /patrons endpoint not to work because the underlying code didn't provide the right data. With the introduction of TO_JSON on Koha::Object(s) we now have a way to output the proper data types. This patch does so by: - Adding is_boolean => 1 to the relevant columns on the Borrower.pm schema file. - Tweaking the controller class for the /patrons endpoint so it doesn't use the $object(s)->unblessed call but just let the Mojo::JSON library pick out TO_JSON implementation instead on rendering the output. - It adds a new test for booleans. To test: - Have 17927 applied - Run: $ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail [1] - Apply this patches - Run: $ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off! :-D [1] It is self explanatory to just try the API using any of the available tools (I use HttpRequester on Firefox) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:48:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:48:45 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:52:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:52:24 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:52:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:52:30 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 --- Comment #1 from Jonathan Druart --- Created attachment 59433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59433&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 16:54:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 15:54:25 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59433|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 59434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59434&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:17:20 +0000 Subject: [Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:17:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:17:22 +0000 Subject: [Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 --- Comment #1 from Owen Leonard --- Created attachment 59435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59435&action=edit Bug 17972 - Reformat acquisitions sidebar menu with acquisitions and administration sections This patch makes changes to acquisitions-menu.inc so that the style matches that of the Administration and Tools sidebar menus. The links are now divided up between Acquisitions (/acqui/) and Administration (/admin/). The link-highlighting JavaScript used elsewhere has been added. To test, apply the patch and view the Acquisitions home page. - Check that the "Acquisitions home" link is highlighted (bold). - Test the other Acquisitions links to confirm that highlighting works. - Click any link in the Administration section of the sidebar menu. - Confirm that everything looks correct and works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:21:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:21:34 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:21:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:21:42 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #1 from Jonathan Druart --- Created attachment 59436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59436&action=edit Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible >From the CHECKIN and CHECKOUT templates you should be able to access the following information: item, biblio, biblioitem, patron and library Test plan: Define CHECKIN and CHECKOUT notice templates. You should be able to define them using the TT syntax to produce the same generated notice messages as with the historical syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:21:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:21:48 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #2 from Jonathan Druart --- Created attachment 59437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59437&action=edit Bug 17964: Add old_issues If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a "old_issues" key instead of "issues". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:21:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:21:57 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 --- Comment #3 from Jonathan Druart --- Created attachment 59438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59438&action=edit Bug 17964: Support date formatting Using the KohaDates plugin will allow us to format dates as we want, using the same filters as the ones defined in the KohaDates TT plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:22:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:22:15 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 [Bug 17963] TT syntax for notices - Prove that AR_* are compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:22:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:22:15 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:23:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:23:34 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|TT syntax for notices - |TT syntax for notices - |Prove that DUEGST is |Prove that DUEDGST is |compatible |compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:26:35 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17970, 17964 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 [Bug 17970] GetPreparedLetter does not warn when expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:26:35 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:26:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:26:35 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:27:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:27:48 +0000 Subject: [Koha-bugs] [Bug 16605] All notices should give the ability to unsubscribe or flag account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16605 Agnes Rivers-Moore changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arm at hanover.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:31:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:31:52 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:32:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:32:00 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #1 from Jonathan Druart --- Created attachment 59439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59439&action=edit Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible This notice template have the particular feature of using <>. This value is substitued during the process of the notice template. For the TT syntax, all what we need is to send the values to substitute to the template. Note that items.content can also be used in these template, you can have a look at bug 17967 to see a better alternative to this marker. Test plan: Generate DUEDGST and DUE notice messages. You should be able to generate the same messages with the TT syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:32:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:32:51 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:32:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:32:51 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:33:35 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 [Bug 17971] TT syntax for notices - Add support for plurals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:33:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:33:35 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:44:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:44:43 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59434|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59440&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:56:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:56:28 +0000 Subject: [Koha-bugs] [Bug 17973] New: Add the Koha::Checkout->item method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 Bug ID: 17973 Summary: Add the Koha::Checkout->item method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:56:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:56:49 +0000 Subject: [Koha-bugs] [Bug 17974] New: Add the Koha::Item->biblio method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Bug ID: 17974 Summary: Add the Koha::Item->biblio method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:59:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:59:26 +0000 Subject: [Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 17:59:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 16:59:31 +0000 Subject: [Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 --- Comment #1 from Jonathan Druart --- Created attachment 59441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59441&action=edit Bug 17974: Add the Koha::Item->biblio method Test plan: prove t/db_dependent/Koha/Items.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:00:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:00:59 +0000 Subject: [Koha-bugs] [Bug 17973] Add the Koha::Checkout->item method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:01:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:01:07 +0000 Subject: [Koha-bugs] [Bug 17973] Add the Koha::Checkout->item method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 --- Comment #1 from Jonathan Druart --- Created attachment 59442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59442&action=edit Bug 17973: Add the Koha::Checkout->item method Test plan: prove t/db_dependent/Koha/Checkouts.t should return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:08:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:08:42 +0000 Subject: [Koha-bugs] [Bug 17973] Add the Koha::Checkout->item method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:08:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:08:42 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17974, 17973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 [Bug 17973] Add the Koha::Checkout->item method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 [Bug 17974] Add the Koha::Item->biblio method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:08:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:08:42 +0000 Subject: [Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:10:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:10:21 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:10:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:10:21 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17960 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 [Bug 17960] Rename opac_news.new with opac_news.content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:11:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:11:56 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15283 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:11:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:11:56 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:13:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:13:03 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58125|0 |1 is obsolete| | --- Comment #29 from Nick Clemens --- Created attachment 59443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59443&action=edit Bug 13937 - Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:13:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:13:12 +0000 Subject: [Koha-bugs] [Bug 13937] Add a Z39.50 daemon that can inject item status MARC subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58126|0 |1 is obsolete| | --- Comment #30 from Nick Clemens --- Created attachment 59444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59444&action=edit Bug 13937 (Followup) - Remove reference to sub _prefetch_records Remove reference to sub _prefetch_records It appears this subis built into fetch and this call is a duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:17:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:17:11 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56052|0 |1 is obsolete| | Attachment #56053|0 |1 is obsolete| | --- Comment #43 from Bouzid --- Created attachment 59445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59445&action=edit Bug 12532 - QA Follow-up Fixed tests, they now work without any fails https://bugs.koha-community.org/show_bug.cgi?id=12532 Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:18:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:18:48 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #44 from Bouzid --- Created attachment 59446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59446&action=edit Bug 12532 - Redirect guarantee email to guarantor Fixed merge conflicts. Both the guarantor and the guarantee will receive the email now. Also fixed some log errors since the "save" button is the same one use for editing the patron details. Changed the save button "save" id whene editing only the Patron messaging preferences so we can detect where the request is comming from. Added unit tests. Added an atomicupdate file. Reordered the sysprefs in alphabetical order. Refactored some code. TEST PLAN: I Apply the patch II Run updatedatabase.pl III Run db_dependent/Letters.t and db_dependant/Members.t 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville Tested together with follow-up works as expected. Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:19:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:19:40 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59445|0 |1 is obsolete| | --- Comment #45 from Bouzid --- Created attachment 59447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59447&action=edit Bug 12532 - QA Follow-up Fixed tests, they now work without any fails https://bugs.koha-community.org/show_bug.cgi?id=12532 Signed-off-by: Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:22:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:22:18 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #46 from Bouzid --- I rebase all patches and fix small problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:23:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:23:32 +0000 Subject: [Koha-bugs] [Bug 17975] New: TT syntax for notices - Prove that HOLD_SLIP is compatible Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Bug ID: 17975 Summary: TT syntax for notices - Prove that HOLD_SLIP is compatible Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:24:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:24:36 +0000 Subject: [Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17065 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065 [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:24:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:24:36 +0000 Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:25:06 +0000 Subject: [Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17065 |17965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065 [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:25:06 +0000 Subject: [Koha-bugs] [Bug 17065] Rename C4/Auth_cas_servers.yaml.orig In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17065 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:25:06 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:28:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:28:04 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50954|0 |1 is obsolete| | --- Comment #41 from Bouzid --- Created attachment 59448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59448&action=edit Bug 11297: QA follow-up - Some fixes - Makes Attributes only show up when adding a new Z39.50 server, not for SRU - Fixes typo in db documentation - Fixes sorting of table columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:29:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:29:03 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Bouzid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #42 from Bouzid --- I rebase patches, it's apply correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:31:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:31:12 +0000 Subject: [Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:31:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:31:20 +0000 Subject: [Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 --- Comment #1 from Jonathan Druart --- Created attachment 59449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59449&action=edit Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible Here we need to test <>. We already pass a value, but it was wrong. We must pass a string, not a DateTime object, otherwise the KohaDates plugin will not display the hours part if we need it. Test plan: Define a HOLD_SLIP notice template to match your need. Do not forget to use [% today | $KohaDates %] or [% today | $KohaDates with_hours => 1 %] To access data from the reserves table, use the 'hold' variable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:35:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:35:13 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17965 |17975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:35:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:35:13 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17966 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:35:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:35:13 +0000 Subject: [Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:42:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:42:28 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #2 from Jonathan Druart --- I forgot an important thing here: the items.fine value which was available in the historical syntax is no longer supported. It's of course a bug we will need to address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:57:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:57:06 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:57:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:57:13 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 --- Comment #1 from Jonathan Druart --- Created attachment 59450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59450&action=edit Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible Here we go, you will notice at the dependency list that this one is a bit different. In our former syntax we have 2 custom tags and . These tags were allowed to permit loop on the checked out items and the overdue items. In this patch, we will use the "loops" parameter, introduced by bug 17971, to pass the list of checkouts and overdues to the template. Note that Kyle suggested another approach on bug 15283: all the checkouts were send into the same array and each element of this array calls the is_from_today method, to know if the checkout is an overdue. I don't think we should rely on the Koha API, that's why I suggest to pass 2 differents object list, 1 which contains the checkouts and another one with the overdues. Note that we do rely on the Koha API, we call the Koha::Checkout->item and Koha::Item->biblio to propose an equivalent TT notice. But I think we can accept that. Test plan: Define the ISSUESLIP and ISSUEQSLIP notice templates to generate the same notices you generated with the historical syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 18:59:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 17:59:10 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > I forgot an important thing here: the items.fine value which was available > in the historical syntax is no longer supported. > It's of course a bug we will need to address. This is not for DUEDGST but ODUE, forget it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:01:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:01:32 +0000 Subject: [Koha-bugs] [Bug 17976] New: TT syntax for notices - Add an equivalence for items.fine Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976 Bug ID: 17976 Summary: TT syntax for notices - Add an equivalence for items.fine Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The items.fine is a trick of our historical syntax. We need to provide a way to access this value from the a notice template using the TT syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:07:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:07:10 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:07:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:07:16 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 --- Comment #1 from Jonathan Druart --- Created attachment 59451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59451&action=edit Bug 17967: TT syntax for notices - Prove that ODUE is compatible Nothing new here, unless we are introducing a regression. The items.fine is a trick of our historical syntax. We need to provide a way to access this value from the a notice template using the TT syntax. A bug 17976 has been opened for discussion. Test plan: Define ODUE and OVERDUES_SLIP notice templates and use it to generate overdue notices from the cronjob script (misc/cronjobs/overdue_notices.pl) or the interface (members/print_overdues.pl). You should be able to generate the same notices with and without using the TT syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:07:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:07:31 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:07:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:07:31 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17967 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 [Bug 17967] TT syntax for notices - Prove that ODUE is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:07:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:07:42 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17976 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:07:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:07:42 +0000 Subject: [Koha-bugs] [Bug 17976] TT syntax for notices - Add an equivalence for items.fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17967 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:09:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:09:38 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 --- Comment #2 from Jonathan Druart --- The patch will not applied cleanly but you can use a version with all conflicts fixed on https://github.com/joubu/Koha/tree/bug_17966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:31:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:31:37 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58133|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 59452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59452&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:31:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:31:51 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58134|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 59453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59453&action=edit Bug 17762: DBIC Schema changes Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:32:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:32:04 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58135|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 59454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59454&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:32:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:32:17 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58136|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 59455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59455&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:32:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:32:30 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58137|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 59456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59456&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:32:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:32:44 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58138|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 59457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59457&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:32:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:32:58 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58139|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 59458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59458&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:33:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:33:12 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58140|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 59459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59459&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:33:23 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58141|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 59460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59460&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 19:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 18:33:36 +0000 Subject: [Koha-bugs] [Bug 17762] Ability to translate notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58525|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 59461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59461&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 20:24:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 19:24:44 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 20:26:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 19:26:03 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #5 from Owen Leonard --- Sorry, I still don't understand your comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 20:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 19:36:20 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59270|0 |1 is obsolete| | --- Comment #22 from Mehdi Hamidi --- Created attachment 59463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59463&action=edit Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 21:07:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 20:07:31 +0000 Subject: [Koha-bugs] [Bug 17950] Additional housekeeping on Merge.t (after 17913) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:00:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:00:44 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields , or based on the koha biblio level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at ccsr.qc | |.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:00:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:00:52 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:07:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:07:40 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #15 from Chris Cormack --- (In reply to Jonathan Druart from comment #14) > Please see comment 6 for a better solution. Can you explain more please Jonathan, they tried changing from indicator ot content-box and this failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:09:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:09:19 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #16 from Katrin Fischer --- I think the trick might be to add content-box without removing indicator. And just remove the styling applied to indicator from the CSS file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:32:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:32:17 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #22 from Josef Moravec --- Looks good, just when I check out an item with type with defined charge, this charge doesn't make line in acount_offsets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:35:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:35:28 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #65 from Blou --- Josef, I'd be happy to have someone in our team test and sign this, but right now I get a Applying: Bug 8612 - Followup - use Koha::CsvProfile[s] module (see bug 15451) fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Damn sha1... Making one big patch out of it would probably limit future rebases, btw, since a lot of these do-undo-redo the same code... Reminder for the initial work: **** Sponsored by : CCSR **** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:41:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:41:08 +0000 Subject: [Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:41:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:41:11 +0000 Subject: [Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59441|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 59464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59464&action=edit [SIGNED-OFF] Bug 17974: Add the Koha::Item->biblio method Test plan: prove t/db_dependent/Koha/Items.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:43:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:43:09 +0000 Subject: [Koha-bugs] [Bug 17973] Add the Koha::Checkout->item method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59442|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 59465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59465&action=edit [SIGNED-OFF] Bug 17973: Add the Koha::Checkout->item method Test plan: prove t/db_dependent/Koha/Checkouts.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:43:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:43:05 +0000 Subject: [Koha-bugs] [Bug 17973] Add the Koha::Checkout->item method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:48:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:48:19 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:48:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:48:23 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59403|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 59466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59466&action=edit [SIGNED-OFF] Bug 17958: Add Koha::Notice::Template[s] packages (letter table) This just add Koha::Letter[s] for later uses. Test plan: prove t/db_dependent/Koha/Notices.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:48:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:48:31 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59404|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 59467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59467&action=edit [SIGNED-OFF] Bug 17958: Add tests for Koha::Notice::Template[s] Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:51:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:51:38 +0000 Subject: [Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 22:51:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 21:51:42 +0000 Subject: [Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59405|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 59468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59468&action=edit [SIGNED-OFF] Bug 17959 - Add the Koha::Notice::Message[s] packages (message_queue table) This just add Koha::Notice::Message[s] for later uses. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:30:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:30:29 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:30:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:30:34 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58622|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia --- Created attachment 59469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59469&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:33:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:33:52 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59293|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 59470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59470&action=edit Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in Only) 3: Apply patch and refresh page. It should now say Search (in only) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:33:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:33:49 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:34:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:34:13 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|caitlingoodger.student at wegc |aleishaamohia at hotmail.com |.school.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:36:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:36:20 +0000 Subject: [Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:36:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:36:24 +0000 Subject: [Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59435|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 59471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59471&action=edit [SIGNED-OFF] Bug 17972 - Reformat acquisitions sidebar menu with acquisitions and administration sections This patch makes changes to acquisitions-menu.inc so that the style matches that of the Administration and Tools sidebar menus. The links are now divided up between Acquisitions (/acqui/) and Administration (/admin/). The link-highlighting JavaScript used elsewhere has been added. To test, apply the patch and view the Acquisitions home page. - Check that the "Acquisitions home" link is highlighted (bold). - Test the other Acquisitions links to confirm that highlighting works. - Click any link in the Administration section of the sidebar menu. - Confirm that everything looks correct and works correctly. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:41:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:41:21 +0000 Subject: [Koha-bugs] [Bug 17977] New: Add acquisitions sidebar menu to suggestions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 Bug ID: 17977 Summary: Add acquisitions sidebar menu to suggestions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org At the moment, the acqui sidebar menu does not show on the suggestions page. it should show after all the filter boxes (similarly to Invoices). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:42:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:42:33 +0000 Subject: [Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:42:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:42:37 +0000 Subject: [Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 --- Comment #1 from Aleisha Amohia --- Created attachment 59472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59472&action=edit Bug 17977: Add acquisitions sidebar menu to suggestions To test: 1) Go to Acquisitions -> Suggestions 2) Notice no acquisitions sidebar 3) Apply patch and refresh page 4) Sidebar menu should now show. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 23 23:42:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 22:42:48 +0000 Subject: [Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 00:56:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 23 Jan 2017 23:56:48 +0000 Subject: [Koha-bugs] [Bug 17978] New: Circ rules will not limit holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Bug ID: 17978 Summary: Circ rules will not limit holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It appears that the holds limit in circ rules is broken. I can set a limit of 0 on holds and it will block the hold, but if I set it to anything higher than 0, it ignores the value altogether and gives the patron unlimited holds. Maxreserves works as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 01:01:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 00:01:00 +0000 Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 tmcmahon at wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 01:06:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 00:06:19 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 tmcmahon at wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmcmahon at wlpl.org --- Comment #1 from tmcmahon at wlpl.org --- I've tested this and the hold limit did not work for me either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 01:18:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 00:18:26 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 --- Comment #2 from tmcmahon at wlpl.org --- At least for me, this setting doesn't work only if I do a bulk hold by checking the boxes in search results. If I reserve one item at a time, it will stop me at the limit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 01:53:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 00:53:18 +0000 Subject: [Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #152 from M. Tompsett --- (In reply to Oleg Vasilenko from comment #148) > Should this be a new bug? Yes, but I think it may be covered by 17527, which is currently in discussion, because people didn't test and go, "Oh, strangeness when we do something bad like everything set to hidden=-8 is perfectly okay." I'm going to tweak it to Needs Sign off, so we can move forward on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 01:54:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 00:54:20 +0000 Subject: [Koha-bugs] [Bug 17527] 245 $h Medium - hidden settings in MARC framework don' t work correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #22 from M. Tompsett --- Changed to needs sign off, because I'm pretty sure it solved the issues mentioned on bug 11592 after it was pushed to master. And 'In Discussion' is a wasteland. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 02:43:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 01:43:36 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #6 from M. Tompsett --- (In reply to Owen Leonard from comment #5) > Sorry, I still don't understand your comments. I gave the titles of the pages (and what is on them). Staff is like normal black texty-text, and superlibrarian is like square red blocky text. I'll attach a screen shot if I must, but I thought running the web installer and looking for the text in question on the pages listed would be evident. I'm sorry if my descriptive abilities are lacking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 03:04:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 02:04:11 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #10 from David Cook --- You're a champion, Colin! Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 03:23:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 02:23:10 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59470|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 59479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59479&action=edit Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in Only) 3: Apply patch and refresh page. It should now say Search (in only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 03:23:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 02:23:07 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 03:52:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 02:52:12 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett --- On my non-kohadevbox I drop'd the db and created it, applied all the patches, ran a web install only doing mandatory default stuff, and then I tried this: mtompset at debian:~/kohaclone$ prove t/db_dependent/Koha/News.t t/db_dependent/Koha/News.t .. 1/5 # Failed test 'The content method return the content of the news' # at t/db_dependent/Koha/News.t line 50. # got: '' # expected: undef # Looks like you failed 1 test of 5. t/db_dependent/Koha/News.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests Test Summary Report ------------------- t/db_dependent/Koha/News.t (Wstat: 256 Tests: 5 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=5, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.72 cusr 0.01 csys = 0.75 CPU) Result: FAIL While I would have expected a failure (and I did get one) before applying the last three on an older DB, I was not expect a failure after the upgrade and all patches applied. Nor after a drop and recreate web install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:07:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:07:18 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58786|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 59480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59480&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'issue notes pending'. 14) Go to circulation home page. There should be no link to Issue notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Issue notes pending: 2' 17) Go to circulation home page. There should be a link to Issue notes with a 2 next to it. Click Issue notes 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 22) Confirm the barcode link to the item works as expected. 23) Confirm the cardnumber link to the user works as expected. 24) Confirm all table details show correctly. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:32:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:32:09 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59423|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 59482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59482&action=edit Bug 17970: Fix GetPreparedLetter behavior if nothing to substitute >From C4::Letters::GetPreparedLetter: my $tables = $params{tables}; my $substitute = $params{substitute}; $tables || $substitute || $repeat or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute' are empty" ), return; So if the parameter tables or substitute is passed but does not contain anything, it will not warn as expected. Test plan: 1/ Apply the patch with tests 2/ Confirm that they do not pass 3/ Apply this patch 4/ Confirm that the tests now pass Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:32:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:32:03 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59425|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 59481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59481&action=edit Bug 17970: Add tests to highlight the problem Depends on 17958 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:32:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:32:34 +0000 Subject: [Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 [Bug 17970] GetPreparedLetter does not warn when expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:32:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:32:34 +0000 Subject: [Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17958 CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958 [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:33:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:33:36 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #35 from Aleisha Amohia --- Created attachment 59483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59483&action=edit Bug 14272: [FOLLOW-UP] Show single news item This patch fixes merge conflicts, an error in the query, and changes the column name `new` to `content`. This patch is now ready to test. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:33:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:33:31 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 04:47:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 03:47:26 +0000 Subject: [Koha-bugs] [Bug 17930] Errors in the manual in self-checkout section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17930 --- Comment #1 from Aleisha Amohia --- the provided JS script should be changed to $(document).ready(function(){ $("#login .btn").parent().after("

    Self-Checkout

    "); }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:02:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:02:54 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Jonathan Druart from comment #1) > Moreover it the letter parameter, but it is never sent to this > subroutine. letter_code is expected instead. Right, $params->{letter}->{content} is never used, so while the logic actually does something, it isn't actually used at all. > Test plan: > No test plan, just read the code and `git grep ` Oh, and there is just the letter_code sent and expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:04:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:04:22 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:04:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:04:24 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59410|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 59484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59484&action=edit Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep ` Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:24:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:24:43 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Michael changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:30:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:30:08 +0000 Subject: [Koha-bugs] [Bug 17979] New: Fatal error when searching from addbooks.pl due to ISBN flaw Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Bug ID: 17979 Summary: Fatal error when searching from addbooks.pl due to ISBN flaw Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org If you're doing a "Cataloging Search" from /cgi-bin/koha/cataloguing/addbooks.pl, and you type in "1st to die", you'll see the following: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 5 at //lib/C4/Breeding.pm line 107 The reason is that the string is 10 characters long and contains a digit, so Koha thinks it's an ISBN. But when it tries to normalize it, it fails, and instead Koha generates no data for the WHERE clause and then the SQL statement fails because it contains a WHERE without the actual clause. The code: if ($query) { # fill isbn or title, depending on what has been entered #u must do check on isbn because u can find number in beginning of title #check is on isbn legnth 13 for new isbn and 10 for old isbn my ( $title, $isbn ); if ($query=~/\d/) { my $clean_query = $query; $clean_query =~ s/-//g; # remove hyphens my $querylength = length $clean_query; if ( $querylength == 13 || $querylength == 10 ) { $isbn = $query; } } if (!$isbn) { $title = $query; } ( $countbr, @resultsbr ) = BreedingSearch( $title, $isbn ); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:34:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:34:49 +0000 Subject: [Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290 --- Comment #6 from M. Tompsett --- Comment on attachment 59176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59176 Bug 17290 - Standardize on "Patron Categories" Review of attachment 59176: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17290&attachment=59176) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/categorie.tt @@ +2,4 @@ > >

    Patron Categories

    > > +

    Patron categories allow you to organize your patrons into different roles, age groups, and patron categories.

    Isn't "patron categories." at the end over kill? Patron categories allow you to organize your patrons into different roles, age groups, and categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:38:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:38:01 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:38:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:38:10 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59385|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 59486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59486&action=edit Bug 17935: Follow up for C4::Plugin... TEST PLAN --------- -- apply first patch git grep "C4::Plugin" -- still two references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- apply this patch git grep "C4::Plugin" -- no references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- should look fixed Please enter the commit message for your changes. Lines starting Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:38:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:38:04 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59209|0 |1 is obsolete| | --- Comment #4 from David Cook --- Created attachment 59485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59485&action=edit Bug 17935: Adjust some POD lines, fix a few typos This patch does the following: [1] Move some POD lines from Cache to Caches. [2] Correct C4::Plugins to Koha::Plugins in POD line of Koha::Plugins [3] POD Koha/AuthorisedValue.pm: lib_opac moved to opac_description [4] The POD in Koha/Patron.pm uses head2 and head3 inconsistently. Ran s/^=head2/=head3/ on those lines (7 substitutions on 7 lines) [5] Correct a copied POD line from reports/issues_stats.pl in reports/reserve_stats.pl. [6] Correct a test description in t/db_dependent/Koha/Authorities.t. You should never delete the library :) [7] Correct typo shouild in a comment of rebuild_zebra.pl Test plan: [1] Read the patch. Does it make sense? [2] Run perldoc Koha/Cache.pm and Koha/Caches.pm [3] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 05:38:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 04:38:41 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook --- Forgot to label the patches as signed off, but you can see that I've signed off both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:23:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:23:16 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:23:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:23:19 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59355|0 |1 is obsolete| | Attachment #59356|0 |1 is obsolete| | --- Comment #17 from Josef Moravec --- Created attachment 59487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59487&action=edit Bug 17929 - You can't edit indicators in the cataloging screen Test plan: 0. Do not apply the patch 1. Edit a biblio record, note you can't edit an indicator (in fact you edit it, but can't see the value) 2. Edit an authority record, note you can't edit an indicator (in fact you edit it, but can't see the value) 3. Apply the patch, you may need clear the browser cache (in Firefox Ctrl+F5 is often enough) 4. Repeat steps 1 and 2 - but now you will be able to edit the indicator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:25:06 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com --- Comment #18 from Josef Moravec --- (In reply to Katrin Fischer from comment #16) > I think the trick might be to add content-box without removing indicator. > And just remove the styling applied to indicator from the CSS file. That's what I meant too... Just edit css file.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:26:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:26:51 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #19 from Chris Cormack --- Seems a shame to take a patch off a high school student. But OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:35:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:35:19 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 --- Comment #20 from Josef Moravec --- (In reply to Chris Cormack from comment #19) > Seems a shame to take a patch off a high school student. But OK Sorry for that, that was the reason, why I didn't do it before... I am a bit impatiant :( And of course I am feeling responsible for this bug, as it is introduced by my patchset on bug 16239... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:46:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:46:52 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com Depends on| |17494 --- Comment #1 from Jonathan Druart --- Caused by bug 17494. Julian could you take a look? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 [Bug 17494] Koha generating duplicate self registration tokens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:46:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:46:52 +0000 Subject: [Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17943 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 08:47:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 07:47:53 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 --- Comment #2 from Jonathan Druart --- Bug 17494 should not have been backported to 3.22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 09:16:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 08:16:33 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 --- Comment #6 from Jonathan Druart --- Created attachment 59488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59488&action=edit Bug 17960: Add opac_news.content values in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 09:17:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 08:17:00 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 --- Comment #7 from Marcel de Rooy --- (In reply to David Cook from comment #6) > Forgot to label the patches as signed off, but you can see that I've signed > off both. Thanks, David. Note that I do not see any real use in labeling patches with SIGNED_OFF. We have a signoff line and a bug status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 09:24:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 08:24:46 +0000 Subject: [Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 09:24:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 08:24:50 +0000 Subject: [Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59472|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 59489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59489&action=edit Bug 17977: Add acquisitions sidebar menu to suggestions To test: 1) Go to Acquisitions -> Suggestions 2) Notice no acquisitions sidebar 3) Apply patch and refresh page 4) Sidebar menu should now show. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 09:28:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 08:28:55 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #14 from Jonathan Druart --- Tomas, can we get your opinion on comment 10? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 10:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 09:39:30 +0000 Subject: [Koha-bugs] [Bug 17980] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Bug ID: 17980 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:08:49 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |Fix wrong call to ModZebra | |in AddAuthority (affects | |Elastic Search users) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:10:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:10:04 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 --- Comment #1 from Marcel de Rooy --- Created attachment 59490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59490&action=edit Bug 17980: Fix wrong call to ModZebra in AddAuthority (affects Elastic Search users) The ModZebra call in AddAuthority incorrectly passes five parameters to ModZebra including $oldRecord. This makes the last parameter (the new record) being ignored !! A closer inspection of ModZebra reveals that this only affects installs using Elastic Search. The record parameter is ignored when you still use Zebra. Note: Keep in mind that AddAuthority is being used in adding as well as modifying authority records. This patch is part of a larger effort to make improvements in this area and will not be last one. Please help to get this further (see bug 17908). Trivial fix. Test plan: [1] If you use Elastic Search, verify that the new authority record is being indexed, not the old one. [2] If you do not use Elastic Search, add or modify an authority and search for this change in Authority (Search entire record). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:10:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:10:38 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:11:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:11:38 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |nick at bywatersolutions.com --- Comment #2 from Marcel de Rooy --- Chris or Nick: could one of you please confirm the Elastic Search side? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:12:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:12:19 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:12:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:12:19 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 [Bug 17980] Fix wrong call to ModZebra in AddAuthority (affects Elastic Search users) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:17:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:17:00 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 --- Comment #3 from Marcel de Rooy --- Actually, the Elastic Search problem is larger than this: Look at ModZebra itself: if ( $op eq 'specialUpdate' ) { unless ($record) { $record = GetMarcBiblio($biblionumber, 1); } my $records = [$record]; $indexer->update_index_background( [$biblionumber], [$record] ); } This code is wrong in case you call ModZebra for an authority ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:18:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:18:03 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 --- Comment #4 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #3) > Actually, the Elastic Search problem is larger than this: > Look at ModZebra itself: > if ( $op eq 'specialUpdate' ) { > unless ($record) { > $record = GetMarcBiblio($biblionumber, 1); > } > my $records = [$record]; > $indexer->update_index_background( [$biblionumber], [$record] ); > } > > This code is wrong in case you call ModZebra for an authority ! At least if you pass no record and call GetMarcBiblio :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:21:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:21:08 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 --- Comment #5 from Marcel de Rooy --- Created attachment 59491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59491&action=edit Bug 17980: Corresponding fix in DelAuthority The call to ModZebra here does not need more than three parameters. Same for Zebra and Elastic Search. Note: On omnibus bug 17908 a few more fixes are coming on this subject of deleting authorities. Test plan: [1] Delete an authority. [2] Search for it in the Authority module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:23:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:23:41 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59491|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 59492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59492&action=edit Bug 17980: Corresponding fix in DelAuthority The call to ModZebra here does not need more than three parameters. Same for Zebra and Elastic Search. Note: On omnibus bug 17908 a few more fixes are coming on this subject of deleting authorities. Test plan: [1] Delete an authority. [2] Search for it in the Authority module. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:24:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:24:31 +0000 Subject: [Koha-bugs] [Bug 17980] Fix wrong call to ModZebra in AddAuthority ( affects Elastic Search users) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 11:43:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 10:43:37 +0000 Subject: [Koha-bugs] [Bug 17940] Holds not going to waiting state after having been transferred In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 --- Comment #1 from Stefan Berndtsson --- Some additional information. When in the unexpected state after having checked in on library B (step 3), the information notice presented includes: "Hold found (item is already waiting):" This state seems to only look at itemnumber and priority == 0. When step 2 executes, the reserve is set to 'T', the priority to 0 and the itemnumber is added to the reserve entry. As far as I understand things, this is normal (priority is 0 when the item is assigned to a person, even if there is a transfer needed). When the item is checked in at the pickup (Step 3 again) the item is returned as "Waiting" (from CheckReserves) due to the itemnumber and priority == 0, and since it does not need a transfer from Library B, and is already considered to be waiting, it does not seem to update the 'W' flag. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:15:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:15:51 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:33:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:33:23 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:33:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:33:45 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:33:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:33:48 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58690|0 |1 is obsolete| | --- Comment #31 from Nick Clemens --- Created attachment 59493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59493&action=edit Bug 17255 - Upgrade Elastic Search code to work with version 2.4+ - rebased wip -Changed deprecated facets to aggregations -Fixed boolean datatypes not allowing analyzers to be specified -Fixed deprecated '_id' to 'es_id'. Now the ES-index has the correct id==biblionumber ZE TEST PLAN 1. Reset Zebra index since facets are hard coded to dynamic search_marc_mappings. 2. perl misc/search_tools/rebuild_elastic_search.pl 3. Fetch all indexed records and the facet for subject__facet curl -XGET localhost:9200/koha_biblios/data/_search?pretty -d '{ "aggregations": { "my_agg": { "terms": { "field": "subject__facet" } } } }' Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:33:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:33:55 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58757|0 |1 is obsolete| | --- Comment #32 from Nick Clemens --- Created attachment 59494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59494&action=edit Bug 17255 - Upgrade Elastic Search code to work with version 5.1 Builds on top of commit: Bug 17255 - Upgrade Elastic Search code to work with version 2.4+ - rebased wip -Fix data type 'string' to 'keyword' and 'text' -index: not_analyzed deprecated, replaced with type: keyword which is equivalent -store: yes was deprecated, use store: true TODO: Installer bindings to both the debian package install and the raw developer install. A taster in Buug 17851 ZE TEST PLAN 0. Remove existing ES and reinstall ES 5.1 apt-get purge elasticsearch Follow instruction here: https://www.elastic.co/guide/en/elasticsearch/reference/current/deb.html 1. Reset Elasticsearch index since facets are hard coded to dynamic search_marc_mappings. 1a. perl -e 'use Koha::SearchEngine::Elasticsearch; Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings();' 1b. If you get trouble, simply DELETE FROM [search_fields|search_marc_to_fields|search_marc_mapping]; and retry 1a. 1c. Destroy elasticsearch index curl -XDELETE localhost:9200/koha_biblios so it can be recreated 2. Recreate the index: perl misc/search_tools/rebuild_elastic_search.pl 2a. Add something to index if your koha.biblio-table is empty 3. Fetch all indexed records and the facet for subject__facet curl -XGET localhost:9200/koha_biblios/data/_search?pretty -d '{ "aggregations": { "my_agg": { "terms": { "field": "subject__facet" } } } }' 4. Run the included tests: perl t/db_dependent/Koha_Elasticsearch_Indexer.t perl t/db_dependent/Koha_Elasticsearch.t perl t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t Have fun with your new ES 5.1 cluster! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:35:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:35:38 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 --- Comment #33 from Nick Clemens --- I had to apply the patches interactively, one at a time, but they worked then without issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:36:13 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 59495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59495&action=edit Bug 17871: Remove zebra::snippet to allow access to facets in YAZ 5.8.1+ This patch restores access to zebra facets (or zebra::snippet) with YAZ 5.8.1 or higher. It was failing due to The entry in retrieval-info-bib-dom.xml which IndexData said it wasn't even needed to get that access. Edit: I amended the commit message (tcohen) Signed-off-by: Colin Campbell Signed-off-by: Tomas Cohen Arazi I tested on kohadevbox and found no regression or behaviour change. I will provide a followup for the packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:37:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:37:03 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 12:37:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 11:37:08 +0000 Subject: [Koha-bugs] [Bug 17871] Can't retrieve facets (or zebra::snippet) from Zebra with YAZ 5.8.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17871 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59400|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 59496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59496&action=edit Bug 17871: (followup) Remove zebra::* from the packages templates Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 13:07:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 12:07:54 +0000 Subject: [Koha-bugs] [Bug 16749] Follow-up for bug 16733: changes for koha-translate In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749 --- Comment #15 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #10) > (In reply to Marcel de Rooy from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > Why don't you use intranetdir? > > > > dev_install tells you too that this is a gitified install > > In that case, does a boolean flag would be enough? If dev_install will > always be equal to intranetdir it would make more sense to have a flag. What > do you think? I think we should go with a boolean flag. We love booleans. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:10:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:10:54 +0000 Subject: [Koha-bugs] [Bug 16018] merges not modifying biblios properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:10:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:10:58 +0000 Subject: [Koha-bugs] [Bug 16018] merges not modifying biblios properly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58578|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 59497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59497&action=edit Bug 16018: Merge.pl does not update biblios linked to the old authority Original patch from Remi Mayrand-Provencher. Amended by Marcel de Rooy (January 2017), part of omnibus bug 17908. EDIT: We cannot remove the ModAuthority call, since the reference record is the result of the merge and should be saved. Variable $overwrite is not used and can be removed. The ModAuthority call triggers a merge like: recordid1, original ref record, recordid1, new ref record. This only updates all biblio records that were already attached to the reference record. As Remi discovered correctly, we still need another merge for the biblios attached to recordid2 (the record to be deleted). This patch adds that merge. Note: The results of this merge operation should have been improved by the changes to C4::AuthoritiesMarc::merge. Test plan: [1] Restart Plack and restart koha-indexer. (I had some problems related to indexing as a result of the marcxml transition.) [2] Go to Authorities. Select two authorities to merge, start with two of the same type. Make sure that both are used in a few biblio records. Select at least one subfield from the authority to be removed for inclusion in the authority to be kept ("reference record"). [3] Click Merge. You come back to the kept authority record. Note: The number of attached records may not yet be updated. This depends on the speed of koha-indexer. If you wait a bit and refresh, you should have the correct number. First check the authority record again for the inserted subfield. Now check a biblio that was ALREADY attached to the reference record. And check a biblio that was FORMERLY attached to the deleted one. Note: See bug 17913 to see how pref AuthorityMergeMode impacts this. [4] Try steps 2 and 3 again for a merge of two authority records that do not have the same authority type noting the remarks below. For instance try to merge from a CORPO_NAME to a PERSO_NAME record. Make a change in say 040$a of the record to be deleted. And select that field later on the merge form. Normally, you would use the PERSO_NAME framework in the merge now. When checking the authority record, look at 040a. When checking the record that was linked to the CORPO_NAME, check if it contains the PERSO_NAME authority in the correct field (say 100, 600, 700). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:11:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:11:33 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|merges not modifying |Merge.pl does not update |biblios properly |biblios linked to the old | |authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:13:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:13:34 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Owen Leonard --- Okay, I think I understand. I think it's fine. > Don't you love the set koha version text? :( Can you explain this comment please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:14:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:14:13 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 --- Comment #13 from Marcel de Rooy --- The test plan may scare you away, but please stay. It is really not that hard to test this change. Manipulating two authorities and a few biblios in say 10 to 15 minutes should be enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:18:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:18:08 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 --- Comment #14 from Marcel de Rooy --- Still see something. Wait! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:39:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:39:24 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #43 from Owen Leonard --- (In reply to Aleisha Amohia from comment #36) > > - On the circulation page, I think it makes more sense to put the patron > > note in the column which shows the "Checked in" message since that's where > > the librarian would be looking for confirmation of the transaction. Was it supposed to work this way in your latest version? The note was still appearing in the first column of the table in my latest tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:52:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:52:06 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59431|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 59498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59498&action=edit Bug 17932: Add a TO_JSON method to Koha::Object(s) Bug 17927 fixes data types on the current REST endpoints. If you test those endpoints, you will notice trying to access them (for listing or retrieving single objects yields a data type error. Notably on booleans but also on integers. Integers fail due to https://rt.cpan.org/Ticket/Display.html?id=119904 but it needs some global solution until there's a DBD::mysql release backported to the supported distros. There's the option to use http://search.cpan.org/~frew/DBIx-Class-Helpers-2.033002/lib/DBIx/Class/Helper/Row/NumifyGet.pm to get the integer columns fixed as a workaround: __PACKAGE__->add_columns( borrowernumber => { data_type => 'integer', is_nullable => 0, is_numeric => 1, } ); I didn't find bug reports related to this (maybe because we don't use warnings everywhere) But I don't think is worth going such a heavy overhead. A similar situation takes place for Boolean values. They need to be prepared for JSON output. This could have been done using DBIx filters as pointed out by Martin: __PACKAGE__->filter_column( lost => { filter_to_storage => sub { $_[1] ? 1 : 0 }, filter_from_storage => sub { $_[1] ? Mojo::JSON->true : Mojo::JSON->false } } ); but this could have other consequences that are worth exploring on another bug (i.e. it would mean we need to take care of every place where this boolean data is used/set needs to handle this data types nicely. Such would be the case if we were a Mojo-only app, but we aren't. We use Koha::Obect(s) in the whole app. Period. This patch adds the need to specify on the schema files, columns that are actually boolean, because we have no way to detect them for now (i.e. they are all tinyint, but we use tinyint for non-boolean stuff too). So if this patch is accepted, we would need to specify boolean columns like this: __PACKAGE__->add_columns( '+lost' => { is_boolean => 1 } ); This patch adds a TO_JSON method for Koha::Object(s) to be used for serializing Koha::Object-derived objects into JSON strings. To test it (as Koha::Object(s) need to be instantiated) I provide tests on top of the Koha::Patron(s) classes in the followup patches. [1] Yes, we use TINYINT(1) for booleans, but from DBIC's perspective there's no way to read the (1) in runtime. Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:52:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:52:21 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59432|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 59499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59499&action=edit Bug 17932: (followup) Fix /patrons endpoint Bug 17927 introduced data type fixes on the /patrons endpoint (integer and boolean types got fixed). This led to the /patrons endpoint not to work because the underlying code didn't provide the right data. With the introduction of TO_JSON on Koha::Object(s) we now have a way to output the proper data types. This patch does so by: - Adding is_boolean => 1 to the relevant columns on the Borrower.pm schema file. - Tweaking the controller class for the /patrons endpoint so it doesn't use the $object(s)->unblessed call but just let the Mojo::JSON library pick out TO_JSON implementation instead on rendering the output. - It adds a new test for booleans. To test: - Have 17927 applied - Run: $ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail [1] - Apply this patches - Run: $ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off! :-D [1] It is self explanatory to just try the API using any of the available tools (I use HttpRequester on Firefox) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:52:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:52:32 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 59500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59500&action=edit Bug 17932: Unit tests This patch adds unit tests for the Koha::Object::TO_JSON function. It tests on top of Koha::Patron as Koha::Object needs to be instantiated. To test: - Apply the patch - Run: $ prove -v t/db_dependent/Koha/Object.t => SUCCESS: New tests for TO_JSON are run and return green. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:52:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:52:44 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 59501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59501&action=edit Bug 17932: (followup) Tidy tests This patch makes the tests create its own data instead of searching the DB for a branchcode and a categorycode. It does so on each subtest, because there shouldn't be side effects between subtests. I also wrapped each subtest inside a transaction, for the same reason. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests return green with this patch - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:54:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:54:05 +0000 Subject: [Koha-bugs] [Bug 17449] Let users choose action in self checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17449 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:55:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:55:54 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 --- Comment #15 from Marcel de Rooy --- Created attachment 59502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59502&action=edit Bug 16018: Add a TODO for need_merge_authorities in merge.pl It is not useful to postpone a merge to the cron job here, since the old authority record is deleted and merge_authority cannot yet handle that correctly. But no harm either to leave it here. Note: This will be addressed shortly on bug 9988. So please help! Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 14:59:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 13:59:22 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:05:18 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 --- Comment #12 from Marcel de Rooy --- Stage 3 is on its way. Can we get these three reports further this week or so? BUG 17950: Tiny improvements on Merge.t BUG 17980: Fixing ModZebra calls in AuthoritiesMarc BUG 16018: Merge.pl does not update biblios linked to the old authority The third one is the most interesting fix in this stage, originating from Remi Marchand. Thanks! What remains is: [PHASE4] 09988 AuthorityMergeLimit (instead of dontmerge) [PHASE5] 14026 Deleting an authority [PHASE6/DEPENDS ON 9701] 14769 Correct indicators in merge In phase4 some things might be Koha-Objectified. We might need one or two intermediate reports in stage 4 to pave the way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:07:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:07:49 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:14:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:14:25 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #8 from Martin Renvoize --- Looks good to me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:17:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:17:58 +0000 Subject: [Koha-bugs] [Bug 15448] Suppressed items show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #3 from Jessie Zairo --- In 16.05.05 when a rule to hide specific items in OPACHiddenItems is set, the item does not show in the holdings table, but does appear when the user attempts to place the hold. 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]." 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. The Suppress ccode item isn't shown. 5. View the detail page for the title. The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" -- the ccode with the opachiddenitems rule has an item that appear in the list to place a hold. Jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:19:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:19:52 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suppressed items show in |OPACHiddenItems show in |OPAC when patron places a |OPAC when patron places a |hold on a specific item |hold on a specific item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:27:04 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard --- My only comment about required fixes is that "Issue notes" should be "Checkout notes." Suggestions: - In the table of notes I think it makes more sense to have: Title | Note | Date | Set by | Status | Actions I think it makes more sense to be able to scan the list by title than by note content. And I think it makes sense for the status to be next to the actions. - A nice improvement would be to have the batch action buttons at the bottom be disabled until one or more checkboxes are checked. See Audio alerts for an example. Marking as Failed QA just for the language fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:35:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:35:41 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I guess the regex should be m|^[\d-]*$|; Instead of just /\d/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:42:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:42:38 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting Authority record tag does not update bibliographic marc record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy --- Pick this up in the course of omnibus bug 17908. Support appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:44:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:44:08 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 15:44:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 14:44:11 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59286|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 59503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59503&action=edit [SIGNED-OFF] Bug 17840: adding classes to notes in checkouts Test Plan 1) Add an internal and a public note to an item. 2) Check out the item. 3) Verify that both notes are shown in between title and barcode in the second column of the details table. 4) Verify there is an empty class="" in the HTML source code for each 5) Apply patch and refresh page 6) View page source, confirm that class has been changed I tested this by first applying the patch for bug 17919 to catch the check-in software error. Patch working as expected :) Signed-off-by: Claire Gravely Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:03:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:03:14 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59182|0 |1 is obsolete| | --- Comment #27 from Owen Leonard --- Created attachment 59504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59504&action=edit [SIGNED-OFF] Bug 17134: Replace item types codes with category To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:03:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:03:11 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:15:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:15:00 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:15:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:15:04 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59276|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 59505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59505&action=edit [SIGNED-OFF] Bug 11450: Hold Request Confirm Deletion ==TEST PLAN== 1) Go to an item with a hold and click on the holds tab on the left 2) Click the red 'X' 3) The hold will be deleted immediately 4) Apply patch 5) Return to an item with a hold and click the 'X' 6) There will now be a confirmation dialog 7) Click cancel and the dialog will disappear and the hold will not be deleted 8) Click OK and the hold will be deleted Signed-off-by: Owen Leonard Made one minor correction while signing off: Removed some stray spaces from inside a link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:15:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:15:28 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17962, 17963, 17964, 17965, | |17966, 17967, 17975 --- Comment #2 from Jonathan Druart --- Bug 17962: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible Bug 17963: TT syntax for notices - Prove that AR_* are compatible Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible Bug 17965: TT syntax for notices - Prove that DUEDGST is compatible Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible Bug 17966: TT syntax for notices - Prove that ISSUESLIP is compatible Bug 17967: TT syntax for notices - Prove that ODUE is compatible Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 [Bug 17963] TT syntax for notices - Prove that AR_* are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17965 [Bug 17965] TT syntax for notices - Prove that DUEDGST is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 [Bug 17967] TT syntax for notices - Prove that ODUE is compatible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17966] TT syntax for notices - Prove that ISSUESLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:18:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:18:22 +0000 Subject: [Koha-bugs] [Bug 17967] TT syntax for notices - Prove that ODUE is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:19:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:19:44 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17981 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 [Bug 17981] Add the ability to preview generated notice templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:19:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:19:44 +0000 Subject: [Koha-bugs] [Bug 17981] New: Add the ability to preview generated notice templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Bug ID: 17981 Summary: Add the ability to preview generated notice templates Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:26:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:26:56 +0000 Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:26:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:26:59 +0000 Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59187|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 59506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59506&action=edit [SIGNED-OFF] Bug 16606 Checkout settings dropdown should have a preference to stay open all the time Test Plan 1: Update database 2: Turn on the CheckoutSettingsVisibility syspref 3: Go to your checkouts 4: COnfirm that the checkout settings is open 5: Turn the syspref and go back to your checkouts 6: Confirm that the Checkout settings are closed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:27:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:27:48 +0000 Subject: [Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |grace.mcky at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:34:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:34:21 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:34:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:34:24 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58684|0 |1 is obsolete| | --- Comment #15 from Owen Leonard --- Created attachment 59507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59507&action=edit [SIGNED-OFF] Bug 17793: Follow up for identified missing changes I ran: $ git grep -l cat-search.inc | grep admin This means I believe the outstanding ones are (koha-tmpl/intranet-tmpl/prog/en/modules/): - admin/auth_subfields_structure.tt - admin/clone-rules.tt - admin/marc_subfields_structure.tt - admin/searchengine/elasticsearch/mappings.tt One other was recommended by Katrin in comment #9: - plugins/plugins-home.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:34:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:34:31 +0000 Subject: [Koha-bugs] [Bug 17982] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Bug ID: 17982 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:34:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:34:52 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:34:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:34:59 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #1 from Jonathan Druart --- Created attachment 59508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59508&action=edit Bug 17981: Move svc/letters to svc/letters/get To allow another script under svc/letters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:35:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:35:07 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #2 from Jonathan Druart --- Created attachment 59509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59509&action=edit Bug 17981: Add a 'letter' param to GetPreparedLetter This will allow us to call GetPreparedLetter with a letter content that does not exist in the DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:35:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:35:20 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #3 from Jonathan Druart --- Created attachment 59510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59510&action=edit Bug 17981: Add a preview mode for notice templates This patch is a first step to provide a preview mode for notice templates. CHECKIN, CHECKOUT and HOLD_SLIP are supported so far. Maybe more, but I have not tested yet and the interface will not allow you to generate the preview. The idea is to provide an idea of how will render the messages generated from a notice template. A new "Preview" button is added close to each textarea on the editing notice templates view. For each notice template code (letter_code), we will need some input data to produce the preview. For instance, for CHECKIN we need an barcode. From the barcode we can guess all the other data. For CHECKOUT we will need the borrowernumber and the barcode. Note that the way to enter the data for the preview is not really user-friendly, for CHECKOUT you will have to fill 'borrowernumber|barcode', but the placeholder will help you to know how and what to fill. In the modal window, you will see 4 blocks: 1/ the content of the letter (with the placeholds << >>) 2/ the generated message (with the data filled) 3/ if the letter contained historical syntax markers, the screen will try to generate a notice template using the TT syntax 4/ the generated message from this TT syntax => You will be able to compare the 2 generated messages. What is the goal of this first patchset: - Show this first POC and get feedback from other developpers - Add a way to easily visualise the differences between the 2 syntaxes - Confort users with the TT syntax and the migration step from the historical syntax. I'd like to get opinions before going further. The possibilities: - Mock data to get fully working generated messages for any notice templates. For instance, for CHECKIN and CHECKOUT, the item is not checked in/out yet. So we cannot access the issue's information. (I have no idea how to do that) - Browse the data to get the ones we want to use for the preview (big). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:37:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:37:14 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #4 from Jonathan Druart --- These patches will not apply due to the big dependency tree. Use this remote branch instead: https://github.com/joubu/Koha/tree/bug_17981 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:37:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:37:49 +0000 Subject: [Koha-bugs] [Bug 17960] Rename opac_news.new with opac_news.content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 16:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 15:41:14 +0000 Subject: [Koha-bugs] [Bug 17886] Don' t show option to add to existing list if there are no lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17886 --- Comment #7 from Owen Leonard --- (In reply to M. Tompsett from comment #5) > I believe this is the wrong solution. It is much simpler. Since you're obsoleting a patch from an Academy student in favor of your own I think it's worthwhile to give a detailed explanation of your reasoning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:03:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:03:53 +0000 Subject: [Koha-bugs] [Bug 17982] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 --- Comment #1 from Marcel de Rooy --- Created attachment 59511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59511&action=edit Bug 17982: Fix the use of uniq in sub themelanguage Doing uniq( \@themes ) is useless. It will just return to you the only reference you gave it. List::MoreUtils::uniq requires a list instead of an arrayref. So it is a trivial fix that makes sub themelanguage return one theme instead of three themes like [ 'prog', 'prog', 'prog' ]. Note that Template->new inserts one or two include paths to TT for each of these three identical themes. Added a unit to be somewhat overcomplete :) Test plan: [1] Run t/db_dependent/Templates.t [2] Open a page on OPAC or intranet. (Did you restart Plack?) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:04:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:04:17 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |Fix the use of uniq in sub | |themelanguage Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:04:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:04:28 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:06:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:06:14 +0000 Subject: [Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 59512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59512&action=edit Bug 17951: Make koha-create set template_cache_dir correctly This patch makes koha-create (and friends) handle the template_cache_dir config entry correctly. It does so by: - Adding a replaceable string to the template for koha-conf.xml - Making koha-create-dirs create the needed directories (i.e. /var/cache/koha/instance and /var/cache/koha/instance/templates) - Adding a --template-cache-dir switch to koha-create (so sysadmins can specify their favourite directory for the templates cache). - koha-remove now takes care of the instance's *templates* dir. - The install scripts now automatically create /var/cache/koha so it can be used later by koha-create and friends. It does so the same way it does for other install-created directories. To test, you should ideally be able to build your own packages. This instructions can be followed by people that doesn't have that ability yet. But can be used on a custom packages setup too. To test: - Make sure you have the latest misc4dev in your kohadevbox (if it is a fresh box you have it already) - Run: $ sudo perl misc4dev/cp_debian_files.pl - Manually create the /var/cache/koha dir (skip if you have your own packages): $ sudo mkdir /var/cache/koha - Create a new instance: $ sudo koha-create --create-db cachetest => SUCCESS: * /etc/koha/sites/cachetest/koha-conf.xml contains template_cache_dir and is populated with /var/cache/koha/cachetest/templates * The directory /var/cache/koha/cachetest/templates exists! - Create a new instance, pass your own cache dir: $ sudo koha-create --create-db --template-cache-dir /tmp cachetest2 => SUCCESS: etc/koha/sites/cachetest2/koha-conf.xml contains template_cache_dir and is populated with /tmp - Run: $ man koha-create => SUCCESS: The docs mention the --template-cache-dir option switch correctly. - Sign off :-D! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:06:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:06:05 +0000 Subject: [Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:11:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:11:52 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |synapse.ova at gmail.com --- Comment #4 from Oleg Vasilenko --- Created attachment 59513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59513&action=edit Bug 17780: JS structure check fix Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. This patch checks if input has name attribute, because some inputs in Select2 have not. Blank screen happens on page blinddetail-biblio-search.pl because when the script works with field that has Select2 as one of the subfields, it finds some structures, that have no required attributes. To test: Try to add info from the authorities to field that has subfield with Select2 (subfield with authorised values on Koha 16.11+). For example, in UNIMARC installations that should be 700, 701, 702 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:13:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:13:33 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #5 from Jonathan Druart --- Created attachment 59514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59514&action=edit Bug 17981: Better error handling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:16:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:16:44 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13501 Change sponsored?|Seeking developer |--- Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 [Bug 13501] Allow autocompletion on drop-down lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:16:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:16:44 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 [Bug 17780] When choose an author in authority results new window shows a blank screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:18:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:18:04 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #67 from Kyle M Hall --- Created attachment 59515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59515&action=edit Bug 15503 - Populate the order prices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:51:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:51:40 +0000 Subject: [Koha-bugs] [Bug 17983] New: Add minutes loan to DiscreteCalendar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Bug ID: 17983 Summary: Add minutes loan to DiscreteCalendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: mehdi.hamidi at inlibro.com QA Contact: testopia at bugs.koha-community.org Hello everyone, This is an additional feature to our new Discrete Calendar. Theses patches add the possibility to choose the loan unit as minutes in circulations rules. Test plan: - Apply patch of Bugzilla 17015 - Apply this patch. - Run test t/db_dependent/minutes_loan.t - Create new item type for the new rule. - Create circulation rule and fill the fields, make sure the unit is set to : minutes, choose the item type of the one created above.- - Checkout an item that follow the circulation rule and set due date in the past. - Run fines.pl. - Check if the correct amount was calculated. - Note: make sure to factor in the fine grace period if set and the system preference FinesIncludeGracePeriod. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:52:25 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi at inlibro.com Depends on| |17015 Assignee|koha-bugs at lists.koha-commun |mehdi.hamidi at inlibro.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 [Bug 17015] New Koha Calendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:52:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:52:25 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 [Bug 17983] Add minutes loan to DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 17:54:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 16:54:12 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:19:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:19:17 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59268|0 |1 is obsolete| | --- Comment #24 from Mehdi Hamidi --- Created attachment 59517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59517&action=edit Bug 17015 - Tests for DiscreteCalendar -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:19:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:19:09 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59267|0 |1 is obsolete| | --- Comment #23 from Mehdi Hamidi --- Created attachment 59516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59516&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:19:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:19:27 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59269|0 |1 is obsolete| | --- Comment #25 from Mehdi Hamidi --- Created attachment 59518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59518&action=edit Bug 17015 - Koha now uses the new DiscreteCalendar module C4/Circulation.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:19:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:19:42 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59463|0 |1 is obsolete| | --- Comment #26 from Mehdi Hamidi --- Created attachment 59519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59519&action=edit Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:19:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:19:51 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59271|0 |1 is obsolete| | --- Comment #27 from Mehdi Hamidi --- Created attachment 59520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59520&action=edit Bug 17015 - Peformance tests for Koha::DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:21:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:21:11 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:21:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:21:13 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #1 from Mehdi Hamidi --- Created attachment 59521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59521&action=edit Bug 17983 - Added minutes loan to Koha/DiscreteCalendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:21:24 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #2 from Mehdi Hamidi --- Created attachment 59522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59522&action=edit Bug 17983 - Enabled the use of minutes loan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:21:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:21:29 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #3 from Mehdi Hamidi --- Created attachment 59523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59523&action=edit Bug 17983 - Tests for minutes loan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:22:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:22:38 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #4 from Mehdi Hamidi --- Forget to mention : run Koha tests to make sure everything still works properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:23:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:23:28 +0000 Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 18:23:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 17:23:20 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #6 from Jonathan Druart --- Created attachment 59524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59524&action=edit Bug 17981: Move the divs to the top of the modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 19:30:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 18:30:24 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #44 from Aleisha Amohia --- (In reply to Owen Leonard from comment #43) > Was it supposed to work this way in your latest version? The note was still > appearing in the first column of the table in my latest tests. The first column of the table also has the Checked In message. I moved it out of the Title (etc) column into that column, so yes, this is the way it is meant to work. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:02:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:02:54 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Christopher Brannon --- Found flaws in my testing. I was able to get this to work as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:13:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:13:17 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:13:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:13:29 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 --- Comment #4 from Josef Moravec --- Created attachment 59526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59526&action=edit [SIGNED-OFF] Bug 17962: Add Koha::Tmp::Order[s] These packages should not be used outside the TT syntax scope. A rewrite of Koha::Acquisition::Order[s] should be considered instead. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:13:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:13:22 +0000 Subject: [Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59428|0 |1 is obsolete| | Attachment #59429|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 59525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59525&action=edit [SIGNED-OFF] Bug 17962: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible To make ACQ_NOTIF_ON_RECEIV TT compatible, we need to expose data from the aqorders table. We already have a package for it in the Koha namespace but it is based on Koha::Object[s]. The other path creates dummy Koha::Tmp::Order[s] packages to make it usable. Of course we should use a valid Koha::Acquisition::Order[s] based on Koha::Object, but it's outside the scope of this bug report. This notice template is quite simple, and it's a good one to start. >From C4::Acq::NotifyOrderUsers, GetPreparedLetter is called with 4 elements: the library, the patron to notify, the biblio and the order information. Note that prior to this patch aqorders was filled from GetOrder, which retrieved a lot of information from the acquisition table (aqbasket, aqbookseller). The idea with the TT syntax is to access the data from where it really exists. So if a user wants to display the basket name, [% order.basket.basketname %] should be used instead. Note that this will not work at the moment, the basket method is not defined in the order package. However the basic template should work as before. The test added to TemplateToolkit proves that. Test plan: Use the default ACQ_NOTIF_ON_RECEIV to notify a patron that an order has been received. That generated template should be exactly the same as prior to this patch. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:16:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:16:36 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59111|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 59527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59527&action=edit [SIGNED-OFF] Bug 17852; Multiple URLs (856) in list email are broken. Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it. 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:16:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:16:43 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59197|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 59528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59528&action=edit [SIGNED-OFF] Bug 17852 Follow up.Multiple URLs (856) in list email are broken This is a follow-up to my previous patch. This fixes it on the OPAC and the previous one was from the intranet Test Plan 1: Add multiple urls to a biblographic record 2: Add the biblographic record to a list and then email it from the OPAC 3: See that the links are broken and have been merged into one. 4: Apply patch 5: Send the list again and see that the links work Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:17:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:17:05 +0000 Subject: [Koha-bugs] [Bug 17852] Multiple URLs (856) in list email are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17852 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:20:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:20:58 +0000 Subject: [Koha-bugs] [Bug 17984] New: Warn catalogers if item type doesn't match 942c Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17984 Bug ID: 17984 Summary: Warn catalogers if item type doesn't match 942c Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Because circ rules can be thrown off if the item type in the items record doesn't match the 942c when it comes to bib level hold requests, it would be helpful to have a warning next to field "y - Koha item type" if it does not match the 942c. Maybe something like: "WARNING: item type does not match 942c. May have unexpected results on hold requests." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:29:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:29:38 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |luke.honiss at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:30:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:30:35 +0000 Subject: [Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:43:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:43:53 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 tmcmahon at wlpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #4 from tmcmahon at wlpl.org --- Circ rules will still not limit holds if multiples are added from search results. To repeat this: 1. Select a patron who has less than the maximum holds. 2. Search for items to hold and select multiple check boxes to bring the hold count over the set limit. 3. Select the "Place hold for (patron)" from the "Place hold" button at the top of the list. It will let you place holds on as many as you select. It will not let you add more holds if you've already reached the limit before this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:47:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:47:55 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Josef Moravec --- I think there is missing article_requests table definition in C4::Letters, I am getting the notice generated without any information from article_requests table... but test is passing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:58:42 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:58:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:58:46 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59426|0 |1 is obsolete| | --- Comment #3 from Josef Moravec --- Created attachment 59529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59529&action=edit [SIGNED-OFF] Bug 17971: TT syntax for notices - Add support for plurals On of the awesome things we will be able to do with the TT syntax is the support of plurals. For instance we will be able to send a list of items, checkouts, etc. to the notice template. That way we will get rid of our custom syntax like <> or for instance. The existing code already has the playground for that but it is not used. Basically the idea is to add a "loops" key which can contain a list of object to retrieve from the DB and send to the template. For instance: loops => { overdues => [ $itemnumber_1, .., $itemnumber_N ] } will send a variable "overdues" to the template. It will contain the Koha::Checkout objects relative to the id passed. There is one quite big inconvenient to this approach so far: since we are still supporting the historical syntax, the objects can be fetch by a script, then the script will send the id to GetPreparedLetter which will refetch them. This must be improved, but I suggest to do that later. Test plan: prove t/db_dependent/Letters/TemplateToolkit.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 20:58:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 19:58:55 +0000 Subject: [Koha-bugs] [Bug 17971] TT syntax for notices - Add support for plurals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17971 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59427|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 59530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59530&action=edit [SIGNED-OFF] Bug 17971: Add support for objects represented by fk For instance an issue is not fetch from its fk but using the fk itemnumber. We need to support them. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:00:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:00:48 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #28 from Mehdi Hamidi --- Hello everyone, we added a more detailed test plan for the UI: - Go tools and choose Discrete Calendar - The field title is optional. [Cant change past] - Choose any date from the calendar that is yesterday or older. - Change it's details and save. Result: **Nothing should change.** [change from past to future] - Choose any date from the calendar that is yesterday or older. - Choose another date in the To date field that is today or in the future. - Update the details and save. Result: **Only dates starting from today are affected.** Adding holidays [Single holiday] - Choose any date from the calendar that is today or in the future. - Choose another date in the To date field that is in the future (optional, for range only). - Change Date type to : exception. - Save. Result: **All dates in the range should be marked red for unique holiday.** [Weekly] - Choose any Sunday from the calendar that is in the past or future. - Change Date type to : Weekly. - Save. Result: **All upcomming (starting from today) Sundays will be holidays.** PS: Open and close hour will be affected **to all Sundays** unless inputs are empty. [Fixed] - Choose any date from the calendar that is today or in the future. - Change Date type to : Fixed. - Save Result: **The selected date and the same day in the future (if available in Calendar) will be holiday.** [Fixed from the past] - Choose any date from the calendar that is in the past. - Change Date type to : Fixed. - Save Result: **The selected date is unchanged but the same day in the future (if available in Calendar) will be holiday.** Delete holidays [Single date] - Choose any date from the calendar that is today or in the future and is also a holiday. - Change Date type to : Normal day. - Save. Result: **The selected date should be a normal day** [Range of dates] - Choose any date from the calendar that is today or in the future. - Choose another date in the To date field that is in the future. - Change date type to : Normal day - Save. Result: **The selected dates should be a normal days** [Delete type] - Choose any date from the calendar that is today or in the future and is a weekly or a fixed holiday. - Change date type to : Normal day. - Check : Delete this type CheckBox - Save. Result: -Weekly, all upcoming weekly holidays if that day will be normal days. Example : all upcoming Sundays will be normal days -Fixed, all upcoming fixed holidays of that day will be normal days. Example : all upcoming 25 December will be normal days [Copy dates, 1 day to multiple] - Choose starting date from the calendar. - Choose en date in the To date field. - Select Copy to different dates - Choose starting date. - Choose end date date. - Save. Result: **The selected day details will be copied to all the dates in the range.** [Copy dates, 1 week to 1 week] - Choose starting date from the calendar. - Choose en date in the To date field to make a whole week(7 days). - Select Copy to different dates - Choose starting date. - Choose end date date to make a whole week(7 days). - Save. Result: **Every day of week from the first range will be applied to the second range. Independently of the order. Exemple : Sunday1 to Sunday2, Monday1 to Monday2, etc.** [Copy dates, multiple dates to multiple dates] - Choose start date from the calendar. - Choose end date in the To date field. - Select Copy to different dates - Choose start date. - Choose end date date to have the same number of days as the first range - Save. Result: **Each day from the first range will be applied the second range in the same order. Exemple : days1 to day1, day2 to day2, etc.** [Copy to branch] - Select any date to make the side panel appear. - Select : Copy calendar to another branch. - Choose a calendar to copy to. - Save. - Choose copied to calendar in the dropdown : Define the holidays for. Result: **All of the information in the currect calendar will be copied to the chosen calendar** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:15:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:15:07 +0000 Subject: [Koha-bugs] [Bug 14876] Show number of holds per record on the search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:19:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:19:30 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:22:03 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:29:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:29:00 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #56 from Josef Moravec --- Sorry, but I found some problems... First, the ReserveCount test is failing: t/db_dependent/Reserves/ReserveCount.t .. 1/3 Value not allowed for auto_incr hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267. Value not allowed for auto_incr hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267. Value not allowed for auto_incr hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267. # Failed test 'Test borrower has 2 reserve.' # at t/db_dependent/Reserves/ReserveCount.t line 82. # got: '1' # expected: '2' Value not allowed for auto_incr hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267. Value not allowed for auto_incr hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267. Value not allowed for auto_incr hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267. Value not allowed for auto_incr hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267. # Failed test 'Test borrower has 2 reserve.' # at t/db_dependent/Reserves/ReserveCount.t line 114. # got: '1' # expected: '3' # Looks like you failed 2 tests of 3. Second, Koha qa tools has complains: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc FAIL forbidden patterns forbidden pattern: simple-quote string (line 24) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/reserve-group.tt FAIL git manipulation The file has been added and deleted in the same patchset FAIL reserve/reserve-group.pl FAIL git manipulation The file has been added and deleted in the same patchset And you should also change the modal syntax... For bootstrap related issues see page https://wiki.koha-community.org/wiki/Interface_patterns especially sections "Buttons" and "Modals" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:36:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:36:15 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #45 from Josef Moravec --- Please, upgrade your templates to bootstrap 3 (see bug 16239) and https://wiki.koha-community.org/wiki/Interface_patterns http://getbootstrap.com/css/#grid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:42:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:42:20 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #48 from Josef Moravec --- Kyle, could you please provide followup due to bug 16239? See https://wiki.koha-community.org/wiki/Interface_patterns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 21:47:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 20:47:02 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 23:22:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 22:22:04 +0000 Subject: [Koha-bugs] [Bug 17309] Renewing and HomeOrHoldingBranch syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 Carl Salbacka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sabbacc108 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 23:40:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 22:40:56 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 23:41:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 22:41:00 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59497|0 |1 is obsolete| | --- Comment #16 from Mehdi Hamidi --- Created attachment 59531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59531&action=edit Bug 16018: Merge.pl does not update biblios linked to the old authority Original patch from Remi Mayrand-Provencher. Amended by Marcel de Rooy (January 2017), part of omnibus bug 17908. EDIT: We cannot remove the ModAuthority call, since the reference record is the result of the merge and should be saved. Variable $overwrite is not used and can be removed. The ModAuthority call triggers a merge like: recordid1, original ref record, recordid1, new ref record. This only updates all biblio records that were already attached to the reference record. As Remi discovered correctly, we still need another merge for the biblios attached to recordid2 (the record to be deleted). This patch adds that merge. Note: The results of this merge operation should have been improved by the changes to C4::AuthoritiesMarc::merge. Test plan: [1] Restart Plack and restart koha-indexer. (I had some problems related to indexing as a result of the marcxml transition.) [2] Go to Authorities. Select two authorities to merge, start with two of the same type. Make sure that both are used in a few biblio records. Select at least one subfield from the authority to be removed for inclusion in the authority to be kept ("reference record"). [3] Click Merge. You come back to the kept authority record. Note: The number of attached records may not yet be updated. This depends on the speed of koha-indexer. If you wait a bit and refresh, you should have the correct number. First check the authority record again for the inserted subfield. Now check a biblio that was ALREADY attached to the reference record. And check a biblio that was FORMERLY attached to the deleted one. Note: See bug 17913 to see how pref AuthorityMergeMode impacts this. [4] Try steps 2 and 3 again for a merge of two authority records that do not have the same authority type noting the remarks below. For instance try to merge from a CORPO_NAME to a PERSO_NAME record. Make a change in say 040$a of the record to be deleted. And select that field later on the merge form. Normally, you would use the PERSO_NAME framework in the merge now. When checking the authority record, look at 040a. When checking the record that was linked to the CORPO_NAME, check if it contains the PERSO_NAME authority in the correct field (say 100, 600, 700). Signed-off-by: Marcel de Rooy Signed-off-by: mehdi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 23:45:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 22:45:42 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #2 from David Cook --- (In reply to Jonathan Druart from comment #1) > I guess the regex should be m|^[\d-]*$|; > Instead of just /\d/ That doesn't account for ISBN-10 where the check digit can be X or x: https://en.wikipedia.org/wiki/Check_digit#ISBN_10 We could use Business::ISBN to check if it's an ISBN and then if it's not, we could treat it as a title. (We could even do ISBN search only for valid ISBNs and do title searches for everything else.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 24 23:47:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 22:47:48 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59502|0 |1 is obsolete| | --- Comment #17 from Mehdi Hamidi --- Created attachment 59532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59532&action=edit Bug 16018: Add a TODO for need_merge_authorities in merge.pl It is not useful to postpone a merge to the cron job here, since the old authority record is deleted and merge_authority cannot yet handle that correctly. But no harm either to leave it here. Note: This will be addressed shortly on bug 9988. So please help! Signed-off-by: Marcel de Rooy Signed-off-by: mehdi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:02:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:02:24 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #16 from David Cook --- Ooops... it looks like I actually created a new bug while fixing that bug! The test works but I made a copy/paste error which means koha_perl_deps.pl now doesn't work correctly! I'm just about to attach a patch to fix that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:02:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:02:40 +0000 Subject: [Koha-bugs] [Bug 17985] New: Hold request fails if only item in transit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17985 Bug ID: 17985 Summary: Hold request fails if only item in transit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To test: * Create patron rule that limits a patron category to checkout or place a hold only from Branch A * Set Patron 1 with that patron category * Create a single item bib record whose homebranch is Branch A SUCCESS * Try to place a hold on that item under Patron 1. You will see that you can. FAIL * Place a hold for that item under another patron under another branch and trigger the hold. * Place a hold for that item under Patron 1. You will see that you cannot place the hold! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:03:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:03:21 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #17 from David Cook --- Created attachment 59533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59533&action=edit Fix copy/paste error It looks like I made a copy/paste error in a previous patch. While the fix was working when you pass the param "module" to version_info, it wasn't populating the version correctly for the "all" param, which causes koha_perl_deps.pl to think all OK modules actually need an upgrade. TEST PLAN 0) Be on a system where you know your Koha Perl dependencies are mostly up-to-date 1) Run ./koha_perl_deps.pl -a -c 2) Note that most modules say they need an upgrade even when the installed version is the same as the minimum version 3) Apply patch 4) Run ./koha_perl_deps.pl -a -c 5) Note that most moduls say they're OK, especially when the installed version is the same or greater than the minimum version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:06:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:06:51 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59533|0 |1 is obsolete| | --- Comment #18 from David Cook --- Created attachment 59534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59534&action=edit Bug 17880: Fix copy/paste error It looks like I made a copy/paste error in a previous patch. While the fix was working when you pass the param "module" to version_info, it wasn't populating the version correctly for the "all" param, which causes koha_perl_deps.pl to think all OK modules actually need an upgrade. TEST PLAN 0) Be on a system where you know your Koha Perl dependencies are mostly up-to-date 1) Run ./koha_perl_deps.pl -a -c 2) Note that most modules say they need an upgrade even when the installed version is the same as the minimum version 3) Apply patch 4) Run ./koha_perl_deps.pl -a -c 5) Note that most moduls say they're OK, especially when the installed version is the same or greater than the minimum version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:22:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:22:59 +0000 Subject: [Koha-bugs] [Bug 17986] New: Perl dependency evaluation incorrect Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Bug ID: 17986 Summary: Perl dependency evaluation incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org While I was fixing Bug 17880, I mistakenly created a new bug via a copy/paste error. At the moment, if you run koha_perl_deps.pl -a -c, or go to /cgi-bin/koha/about.pl and click on Perl modules, most installed modules will be coloured yellow indicating they need an upgrade. The fix is a simple one line change, but will help solve a lot of headaches and confusion over people trying to meet dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:23:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:23:09 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17880 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:23:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:23:09 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17986 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:24:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:24:15 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 --- Comment #1 from David Cook --- Created attachment 59535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59535&action=edit Bug 17986 - Perl dependency evaluation incorrect It looks like I made a copy/paste error in a previous patch. While the fix was working when you pass the param "module" to version_info, it wasn't populating the version correctly for the "all" param, which causes koha_perl_deps.pl to think all OK modules actually need an upgrade. TEST PLAN 0) Be on a system where you know your Koha Perl dependencies are mostly up-to-date 1) Run ./koha_perl_deps.pl -a -c 2) Note that most modules say they need an upgrade even when the installed version is the same as the minimum version 3) Apply patch 4) Run ./koha_perl_deps.pl -a -c 5) Note that most moduls say they're OK, especially when the installed version is the same or greater than the minimum version https://bugs.koha-community.org/show_bug.cgi?id=17880 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:24:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:24:40 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59535|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 59536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59536&action=edit Bug 17986 - Perl dependency evaluation incorrect It looks like I made a copy/paste error in a previous patch. While the fix was working when you pass the param "module" to version_info, it wasn't populating the version correctly for the "all" param, which causes koha_perl_deps.pl to think all OK modules actually need an upgrade. TEST PLAN 0) Be on a system where you know your Koha Perl dependencies are mostly up-to-date 1) Run ./koha_perl_deps.pl -a -c 2) Note that most modules say they need an upgrade even when the installed version is the same as the minimum version 3) Apply patch 4) Run ./koha_perl_deps.pl -a -c 5) Note that most moduls say they're OK, especially when the installed version is the same or greater than the minimum version https://bugs.koha-community.org/show_bug.cgi?id=17880 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:24:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:24:37 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:26:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:26:18 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 --- Comment #3 from David Cook --- TEST PLAN alternative Instead of running koha_perl_deps.pl, you can visit /cgi-bin/koha/about.pl and click on "Perl modules". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:27:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:27:55 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:28:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:28:20 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #19 from David Cook --- See Bug 17986 for a separate bug report and fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:35:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:35:03 +0000 Subject: [Koha-bugs] [Bug 16914] Export csv in item search, exports all items in one line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16914 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #27 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:56:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:56:07 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:56:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:56:59 +0000 Subject: [Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:57:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:57:05 +0000 Subject: [Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:58:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:58:38 +0000 Subject: [Koha-bugs] [Bug 17720] CSRF token is not generated correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17720 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 00:59:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 24 Jan 2017 23:59:00 +0000 Subject: [Koha-bugs] [Bug 17830] CSRF token is not generated correctly (bis) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17830 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:22:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:22:52 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #50 from Mason James --- Enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:25:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:25:37 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Aleisha Amohia --- I have a few issues with the patch: 1) There is a 'session date' column and a 'date' column. The 'date' column is filled, but every row in the 'session date' column says Unknown. This column should be removed. 2) The 'start a new search' line is clickable without selecting any rows, but will not execute the search until some rows are selected. The line should be greyed out initially, as stated in your test plan 3) My previous search history in both staff client and OPAC are gone. Setting as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:28:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:28:25 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #29 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:30:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:30:16 +0000 Subject: [Koha-bugs] [Bug 17725] Repeating a field or subfield clones content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17725 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Blocked by enhancement, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:36:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:36:04 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:40:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:40:02 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #237 from Mason James --- New feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:41:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:41:16 +0000 Subject: [Koha-bugs] [Bug 14685] Cannot set guarantor for a child account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 [Bug 17766] Patron notification does not work with multi item holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:41:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:41:16 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Depends on| |14685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 [Bug 14685] Cannot set guarantor for a child account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:42:57 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:42:57 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17766 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 [Bug 17766] Patron notification does not work with multi item holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 01:44:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 00:44:35 +0000 Subject: [Koha-bugs] [Bug 17766] Patron notification does not work with multi item holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17766 --- Comment #7 from Mason James --- Blocked by new feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 02:50:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 01:50:36 +0000 Subject: [Koha-bugs] [Bug 11536] patron self registration fails when PatronSelfRegistrationDefaultCategory is set to nonexistent borrower category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11536 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #1 from Aleisha Amohia --- The original bug you are reporting doesn't seem quite valid anymore. Instead there is a different bug. It doesn't matter what you put in the PatronSelfRegistrationDefaultCategory because the OPAC form itself has a category field that sets the patron category. My opinion is that the PatronSelfRegistrationDefaultCategory should be changed to a dropdown with a list of the existing patron categories. If it is set to something, then the category field in the OPAC form should be removed and will be set to whatever is in PatronSelfRegistrationDefaultCategory. If it is empty, the user can select their category themselves (the current behaviour). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 02:55:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 01:55:44 +0000 Subject: [Koha-bugs] [Bug 11536] patron self registration fails when PatronSelfRegistrationDefaultCategory is set to nonexistent borrower category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11536 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Aleisha Amohia --- Actually, my mistake - this seems to be fixed now. If the input in PatronSelfRegistrationDefaultCategory doesnt match an existing category, the category list is still there and the patron is assigned the first one in the list. This doesn't seem to be a bug anymore. Setting to Resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 03:25:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 02:25:06 +0000 Subject: [Koha-bugs] [Bug 17987] New: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Bug ID: 17987 Summary: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Rather than a free text syspref where a user can easily put in a category that doesn't exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 06:23:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 05:23:25 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 09:00:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 08:00:44 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 09:11:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 08:11:20 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 jesus at medios.es changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesus at medios.es --- Comment #4 from jesus at medios.es --- Packaged koha-kommon included in Debian Wheezy seems to be affected by this bug. Upgrades to koha-kommon 16.05.05 package fail complaining of perl "virtual packages" unmet dependencies. Will this patch be commited to 16.11 or shall we wait to 17.05? Best, Jesus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 09:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 08:17:20 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 --- Comment #9 from Jonathan Druart --- (In reply to Martin Renvoize from comment #8) > Looks good to me :) Is it a signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 09:24:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 08:24:56 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59511|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy --- Created attachment 59537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59537&action=edit Bug 17982: Fix the use of uniq in sub themelanguage Doing uniq( \@themes ) is useless. It will just return to you the only reference you gave it. List::MoreUtils::uniq requires a list instead of an arrayref. So it is a trivial fix that makes sub themelanguage return one theme instead of three themes like [ 'prog', 'prog', 'prog' ]. Note that Template->new inserts one or two include paths to TT for each of these three identical themes. Added a unit test to be somewhat overcomplete :) Test plan: [1] Run t/db_dependent/Templates.t [2] Open a page on OPAC or intranet. (Did you restart Plack?) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 09:30:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 08:30:04 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 09:30:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 08:30:07 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59536|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 59538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59538&action=edit Bug 17986: Perl dependency evaluation incorrect It looks like I made a copy/paste error in a previous patch. While the fix was working when you pass the param "module" to version_info, it wasn't populating the version correctly for the "all" param, which causes koha_perl_deps.pl to think all OK modules actually need an upgrade. TEST PLAN 0) Be on a system where you know your Koha Perl dependencies are mostly up-to-date 1) Run ./koha_perl_deps.pl -a -c 2) Note that most modules say they need an upgrade even when the installed version is the same as the minimum version 3) Apply patch 4) Run ./koha_perl_deps.pl -a -c 5) Note that most moduls say they're OK, especially when the installed version is the same or greater than the minimum version Signed-off-by: Marcel de Rooy Running koha_perl_deps.pl -u convinced me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:00:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:00:19 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59440|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 59539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59539&action=edit Bug 17963: TT syntax for notices - Prove that AR_* are compatible Nothing new here since bug 17962, the AR_* notice messages are quite simple. They send the article_request, patron, biblio, biblioitem, item and library linked to the article request. All the fields from these 6 tables should still be accessible using the TT syntax. Test plan: Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED or AR_CANCELED. You should manage to create a template to generate the same result as the historical syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:01:04 +0000 Subject: [Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- (In reply to Josef Moravec from comment #4) > I think there is missing article_requests table definition in C4::Letters, I > am getting the notice generated without any information from > article_requests table... but test is passing... Yes indeed, the test was completely wrong! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:21:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:21:52 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59436|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 59540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59540&action=edit Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible >From the CHECKIN and CHECKOUT templates you should be able to access the following information: item, biblio, biblioitem, patron and library Test plan: Define CHECKIN and CHECKOUT notice templates. You should be able to define them using the TT syntax to produce the same generated notice messages as with the historical syntax. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:21:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:21:56 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59437|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 59541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59541&action=edit Bug 17964: Add old_issues If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a "old_issues" key instead of "issues". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:21:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:21:59 +0000 Subject: [Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59438|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 59542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59542&action=edit Bug 17964: Support date formatting Using the KohaDates plugin will allow us to format dates as we want, using the same filters as the ones defined in the KohaDates TT plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:29:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:29:37 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 [Bug 17986] Perl dependency evaluation incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:29:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:29:37 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 [Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:54:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:54:02 +0000 Subject: [Koha-bugs] [Bug 17988] New: Select2 prevents correct tag expand/ minimize functionality Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Bug ID: 17988 Summary: Select2 prevents correct tag expand/minimize functionality Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: synapse.ova at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Overview: Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure. Because of that, expanding fields to show all hidden subfields does not work properly. Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Try to minimize or expand fields, that have among subfields the following: ? Thesaurus driven subfield ? subfield with Select2 ? Hidden subfield. Actual Results: ?? some fields become hidden, some not, and vice versa ?? in the console, you'll see ?Uncaught TypeError: Cannot read property 'match' of null? Expected Results: ?? all subfields should minimize/maximize completely Additional Information: This happens because Select2 adds some divs, that do not have ID property. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:56:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:56:39 +0000 Subject: [Koha-bugs] [Bug 17989] New: Working title Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Bug ID: 17989 Summary: Working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 10:56:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 09:56:51 +0000 Subject: [Koha-bugs] [Bug 17989] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:06:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:06:36 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |synapse.ova at gmail.com --- Comment #1 from Oleg Vasilenko --- Created attachment 59543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59543&action=edit Bug 17988: add attribute check The following patch adds check for the needed attribute existance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:08:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:08:18 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13501 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 [Bug 13501] Allow autocompletion on drop-down lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:08:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:08:18 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 [Bug 17988] Select2 prevents correct tag expand/minimize functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:20:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:20:10 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Oleg Vasilenko --- Steps to Reproduce: 1. Open some book in the editor or create new (cataloguing/addbiblio.pl) 2. Add info to authority-controlled subfield. One of the subfields of this field should be thesaurus driven ? subfield with Select2 (In UNIMARC that could be 700-702) Actual Results: ?? data from the authority record does not added ?? blinddetail-biblio-search.pl with white screen is opened, and does not close Expected Results: Info from the authority record shoul be added to appropriate subfields Additional Information: This happens because Select2 adds some inputs, that do not have NAME property. The following patch adds check for the needed attribute existance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:21:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:21:46 +0000 Subject: [Koha-bugs] [Bug 17780] When choose an author in authority results new window shows a blank screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17780 Oleg Vasilenko changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gveranis at seab.gr |synapse.ova at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:34:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:34:00 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 --- Comment #6 from Jonathan Druart --- Created attachment 59544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59544&action=edit Bug 17986: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:36:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:36:24 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 --- Comment #7 from Jonathan Druart --- I am stuck, I tried to provide tests to highlight the problem, but I do not manage to make them fail. There is something wrong in the code: It seems that the same code is duplicated: if ( $params{module} ) { do something; } else { do almost the same thing; } Except that in the first block, $_ is used, but is always undefined (not in a loop). This code sounds ugly and buggy, it may be good to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:39:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:39:43 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > I am stuck, I tried to provide tests to highlight the problem, but I do not > manage to make them fail. > There is something wrong in the code: > It seems that the same code is duplicated: > if ( $params{module} ) { > do something; > } else { > do almost the same thing; > } > > Except that in the first block, $_ is used, but is always undefined (not in > a loop). > This code sounds ugly and buggy, it may be good to fix it. Yeah. I saw the code; it is horrible. But this seems to fix at least one issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 11:43:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 10:43:03 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Attachment #59534|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy --- Comment on attachment 59534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59534 Bug 17880: Fix copy/paste error Deleting this patch here, since it is on a new report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:22:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:22:03 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 --- Comment #9 from Jonathan Druart --- Ok, I am rewriting it, will move that to another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:40:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:40:14 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:40:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:40:18 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59538|0 |1 is obsolete| | Attachment #59544|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 59545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59545&action=edit Bug 17986: Perl dependency evaluation incorrect It looks like I made a copy/paste error in a previous patch. While the fix was working when you pass the param "module" to version_info, it wasn't populating the version correctly for the "all" param, which causes koha_perl_deps.pl to think all OK modules actually need an upgrade. TEST PLAN 0) Be on a system where you know your Koha Perl dependencies are mostly up-to-date 1) Run ./koha_perl_deps.pl -a -c 2) Note that most modules say they need an upgrade even when the installed version is the same as the minimum version 3) Apply patch 4) Run ./koha_perl_deps.pl -a -c 5) Note that most moduls say they're OK, especially when the installed version is the same or greater than the minimum version Signed-off-by: Marcel de Rooy Running koha_perl_deps.pl -u convinced me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:41:14 +0000 Subject: [Koha-bugs] [Bug 17990] New: Code to check perl module versions is buggy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 Bug ID: 17990 Summary: Code to check perl module versions is buggy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 [Bug 17986] Perl dependency evaluation incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:41:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:41:14 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 [Bug 17990] Code to check perl module versions is buggy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:41:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:41:51 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > Ok, I am rewriting it, will move that to another bug report. See bug 17990. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:45:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:45:02 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:45:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:45:06 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 --- Comment #1 from Jonathan Druart --- Created attachment 59546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59546&action=edit Bug 17990: Refactor Perl module versions check The code is duplicated, variable are not set ($_), code is hard to read, not covered by tests and the subroutine has 2 completely different behaviors depending on the presence of the "module" parameter. No need more ti rewrite it. Test plan: - Use koha_perl_deps.pl with the different options (-u -m -a -i) - Go on the about page, "Perl modules" tab You should not see any differences from before and after this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:50:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:50:08 +0000 Subject: [Koha-bugs] [Bug 17988] Select2 prevents correct tag expand/minimize functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 12:55:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 11:55:57 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #16 from Jonathan Druart --- So we are going to loose the 'check in' and 'renew' actions from the header search and the syspref search will become the default one. Does everybody agree with that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:11:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:11:23 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59532|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy --- Created attachment 59547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59547&action=edit Bug 16018: Add a TODO for need_merge_authorities in merge.pl It is not useful to postpone a merge to the cron job here, since the old authority record is deleted and merge_authority cannot yet handle that correctly. But no harm either to leave it here. Note: This will be addressed shortly on bug 9988. So please help! Signed-off-by: Marcel de Rooy Signed-off-by: mehdi Signed-off-by: Marcel de Rooy EDIT: Typo recordid1 => recordid2 for new record in table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:11:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:11:50 +0000 Subject: [Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018 --- Comment #19 from Marcel de Rooy --- (In reply to Mehdi Hamidi from comment #17) > Created attachment 59532 [details] [review] > Bug 16018: Add a TODO for need_merge_authorities in merge.pl > > It is not useful to postpone a merge to the cron job here, since the > old authority record is deleted and merge_authority cannot yet handle > that correctly. But no harm either to leave it here. > > Note: This will be addressed shortly on bug 9988. So please help! > > Signed-off-by: Marcel de Rooy > Signed-off-by: mehdi Great, mehdi. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:13:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:13:10 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehdi.hamidi at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:35:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:35:10 +0000 Subject: [Koha-bugs] [Bug 17992] New: REST api: Cities controller should not use ->unblessed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Bug ID: 17992 Summary: REST api: Cities controller should not use ->unblessed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org As bug 17932 introduced the TO_JSON method there's no need to call ->unblessed anymore. As this is a reference implementation, I fix it to the new coding style. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:35:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:35:25 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Depends on| |17932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 [Bug 17932] Koha::Object should provide a TO_JSON method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:35:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:35:25 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17992 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 [Bug 17992] REST api: Cities controller should not use ->unblessed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:42:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:42:32 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:48:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:48:13 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:48:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:48:19 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 59548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59548&action=edit Bug 17992: REST api: Remove the use of ->unblessed from Cities controller As bug 17932 adds TO_JSON to Koha::Object(s), there's no need for using it. Also, as this is a reference implementation for developers to copy and paste it is sensible to make this change even when this is not causing any bug. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests still pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:48:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:48:41 +0000 Subject: [Koha-bugs] [Bug 17989] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 [Bug 17982] Fix the use of uniq in sub themelanguage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:48:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:48:41 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17989 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 [Bug 17989] Working title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 13:52:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 12:52:03 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart --- This patch adds a lot of indentation changes but does not improve it. Could you provide a patch without the indentation changes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:17:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:17:37 +0000 Subject: [Koha-bugs] [Bug 17993] New: Do not use modal authentication with CAS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Bug ID: 17993 Summary: Do not use modal authentication with CAS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in other links leading to authentication like for lists and tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:17:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:17:46 +0000 Subject: [Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17993 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 [Bug 17993] Do not use modal authentication with CAS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:17:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:17:46 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046 [Bug 12046] Authentication using CAS - bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:18:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:18:01 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:49:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:49:34 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #1 from Fridolin SOMERS --- Created attachment 59549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59549&action=edit Bug 17993 - Do not use modal authentication with CAS - lists Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link of lists popup : "Log in to create your own lists" Test plan : - Enable syspref casAuthentication - Go to OPAC - Click on Lists > Log in to create your own lists => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:49:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:49:45 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 --- Comment #2 from Fridolin SOMERS --- Created attachment 59550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59550&action=edit Bug 17993 - Do not use modal authentication with CAS - tags Bug 12046 corrected the fact that modal dialog does not allow to use the CAS authentication in main authentication link. This must also be corrected in link for tags in detail page : "Log in to add tags" Test plan : - Enable syspref casAuthentication - Go to OPAC - Go to a record detail page opac-detail.pl - Click on "Log in to add tags" => Without patch you get the modal login popup => With patch you go to the login page opac-user.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:50:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:50:05 +0000 Subject: [Koha-bugs] [Bug 17993] Do not use modal authentication with CAS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17993 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:54:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:54:51 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 14:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 13:54:53 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59378|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 59551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59551&action=edit Bug 17952 - Lost items not skipped by overdue_notices.pl If a library does not use --mark-returned when running longoverdue.pl, all those lost item checkouts are selected by overdue_notices.pl. This causes much unnecessary overhead. In addition Koha::Calendar is instantiated many times for each branchcode which is not necessary. Test Plan: 1) Run overdue_notices.pl, note output 2) Apply this patch 3) Run overdue_notices.pl again, note output is the same Signed-off-by: Kyle M Hall Signed-off-by: Jane Leven -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 15:17:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 14:17:48 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 15:32:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 14:32:15 +0000 Subject: [Koha-bugs] [Bug 17992] REST api: Cities controller should not use ->unblessed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17992 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 15:32:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 14:32:55 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:27:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:27:22 +0000 Subject: [Koha-bugs] [Bug 17494] Koha generating duplicate self registration tokens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17494 --- Comment #18 from Julian Maurice --- Reverted patch 2 and 3 from 3.22.x as they are not intended for this version. First patch kept because it's useful in 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:30:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:30:35 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 --- Comment #3 from Julian Maurice --- Reverted some patches from bug 17494 (see bug 17494, comment 18) in 3.22.x Will be fixed in 3.22.16 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:30:43 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:30:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:30:51 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:31:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:31:00 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:31:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:31:08 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:32:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:32:49 +0000 Subject: [Koha-bugs] [Bug 17943] "make test" failed when upgrading from koha-3.22.10 to 3-22.14 , also fresh installation of koha-3.22.14 made the same "make test" failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17943 --- Comment #4 from Julian Maurice --- Thanks Michael and Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:43:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:43:57 +0000 Subject: [Koha-bugs] [Bug 17994] New: OAI-PMH: ListSets logs a warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17994 Bug ID: 17994 Summary: OAI-PMH: ListSets logs a warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Steps to reproduce: - Have current master source - Point your browser to the OAI endpoint - Select 'Sets' (or just go to http://localhost:8080/cgi-bin/koha/oai.pl?verb=ListSets) => FAIL: You get this in the logs: Use of uninitialized value $metadata_prefix in join or string at /home/vagrant/kohaclone/Koha/OAI/Server/ResumptionToken.pm line 69. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:44:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:44:50 +0000 Subject: [Koha-bugs] [Bug 17994] OAI-PMH: ListSets logs a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17994 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 16:53:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 15:53:22 +0000 Subject: [Koha-bugs] [Bug 14919] Reserves history for patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Brenda Turnbull changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bturnbull at livewirewarringto | |n.org --- Comment #1 from Brenda Turnbull --- I wondered if a report would help your staff with this request. I ahve placed the report in teh SQL area. We palced a link on the home page fo staff to access this report. https://wiki.koha-community.org/wiki/SQL_Reports_Holds#Patrons_Holds_History_List -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 17:00:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 16:00:56 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 17:00:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 16:00:59 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #11 from Nick Clemens --- Created attachment 59558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59558&action=edit Bug 17782 - (QA Followup) Fix tests prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 17:46:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 16:46:26 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #8 from Josef Moravec --- Just read quickly through the code. First I have to say: good job Owen! Just one think: It is enough to use container-fluid for full width grid, row-fluid should be just "row" acording to bootstrap documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 18:04:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 17:04:06 +0000 Subject: [Koha-bugs] [Bug 17995] New: HOLDPLACED notice should have access to the reserves table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Bug ID: 17995 Summary: HOLDPLACED notice should have access to the reserves table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org HOLDPLACED is in the reserves module but cannot use reserves columns in the notice. 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 18:04:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 17:04:59 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #9 from M. Tompsett --- (In reply to Owen Leonard from comment #7) > Okay, I think I understand. I think it's fine. > > > Don't you love the set koha version text? :( > > Can you explain this comment please? That was part of the transitional changes on 17855. Nevermind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 18:05:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 17:05:46 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 18:05:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 17:05:48 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 --- Comment #1 from Nick Clemens --- Created attachment 59559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59559&action=edit Bug 17995 - HOLDPLACED notice should have access to the reserves table To test: 1 - Add reserves.reservenotes to HOLDPLACED message 2 - Enable emailLibrarianWhenHoldIsPlaced OpacHoldNotes sysprefs 3 - Place a hold via OPAC with a note 4 - view the messagequeue and note the reservenotes is blank 5 - Apply patch 6 - Place a hold with a note 7 - view the messagequeue and note the reservenotes is populated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 18:07:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 17:07:48 +0000 Subject: [Koha-bugs] [Bug 14919] Reserves history for patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | --- Comment #2 from Josef Moravec --- (In reply to Brenda Turnbull from comment #1) > I wondered if a report would help your staff with this request. I ahve > placed the report in teh SQL area. We palced a link on the home page fo > staff to access this report. > https://wiki.koha-community.org/wiki/ > SQL_Reports_Holds#Patrons_Holds_History_List Yes, that's the solution we have adopted... but I think it's still valid to have it integrated into patron account better, I am assigning it to myself and will see if I will be able to come with something ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 18:21:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 17:21:06 +0000 Subject: [Koha-bugs] [Bug 17995] HOLDPLACED notice should have access to the reserves table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17995 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 18:40:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 17:40:39 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 --- Comment #5 from tmcmahon at wlpl.org --- My tests were from the staff interface. It's not likely the staff will be reserving in bulk for a patron, but the bug still exists there if someone feels the need to work on this. If a patron selects a group of items to reserve, it will add items up to the limit, but not give a warning that not all items were added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 19:00:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 18:00:33 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Hugo Agud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hagud at orex.es --- Comment #31 from Hugo Agud --- I have tested the patch and it works fine! I am not able to generate the signed patch, sorry -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 19:06:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 18:06:18 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 19:17:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 18:17:20 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #29 from J Schmidt --- This is what I did on 1/25/17: 1. Used the ByWater sandbox. 2. Went to Tools > Discrete calendar. 3. Page opens /tools/discrete_calendar.pl but yellow error states "You have to run generate_discrete_calendar.pl in order to use Discrete Calendar. 4. I pushed on and went back a month and clicked on Dec. 1, 2016. Nothing. FYI. jenny~ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 19:40:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 18:40:44 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #30 from Mehdi Hamidi --- Hello jenny, First, thank you for testing our patch! Did you run the script generate_discrete_calendar.pl? If so, was there any errors? Discrete Calendar needs to have valid dates in database in order to work. Without them, an error message is shown and the calendar doesn't work. Mehdi. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 20:13:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 19:13:16 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #31 from Blou --- Mehdi, I think that in order to be tested using those soap box, you'll need something in atomicupdates/ that does the equivalent of your init script, or just call it. The box users have no control over running manual scripts, iiuc. So maybe add a patch clearly identifying that it's just doing that (and being useless otherwise). Otherwise, the patch is no "Patch doesn't apply". Soap boxes limits is not a code error per se. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 20:45:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 19:45:27 +0000 Subject: [Koha-bugs] [Bug 17996] New: longoverdue.pl should not set 'datereturned' when --mark-returned option is used. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Bug ID: 17996 Summary: longoverdue.pl should not set 'datereturned' when --mark-returned option is used. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz When longoverdue.pl returns items, it sets old_issues.returndate to the current date. This means that when staff look at the borrowers' circulation history, they see a returndate displayed, which is confusing. We don't lose information by not setting old_issues.returndate, because items.itemlost_on will contain the date that the item was lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 20:46:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 19:46:32 +0000 Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 20:57:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 19:57:02 +0000 Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 20:57:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 19:57:05 +0000 Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 --- Comment #1 from Kyle M Hall --- Created attachment 59560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59560&action=edit Bug 17996 - longoverdue.pl should not set 'datereturned' when --mark-returned option is used When longoverdue.pl returns items, it sets old_issues.returndate to the current date. This means that when staff look at the borrowers' circulation history, they see a returndate displayed, which is confusing. We don't lose information by not setting old_issues.returndate, because items.itemlost_on will contain the date that the item was lost. Test Plan: 1) Apply this patch 2) Mark an item lost using longoverdue.pl with --mark-returned 3) Note the item's old_issues line does not have a returndate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 21:19:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 20:19:53 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #3 from Alex Buckley --- (in reply to comment 2 by M.Tompsett) I have altered the formatting of the date so that it does not show time, i.e. it is displayed in the format: DD/MM/YY I assume this is what you were referring to when saying that TT variable was excessive? But before I attach my new commit to this bug, I would like to ask if you are happy with the time being displayed being the UTC rather than the localtime? The issue is that the timestamp of the member modification request is stored as UTC in the database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 21:36:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 20:36:17 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #32 from Mehdi Hamidi --- Created attachment 59561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59561&action=edit Bug 17015 - Fix for sandbox users, updatedatebase.pl now calls generate_discrete_calendar.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 21:42:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 20:42:59 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59561|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 21:45:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 20:45:03 +0000 Subject: [Koha-bugs] [Bug 17997] New: Staff client -- print cart stalls when cart is sorted by item. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17997 Bug ID: 17997 Summary: Staff client -- print cart stalls when cart is sorted by item. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To reproduce: 1) Run a search in the staff client 2) Select several of the bibs 3) Select 'cart' from 'Add to' drop down and click 'Save' 4) Click cart link at the top of the page. 5) Click print button -- this should bring up the browser's print dialog. 6) Click on 'Items' column to sort by item 7) Click print button -- Nothing happens I have tested this in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 21:46:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 20:46:24 +0000 Subject: [Koha-bugs] [Bug 17997] Staff client -- print cart stalls when cart is sorted by item. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17997 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 21:50:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 20:50:11 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59516|0 |1 is obsolete| | --- Comment #33 from Mehdi Hamidi --- Created attachment 59562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59562&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 22:02:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 21:02:49 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 22:10:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 21:10:02 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #34 from Mehdi Hamidi --- (In reply to Blou from comment #31) > Mehdi, > I think that in order to be tested using those soap box, you'll need > something in atomicupdates/ that does the equivalent of your init script, or > just call it. The box users have no control over running manual scripts, > iiuc. > > So maybe add a patch clearly identifying that it's just doing that (and > being useless otherwise). > > Otherwise, the patch is no "Patch doesn't apply". Soap boxes limits is not > a code error per se. Thank you for the insight Phillipe! I Changed the test plan so sandbox users can test the patch. Test plan : 1- Apply patch 2- Run installer/data/mysql/updatedatabase.pl 3- Run the script add_days_discrete_calendar.pl to add days into the future - Check if the max date is now today + 1 day 4- Generate schemas by running misc/devel/update_dbix_class_files.pl 5- Run test t/db_dependent/DiscreteCalendar.t 6- Run all of Koha's tests in t/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 22:39:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 21:39:47 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #35 from J Schmidt --- Again on 1/25/17 3:32pm CST (US), I went back into the sandbox for ByWater (first one). The .pl script and patch seems to have been applied. Steps: 1.) Tools > Discrete Calendar for Alphaville. 2.) Changed the calendar back to December 2016 and selected Dec 1st. 3.) Received the Add new holiday dialog box. 4.) Filled in "To date"; "title" Date type: "Weekly" Open hours; 5.) Filled in the hour/minutes (12:30) and (16:30). 6.) Left default Edit selected dates. then clicked Save. 7.) Received a software error, The 'month' parameter ("30") to DateTime::new did not pass the 'an integer between 1 and 12' callback at /usr/local/lib/perl/5.14.2/DateTime.pm line 197. DateTime::new(undef, "hour", 0, "minute", 0, "second", 0, "month", 30, ...) called at /var/lib/koha/sandbox1/kohaclone/Koha/DateUtils.pm line 172 Koha::DateUtils::dt_from_string("04/30/2017") called at /var/lib/koha/sandbox1/kohaclone/tools/discrete_calendar.pl line 94 main::edit_holiday() called at /var/lib/koha/sandbox1/kohaclone/tools/discrete_calendar.pl line 60 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jan 25 23:54:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 22:54:10 +0000 Subject: [Koha-bugs] [Bug 17998] New: Notice ISSUEQSLIP changes do not take effect consistently Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17998 Bug ID: 17998 Summary: Notice ISSUEQSLIP changes do not take effect consistently Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: arm at hanover.ca QA Contact: testopia at bugs.koha-community.org Changes made the the ISSUEQSLIP template text may eventually happen but not quickly. When the slip is printed, for some time older versions appear instead. This might not happen in later versions, tested in 3.22. We have not tested this in any other notice templates - only ISSUEQSLIP. Details: I make a change (in the 'email' tab), submit, and then open another tab to view or print the change in patron checkout, and my changes are not there. After making several changes to the layout in the 'email' tab, and then attempting to print the slip - newest changes are not there in the print for some time and the preceding versions continue to appear - not the same older version every time but alternating different versions. I did this all in both our 'sandbox' test system, and in our live system. Eventually got the layout I wanted in the test system and copied it to the live system, but still changes did not happen once submitted. I also created a Hanover Library rule (as opposed to the 'all libraries' one), and that seemed to make things worse. I have deleted it. I tried closing browser, using a different browser... and still I would get the version before last or the one before that instead of the most recently submitted. I tried submitting, closing the edit page, waiting, opening and submitting again three times. John at Equinox tested the issue and reported that: I was able to duplicate the issue you described, although this is the first I've heard of it. Some things I found while examining this: 1) the changes do register immediately in the database where the templates are stored. 2) In my testing, every other time I printed a quick slip it would reflect the change, until eventually it would show the change every time. 3) Different browsers made no difference. 4) Restarting Apache between changes appeared to make no difference either. 5) I was not able to duplicate it on 16.05 system It does seem like this is a bug. Katrin asked whether we are using Plack (yes) and caching (I don't know), and she asked that we submit a new bug for this. If anyone could test it on your local 16.05 setup and report whether this can be duplicated, or comment on whether it is related to Plack or caching setup that would be great. We will hope that it is gone in the next release but provide this information for anyone who might run into it or in case it indicates a larger underlying issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 00:07:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 23:07:53 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Luke Honiss changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 00:07:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 25 Jan 2017 23:07:57 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 --- Comment #11 from Luke Honiss --- Created attachment 59563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59563&action=edit Bug 11450: Hold Request Confirm Deletion ==TEST PLAN== 1) Go to an item with a hold and click on the holds tab on the left 2) Click the red 'X' 3) The hold will be deleted immediately 4) Apply patch 5) Return to an item with a hold and click the 'X' 6) There will now be a confirmation dialog 7) Click cancel and the dialog will disappear and the hold will not be deleted 8) Click OK and the hold will be deleted Fixed some indentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 01:37:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 00:37:13 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Attachment #59505|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 01:38:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 00:38:01 +0000 Subject: [Koha-bugs] [Bug 11450] Hold Request Confirm Deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11450 --- Comment #12 from Chris Cormack --- Well done Luke working on your patches after the Academy is finished, very good to see! Don't forget to obsolete any old patches if you add one to replace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 02:56:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 01:56:39 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #5 from Alex Buckley --- Created attachment 59564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59564&action=edit Bug 17944 - Removed the sql code from Itemtypes.pm and replaced it with DBIx database query in the itemtypes.pl administrative script Test plan: 1. In the staff interface, stage and manage MARC records for import 2. Try to delete an itemtype. If there are items of that itemtype in the database then a message telling you the number of items of that itemtype there are will be displayed. 3. Record that number 4. View the admin/itemtpes.pl script and confirm that there is sql code written in this file. 5. Apply this patch 6. View the admin/itemtypes.pl script and observe that there is no sql in this file. There is however DBIx code, for example $schema->resultset('Item')->search({ 'itype' => $itemtype_code} ); which is searching for items with the itype value matching $itemtype_code value. 7. In the staff interface try to delete the same itemtype 8. Record the number of items there are with that itemtype in the resulting message 9. The numbers recorded in steps 3 and 8 should match showing that the DBIx code is working as intended -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:05:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:05:09 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #6 from Alex Buckley --- (in reply to comment 4 by M.tompsett) I have tried to implement DBIx in the itemtypes.pl script. To get it working successfully I had to implement two DBIx queries, one to search the items and another to search the biblioitems for the itemtype being attempted to be deleted. Then I add the number of retrieved items together. I tried to implement the entire original sql query into the equivalent singular DBIx query however I could not get a successful search of both items and biblioitems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:30:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:30:19 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #7 from M. Tompsett --- Comment on attachment 59564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59564 Bug 17944 - Removed the sql code from Itemtypes.pm and replaced it with DBIx database query in the itemtypes.pl administrative script Review of attachment 59564: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17944&attachment=59564) ----------------------------------------------------------------- ::: admin/itemtypes.pl @@ +145,5 @@ > + my $itemtotal = $schema->resultset('Item')->search({ 'itype' => $itemtype_code} ); > + my $bibliototal = $schema->resultset('Biblioitem')->search({ 'itemtype' => $itemtype_code} ); > + > + $itemtotal->count; > + $bibliototal->count; Why? @@ +146,5 @@ > + my $bibliototal = $schema->resultset('Biblioitem')->search({ 'itemtype' => $itemtype_code} ); > + > + $itemtotal->count; > + $bibliototal->count; > + my $overalltotal = $itemtotal + $bibliototal; I like the idea, but this segment of code is not quite right. Why the context line? why not my $foo = $schema->resulset('Bar')->search({ 'foobar' => $itemtypecode })->count // 0; with the appropriate variables and tables changed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:31:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:31:37 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:32:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:32:45 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #8 from Alex Buckley --- I'll try implementing that now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:37:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:37:52 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #9 from Alex Buckley --- So before I attach the new commit just to check would you be happy with this? my $schema = Koha::Database->new()->schema(); my $itemtotal = $schema->resultset('Item')->search({ 'itype' => $itemtype_code})->count; my $bibliototal = $schema->resultset('Biblioitem')->search({ 'itemtype' => $itemtype_code})->count; my $overalltotal = $itemtotal + $bibliototal; if ($overalltotal) { push @messages, { type => 'error', code => 'cannot_be_deleted', total => $overalltotal }; $op = 'list'; } else { my $itemtype = Koha::ItemTypes->find($itemtype_code); $template->param( itemtype => $itemtype, ); } I have tested it and it outputs the correct value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:42:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:42:33 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #10 from M. Tompsett --- (In reply to Alex Buckley from comment #9) > So before I attach the new commit just to check would you be happy with this? Yes, and it is prettier. Thank you. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:44:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:44:21 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 --- Comment #11 from Alex Buckley --- Created attachment 59565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59565&action=edit Bug 17944 - Tidied the DBIx code in itemtypes.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 03:44:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 02:44:43 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 05:54:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 04:54:10 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #4 from M. Tompsett --- Comment on attachment 59379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59379 [SIGNED-OFF] Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Review of attachment 59379: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17334&attachment=59379) ----------------------------------------------------------------- This is what I was talking about. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt @@ +79,4 @@ >
    > [% FOREACH pm IN PendingModifications %] > [% SET borrowernumber = pm.borrowernumber %] > + [% SET timestamp = pm.timestamp %] This is overkill, because... @@ +79,5 @@ >
    > [% FOREACH pm IN PendingModifications %] > [% SET borrowernumber = pm.borrowernumber %] > + [% SET timestamp = pm.timestamp %] > +

    [% borrowers.$borrowernumber.surname %][% IF ( borrowers.$borrowernumber.firstname ) %], [% borrowers.$borrowernumber.firstname %][% END %] - [% Categories.GetName( borrowers.$borrowernumber.categorycode ) %] ([% Branches.GetName( borrowers.$borrowernumber.branchcode ) %]) ([% borrowers.$borrowernumber.cardnumber %]) Requested: [% timestamp %]

    You only use it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 05:55:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 04:55:26 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #5 from M. Tompsett --- (In reply to Alex Buckley from comment #3) > But before I attach my new commit to this bug... No need. Let QA do their job. If they are fine with it. Let it go. If not, they'll tweak it and push it through. -- You are receiving this mail because: You are watching all bug changes. From irfan.itscholar at gmail.com Thu Jan 26 08:24:54 2017 From: irfan.itscholar at gmail.com (Muhammad Irfan Awan) Date: Thu, 26 Jan 2017 12:24:54 +0500 Subject: [Koha-bugs] Error on Koha 3.0 Message-ID: When I search a book against barcode error arises Can't call method "raw" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 487 -------------- next part -------------- An HTML attachment was scrubbed... URL: From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 09:01:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 08:01:55 +0000 Subject: [Koha-bugs] [Bug 17989] Allow templates from plugin directories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |Allow templates from plugin | |directories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 09:02:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 08:02:21 +0000 Subject: [Koha-bugs] [Bug 17989] Allow templates from plugin directories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Templates |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:02:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:02:19 +0000 Subject: [Koha-bugs] [Bug 17999] New: batch item modifications does disregard MARC framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17999 Bug ID: 17999 Summary: batch item modifications does disregard MARC framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: boutrosboutrosboutros at gmail.com QA Contact: testopia at bugs.koha-community.org When performing batch item modifications, the form to enter item details is allways created using the standard MARC framework, and not using the framework of the bilio the items belongs to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:02:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:02:45 +0000 Subject: [Koha-bugs] [Bug 17999] batch item modifications disregards MARC framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17999 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|batch item modifications |batch item modifications |does disregard MARC |disregards MARC framework |framework | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:19:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:19:12 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #8 from Alex Sassmannshausen --- (In reply to Bob Birchall from comment #7) > (In reply to Alex Sassmannshausen from comment #6) > > Hello, > > > > PTFS Europe is working on ILL functionality within Koha. See the URL above > > for a link to the RFC. > > > > Best wishes, > > > > Alex > > Is there any update here? Hi Bob, We are currently investing time into this again. We are hoping to provide code to this bug number by next Friday. Best wishes, Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:39:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:39:09 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #9 from Alex Arnaud --- Created attachment 59566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59566&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:43:14 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #10 from Alex Arnaud --- Created attachment 59567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59567&action=edit Bug 16881 - Apply KohaTable and ColVis plugin on MARCdetail's items table Also, the columns displayed are saved for each users in database. Test plan: - apply this BZ, - launch perl installer/data/mysql/updatedatabase.pl - launch perl misc/devel/update_dbix_class_files.pl - go to the items tab on cgi-bin/koha/catalogue/MARCdetail.pl page you should be able to hide/show each columns. - leave this page and come back with the same koha account: You should have the same columns shown/hidden as when you left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:44:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:44:10 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59566|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:44:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:44:25 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53510|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 10:55:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 09:55:21 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Alex Arnaud --- Here is a replacement patch. Code is more generic, svc script is replaced with a new REST api method and UsersColumnsSetting has its Koha objects. I change the javascript code to make other tables can use this feature with few changes. It could have been more usable but this means i should have to modify the KohaTable call for all these tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:01:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:01:02 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:01:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:01:05 +0000 Subject: [Koha-bugs] [Bug 17895] Small typo -'re-set' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59389|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 59568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59568&action=edit Bug 17895: 'Re-set' typo fix To test: 1) Log into OPAC and go to change your password 2) Enter current password incorrectly and click Submit changes 3) Observe error message and typo 're-set' 4) Apply patch and refresh page 5) May be asked to resend data - if so, click Resend, if not, repeat step 2 6) Observe error message and corrected spelling of 'reset' Sponsored-by: Catalyst IT Signed-off-by: Caitlin Goodger Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:01:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:01:08 +0000 Subject: [Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881 --- Comment #12 from Alex Arnaud --- (In reply to Nick Clemens from comment #8) > I really like this feature and agree with Cait, the ability for users to > save their settings will make workflows easier for librarians > > I agree with Jonathan too, this feature should be made usable for other > pages too, even if it is only introduced here first. > > 1 - C4/Utils/DataTables/DynamicColumnsSettings.pm - sub > catalogue_marcdetail_itemst > This should be more generic, the work should be done in a function that can > be passed data from any page I don't know how to make it more generic. It return all item fields depending on a framwork code... > > 2 - The script should be moved ot a javascript files for inclusion when > necessary, and can then be triggered by code on each page. > > 3 -The current code calls the service function each time the table is > rendered, so a sort will also make a call, this should only happen when > column view changes What do you mean by service function ? If you speak about the saveStateCallback, it is called only when a "column button" is clicked. > > 4 - Ideally when a user restores all columns we shouldn't need to save their > data, maybe we only store columns that are exceptions? There is no option for restoring all columns for now. > > 5 - This should use the REST api and not an svc script > > 6 - $schema->resultset('UsersColumnsSetting')->update_or_create > This should use Koha::Object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:22:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:22:08 +0000 Subject: [Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:22:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:22:11 +0000 Subject: [Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59471|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59569&action=edit Bug 17972 - Reformat acquisitions sidebar menu with acquisitions and administration sections This patch makes changes to acquisitions-menu.inc so that the style matches that of the Administration and Tools sidebar menus. The links are now divided up between Acquisitions (/acqui/) and Administration (/admin/). The link-highlighting JavaScript used elsewhere has been added. To test, apply the patch and view the Acquisitions home page. - Check that the "Acquisitions home" link is highlighted (bold). - Test the other Acquisitions links to confirm that highlighting works. - Click any link in the Administration section of the sidebar menu. - Confirm that everything looks correct and works correctly. Signed-off-by: Aleisha Amohia Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:26:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:26:04 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:26:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:26:08 +0000 Subject: [Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59479|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 59570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59570&action=edit Bug 17947: Searching my library first shows the branchcode by the search bar rather than branchname Test Plan 1: Turn on SearchMyLibraryFirst and go into OPAC 2: It should say Search (in Only) 3: Apply patch and refresh page. It should now say Search (in only) Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:29:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:29:42 +0000 Subject: [Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:29:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:29:46 +0000 Subject: [Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59489|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59571&action=edit Bug 17977: Add acquisitions sidebar menu to suggestions To test: 1) Go to Acquisitions -> Suggestions 2) Notice no acquisitions sidebar 3) Apply patch and refresh page 4) Sidebar menu should now show. Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:32:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:32:03 +0000 Subject: [Koha-bugs] [Bug 17840] Add classes to internal and public notes in checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17840 --- Comment #9 from Jonathan Druart --- But now the circ-hlt class name are removed. No idea if we must keep it or not. Any opinions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:41:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:41:48 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12478 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #28 from Jonathan Druart --- It seems that this has been introduced by bug 12478. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 [Bug 12478] Elasticsearch support for Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:41:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:41:48 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 [Bug 17134] Facet's area shows itemtypes' code instead of item's description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:44:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:44:01 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:44:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:44:06 +0000 Subject: [Koha-bugs] [Bug 17134] Facet's area shows itemtypes' code instead of item' s description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17134 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59504|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 59572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59572&action=edit Bug 17134: Replace item types codes with category in facets (opac) To test: -Search in OPAC for two or more items -Note that item types display category codes rather than names -Make change to file and test in OPAC Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:49:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:49:15 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:49:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:49:43 +0000 Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a preference to stay open all the time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I do not think this option should be controlled by a syspref. It would better to let it open if the user open it, don't you think? To do that we could use a cookie to store user's preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 11:50:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 10:50:10 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:27:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:27:19 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #12 from Jonathan Druart --- Created attachment 59573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59573&action=edit Bug 17782: Try to fix tests Previous code was wrong, $retrieved_patron->{updated_on} is always undef, $retrieved_patron is a Koha::Object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:34:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:34:15 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #32 from Alex Arnaud --- (In reply to Hugo Agud from comment #31) > I have tested the patch and it works fine! > > I am not able to generate the signed patch, sorry Is it a technical problem or you know how to signoff ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:35:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:35:52 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Kyle, could you move the "$calendar" fix to its own bug? That sounds like a major bug as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:39:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:39:06 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #33 from Hugo Agud --- I am still learning to create sign-off patch with kohadevbox, I have pending a trainning ;) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:45:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:45:09 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59379|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 59574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59574&action=edit Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:46:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:46:00 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:46:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:46:06 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59574|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 59575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59575&action=edit Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:46:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:46:11 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #8 from Jonathan Druart --- Created attachment 59576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59576&action=edit Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:46:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:46:34 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- I'd like to get a signoff on the second patch. Is the display better? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:54:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:54:08 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:54:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:54:12 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59373|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 59577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59577&action=edit Bug 17922: Use correct number of digits when replacing date placeholders This patch also fixes a typo ("<<" should be "<>") Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 12:55:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 11:55:46 +0000 Subject: [Koha-bugs] [Bug 17922] Default value substitution for month and day should be fixed length In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Ouch, my bad. Would be great to get this stuff moved to a module and provide tests. But this patch definitely fixes issues and should be pushed and backported ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:36:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:36:44 +0000 Subject: [Koha-bugs] [Bug 17405] Edit record uses Default framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17405 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:39:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:39:11 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 Serhij Dubyk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58490|0 |1 is obsolete| | --- Comment #2 from Serhij Dubyk --- Created attachment 59578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59578&action=edit New version of patch (git format-patch) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:39:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:39:40 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Lucy Vaux-Harvey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey at ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:42:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:42:24 +0000 Subject: [Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Jonathan Druart --- I cannot recreate either. Marked as duplicate of bug 17817. *** This bug has been marked as a duplicate of bug 17817 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:42:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:42:24 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #30 from Jonathan Druart --- *** Bug 17818 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:43:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:43:36 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:44:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:44:07 +0000 Subject: [Koha-bugs] [Bug 17812] Return focus to barcode field after toggling on-site checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:45:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:45:21 +0000 Subject: [Koha-bugs] [Bug 17952] Lost items not skipped by overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:45:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:45:46 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:47:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:47:44 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:47:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:47:47 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59485|0 |1 is obsolete| | Attachment #59486|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 59579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59579&action=edit Bug 17935: Adjust some POD lines, fix a few typos This patch does the following: [1] Move some POD lines from Cache to Caches. [2] Correct C4::Plugins to Koha::Plugins in POD line of Koha::Plugins [3] POD Koha/AuthorisedValue.pm: lib_opac moved to opac_description [4] The POD in Koha/Patron.pm uses head2 and head3 inconsistently. Ran s/^=head2/=head3/ on those lines (7 substitutions on 7 lines) [5] Correct a copied POD line from reports/issues_stats.pl in reports/reserve_stats.pl. [6] Correct a test description in t/db_dependent/Koha/Authorities.t. You should never delete the library :) [7] Correct typo shouild in a comment of rebuild_zebra.pl Test plan: [1] Read the patch. Does it make sense? [2] Run perldoc Koha/Cache.pm and Koha/Caches.pm [3] Run t/db_dependent/Koha/Authorities.t Signed-off-by: Marcel de Rooy Signed-off-by: David Cook Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:47:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:47:51 +0000 Subject: [Koha-bugs] [Bug 17935] Adjust some POD lines, fix a few typos In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17935 --- Comment #9 from Jonathan Druart --- Created attachment 59580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59580&action=edit Bug 17935: Follow up for C4::Plugin... TEST PLAN --------- -- apply first patch git grep "C4::Plugin" -- still two references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- apply this patch git grep "C4::Plugin" -- no references perldoc Koha::Plugins::Base perldoc Koha::Plugins::Handler -- should look fixed Please enter the commit message for your changes. Lines starting Signed-off-by: David Cook Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:50:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:50:39 +0000 Subject: [Koha-bugs] [Bug 17948] Link to make a new list in masthead in OPAC does not take you straight to add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:50:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:50:43 +0000 Subject: [Koha-bugs] [Bug 17948] Link to make a new list in masthead in OPAC does not take you straight to add form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59296|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59581&action=edit Bug 17948 Link to make a new list in masthead in OPAC does not take you straight to add form Test Form 1: Go to OPAC and click on add new list. 2: It takes you to Your Lists and not straight to add a new list 3: Apply patch 4: Refresh and when you click on new list it should take you straight to add a new list Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:56:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:56:23 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 --- Comment #3 from Serhij Dubyk --- Before this patch in file en-GB-marc-MARC21.po present next paragraph: #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by " According string "by " in the file MARC21slim2intranetResults.xsl can not be translated (in other languages). After applying this patch performed the following command: cd /usr/share/koha/misc/translator sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update Now in the file en-GB-marc-MARC21.po present the following (modified) paragraph: #: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:348 #: /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457 #, fuzzy, c-format msgid "by " msgstr " by " And the string " by " becomes available for translation in uk-UA/xslt/MARC21slim2intranetResults.xsl (and other language versions) This can be checked the command sudo koha-translate --update uk-UA In the file uk-UA/xslt/MARC21slim2intranetResults.xsl string 'by

    ' is now translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:58:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:58:09 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:58:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:58:13 +0000 Subject: [Koha-bugs] [Bug 17838] Availability limit broken until an item has been checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59133|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59582&action=edit Bug 17838 Availability limit broken until an item has been checked out. TEST PLAN 1. Make sure you have no items checked out. 2. Run sudo koha-rebuild-zebra -f -v kohadev. 3. Go to search the catalog and search. 4. Check items availability and then click on limit to currently available items. 5. This should return no results. 6. Apply patch and reload. 7. Results should show. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Attribute 14: " Specifies whether un-indexed fields should be ignored. A zero value (default) throws a diagnostic when an un-indexed field is specified. A non-zero value makes it return 0 hits." >From http://www.indexdata.com/zebra/doc/querymodel-zebra.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 13:59:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 12:59:41 +0000 Subject: [Koha-bugs] [Bug 17821] due date in intranet search results should use TT date plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:02:46 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #65 from Jonathan Druart --- Please use column_exists in the update DB entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:04:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:04:07 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #66 from Jonathan Druart --- (In reply to Jonathan Druart from comment #65) > Please use column_exists in the update DB entry. Done later, sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:04:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:04:37 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #67 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #65) > Please use column_exists in the update DB entry. Last patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:18:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:18:14 +0000 Subject: [Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827 --- Comment #4 from Serhij Dubyk --- (In reply to Katrin Fischer from comment #1) > Hi Serhij, can you please try to make a valid git patch file? > You can use the git format-patch command or tCan you detail the problem a > bit more? I am not sure why the mapping should be a problem.he git bz tool > described in our wiki. > Maybe the by should still be wrapped in a class? That way we could hide the > whole line still without the by remaining. 'by' not wrapped in class also in MARC21slim2OPACResults.xsl http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl;h=7349b816a61a7a4e712e2531d4d5b36ccb3b1b75;hb=refs/heads/master#l459 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:23:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:23:36 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #68 from Jonathan Druart --- I was expecting to find some calls to Koha::Object::Limit::Library->library_limits in this patchset, but I actually do not see any. Is it unused code or I missed a bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:26:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:26:32 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #17 from M. Tompsett --- (In reply to Jonathan Druart from comment #16) > So we are going to loose the 'check in' and 'renew' actions from the header > search and the syspref search will become the default one. > > Does everybody agree with that? When you are in the admin section, that makes more sense. So yes, I agree with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:27:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:27:38 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #13 from Kyle M Hall --- Created attachment 59583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59583&action=edit Bug 17782 - Allow discard_changes to work for Deletedborrower class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:31:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:31:36 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 --- Comment #69 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #68) > I was expecting to find some calls to > Koha::Object::Limit::Library->library_limits in this patchset, but I > actually do not see any. > Is it unused code or I missed a bug report? It is unused code. The idea was to introduce the new code and then migrate page by page to using the new class. On separate bug reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 14:56:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 13:56:19 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 angelo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angelosebastiao at gmail.com --- Comment #31 from angelo --- In the same bug there is another problem. When we try to add an authority in field 701 702, that is, where a field with authorized value exists, it does not add the authority that exists, it creates another authority id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 15:36:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 14:36:42 +0000 Subject: [Koha-bugs] [Bug 18000] New: Add --tablename option to misc/devel/ update_dbix_class_files.pl script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Bug ID: 18000 Summary: Add --tablename option to misc/devel/update_dbix_class_files.pl script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Developers, Don't you think it's quite disturbing to see that all Koha schema files appear as modified in your git status when you ran update_dbix_class_files.pl script to get the one related to the table you've just created ? If yes, here is a patch that add the ability to specify a table name to this script, so test and sign. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 15:37:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 14:37:42 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 --- Comment #1 from Alex Arnaud --- Created attachment 59584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59584&action=edit Bug 18000 - Add --tablename option to misc/devel/update_dbix_class_files.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 15:39:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 14:39:25 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59584|0 |1 is obsolete| | --- Comment #2 from Alex Arnaud --- Created attachment 59585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59585&action=edit Bug 18000 - Add --tablename option to misc/devel/update_dbix_class_files.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 15:40:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 14:40:19 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 15:57:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 14:57:11 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |alex.arnaud at biblibre.com QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 16:29:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 15:29:38 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #36 from Mehdi Hamidi --- (In reply to J Schmidt from comment #35) Hello Jenny, I just went on By water solutions sandbox to test the bug, there seems to be a problem with the datepicker. The reason you'are getting this error : >The 'month' parameter ("30") to DateTime::new did not pass the 'an integer >between 1 and 12' callback at /usr/local/lib/perl/5.14.2/DateTime.pm line 197. >DateTime::new(undef, "hour", 0, "minute", 0, "second", 0, "month", 30, ...) >called at /var/lib/koha/sandbox1/kohaclone/Koha/DateUtils.pm line 172 > Koha::DateUtils::dt_from_string("04/30/2017") called at >/var/lib/koha/sandbox1/kohaclone/tools/discrete_calendar.pl line 94 > main::edit_holiday() called at >/var/lib/koha/sandbox1/kohaclone/tools/discrete_calendar.pl line 60 It's because the date format is not correct, it is set to dd/mm/yyyy in the settings, so you get an error saying the month can't be 30 when the date entered is : 04/30/2017. I'm working on to find why the datepickers are not showing on the sandbox, because they are working correctly on local installations. Also, for weekly holidays, they are only for single day, so the to date will be ignored. Thank you again for testing! Mehdi Hamidi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 16:50:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 15:50:26 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #37 from Mehdi Hamidi --- Created attachment 59586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59586&action=edit Bug 17015 - sandbox fixe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 17:55:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 16:55:55 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 --- Comment #6 from Alexandre --- Thanks everyone, we appreciate it. I will inform the other users here. Alexandre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 17:56:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 16:56:46 +0000 Subject: [Koha-bugs] [Bug 17784] Ability to see funds with an amount of 0.00 when doing a new order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17784 --- Comment #7 from Alexandre --- Thanks everyone, we appreciate it. I will inform the other users here. Alexandre -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 18:17:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 17:17:09 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59562|0 |1 is obsolete| | Attachment #59586|0 |1 is obsolete| | --- Comment #38 from Mehdi Hamidi --- Created attachment 59587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59587&action=edit Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 18:29:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 17:29:46 +0000 Subject: [Koha-bugs] [Bug 18001] New: LocalHoldsPriority can cause multiple holds queue lines for same hold request Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 Bug ID: 18001 Summary: LocalHoldsPriority can cause multiple holds queue lines for same hold request Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 20:05:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 19:05:21 +0000 Subject: [Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 --- Comment #1 from Kyle M Hall --- Created attachment 59588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59588&action=edit Bug 18001 - LocalHoldsPriority can cause multiple holds queue lines for same hold request If LocalHoldsPriority is enabled, and a record level request has more than one item that could fill that hold, there is a possibility that a holds queue row will be generated for the request for each of the available items! Signed-off-by: Kyle M Hall Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 20:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 19:05:18 +0000 Subject: [Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 20:23:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 19:23:29 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #10 from Alex Buckley --- Created attachment 59589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59589&action=edit Bug 17334 - Second update following QA feedback This commit contains the following changes: 1. Implemented the use of KohaDates TT plugin to format the date correctly 2. Removed the use of the temporary timestamp variable 3. Changed the date text to: patron's info - Requested on Datetime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 20:24:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 19:24:34 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #39 from Mehdi Hamidi --- Hello Jenny, I found the reason why you were getting the error. There seems to be a problem with the sandbox that prevents the datepicker from showing the correct date format which is selected in the system preferences and this makes the calendar unusable. If you wish to proceed on testing, you will have to change the system preference dateformat to mm/dd/yyyy, it seems like it's the only option that works for now. Mehdi Hamidi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 20:28:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 19:28:49 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #11 from Alex Buckley --- (in reply to Jonathan Druart) Sorry I realised you have made all of the neccisary changes and so to remove my second patch ( Bug 17334 - Second update following QA feedback) can I just set it to obsolete? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 20:33:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 19:33:09 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #12 from Alex Buckley --- I am still learning bugzilla and didn't realise your patch contained the necessary changes. so sorry about that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 21:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 20:11:51 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at ccsr.qc | |.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 21:11:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 20:11:57 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 21:42:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 20:42:57 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59589|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 21:48:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 20:48:46 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #40 from J Schmidt --- Went into ByWater sandbox on 1/26/17. Steps taken: 1.) Went to Koha Admin > modified the dateFormat preference (I18N/L10N) from dd/mm/yyyy to mm/dd/yyyy. Saved. 2.) Went to Tools > Discrete Calendar 3.) Select January 6, 2017. Dialog box for "add new holiday" appears. 4.) Initial date is Friday 1/6/2017. Filled in To date to be 02/17/2017; Title was laptop loaning office hours. Date type: weekly; open hours stayed at 09:00:00; Close hours set to 19:30:00. Kept Edit selected dates and Save. 5.) Weekly repeatable holiday is added to the Calendar page display as it normally would. From that line item on the side there is no hours/times listed (just an fyi). 6.) Did another entry into the future but that did not take. It did not, however, generate an error so that's good. 7.) I did another entry of a past date (Jan 16th, Monday as a weekly repeatable holiday). I entered in the times using minutes as well and then selected Copy calendar to another branch. Betatown. I saved. I did not receive an error. It doesn't appear under the Betatown calendar listings however. I did that again. It still doesn't appear under Betatown's calendar listings... but no error. The defining a calendar listing in the past, with hours seems to work. Transferring to another branch does not... Not sure what to put as the status but it's partially working so kudos for that. jenny~ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 22:24:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 21:24:12 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org Status|Needs Signoff |Signed Off --- Comment #21 from J Schmidt --- Worked in sandbox ByWater on 1/26/17 (Chrome): Steps taken: 1.) Searched in the staff client to locate a biblio record. 2.) Clicked on Edit record (to edit biblio) 3.) Defaults to the basic editor. 4.) I click on indicators next to several MARC fields (243, 250, 710), I was able to edit and delete both the first and/or second indicators and successfully save without error. I was able to see the edits/changes. 5.) Went back into edit biblio screen. Still in basic editing mode. I went into 245 field and noticed subfields can click on. I choose 245$h and changed that to a comma and was able to save it. This means there is no validation on retaining correct subfields but perhaps that can be set in the framework itself. 6.) Clicking on the ? next to a MARC field correctly takes user to the MARC 21 format web page. (Works as should). 7.) Went to 100 field, entered in subfield a and then clicked on the icon to perform authority search to locate a personal name authority to link to subfield 9. Successfully got authority search dialog box to open up and perform searches. 8.) Located a personal name authority Campbell-Smith, Duncan. Chose it. 9.) 100$9 now populated with the authority record number and correct $a personal name. Saved without error. 10.) Went into Koha admin > Labs, changed the preference to enable the advanced cataloging editor. Save. 11.) Went back into Edit biblio. Changed to Advanced editor. 12.) Went into MARC 500 to edit indicators. I could edit and see numbers. Success. I had to tread carefully not to overwrite the field data itself. Upon save the advanced editor validates and tells you which tags are mandatory... Much improved. 13.) I put in bad indicators for the 300 field and it gave me invalid. Good. I had to do underline for blank which was not intuitive but me typing those in manually worked and the editor was able to detect error of incorrect indicator so far as I could tell. 14.) 003 is not familiar to me so I entered in DDC and Record saved successfully. 15.) Went to 650 to try and add in CTRL+D 9 for authority record number...but no way to access authority search dialog box from this screen. I would say this is working well. The advanced editor still needs to allow macros that stick overtime and are tied to login so as not to lose them. Keyboard shortcuts or macros needed for fixed fields such as 007, 008, 006 especially. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 26 22:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 21:26:24 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:07:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:07:47 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- After looking through the master code a bit, it seems like we never actually use this form in anything but tests: $modules->version_info('module'=>"DBI"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:11:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:11:24 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 --- Comment #12 from David Cook --- (In reply to Jonathan Druart from comment #11) > (In reply to Jonathan Druart from comment #9) > > Ok, I am rewriting it, will move that to another bug report. > > See bug 17990. You're a champ, Jonathan! I have another two reports* that looks at fixing issues with this code, so cheers for rewriting it overall. *bug 17882 *bug 17887 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:17:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:17:54 +0000 Subject: [Koha-bugs] [Bug 17882] C4::Installer::PerlModules::version_info() drops data during error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17882 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #8 from David Cook --- *** This bug has been marked as a duplicate of bug 17990 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:17:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:17:54 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 --- Comment #3 from David Cook --- *** Bug 17882 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:18:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:18:29 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 --- Comment #4 from David Cook --- *** Bug 17887 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:18:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:18:29 +0000 Subject: [Koha-bugs] [Bug 17887] Dependency usage doesn' t show for upgrades or installed modules using version_info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17887 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 17990 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:20:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:20:37 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:20:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:20:40 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59546|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 59590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59590&action=edit Bug 17990: Refactor Perl module versions check The code is duplicated, variable are not set ($_), code is hard to read, not covered by tests and the subroutine has 2 completely different behaviors depending on the presence of the "module" parameter. No need more ti rewrite it. Test plan: - Use koha_perl_deps.pl with the different options (-u -m -a -i) - Go on the about page, "Perl modules" tab You should not see any differences from before and after this patch Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 00:21:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 26 Jan 2017 23:21:36 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 --- Comment #6 from David Cook --- I also ran the following tests and they all passed. perl t/Installer_PerlModules.t perl t/Installer_pm.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 01:12:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 00:12:50 +0000 Subject: [Koha-bugs] [Bug 18002] New: Add functionality to create a vendor and budget in the onboarding tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Bug ID: 18002 Summary: Add functionality to create a vendor and budget in the onboarding tool Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 17855 Add two additional interfaces to the onboarding tool to allow the user to create a vendor and budget before logging into Koha for the first time, thereby allowing users to get acquisition requirements set up. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 01:12:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 00:12:50 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 01:12:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 00:12:50 +0000 Subject: [Koha-bugs] [Bug 17956] Provide additional functionality in the onboarding tool through configuring z-targets , and providing information on setting up SIP and LDAP services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17956 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18002 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:35:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:35:41 +0000 Subject: [Koha-bugs] [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #17 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:36:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:36:44 +0000 Subject: [Koha-bugs] [Bug 14637] Add patron category fails with MySQL 5.6.26 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14637 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:38:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:38:48 +0000 Subject: [Koha-bugs] [Bug 17742] Test t/db_dependent/Patrons.t can fail randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17742 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:39:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:39:59 +0000 Subject: [Koha-bugs] [Bug 17781] Improper branchcode set during renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:41:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:41:05 +0000 Subject: [Koha-bugs] [Bug 17785] oai.pl returns wrong URLs under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:41:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:41:53 +0000 Subject: [Koha-bugs] [Bug 15711] Deleting patroncard images has unexpected behaviour and is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15711 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:49:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:49:24 +0000 Subject: [Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #63 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 03:50:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 02:50:01 +0000 Subject: [Koha-bugs] [Bug 17265] Make koha-create and koha-dump-defaults less greedy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17265 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:03:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:03:15 +0000 Subject: [Koha-bugs] [Bug 17778] Make "Earliest Registered Date" in OAI-PMH dynamic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17778 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:04:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:04:16 +0000 Subject: [Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:05:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:05:00 +0000 Subject: [Koha-bugs] [Bug 17879] Possible to upload images with no image name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17879 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:06:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:06:09 +0000 Subject: [Koha-bugs] [Bug 17914] The installer process tries to create borrowers.updated_on twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17914 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:06:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:06:48 +0000 Subject: [Koha-bugs] [Bug 17777] koha-remove should deal with temporary uploads In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17777 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:09:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:09:24 +0000 Subject: [Koha-bugs] [Bug 17924] Fix error in password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17924 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:09:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:09:56 +0000 Subject: [Koha-bugs] [Bug 17931] Remove unused vars from reserves_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17931 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:10:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:10:20 +0000 Subject: [Koha-bugs] [Bug 15460] Bug 13381 accidentally removed spaces after subfields c and h of 245 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15460 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:11:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:11:06 +0000 Subject: [Koha-bugs] [Bug 17469] fr-CA web installer is missing some sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17469 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #34 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:16:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:16:13 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #34 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:16:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:16:54 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #43 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:17:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:17:50 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:17:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:17:53 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 --- Comment #1 from Aleisha Amohia --- Created attachment 59591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59591&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category code from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=17897 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:18:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:18:03 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:21:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:21:28 +0000 Subject: [Koha-bugs] [Bug 11536] patron self registration fails when PatronSelfRegistrationDefaultCategory is set to nonexistent borrower category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11536 --- Comment #3 from Aleisha Amohia --- I have added a patch to bug 17987 to make this syspref a dropdown menu selection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:21:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:21:39 +0000 Subject: [Koha-bugs] [Bug 11536] patron self registration fails when PatronSelfRegistrationDefaultCategory is set to nonexistent borrower category code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11536 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17987 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:21:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:21:39 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11536 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:22:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:22:40 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59591|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 59592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59592&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category code from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:22:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:22:43 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #21 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:46:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:46:28 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #22 from Mason James --- (In reply to Mason James from comment #21) > Pushed to 16.05.x, for 16.05.08 release Blocked by BZ-17986, skipping for 16.05.08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:46:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:46:51 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:46:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:46:55 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #1 from Aleisha Amohia --- Created attachment 59593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59593&action=edit Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, SelfCheckTimeout, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin, Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:47:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:47:06 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |aleishaamohia at hotmail.com CC| |aleishaamohia at hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:47:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:47:13 +0000 Subject: [Koha-bugs] [Bug 17909] Add unit tests for authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #30 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:47:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:47:33 +0000 Subject: [Koha-bugs] [Bug 17808] When editing circulation conditions, only ask for confirmation when there is already a rule selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17808 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:48:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:48:37 +0000 Subject: [Koha-bugs] [Bug 17920] t/db_dependent/Sitemapper.t fails because of permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17920 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 04:49:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 03:49:46 +0000 Subject: [Koha-bugs] [Bug 17899] Show only mine does not work in newordersuggestion.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 08:50:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 07:50:15 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:18:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:18:12 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:18:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:18:15 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59590|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 59601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59601&action=edit Bug 17990: Refactor Perl module versions check The code is duplicated, variable are not set ($_), code is hard to read, not covered by tests and the subroutine has 2 completely different behaviors depending on the presence of the "module" parameter. No need more ti rewrite it. Test plan: - Use koha_perl_deps.pl with the different options (-u -m -a -i) - Go on the about page, "Perl modules" tab You should not see any differences from before and after this patch Signed-off-by: David Cook Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:18:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:18:39 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 --- Comment #8 from Marcel de Rooy --- Good job, Jonathan. ok( $dbi_is_missing || $dbi_is_upgrade || $dbi_is_current, 'DBI should either be missing, upgrade or current' ); So now we are safe :) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:25:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:25:07 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:25:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:25:10 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59484|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 59602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59602&action=edit Bug 17968: Remove useless variable $item_format in C4::Overdues::parse_overdues_letter The variable $item_format is not used and should be removed from this subroutine. Moreover it the letter parameter, but it is never sent to this subroutine. letter_code is expected instead. Test plan: No test plan, just read the code and `git grep ` Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:25:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:25:21 +0000 Subject: [Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:47:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:47:30 +0000 Subject: [Koha-bugs] [Bug 17990] Code to check perl module versions is buggy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990 --- Comment #9 from Jonathan Druart --- Heh yes this test looks a bit silly, but it was to make sure the returned structure was still correct. To make it pass in every situation I needed to test all of them :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 09:53:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 08:53:56 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #18 from Marcel de Rooy --- I think it is somewhat arbitrary choice. If you leave checkout, I would have preferred to leave checkin too e.g. But the syspref search is handy. So I do not disagree :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:06:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:06:00 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #32 from Jonathan Druart --- (In reply to angelo from comment #31) > In the same bug there is another problem. When we try to add an authority in > field 701 702, that is, where a field with authorized value exists, it does > not add the authority that exists, it creates another authority id. Please open a new bug report, it's a completely different problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:06:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:06:14 +0000 Subject: [Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817 --- Comment #33 from Jonathan Druart --- s/?// -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:06:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:06:48 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy --- (In reply to Hugo Agud from comment #3) > I have checked that all those fields are now indexed and this bugs it is > signed off BUT under my undestading this opens a new bug regarding the > authorities > > For example 650 SUBJECT ADDED ENTRY--TOPICAL TERM and 690 - LOCAL SUBJECT > ADDED ENTRY--TOPICAL TERM (OCLC, RLIN) POINTS TO the same authority base > --> TOPIC_TERM > > Under my understanding Koha should have new authority for cocver 690, 691, > 692...If I am not wrong, If we don't add new authotiries, the official and > local authorities will be the at the TOPIC_TERM and it is little weird > > What do you think? I do not have a strong opinion on that; you could open a new report and invite other people to give feedback too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:11:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:11:23 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 --- Comment #6 from Marcel de Rooy --- Tomas: Why do we have 691 but not 791 (there is 751) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:13:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:13:22 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 --- Comment #7 from Marcel de Rooy --- Adding a signoff line too for Hugo Agud (check bug history) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:14:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:14:03 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:14:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:14:06 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58267|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 59604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59604&action=edit Bug 17788: (MARC21) Add $9 fields to Koha-Auth-Number:w index Looking at the default framework's fields that are linked to authority records, there's a divergence with the Zebra index definitions. This yields to authority usage count be incorrect for users searching for authority records. MariaDB [koha_kohadev]> SELECT tagfield,tagsubfield,authtypecode FROM marc_subfield_structure WHERE authtypecode IS NOT NULL AND authtypecode<>'' AND frameworkcode='' GROUP BY tagfield,tagsubfield,authtypecode ; +----------+-------------+--------------+ | tagfield | tagsubfield | authtypecode | +----------+-------------+--------------+ | 100 | a | PERSO_NAME | | 110 | a | CORPO_NAME | | 111 | a | MEETI_NAME | | 130 | a | UNIF_TITLE | | 440 | a | UNIF_TITLE | | 600 | a | PERSO_NAME | | 610 | a | CORPO_NAME | | 611 | a | MEETI_NAME | | 630 | a | UNIF_TITLE | | 648 | a | CHRON_TERM | | 650 | a | TOPIC_TERM | | 651 | a | GEOGR_NAME | | 654 | a | TOPIC_TERM | | 655 | a | GENRE/FORM | | 656 | a | TOPIC_TERM | | 657 | a | TOPIC_TERM | | 658 | a | TOPIC_TERM | | 662 | a | GEOGR_NAME | | 690 | a | TOPIC_TERM | | 691 | a | GEOGR_NAME | | 696 | a | PERSO_NAME | | 697 | a | CORPO_NAME | | 698 | a | MEETI_NAME | | 699 | a | UNIF_TITLE | | 700 | a | PERSO_NAME | | 710 | a | CORPO_NAME | | 711 | a | MEETI_NAME | | 730 | a | UNIF_TITLE | | 796 | a | PERSO_NAME | | 797 | a | CORPO_NAME | | 798 | a | MEETI_NAME | | 799 | a | UNIF_TITLE | | 800 | a | PERSO_NAME | | 810 | a | CORPO_NAME | | 811 | a | MEETI_NAME | | 830 | a | UNIF_TITLE | | 896 | a | PERSO_NAME | | 897 | a | CORPO_NAME | | 898 | a | MEETI_NAME | | 899 | a | UNIF_TITLE | +----------+-------------+--------------+ This patch adds the missing ones to the authority number index as it is done for the rest of the fields. To test: - Verify that etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml contains intries pointing the $9 subfield of all the fields in the 'tagfield' column above, to the Koha-Auth-Number:w index. - Sign off :-D Signed-off-by: Hugo Agud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:14:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:14:23 +0000 Subject: [Koha-bugs] [Bug 17788] (MARC21) $9 fields not indexed in authority-linked fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17788 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:15:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:15:32 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:15:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:15:39 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58913|0 |1 is obsolete| | Attachment #59558|0 |1 is obsolete| | Attachment #59573|0 |1 is obsolete| | Attachment #59583|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 59605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59605&action=edit Bug 17782 - Patron updated_on field should be set to current timestamp when borrower is deleted To test: 01 Find a patron 02 Get the updated_on value from the db in borrowers table 03 Delete the patron 04 Get the update_on value from the db on deletedborrowers table 05 Values from 02 and 04 are the same 06 Apply patch 07 Repeat 01-04 08 Values should now be different Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:15:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:15:45 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #15 from Jonathan Druart --- Created attachment 59606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59606&action=edit Bug 17782 - (QA Followup) Fix tests prove t/db_dependent/Koha/Patrons.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:15:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:15:50 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #16 from Jonathan Druart --- Created attachment 59607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59607&action=edit Bug 17782: Fix tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:20:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:20:20 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #19 from Josef Moravec --- Hm, what about syspref|checkout|checkin|catsearch combination? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:26:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:26:03 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #17 from Jonathan Druart --- Let's deal with deletedborrowers.borrowernumber as a PK on another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:27:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:27:40 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:27:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:27:46 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58407|0 |1 is obsolete| | Attachment #59507|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 59608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59608&action=edit Bug 17793: Make sysprefs search show on all Admin pages This patch is amended to use the sysprefs search on all Administration pages that do not have their own custom search. To test: 1) Go to Administration 2) Notice Catalogue search at the top - seems out of place. 3) Apply patch and refresh page. 4) Notice admin / sysprefs search now shows and is more appropriate. 5) Confirm searching for sysprefs still works This patch affects the following pages: - admin-home.pl - audio_alerts.pl - authtypes.pl - auth_tag_structure.pl - authorised_values.pl - biblio_framework.pl - marctagstructure.pl - branch_transfer_limits.pl - branches.pl - checkmarc.pl - classsources.pl - columns_settings.pl - didyoumean.pl - edi_accounts.pl - edi_ean_accounts.pl - fieldmapping.pl - item_circulation_alerts.pl - items_search_fields.pl - items_search_field.pl - item_types.pl - koha2marklinks.pl - matching-rules.pl - oai_sets.pl - oai_set_mappings.pl - patron-attr-types.pl - smart-rules.pl - transport-cost-matrix.pl - sms_providers.pl Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:27:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:27:52 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #21 from Jonathan Druart --- Created attachment 59609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59609&action=edit Bug 17793: Follow up for identified missing changes I ran: $ git grep -l cat-search.inc | grep admin This means I believe the outstanding ones are (koha-tmpl/intranet-tmpl/prog/en/modules/): - admin/auth_subfields_structure.tt - admin/clone-rules.tt - admin/marc_subfields_structure.tt - admin/searchengine/elasticsearch/mappings.tt One other was recommended by Katrin in comment #9: - plugins/plugins-home.tt Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:29:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:29:03 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #22 from Jonathan Druart --- (In reply to Josef Moravec from comment #19) > Hm, what about > > syspref|checkout|checkin|catsearch combination? Oops, did not see your comment before passing QA. Anybody has opinions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:37:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:37:31 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:37:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:37:33 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58596|0 |1 is obsolete| | Attachment #58597|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 59610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59610&action=edit Bug 17846: Remove C4::Koha::get_infos_of This subroutine does not longer make any senses. The call to get_infos_of can be replaced with $dbh->selectall_hashref. The third argument of this subroutine was never used. Test plan (for developer only): Compare the 2 codes and confirm that they are equivalent Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:37:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:37:37 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 --- Comment #8 from Marcel de Rooy --- Created attachment 59611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59611&action=edit Bug 17846: Remove get_infos_of declaration The function which was removed was still being exported. This removes it completely. Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 10:37:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 09:37:51 +0000 Subject: [Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Version|unspecified |master CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:01:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:01:34 +0000 Subject: [Koha-bugs] [Bug 16694] Limit SIP2 auth by patron attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16694 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- Would be nice to validate this small change with a small test in e.g. t/db_dependent/SIP/Message.t We already have a test there for patron info. Should not be big deal :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:02:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:02:45 +0000 Subject: [Koha-bugs] [Bug 15566] Update API to allow to reserve first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy --- Blocked: this depends on a failed qa report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:39:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:39:33 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57173|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 59614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59614&action=edit Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:39:30 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:40:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:40:17 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:40:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:40:36 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 --- Comment #12 from Marcel de Rooy --- The fact that we should replace <> by [% branch.field %] is somewhat confusing ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:43:14 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:43:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:43:14 +0000 Subject: [Koha-bugs] [Bug 18003] New: Should deletedborrowers.borrowernumber be a primary key? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Bug ID: 18003 Summary: Should deletedborrowers.borrowernumber be a primary key? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 17782 (Raised from bug 17782) DBIC needs a primary key to work correctly. We could be tempt to make borrowernumber a primary key, but a use case could bring thing. Indeed if a table is empty and the mysql (mariadb behaves identically) server restarted, the Auto Increment (AI) is reset. Problematic use case: 1. Install Koha 2. Create a patron (borrowers.borrowernumber = 1) 3. Delete it (deletedborrowers.borrowernumer = 1, and AI is set to 2 4. Restart mysql => borrowers is empty so AI is reset 5. Create a patron (borrowers.borrowernumber = 1) 6. Delete it => We will try to insert a new row with an existing borrowernumber (1) into the deletedborrowers table: BOOM Solution 1: Do not care about this problematic use case and prevent to delete the last patron. Solution 2: Add a AI primary key (id) to deletedborrowers => The 2 tables borrowers and deletedborrowers will differ, bugs will be expected Solution 3: Deal with that at code level: when a patron is created, guess the borrowernumber it will get and check if it does not already exist in the deletedborrowers table. If so, force it before inserting it Solution 4: Do not enforce this constraint at DB level but set the primary key to DBIC schema: Koha::Schema::Result::Deletedborrower: __PACKAGE__->set_primary_key("borrowernumber"); Problem: Koha::Database->new->schema->resultset('Deletedborrower')->find(42); will raise a warning "DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single" if 42 is duplicated, and the first matching row will be picked Another solution? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:44:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:44:47 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:44:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:44:50 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 --- Comment #5 from Marcel de Rooy --- Created attachment 59615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59615&action=edit Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:45:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:45:03 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:45:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:45:20 +0000 Subject: [Koha-bugs] [Bug 17782] Patron updated_on field should be set to current timestamp when borrower is deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17782 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > Let's deal with deletedborrowers.borrowernumber as a PK on another bug > report. See bug 18003. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:46:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:46:30 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I think this is fixed in new version of DBIx::Class::Schema::Loader, I have 0.07042 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:49:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:49:16 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen at ptfs-e | |urope.com, | |fridolin.somers at biblibre.co | |m, | |julian.maurice at biblibre.com | |, katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:51:23 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 --- Comment #1 from Jonathan Druart --- Created attachment 59616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59616&action=edit Bug 18003: Example of why we would need a PK on deletedborrowers These tests do not pass: DBIx::Class::ResultSource::_pri_cols_or_die(): Operation requires a primary key to be declared on 'Deletedborrower' via set_primary_key at t/db_dependent/Koha/Patrons.t line 329 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:58:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:58:51 +0000 Subject: [Koha-bugs] [Bug 15282] Switch default CHECKIN notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 --- Comment #6 from Jonathan Druart --- I think that this patch should not be pushed before bug 17964. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 11:59:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 10:59:07 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 --- Comment #13 from Jonathan Druart --- I think that this patch should not be pushed before bug 17964. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 12:08:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 11:08:08 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #70 from Jonathan Druart --- Found a bug: If a attr is editable at the opac and the patron clear the field, it appears in the patron modifications to approve/deny. But if you approve it, it's not cleared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 12:13:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 11:13:17 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 12:36:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 11:36:45 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #37 from Jonathan Druart --- I do not manage to clear up my mind about the use of this plugin. I'd say it's the kind of feature that could be driven by a syspref. The quantity of code to wrap the plugin seems the same as the size of the plugin itself. It is also the kind of code we will not be able to know if it is used by someone in few years (what we do have with a syspref, cf Hea). I would like to see the C4::Reserves sub moved to a Koha::Hold method at least. Kyle, can we get your opinion on this one please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 12:37:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 11:37:01 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 12:39:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 11:39:02 +0000 Subject: [Koha-bugs] [Bug 18004] New: Koha don't add authority id that exist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004 Bug ID: 18004 Summary: Koha don't add authority id that exist Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: angelosebastiao at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When we try to add an authority in field 701 702, that is, where a field with authorized value exists, it does not add the authority that exists, it creates another authority id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 12:55:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 11:55:00 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 --- Comment #4 from Alex Arnaud --- (In reply to Jonathan Druart from comment #3) > I think this is fixed in new version of DBIx::Class::Schema::Loader, I have > 0.07042 Tested with version 0.07046 and it's better but i still got about thirty files modified. I keep thinking this feature could be nice to avoid that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 13:02:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 12:02:14 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 --- Comment #5 from Jonathan Druart --- It would be good to pass several tables. It seems that we can pass a regexp, so I tried: --tablename='*borro*' And got: \A* matches null string many times in regex; marked by <-- HERE in m/\A* <-- HERE borro*\z/ at misc/devel/update_dbix_class_files.pl line 59. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 13:02:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 12:02:22 +0000 Subject: [Koha-bugs] [Bug 18000] Add --tablename option to misc/devel/ update_dbix_class_files.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18000 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|alex.arnaud at biblibre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 13:30:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 12:30:19 +0000 Subject: [Koha-bugs] [Bug 18004] Koha don't add authority id that exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004 --- Comment #1 from Marcel de Rooy --- Please describe in more detail what you are doing exactly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 13:33:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 12:33:21 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #38 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #37) > I would like to see the C4::Reserves sub moved to a Koha::Hold method at > least. I would not block this for that reason; the change was already pending before Koha::Objects were invented :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 13:35:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 12:35:07 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 --- Comment #14 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #13) > I think that this patch should not be pushed before bug 17964. There is no direct connection? These patches do a simple change to the default notice that works and only depends on biblio and branch, not issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 13:48:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 12:48:29 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #39 from Kyle M Hall --- I'm really on the fence. I don't see anything wrong with extending the plugin functionality, but on the other hand, there is a *very* specific behavior. If it were an extension to control all the hold fields it would seem a bit less odd. Marcel, considering the small size of the patches, I don't think moving the sub to Koha::Hold is too big of an ask ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 13:59:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 12:59:39 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #41 from Mehdi Hamidi --- Hello Jenny, Went into ByWater sandbox on 1/27/17. - Adding an entry in the future worked for me, I added an exception and a fixed holiday and they were both added and their hours changed. - Copy calendar to an other branch will take the current state of the calendar and copy it to another. Holidays that there were not saved will not be copied. So you will have to save your changes, and then, copy calendar. I tested it and it copied the Alphaville to Betatown. Mehdi Hamidi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:09:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:09:08 +0000 Subject: [Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793 --- Comment #23 from M. Tompsett --- (In reply to Jonathan Druart from comment #22) > Oops, did not see [Josef Moravec's] comment before passing QA. > Anybody has opinions? A new enhancement that actually has configurable search bar letting you also set the default active tab? In short, let this pass, and fix it elsewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:21:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:21:48 +0000 Subject: [Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545 --- Comment #40 from Marcel de Rooy --- >From khall on irc to clarify: marcelr: pluggability should be for the controlling behavior, not for the action imo. I'm trying to say if the plugin hook could be used to decide if any given hold form field should be required it would make more sense to me. That being said, I'm not opposed to it the way it works atm. I'm wondering if maybe HEA should be able to track installed plugins, that would be useful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:26:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:26:18 +0000 Subject: [Koha-bugs] [Bug 12437] <> 952$h field not populated while sending Routing List Notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12437 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13972 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:26:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:26:18 +0000 Subject: [Koha-bugs] [Bug 13972] Include fields from subscription and serial table in serial notification email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |binu at eclateng.com --- Comment #11 from Katrin Fischer --- *** Bug 12437 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:28:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:28:39 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #35 from Katrin Fischer --- Critical bug, can we get this moving again? We had another report for barcode going missing when editing from the serials module. That's bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:38:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:38:45 +0000 Subject: [Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 --- Comment #15 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #14) > (In reply to Jonathan Druart from comment #13) > > I think that this patch should not be pushed before bug 17964. > > There is no direct connection? These patches do a simple change to the > default notice that works and only depends on biblio and branch, not issues. They prove that CHECKIN and CHECKOUT work and will still work if a change is done in template processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:46:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:46:10 +0000 Subject: [Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:46:14 +0000 Subject: [Koha-bugs] [Bug 4126] bulkmarcimport.pl allows -b and -a to be specified simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58833|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 59618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59618&action=edit Bug 4126 - Exit bulkmarcimport if -a and -b given Currently it is possible to spceify both --biblios and --authorities as command line switches to bulkmarcimport.pl. This does not make sense so we should exit early and explain that these switches are mutually exclusive. To test: - Run one of these and check that there is no complaint about missing options: perl misc/migration_tools/bulkmarcimport.pl -a -b sudo koha-shell -c "perl misc/migration_tools/bulkmarcimport.pl -a -b" kohadev - Observe that this displays the perldoc, but does not complain about mutually exclusive switches. - Apply the patch - Rerun the command(s) from earlier. - Verify that the script is now halted and a small explanation given. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:51:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:51:15 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:51:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:51:19 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59278|0 |1 is obsolete| | Attachment #59285|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 59619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59619&action=edit Bug 16387: Fix default shortened loan period time When a loan period is shortened due to using decreaseLoanHighHolds* the time is always set to the current time in X days, even if the original loan period is given in days and not in hours. It should default to 23:59 as is normal for loan periods given in days. As original due date time defaults to 23:59 when given in days, this patch modifies the hours and minutes of shortened due date to be equal to original due date. To test: 1. prove t/db_dependent/DecreaseLoanHighHolds.t Signed-off-by: Grace McKenzie Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:53:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:53:20 +0000 Subject: [Koha-bugs] [Bug 16387] Incorrect loan period calculation when using decreaseLoanHighHolds feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:56:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:56:35 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:56:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:56:39 +0000 Subject: [Koha-bugs] [Bug 17929] You can't edit indicators in the cataloging screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59487|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 59620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59620&action=edit Bug 17929 - You can't edit indicators in the cataloging screen Test plan: 0. Do not apply the patch 1. Edit a biblio record, note you can't edit an indicator (in fact you edit it, but can't see the value) 2. Edit an authority record, note you can't edit an indicator (in fact you edit it, but can't see the value) 3. Apply the patch, you may need clear the browser cache (in Firefox Ctrl+F5 is often enough) 4. Repeat steps 1 and 2 - but now you will be able to edit the indicator Signed-off-by: J Schmidt Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 14:57:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 13:57:09 +0000 Subject: [Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 5.1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 15:16:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 14:16:40 +0000 Subject: [Koha-bugs] [Bug 17695] Frameworks not saving in IE11 when editing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17695 --- Comment #2 from Fiona Borthwick --- We have had another few customers report this problem too. It is often the case that they do not have any use of a different browser so it is causing major problems for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 15:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 14:48:21 +0000 Subject: [Koha-bugs] [Bug 18005] New: Pagination of the search result displayed wrong Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Bug ID: 18005 Summary: Pagination of the search result displayed wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 16239 There is 1 line per page, it's very ugly :) Introduced by bug 16239. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 [Bug 16239] Upgrade Bootstrap in the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 15:48:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 14:48:21 +0000 Subject: [Koha-bugs] [Bug 16239] Upgrade Bootstrap in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 [Bug 18005] Pagination of the search result displayed wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 15:54:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 14:54:37 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #33 from Alex Arnaud --- (In reply to Fridolin SOMERS from comment #32) > Change in C4/Installer/PerlDependencies.pm is useless I think I think you are right Frido -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 16:01:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 15:01:33 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|REOPENED |NEW --- Comment #6 from Jonathan Druart --- Technically: placerequest.pl is not checking if a patron can place reserve. The check is only done in reserve.pl That means that if a patron can place 1 hold, he will not be blocked to place X holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 16:28:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 15:28:26 +0000 Subject: [Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #1 from Owen Leonard --- I think it would be nice to be able to skip this step since Koha can function just fine without the use of acquisitions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 16:34:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 15:34:56 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 17:42:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 16:42:31 +0000 Subject: [Koha-bugs] [Bug 18006] New: MARC21: Don't show 246 when 1st indicator = 3 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18006 Bug ID: 18006 Summary: MARC21: Don't show 246 when 1st indicator = 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org http://www.loc.gov/marc/bibliographic/bd246.html It is our understanding, that the entry should be searchable but not display in the detail view, when the first indicator of 246 is 3. For example: 245 10 $a Apples & bears (displayed) 246 33 $a Apples and bears (not displayed) See also discussion on IRC: http://irc.koha-community.org/koha/2017-01-27#i_1900430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 18:56:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 17:56:51 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55263|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 59621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59621&action=edit Bug 17260: updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns The loading of file admin/searchengine/elasticsearch/mappings.yaml specifies 'type' as empty, which fails with Mysql 5.7+ which is more stringent. Also, forcing an empty value into a boolean also fails. Both issues arise when updatedatabase.pl hit 3.23.00.050. NOTE: both issues could also be resolved by actually setting values in the load file. This doesn't make this solution incorrect, though. To Test/reproduce: -1) Happens with Mysql 5.7.4. Maybe earlier, but certainly at that point. Use a Xenial kohadevbox to more easily test. 0) Find a database on 3.22 or earlier, save it. a) place sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION into the [mysqld] section of /etc/mysql/mysql.conf.d/mysqld.cnf b) restart you mysql server c) drop the db and recreate it d) checkout the 3.22.x branch e) do a web install f) remove the added sql_mode g) restart the mysql server 1) Set your code base to master 2) run updatedatabase.pl 3) See the errors on 3.23.00.050 4) Apply the patch 5) Reload the 3.22 db. a) repeat steps 0(a)-0(g) b) don't forget the caching issues 6) succeed with updatedatabase.pl 7) drop the db and recreate it 8) run the web installer 9) notice no issues either. 10) run koha qa test tools NOTE: This bug only solved the upgrade portion. I added the kohastructure.sql change as well. I confirmed that all the code changes were triggered with this test plan. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 19:37:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 18:37:39 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 [Bug 18007] Interface updates to notices and notice previews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 19:37:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 18:37:39 +0000 Subject: [Koha-bugs] [Bug 18007] New: Interface updates to notices and notice previews Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Bug ID: 18007 Summary: Interface updates to notices and notice previews Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart at bugs.koha-community.org, testopia at bugs.koha-community.org Depends on: 17961, 17981 An upcoming patch will: - Restructure the template for side-by-side comparisons of notice updates - Move JavaScript out of template into separate file - Improving form validation through use of validation plugin - Give better visual feedback for AJAX form checks Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 [Bug 17981] Add the ability to preview generated notice templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 19:37:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 18:37:39 +0000 Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 [Bug 18007] Interface updates to notices and notice previews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 20:10:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 19:10:09 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 20:10:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 19:10:13 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 --- Comment #1 from Owen Leonard --- Created attachment 59622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59622&action=edit Bug 18007 - Interface updates to notices and notice previews This patch makes changes to the form for adding and editing notices, and to the template for viewing a rendered preview of notices. - Preview now shows side-by-side comparisons - JavaScript has been movied out of template into separate file - Validation of the add/edit form improved through use of validation plugin - There is now better visual feedback for AJAX form checks To test, apply the patch on top of those for Bug 17981 - Add a new notice. - Confirm that the form can't be submitted without data in the "code" and "name" fields. - Confirm that the form can't be submitted without filling in at least one message template (subject and body). - Confirm that you cannot submit the form while using an existing notice code. - Confirm that while the form validates this step the submit button shows a loading indicator. - Follow Bug 17981's test plan for testing the preview function. Confirm that the preview loads correctly and looks correct. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 20:10:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 19:10:52 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 20:27:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 19:27:07 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59275|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 59623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59623&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 20:28:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 19:28:00 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #11 from Owen Leonard --- (In reply to Josef Moravec from comment #8) > It is enough to use container-fluid for full width grid, row-fluid should be > just "row" acording to bootstrap documentation Quite right. It is fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 20:31:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 19:31:58 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 20:42:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 19:42:19 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 --- Comment #3 from Owen Leonard --- Could this show the description instead of the code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:09:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:09:23 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #12 from M. Tompsett --- Created attachment 59624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59624&action=edit Staff is black -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:09:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:09:51 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #13 from M. Tompsett --- Created attachment 59625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59625&action=edit Superlibrarian is red -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:10:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:10:35 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from M. Tompsett --- There, screen shots of what I was talking about. Explain the reasons for the difference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:25:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:25:08 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 --- Comment #1 from Josef Moravec --- Created attachment 59626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59626&action=edit Bug 18005: Re-styled pagination on search results with Bootstrap Test plan: 0. Don't apply path 1. Make catalogue search in staff client with more then 20 results, scroll down to see that pagination is broken 2. Apply the patch 3. Make similar search and confirm, the pagination looks OK with new style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:25:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:25:04 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:26:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:26:31 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:41:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:41:19 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #15 from Josef Moravec --- Created attachment 59627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59627&action=edit WebIntallerStep1 I have broken screen on step 1, when I am trying to install in Czech language... Generated html code is here: http://paste.koha-community.org/287 In English it's OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:46:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:46:28 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Josef Moravec --- Hm, maybe some fa icon by link "Select all sample data" would be useful to make it more visible... I like the using of "btn-primary" ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:48:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:48:17 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #17 from Josef Moravec --- I faced a weird behavior, after installation, I was redirected to onboarding step 1, then immediatelly to step 2 and then step 3... so imposible to use two first forms/steps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:55:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:55:20 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #18 from Josef Moravec --- (In reply to Josef Moravec from comment #15) > Created attachment 59627 [details] > WebIntallerStep1 > > I have broken screen on step 1, when I am trying to install in Czech > language... > > Generated html code is here: http://paste.koha-community.org/287 > > In English it's OK Forgot it, my mistake, I did not regenerate the templates... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 21:55:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 20:55:45 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59627|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 22:16:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 21:16:10 +0000 Subject: [Koha-bugs] [Bug 17310] Broken URLs in 'Item renewed' / 'Cannot renew' messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17310 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 22:18:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 21:18:36 +0000 Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 27 23:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 27 Jan 2017 22:05:18 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #19 from M. Tompsett --- Don't sign off until I get feedback on comment #14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 03:35:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 02:35:05 +0000 Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17260 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 03:35:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 02:35:05 +0000 Subject: [Koha-bugs] [Bug 17260] updatedatabase.pl fails on invalid entries in ENUM and BOOLEAN columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17260 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16583 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 03:38:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 02:38:31 +0000 Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583 --- Comment #6 from M. Tompsett --- (In reply to Nabila from comment #5) > The Ubuntu 16.04 LTS is not supporting a fresh installation of Koha. With the application of 17260, I was able to get a fresh installation working on the xenial kohadevbox. > The error not comes in Acquisition Module but also the following: > > -- Cannot create New Vendor in Acquisition (Doesn't save the record instead > searches the vendor) > -- Cannot do the Batch Patron Import (Shows error in DBI.pm file) > -- Cannot create any entry that requires Auto Increment of Primary Key. > -- Does not load default framework of Cataloging. I propose making this bug one of these things, and creating other bugs for the others. Smaller bugs get pushed through faster. They are also easier to test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 03:45:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 02:45:47 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #113 from M. Tompsett --- Comment on attachment 59279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59279 [SIGNED-OFF] bug 17855 - Updated web installer finished Review of attachment 59279: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=59279) ----------------------------------------------------------------- Sorry I didn't catch this the first time. ::: installer/onboarding.pl @@ +381,5 @@ > + $newdata{categorycode} = $input->param('categorycode_entry'); > + $newdata{userid} = $input->param('userid'); > + $newdata{password} = $input->param('password'); > + $newdata{password2} = $input->param('password2'); > + $newdata{dateexpiry} = '12/10/2016'; No no no! I was trying to test under Xenial Kohadevbox, and it blew up! "DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect date value: '12/10/2016' for column 'dateexpiry' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 120" Dates that will be used directly with SQL queries need to be YYYY-MM-DD. Plus hard coded?! YUCK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 03:46:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 02:46:01 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 04:21:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 03:21:01 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #114 from M. Tompsett --- Also missing: address and city need to default to something other than undef (onboarding.pl line 378ish -- see lack of address and city). Adding blank values should be good enough. Also questionable: onshelfholds logic. The schema says bit, but "yes" and the other possible string values are not bit values. I hacked a !(!( blah )) to get it to keep running, but that's the wrong solution. All problems are highlighted when testing on Xenial KohaDevBox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 08:45:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 07:45:27 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #115 from Alex Buckley --- (in reply to M.Tompsett in comments 113 and 114) To fix the dateexpiry issue I can simply remove the dateexpiry altogether from the onboarding.pl script, because in the database it is set to null by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 09:11:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 08:11:14 +0000 Subject: [Koha-bugs] [Bug 18008] New: Use templates for generating pagination Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Bug ID: 18008 Summary: Use templates for generating pagination Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Except catalogue search results the pagination is generated by C4::Output::pagination_bar, id don't think it's the right way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 09:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 08:11:51 +0000 Subject: [Koha-bugs] [Bug 18008] Use templates for generating pagination In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 [Bug 18005] Pagination of the search result displayed wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 09:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 08:11:51 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008 [Bug 18008] Use templates for generating pagination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 12:52:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 11:52:37 +0000 Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #7 from Zeno Tajoli --- Hi, for who want an immediate solution: >Perhaps the best immediate solution is to change MySQL config files to make 5.7 > it behave like 5.6. Insert in your /etc/mysql/my.conf: [mysqld] sql_mode=IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION Source: http://askubuntu.com/questions/811831/whats-the-correct-way-to-revert-mysql-5-7-strict-mode-back-to-how-it-was-in-5-6 But is not a long term solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 22:15:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 21:15:00 +0000 Subject: [Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583 --- Comment #8 from M. Tompsett --- (In reply to Zeno Tajoli from comment #7) > Insert in your /etc/mysql/my.conf: This does not fix the software side of the issues, and will not solve the problems long term. And I had to stick it somewhere else to get it to work for me. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 28 22:17:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 28 Jan 2017 21:17:09 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #116 from M. Tompsett --- (In reply to Alex Buckley from comment #115) > (in reply to M.Tompsett in comments 113 and 114) > > To fix the dateexpiry issue I can simply remove the dateexpiry altogether > from the onboarding.pl script, because in the database it is set to null by > default. But shouldn't it be set based on the patron category? I didn't check, but I think the patron category would determine what the date expiry should be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 02:54:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 01:54:53 +0000 Subject: [Koha-bugs] [Bug 18009] New: IssueSlip.t test fails if launched between 00:00 and 00: 59 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Bug ID: 18009 Summary: IssueSlip.t test fails if launched between 00:00 and 00:59 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtj at kohaaloha.com QA Contact: gmcharlt at gmail.com here's an example of the test passing then failing with 2 different dates. ------------------------- vagrant at kohadevbox:~$ sudo date -s 'Sun Jan 29 01:41:55 UTC 2017' Sun Jan 29 01:41:55 GMT 2017 kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Members/IssueSlip.t t/db_dependent/Members/IssueSlip.t .. ok All tests successful. Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 2.10 cusr 0.12 csys = 2.25 CPU) Result: PASS ------------------------- vagrant at kohadevbox:~$ sudo date -s 'Sun Jan 29 00:41:55 UTC 2017' Sun Jan 29 00:41:55 GMT 2017 kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Members/IssueSlip.t t/db_dependent/Members/IssueSlip.t .. # Looks like you planned 2 tests but ran 1. # Failed test 'Hourly loans' # at t/db_dependent/Members/IssueSlip.t line 279. # Looks like you failed 1 test of 3. t/db_dependent/Members/IssueSlip.t .. 1/3 # Failed test 'Issue slip' # at t/db_dependent/Members/IssueSlip.t line 281. The 'hour' parameter ("-1") to DateTime::set did not pass the 'an integer between 0 and 23' callback at /usr/lib/x86_64-linux-gnu/perl5/5.20/DateTime.pm line 1946. DateTime::set(undef, "hour", -1) called at t/db_dependent/Members/IssueSlip.t line 254 main::__ANON__() called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 eval {...} called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 Test::Builder::subtest(Test::Builder=HASH(0x1cfa9d0), "Hourly loans", CODE(0x85c7ea0)) called at /usr/local/share/perl/5.20.2/Test/More.pm line 807 Test::More::subtest("Hourly loans", CODE(0x85c7ea0)) called at t/db_dependent/Members/IssueSlip.t line 279 main::__ANON__() called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 eval {...} called at /usr/local/share/perl/5.20.2/Test/Builder.pm line 309 Test::Builder::subtest(Test::Builder=HASH(0x1cfa9d0), "Issue slip", CODE(0x86031c8)) called at /usr/local/share/perl/5.20.2/Test/More.pm line 807 Test::More::subtest("Issue slip", CODE(0x86031c8)) called at t/db_dependent/Members/IssueSlip.t line 281 # Looks like your test exited with 255 just after 1. t/db_dependent/Members/IssueSlip.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/3 subtests Test Summary Report ------------------- t/db_dependent/Members/IssueSlip.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.79 cusr 0.08 csys = 1.89 CPU) Result: FAIL ------------------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 02:55:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 01:55:09 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 02:56:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 01:56:50 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15029 Depends on| |15029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 [Bug 15029] Tests fail if launched after 23:00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 02:56:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 01:56:50 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18009 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18009 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 09:44:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 08:44:51 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #117 from Alex Buckley --- (In reply to M.Tompsett in comment 116) Yes I've checked and the dateexpiry is based on the patron category and so I am currently working on retrieving the selected patron category enrolement date to be used as the value for the dateexpiry variable. In the commit I am working on currently I have set the address and city to blank values- so that is that issue fixed. Regarding the onshelfholds logic, I suggest we leave that to be fixed in bug 17955 which I am also currently working on as I am removing the SQL code which forms a big portion of the onshelfholds code in the onboarding.pl script and reworking it to use DBIx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 11:21:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 10:21:20 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #118 from Alex Buckley --- Created attachment 59628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59628&action=edit Bug 17855 - Implemented a retrieval of patron category enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron accounts created with the onboarding tool. Set address and city variables to "" in onboarding.pl Fixed the creation/filling of the $firstpassword, $secondpassword and $op variables in the onboarding.pl so they don't cause uninitialised variable errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 11:23:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 10:23:12 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 11:58:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 10:58:47 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 11:58:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 10:58:50 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 --- Comment #1 from Mason James --- Created attachment 59629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59629&action=edit Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59 to test patch... 1/ set date between 00:00 and 00:59 $ sudo date -s 'Sun Jan 29 00:41:55 NZDT 2017' 2/ run prove, see fail $ prove -v t/db_dependent/Members/IssueSlip.t ... t/db_dependent/Members/IssueSlip.t (Wstat: 65280 Tests: 1 Failed: 0) Result: FAIL 3/ apply patch 4/ run prove, see pass $ prove -v t/db_dependent/Members/IssueSlip.t ... All tests successful. Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:32:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:32:45 +0000 Subject: [Koha-bugs] [Bug 17660] Any $t subfields not editable in any framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17660 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:36:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:36:31 +0000 Subject: [Koha-bugs] [Bug 17513] koha-create does not set GRANTS correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17513 --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:38:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:38:25 +0000 Subject: [Koha-bugs] [Bug 15822] STAFF Advanced search error date utils In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #23 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:38:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:38:58 +0000 Subject: [Koha-bugs] [Bug 16376] Koha::Calendar-> is_holiday date truncation creates fatal errors for TZ America/Santiago In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376 --- Comment #28 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:39:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:39:30 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #22 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:39:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:39:56 +0000 Subject: [Koha-bugs] [Bug 17749] Missing l in '.pl' in link on waitingreserves.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17749 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:40:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:40:26 +0000 Subject: [Koha-bugs] [Bug 17547] (MARC21) Chronological term link subfield 648$9 not indexed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17547 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:40:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:40:51 +0000 Subject: [Koha-bugs] [Bug 17681] Existing typos might thow some fees when recieved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17681 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:42:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:42:34 +0000 Subject: [Koha-bugs] [Bug 17652] opac-account.pl does not include login branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:43:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:43:11 +0000 Subject: [Koha-bugs] [Bug 17761] Renewing or returning item via the checkouts table causes lost and damaged statuses to disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17761 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:43:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:43:33 +0000 Subject: [Koha-bugs] [Bug 16951] Item search sorting not working properly for most columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16951 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:43:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:43:51 +0000 Subject: [Koha-bugs] [Bug 17743] Item search: indexes build on MARC do not work in item' s search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17743 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:46:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:46:55 +0000 Subject: [Koha-bugs] [Bug 15415] Warn when creating new printer profile for patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 12:47:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 11:47:55 +0000 Subject: [Koha-bugs] [Bug 17744] OAI: oai_dc has no element named dcCollection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17744 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.07 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 13:06:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 12:06:53 +0000 Subject: [Koha-bugs] [Bug 17917] t/db_dependent/check_sysprefs.t fails on kohadev strangely In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17917 --- Comment #44 from Mason James --- (In reply to Mason James from comment #43) > Pushed to 16.05.x, for 16.05.08 release Update - I reverted this patchset from 16.05.x after hitting failing test from t/db_dependent/Search.t transcript below.. $ prove t/db_dependent/Search.t ... t/db_dependent/Search.t .. 4/4 Can't locate object method "get_instance" via package "Koha::Caches" (perhaps you forgot to load "Koha::Caches"?) at t/db_dependent/Search.t line 971. # Looks like your test exited with 255 just after 4. t/db_dependent/Search.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 4 subtests passed Test Summary Report ------------------- t/db_dependent/Search.t (Wstat: 65280 Tests: 4 Failed: 0) Non-zero exit status: 255 Files=1, Tests=4, 34 wallclock secs ( 0.05 usr 0.02 sys + 12.82 cusr 9.46 csys = 22.35 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 15:07:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 14:07:48 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59537|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 59630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59630&action=edit Bug 17982: Fix the use of uniq in sub themelanguage Doing uniq( \@themes ) is useless. It will just return to you the only reference you gave it. List::MoreUtils::uniq requires a list instead of an arrayref. So it is a trivial fix that makes sub themelanguage return one theme instead of three themes like [ 'prog', 'prog', 'prog' ]. Note that Template->new inserts one or two include paths to TT for each of these three identical themes. Note: Removed a overcomplete unit test that basically tested uniq with uniq in order to remove a dependency for a more important bug report. Test plan: [1] Run t/db_dependent/Auth.t (triggering themelanguage) [2] Open a page on OPAC or intranet. (Did you restart Plack?) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 15:09:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 14:09:09 +0000 Subject: [Koha-bugs] [Bug 17989] Allow templates from plugin directories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17982 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 [Bug 17982] Fix the use of uniq in sub themelanguage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 15:09:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 14:09:09 +0000 Subject: [Koha-bugs] [Bug 17982] Fix the use of uniq in sub themelanguage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17982 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17989 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 [Bug 17989] Allow templates from plugin directories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 18:03:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 17:03:24 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #119 from M. Tompsett --- Comment on attachment 59628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59628 Bug 17855 - Implemented a retrieval of patron category enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron accounts created with the onboarding tool. Review of attachment 59628: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=59628) ----------------------------------------------------------------- This is my quick eyeball. I'll test later. ::: installer/onboarding.pl @@ +92,4 @@ > ); > > #Store the value of the template input name='op' in the variable $op so we can check if the user has pressed the button with the name="op" and value="finish" meaning the user has finished the onboarding tool. > +my $op = $input->param('op') || ""; For future reference q{} is perlcritic level 1 friendly. Single quotes are also more perlcritic friendly. @@ +282,5 @@ > $template->param( 'categories' => $categories, ); > > + > + > + Hmmm... excess space? I'm not going to fail over this. I'll let QA fix it. @@ +387,5 @@ > + $newdata{city} = ""; > + > +#Determine the dateexpiry of the patron based on the patron category it is created from > + my $patron_category = Koha::Patron::Categories->find( $newdata{categorycode} ); > + $newdata{dateexpiry} = $patron_category->get_expiry_date( $newdata{dateenrolled} ); It's so pretty! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 21:07:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 20:07:05 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #1 from Alex Buckley --- Created attachment 59633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59633&action=edit Bug 17955 - Implemented working DBIX in place of sql queries throughout the whole of the onboarding.pl script. Modified the onshelfholds if statement logic in the onboarding.pl script. Removed unneccisary use pragmas from onboarding.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 21:09:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 20:09:23 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59633|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 21:16:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 20:16:27 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #2 from Alex Buckley --- Created attachment 59634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59634&action=edit Bug 17955 - Implemented working DBIX in place of sql queries throughout the whole of the onboarding.pl script. Modified the onshelfholds if statement logic in the onboarding.pl script. Removed unneccisary use pragmas from onboarding.pl script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 21:52:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 20:52:00 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59592|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 59635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59635&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 21:59:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 20:59:05 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59634|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 22:14:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 21:14:08 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #3 from Alex Buckley --- Created attachment 59636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59636&action=edit bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged several commits - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script - Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' - Added the use CGI qw ( -utf8 ); - Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt - Fixed typo in summary.tt - Made consistent single space before and after -> in all onboarding .tt and summary.tt files. - Made single
    tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) - Changed button and link names in web installer and onboarding tool - Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. - Fixed the errors from the koha qa test - Removed use:C4/Auth from the onboarding.pl - Moved the "select all options" button down to just above the selectable options in the basic setup, and positioned at the top of the page for the advanced setup. - Removed the "there is nothing to do because the sample data is already installed" page so if the user has install sample data in the web installer then the step to create that object in the onboarding tool is skipped altogether. - Removed the "We're just going to setup a few more things" page - Changed the title of the 'Create patron page' - Added clarifying information to the "Add a patron category" page - Added clarifying information to the "Create item type" page - Fixed the capitalization in the onboarding tool - Removed the BackupStep3.tt file which was un-used - Changed the redirect time displayed to user in step3.tt to 10 - Changed the cardnumber on the create patron administrator page so that it is only populated when the user installed sample patrons. Also changed the regex so that it allows letters and number. - Used the HTMl validator to identify errors in the template and have corrected all possible in the onboarding templates. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 22:14:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 21:14:31 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #35 from Liz Rea --- Bump for attention please. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 22:16:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 21:16:37 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59469|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia --- Created attachment 59637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59637&action=edit Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 22:17:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 21:17:39 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #47 from Aleisha Amohia --- (In reply to Josef Moravec from comment #45) > Please, upgrade your templates to bootstrap 3 (see bug 16239) and > > https://wiki.koha-community.org/wiki/Interface_patterns > http://getbootstrap.com/css/#grid I only found one place I needed to update a button to bootstrap 3. This is ready to sign off again, unless someone else can find other places that need updating ... would really like to get this one through now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 22:20:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 21:20:47 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59636|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 22:52:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 21:52:16 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 22:52:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 21:52:20 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59480|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 59638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59638&action=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first, update database, rebuild schema. 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowIssueNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave an issue note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage issue notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage issue notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an issue note as seen. This should update the status of the issue note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 23:12:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 22:12:59 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #4 from Alex Buckley --- Created attachment 59639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59639&action=edit Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script Replaced all sql code in onboarding.pl script with DBIx Changed the logic of the onshelfholds if statement in onboarding.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 23:15:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 22:15:19 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 29 23:17:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 29 Jan 2017 22:17:07 +0000 Subject: [Koha-bugs] [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #5 from Alex Buckley --- Test Plan: 1. Apply bug 17855 and observe the installer/onboarding.pl script has multiple sql queries in it 2. Apply bug 17955 (this bug) and observe that there are no more sql queries in the same onboarding.pl script. The queries have been replaced with DBIx database interaction queries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 01:50:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 00:50:01 +0000 Subject: [Koha-bugs] [Bug 17938] XSLT: if 583 is repeated, the label will appear multiple times. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- Hi Karen, I think there may be a bug in your patch - without an indicator, or with indicator 0, the notes do not display, but the action-note label and associated pipe separators do. Thanks for having a look into this problem though! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 04:52:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 03:52:56 +0000 Subject: [Koha-bugs] [Bug 18011] New: Categories.pl allows users to set the enrolementperioddate to before the current date without any error /warning messages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Bug ID: 18011 Summary: Categories.pl allows users to set the enrolementperioddate to before the current date without any error/warning messages Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P3 Component: System Administration Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At present when creating a patron category the user can select a date from the date picker which is earlier than the current date, meaning patrons created from the patron category have a dateexpire before they were even created. The fix of this bug is to implement a javascript message informing the user that the date they selected from the datepicker is invalid and forcing them to choose a new date before they can submit the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 05:46:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 04:46:36 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Mubassir Ahsan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mahsandu at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 06:19:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 05:19:18 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 Geetmala <0907mala at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|3.18 |3.22 Priority|P5 - low |P1 - high OS|All |Windows CC| |0907mala at gmail.com Hardware|All |PC --- Comment #15 from Geetmala <0907mala at gmail.com> --- How to change library code in koha 3.20 because we seven branches each sch we have taken 3 letter before accession no. as barcode two of our sch name Prabhadevi and Sayani we started with PRAB and SAYA. I want to change PRA and SAY instead of that please suggest me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 08:32:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 07:32:11 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Status|NEW |Needs Signoff --- Comment #4 from Mason James --- hmm, setting status to 'needs signoff' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 08:32:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 07:32:46 +0000 Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14625 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 08:32:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 07:32:46 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 08:55:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 07:55:56 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Status|NEW |In Discussion --- Comment #3 from Mason James --- (In reply to Oliver Bock from comment #2) > Any update on this? hi Oliver, can you provide some testing steps for this patchset? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 08:57:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 07:57:28 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #5 from Mason James --- (In reply to Mason James from comment #4) > hmm, setting status to 'needs signoff' hi Oliver, can you provide some testing steps for this patchset? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 09:05:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 08:05:33 +0000 Subject: [Koha-bugs] [Bug 5800] Hold Policy "home library only" incompatible with CircControl " patron home library" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5800 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 09:05:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 08:05:45 +0000 Subject: [Koha-bugs] [Bug 5800] Hold Policy "home library only" incompatible with CircControl " patron home library" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5800 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 09:32:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 08:32:25 +0000 Subject: [Koha-bugs] [Bug 13545] Add barcode image generator service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 --- Comment #16 from Katrin Fischer --- I think this is not possible with configuration in 3.20 - maybe it will be possible once notices templates are using template toolkit. This feature is in development for 17.05. If you want help for a customization, it's better to ask on the mailing list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 09:40:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 08:40:11 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker --- Comment #36 from Katrin Fischer --- Losing data without noticing it... upping severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 09:49:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 08:49:25 +0000 Subject: [Koha-bugs] [Bug 15714] Remove zebra.log from debian scripts and add optional log levels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15714 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #23 from Marcel de Rooy --- Barton: We do not need to add zebra_loglevels to etc/koha-conf.xml here, since zebra_loglevels is only used in debian script koha-functions.sh, not used by other install types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 10:50:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 09:50:16 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 10:50:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 09:50:19 +0000 Subject: [Koha-bugs] [Bug 17987] Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17987 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59635|0 |1 is obsolete| | --- Comment #5 from Claire Gravely --- Created attachment 59640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59640&action=edit Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 11:09:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 10:09:17 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #48 from Josef Moravec --- Ad 3) Rebuild schema Change for for table issues are in your patch, but for old_issues not - probably better to be consistant here, just for more convinience testing. But not reason to fail the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 11:10:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 10:10:49 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 11:10:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 10:10:53 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59637|0 |1 is obsolete| | --- Comment #49 from Josef Moravec --- Created attachment 59641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59641&action=edit [SIGNED-OFF] Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Update database 3) Rebuild schema 4) Turn on 'AllowIssueNote' syspref 5) Check out three different items to a borrower (may be easiest to check out to yourself) 6) Log in as that borrower (or yourself) on the OPAC side and go to your summary 7) Confirm text field shows under Note column for all checkouts. Set a note for each issue, confirm all save. 8) Check the message_queue in mysql for the entries for ALL THREE issue notes. 9) Disable javascript in your browser 10) Refresh your summary page. Confirm that you can no longer edit the notes in the text field. Click the 'Create/edit note' button and confirm you are redirected to a new page. 11) Confirm that the correct title and author show for the note button you clicked. 12) Set the note and click Submit -> confirm you are redirected back to summary page and note is saved 13) Confirm there is a new entry in message_queue 14) Enable javascript and go back to the your checkouts page in the staff client for the borrower you issued the items to 15) Check in TWO items 16) Confirm that the issue notes show under the "Date due" column for the two items you checked in, and are accurate to the item (i.e. the right issue note under the right item) 17) Go to circ/returns.pl and check in the final item using the barcode. Confirm the issue note shows and the date is formatted correctly. Sponsored-by: Region Halland Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 11:11:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 10:11:54 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59626|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 59642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59642&action=edit Bug 18005: Re-styled pagination on search results with Bootstrap Test plan: 0. Don't apply path 1. Make catalogue search in staff client with more then 20 results, scroll down to see that pagination is broken 2. Apply the patch 3. Make similar search and confirm, the pagination looks OK with new style Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 11:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 10:11:51 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 11:22:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 10:22:14 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #8 from Josef Moravec --- Koha QA tools complains: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/checkout_notes/checkout-notes.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 104) There are some references to non-existing page issue notes see git grep "issue-notes.pl" And bad terminology: "Back to issue notes", line 104 of checkout-notes.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 11:38:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 10:38:38 +0000 Subject: [Koha-bugs] [Bug 18012] New: Add classes and ids to opac-user.pl / Failed login Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18012 Bug ID: 18012 Summary: Add classes and ids to opac-user.pl / Failed login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When using LDAP, CAS or even Koha, sometimes the existing texts shown on the opac-user.pl page don't fit when the login failed or when you are asked to login after trying to access a feature (try to place a hold without being logged in first) Right now it's really hard to change something here with OpacUserJs or CSS, because the text is in multiple

    tags without any classes or ids. It would be nice if it was easier to select the elements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:00:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:00:24 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52704|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud --- Created attachment 59643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59643&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve Rabased on master Rebased on master (2016-06-23) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:16:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:16:48 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec --- (In reply to Jonathan Druart from comment #0) > > Solution 1: > Do not care about this problematic use case and prevent to delete the last > patron. I do not like this - it escalates the internal technical problem to end user... > Solution 2: > Add a AI primary key (id) to deletedborrowers > => The 2 tables borrowers and deletedborrowers will differ, bugs will be > expected It could be possible I think, but probably not easy to make it > Solution 3: > Deal with that at code level: when a patron is created, guess the > borrowernumber it will get and check if it does not already exist in the > deletedborrowers table. If so, force it before inserting it > A bit complicated, but probably the best one > Solution 4: > Do not enforce this constraint at DB level but set the primary key to DBIC > schema: > Koha::Schema::Result::Deletedborrower: > __PACKAGE__->set_primary_key("borrowernumber"); > Problem: > Koha::Database->new->schema->resultset('Deletedborrower')->find(42); > will raise a warning "DBIx::Class::Storage::DBI::select_single(): Query > returned more than one row. SQL that returns multiple rows is DEPRECATED > for ->find and ->single" if 42 is duplicated, and the first matching row > will be picked I do not like this too > > Another solution? So I am for 2 or 3, 2 was what came first to my mind, but the 3 is better I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:17:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:17:54 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 --- Comment #3 from Josef Moravec --- > Another solution? Merge borrowers and deletedborrowers to one table and mark the deleted one with a flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:22:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:22:22 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #6 from Oliver Bock --- Not really, unfortunately. I'm not a Koha dev so I don't know anything about the unit test framework you use. Also, my patch was just meant as a proposal: it works for us but it should certainly be vetted (fixed/improved?) by the original author of that code section. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:30:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:30:37 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #4 from Oliver Bock --- Not really, unfortunately. I'm not a Koha dev so I don't know anything about the unit test framework you use. Also, my patch was just meant as a proposal: it works for us but it should certainly be vetted (fixed/improved?) by the original author of that code section. My patches only reflect my understanding of code concerned which build while tracking down the issues we saw (this was a tricky one). They're based on my interpretation of the original author's intentions, the reasoning of which I just don't know. Thus my hope was that my patch starts a discussion. Thanks, Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:33:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:33:40 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 --- Comment #4 from Marcel de Rooy --- Does the problem mentioned on top only occur on an empty borrowers table with a mysql restart? Supposing that this is the case and it is quite rare, can't we just use borrowernumber as the primary key on borrowers and deletedborrowers, obviously having no constraints on deletedborrowers. We could even add a check for borrowernumber when creating a patron, and update the borrowernumber if needed to not match deletedborrowers? Ugly, but fixing some problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:35:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:35:54 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 --- Comment #5 from Katrin Fischer --- We discussed if it also happens when you delete the last added borrower and then restart - not sure what the answer was. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:37:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:37:31 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #7 from Katrin Fischer --- Hi Oliver, testing steps can also be a "step by step" on how to reproduce the error. 1) go to the login page 2) enter... ... and so on. This makes it easier for people to understand the problem and test your code. Given the number of devs and Koha's age, we might not be able to find the original developer :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:44:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:44:26 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:44:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:44:29 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #7 from Dobrica Pavlinusic --- Created attachment 59644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59644&action=edit Bug 17775 - Add new user with LDAP not works under Plack This patch fixes internal server error: Undefined subroutine &C4::Auth_with_ldap::AddMember called at /srv/koha_ffzg/C4/Auth_with_ldap.pm line 213. It occurs only under plack, and it's strange since C4::Members does EXPORT AddMember and we are importing it into Auth_with_ldap.pm (and it does work under CGI). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 12:45:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 11:45:34 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #8 from Dobrica Pavlinusic --- Alex, sorry to steal this one from you, but we hit this one when we deploy master in production, so here if fix for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 13:00:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 12:00:50 +0000 Subject: [Koha-bugs] [Bug 18013] New: acqui/transferorder.pl typo in find method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 Bug ID: 18013 Summary: acqui/transferorder.pl typo in find method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 13:04:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 12:04:18 +0000 Subject: [Koha-bugs] [Bug 18013] acqui/transferorder.pl typo in find method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 13:04:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 12:04:21 +0000 Subject: [Koha-bugs] [Bug 18013] acqui/transferorder.pl typo in find method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 59645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59645&action=edit Bug 18013 - acqui/transferorder.pl typo in find method This typo was introduced in Bug 13726 and has obvious fix -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 13:05:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 12:05:56 +0000 Subject: [Koha-bugs] [Bug 18013] acqui/transferorder.pl typo in find method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 13:13:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 12:13:19 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #8 from Oliver Bock --- Sorry, I thought the description was clear enough. Ok, let's see: 1) Create an extended patron attribute (that exists in LDAP) 2) Map that attribute in your LDAP auth config 3) Log in (first replication, should give no error in OPAC log) 4) Log out 5) Update attribute in LDAP 6) Log in 7) Error (see first comment) should be visible in OPAC log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 13:36:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 12:36:03 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #5 from Oliver Bock --- Steps to reproduce: 1) Map the attribute "cardnumber" for replication and update in your LDAP config 2) Create at least two users that don't yet have a value for that attribute in LDAP 3) Log in with both users one after the other 4) The second log in should result in a UNIQUE CONSTRAINT violation While "cardnumber" is NULLable, inserting/updating two borrowers with an empty string for it result in a UNIQUE CONSTRAINT violation. This proves that a semantically correct action fails with the current implementation. This wouldn't happen if NULL would be used instead of an empty string. HTH, Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:43:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:43:37 +0000 Subject: [Koha-bugs] [Bug 17942] Update style of the web installer with Bootstrap 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #20 from Owen Leonard --- (In reply to M. Tompsett from comment #14) > There, screen shots of what I was talking about. Explain the reasons for the > difference. This is rude. (In reply to M. Tompsett from comment #19) > Don't sign off until I get feedback on comment #14. I don't think this comment is appropriate. "Superlibrarian" is red because it is highlighted for visibility in a page which is structured with sections topped by headings. There is nothing in that section other than text. I think its appropriate to provide a little more visibility to that text to help show that it is the focus of that section. "Staff" is plain black because it is informational text being displayed as part of a form. As in other places in Koha, when a line in a form displays information instead of some kind of input, plain text is paired with Label: to preserve the structure and flow of the form. The plain text fits with the structure of the form and does not need to be highlighted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:46:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:46:10 +0000 Subject: [Koha-bugs] [Bug 17950] Small improvements for Merge.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Additional housekeeping on |Small improvements for |Merge.t (after 17913) |Merge.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:50:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:50:25 +0000 Subject: [Koha-bugs] [Bug 18014] New: Make auth_header.authid AUTO_INCREMENT Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Bug ID: 18014 Summary: Make auth_header.authid AUTO_INCREMENT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:51:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:51:06 +0000 Subject: [Koha-bugs] [Bug 18014] Working title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make auth_header.authid |Working title |AUTO_INCREMENT | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:53:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:53:12 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Working title |AddAuthority should respect | |AUTO_INCREMENT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:53:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:53:35 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |MARC Authority data support |and plumbing | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:53:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:53:41 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 14:57:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 13:57:27 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #9 from Katrin Fischer --- Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 15:17:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 14:17:33 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #13 from Kyle M Hall --- Pushed to master for 17.05, thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 15:37:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 14:37:34 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Much better. This patch has been pushed to 16.11.x and will be in 16.11.03. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 15:56:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 14:56:25 +0000 Subject: [Koha-bugs] [Bug 18015] New: On shelf holds allowed > "If all unavailable" ignores notforloan Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Bug ID: 18015 Summary: On shelf holds allowed > "If all unavailable" ignores notforloan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 15:56:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 14:56:44 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mirko at abunchofthings.net |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 15:59:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 14:59:43 +0000 Subject: [Koha-bugs] [Bug 18011] Categories.pl allows users to set the enrolementperioddate to before the current date without any error /warning messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 --- Comment #1 from Owen Leonard --- Check out the options for the datepicker widget which can limit the range of dates which will be accepted. https://jqueryui.com/datepicker/#min-max For instance, in returns.tt starting at line 60. That template also has some back-up date testing in case someone types an invalid date directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:02:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:02:16 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 --- Comment #1 from Mirko Tietgen --- Created attachment 59646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59646&action=edit Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. Test plan: - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - Have two items for a record. Check out one - Set 7 - Not for loan: "Not For Loan" for the second item - Try to place a hold. Does not work. - Apply the patch - Try to place a hold. Should work now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:02:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:02:41 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:15:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:15:05 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #33 from Tom?s Cohen Arazi --- Guys, this patchset broke kohadevbox. It is probably an integration issue, but as dev_install is not present I would expect it to use the package's paths, and instead of that it just breaks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:17:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:17:24 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #10 from Dobrica Pavlinusic --- Most of our invalid birth dates in DB are result of external bulk script to open accounts at beginning of each academic year since source data sometimes doesn't have birth dates, so this is our local problem, and not Koha related. However, it doesn't explain all entries, since some of them are created after bulk script, using Koha's replication from LDAP. We have following mapping in koha-conf.xml: and if LDAP entry doesn't have hredupersondateofbirth we are also getting 0000-00-00 for dateofbirth in Koha mosty because of $data = $mapping{$key}->{content} || ''; # default or failsafe '' from ldap_entry_2_hash in C4/Auth_with_ldap.pm. Sould I fix ldap_entry_2_hash as separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:20:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:20:44 +0000 Subject: [Koha-bugs] [Bug 18001] LocalHoldsPriority can cause multiple holds queue lines for same hold request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18001 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:24:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:24:19 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:24:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:24:23 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57110|0 |1 is obsolete| | --- Comment #36 from Owen Leonard --- Created attachment 59648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59648&action=edit [SIGNED-OFF] Bug 14764: OPAC news selector Test plan: 1) Add more than one library, at least two in total is needed. Make note of which is your current user's home branch. 2) Go to Tools -> News and add one global ("All") news item and one specific for each branch. 3) Apply the patches. 4) Perform database upgrades when you log in. 5) Go to OPAC main, it should work as before: Showing global news as well as the news for your home branch once logged in. 6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes. 7) Go to OPAC main, you should see the global news item plus any items for your home branch for the current user if logged in. 8) Above the news, you will see a dropdown that lists the branches. Select one, and click "Change library." 9) You should now see global news and the news for the selected branch, regardless of whether logged in or not. Sponsored-By: Halland County Library Fixes QA comments: * Keep the current selected branch selected * Change OPACNewsBranchSelect -> OPACNewsLibrarySelect * fix 'system wide only' view for logged in user. We still show system wide even when a library is selected. * Removed the "change library" link * Added a label to the field. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:42:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:42:09 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:42:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:42:12 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59646|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 59649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59649&action=edit Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. Test plan: - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - Have two items for a record. Check out one - Set 7 - Not for loan: "Not For Loan" for the second item - Try to place a hold. Does not work. - Apply the patch - Try to place a hold. Should work now. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:56:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:56:37 +0000 Subject: [Koha-bugs] [Bug 18016] New: C4::Auth_with_ldap:: ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016 Bug ID: 18016 Summary: C4::Auth_with_ldap::ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:57:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:57:52 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 --- Comment #11 from Dobrica Pavlinusic --- On closer review, our script is using C4::Auth_with_ldap::ldap_entry_2_hash so I opened Bug 18016 to track this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:58:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:58:15 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59648|0 |1 is obsolete| | --- Comment #37 from Zeno Tajoli --- Created attachment 59653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59653&action=edit OPAC news selector -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:58:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:58:28 +0000 Subject: [Koha-bugs] [Bug 17933] Internal software error when searching patron without birth date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17933 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18016 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 16:58:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 15:58:28 +0000 Subject: [Koha-bugs] [Bug 18016] C4::Auth_with_ldap:: ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17933 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:00:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:00:39 +0000 Subject: [Koha-bugs] [Bug 18016] C4::Auth_with_ldap:: ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:01:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:01:44 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #38 from Zeno Tajoli --- Test plan: 1) Add more than one library, at least two in total is needed. Make note of which is your current user's home branch. 2) Go to Tools -> News and add one global ("All") news item and one specific for each branch. 3) Apply the patches. 4) Perform database upgrades when you log in. 5) Go to OPAC main, it should work as before: Showing global news as well as the news for your home branch once logged in. 6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes. 7) Go to OPAC main, you should see the global news item plus any items for your home branch for the current user if logged in. 8) Above the news, you will see a dropdown that lists the branches. Select one, and click "Change library." 9) You should now see global news and the news for the selected branch, regardless of whether logged in or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:06:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:06:52 +0000 Subject: [Koha-bugs] [Bug 14764] Add OPAC News branch selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch insert a new sys release notes| |pref: | |"OpacNewsLibrarySelect". | |When it is active you can | |select the news that you | |see in the | |main opac page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:07:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:07:55 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59391|0 |1 is obsolete| | --- Comment #12 from Owen Leonard --- Created attachment 59655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59655&action=edit [SIGNED-OFF] Bug 17944 - Moved the sql code from itemtypes.pl into Koha/ItemTypes.pm Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:08:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:08:06 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59564|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 59656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59656&action=edit [SIGNED-OFF] Bug 17944 - Removed the sql code from Itemtypes.pm Removed the sql code from Itemtypes.pm and replaced it with DBIx database query in the itemtypes.pl administrative script Test plan: 1. In the staff interface, stage and manage MARC records for import 2. Try to delete an itemtype. If there are items of that itemtype in the database then a message telling you the number of items of that itemtype there are will be displayed. 3. Record that number 4. View the admin/itemtpes.pl script and confirm that there is sql code written in this file. 5. Apply this patch 6. View the admin/itemtypes.pl script and observe that there is no sql in this file. There is however DBIx code, for example $schema->resultset('Item')->search({ 'itype' => $itemtype_code} ); which is searching for items with the itype value matching $itemtype_code value. 7. In the staff interface try to delete the same itemtype 8. Record the number of items there are with that itemtype in the resulting message 9. The numbers recorded in steps 3 and 8 should match showing that the DBIx code is working as intended Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:08:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:08:16 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59565|0 |1 is obsolete| | --- Comment #14 from Owen Leonard --- Created attachment 59657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59657&action=edit [SIGNED-OFF] Bug 17944 - Tidied the DBIx code in itemtypes.pl Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:08:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:08:37 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:19:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:19:39 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59576|0 |1 is obsolete| | --- Comment #13 from Owen Leonard --- Created attachment 59658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59658&action=edit [SIGNED-OFF] Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:19:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:19:36 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 17:32:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 16:32:00 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #10 from Owen Leonard --- What is the test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:13:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:13:17 +0000 Subject: [Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:13:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:13:19 +0000 Subject: [Koha-bugs] [Bug 16115] JavaScript error on item search form unless NOT_LOAN defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16115 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59396|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 59659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59659&action=edit [SIGNED-OFF] Bug 16115: Remove JS error on item search if LOC does not exist If LOC is not present, the item search form will raise a JS error: SyntaxError: expected expression, got '}' This patch fixes it by handling this specific case. Note that the "Status" column is still displayed. Test plan: Remove your LOC authorised values Go on the item search form => You will not get the JS error and the "Status" bloc is no longer displayed. There is no need to display it if empty. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:19:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:19:20 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:19:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:19:33 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59260|0 |1 is obsolete| | --- Comment #355 from Owen Leonard --- Created attachment 59660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59660&action=edit [SIGNED-OFF] Bug 7143: Replace Santallan by Santellan Missed one typo in about.tt. Can go along with the next patch here. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:31:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:31:36 +0000 Subject: [Koha-bugs] [Bug 18004] Koha don't add authority id that exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004 --- Comment #2 from angelo --- (In reply to Marcel de Rooy from comment #1) > Please describe in more detail what you are doing exactly. When we do a search of authority in field 701 and select that authority it is not added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:32:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:32:16 +0000 Subject: [Koha-bugs] [Bug 18004] Koha don't add authority id that exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004 --- Comment #3 from angelo --- (In reply to Marcel de Rooy from comment #1) > Please describe in more detail what you are doing exactly. When we do a search of authority in field 701 and select that authority it is not added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:32:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:32:30 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:32:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:32:33 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59183|0 |1 is obsolete| | --- Comment #21 from Owen Leonard --- Created attachment 59661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59661&action=edit [SIGNED-OFF] Bug 15584 - Staff client list errors are incorrectly styled To Test- 1. In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that it has some red in it like an error 2. apply patch 3. In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that now it should be just yellow with black writing as an alert Signed-off-by: Mirko Tietgen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:33:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:33:31 +0000 Subject: [Koha-bugs] [Bug 18004] Koha don't add authority id that exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004 --- Comment #4 from angelo --- When we do a search of authority in field 701 or 702 and select that authority it is not added in field 701 create another authority ID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:35:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:35:53 +0000 Subject: [Koha-bugs] [Bug 18004] Koha don't add authority id that exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18004 --- Comment #5 from angelo --- When we do a search of authority in field 701 and select that authority it is not added(In reply to Marcel de Rooy from comment #1) > Please describe in more detail what you are doing exactly. When we do a search of authority in field 701 and select that authority it is not added, instead it creates another authority ID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:36:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:36:13 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 --- Comment #22 from Owen Leonard --- I think it's not necessary, from the point of view of the librarian, to have a visual distinction between an error which requires action (like confirmation) and an error which indicates that something failed. I think this patch is the correct solution, but I know not everyone agrees. If you think this should be discussed further I'm okay with moving this to 'In discussion.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 18:45:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 17:45:01 +0000 Subject: [Koha-bugs] [Bug 16282] Usernames should be case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282 --- Comment #9 from Owen Leonard --- (In reply to M. Tompsett from comment #8) > WHERE BINARY? This is a MySQL-ism, is it not? Is it? Anyone able to point to documentation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 21:31:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 20:31:20 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #9 from Liz Rea --- Hi, I thought this was the problem too - but there is another problem. Sessions created for the LDAP created user hijack any sessions from the same IP, including staff ones. I don't think of it as a separate bug - I think symptoms of the same problem. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 30 22:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 30 Jan 2017 21:08:46 +0000 Subject: [Koha-bugs] [Bug 17978] Circ rules will not limit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Viccy Kemp changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victoria.kemp at flower-mound. | |com --- Comment #7 from Viccy Kemp --- Flower Mound Public Library can verify this is, in fact, happening. I have a hold limit placed of one particular item type, but the same card is able to place multiple holds. This is a real problem because we do not want patrons checking out more than one of our STEM kits at a time or placing holds on all of them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 02:04:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 01:04:28 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17905 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 03:31:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 02:31:34 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #10 from Liz Rea --- Actually never mind, this sessions thing is a problem generally with plack, with or without LDAP. I only wish I had submitted my identical patch 2 weeks ago >.< Thanks for fixing this, Dobrica! Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 03:33:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 02:33:26 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 03:33:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 02:33:30 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59644|0 |1 is obsolete| | --- Comment #11 from Liz Rea --- Created attachment 59662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59662&action=edit y# Attachment to Bug 17775 - Add new user with LDAP not works under Plack Bug 17775 - Add new user with LDAP not works under Plack This patch fixes internal server error: Undefined subroutine &C4::Auth_with_ldap::AddMember called at /srv/koha_ffzg/C4/Auth_with_ldap.pm line 213. It occurs only under plack, and it's strange since C4::Members does EXPORT AddMember and we are importing it into Auth_with_ldap.pm (and it does work under CGI). Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 07:13:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 06:13:44 +0000 Subject: [Koha-bugs] [Bug 16282] Usernames should be case sensitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16282 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #10 from M. Tompsett --- (In reply to Owen Leonard from comment #9) > (In reply to M. Tompsett from comment #8) > > > WHERE BINARY? This is a MySQL-ism, is it not? > > Is it? Anyone able to point to documentation? https://dev.mysql.com/doc/refman/5.7/en/cast-functions.html I can't find such a casting name for postgres sqlite or other SQLs. Though, I could be wrong. Which is why I was asking for confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 07:37:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 06:37:38 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #120 from M. Tompsett --- (In reply to Alex Buckley from comment #117) > Regarding the onshelfholds logic, I suggest we leave that to be fixed in bug > 17955 which I am also currently working on as I am removing the SQL code > which forms a big portion of the onshelfholds code in the onboarding.pl > script and reworking it to use DBIx. I'm wondering if the wrong thing is being accessed. I was reading updatedatabase.pl around 3.19.00.017's update. The drop down list you give makes me think of the variable opac items holds. I'd personally prefer the functionality clean up (does it actually generate valid values to go in the right place) here. You can do the code clean up (DBIx, making the gui pretty, etc) there. Sorry, I just got my xenial up again to retest and ran out of time. I'll aim for 12 hours from now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:23:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:23:28 +0000 Subject: [Koha-bugs] [Bug 18007] Interface updates to notices and notice previews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17961 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:23:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:23:28 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18007 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 [Bug 18007] Interface updates to notices and notice previews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:31:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:31:46 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:44:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:44:00 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > We discussed if it also happens when you delete the last added borrower and > then restart - not sure what the answer was. Indeed this is a case that sucks as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:51:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:51:14 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #12 from Jonathan Druart --- Having a quick look at C4::Auth_with_ldap I am pretty sure there are other bugs under plack. Variable scoping in this module is very bad, have a look at $ldap, $prefhost, $base,... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:51:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:51:32 +0000 Subject: [Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Population of Authority 001 |bulkmarcimport.pl: Should |is inconsistent |we move the old 001 to 035 | |? Depends on| |18014 --- Comment #4 from Marcel de Rooy --- (In reply to David Gustafsson from comment #3) > I have also encountered this issue. I'm tempted to have the opinion that it > should be enforced that "(003)001" is moved to 035$a (if 001 is not already > the internal koha id) on import since I interpret this behavior as being > part of the MARC standard. At least it should be an option. Was thinking > about adding this in the form of a custom script (-custom), but really think > it should be added into the default logic. Report 18014 now deals consistenly with field 001. The suggested change for bulkmarcimport.pl could be done on this report ? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 [Bug 18014] AddAuthority should respect AUTO_INCREMENT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:51:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:51:32 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:52:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:52:04 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:52:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:52:07 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #1 from Marcel de Rooy --- Created attachment 59663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59663&action=edit Bug 18014: General update of AuthoritiesMarc.t Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:52:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:52:11 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #2 from Marcel de Rooy --- Created attachment 59664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59664&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:52:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:52:15 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #3 from Marcel de Rooy --- Created attachment 59665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59665&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:56:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:56:13 +0000 Subject: [Koha-bugs] [Bug 12734] Authority 001 should be set to authid in AddAuthority() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12734 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|REOPENED |RESOLVED --- Comment #4 from Marcel de Rooy --- Closed in favor of bug 18014 and bug 12722 *** This bug has been marked as a duplicate of bug 18014 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:56:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:56:13 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from Marcel de Rooy --- *** Bug 12734 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:56:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:56:24 +0000 Subject: [Koha-bugs] [Bug 12734] Authority 001 should be set to authid in AddAuthority() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12734 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:59:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:59:23 +0000 Subject: [Koha-bugs] [Bug 18013] acqui/transferorder.pl typo in find method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:59:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:59:26 +0000 Subject: [Koha-bugs] [Bug 18013] acqui/transferorder.pl typo in find method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59645|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 59666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59666&action=edit Bug 18013 - acqui/transferorder.pl typo in find method This typo was introduced in Bug 13726 and has obvious fix Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:59:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:59:41 +0000 Subject: [Koha-bugs] [Bug 18013] acqui/transferorder.pl typo in find method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13726 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 09:59:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 08:59:41 +0000 Subject: [Koha-bugs] [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 [Bug 18013] acqui/transferorder.pl typo in find method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:00:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:00:13 +0000 Subject: [Koha-bugs] [Bug 18013] acqui/transferorder.pl typo in find method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:05:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:05:43 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59663|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 59667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59667&action=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:05:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:05:46 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59664|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 59668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59668&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:05:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:05:50 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59665|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 59669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59669&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:09:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:09:18 +0000 Subject: [Koha-bugs] [Bug 18016] C4::Auth_with_ldap:: ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I guess diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm index a58f4e6..8a69d97 100644 --- a/C4/Auth_with_ldap.pm +++ b/C4/Auth_with_ldap.pm @@ -350,6 +350,9 @@ sub update_local { my $borrowerid = shift or croak "No borrowerid"; my $borrower = shift or croak "No borrower record"; + for my $field ( qw( dateofbirth dateenrolled dateexpiry debarred sms_provider_id guarantorid ) ) { + delete $borrower->{$field} unless $borrower->{$field}; + } my @keys = keys %$borrower; my $dbh = C4::Context->dbh; Should fix this issue, but I am not able to test. I am also wondering if it would not be better to call ModMember. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:12:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:12:10 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12722, 8579 --- Comment #13 from Marcel de Rooy --- I added report 18014 to solve the problem of reusing authid's after deleting the last record. (In that regard also adding 12722 for adjusting bulkmarcimport and 8579 for a maintenance script.) Status in the current stage is now: NSO Bug 17950: Tiny improvements on Merge.t NSO Bug 17980: Fixing ModZebra calls in AuthoritiesMarc NSO Bug 18014: Fix AddAuthority SO Bug 16018: Merge.pl does not update biblios linked to the old authority So please help by adding your signoff on those three OR QAing the last one ! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579 [Bug 8579] Need script for updating authority 001s https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:12:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:12:10 +0000 Subject: [Koha-bugs] [Bug 8579] Need script for updating authority 001s In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8579 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:12:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:12:10 +0000 Subject: [Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:13:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:13:11 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:13:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:13:14 +0000 Subject: [Koha-bugs] [Bug 18005] Pagination of the search result displayed wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59642|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59670&action=edit Bug 18005: Re-styled pagination on search results with Bootstrap Test plan: 0. Don't apply path 1. Make catalogue search in staff client with more then 20 results, scroll down to see that pagination is broken 2. Apply the patch 3. Make similar search and confirm, the pagination looks OK with new style Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:21:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:21:09 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.09 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:24:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:24:46 +0000 Subject: [Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 --- Comment #32 from Mason James --- Pushed to 16.05.x, for 16.05.09 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:27:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:27:21 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17986 Blocks|17986 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 [Bug 17986] Perl dependency evaluation incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:27:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:27:21 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17880 Depends on|17880 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 [Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:28:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:28:25 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 --- Comment #23 from Mason James --- Pushed to 16.05.x, for 16.05.09 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:28:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:28:43 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #37 from Jonathan Druart --- I personally think that the tests I have provided (6 months ago because it was critical) cover the changes made by this patchset. They test C4::Serials::GetSerialInformation, which is the only call to C4::Items::PrepareItemrecordDisplay (in modules). I do not see the point to struggle to cover and highlight the change made to this ugly subroutine when my 10 lines test do it properly and widely. Critical one, data loose, waiting for 1 year and a half, I do not think it the kind of bugs we need to think to much when we have a solution already. Switching back to Needs Signoff, a rebased version is coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:29:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:29:09 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:29:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:29:13 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53456|0 |1 is obsolete| | Attachment #53457|0 |1 is obsolete| | Attachment #53458|0 |1 is obsolete| | Attachment #53459|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 59671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59671&action=edit Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:29:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:29:18 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #39 from Jonathan Druart --- Created attachment 59672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59672&action=edit Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying with each new edit, losing the previous effort. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:29:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:29:22 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #40 from Jonathan Druart --- Created attachment 59673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59673&action=edit Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:29:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:29:27 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #41 from Jonathan Druart --- Created attachment 59674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59674&action=edit Bug 15030: Add tests This test will prevent regression on the lost of data when items.itemcallnumber is linked with a plugin. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:35:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:35:14 +0000 Subject: [Koha-bugs] [Bug 18017] New: [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Bug ID: 18017 Summary: [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This is a unimarc bug only: When importing biblios from Z39.50, related authorities are wrong matched by the linker. This causes duplicates of authorities. The problem come from a bad marc definition in unimarc/authorities/authority-koha-indexdefs.xml which does not create a index for matching an entire heading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:35:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:35:40 +0000 Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |alex.arnaud at biblibre.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:38:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:38:52 +0000 Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #1 from Alex Arnaud --- Created attachment 59675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59675&action=edit Bug 18017 - add index_matching_heading to create indexes for matching an entire authority heading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:39:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:39:14 +0000 Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:42:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:42:12 +0000 Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:51:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:51:52 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #50 from Jonathan Druart --- I'd like to get feedbacks about these few questions: 1. Maybe the pref AllowIssueNotes should be renamed AllowCheckoutNotes? 2. Does everybody think that "PATRON_NOTE" template code is meaningful enough? (In reply to Jonathan Druart from comment #41) > Aleisha, it seems that your last patch kept the 2 subroutines in C4::Items. > Since you are not using them, you can remove them. Note that this is still valid, C4::Circulation::GetItemIssues is readded by your patch whereas it has been removed by bug 17679. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:54:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:54:59 +0000 Subject: [Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17986 Depends on|17986 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 [Bug 17986] Perl dependency evaluation incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 10:54:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 09:54:59 +0000 Subject: [Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17880 Blocks|17880 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880 [Bug 17880] C4::Installer::PerlModules lexicographical comparison is incorrect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:05:23 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:05:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:05:26 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59649|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 59676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59676&action=edit Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. Test plan: - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - Have two items for a record. Check out one - Set 7 - Not for loan: "Not For Loan" for the second item - Try to place a hold. Does not work. - Apply the patch - Try to place a hold. Should work now. Signed-off-by: Claire Gravely Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:06:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:06:54 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15534 Severity|normal |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Must be backported to 16.11 and 16.05 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:06:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:06:54 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:21:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:21:14 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart --- Can I suggest to create a method in Koha::ItemType (something like ->is_used), which would return Koha::Items->search({ itype => $itemtype_code })->count + Koha::Biblioitems->search({ itemtype => $itemtype_code })->count That way we could provide tests for this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:23:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:23:31 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:23:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:23:36 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59575|0 |1 is obsolete| | Attachment #59658|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 59677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59677&action=edit Bug 17334- Added a timestamp to the members-update.tt To show the user when the pending modifications were requested. Test plan: 1.Log into OPAC and click on Lists->Your Lists->your personal details 2. Change/add a value in that form 3. Select the 'Submit update request' 4. Log into the Koha staff interface, then go to the url: cgi-bin/koha/members/members-update.pl 5. You will see near the top of each box containing a pending request the following are displayed: surname, firstname, patron category, branch, and cardnumber but no timestamp. 6. Apply this patch 7. Repeat steps 1,2, 3, 4 8. You will now see timestamp in the format "Requested: YYYY-MM-DD HH:MM:SS" next to each patrons details near the top of each pending request box. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:23:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:23:40 +0000 Subject: [Koha-bugs] [Bug 17334] members-update.pl should show timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17334 --- Comment #15 from Jonathan Druart --- Created attachment 59678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59678&action=edit Bug 17334: Format the date according to the system preference - Use KohaDates TT plugin to format the date correctly - Do not use a temporary variable - Replace: patron's info Requested: Datetime with patron's info - Requested on Datetime Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:25:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:25:45 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:26:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:26:39 +0000 Subject: [Koha-bugs] [Bug 18015] On shelf holds allowed > "If all unavailable" ignores notforloan In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18015 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:28:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:28:00 +0000 Subject: [Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 --- Comment #5 from David Gustafsson --- Seems like Koha keeps the old 001 though, (instead of replacing it with the local koha id). So if that it the also copying it to 035a is a bit confusing. So not really sure how to tackle this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:29:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:29:56 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 [Bug 15584] Staff client list errors are incorrectly styled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:29:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:29:56 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:30:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:30:31 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:30:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:30:36 +0000 Subject: [Koha-bugs] [Bug 15584] Staff client list errors are incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15584 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59661|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 59679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59679&action=edit Bug 15584 - Staff client list errors are incorrectly styled To Test- 1. In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that it has some red in it like an error 2. apply patch 3. In the Staff Client, go to Lists (/cgi-bin/koha/virtualshelves/shelves.pl) and create a new list with the same name as an existing one. --note that now it should be just yellow with black writing as an alert Signed-off-by: Mirko Tietgen Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:35:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:35:35 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 [Bug 18014] AddAuthority should respect AUTO_INCREMENT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:35:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:35:35 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:38:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:38:05 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #42 from Katrin Fischer --- (In reply to Jonathan Druart from comment #37) > I personally think that the tests I have provided (6 months ago because it > was critical) cover the changes made by this patchset. > > They test C4::Serials::GetSerialInformation, which is the only call to > C4::Items::PrepareItemrecordDisplay (in modules). > I do not see the point to struggle to cover and highlight the change made to > this ugly subroutine when my 10 lines test do it properly and widely. > > Critical one, data loose, waiting for 1 year and a half, I do not think it > the kind of bugs we need to think to much when we have a solution already. > > Switching back to Needs Signoff, a rebased version is coming. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:53:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:53:10 +0000 Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:53:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:53:15 +0000 Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59377|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 59680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59680&action=edit Bug 17610 - Allow the number of plack workers and max connections to be set in koha-conf.xml It would be nice if we could control the number of workers and max requests on a per instance basis, rather than the numbers being hardcoded in the plack startup script. Test Plan: 1) Build a new package of Koha with this patch applied ; ) 2) Verify koha-plack still works 3) Add the following to the config section of your koha-conf.xml: 75 4 4) Stop plack 5) Start plack 6) Verify the number of works and max requests worked! Signed-off-by: Kyle M Hall Signed-off-by: Larry Baerveldt Signed-off-by: Tomas Cohen Arazi Rebased against master and added a description for the new configuration entries Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 11:58:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 10:58:49 +0000 Subject: [Koha-bugs] [Bug 18016] C4::Auth_with_ldap:: ldap_entry_2_hash inserts 0000-00-00 for invalid dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016 --- Comment #2 from Dobrica Pavlinusic --- Seems good, but would it better to do dt_from_string on them to verify they are also valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:03:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:03:50 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #25 from Mirko Tietgen --- Created attachment 59681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59681&action=edit update control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:06:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:06:40 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #26 from Mirko Tietgen --- Created attachment 59682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59682&action=edit Bug 17111: Update control file for 16.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:06:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:06:58 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59681|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:07:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:07:22 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:12:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:12:36 +0000 Subject: [Koha-bugs] [Bug 18018] New: WWW:CSRF is missing in PerlDependencies.pm Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 Bug ID: 18018 Summary: WWW:CSRF is missing in PerlDependencies.pm Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org WWW:CSRF is missing in PerlDependencies.pm and so libwww-csrf-perl is missing in PerlDependencies.pm missing in debian/control. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:13:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:13:28 +0000 Subject: [Koha-bugs] [Bug 5905] Biblibre, Partial fine payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5905 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:14:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:14:45 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 --- Comment #1 from Mirko Tietgen --- Created attachment 59683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59683&action=edit Bug 18018 - WWW:CSRF is missing in PerlDependencies.pm WWW:CSRF is missing in PerlDependencies.pm and so libwww-csrf-perl is missing in PerlDependencies.pm missing in debian/control. This patch adds both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:15:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:15:05 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |17111 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:15:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:15:05 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 13:19:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 12:19:07 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 14:08:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 13:08:23 +0000 Subject: [Koha-bugs] [Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 --- Comment #6 from Marcel de Rooy --- (In reply to David Gustafsson from comment #5) > Seems like Koha keeps the old 001 though, (instead of replacing it with the > local koha id). So if that it the also copying it to 035a is a bit > confusing. So not really sure how to tackle this one. Please have a look at bug 18014. Now Koha always stores the local id into 001. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 14:09:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 13:09:16 +0000 Subject: [Koha-bugs] [Bug 16733] More flexible paths in debian scripts (for dev installs) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16733 --- Comment #34 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #33) > Guys, this patchset broke kohadevbox. It is probably an integration issue, > but as dev_install is not present I would expect it to use the package's > paths, and instead of that it just breaks. Yes, that should be. Will have a look too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 14:20:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 13:20:07 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:05:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:05:50 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #13 from Dobrica Pavlinusic --- (In reply to Liz Rea from comment #9) > Hi, > I thought this was the problem too - but there is another problem. Sessions > created for the LDAP created user hijack any sessions from the same IP, > including staff ones. I don't think of it as a separate bug - I think > symptoms of the same problem. > > Cheers, > Liz Liz, can you expand on this a little bit more? I know that login into OPAC or Intranet will be transferred between then (so if you login into intranet you will also be logged into opac). Is that what you are having problem with? This behavior is because we are registering cookies on hostname (whole hostname) so if OPAC and intranet are on the same hostname (but different path or ports) they will share session. If they are on different hostnames, they will not share sessions. Does this make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:07:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:07:16 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #14 from Dobrica Pavlinusic --- (In reply to Jonathan Druart from comment #12) > Having a quick look at C4::Auth_with_ldap I am pretty sure there are other > bugs under plack. Variable scoping in this module is very bad, have a look > at $ldap, $prefhost, $base,... Yes, it's very bad code but we haven't hit any bugs in it (yet) and we'll need to rewrite it for DBIx anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:43:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:43:36 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting Authority record tag does not update bibliographic marc record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 --- Comment #4 from Marcel de Rooy --- Created attachment 59685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59685&action=edit Bug 14026: Extend sub merge to remove fields for deleted authorities In order to accomplish this, we need to add some additional checks in the merge routine. The actual change to remove the field, is quite small. Furthermore, we need to add a merge call in DelAuthority and adjust the merge cron job accordingly. The change is well supported by additional tests, including a simulation of postponed removal via cron, if dontmerge is enabled. Test plan: [1] Run t/db_dependent/Authorities/Merge.t [2] Look for an authority with a few linked biblios. Delete this authority: the quickest way currently is URL manipulation: /cgi-bin/koha/authorities/authorities-home.pl?op=delete&authid=[XXX] Now check the biblio records; the link should be removed. Note: Since merge can handle deleting authorities now, we could consider adding the option 'Delete' on the Actions menu for authorities having linked biblios. The delete action also needs CSRF protection. Both should be handled on new reports. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:43:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:43:32 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting Authority record tag does not update bibliographic marc record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 --- Comment #3 from Marcel de Rooy --- Created attachment 59684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59684&action=edit Bug 14026: First expose the problem in Merge.t Adding a test where we delete an authority and prove that the linked biblio still contains a reference to it. Test plan: [1] Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:44:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:44:32 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting authority record does not update biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Deleting Authority record |Deleting authority record |tag does not update |does not update biblio |bibliographic marc record |records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:44:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:44:40 +0000 Subject: [Koha-bugs] [Bug 17288] Advanced Editor - Rancor - Helpers for 006 and 007 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17288 --- Comment #11 from H?ctor Eduardo Castro Avalos --- (In reply to Owen Leonard from comment #10) > What is the test plan for this? Hi Owen, please follow the first commit by Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:44:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:44:52 +0000 Subject: [Koha-bugs] [Bug 17950] Small improvements for Merge.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 [Bug 14026] Deleting authority record does not update biblio records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:44:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:44:52 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting authority record does not update biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 [Bug 17950] Small improvements for Merge.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:48:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:48:06 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting authority record does not update biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:53:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:53:41 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting authority record does not update biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:56:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:56:06 +0000 Subject: [Koha-bugs] [Bug 14026] Deleting authority record does not update biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14026 --- Comment #5 from Marcel de Rooy --- (In reply to Joy Nelson from comment #0) > When an authority record that is linked to a bibliographic record has a > subfield *deleted*, that deleted tag is *not* deleted from the linked > bibliographic record(s). note: edits and additions are reflected in the > linked bibliographic records. only deletions are not. Joy: This subfield deletion problem is already fixed on bug 17913, patch Do not keep a cleared subfield in loose merge mode. When I glanced through this report, I had a fix for deleting the complete authority record in mind. And so that should be fixed now too.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 15:57:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 14:57:44 +0000 Subject: [Koha-bugs] [Bug 17913] Merge three authority merge fixes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 --- Comment #71 from Marcel de Rooy --- Katrin: Better add the syspref.sql addition too in the dbrev, although it technically speaking is not a must.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 16:13:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 15:13:50 +0000 Subject: [Koha-bugs] [Bug 18020] New: Self-Checkout Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18020 Bug ID: 18020 Summary: Self-Checkout Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: koha.stjernepost at gmail.com QA Contact: testopia at bugs.koha-community.org Hei Jeg har en forbedring til Koha, og selvbetjetnsystemet! Det burde v?rt s?nn at man skannet kortet sitt ogs? kom det opp en rute over hva man har p? l?n og et input omr?de hvor man kan skanne inn materialer ogs? ser systemet om man har det p? l?n, i s? fall leverer det det og gir en melding om hvor det skal st?, eller hvis det er til utl?n l?ner det det ut til l?neren! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 16:51:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 15:51:50 +0000 Subject: [Koha-bugs] [Bug 15503] Grab Item Information from Order Files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 --- Comment #68 from Benjamin Daeuber --- After doing this again with a few records, most fields appear to be mapping correctly now. The two issues are: 1. For items that have been imported, the non-public notes for each appears correctly on the bibliographic record details screen, but appear blank on the item edit screen. Additionally, updating the note doesn't appear to update the bib details screen. From what we can tell, this is only for imported records. 2. The source of acquisitions is blank. I'm fairly sure that was populating before the latest patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 16:59:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 15:59:28 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 59686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59686&action=edit Bug 13757: (regression tests) Empty attributes should delete existing This patch introduces tests for the required functionality. To test: - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => FAIL: The current code doesn't work like that Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 16:59:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 15:59:33 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 59687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59687&action=edit Bug 13757: Make Koha::Patron::Modification->store del empty attrs This patch makes Koha::Patron::Modification->store delete the passed attributes that contain empty values. This is the way it currently works, as all opac-editable attributes are presented to the end-user and they are allowed to delete them, and the best way I found to represent the deletion on the modification request is by setting it to the empty string. I chose this way because it is how the staff interface handles it, so it is consistent. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Patron/Modifications.t => SUCCESS: This time tests pass! - Verify comment #70 on the bug is fixed now - Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 16:59:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 15:59:36 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 59688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59688&action=edit Bug 13757: (QA followup) Make opac-memberentry.pl handle attrs deletion The original code on this bug skipped empty-valued attributes. But emptying attributes is the only way to tell the controller script that the user wants to delete them. This patch makes opac-memberentry.pl check the existence of attributes sharing the code of the empty for the given patron, and it stores the deletion on the Koha::Patron::Modification as needed. Otherwise deletions got skipped. To test: - Verify setting/deleting attributes that are opac-editable and verify the results are sound. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 17:00:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 16:00:11 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 17:25:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 16:25:05 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #42 from J Schmidt --- Testing again. 1/31/2016. Here are the steps taken: 1.) Went to Koha Admin > modified the dateFormat preference (I18N/L10N) from dd/mm/yyyy to mm/dd/yyyy. Saved. 2.) Went to Tools > Discrete Calendar 3.) Selected December 2nd, 2016. The dialog box to "add new holiday" appears. 4.) I left the "To date:" blank. Date type: fixed. Open hours: 08:00:00 to Close hours: 19:45:00. Kept the "Edit selected dates" and clicked. Save. 5.) The new calendar "holiday" is placed on the right as an entry. However, there are no times displaying. Only the date displays. Is the time desired here as well? 6.) Clicked on 1/1/2017 to insert another "holiday". 7.) Parameters filled in this time were: To date: 01/15/2017. Title: Sundays Limited Hours. Date type: Weekly; Open hours: 08:00:00 - 12:30:00. I chose Copy calendar to another branch: Gammatron College. I clicked Save. That did not seem to work. No new holiday was added under the Alphaville branch calendar area OR under the Gammatron branch calendar page. 8.) To confirm this I went to Set library > Choose library as Gammatron College. When I went to look at Gammatron College's calendar being a Gammatron College staffer, the weekly Sundays limited hours was not listed there. 9.) Changing to Alphaville. I create another calendar entry under Alphaville that is for "Sunday limited hours." It's a weekly event with set hours for 1/1/2017-1/15/2017. I leave the "Edit selected dates and click Save and it is there. appearing under this branch's calendar events. 10.) I click on January 16, 2017 because it is earlier than today. I'm in the Alphaville branch's calendar area. The "Add new holiday" box comes up. I do not add any date/times into this box but simply click the "Copy calendar to another branch" option, choose Gammatron College, and click Save. Now I move to the Gammatron College branch but I do not see two entries from Alphaville's calendar under Gammatron's calendar. I am hoping to see the Sundays limited hours entry I created.. 11.) It seems you have to first create an entry in one calendar and save it before you are able to copy it to another branch's calendar but it also seems you end up recreating the new holiday entry for that branch anyway. 12.) I went into Alphaville and clicked on Jan 5, 2016. I created a new calendar event to test the "Normal" date types. After entering in information in the dialog box and leaving Edit selected dates as is, then Save. the calendar would not save the new holiday entry to the default branch's calendar area. So Normal date types might not work. After clicking save when trying to fill in a "Normal date type" it moved me over to Gammatron College's calendar area. 13.) I used the drop down to return to Alphaville's calendar area. I clicked on 1/5/2016 and was prompted with the new holiday entry dialog box. This time I say from 1/5/2016 to 1/5/2016 (same day) and I made the Date type Exception. (I filled in the other boxes for title and hours....Upon clicking save, it jumped me over to Gammatron College's calendar (that's which library my log in is set to by the way)... The new calendar entry is not under Gammatron College's area OR under Alphaville. 14.) I change my log home branch now. I set the library BACK to be Alphaville. Submit. 15.) I look under Alphaville's calendar area but my previously attempted calendar entries are still not there. They are also not under Gammatron College's calendar area. 12.) From my testing, it saves new holiday entries for any branch but not all date types work. I find that the Normal and weekly work but not the others. I am also not able to copy the calendar to another branch. I was using Chrome. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 17:35:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 16:35:12 +0000 Subject: [Koha-bugs] [Bug 6514] Save book price in different currencies (cataloging) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6514 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:10:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:10:11 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in Assignee|koha-bugs at lists.koha-commun |indradg at l2c2.co.in |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:20:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:20:12 +0000 Subject: [Koha-bugs] [Bug 17610] Allow the number of plack workers and max connections to be set in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:36:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:36:00 +0000 Subject: [Koha-bugs] [Bug 17950] Small improvements for Merge.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59397|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 59689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59689&action=edit Bug 17950: Improve quick UNIMARC fix in Merge.t Bug 17909 and 17913 added a quick fix for Merge.t on UNIMARC records. This patch improves that fix with the sub compare_fields, a merge from compare_field_count and compare_field_order. Also it adds the option to test MARC21/UNIMARC by adding a command line switch that triggers mocking the marcflavour preference. The test on a cleared field 609 in strict mode has been broken up in two tests: first a count without 609 and then counting 609s only. Note: Could have mocked GetMarcBiblio too, but decided to go this way. Test plan: [1] Run perl t/db_dependent/Authorities/Merge.t [2] (For UNIMARC users:) Run perl Merge.t -flavour MARC21 [3] (For others:) Run perl Merge.t -flavour UNIMARC Signed-off-by: Marcel de Rooy NOTE: prove -v t/db_dependent/Authorities/Merge.t :: -flavor {flavour} Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:36:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:36:09 +0000 Subject: [Koha-bugs] [Bug 17950] Small improvements for Merge.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59399|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 59690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59690&action=edit Bug 17950: Merge.t: Improve variable handling at top level This patch does: [1] Remove unused $dbh. [2] Move all mocking statements to one sub. [3] Promote a few lexicals to globals when used in the subtests. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:37:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:37:25 +0000 Subject: [Koha-bugs] [Bug 17950] Small improvements for Merge.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Signed Off --- Comment #8 from M. Tompsett --- No need to run perl {testfile} you can use :: to pass parameters to the test file. $ prove -v t/db_dependent/Authorities/Merge.t :: -flavor {flavour} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:37:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:37:52 +0000 Subject: [Koha-bugs] [Bug 18021] New: Confirming each loan when going beyond the limit of loans Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18021 Bug ID: 18021 Summary: Confirming each loan when going beyond the limit of loans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, We have a request here since some time about the system asking a confirmation for a loan just after it was scanned and when a person takes a number of loans higher than the permitted limit. For example : If the rule is 3 DVD maximum but a teacher ask to take 15 of them, the librairian must confirm all of them beyond the third and it takes some time to do the operation. I'm wondering if we can have only one warning for a transaction (as a reminder). Thanks again, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:47:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:47:51 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #27 from M. Tompsett --- Comment on attachment 59682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59682 Bug 17111: Update control file for 16.05 Review of attachment 59682: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17111&attachment=59682) ----------------------------------------------------------------- Eyeball'd through the changes. ::: debian/control @@ +12,4 @@ > Build-Depends: libalgorithm-checkdigits-perl, > libanyevent-http-perl, > libanyevent-perl, > + libarchive-extract-perl, Needed by plugins. @@ +16,5 @@ > libarchive-zip-perl, > libauthen-cas-client-perl, > libbiblio-endnotestyle-perl, > libbusiness-isbn-perl, > + libbytes-random-secure-perl, Needed by Koha::Token. @@ +54,4 @@ > libfile-slurp-perl, > libfont-ttf-perl, > libgd-barcode-perl, > + libgd-perl, Actual package for which the old entry were both virtual package wrappers. @@ +82,4 @@ > libmodern-perl-perl, > libmodule-bundled-files-perl, > libmodule-load-conditional-perl | perl-modules, > + libmodule-pluggable-perl, Needed by plugins, Koha::SuggestionEngine, and Koha::RecordProcessor. @@ +133,4 @@ > liburi-perl, > libuuid-perl, > libwww-perl, > + libwww-youtube-download-perl, Needed by C4::HTML5Media -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:51:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:51:11 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #28 from M. Tompsett --- Comment on attachment 59682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59682 Bug 17111: Update control file for 16.05 Review of attachment 59682: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17111&attachment=59682) ----------------------------------------------------------------- Eyeball'd through the changes. ::: debian/control @@ +12,4 @@ > Build-Depends: libalgorithm-checkdigits-perl, > libanyevent-http-perl, > libanyevent-perl, > + libarchive-extract-perl, Needed by plugins. @@ +16,5 @@ > libarchive-zip-perl, > libauthen-cas-client-perl, > libbiblio-endnotestyle-perl, > libbusiness-isbn-perl, > + libbytes-random-secure-perl, Needed by Koha::Token. @@ +54,4 @@ > libfile-slurp-perl, > libfont-ttf-perl, > libgd-barcode-perl, > + libgd-perl, Actual package for which the old entry were both virtual package wrappers. @@ +82,4 @@ > libmodern-perl-perl, > libmodule-bundled-files-perl, > libmodule-load-conditional-perl | perl-modules, > + libmodule-pluggable-perl, Needed by plugins, Koha::SuggestionEngine, and Koha::RecordProcessor. @@ +133,4 @@ > liburi-perl, > libuuid-perl, > libwww-perl, > + libwww-youtube-download-perl, Needed by C4::HTML5Media @@ -233,5 @@ > libarchive-zip-perl, > libauthen-cas-client-perl, > libbiblio-endnotestyle-perl, > libbusiness-isbn-perl, > - libbusiness-issn-perl, Not used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:55:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:55:46 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:55:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:55:49 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable/16.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59682|0 |1 is obsolete| | --- Comment #29 from M. Tompsett --- Created attachment 59691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59691&action=edit Bug 17111: Update control file for 16.05 https://bugs.koha-community.org/show_bug.cgi?id=17111 NOTE: Correctly adds/removes dependencies in debian/control Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:59:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:59:26 +0000 Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:59:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:59:28 +0000 Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58414|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 59692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59692&action=edit Bug 17792: Introduce Koha::Patron::Attribute(s) This patch introduces stub Koha::Object(s) for handling patron attributes. Edit: amended the POD to fix C&p mistake Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 18:59:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 17:59:35 +0000 Subject: [Koha-bugs] [Bug 17792] Introduce Koha::Patron::Attribute(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17792 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58421|0 |1 is obsolete| | --- Comment #17 from Nick Clemens --- Created attachment 59693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59693&action=edit Bug 17792: Add opac_editable and opac_display methods This patch adds two methods to the Koha::Patron::Attribute: - opac_display - opac_editable Both method just check the corresponding Koha::Patron::Attribute::Type and return the values for those attributes. This is useful to avoid checking that manually on the controller scripts. To test: - Run: $ prove t/db_dependent/Koha/Patron/Attributes.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:00:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:00:22 +0000 Subject: [Koha-bugs] [Bug 17150] Cancelling holds over process needs improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:05:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:05:20 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:05:23 +0000 Subject: [Koha-bugs] [Bug 18018] WWW:CSRF is missing in PerlDependencies.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18018 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59683|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 59694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59694&action=edit Bug 18018 - WWW:CSRF is missing in PerlDependencies.pm WWW:CSRF is missing in PerlDependencies.pm and so libwww-csrf-perl is missing in PerlDependencies.pm missing in debian/control. This patch adds both. NOTE: Tested on top of 17111. Checked ./koha_perl_deps.pl -m -u before and after. Control file eyeballs well. git diff origin/master -- debian/control does not differ in this change. :) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:12:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:12:17 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:12:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:12:19 +0000 Subject: [Koha-bugs] [Bug 18009] IssueSlip.t test fails if launched between 00:00 and 00:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18009 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59629|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 59695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59695&action=edit Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59 to test patch... 1/ set date between 00:00 and 00:59 $ sudo date -s 'Sun Jan 29 00:41:55 NZDT 2017' 2/ run prove, see fail $ prove -v t/db_dependent/Members/IssueSlip.t ... t/db_dependent/Members/IssueSlip.t (Wstat: 65280 Tests: 1 Failed: 0) Result: FAIL 3/ apply patch 4/ run prove, see pass $ prove -v t/db_dependent/Members/IssueSlip.t ... All tests successful. Result: PASS NOTE: for code obscurity you could have also done a modulus 24. ;) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:42:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:42:02 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #8 from M. Tompsett --- Comment on attachment 59669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59669 Bug 18014: AddAuthority should respect AUTO_INCREMENT Review of attachment 59669: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18014&attachment=59669) ----------------------------------------------------------------- ::: t/db_dependent/AuthoritiesMarc.t @@ +201,5 @@ > my $id2 = AddAuthority( $record, undef, 'GEOGR_NAME' ); > + isnt( $id1, $id2, 'Do not return the same id again' ); > + t::lib::Mocks::mock_preference( 'marcflavour', 'UNIMARC' ); > + my $id3 = AddAuthority( $record, undef, 'GEOGR_NAME' ); > + is( $id3 > 0, 1, 'Tested AddAuthority with UNIMARC' ); ok($id3>0,'...') would have been better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:43:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:43:31 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://lists.koha-community | |.org/pipermail/koha-devel/2 | |016-January/042207.html Status|NEW |In Discussion --- Comment #7 from Jonathan Druart --- See also "Merge borrowers and deletedborrowers tables" topic on koha-devel 1 year ago: http://lists.koha-community.org/pipermail/koha-devel/2016-January/042207.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:50:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:50:32 +0000 Subject: [Koha-bugs] [Bug 18003] Should deletedborrowers.borrowernumber be a primary key? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18003 --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #7) > See also "Merge borrowers and deletedborrowers tables" topic on koha-devel 1 > year ago: > http://lists.koha-community.org/pipermail/koha-devel/2016-January/042207.html We don't provide a way to recover a deleted borrower, do we? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:55:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:55:46 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 --- Comment #9 from M. Tompsett --- Comment on attachment 59669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59669 Bug 18014: AddAuthority should respect AUTO_INCREMENT Review of attachment 59669: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18014&attachment=59669) ----------------------------------------------------------------- ::: t/db_dependent/AuthoritiesMarc.t @@ -198,5 @@ > my $record = C4::AuthoritiesMarc::GetAuthority(1); > my $id1 = AddAuthority( $record, undef, 'GEOGR_NAME' ); > DelAuthority( $id1 ); > my $id2 = AddAuthority( $record, undef, 'GEOGR_NAME' ); > - is( $id1, $id2, 'FIXME: Got the same id back, let\'s fix that behavior' ); This should have been isnt in the first place, and the second patch should be expecting a failure. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:57:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:57:10 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:57:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:57:18 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59499|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 59697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59697&action=edit Bug 17932: (followup) Fix /patrons endpoint Bug 17927 introduced data type fixes on the /patrons endpoint (integer and boolean types got fixed). This led to the /patrons endpoint not to work because the underlying code didn't provide the right data. With the introduction of TO_JSON on Koha::Object(s) we now have a way to output the proper data types. This patch does so by: - Adding is_boolean => 1 to the relevant columns on the Borrower.pm schema file. - Tweaking the controller class for the /patrons endpoint so it doesn't use the $object(s)->unblessed call but just let the Mojo::JSON library pick out TO_JSON implementation instead on rendering the output. - It adds a new test for booleans. To test: - Have 17927 applied - Run: $ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail [1] - Apply this patches - Run: $ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! - Sign off! :-D [1] It is self explanatory to just try the API using any of the available tools (I use HttpRequester on Firefox) Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:57:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:57:13 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59498|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 59696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59696&action=edit Bug 17932: Add a TO_JSON method to Koha::Object(s) Bug 17927 fixes data types on the current REST endpoints. If you test those endpoints, you will notice trying to access them (for listing or retrieving single objects yields a data type error. Notably on booleans but also on integers. Integers fail due to https://rt.cpan.org/Ticket/Display.html?id=119904 but it needs some global solution until there's a DBD::mysql release backported to the supported distros. There's the option to use http://search.cpan.org/~frew/DBIx-Class-Helpers-2.033002/lib/DBIx/Class/Helper/Row/NumifyGet.pm to get the integer columns fixed as a workaround: __PACKAGE__->add_columns( borrowernumber => { data_type => 'integer', is_nullable => 0, is_numeric => 1, } ); I didn't find bug reports related to this (maybe because we don't use warnings everywhere) But I don't think is worth going such a heavy overhead. A similar situation takes place for Boolean values. They need to be prepared for JSON output. This could have been done using DBIx filters as pointed out by Martin: __PACKAGE__->filter_column( lost => { filter_to_storage => sub { $_[1] ? 1 : 0 }, filter_from_storage => sub { $_[1] ? Mojo::JSON->true : Mojo::JSON->false } } ); but this could have other consequences that are worth exploring on another bug (i.e. it would mean we need to take care of every place where this boolean data is used/set needs to handle this data types nicely. Such would be the case if we were a Mojo-only app, but we aren't. We use Koha::Obect(s) in the whole app. Period. This patch adds the need to specify on the schema files, columns that are actually boolean, because we have no way to detect them for now (i.e. they are all tinyint, but we use tinyint for non-boolean stuff too). So if this patch is accepted, we would need to specify boolean columns like this: __PACKAGE__->add_columns( '+lost' => { is_boolean => 1 } ); This patch adds a TO_JSON method for Koha::Object(s) to be used for serializing Koha::Object-derived objects into JSON strings. To test it (as Koha::Object(s) need to be instantiated) I provide tests on top of the Koha::Patron(s) classes in the followup patches. [1] Yes, we use TINYINT(1) for booleans, but from DBIC's perspective there's no way to read the (1) in runtime. Sponsored-by: ByWater Solutions Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:57:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:57:25 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59500|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 59698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59698&action=edit Bug 17932: Unit tests This patch adds unit tests for the Koha::Object::TO_JSON function. It tests on top of Koha::Patron as Koha::Object needs to be instantiated. To test: - Apply the patch - Run: $ prove -v t/db_dependent/Koha/Object.t => SUCCESS: New tests for TO_JSON are run and return green. - Sign off :-D Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 19:57:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 18:57:31 +0000 Subject: [Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59501|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 59699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59699&action=edit Bug 17932: (followup) Tidy tests This patch makes the tests create its own data instead of searching the DB for a branchcode and a categorycode. It does so on each subtest, because there shouldn't be side effects between subtests. I also wrapped each subtest inside a transaction, for the same reason. To test: - Apply this patch - Run: $ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests return green with this patch - Sign off :-D Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 20:03:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 19:03:15 +0000 Subject: [Koha-bugs] [Bug 18022] New: Empty barcode causes internal server error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Bug ID: 18022 Summary: Empty barcode causes internal server error Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: ruatuki at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Internal server error The error is Can't use string ("1") as a HASH ref while "strict refs" in use at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 472 to reproduce: 1. Set the CircAutoPrintQuickSlip system preference to "clear the screen." 2. Load a patron's account in circulation. 3. Click the "Checkout" button with an empty barcode field or hit enter. Also reported to exist in 3.22.08 by Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 20:15:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 19:15:13 +0000 Subject: [Koha-bugs] [Bug 12219] Purchase Suggestions branch level permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12219 Indranil Das Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 20:21:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 19:21:10 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59667|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Created attachment 59700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59700&action=edit Bug 18014: General update of AuthoritiesMarc.t Modern::Perl, Koha::Database, etc. Test plan: Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 20:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 19:21:24 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59669|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 59702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59702&action=edit Bug 18014: AddAuthority should respect AUTO_INCREMENT Instead of using the MAX(authid)+1 logic, AddAuthority should just save the record and get the new id. The authid column is an autoincrement. This eliminates problems where a newly assigned authid also refers to a previously deleted record. (And it will not cause problems when refining the dontmerge functionality on report 9988.) Note: ModAuthority also calls AddAuthority to update an existing record; in that case we should not create a new record even if the record should not be found any more (which should be exceptional). This patch also simplifies handling of 001 in the authority record: in all cases this field is updated now; no need to check its contents. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t [2] Add a new authority record via the interface Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 20:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 19:21:18 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59668|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 59701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59701&action=edit Bug 18014: Add test to AuthoritiesMarc.t to expose problem in AddAuthority Since AddAuthority uses max(id)+1 logic to produce the next authid, authority id's will be reused when you delete the last record. This may be a source of problems and will be addressed on the next patch. This patch add a test to expose the problem. Test plan: [1] Run t/db_dependent/AuthoritiesMarc.t Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 20:23:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 19:23:10 +0000 Subject: [Koha-bugs] [Bug 18014] AddAuthority should respect AUTO_INCREMENT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com --- Comment #13 from M. Tompsett --- Didn't test just the first patch by itself, but tested 1&2 together and all three together. That's why I commented like I dd in comment #8 and comment #9. But the end product is good. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 20:57:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 19:57:53 +0000 Subject: [Koha-bugs] [Bug 17996] longoverdue.pl should not set 'datereturned' when --mark-returned option is used. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17996 --- Comment #2 from Barton Chittenden --- In my initial testing, I've found that longoverdue.pl --lost 1=2 --charge=2 --mark-returned --confirm Does indeed check the item in and set old_issues.returndate to NULL, but the item still shows as 'Checked out' on the patron and item circ history. See koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt line 125 125 [% IF issue.returndate %] 126 [% issue.returndate |$KohaDates with_hours => 1 %] 127 [% ELSE %] 128 Checked out 129 [% END %] koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt line 86 86 [% IF ( issue.returndate ) %] 87 [% issue.returndate |$KohaDates with_hours => 1 %] 88 [% ELSE %] 89 Checked out 90 [% END %] ... unfortunately I don't think that it's as simple as adding a test for lost lost status, because it *is* possible for items to be checked out and lost. the underlying problem is that there's an implicit assumption that an item is checked out if either isssues.returndate or old_issues.returndate is NULL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 21:06:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 20:06:36 +0000 Subject: [Koha-bugs] [Bug 18023] New: Add "New from Z39.50" button on search results in Authorities module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18023 Bug ID: 18023 Summary: Add "New from Z39.50" button on search results in Authorities module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Hi, Someone suggest this little enhancement here for Authorities module. 1) Go to Authorities module 2) Make a research on any subject 3) Observe that a results list appears 4) Clic on "details" to see any one authority 5) Observe now the button "New from Z39.50" (with a magnifying glass) which will replace the selected authority It could be easier and faster if we have the button "New from Z39.50" directly on the results list (step 3) this could permit to skip the steps 4 and 5. Thanks again, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 21:35:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 20:35:06 +0000 Subject: [Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #121 from Alex Buckley --- (in reply to M.Tompsett in comment 120) I believe we are starting to scope creep. The purpose of the create circulation rule is simply to display the library, patron category and item type the user created/installed (in drop-down boxes) and then the user can choose 'All' or a specific value and the circulation rule is assigned accordingly. Thus at present the create circulation rule step does what it's supposed to do successfully. Regarding the onshelfholds logic I fixed it up in the bug 17955 (which needs signoff), because some of the sql queries were inserting into the onshelfholds column of the default_branch_circ_rules table (see below) (there is no such column in this table) so I changed the insert to input values into the issuingrules table. 628 my $sth_insert = $dbh->prepare( 629 "INSERT INTO default_branch_circ_rules 630 (branchcode, onshelfholds) 631 VALUES (?, ?)" 632 ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 21:42:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 20:42:34 +0000 Subject: [Koha-bugs] [Bug 17775] Add new user with LDAP not works under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17775 --- Comment #15 from Liz Rea --- Just forget I said anything at all. Patch fixes the issue, and it's quite a bad one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 22:45:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 21:45:39 +0000 Subject: [Koha-bugs] [Bug 18024] New: Adding a "genres and kinds" search in Authorities module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18024 Bug ID: 18024 Summary: Adding a "genres and kinds" search in Authorities module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Another little enhancement for the Authorities module 1) Go to Authorities module 2) Clic on "New from Z39.50" 3) Observe in the search window that we don't have a place to search by genres (novel, science-fiction, roman, poetry, etc.) It will be very convenient if we can have an additionnal search option by literary "genres and kinds" to help target the good records when searching. Then it will find all records with the same authority (zone 155) from the RVML. Thanks again, Alexandre from CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 31 23:04:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Jan 2017 22:04:14 +0000 Subject: [Koha-bugs] [Bug 18025] New: Expired password recovery links cause sql crash Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025 Bug ID: 18025 Summary: Expired password recovery links cause sql crash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Trying to reset a password with an expired token leads to a very user unfriendly sql crash: DBD::mysql::st execute failed: Duplicate entry '19' for key 'PRIMARY' [for Statement "INSERT INTO `borrower_password_recovery` ( `borrowernumber`, `uuid`, `valid_until`) VALUES ( ?, ?, ? )" with ParamValues: 0='19', 1='$2a$08$O8FjE434Ue3DLtGTgQB3Bu', 2='2017-02-02T22:03:01'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '19' for key 'PRIMARY' at /home/vagrant/kohaclone/Koha/Patron/Password/Recovery.pm line 127 We should delete these if they exist, and issue a new token. -- You are receiving this mail because: You are watching all bug changes.