[Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 54532
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54532
Bug 17138 - UpdateFine() modyfies existing fine records even when there is no
need

Review of attachment 54532:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17138&attachment=54532)
-----------------------------------------------------------------

::: C4/Overdues.pm
@@ +574,4 @@
>          # we're updating an existing fine.  Only modify if amount changed
>          # Note that in the current implementation, you cannot pay against an accruing fine
>          # (i.e. , of accounttype 'FU').  Doing so will break accrual.
> +        if ( $data->{'amount'} ne sprintf('%.6f', $amount) ) {

While this does work, would not a compare_numbers($n1,$n2,$accuracy) function
work better? Let's not rely on implicit type conversions for $data->{'amount'}.

-- 
You are receiving this mail because:
You are watching all bug changes.