[Koha-bugs] [Bug 17138] UpdateFine() modyfies existing fine records even when there is no need

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17138

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jacek Ablewicz from comment #9)
> (In reply to M. Tompsett from comment #8)
> > Comment on attachment 54532 [details] [review] [review]
> > Bug 17138 - UpdateFine() modyfies existing fine records even when there is
> > no need
> > 
> > Review of attachment 54532 [details] [review] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: C4/Overdues.pm
> > @@ +574,4 @@
> > >          # we're updating an existing fine.  Only modify if amount changed
> > >          # Note that in the current implementation, you cannot pay against an accruing fine
> > >          # (i.e. , of accounttype 'FU').  Doing so will break accrual.
> > > +        if ( $data->{'amount'} ne sprintf('%.6f', $amount) ) {
> > 
> > While this does work, would not a compare_numbers($n1,$n2,$accuracy)
> > function work better?
> 
> I'm not familiar with this function (compare_numbers), and google doesn't
> yield any (useful) results; from which module is it?

I was implying writing it... like... wait for it...

-- 
You are receiving this mail because:
You are watching all bug changes.