[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #29 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Owen Leonard from comment #22)

Hi Owen

Thanks *very* much for your feedback, hugely useful. I've just attached a bunch
of modified patches that address most of the points, pertinent comments below
each of your points.

> I've done a quick run-through of this and nothing looks broken. The tests
> all pass. I think the biggest gap is documentation. There should be a help
> file for the whole process, especially the things which aren't
> self-explanatory. For instance:
> 
> - What does the 'cyclical' setting do?
> - What is the purpose of the "Start" item in the stages
>   and duration column of the manage items table?
> - What does the "In demand" setting do?

Excellent point, we'll address that.

> Minor problems:
> 
> - Our capitalization rules say the heading should say
>   "Stock rotation" instead of "Stock Rotation"

Fixed  

> 
> - I don't the the alert-style div is correct for showing
>   a confirmation of items added. I would put the confirmation
>   message in a <div class="dialog message"></div> and show a
>   table of results below that.

Yes, agreed, fixed.

> - In the manage items table, there is no <tr> wrapping <th>.

I couldn't replicate this. I looked in the markup for the manage items table
and there was definitely a <tr> wrapping <th>. I'm not sure if I'm
misunderstanding where you mean.

> - The page title and breadcrumbs should be made more specific
>   for each page. For instance, when on the manage items page
>   the breadcrumbs should be:
> 
>   Home › Tools › Stock rotation > Manage items
> 
>   This provides an easily accessible link back to the main
>   stock rotation page.

Yes, excellent point. This has now been addressed throughout.

> Suggestions:
> 
> - Add a toolbar to the manage items page with a 'New rota'
>   and 'Edit rota' buttons.

Done.

> - Move the add items forms to the top of the [items table]

Done.

> - In the manage items table, I think title and barcode
>   should link to the bibliographic record and items page,
>   respectively.

Done.

> - Make the manage items table a DataTable with sorting and
>   searching. Unless you think the items table will typically
>   hold so much data this would become cumbersome?

I don't imagine it will, good suggestion. Done.

> - Should item status information be displayed in the manage
>   items table? Is it relevant to the process to know whether
>   something is checked out, lost, etc?

Not sure how immediately useful this will be, particularly as we're linking
directly to the item from the barcode in the row. I got a consensus of opinions
here and the majority felt it wasn't necessary. Thanks for the suggestion
though.

> - Since the drag-to-sort interaction is new to Koha it
>   probably needs a hint at the top to suggest it. (Looks 
>   good and work well, though).

Done.

Again, thanks for your feedback. If you find time to go through the latest
changes, I'd be very grateful. I'll update this bug when we have some
accompanying docs.

Cheers
Andrew

-- 
You are receiving this mail because:
You are watching all bug changes.