[Koha-bugs] [Bug 15908] Remove use of recordpayment_selectaccts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15908

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 52152
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52152
Bug 15908 - Remove use of recordpayment_selectaccts

Review of attachment 52152:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15908&attachment=52152)
-----------------------------------------------------------------

Perhaps it is an extra constraint, but the code isn't identical without it.
Results should be identical though.

::: C4/Accounts.pm
@@ -372,5 @@
> -
> -    my @lines = Koha::Account::Lines->search(
> -        {
> -            borrowernumber    => $borrowernumber,
> -            amountoutstanding => { '<>' => 0 },

Why is...

::: members/paycollect.pl
@@ +135,5 @@
> +
> +                my @lines = Koha::Account::Lines->search(
> +                    {
> +                        borrowernumber    => $borrowernumber,
> +                        accountno         => { 'IN' => \@acc },

... this not here?

-- 
You are receiving this mail because:
You are watching all bug changes.