[Koha-bugs] [Bug 17880] New: C4::Installer:: PerlModules lexicographical comparison is incorrect

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

            Bug ID: 17880
           Summary: C4::Installer::PerlModules lexicographical comparison
                    is incorrect
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: gmcharlt at gmail.com
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

C4::Installer::PerlModules compares a modules VERSION against the min_version
specified in C4::Installer::PerlDependencies using the lexicographical
comparison "lt". 

This means that 0.9.12 will be considered to be less than 0.9.3:

PDF::Table                                    0.9.12            0.9.3          
        Yes

The above line shows up in koha_perl_deps.pl when I look to see what modules I
need to upgrade. 

It doesn't prevent me from installing/running Koha, but it's wrong. 

In theory, we could use version.pm for our comparisons
(http://search.cpan.org/~jpeacock/version-0.9917/lib/version.pod#How_to_compare_version_objects).
I think it can sometimes have surprising results, although in this case it
should be OK since we're comparing version numbers against version numbers of
the same module. So in theory it should have a consistent scheme...

-- 
You are receiving this mail because:
You are watching all bug changes.