[Koha-bugs] [Bug 17794] Menu items in Tools menu and Admin menu not bold when active but not on linked page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17794

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Owen Leonard from comment #7)
> These comments are not a criticism of this patch, but just something I've
> been thinking about with regard to this area of the templates:
> 
> 1. This is starting to get convoluted. At what point should we try to
> reevaluate how we highlight menu items? Eventually the JavaScript becomes
> almost as complicated as doing the logic in the template.

Yes, it's hard to say.
We use another method to do that in members-menu.inc, but that requires a new
line per script + 1 check per entry in the menu. So much more code to maintain.

> 2. This way of doing things is going to create a problem for Bug 17858
> because these menu templates include jQuery JavaScript which the browser
> will attempt to run before jQuery has loaded. We will need to figure out a
> way to make it not break.

Indeed, and it will not be the only one:
  git grep '$(document).ready' ../includes/ | wc -l
 => 20

Not all of them are relevant, but some are.

-- 
You are receiving this mail because:
You are watching all bug changes.