[Koha-bugs] [Bug 17817] Repeat this Tag (cloning) not working

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 11 15:50:17 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17817

Patricio Marrone <marrone.patricio at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marrone.patricio at gmail.com

--- Comment #7 from Patricio Marrone <marrone.patricio at gmail.com> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Patricio Marrone from comment #5)
> 
> Hi Patricio,
> Can you confirm that your patch fixes the following:
>  - width is wrongly calculated
>  - "Move up" raises a JS error
> ?

Hi Jonathan! Short answer: yes. 
I checked that
- The width is the same as the one from the cloned line. This was fixed by
first
  appending the cloned element to the dom and then reactivating select2, so
that
  it can calculate the width.
- Moving up should work. select2 introduces some divs which broke the present
  assumptions that all divs were lines. I added more specific selectors to
  choose what's a line and what's not. This could use some regression testing
to
  check that other kind of fields still work correctly (that is, textfields,
  textareas...). I did test that they worked to the limits of my not very
extensive
  Koha knowledge.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list