[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #26 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Viccy Kemp from comment #25)
> I do not understand what Alex and Marcel are working on here. All I know is
> it appears that reserves do not take into account the dates when the library
> is closed. Today, the holds are showing they expire on January 16, but the
> library is closed that day and this is defined in the calendar. 
> WHY IS THIS NOT TAKEN INTO ACCOUNT ON THE EXPIRY DATE?

Hello Viccy,

The purpose of this patch is that the expiration date of reserves being
calculated one time when the item is checked in and that this date take into
account the pickup delay set by the library *AND* the potential closed days
during the period until the delay.

Let's admit:

  - a pickup delay set to 10 (days),
  - an item checked in at 01/01/2017,
  - so hold expires at 11/01/2017,
  - but library is closed from 04/01/2017 to 06/01/2017 (3 days),
  - if ExcludeHolidaysFromMaxPickUpDelay system preference is enabled, the
expiration date will be extended with these 3 days. So until 14/01/2017.

But, the case of holds expiring on a closed day is already handled in koha by
disabling ExpireReservesOnHolidays if i'm not wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.