[Koha-bugs] [Bug 7654] Add location at opac subscription view

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to M. Tompsett from comment #22)
> Comment on attachment 58869 [details] [review]
> Bug 7654: Add location at opac subscription view
> 
> Review of attachment 58869 [details] [review]:
> -----------------------------------------------------------------
> 
> Here are some untested thoughts. :)
> 
> ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
> @@ +796,4 @@
> >                              <p>There are [% subscriptionsnumber %] subscription(s) associated with this title.</p>
> >                              [% FOREACH subscription IN subscriptions %]
> >                                  [% IF ( subscription.branchcode ) %]
> > +                                    <h3>At library: [% Branches.GetName( subscription.branchcode ) %]</h3>
> 
> What if it gets a branch, but someone failed to enter a description or it is
> blank? Displaying the branchcode in that case would make sense. I do not
> think this correction is correct.

That's actually not a problem. The branchcode and branchname are both
mandatory. It's not possible to have a branch without a branchname in Koha.
Using the TT plugin like this is common in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.