[Koha-bugs] [Bug 17290] Standardize on "Patron categories" when referring to patron category

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17290

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 59119
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59119
Bug 17290 - Standardize on "Patron Categories"

Review of attachment 59119:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17290&attachment=59119)
-----------------------------------------------------------------

Hey Grace,
overall this reads great already - can you please take a look at the notes I
made and provide a new patch or a follow-up? Thx!

::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ +1,1 @@
> +% USE Koha %]

I think this was an accidental change, can you please fix and resubmit?

:::
koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/item_circulation_alerts.tt
@@ +16,4 @@
>  	<li>To set preferences for all libraries, keep the menu set to 'Default'</li>
>  </ul>
>  </li>
> +    <li>By default all item types and all patrons are notified of check ins and check outs. To change this, click on the item/patron category combination that you would like to stop notices for.</li>

We have patron categories and item types in Koha, so maybe it would read a
little better as: item type/patron category

::: koha-tmpl/intranet-tmpl/prog/en/modules/help/members/boraccount.tt
@@ +10,4 @@
>  
>  <ul>
>  	<li>Fines will be charged based on your Circulation & Fines Rules</li>
> +	<li>Hold fees will be charged based on the rules you set in the Patron Categories & Categories administration area</li>

I think the original read a little oddly as we don't have a section in
administration that reads like the help suggests. My suggestion is to write
something like:
Hold fees will be charged based on the rules you set for the patron category in
administration.

-- 
You are receiving this mail because:
You are watching all bug changes.