[Koha-bugs] [Bug 17946] Show number of subscriptions on tab in OPAC record details

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jan 20 02:24:58 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 59288
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59288
Bug 17946: Show number of subscriptions on tab in OPAC record details

Review of attachment 59288:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17946&attachment=59288)
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ +576,4 @@
>  
>                          [% IF ( subscriptionsnumber ) %]
>                              [% IF ( defaulttab == 'subscriptions' ) %]<li id="tab_subscriptions" class="ui-tabs-active">[% ELSE %]<li id="tab_subscriptions">[% END %]
> +                                <a href="#subscriptions">Subscriptions ( [% subscriptions.size || 0 %] )</a>

Why not just subscriptionsnumber?
See line 796ish where it puts it in the sentence.
There is no need for || 0, because subscriptions.size should be equal to
subscriptionsnumber.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list