[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Jan 22 18:01:33 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 59391
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59391
Bug 17944 - Moved the sql code from itemtypes.pl into Koha/ItemTypes.pm

Review of attachment 59391:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17944&attachment=59391)
-----------------------------------------------------------------

::: Koha/ItemTypes.pm
@@ +53,5 @@
> +        ) AS tmp
> +        WHERE tmp.t=?
> +        ', {}, $itemtype_code );
> +    return $total;
> +}

While not an easy thing, I don't even know how to do it off the top of my head,
consider reworking in DBIx.

Also, wouldn't this partially double count? Don't worry, this is a pre-existing
issue.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list