[Koha-bugs] [Bug 17970] GetPreparedLetter does not warn when expected

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 24 04:32:09 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59423|0                           |1
        is obsolete|                            |

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 59482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59482&action=edit
Bug 17970: Fix GetPreparedLetter behavior if nothing to substitute

>From C4::Letters::GetPreparedLetter:

    my $tables = $params{tables};
    my $substitute = $params{substitute};

    $tables || $substitute || $repeat
       or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute'
are empty" ),
          return;

So if the parameter tables or substitute is passed but does not contain
anything, it will not warn as expected.

Test plan:
1/ Apply the patch with tests
2/ Confirm that they do not pass
3/ Apply this patch
4/ Confirm that the tests now pass

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list