[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 24 21:29:00 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #56 from Josef Moravec <josef.moravec at gmail.com> ---
Sorry, but I found some problems...

First, the ReserveCount test is failing:

t/db_dependent/Reserves/ReserveCount.t .. 1/3 Value not allowed for auto_incr
hold_group_id in HoldGroup at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line
267.
Value not allowed for auto_incr hold_group_id in HoldGroup at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267.
Value not allowed for auto_incr hold_group_id in HoldGroup at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267.

#   Failed test 'Test borrower has 2 reserve.'
#   at t/db_dependent/Reserves/ReserveCount.t line 82.
#          got: '1'
#     expected: '2'
Value not allowed for auto_incr hold_group_id in HoldGroup at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267.
Value not allowed for auto_incr hold_group_id in HoldGroup at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267.
Value not allowed for auto_incr hold_group_id in HoldGroup at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267.
Value not allowed for auto_incr hold_group_id in HoldGroup at
/home/vagrant/kohaclone/t/lib/TestBuilder.pm line 267.

#   Failed test 'Test borrower has 2 reserve.'
#   at t/db_dependent/Reserves/ReserveCount.t line 114.
#          got: '1'
#     expected: '3'
# Looks like you failed 2 tests of 3.


Second, Koha qa tools has complains:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc
   FAIL   forbidden patterns
                forbidden pattern: simple-quote string (line 24)
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 1)

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reserve/reserve-group.tt
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

 FAIL   reserve/reserve-group.pl
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

And you should also change the modal syntax...

For bootstrap related issues see page
https://wiki.koha-community.org/wiki/Interface_patterns
especially sections "Buttons" and "Modals"

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list