[Koha-bugs] [Bug 16018] Merge.pl does not update biblios linked to the old authority

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018

Mehdi Hamidi <mehdi.hamidi at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59497|0                           |1
        is obsolete|                            |

--- Comment #16 from Mehdi Hamidi <mehdi.hamidi at inlibro.com> ---
Created attachment 59531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59531&action=edit
Bug 16018: Merge.pl does not update biblios linked to the old authority

Original patch from Remi Mayrand-Provencher.
Amended by Marcel de Rooy (January 2017), part of omnibus bug 17908.

EDIT:
We cannot remove the ModAuthority call, since the reference record is
the result of the merge and should be saved.
Variable $overwrite is not used and can be removed.

The ModAuthority call triggers a merge like: recordid1, original ref record,
recordid1, new ref record. This only updates all biblio records that were
already attached to the reference record.
As Remi discovered correctly, we still need another merge for the biblios
attached to recordid2 (the record to be deleted).
This patch adds that merge.

Note: The results of this merge operation should have been improved by the
changes to C4::AuthoritiesMarc::merge.

Test plan:
[1] Restart Plack and restart koha-indexer. (I had some problems related to
    indexing as a result of the marcxml transition.)
[2] Go to Authorities.
    Select two authorities to merge, start with two of the same type.
    Make sure that both are used in a few biblio records.
    Select at least one subfield from the authority to be removed for
    inclusion in the authority to be kept ("reference record").
[3] Click Merge. You come back to the kept authority record.
    Note: The number of attached records may not yet be updated. This depends
    on the speed of koha-indexer. If you wait a bit and refresh, you should
    have the correct number.
    First check the authority record again for the inserted subfield.
    Now check a biblio that was ALREADY attached to the reference record.
    And check a biblio that was FORMERLY attached to the deleted one.
    Note: See bug 17913 to see how pref AuthorityMergeMode impacts this.
[4] Try steps 2 and 3 again for a merge of two authority records that do not
    have the same authority type noting the remarks below.
    For instance try to merge from a CORPO_NAME to a PERSO_NAME record.
    Make a change in say 040$a of the record to be deleted. And select that
    field later on the merge form.
    Normally, you would use the PERSO_NAME framework in the merge now.
    When checking the authority record, look at 040a. When checking the
    record that was linked to the CORPO_NAME, check if it contains the
    PERSO_NAME authority in the correct field (say 100, 600, 700).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: mehdi <mehdi at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.