[Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Jan 24 23:45:42 CET 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979
--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #1)
> I guess the regex should be m|^[\d-]*$|;
> Instead of just /\d/
That doesn't account for ISBN-10 where the check digit can be X or x:
https://en.wikipedia.org/wiki/Check_digit#ISBN_10
We could use Business::ISBN to check if it's an ISBN and then if it's not, we
could treat it as a title. (We could even do ISBN search only for valid ISBNs
and do title searches for everything else.)
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list