[Koha-bugs] [Bug 17880] C4::Installer:: PerlModules lexicographical comparison is incorrect

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 25 00:06:51 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17880

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59533|0                           |1
        is obsolete|                            |

--- Comment #18 from David Cook <dcook at prosentient.com.au> ---
Created attachment 59534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59534&action=edit
Bug 17880: Fix copy/paste error

It looks like I made a copy/paste error in a previous patch.

While the fix was working when you pass the param "module" to
version_info, it wasn't populating the version correctly
for the "all" param, which causes koha_perl_deps.pl to
think all OK modules actually need an upgrade.

TEST PLAN

0) Be on a system where you know your Koha Perl dependencies are
mostly up-to-date

1) Run ./koha_perl_deps.pl -a -c
2) Note that most modules say they need an upgrade even when
the installed version is the same as the minimum version

3) Apply patch

4) Run ./koha_perl_deps.pl -a -c
5) Note that most moduls say they're OK, especially when the
installed version is the same or greater than the minimum version

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list