[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #119 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 59628
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59628
Bug 17855 - Implemented a retrieval of patron category
enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron
accounts created with the onboarding tool.

Review of attachment 59628:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=59628)
-----------------------------------------------------------------

This is my quick eyeball. I'll test later.

::: installer/onboarding.pl
@@ +92,4 @@
>  );
>  
>  #Store the value of the template input name='op' in the variable $op so we can check if the user has pressed the button with the name="op" and value="finish" meaning the user has finished the onboarding tool.
> +my $op = $input->param('op') || "";

For future reference q{} is perlcritic level 1 friendly. Single quotes are also
more perlcritic friendly.

@@ +282,5 @@
>      $template->param( 'categories' => $categories, );
>  
> +
> +
> +

Hmmm... excess space? I'm not going to fail over this. I'll let QA fix it.

@@ +387,5 @@
> +            $newdata{city}           = "";
> +
> +#Determine the dateexpiry of the patron based on the patron category it is created from
> +            my $patron_category = Koha::Patron::Categories->find( $newdata{categorycode} );
> +            $newdata{dateexpiry} = $patron_category->get_expiry_date( $newdata{dateenrolled} );

It's so pretty!

-- 
You are receiving this mail because:
You are watching all bug changes.