[Koha-bugs] [Bug 17950] Small improvements for Merge.t

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 31 18:36:09 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59399|0                           |1
        is obsolete|                            |

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 59690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59690&action=edit
Bug 17950: Merge.t: Improve variable handling at top level

This patch does:
[1] Remove unused $dbh.
[2] Move all mocking statements to one sub.
[3] Promote a few lexicals to globals when used in the subtests.

Test plan:
Run t/db_dependent/Authorities/Merge.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list