[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 31 21:35:06 CET 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855

--- Comment #121 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
(in reply to M.Tompsett in comment 120)

I believe we are starting to scope creep. The purpose of the create circulation
rule is simply to display the library, patron category and item type the user
created/installed (in drop-down boxes) and then the user can choose 'All' or a
specific value and the circulation rule is assigned accordingly. Thus at
present the create circulation rule step does what it's supposed to do
successfully. 

Regarding the onshelfholds logic I fixed it up in the bug 17955 (which needs
signoff), because some of the sql queries were inserting into the onshelfholds
column of the default_branch_circ_rules table (see below) (there is no such
column in this table) so I changed the insert to input values into the
issuingrules table. 

628             my $sth_insert = $dbh->prepare(
629                 "INSERT INTO default_branch_circ_rules
630                                         (branchcode, onshelfholds)
631                                         VALUES (?, ?)"
632             );

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list