From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 00:20:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Jun 2017 22:20:48 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 00:50:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Jun 2017 22:50:17 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #13 from Marc V?ron --- (In reply to Marcel de Rooy from comment #12) > Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl > fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. Re-tested, applies cleanly here (on top of Bug 18859). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 01:45:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Jun 2017 23:45:17 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 --- Comment #7 from Nick Clemens --- (In reply to Katrin Fischer from comment #6) > > To my understanding, this is what happened : > > > > Situation 1 (regular) > > > > - Patron A put a hold on Book A > > - Book A is returned. Hold is confirmed. > > - Patron B checkout Book A > > - Koha says "This book is on hold for Patron A, what do you want to do?" > > - The button "Don't checkout and print" allows you to cancel the process and > > print a slip. > > - It keeps the book on hold for Patron A. It's actually already on hold so > > there should be no reason to update it. > > If the item is already on hold for the patron it will allow to reprint the > hold slip. Sounds good. > > > > BUT, here comes situation 2 (exception) > > > > - Patron A put a hold on Book A > > - Book A is returned. Hold is NOT confirmed (Library wants to confirm the > > hold later to control when the confirmation email is sent, or library had > > forgotten, etc.) > > - Patron B checkout Book A > > - Koha says "This book is on hold for Patron A, what do you want to do?" > > - The button "Don't checkout and print" allows you to cancel the process and > > print a slip. > > - The hold is not confirmed and this button doesn?t update it. > > I think that's wrong - you should not have a hold slip if no email is > generated and the hold is not set to waiting. The slip should only happen if > the hold is waiting or set to waiting - otherwise you end up with > 'available' items on the hold shelf. > > I wonder if the message could be better as on hold sounds like it's already > waiting, but it's not. We should have different messages for already waiting > and having a hold on it that's not yet confirmed. > > I think what Nick describes is a 3rd option: hold for A, don't confirm hold, > try to checkout to A. In this case, the item was not waiting and should be > set to waiting. Yes, as I follow things this is correct - I was thinking of the situation where: A places a hold from home B picks up the book off the shelf before a hold list is checked Try to checkout to B, print slip, hold never confirmed I think you are getting at language something like: this item has a hold for Patron A versus this item is on hold for Patron A -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:22:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 00:22:04 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- I figured the test added should fail under master, so: git bz apply 18755 git checkout origin/master -- C4/SIP/Sip/MsgType.pm prove t/db_dependent/SIP/Message.t -- fails as expected git reset --hard origin/master git bz apply 18755 prove t/db_dependent/SIP/Message.t -- passes as expected. This change is fully tested by the test that is added, so I'm going to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:22:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 00:22:55 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:22:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 00:22:57 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64101|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 64762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64762&action=edit Bug 18755 Allow empty passwords in Patron Info to return OK With this patch a parameter 'allow_empty_passwords="1" can be added to a login in the SIP configuration file to allow the behaviour as was normal before the patch for bug 16610 was applied. Some sip clients rely on this behaviour sending an empty password field when they wish to validate to user but do not have the password. If a password is supplied it will be validated A test has been added to Message.t to confirm this behaviour Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:59:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 00:59:01 +0000 Subject: [Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:58:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 00:58:50 +0000 Subject: [Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 --- Comment #2 from M. Tompsett --- Comment on attachment 64197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64197 Bug 18785: Add Koha::Subscription::biblio Review of attachment 64197: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18785&attachment=64197) ----------------------------------------------------------------- ::: Koha/Subscription.pm @@ +44,5 @@ > + > +sub biblio { > + my ($self) = @_; > + > + return Koha::Biblios->find($self->biblionumber); There are a bunch of other bugzilla issues related to ->find and a scalar context. Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or I think others get lazy ->find( scalar $self->biblionumber )... or was it return scalar Koha::Biblios->find($self->biblionumber); Hmmm... anyways, this isn't right, as far as I can tell. Plus if it is singular, then why Biblios? This is the part I don't understand in this and other code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 05:25:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 03:25:57 +0000 Subject: [Koha-bugs] [Bug 9409] koha-create --request-db should be able to accept a dbhost option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- Thanks for the sign off, LeeJ. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 05:50:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 03:50:38 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 --- Comment #3 from Alex Buckley --- Created attachment 64763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64763&action=edit Bug 18743 - Removed library filter in Acquisition suggestions when IndependentBranches enabled Also ensured that when a superlibrarian is logged in then suggestions from all branches are displayed with IndependentBranches being either on or off, as this syspref does not affect what suggestions superlibrarians can see. But when non-superlibrarian user with access to the acquisitions module visits it when IndependentBranches is enabled then only suggestions of the branch they are logged in with are displayed. If non-superlibrarian users log in when IndependentBranches is not enabled then suggestions from all branches are displayed. Note: The library filter in the 'Organize by' area (which is displayed when multiple branches suggestions are displayed according to the aforementioned logic) successfully splits the suggestions into different tabs with the correct number of suggestions for each branch displayed in each tab. Test plan: 1. Create 2 suggestions a library branch (which I will refer to in this test plan as branch A) 2. Create 1 suggestion for a different branch (which I will refer to as branch B) 3. Log into staff client as superlibrarian with either branch and ensure the IndependentBranches syspref is set to 'yes' 4. Go to Acquisitions->Suggestions Management 5. Notice that suggestions from branch A and B are displayed 6. In the Organize by are click to filter by library and click go 7. Notice that one tab says (2) whilst the other tab says (1) with each tab containing the relevant suggestions to that branch 8. Now change the IndependentBranches syspref to 'no' 9. Repeat steps 4, 5, 6, 7 noticing the same outcome in step 7 10. Log out and log back into staff client in branch A as a non-superlibrarian user who has access to the Acquisitions module 11. Currently IndependentBranches is set to 'no' so go to Acquisitions->Suggestions Management 12. Repeat steps 5, 6, 7 and notice the same outcome as step 7 13. Change IndependentBranches to 'yes' 14. Go to Acquisitions->Suggestions Management 15. Notice that only suggestions from branch A (the branch you are logged in with) are displayed. This is because when IndependentBranches is enabled non-superlibrarians do not need to see suggestions from other branches 16. Also noticethat there is no 'library' option in the 'Organized by' area. This is because only suggestions from the current branch are displayed and so organizing by library is redundant. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 11:17:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 09:17:56 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 11:19:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 09:19:05 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 00:02:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 22:02:25 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 00:02:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 22:02:30 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64676|0 |1 is obsolete| | --- Comment #2 from Alex Buckley --- Created attachment 64764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64764&action=edit Bug 18861 - branch_transfer_limits needs keys The branch transfers limits are edited in : /cgi-bin/koha/admin/branch_transfer_limits.pl This page calls a loop on IsBranchTransferAllowed with all destination branches and codes (ccodes or itemtypes). This can takes a huge time because table branch_transfer_limits has no keys. Since ccode or itemtype may be used, this patch adds a key on both combinaison : ccode/fromBranch/toBranch and itemtype/fromBranch/toBranch. Tested on a table with 66000 entries, time whent from 26 second to less than 1 second. Test plan : - Go to Administration > Library transfer limits - Check page load is faster - Uncheck a checkbox - Save => Verify save is OK - Change branch and same tests Followed test plan which worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 00:05:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jul 2017 22:05:32 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz Status|Signed Off |In Discussion --- Comment #3 from Alex Buckley --- Hi Frindolin Your patch works well, one thing I noticed was that it would be logical for the checkbox of the current branch not to be displayed. i.e. if I am looking at the Fairfield checkin and transfer policy then the fairfield checkbox should not be displayed because when you uncheck the fairfield box then save the page it reloads with fairfield checked again. Perhaps this could be a future patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 10:28:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jul 2017 08:28:10 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64732|0 |1 is obsolete| | --- Comment #46 from Alex Buckley --- Created attachment 64765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64765&action=edit Bug 18002 - Created an acquisition onboarding tool to be displayed when no currency, budget, or fund exists Implemented scrolling for acquisition onboarding tool. Hidden the active checkbox for currencies and budget, and made exchange rate readonly (displayed). Same test plan as comment 29. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 12:28:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jul 2017 10:28:58 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 12:29:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jul 2017 10:29:25 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 --- Comment #11 from Alex Buckley --- Created attachment 64766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64766&action=edit Bug 18060 - Label onboarding tool to be displayed when no labels or templates exist Updated to apply cleanly with bug 18002 Please follow the test plan on comment 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 12:41:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jul 2017 10:41:42 +0000 Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz |ity.org | CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 16:30:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jul 2017 14:30:05 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 02:20:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 00:20:46 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #1 from Alex Buckley --- Created attachment 64767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64767&action=edit Bug 18888 - Currency defined in new onboardingstep6.tt after installation Test plan: 1. Restart memcached and drop and recreate your database 2. Go through the Koha web installer making sure to install all data except the currencies 3. Run through the onboarding tool noticing that after creating the circulation rule the complete page appears and you can click to log into Koha with the superlibrarian user you have created in the onboarding tool 4. Apply patch 5. Repeat step 1, and 2 6. Run through the onboarding tool and notice that after creating the circulation rule, a screen appears for you to define a currency 7. Write in the currency name and symbol (notice: you cannot edit the exchange rate of 1) and submit the form 8. Notice the complete screen appears and you can log in with the superlibrarian account created in the onboarding tool 9. Go to Administration->Currencies and exchange rates and notice that the currency you created in the onboarding tool is displayed as active 10. Repeat step 1 11. Go through the Koha web installer making sure to install all data including currencies 12. Run through the onboarding tool and notice that after creating the circulation rule then the complete screen appears and click to log into Koha with your superlibrarian account 13. Run qa tool and all tests should be successful 14. Sign off Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 02:21:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 00:21:24 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 07:26:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 05:26:23 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 07:27:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 05:27:01 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 --- Comment #4 from Alex Buckley --- Created attachment 64768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64768&action=edit Bug 18743 - Removed library filter in Acquisition suggestions when IndependentBranches enabled Also ensured that when a superlibrarian is logged in then suggestions from all branches are displayed with IndependentBranches being either on or off, as this syspref does not affect what suggestions superlibrarians can see. But when non-superlibrarian user with access to the acquisitions module visits it when IndependentBranches is enabled then only suggestions of the branch they are logged in with are displayed. If non-superlibrarian users log in when IndependentBranches is not enabled then suggestions from all branches are displayed. Note: The library filter in the 'Organize by' area (which is displayed when multiple branches suggestions are displayed according to the aforementioned logic) successfully splits the suggestions into different tabs with the correct number of suggestions for each branch displayed in each tab. Test plan: 1. Relicate the bug described in description comment 2. Apply patch 3. Create 2 suggestions a library branch (which I will refer to in this test plan as branch A) 4. Create 1 suggestion for a different branch (which I will refer to as branch B) 5. Log into staff client as superlibrarian with either branch and ensure the IndependentBranches syspref is set to 'yes' 6. Go to Acquisitions->Suggestions Management 7. Notice that suggestions from branch A and B are displayed 8. In the Organize by are click to filter by library and click go 9. Notice that one tab says (2) whilst the other tab says (1) with each tab containing the relevant suggestions to that branch 10. In the Acquisition information filter select branch A and then click 'Go' and notice that it successfully filters the results and shows 2 suggestions of branch A only 11. Now change the IndependentBranches syspref to 'no' 12. Repeat steps 6, 7, 8, 9, 10 noticing the same outcome in step 9 and 10 13. Log out and log back into staff client in branch A as a non-superlibrarian user who has access to the Acquisitions module 14. Currently IndependentBranches is set to 'no' so go to Acquisitions->Suggestions Management 15. Repeat steps 6, 7, 8, 9, 10 and notice the same outcome as step 9 and 10 16. Change IndependentBranches to 'yes' 17. Go to Acquisitions->Suggestions Management 18. Notice that only suggestions from branch A (the branch you are logged in with) are displayed. This is because when IndependentBranches is enabled non-superlibrarians do not need to see suggestions from other branches 19. Also notice that there is no 'library' option in the 'Organized by' area and there is no library filter in the acquisition information area. This is because only suggestions from the current branch are displayed and so organizing/filtering by library is redundant. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:20:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:20:11 +0000 Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between framework and authority editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811 --- Comment #13 from Marcel de Rooy --- (In reply to Michael Cabus from comment #12) > When I run perl misc/maintenance/auth_show_hidden_data.pl -c I get this > error: > > DBIx::Class::ResultSet::find(): find() expects either a column/value > hashref, or a list of values corresponding to the columns of the specified > unique constraint 'primary' at /home/vagrant/kohaclone/Koha/Objects.pm line > 85 > > Checked Authorities schema and all seemed well. Hi Michael, Thanks for testing. I guess that you are using kohadevbox to test, but I wonder if you have a configuration issue. Line 85 of Koha/Objects in master is not the DBIx find call, but only the first line of the sub with me. Please check if your paths are in order. The perl library path should also point to current master not to the older instance installed on your devbox. Do you use dev_install in your koha-conf? Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:36:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:36:15 +0000 Subject: [Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799 --- Comment #21 from Baptiste --- Hum ok.. So the settings: item-level_itype => biblio record XSLTDetailsDisplay, XSLTListsDisplay , XSLTResultsDisplay => "default" DisplayIconsXSLT => show noItemTypeImages => show I can find icons on this page http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=384&searchid=scs_1499067251739 but with all others settings it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:49:34 +0000 Subject: [Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |RESOLVED --- Comment #3 from Marcel de Rooy --- Good catch, Aleisha. I am moving the solution to 18881 as Marc expanded it. *** This bug has been marked as a duplicate of bug 18881 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:49:34 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #14 from Marcel de Rooy --- *** Bug 18859 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:49:36 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Bug 18881 depends on bug 18859, which changed state. Bug 18859 Summary: Warns when accessing Circulation -> Holds Queue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:49:49 +0000 Subject: [Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds Queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18881 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 [Bug 18881] Remove dead code in circ/view_holdsqueue.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:49:49 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18859 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859 [Bug 18859] Warns when accessing Circulation -> Holds Queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:51:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:51:27 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #15 from Marcel de Rooy --- Created attachment 64769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64769&action=edit Bug 18881: Remove dead code from view_holdsqueue.pl Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859. The description was not even used. Template calls GetDescription. To test: Verify that viewing the holds queue still works as expected. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:51:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:51:31 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #16 from Marcel de Rooy --- Created attachment 64770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64770&action=edit Bug 18881: [QA Follow-up] Remove even more Removing the commented section from the template: If it does not work, it should not be here. When it works again, put it back in. Since @itemtypesloop is not used, remove it from the script too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:51:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:51:48 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:54:10 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:54:45 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 --- Comment #17 from Marcel de Rooy --- Taking the liberty to move this directly into PQA now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:54:52 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:54:57 +0000 Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:57:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:57:54 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64767|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 64771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64771&action=edit Bug 18888 - Currency defined in new onboardingstep6.tt after installation Test plan: 1. Restart memcached and drop and recreate your database 2. Go through the Koha web installer making sure to install all data except the currencies 3. Run through the onboarding tool noticing that after creating the circulation rule the complete page appears and you can click to log into Koha with the superlibrarian user you have created in the onboarding tool 4. Apply patch 5. Repeat step 1, and 2 6. Run through the onboarding tool and notice that after creating the circulation rule, a screen appears for you to define a currency 7. Write in the currency name and symbol (notice: you cannot edit the exchange rate of 1) and submit the form 8. Notice the complete screen appears and you can log in with the superlibrarian account created in the onboarding tool 9. Go to Administration->Currencies and exchange rates and notice that the currency you created in the onboarding tool is displayed as active 10. Repeat step 1 11. Go through the Koha web installer making sure to install all data including currencies 12. Run through the onboarding tool and notice that after creating the circulation rule then the complete screen appears and click to log into Koha with your superlibrarian account 13. Run qa tool and all tests should be successful 14. Sign off Sponsored-by: Catalyst IT Folloewe test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:58:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:58:10 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:59:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:59:10 +0000 Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18755 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:59:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 07:59:10 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16610 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:22:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 08:22:41 +0000 Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to be embedded in Acquisitions to help the users set up Acquisitions for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 --- Comment #47 from Marc V?ron --- Hi Alex It works great. Two small issues: - The modal box now shows sliders (inactive), they are not necessary. I think it's in #onboardingModal (overflow) or something with the dimensions. - The rate can not be changed, that is ok now, but users can enter oter values and try to save. They will need an explanation why the exchange rate can not be changed. Or maybe better hide the exchange rate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:34:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 08:34:23 +0000 Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911 Ruth Smalley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rsmalley at livewirewarrington | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:43:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 08:43:08 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Marc V?ron --- Sorry, after applying the patch (on top of 18002, refresh memcahed and plack), I get an Internal error. Plack error log says: Variable "$layout" is not available at /home/marc/koha/labels/label-home.pl line 55. Can't call method "get_attr" on an undefined value at /home/marc/koha/labels/label-home.pl line 55. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:48:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 08:48:06 +0000 Subject: [Koha-bugs] [Bug 12355] Print quick slip should not print items renewed in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12355 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:48:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 08:48:30 +0000 Subject: [Koha-bugs] [Bug 12355] Print quick slip should not print items renewed in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12355 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18527 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:48:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 08:48:30 +0000 Subject: [Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12355 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:54:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 08:54:50 +0000 Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #25 from Marc V?ron --- Still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:31:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 09:31:01 +0000 Subject: [Koha-bugs] [Bug 18889] New: Item number in biblio description in fine page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Bug ID: 18889 Summary: Item number in biblio description in fine page Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: vimal0212 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 64772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64772&action=edit Fines Dear Friends, Very useful to see the item number (barcode) along with bibliographic details in fines page. If barcode appears along with book details easy identify the specific book. For example, in law libraries books with the same title by many authors (e.g. Constitution of India). Please see the screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:31:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 09:31:21 +0000 Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 vimal kumar changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:43:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 09:43:31 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #21 from Nick Clemens --- Created attachment 64773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64773&action=edit Bug 18434 - Followup fix tests for sorting and factes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:59:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 09:59:37 +0000 Subject: [Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #3 from Julian Maurice --- (In reply to M. Tompsett from comment #2) > There are a bunch of other bugzilla issues related to ->find and a scalar > context. > Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or > I think others get lazy ->find( scalar $self->biblionumber )... or was it > return scalar Koha::Biblios->find($self->biblionumber); > Hmmm... anyways, this isn't right, as far as I can tell. I assume you are talking about bug 18179, but the patch I wrote doesn't make any call to 'find' in a list context. Plus, there is a check in Koha::Objects::find that prevents it to be used in a list context, so I think we're good. Callers of Koha::Subsbcription::biblio will be the ones to have to make sure it's called in scalar context. > Plus if it is singular, then why Biblios? This is the part I don't > understand in this and other code. The 'find' subroutine is defined in Koha::Objects, not Koha::Object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:59:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 09:59:55 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 --- Comment #4 from Marcel de Rooy --- Colin: What about Patron Status now? If you provide no AD field, Patron Status responds with a CQN (without Invalid password). Should it return a CQ? Same for empty AD; receive CQN. Should the new option change behavior here? Note: Patron Info without AD does not return a CQ. (Should it?) And an empty AD with allow_e_p returns a CQY. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 12:42:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 10:42:29 +0000 Subject: [Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 14:20:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 12:20:30 +0000 Subject: [Koha-bugs] [Bug 18890] New: REST API: Fix fetching operation spec in route chain Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 Bug ID: 18890 Summary: REST API: Fix fetching operation spec in route chain Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at jns.fi QA Contact: testopia at bugs.koha-community.org Mojolicious::Plugin::OpenAPI version 1.17 added a feature for fetching API spec in route chain. For us, this type of functionality is used in authentication with our own workaround introduced in Bug 18137. Our own workaround no longer works if M::P::OpenAPI version >=1.17. When upgrading Mojolicious::Plugin::OpenAPI dependency, this patch will fix the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 14:55:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 12:55:39 +0000 Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 --- Comment #1 from Lari Taskula --- Created attachment 64774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64774&action=edit Bug 18890: REST API: Fix fetching operation spec in route chain Mojolicious::Plugin::OpenAPI version 1.17 added a feature for fetching API spec in route chain. For us, this type of functionality is used in authentication with our own workaround introduced in Bug 18137. Our own workaround no longer works if M::P::OpenAPI version >=1.17. When upgrading Mojolicious::Plugin::OpenAPI dependency, this patch will fix the issue. To test: 1. prove t/db_dependent/api/v1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:29:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 14:29:12 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40000|0 |1 is obsolete| | Attachment #40001|0 |1 is obsolete| | Attachment #40002|0 |1 is obsolete| | Attachment #42157|0 |1 is obsolete| | Attachment #43181|0 |1 is obsolete| | Attachment #43546|0 |1 is obsolete| | --- Comment #52 from Nick Clemens --- Created attachment 64775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64775&action=edit Bug 12768 - Updated schema files Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:29:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 14:29:18 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #53 from Nick Clemens --- Created attachment 64776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64776&action=edit Bug 12768 - Replacement cost and processing fee management Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:29:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 14:29:08 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:33:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 14:33:40 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #54 from Nick Clemens --- Rebased, addressed QA concerns, squashed for readability, added more tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:52:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 14:52:17 +0000 Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 --- Comment #2 from Lari Taskula --- Created attachment 64777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64777&action=edit Bug 18890: Fix cities.t The update also causes some tests authorization tests to fail with HTTP 400 response instead of the expected 401/403. It seems that the parameters were not properly validated before and the tests were mistakenly passing. To test: 1. prove t/db_dependent/api/v1/cities.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:52:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 14:52:31 +0000 Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 --- Comment #3 from Lari Taskula --- Created attachment 64778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64778&action=edit Bug 18890: Fix holds.t The update also causes some tests authorization tests to fail with HTTP 400 response instead of the expected 401/403. It seems that the parameters were not properly validated before and the tests were mistakenly passing. To test: 1. prove t/db_dependent/api/v1/holds.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:59:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 14:59:47 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 --- Comment #6 from Lari Taskula --- (In reply to Mike from comment #5) > Hi Lari, > any progress on it? Jiri propably will ready to join us again and do some > code on REST. So, we need to know actual state of Your work. > > Thank You. Hi! Sorry for late answer, I was on holidays. Yes, I have some code ready, attaching it by tomorrow so you can review it. Nice to hear Jiri is joining you again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 17:06:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 15:06:43 +0000 Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 17:06:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 15:06:43 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 [Bug 18890] REST API: Fix fetching operation spec in route chain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 17:07:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 15:07:19 +0000 Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in route chain In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:08:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 16:08:46 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:08:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 16:08:49 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64478|0 |1 is obsolete| | --- Comment #36 from Nick Clemens --- Created attachment 64779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64779&action=edit [SIGNED-OFF] Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Have ES running and some records in it 2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url for your site) 3 - Test searching for author, title, and subject 4 - Verify that results are returned in expected order 5 - Experiment with fuzziness 6 - Click any result and verify specific titles are correct 7 - Click through title to record and verify it is the correct record Signed-off-by: Sebastian Hierl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:30:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 16:30:43 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:32:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 16:32:14 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #12 from Nick Clemens --- (In reply to Marcel de Rooy from comment #10) > If I select say Author and set them all to Facetable No in the Search fields > list on the Biblios tab, I would not expect Author to be still in the Facet > order list? I agree, this is not ideal, but I think that comes when we stop hardcoding the displayable facets all together - I would say beyond the scope of this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:52:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 16:52:42 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #79 from Blou --- Should have been in Need Signoff for a month, now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:02:37 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:02:39 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64505|0 |1 is obsolete| | Attachment #64506|0 |1 is obsolete| | Attachment #64507|0 |1 is obsolete| | Attachment #64508|0 |1 is obsolete| | Attachment #64509|0 |1 is obsolete| | --- Comment #41 from Nick Clemens --- Created attachment 64780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64780&action=edit Bug 18228: Table revision of virtualshelves In order to make the permissions easier, we will replace the columns allow_add, allow_delete_own and allow_delete_other by two new columns allow_change_from_owner and allow_change_from_others. The distinction between adding or deleting an entry is no longer made. If you have change permission, you can do both. Also deleting an entry does no longer depend on who added the entry. Formerly, the owner could always add entries. It is now possible to make a list readonly. We will not use the combination of owner=no and other=yes. This will leave us three possibilities: [1] owner=no, other=no: The list is read-only. No one can change contents of the list. Naturally, the owner can edit permissions. [2] owner=yes, other=no: Only the owner can change contents. [3] owner=yes, other=yes: Anyone seeing the list can change contents. This especially applies to shared lists and public lists. The two database columns will be presented in the interface as one permission field offering the three abovementioned options. Test plan: [1] Run the db rev. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:02:44 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #42 from Nick Clemens --- Created attachment 64781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64781&action=edit Bug 18228: DBIx schema changes for Virtualshelve.pm No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:02:48 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #43 from Nick Clemens --- Created attachment 64782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64782&action=edit Bug 18228: Implement the new columns in code The two new columns as mentioned in the commit message of the table revision must be used in the codebase now. Highlighting some changes in Koha::VirtualShel[f|ves]: [1] Additional methods is_public and is_private. [2] Method add_biblio did not check permissions. Does now. No impact on the interface, but one call in the unit test was affected. [3] Method remove_biblios is signficantly simplified. Removed a FIXME. [4] Method can_biblios_be_removed now redirects to can_biblios_be_added. A followup report may deal with unifying those routines. [5] Condition in get_some_shelves changed. [6] The reference to allow_add in get_shelves_containing_record can simply be removed. opac-shelves.pl and shelves.pl now pass the default setting of Owner only to the template. Templates shelves.tt and opac-shelves.tt now include the new permission field with three choices as mentioned in the table revision patch. opac-addbybiblionumber.pl and addbybiblionumber now need a check on allow_change_from_owner; search conditions slightly adjusted to the new permission scheme. Test plan: When we refer to visibility in the test plan, please check the Add to-combo on opac search results and staff results. And check opac-addbybiblionumber by clicking Save to Lists from opac results. The step 'Check delete' means: open the list in opac and check if you see the Delete button below the entries (only check, do not delete). [ 1] Create private list I01 (perm=Owner) [ 2] Check visibility: Seen. [ 3] Add a book. (Change by owner should be allowed.) [ 4] Check delete: Yes. [ 5] Edit list I01, set perm=Nobody [ 6] Check visibility: Not seen. [ 7] Check delete: No. [ 8] Share list I01 with another patron. [ 9] Check visibility for the other patron: Not seen. [10] Check delete for the other patron: No. [11] Change permission of list I01 to Anyone (by owner). [12] Check visibility for the other patron: Seen. [13] Let other patron add a book (change is allowed). [14] Let owner delete the same book again (change allowed). [15] Create public list U01 (perm=Owner) [16] Check visibility: Seen. [17] Add a book. (Change by owner should be allowed.) [18] Login as other user. Check visibility: Not seen. Check delete: No. [19] Change permission of U01 to Nobody (by owner) [20] As owner: Check visibility: Not seen. Check delete: No. [21] As other user: Check visibility: Not seen. Check delete: No. [22] Create public list U02 (perm=Anyone) [23] Add a book by owner. [24] Delete the same book by other user. Add another book. Signed-off-by: Marcel de Rooy Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:02:52 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #44 from Nick Clemens --- Created attachment 64783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64783&action=edit Bug 18228: Adjust Virtualshelves.t Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Eric Gosselin Signed-off-by: Jesse Maseto Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:02:57 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #45 from Nick Clemens --- Created attachment 64784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64784&action=edit Bug 18228: Add missing comma in kohastructure.sql Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:03:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:03:01 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #46 from Nick Clemens --- Created attachment 64785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64785&action=edit QA Followup - use gender neutral language in new tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:40:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 17:40:55 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- What is the status of this bug? Signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 20:55:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 18:55:43 +0000 Subject: [Koha-bugs] [Bug 18891] New: Download Reports Directly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891 Bug ID: 18891 Summary: Download Reports Directly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: cslone at camdencountylibrary.org QA Contact: testopia at bugs.koha-community.org There should be an option to download a report directly, rather than having to run the report and then choose to download it (effectively running it twice). This would be especially helpful when dealing with reports that take a while to load, though it would also be convenient for reports that are run regularly for distribution and therefore really don't need to be previewed on the screen before downloading. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:04:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:04:43 +0000 Subject: [Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |tomascohen at gmail.com --- Comment #28 from Tom?s Cohen Arazi --- Hi everyone here. I tested this with some credentials Nick gave me. I have a couple observations about this one. Important ========= - I first tested opac-oneclick-search.pl using the q= query param. That way I found stuff in Oneclick. The searched on the main opac search for a term I knew should give results (q=1776), and I got (the first time) "Error searching OneClickDigital collection: Not Found". I then reloaded the results page, and got "Found 1 results in OneClickDigital collection". This one seemed ok - When clicking in the '1 results' link, I got a red message "Error searching OneClickDigital collection: Not Found", on reloading, I got the search results for 1776. => FAIL: It seems there's a problem on the first query, or a throttling stuff getting in the middle. Moderate ======== => FAIL: The search results on opac-oneclick-search.pl have a different styling than Koha's search results. They look nicer, but I think the same XSLT's shold be used. I understood that this is a transition until this search results are displayed inline along with the regular (local) search results. I wouldn't say the second item is a blocker, but it might be a reason for others to vote against its inclusion. Minor ===== - Another (minor) thing I would consider changing is the wording for the sysprefs description. I think they should clearly match what Oneclick provides the user to configure Koha (LibraryID vs. library #) - Warnings are logged: Use of uninitialized value in concatenation (.) or string at /usr/local/share/perl/5.20.2/WebService/ILS/OneClickDigital/PartnerPatron.pm line 58. Use of uninitialized value in concatenation (.) or string at /home/vagrant/kohaclone/Koha/ExternalContent/OneClickDigital.pm line 73. QA scripts ========== The QA scripts complain about oneclick-checkout.inc => FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/oneclick-checkout.inc FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:07:20 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63477|0 |1 is obsolete| | --- Comment #22 from Tom?s Cohen Arazi --- Created attachment 64786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64786&action=edit Bug 18434: Add tests for K:SE:E::get_fixer_rules This patch tries to introduce exhaustive tests for this class method. I didn't try to provide a regression test for the current bug per-se, but cover the current method behaviour as much as I could. (kidclamp) I added a quick test of _convert_marc_to_json to use the mocking here and illuminate what the change does, before the patches this should fail (fields are indexed in place of one another), after it should succeed (new indexed fields are appended). A minor bug is highlighted by this new tests, I'll provide a followup for it. To test: - Run: $ sudo koha-shell kohadev k$ de kohaclone k$ prove t/db_dependent/Koha_Elasticsearch.t => FAIL: The returned fixer rules are not the expected ones Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:07:27 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63478|0 |1 is obsolete| | --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 64787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64787&action=edit Bug 18434: Elasticsearch indexing broken with newer catmandu version To test: 1 - Make sure you have latest koha deps, catmandu versions should be: libcatmandu-marc-perl 1.09-1~kohadev1 libcatmandu-perl 1.0304-2~kohadev1 2 - Reindex elastic 3 - Try searching and likely notice odd results 4 - Try: curl -XGET 'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true' with a known biblionumber and notice some null fields 5 - Apply patch 6 - Reindex 7 - Note fields are populated and search works as expected Signed-off-by: Chris Cormack Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:07:33 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63479|0 |1 is obsolete| | --- Comment #24 from Tom?s Cohen Arazi --- Created attachment 64788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64788&action=edit Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:07:39 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64386|0 |1 is obsolete| | --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 64789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64789&action=edit Bug 18434 - Followup - same changes for sort and facet fields To test: 1 - Index some stuff with multiple fields defined for sorting i.e. Authorites - make heading sortable - default is 110a and 111a for heading - a record with 111a empty will make the sort field empty 2 - view the record: curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true 3 - Note the blank field 4 - Apply patch 5 - Reindex 6 - Fields should be correctly populated Unit tests to follow (once I have the originals working for all) Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:07:45 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64773|0 |1 is obsolete| | --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 64790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64790&action=edit Bug 18434 - Followup fix tests for sorting and factes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:08:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:08:48 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #27 from Tom?s Cohen Arazi --- The last two patches for this one overlap with my patches for bug 18610, this ones are ok and i'm closing the other as duplicate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:09:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:09:14 +0000 Subject: [Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 18434 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:09:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 19:09:14 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 --- Comment #28 from Tom?s Cohen Arazi --- *** Bug 18610 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 01:39:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 23:39:52 +0000 Subject: [Koha-bugs] [Bug 17875] Linking to series authority records fails when a space precedes the semicolon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16804 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 01:39:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jul 2017 23:39:52 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17875 CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 02:21:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 00:21:52 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #18 from M. Tompsett --- Comment on attachment 62934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62934 [SIGNED OFF] Bug 10267: Show error message if user tries to enter too many characters for cardnumber Review of attachment 62934: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10267&attachment=62934) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +621,4 @@ > [% END %] > [% IF minlength_cardnumber == maxlength_cardnumber %] > > + [% IF mandatorycardnumber and not autoMemberNum %]Required[% END %]Card number must not be more than [% maxlength_cardnumber %] characters. It is impossible to enter more than maxlength_cardnumber characters because the maxlength attribute of the input line makes it impossible. I believe bug 13178, providing flexibility of the max size based on the schema which should be regenerated as needed to match the table's field size, makes this bug obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 03:10:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 01:10:41 +0000 Subject: [Koha-bugs] [Bug 18624] Software error when searching authorities in Elasticsearch - incorrect parameter "any" should be "all" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 03:23:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 01:23:44 +0000 Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Liz Rea --- Hi Kyle, Using the MODS url-encode works when you transfer it over to slimUtils, is that what you had in mind or something else? Seems like it sorts the problem nicely. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:36:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 05:36:17 +0000 Subject: [Koha-bugs] [Bug 18817] Screenshots not appearing in the manual linked to the Help tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |minor --- Comment #10 from Katrin Fischer --- The screenshots/images on manual.koha-community.org have been fixed, so this is no longer major. Maybe we should switch all links on master for the 17.11 release - as it can't be done automatically (changed headings/achors) and it's a lot of help files to fix. This here will only link from the start page to the new manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:37:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 05:37:30 +0000 Subject: [Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847 --- Comment #4 from Katrin Fischer --- +1 - nice idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:39:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 05:39:34 +0000 Subject: [Koha-bugs] [Bug 18876] Broken links in Koha documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:47:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 05:47:56 +0000 Subject: [Koha-bugs] [Bug 18876] Broken links in Koha documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18876 --- Comment #1 from Katrin Fischer --- Hi Pablo, thx for reporting and for the list. We are aware that a lot of links need to be fixed with the change to Sphinx as the headings/anchors have changed. Please take a look at https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual for some of the ongoing work on the manual :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 08:01:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 06:01:39 +0000 Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Updating severity as this is a blocker issue for libraries using one of those external methods with no passwords in the db for their users. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:41:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 08:41:51 +0000 Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe' attribute mapping defeats database constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719 --- Comment #6 from Oliver Bock --- Any update on this? Could you reproduce the issue? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:50:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 08:50:59 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 --- Comment #21 from Oliver Bock --- IMHO, this can be closed. Thanks again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:51:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 08:51:17 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 --- Comment #35 from Oliver Bock --- IMHO, this can be closed. Thanks again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:58:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 08:58:09 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #15 from Alex Arnaud --- Created attachment 64791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64791&action=edit Bug 8137 - Add default issuing rule for all branches. This patch does the same that for 'Default checkout limit by patron category'. test plan: - Create an issuing rule a patron category and itemtype. make it has priority, - create more permissive issuing rules for all other branches, - check that the priority rule is taken into account for this category and itemtype. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 14:00:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 12:00:03 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 --- Comment #47 from Marcel de Rooy --- (In reply to Nick Clemens from comment #45) > Signed-off-by: Nick Clemens Great! Thanks, Nick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 14:26:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 12:26:29 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot edit authorities |Resolve several problems |with authtypecode = default |related to Default | |authority framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 16:15:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 14:15:50 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61736|0 |1 is obsolete| | --- Comment #57 from David Gustafsson --- Created attachment 64792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64792&action=edit Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 16:51:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 14:51:37 +0000 Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685 DEVINIM changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim at devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 16:56:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 14:56:05 +0000 Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute updates to silently fail and corrupt existing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #36 from Katrin Fischer --- After releases we move older bugs from "RESOLVED FIXED" to "CLOSED FIXED" in a big bulk edit, but if you tested, it's ok to just do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:01:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 15:01:30 +0000 Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:01:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 15:01:31 +0000 Subject: [Koha-bugs] [Bug 18587] LDAP: update_local is entirely untested! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587 Bug 18587 depends on bug 14625, which changed state. Bug 14625 Summary: LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:04:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 15:04:03 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #58 from David Gustafsson --- The last change (adding the $options parameter) contained several mistakes, (hopefully) fixed those now. Have run the tests and did some manual testing (which I apparently did not do last time). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:24:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 15:24:08 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 --- Comment #5 from Colin Campbell --- (In reply to Marcel de Rooy from comment #4) > Colin: What about Patron Status now? > > If you provide no AD field, Patron Status responds with a CQN (without > Invalid > password). Should it return a CQ? > Same for empty AD; receive CQN. Should the new option change behavior here? > > Note: > Patron Info without AD does not return a CQ. (Should it?) > And an empty AD with allow_e_p returns a CQY. Patron status is a bit odd the CQ is like patron info in being an optional field, but unlike patron info the AD password field is a required field so I assume that a missing AD should provoke an invalid password in return. basically the behaviour has remained unchanged. In practice I cant recall seeing any kind of unit that uses patron status, I think when sip 2 was released patron info effectively superceded it. So I think we should leave functionality as is, just in case anything relies on the current behaviour. ( I tested on a very old sip software before any of the patches affecting patron info to confirm that behaviour hadnt been inadvertantly changed by other patches) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 20:21:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 18:21:57 +0000 Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus. ( make it work for existing instances) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:04:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 21:04:13 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #52 from Philippe Audet-Fortin --- Created attachment 64793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64793&action=edit Cam 722: Permet a n'importe quelle categorie d'avoir un garant (bz12446) Il s'agit du code du bz 12446 collapse en un commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:07:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 21:07:46 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:12:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 21:12:22 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63214|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:18:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 21:18:18 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60934|0 |1 is obsolete| | --- Comment #53 from Philippe Audet-Fortin --- Created attachment 64794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64794&action=edit Bug 12446 - Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:19:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 21:19:24 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 00:26:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jul 2017 22:26:03 +0000 Subject: [Koha-bugs] [Bug 18892] New: RDA fields not searchable as Publisher Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18892 Bug ID: 18892 Summary: RDA fields not searchable as Publisher Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 14198 - RDA: Indexing 264 field (Zebra) added an index called 'Provider' (with a CCL mapping of 'pv'). However, this does not allow bibs cataloged under RDA to be searched using the 'Publisher' search. Library of congress shows that 264 indicator 2 can be used to distinguish manufacture and distribution vs. publication: Second Indicator - Function of entity 0 - Production Field contains a statement relating to the inscription, fabrication, construction, etc., of a resource in an unpublished form. 1 - Publication Field contains a statement relating to the publication, release, or issuing of a resource. 2 - Distribution Field contains a statement relating to the distribution of a resource. 3 - Manufacture Field contains a statement relating to the printing, duplicating, casting, etc., of a resource in a published form. 4 - Copyright notice date Field contains a date associated with a notice of protection under copyright or a similar regime. Copyright dates include phonogram dates (i.e., dates associated with claims of protection for sound recordings). ... so indicator 2 values of 1 or 4 should correspond to publisher. We have the ability to specify indicator values when indexing; we should use it in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 08:06:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 06:06:10 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #23 from Katrin Fischer --- Thinking about this some more: We had a similar, but not quite the same problem with patron modification requests. It was solved with the system preference IndependentBranchesPatronModifications. So we could have a setting to see suggestions from all branches and a setting to see only your own. Ideally the suggestions page should reflect that as well in the preset filter. But patron modification requests always have a branch - suggestions do not. So 'only your own' does not quite work. Maybe the solution is to change the text of the message on the dashboard for this setting, so that it's clearer. I am not quite sure what would work here best. Thinking of something like: 1 suggestion for your branch [and 2 for any branch] are pending. I also like Fridolin's idea to make the selected option more visible as this has caused confusion in our libraries too. Instead of moving the acquisition filters to the top, I suggest having the branch filter outside and always visible, putting it below or over the tab organization filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 09:24:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 07:24:08 +0000 Subject: [Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #22 from Fridolin SOMERS --- I have tested, works well. But with biblio level item type, the image is displayed right of record text. Without patch it is left. Shouldn't it be CSS : .result-biblio-itemtype { float: left; ... ? I think display is better with image left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 10:18:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 08:18:47 +0000 Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 --- Comment #2 from Oliver Bock --- Given the relative urgency, can we assign this bug directly to the original author of the lines in question? He, Jonathan Druart, should be able to verify my assertions and fix the issue in no time. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 11:42:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 09:42:51 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #45 from Lari Taskula --- Created attachment 64795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64795&action=edit Bug 17499: (follow-up) Add information on digest being the only option to get_options If a library wants to force digest on a message type, add this information to Koha::Patron::Message::Preferences->get_options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 11:59:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 09:59:28 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 11:59:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 09:59:30 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 --- Comment #7 from Lari Taskula --- Created attachment 64796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64796&action=edit Bug 17505: REST API route for messaging preferences Get patron's / category's messaging preferences: GET /messaging_preferences?borrowernumber=123 - allowed if getting own preferences - otherwise borrowers flag required GET /messaging_preferences?categorycode=K - borrowers flag required Modify patron's / category's messaging preferences: PUT /messaging_preferences?borrowernumber=123 - allowed if modifying own preferences - otherwise borrowers flag required PUT /messaging_preferences?categorycode=K - borrowers flag required Returns the following JSON object (same for PUT except for readOnly values): { "Advanced_Notice": { "days_in_advance": { "configurable": true, "value": 20 }, "digest": { "configurable": true, "value": true }, "transport_types": { "email": true, "sms": false } }, "Another_Message_Name": { "days_in_advance": { "configurable": false, "value": null }, "digest": { ... }, ... } To test: 1. prove t/db_dependent/api/v1/messagingpreferences.t 2. Send GET and PUT requests to /api/v1/messaging_preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 12:00:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 10:00:34 +0000 Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 --- Comment #8 from Lari Taskula --- Depends on Bug 18137 and 17499. These Bugs will conflict in Koha/Exceptions.pm but should be easily fixable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 12:00:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 10:00:34 +0000 Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 [Bug 17505] REST API: Add route for messaging preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:08:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:08:45 +0000 Subject: [Koha-bugs] [Bug 18893] The dateformat sys pref not used everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18893 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:08:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:08:33 +0000 Subject: [Koha-bugs] [Bug 18893] New: The dateformat sys pref not used everywhere Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18893 Bug ID: 18893 Summary: The dateformat sys pref not used everywhere Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: fiona.borthwick at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The dateformat system preference is set to dd/mm/yyyy but this does not carry through to every screen. Examples noted are: Batch item modification - after entering barcodes the second screen shows date formats as 2017-07-03 Also the specific due date helper in checkout displays the chosen date in a different format. It should be consistent. Tested at 16.11 and 17.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:12:31 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:12:33 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64762|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 64797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64797&action=edit Bug 18755: Allow empty passwords in Patron Info to return OK With this patch a parameter 'allow_empty_passwords="1" can be added to a login in the SIP configuration file to allow the behaviour as was normal before the patch for bug 16610 was applied. Some sip clients rely on this behaviour sending an empty password field when they wish to validate to user but do not have the password. If a password is supplied it will be validated A test has been added to Message.t to confirm this behaviour Signed-off-by: Mark Tompsett Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:12:28 +0000 Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- Chris, can you file a separate bug for your report? I sounds like a related but separate issue to me. As for the initial issue of not having the relationship between fees and payments stored, I do believe Bug 14826 will solve the underlying problem, and one it is pushed we can work on revealing this data in the interface. (In reply to Chris Slone from comment #2) > Hi, > > This is still an issue and is in need of fixing as it presents a potentially > more severe problem when paying the replacement charge for an item if the > item is still checked-out to the patron. So, for example, if your cronjob is > set to mark an item lost and you charge patron's for lost items, using > anything other than the 'pay' button will not remove the item from the > patron's checkouts after the charge has been paid. > > To replicate: > > 1.) Set preference WhenLostChargeReplacementFee to 'Charge' > 2.) Edit the record of a checked-out item to the lost status indicated by > your DefaultLongOverdueChargeValue. Note: To keep the item checked-out, this > must be done by opening and editing the item's record (not directly from the > items tab of the bibliographic record). You can also use an item that your > longoverdue cronjob marked. > 3.) Confirm that the item is still checked-out to the patron and that the > replacement fee was charged. > 4.) Use pay selected, pay amount, write off, or write off all with the > replacement charge and confirm the action as normal. > 5.) The charge will be removed but the item will still be checked-out to the > patron's record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:12:52 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:13:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:13:27 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 --- Comment #7 from Marcel de Rooy --- (In reply to Colin Campbell from comment #5) > (In reply to Marcel de Rooy from comment #4) > Patron status is a bit odd the CQ is like patron info in being an optional > field, but unlike patron info the AD password field is a required field so I > assume that a missing AD should provoke an invalid password in return. > basically the behaviour has remained unchanged. In practice I cant recall > seeing any kind of unit that uses patron status, I think when sip 2 was > released patron info effectively superceded it. So I think we should leave > functionality as is, just in case anything relies on the current behaviour. > ( I tested on a very old sip software before any of the patches affecting > patron info to confirm that behaviour hadnt been inadvertantly changed by > other patches) Clear enough. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:54:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:54:13 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #54 from Philippe Audet-Fortin --- I corrected my old mistake (hope it doesn't affect the rest of the code :)) and rebase it. Now the patch apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:55:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 11:55:24 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #55 from Philippe Audet-Fortin --- Comment on attachment 64793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64793 Cam 722: Permet a n'importe quelle categorie d'avoir un garant (bz12446) >From 0ca1ba90904daea5fac5285799b38f8dfb0b6265 Mon Sep 17 00:00:00 2001 >From: Paudet >Date: Tue, 4 Jul 2017 16:41:04 -0400 >Subject: [PATCH] Cam 722: Permet a n'importe quelle categorie d'avoir un > garant (bz12446) > >Il s'agit du code du bz 12446 collapse en un commit. >--- > C4/Members/Attributes.pm | 19 ++++++++++++- > C4/Utils/DataTables/Members.pm | 24 +++++++++++----- > Koha/Schema/Result/Category.pm | 8 ++++++ > admin/categories.pl | 3 ++ > .../atomicupdate/bug_12446-EnableAdultGarantee.sql | 11 ++++++++ > installer/data/mysql/kohastructure.sql | 3 +- > installer/data/mysql/sysprefs.sql | 4 ++- > .../prog/en/modules/admin/categories.tt | 15 ++++++++++ > .../prog/en/modules/admin/preferences/patrons.pref | 5 ++++ > .../prog/en/modules/common/patron_search.tt | 7 +++-- > .../prog/en/modules/members/memberentrygen.tt | 6 ++-- > .../prog/en/modules/members/moremember.tt | 30 ++++++++++++-------- > .../en/modules/members/tables/guarantor_search.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/js/members.js | 18 ++++-------- > members/memberentry.pl | 20 +++++++------ > members/moremember.pl | 33 ++++++++++++++++++++-- > svc/members/search | 2 ++ > 17 files changed, 156 insertions(+), 54 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql > >diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm >index ab43a7c..2f3bd49 100644 >--- a/C4/Members/Attributes.pm >+++ b/C4/Members/Attributes.pm >@@ -32,7 +32,7 @@ BEGIN { > @EXPORT_OK = qw(GetBorrowerAttributes GetBorrowerAttributeValue CheckUniqueness SetBorrowerAttributes > DeleteBorrowerAttribute UpdateBorrowerAttribute > extended_attributes_code_value_arrayref extended_attributes_merge >- SearchIdMatchingAttribute); >+ SearchIdMatchingAttribute get_guarantor_shared_attributes); > %EXPORT_TAGS = ( all => \@EXPORT_OK ); > } > >@@ -383,6 +383,23 @@ sub _sort_by_code { > return $x->{code} cmp $y->{code} || $x->{value} cmp $y->{value}; > } > >+=head2 get_guarantor_shared_attributes >+ >+ $guarantor_attributes = get_guarantor_attributes(); >+ >+ returns an array reference containing attributes to be shared between guarantor and guarantee. >+ >+=cut >+ >+sub get_guarantor_shared_attributes{ >+ my @attributes = qw( streetnumber address address2 city state zipcode country branchcode phone phonepro mobile email emailpro fax ); >+ if( my @additional = split(/\|/, C4::Context->preference("AdditionalGuarantorField")) ){ >+ $_ =~ s/(?:^\s+)|(?:\s+$)//g for (@additional); # Trim whitespaces >+ @attributes = ( @attributes, @additional); >+ } >+ return \@attributes; >+} >+ > =head1 AUTHOR > > Koha Development Team >diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm >index 302eaff..846bcb3 100644 >--- a/C4/Utils/DataTables/Members.pm >+++ b/C4/Utils/DataTables/Members.pm >@@ -2,6 +2,8 @@ package C4::Utils::DataTables::Members; > > use Modern::Perl; > use C4::Context; >+use C4::Members; >+use C4::Members::Attributes qw/get_guarantor_shared_attributes/; > use C4::Utils::DataTables; > use Koha::DateUtils; > >@@ -47,13 +49,21 @@ sub search { > > } > >- my $select = "SELECT >- borrowers.borrowernumber, borrowers.surname, borrowers.firstname, >- borrowers.streetnumber, borrowers.streettype, borrowers.address, >- borrowers.address2, borrowers.city, borrowers.state, borrowers.zipcode, >- borrowers.country, cardnumber, borrowers.dateexpiry, >- borrowers.borrowernotes, borrowers.branchcode, borrowers.email, >- borrowers.userid, borrowers.dateofbirth, borrowers.categorycode, >+ $dbh = C4::Context->dbh; >+ my @columns = qw( borrowernumber surname firstname streetnumber streettype address address2 city state zipcode country cardnumber dateexpiry borrowernotes branchcode email userid dateofbirth categorycode ); >+ if( my @guarantor_attributes = @{ get_guarantor_shared_attributes() }){ >+ foreach my $item (@guarantor_attributes) { >+ if (! grep {$_ eq $item} @columns) { >+ push @columns, $item; >+ } >+ } >+ }; >+ my $borrowers_columns = ""; >+ foreach my $item (@columns) { >+ $borrowers_columns .= "borrowers." . $item . ", "; >+ } >+ >+ my $select = "SELECT " . $borrowers_columns . " > categories.description AS category_description, categories.category_type, > branches.branchname"; > my $from = "FROM borrowers >diff --git a/Koha/Schema/Result/Category.pm b/Koha/Schema/Result/Category.pm >index fc26a7d..f655fd9 100644 >--- a/Koha/Schema/Result/Category.pm >+++ b/Koha/Schema/Result/Category.pm >@@ -109,6 +109,12 @@ __PACKAGE__->table("categories"); > default_value: -1 > is_nullable: 0 > >+=head2 canbeguarantee >+ >+ data_type: 'tinyint' >+ default_value: 0 >+ is_nullable: 0 >+ > =head2 default_privacy > > data_type: 'enum' >@@ -161,6 +167,8 @@ __PACKAGE__->add_columns( > default_value => -1, > is_nullable => 0, > }, >+ "canbeguarantee", >+ { data_type => "tinyint", default_value => 0, is_nullable => 0}, > "default_privacy", > { > data_type => "enum", >diff --git a/admin/categories.pl b/admin/categories.pl >index 358ef7d..dbaaf48 100755 >--- a/admin/categories.pl >+++ b/admin/categories.pl >@@ -93,6 +93,7 @@ elsif ( $op eq 'add_validate' ) { > my $checkPrevCheckout = $input->param('checkprevcheckout'); > my $default_privacy = $input->param('default_privacy'); > my @branches = grep { $_ ne q{} } $input->multi_param('branches'); >+ my $canbeguarantee = $input->param('canbeguarantee'); > > my $is_a_modif = $input->param("is_a_modif"); > >@@ -119,6 +120,7 @@ elsif ( $op eq 'add_validate' ) { > $category->hidelostitems($hidelostitems); > $category->overduenoticerequired($overduenoticerequired); > $category->category_type($category_type); >+ $category->canbeguarantee($canbeguarantee); > $category->BlockExpiredPatronOpacActions($BlockExpiredPatronOpacActions); > $category->checkprevcheckout($checkPrevCheckout); > $category->default_privacy($default_privacy); >@@ -145,6 +147,7 @@ elsif ( $op eq 'add_validate' ) { > hidelostitems => $hidelostitems, > overduenoticerequired => $overduenoticerequired, > category_type => $category_type, >+ canbeguarantee => $canbeguarantee, > BlockExpiredPatronOpacActions => $BlockExpiredPatronOpacActions, > checkprevcheckout => $checkPrevCheckout, > default_privacy => $default_privacy, >diff --git a/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql b/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql >new file mode 100644 >index 0000000..56462a7 >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql >@@ -0,0 +1,11 @@ >+-- ******** -- >+-- SYSPREFS -- >+-- ******** -- >+INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) >+VALUES ('AdditionalGuarantorField','',NULL,'Additional fields name to be transfer from guarantor to guarantee.','free'); >+ >+-- ********* -- >+-- STRUCTURE -- >+-- ********* -- >+ALTER TABLE categories ADD COLUMN `canbeguarantee` tinyint(1) NOT NULL default '0'; >+UPDATE categories SET canbeguarantee = 1 WHERE category_type = 'P' OR category_type = 'C'; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index e9c60aa..7e3bc48 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -331,8 +331,9 @@ CREATE TABLE `categories` ( -- this table shows information related to Koha patr > `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) > `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff) > `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this category can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BlockExpiredPatronOpacActions >- `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category >+ `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category, > `checkprevcheckout` varchar(7) NOT NULL default 'inherit', -- produce a warning for this patron category if this item has previously been checked out to this patron if 'yes', not if 'no', defer to syspref setting if 'inherit'. >+ `canbeguarantee` tinyint(1) NOT NULL default '0' > PRIMARY KEY (`categorycode`), > UNIQUE KEY `categorycode` (`categorycode`) > ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 0bd8cac..27173df 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -6,7 +6,9 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('AcquisitionDetails', '1', '', 'Hide/Show acquisition details on the biblio detail page.', 'YesNo'), > ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: his own only, any within his branch or all','Choice'), > ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'), >-('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'), >+('AdditionalGuarantorField','',NULL,'Additional fields name to be transfer from guarantor to guarantee.','free'), >+('AddPatronLists','categorycode','categorycode|category_type','Allow user to choose what list to pick up from when adding patrons','Choice'), >+('AddressFormat','us','','Choose format to display postal addresses', 'Choice'), > ('advancedMARCeditor','0','','If ON, the MARC editor won\'t display field/subfield descriptions','YesNo'), > ('AdvancedSearchLanguages','','','ISO 639-2 codes of languages you wish to see appear as an Advanced search option. Example: eng|fre|ita','Textarea'), > ('AdvancedSearchTypes','itemtypes','itemtypes|ccode','Select which set of fields comprise the Type limit in the advanced search','Choice'), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >index e33b36f..b115aa4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt >@@ -151,6 +151,18 @@ > > Required > >+
  • >+ >+ >+
  • >
  • > > [% END %] >
  • >- [% END %] >- [% UNLESS nocontactfirstname %] >-
  • >+ [% UNLESS nocontactfirstname %] >+
  • > > [% IF ( guarantorid ) %] > [% contactfirstname %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index 6e5308f..c106093 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -222,8 +222,7 @@ function validate1(date) { > [% title | html %] [% firstname | html %] [% END %] [% surname | html %] ([% cardnumber | html %]) >
    >
    >- >- [% UNLESS ( I ) %][% IF ( othernames ) %]“[% othernames | html %]”[% END %] >+ [% UNLESS ( I ) %][% IF ( othernames ) %]“[% othernames %]”[% END %] > >
    > [% IF Koha.Preference( 'AddressFormat' ) %] >@@ -254,16 +253,23 @@ function validate1(date) { > [% IF ( sex ) %]
  • Gender: > [% IF ( sex == 'F' ) %]Female[% ELSIF ( sex == 'M' ) %]Male[% ELSE %][% sex %][% END %] >
  • [% END %][% END %] >- [% IF guarantees %] >-
  • >- Guarantees: >- >-
  • >- [% ELSIF guarantor %] >+ [% IF ( isguarantee ) %] >+ [% IF ( guaranteeloop ) %] >+
  • Guarantees: >+ [% FOREACH guaranteeloo IN guaranteeloop %] >+ >+ >+ >+ [% END %] >+ >+ >+ >+ >+
    [% guaranteeloo.name %][% guaranteeloo.finesguarantee %]
    Total[% amounttot %]
    >+
  • >+ [% END %] >+ [% END %] >+ [% IF ( isguarantor ) %] >
  • > Guarantor: > [% IF guarantor.borrowernumber %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt >index f1bb9a1..5817391 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt >@@ -17,7 +17,7 @@ > "dt_address": > "[% INCLUDE escape_address data=data %]", > "dt_action": >- "Select" >+ "Select" > }[% UNLESS loop.last %],[% END %] > [% END %] > ] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/members.js b/koha-tmpl/intranet-tmpl/prog/js/members.js >index 28853b2..c476469 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/members.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/members.js >@@ -183,7 +183,7 @@ function update_category_code(category_code) { > $(mytables).find(" li[data-category_code='']").show(); > } > >-function select_user(borrowernumber, borrower) { >+function select_user(borrowernumber, borrower, attributes) { > var form = $('#entryform').get(0); > if (form.guarantorid.value) { > $("#contact-details, #quick_add_form #contact-details").find('a').remove(); >@@ -206,14 +206,11 @@ function select_user(borrowernumber, borrower) { > .before('' + borrower.firstname + '').get(0).type = 'hidden'; > $("#quick_add_form #contactfirstname").val(borrower.firstname).before(''+borrower.firstname+' >- form.streetnumber.value = borrower.streetnumber; >- form.address.value = borrower.address; >- form.address2.value = borrower.address2; >- form.city.value = borrower.city; >- form.state.value = borrower.state; >- form.zipcode.value = borrower.zipcode; >- form.country.value = borrower.country; >- form.branchcode.value = borrower.branchcode; >+ form.guarantorsearch.value = LABEL_CHANGE; >+ for (var i = 0; i < attributes.length; i++) { >+ var attribute = attributes[i]; >+ document.forms.entryform[attribute].value = borrower[attribute]; >+ } > > $("#quick_add_form #streetnumber").val(borrower.streetnumber); > $("#quick_add_form #address").val(borrower.address); >@@ -224,9 +221,6 @@ function select_user(borrowernumber, borrower) { > $("#quick_add_form #country").val(borrower.country); > $("#quick_add_form select[name='branchcode']").val(borrower.branchcode); > >- form.guarantorsearch.value = LABEL_CHANGE; >- $("#quick_add_form #guarantorsearch").val(LABEL_CHANGE); >- > return 0; > } > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 2ffea5d..eef8554 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -240,21 +240,21 @@ if ( ( $op eq 'insert' ) and !$nodouble ) { > } > } > >- #recover all data from guarantor address phone ,fax... >-if ( $guarantorid ) { >+#recover all data from guarantor address phone ,fax... >+if ( $guarantorid) { >+ > if (my $guarantordata=GetMember(borrowernumber => $guarantorid)) { > $category_type = $guarantordata->{categorycode} eq 'I' ? 'P' : 'C'; > $guarantorinfo=$guarantordata->{'surname'}." , ".$guarantordata->{'firstname'}; > $newdata{'contactfirstname'}= $guarantordata->{'firstname'}; > $newdata{'contactname'} = $guarantordata->{'surname'}; > $newdata{'contacttitle'} = $guarantordata->{'title'}; >+ > if ( $op eq 'add' ) { >- foreach (qw(streetnumber address streettype address2 >- zipcode country city state phone phonepro mobile fax email emailpro branchcode >- B_streetnumber B_streettype B_address B_address2 >- B_city B_state B_zipcode B_country B_email B_phone)) { >- $newdata{$_} = $guarantordata->{$_}; >- } >+ my @attributes = @{C4::Members::Attributes::get_guarantor_shared_attributes()}; >+ foreach my $attribute (@attributes) { >+ $newdata{$attribute} = $guarantordata->{$attribute}; >+ } > } > } > } >@@ -720,7 +720,9 @@ if (C4::Context->preference('EnhancedMessagingPreferences')) { > $template->param(TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification")); > } > >-$template->param( "showguarantor" => ($category_type=~/A|I|S|X/) ? 0 : 1); # associate with step to know where you are >+$template->param( "showguarantor" => $categorycode ? Koha::Patron::Categories->find($categorycode)->canbeguarantee : 1); # associate with step to know where you are >+ >+$template->param( "guarantor_attributes" => C4::Members::Attributes::get_guarantor_shared_attributes() ); > $debug and warn "memberentry step: $step"; > $template->param(%data); > $template->param( "step_$step" => 1) if $step; # associate with step to know where u are >diff --git a/members/moremember.pl b/members/moremember.pl >index 0649dcf..1767a5c 100755 >--- a/members/moremember.pl >+++ b/members/moremember.pl >@@ -177,7 +177,6 @@ if ( $category_type eq 'C') { > > my @relatives; > if ( my $guarantor = $patron->guarantor ) { >- $template->param( guarantor => $guarantor ); > push @relatives, $guarantor->borrowernumber; > push @relatives, $_->borrowernumber for $patron->siblings; > } elsif ( $patron->contactname || $patron->contactfirstname ) { >@@ -189,15 +188,43 @@ if ( my $guarantor = $patron->guarantor ) { > ); > } else { > my @guarantees = $patron->guarantees; >- $template->param( guarantees => \@guarantees ); > push @relatives, $_->borrowernumber for @guarantees; > } > > my $relatives_issues_count = > Koha::Database->new()->schema()->resultset('Issue') > ->count( { borrowernumber => \@relatives } ); >+my @guarantees = $patron->guarantees; >+my $count = scalar @guarantees; >+if ( $count ) { >+ $template->param( isguarantee => 1 ); >+ >+ my @guaranteedata; >+ my $amount; >+ my $totalmount = 0; >+ >+ foreach my $guarantee (@guarantees){ >+ my ($amount,$accts,undef) = GetMemberAccountRecords($guarantee->borrowernumber); >+ push(@guaranteedata, >+ { >+ borrowernumber => $guarantee->borrowernumber, >+ cardnumber => $guarantee->cardnumber, >+ finesguarantee => sprintf("%.2f",$amount), >+ name => $guarantee->firstname . " " >+ . $guarantee->surname >+ } >+ ); >+ $totalmount += $amount; >+ } >+ $template->param( guaranteeloop => \@guaranteedata ); >+ $template->param( amounttot => sprintf("%.2f",$totalmount)); >+} >+( $template->param( adultborrower => 1 ) ) if ( $category_type eq 'A' || $category_type eq 'I' ); > >-$template->param( adultborrower => 1 ) if ( $category_type eq 'A' || $category_type eq 'I' ); >+if (my $guarantor = $patron->guarantor){ >+ $template->param(isguarantor => 1); >+ $template->param(guarantor => $guarantor); >+} > > my %bor; > $bor{'borrowernumber'} = $borrowernumber; >diff --git a/svc/members/search b/svc/members/search >index 4f798ab..cdebc80 100755 >--- a/svc/members/search >+++ b/svc/members/search >@@ -108,12 +108,14 @@ if ($has_permission) { > $results->{iTotalDisplayRecords} = scalar( @patrons_with_permission ); > } > >+my @attributes = C4::Members::Attributes::get_guarantor_shared_attributes(); > $template->param( > sEcho => $sEcho, > iTotalRecords => $results->{iTotalRecords}, > iTotalDisplayRecords => $results->{iTotalDisplayRecords}, > aaData => $results->{patrons}, > selection_type => $selection_type, >+ attributes => @attributes > ); > > output_with_http_headers $input, $cookie, $template->output, 'json'; >-- >1.9.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 14:16:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 12:16:38 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |18235 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 14:16:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 12:16:38 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 [Bug 18213] Add language facets to Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 14:16:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 12:16:41 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #2 from Nick Clemens --- Created attachment 64798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64798&action=edit Bug 18213 - Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 14:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 12:26:24 +0000 Subject: [Koha-bugs] [Bug 17908] Authority merge omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17380 --- Comment #19 from Marcel de Rooy --- Although several authority issues on bug 17380 are outside the scope of this omnibus, I will include a patch on 17380 that still adds a refinement of sub merge. Therefore adding this report to the dependency list too. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 [Bug 17380] Resolve several problems related to Default authority framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 14:26:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 12:26:24 +0000 Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default authority framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 15:34:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 13:34:09 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #63 from Jonathan Druart --- (In reply to Katrin Fischer from comment #61) > I have massive problems making this work with 16.11.x - starting with the > Return.t tests. And now an error in Circulation.pm. I think I am missing > dependencies for the new Koha::Object work again. Can someone help? I have rebased and add a commit to adapt the code to 16.11.x Everything is pushed to the bug_18651_16.11.x branch on my github repo - https://github.com/joubu/Koha/commits/bug_18651_16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 15:55:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 13:55:32 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 --- Comment #9 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #8) > (In reply to Jonathan Druart from comment #7) > > Remote branch has been rebased. > > It doesn't apply due to updatedatabase.pl conflicts... I'm sorry, the updatedatabase.pl merge problem was not the problem (easy fix). The problem was in Circulation.pm: diff --cc C4/Circulation.pm index 7e65a80,789a85f..0000000 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@@ -1903,16 -1904,15 +1904,23 @@@ sub AddReturn } if ($borrowernumber) { ++<<<<<<< HEAD ++======= + if ( ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue ) || $return_date ) { + _CalculateAndUpdateFine( { issue => $issue, item => $item, borrower => $borrower, return_date => $return_date } ); + } + ++>>>>>>> dadae20... Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls eval { - MarkIssueReturned( $borrowernumber, $item->{'itemnumber'}, + my $issue_id = MarkIssueReturned( $borrowernumber, $item->{'itemnumber'}, $circControlBranch, $return_date, $borrower->{'privacy'} ); + $issue->{issue_id} = $issue_id; }; - if ( $@ ) { + unless ( $@ ) { + if ( ( C4::Context->preference('CalculateFinesOnReturn') && $issue->{'overdue'} ) || $return_date ) { + _CalculateAndUpdateFine( { issue => $issue, item => $item, borrower => $borrower, return_date => $return_date } ); + } + } else { $messages->{'Wrongbranch'} = { Wrongbranch => $branch, Rightbranch => $message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 15:57:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 13:57:15 +0000 Subject: [Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #64 from Katrin Fischer --- Thx a lot, I will try to test ASAP. If someone wants to help and test against 16.11.x too, that would be much appreciated. Hope we can fix this for good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 16:32:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 14:32:57 +0000 Subject: [Koha-bugs] [Bug 18894] New: Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 Bug ID: 18894 Summary: Add ability to limit the number of messages sent by misc/cronjobs/process_message_queue.pl at a time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Having the ability to limit the number of messages sent by process_message_queue.pl on a single run would be very useful for controlling home many messages are sent at a given time. This can help prevent too many messages being sent out at once and getting flagged as a spammer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 16:33:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 14:33:02 +0000 Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 16:35:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 14:35:45 +0000 Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 --- Comment #1 from Kyle M Hall --- Created attachment 64801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64801&action=edit Bug 18894 - Add ability to limit the number of messages sent by misc/cronjobs/process_message_queue.pl at a time Having the ability to limit the number of messages sent by process_message_queue.pl on a single run would be very useful for controlling home many messages are sent at a given time. This can help prevent too many messages being sent out at once and getting flagged as a spammer. Test Plan: 1) Apply this patch 2) Generate some number of messages in the message queue 3) Run process_message_queue.pl with the new --limit option, set limit to a number smaller than the number of pending messages 4) After the script has run, check the database and note that only a number of pending messages were sent, and that the remaining amount of pending messages is the original amount less the number specified as the limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 16:35:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 14:35:42 +0000 Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:03:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:03:36 +0000 Subject: [Koha-bugs] [Bug 18895] New: Lost Items Not Removed From Patron' s Account When Charge is Paid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Bug ID: 18895 Summary: Lost Items Not Removed From Patron's Account When Charge is Paid Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cslone at camdencountylibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, There is a potentially severe problem when paying the replacement charge for an item if the item is still checked-out to a patron. For example, if your cronjob is set to mark an item lost and you charge patrons for lost items, using anything other than the 'pay' button will not remove the item from the patron's checkouts after the charge has been paid. 'Pay selected,' 'Pay amount,' Write off,' or 'Write off all' will take care of the charge, but the item will remain checked-out and marked as 'Long Overdue / Lost' on the patron's record. Additionally, it is difficult to identify these erroneous items if staff does not catch it them immediately, making it hard to correct lingering problems. To replicate: 1.) Set preference WhenLostChargeReplacementFee to 'Charge' 2.) Edit the record of a checked-out item to the lost status indicated by your DefaultLongOverdueChargeValue. Note: To keep the item checked-out, this must be done by opening and editing the item's record (not directly from the items tab of the bibliographic record). You can also use an item that your longoverdue cronjob marked. 3.) Confirm that the item is still checked-out to the patron and that the replacement fee was charged. 4.) Use pay selected, pay amount, write off, or write off all with the replacement charge and confirm the action as you normally would. 5.) The charge will be removed but the item will still be checked-out to the patron's record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:03:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:03:48 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron' s Account When Charge is Paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8016 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:03:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:03:48 +0000 Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 Chris Slone changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18895 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:04:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:04:45 +0000 Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using "global" action. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016 --- Comment #4 from Chris Slone --- New bug submitted and linked to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:26:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:26:22 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #48 from Philippe Audet-Fortin --- Created attachment 64802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64802&action=edit Bug 12532 - Changed occurrences to EnableRedirectGuaranteeEmail for RedirectGuaranteeEmail Both were used for the same reason and EnableRedirectGuaranteeEmail doesn't existe in systempreferences table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:26:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:26:52 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:28:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:28:20 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:28:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:28:25 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:28:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:28:38 +0000 Subject: [Koha-bugs] [Bug 18896] New: Changes to Patron' s Contact Info Not Logged if Submitted Via OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18896 Bug ID: 18896 Summary: Changes to Patron's Contact Info Not Logged if Submitted Via OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: cslone at camdencountylibrary.org QA Contact: testopia at bugs.koha-community.org If a patron used the OPAC to update their contact information it is not recorded in the logs. To replicate: 1.) Make sure that Logging->BorrowersLog is set to 'Log' and that Opac preferences->Features->Opacpatrondetails is set to 'Allow.' 2.) Log in to the OPAC, go to the 'your personal details' tab, make changes, and click 'submit update request.' 3.) In staff clien, go to the pending patron modification, select approve, and click 'submit.' 4.) Go to the patron's record and click on the 'Patron Modification Log' tab, the log will not reflect the modification. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:29:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:29:49 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:29:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:29:52 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 --- Comment #1 from Kyle M Hall --- Created attachment 64803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64803&action=edit Bug 18725 - Process_message_queue sends duplicate emails if message_queue is not writable. Last week, we had a database server whose disk filled, causing database writes to fail. This meant that messages in message_queue marked 'pending' were not marked as 'sent' when they were added to the postfix mail queue; messages were sent every 15 minutes (as specified in the cron job) until the disk space issues were cleared. I would suggest adding a token write to the start of process_message_queue.pl as a 'canary in the coal mine'. If the database write fails, process_message_queue should stop, because it's not safe to proceed sending emails that may not be marked 'sent'. I have no good idea on how to test this patch so this is what I've got: Test Plan: 1) Apply this patch 2) prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:40:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:40:30 +0000 Subject: [Koha-bugs] [Bug 18891] Download Reports Directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:44:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:44:05 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #49 from Philippe Audet-Fortin --- Corrected minor error. However, "Bug 12532 - QA Follow-up" give me a Sha1 error so it couldn't be applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 17:46:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 15:46:08 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #50 from Philippe Audet-Fortin --- Corrected minor error. However, "Bug 12532 - QA Follow-up" give me a Sha1 error so it couldn't be applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:13:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:13:00 +0000 Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64801|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 64804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64804&action=edit Bug 18894 - Add ability to limit the number of messages sent by misc/cronjobs/process_message_queue.pl at a time Having the ability to limit the number of messages sent by process_message_queue.pl on a single run would be very useful for controlling home many messages are sent at a given time. This can help prevent too many messages being sent out at once and getting flagged as a spammer. Test Plan: 1) Apply this patch 2) Generate some number of messages in the message queue 3) Run process_message_queue.pl with the new --limit option, set limit to a number smaller than the number of pending messages 4) After the script has run, check the database and note that only a number of pending messages were sent, and that the remaining amount of pending messages is the original amount less the number specified as the limit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:14:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:14:57 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:15:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:15:11 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #39 from Jonathan Druart --- Created attachment 64806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64806&action=edit Bug 17680: Fix regression - is_overdue must be called is_overdue must be called even if there is not dropbox date (!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:15:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:15:17 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #40 from Jonathan Druart --- Created attachment 64807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64807&action=edit Bug 17680: Add few tests for AddReturn when overdue To make sure the last patch fixes the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:15:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:15:06 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64259|0 |1 is obsolete| | Attachment #64284|0 |1 is obsolete| | Attachment #64337|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 64805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64805&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls There are a few calls to GetItemIssue where it's not as easy to make sure everything will be fine just replacing the calls with a Koha::Issues->find - In AddReturn the overdue flag is used (that's why this patch depends on bug 17689) - In CanBookBeRenewed, as well as the overdue flag the dates converted to DateTime were used. It's now our job to convert them when we need them. - Same in AddRenewal but we also call _CalculateAndUpdateFine, so we need to update the variables in this subroutine. Note that, prior to this patch, AddReturn returned the GetItemIssue hashref in the $iteminformation. Most of the time this variable is not used, I have found only 1 place where it's used: circ/returns.pl TODO: In this script we should call ->is_overdue instead of the DateTime->compare calls Test plan: All the circulation tests must pass (it's how I have caught the specific cases). Do some checkins/checkouts/renewal and focus on the due date Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:18:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:18:25 +0000 Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- (In reply to Oliver Bock from comment #0) > The regression itself is a logical error as "@return = (0)" is considered to > be "false" when checked with "unless". That's wrong as "unless" tests the > number of elements in a list. Thus the "falsy" condition has to established > with "@return = ()" instead. Where did you find this condition? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:19:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:19:11 +0000 Subject: [Koha-bugs] [Bug 9599] printable work slip on receive in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9599 Sandre Cunha changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cunha at monterey.org --- Comment #1 from Sandre Cunha --- Has anyone looked into the feasibility of doing this? It would really speed up the process, especially for larger libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:20:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:20:30 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:20:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:20:33 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 --- Comment #2 from Nick Clemens --- Created attachment 64808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64808&action=edit Bug 13560 - need an add option in marc modification templates Add/Update would update a field or create new if it existed, but didn't allow for creating new if the field existed. This patchset splits the options to Add & Update so that add will always add a field and Update will operate as it always has To test: 1 - Have a record with a known existing field (make a copy) 2 - Define a marc modification template that 'Add/update' on that field 3 - Define an 'Add/Update' on a field that doesn't exist 4 - Batch modify the copy of record using the above template 5 - Verify the existing field was updated 6 - Verify the non-existing field was updated 7 - Apply patch 8 - Make another copy 9 - Modify the copy with the same template as above 10 - Should match initial modification 11 - Add a new rule to add a new field 12 - Modify using the updated template 13 - Ensure your new field is created 14 - Test various options in the modification tool 15 - prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:20:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:20:54 +0000 Subject: [Koha-bugs] [Bug 13560] need an add option in marc modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 18:34:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 16:34:07 +0000 Subject: [Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #10 from Jonathan Druart --- Remote branch has been rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:05:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:05:06 +0000 Subject: [Koha-bugs] [Bug 17554] Move GetBorrowersWithEmail to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:05:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:05:18 +0000 Subject: [Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:05:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:05:35 +0000 Subject: [Koha-bugs] [Bug 17843] Move C4::Koha::getitemtypeinfo to Koha::ItemTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17843 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:05:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:05:52 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:06:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:06:08 +0000 Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to use/understand In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #48 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:06:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:06:22 +0000 Subject: [Koha-bugs] [Bug 18782] Remove unused C4::Serials::getsupplierbyserialid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18782 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:11:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:11:51 +0000 Subject: [Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Hello, If this patch is ready to be tested you should change the status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:45:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:45:46 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:46:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:46:01 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #51 from Jonathan Druart --- Created attachment 64810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64810&action=edit Bug 18276: Remove GetBiblioFromItemNumber - ILSDI Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1 The results should be the same before and after this patch Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:46:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:46:08 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #52 from Jonathan Druart --- Created attachment 64811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64811&action=edit Bug 18276: Remove GetBiblioFromItemNumber - circulation pages Test plan: 1. Checkout items in a batch The information displayed should be ok (title, subtitles, author, itemnotes, barcode) 2. Checkout an item using the standard checkout page You should correctly see the information of the item that has been checked out (title and author) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:45:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:45:54 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63294|0 |1 is obsolete| | Attachment #63295|0 |1 is obsolete| | Attachment #63296|0 |1 is obsolete| | Attachment #63297|0 |1 is obsolete| | Attachment #63298|0 |1 is obsolete| | Attachment #63299|0 |1 is obsolete| | Attachment #63300|0 |1 is obsolete| | Attachment #64748|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart --- Created attachment 64809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64809&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Course reserves Values from the items, biblio and biblioitems tables are used in the template, so we need to pass all of them to the template, but separately. That way we easily see which field from which table we are displaying. Test plan: Create a course reserve and add items. Correct information must be displayed on the detail page of the course reserve, on staff and OPAC interface. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:46:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:46:14 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #53 from Jonathan Druart --- Created attachment 64812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64812&action=edit Bug 18276: Remove GetBiblioFromItemNumber - Easy ones The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:46:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:46:19 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #54 from Jonathan Druart --- Created attachment 64813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64813&action=edit Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:46:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:46:24 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #55 from Jonathan Druart --- Created attachment 64814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64814&action=edit Bug 18276: FIX status display for course reserves This include file is terribly wrong, it's called from different places that do not set the same flag. The status from detail and result page might be different from the one display on the course reserve table. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:46:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:46:29 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #56 from Jonathan Druart --- Created attachment 64815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64815&action=edit Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - ILSDI Take into account biblio level holds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:46:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:46:34 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #57 from Jonathan Druart --- Created attachment 64816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64816&action=edit Bug 18276: [QA Follow-up] Two newlines to make qa tools happy FAIL pod Apparent command =cut not preceded by blank line in file misc/cronjobs/advance_notices.pl FAIL pod Apparent command =cut not preceded by blank line in file C4/SIP/ILS/Item.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:48:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:48:14 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #58 from Jonathan Druart --- Fixed conflicts with bug 17843 and bug 17738. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:48:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:48:37 +0000 Subject: [Koha-bugs] [Bug 18897] New: Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Bug ID: 18897 Summary: Koha_Elasticsearch_Indexer.t doesn't skip when ES module not installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: ldjamison at marywood.edu QA Contact: testopia at bugs.koha-community.org Running "prove t/db_dependent/Koha_Elasticsearch_Indexer.t" fails instead of skipping if Catmandu::Importer::MARC is not installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:58:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:58:40 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #59 from Jonathan Druart --- Created attachment 64817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64817&action=edit Bug 18276: barcode may be nonexistent when checking out/in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:59:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:59:20 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 19:59:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 17:59:32 +0000 Subject: [Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 --- Comment #60 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #49) > Add checks for find please. > > Can't call method "biblio" on an undefined value at circ/circulation.pl line > 334. > > Before this patch set you get a warning on an unknown barcode, now an > Internal server error.. Thanks for catching that Marcel. Must be fixed with the last patch. The other calls look safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:04:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:04:24 +0000 Subject: [Koha-bugs] [Bug 18862] Allow relations in Koha::Object's AUTOLOAD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18862 --- Comment #5 from Jonathan Druart --- What you pasted in comment 2 is the current way to go. I am not in favour of adding more magic for now. We clearly see/show what we are using and the methods are covered by tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:08:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:08:01 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 --- Comment #1 from Lee Jamison --- Created attachment 64818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64818&action=edit Bug 18897 - Koha_Elasticsearch_Indexer.t doesn't skip when ES module not installed If Catmandu::Importer::MARC is not installed, Koha_Elasticsearch_Indexer.t fails instead of skipping. Test Plan: 1. Run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t" as koha-shell. 2. Note failure on test 1/5 indicating module not installed. 3. Apply patch. 4. Re-run "prove t/db_dependent/Koha_Elasticsearch_Indexer.t" 5. Note test now skips. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:07:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:07:58 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:28:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:28:51 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #13 from Jonathan Druart --- Yes indeed you are right, this is not ideal and might be confusing. We should add more JS code to handle that correctly, but I am not willing to write it. However I am still thinking that this feature is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:33:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:33:45 +0000 Subject: [Koha-bugs] [Bug 18898] New: Some permissions for Reports can be bypassed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18898 Bug ID: 18898 Summary: Some permissions for Reports can be bypassed Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: bovinitydivinity at comcast.net QA Contact: testopia at bugs.koha-community.org In 16.11.05.000 If a user has permissions to run - but not create or edit reports - they can still create or edit reports by editing the the URL while running a report and changing the Phase parameter to "Edit SQL" or "Create report from SQL". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:42:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:42:37 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #10 from Jonathan Druart --- Created attachment 64820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64820&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem Test plan: Enable EasyAnalyticalRecords and link an item to another one (Edit > link to host item) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:42:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:42:33 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63301|0 |1 is obsolete| | Attachment #63302|0 |1 is obsolete| | Attachment #63303|0 |1 is obsolete| | Attachment #63304|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 64819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64819&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones To retrieve a biblionumber from an itemnumber, we can use: Koha::Item->biblio->biblionumber This is only what this patchset does. Doing that we will be able to get rid of the C4::Biblio::GetBiblionumberFromItemnumber subroutine. Test plan: - Acquisition module: cancel a receipt - Export a record to CSV - Modify items in a batch Item's info should be correct Other changes with be checked by QA team, by reading the code. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:42:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:42:45 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #12 from Jonathan Druart --- Created attachment 64822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64822&action=edit Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:42:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:42:41 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #11 from Jonathan Druart --- Created attachment 64821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64821&action=edit Bug 18277: Remove GetBiblionumberFromItemnumber - create_analytical_rel.pl I have no idea how to test this patch, see bug 5528, or simply read the code. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 20:43:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 18:43:09 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 --- Comment #13 from Jonathan Druart --- Patches have been rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:05:23 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #17 from Tom?s Cohen Arazi --- (In reply to alfre69 from comment #16) > (In reply to Barton Chittenden from comment #13) > > (In reply to alfre69 from comment #9) > > > If you increase $max_record_size too much it breaks the Z39.50 server. > > > > > > A yaz-client search report this: > > > > > > Target has closed the association. > > > Reason: protocolError, message: Incoming package too large > > > > Does this error occur on *all* searches, or simply searches whose results > > are greater than 1 MB? > > It occurs on all searches, so the Z39.50 server is not usable when > increasing $max_record_size. IndexData told me a while back that yaz-client has several limitations the protocol doesn't have, and we should be using zoomsh instead for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:05:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:05:46 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63760|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 64823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64823&action=edit Bug 18260: Koha::Biblio - Remove GetBiblio C4::Biblio::GetBiblio can be replaced with Koha Biblio->find Test plan: Import batch, view issue history, search for items, see the image of a bibliographic record, modify and delete records in a batch Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:13:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:13:35 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #51 from Philippe Audet-Fortin --- Created attachment 64824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64824&action=edit Bug 12532 - Bug 12532 - QA Follow-up Fixed tests, they now work without any fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:14:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:14:16 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64824|Bug 12532 - Bug 12532 - QA |Bug 12532 - QA Follow-up description|Follow-up | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:14:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:14:37 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Philippe Audet-Fortin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:19:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:19:14 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #52 from Philippe Audet-Fortin --- Because of the sha1 error, I took the content of the original commit "Bug 12532 - QA Follow-up", put it in an other commit and mark the old one has obsolete. Now the patch apply correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:20:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:20:15 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:27:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:27:19 +0000 Subject: [Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 [Bug 18260] Koha::Biblio - Remove GetBiblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:27:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:27:24 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 --- Comment #8 from Jonathan Druart --- Created attachment 64825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64825&action=edit Bug 18260: Handle nonexistent biblionumber in imageviewer.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:27:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:27:19 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18277 --- Comment #7 from Jonathan Druart --- Patch rebased on top of bug 18277. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277 [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:29:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:29:59 +0000 Subject: [Koha-bugs] [Bug 18260] Koha::Biblio - Remove GetBiblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #5) > Koha/REST/V1/Hold.pm > Result of Koha::Biblios->find( $biblionumber ) is not tested, but result of > GetBiblio was not tested too before. > No blocker. > > catalogue/imageviewer.pl > biblionumber is a CGI parameter here > find should be tested That was already true before this patch, we must handle nonexistent biblionumber correctly on all catalogue scripts. > Same for catalogue/issuehistory.pl > opac/opac-imageviewer.pl I did not find a change in the behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:32:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:32:35 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from Tom?s Cohen Arazi --- wihtout the patches: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/Returns.t .. ok All tests successful. Files=1, Tests=4, 2 wallclock secs ( 0.02 usr 0.01 sys + 2.09 cusr 0.35 csys = 2.47 CPU) Result: PASS with the patches: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/Returns.t .. 1/4 # Failed test 'No account lines should exist on old issue_id' # at t/db_dependent/Circulation/Returns.t line 311. # got: '1' # expected: '0' # Failed test 'Two account lines should exist on new issue_id' # at t/db_dependent/Circulation/Returns.t line 314. # got: '1' # expected: '2' # Looks like you failed 2 tests of 4. t/db_dependent/Circulation/Returns.t .. 4/4 # Failed test 'Handle ids duplication' # at t/db_dependent/Circulation/Returns.t line 318. # Looks like you failed 1 test of 4. t/db_dependent/Circulation/Returns.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests Test Summary Report ------------------- t/db_dependent/Circulation/Returns.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=4, 3 wallclock secs ( 0.02 usr 0.01 sys + 2.14 cusr 0.33 csys = 2.50 CPU) Result: FAIL kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:43:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:43:36 +0000 Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:44:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:44:43 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:44:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:44:47 +0000 Subject: [Koha-bugs] [Bug 18259] Koha::Biblio - Remove GetSubscriptionsId In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18259 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63889|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 64826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64826&action=edit Bug 18259: Koha::Biblio - Remove GetSubscriptionsId C4::Biblio::GetSubscriptionsId can be replaced using Koha::Biblio->subscriptions Test plan: Create a new order for a bibliographic record Create a new subscription on this biblio >From the basket (acquisition), confirm that you are not able to delete the order with the biblio ("Can't cancel order and delete catalog record 1 subscription(s) left") Receive the order On the parcel page, confirm that you are not able to delete the order with the biblio Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:53:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:53:14 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 --- Comment #11 from Jonathan Druart --- Created attachment 64827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64827&action=edit Bug 18262: Fix test in MultiplePerRecord The biblioitem entry must be added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:54:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:54:01 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #56 from Philippe Audet-Fortin --- Created attachment 64828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64828&action=edit Bug 12446 - Added a missing comma in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:54:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:54:21 +0000 Subject: [Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262 --- Comment #12 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #10) > Overall, it looks great. I would love to see (at some point) the > Koha::Biblio objects passed to the template instead of explicitly extracting > each attribute, but that's a whole other problem. What I did on bug 18789 for Koha::Patron, I'd love to do it for Koha::Biblio too. > I've found a test to fail with this patch applied, and pass without it: Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:57:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:57:32 +0000 Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 21:57:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 19:57:38 +0000 Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64286|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 64829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64829&action=edit Bug 18802: Fix Circulation.t if finesMode ne 'production' If finesMode is not set to production, only 1 fine will be created (the renewal one will not). This is what assumes the tests. If set to 'production', the tests will fail because the fines will not be deleted (because of the DBIx::Class) warning. prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491 t/db_dependent/Circulation.t .. 56/95 # Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10' # at t/db_dependent/Circulation.t line 670. # got: 'auto_too_much_oweing' # expected: 'auto_renew' # Looks like you failed 1 test of 6. Test plan: prove t/db_dependent/Circulation.t should return green whatever the value of finesMode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:10:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:10:02 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |m.de.rooy at rijksmuseum.nl, | |olli-antti.kivilahti at jns.fi | |, tomascohen at gmail.com --- Comment #2 from Jonathan Druart --- My bad, I completely forgot that this module was not packaged. So we have a problem here, the way we mocked our DB was not reliable and we fixed it using Test::DBIx::Class. Olli, Tomas, Marcel, any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:20:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:20:42 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Ok, I am on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:20:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:20:51 +0000 Subject: [Koha-bugs] [Bug 14826] Resurrect account offsets table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:49:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:49:54 +0000 Subject: [Koha-bugs] [Bug 18899] New: Tests should skip instead of failing when dependency modules are not installed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 Bug ID: 18899 Summary: Tests should skip instead of failing when dependency modules are not installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: ldjamison at marywood.edu QA Contact: testopia at bugs.koha-community.org t/db_dependent/00-strict.t (tests 342, 521, 533) and t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t (test 1) fail instead of skipping when a Perl module required for them to run properly is not installed. test 342 requires Catmandu::Importer::MARC tests 521 and 533 require WebService::ILS::OverDrive::Patron test 1 requires Catmandu::Store::ElasticSearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:50:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:50:39 +0000 Subject: [Koha-bugs] [Bug 18899] Tests should skip instead of failing when dependency modules are not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18897 Assignee|chris at bigballofwax.co.nz |ldjamison at marywood.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:50:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:50:39 +0000 Subject: [Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18899 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:51:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:51:02 +0000 Subject: [Koha-bugs] [Bug 18899] Tests should skip instead of failing when dependency modules are not installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18899 Lee Jamison changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:57:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:57:16 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:57:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:57:20 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #4 from Jonathan Druart --- Created attachment 64830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64830&action=edit Bug 18851: Database handler must not be created at runtime -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:57:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:57:24 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #5 from Jonathan Druart --- Created attachment 64831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64831&action=edit Bug 18851: Test::DBIx::Class is not needed in 00-load.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:57:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:57:28 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #6 from Jonathan Druart --- Created attachment 64832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64832&action=edit Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:57:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:57:50 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #7 from Jonathan Druart --- Mirko, could you confirm these patches fix the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 22:59:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 20:59:20 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 --- Comment #8 from Jonathan Druart --- non-dependent tests must be tested with and without Test::DBIx::Class and with and without the DBMS running -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 23:43:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 21:43:32 +0000 Subject: [Koha-bugs] [Bug 17101] Confirm a question before check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101 --- Comment #16 from Lisette --- That seems like the correct order to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 23:47:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 21:47:02 +0000 Subject: [Koha-bugs] [Bug 9599] printable work slip on receive in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9599 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 23:47:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 21:47:44 +0000 Subject: [Koha-bugs] [Bug 18894] Add ability to limit the number of messages sent by misc/ cronjobs/process_message_queue.pl at a time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18894 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 23:50:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 21:50:41 +0000 Subject: [Koha-bugs] [Bug 18847] Add "Save and continue" option to notice editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 23:51:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 21:51:17 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Lisette changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 00:09:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 22:09:38 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #42 from Jonathan Druart --- Created attachment 64833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64833&action=edit Bug 17680: Fix conflict with bug 18651 $issue is now a Koha::Checkout, not a hashref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 00:10:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 22:10:33 +0000 Subject: [Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #43 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #41) Thanks for catching that, fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:07:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:07:06 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:07:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:07:28 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64694|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 64834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64834&action=edit Bug 18870: Force scalar context for Koha::Club methods These 2 methods are called from the template in list context. However since bug 18539 Koha::Objects->find can no longer be called in list context. Forcing the context to scalar fixes the problem and should not introduced side-effects. Test plan: - Create a club template - Create a club using this template => Without this patch you should no longer get the following error: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club.pm line 51. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:08:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:08:27 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18179, 12461 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18179 | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 [Bug 18179] Koha::Objects->find should not be called in list context -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:08:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:08:27 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18870 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 [Bug 18870] Patron Clubs breaks when creating a club -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:08:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:08:27 +0000 Subject: [Koha-bugs] [Bug 18179] Koha::Objects->find should not be called in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18179 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18870 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18870 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 [Bug 18870] Patron Clubs breaks when creating a club -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:17:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:17:09 +0000 Subject: [Koha-bugs] [Bug 18807] www/batch.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > Tests fail for me with and without this patch: master or 16.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:23:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:23:30 +0000 Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |nicolas.legrand at bulac.fr, | |severine.queune at bulac.fr, | |sonia.bouis at univ-lyon3.fr --- Comment #8 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #7) > So the table is more compact and easy to follow. Well not really, it is less compact than before. I'd like more opinions on this one, Nicolas, S?verine or Sonia maybe (See comments 5 & 6). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 01:27:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jul 2017 23:27:47 +0000 Subject: [Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #22 from Jonathan Druart --- You are modifying a js file that is used from different templates. You will introduced side-effects with these changes (when receiving an item if AcqCreateItem = "on receiving"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 03:30:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 01:30:04 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64683|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia --- Created attachment 64835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64835&action=edit Bug 17698: [FOLLOW-UP] Koha Objects, access borrower through patron sub See Comment 27 This is ready to be tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 03:32:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 01:32:53 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 03:32:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 01:32:57 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64834|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 64836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64836&action=edit [SIGNED-OFF] Bug 18870: Force scalar context for Koha::Club methods These 2 methods are called from the template in list context. However since bug 18539 Koha::Objects->find can no longer be called in list context. Forcing the context to scalar fixes the problem and should not introduced side-effects. Test plan: - Create a club template - Create a club using this template => Without this patch you should no longer get the following error: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club.pm line 51. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 07:33:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 05:33:29 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 07:34:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 05:34:24 +0000 Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:05:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:05:40 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- > With this patch a parameter 'allow_empty_passwords="1" can be added... Can we document these kinds of parameters somewhere? Maybe in the example file? I am worried that these kind of features will remain mostly unknown if there are not more clues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:08:39 +0000 Subject: [Koha-bugs] [Bug 18807] www/batch.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 --- Comment #18 from Katrin Fischer --- Was testing with 16.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:29:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:29:06 +0000 Subject: [Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735 DEVINIM changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:31:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:31:15 +0000 Subject: [Koha-bugs] [Bug 18862] Allow relations in Koha::Object's AUTOLOAD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18862 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:31:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:31:24 +0000 Subject: [Koha-bugs] [Bug 18862] Allow relations in Koha::Object's AUTOLOAD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18862 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:42:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:42:33 +0000 Subject: [Koha-bugs] [Bug 18900] New: Receiving order with unitprice multiples by 1000 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Bug ID: 18900 Summary: Receiving order with unitprice multiples by 1000 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define , as decimal and so multiple price value by 1000. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:42:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:42:47 +0000 Subject: [Koha-bugs] [Bug 18900] Receiving order with unitprice multiples by 1000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18471 --- Comment #1 from Fridolin SOMERS --- 18471 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 08:42:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 06:42:47 +0000 Subject: [Koha-bugs] [Bug 18471] Receiving order with unitprice greater than 1000 processing incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 [Bug 18900] Receiving order with unitprice multiples by 1000 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 09:30:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 07:30:40 +0000 Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 --- Comment #4 from Oliver Bock --- Right below the hunks I patched: https://github.com/Koha-Community/Koha/commit/cfc484b173120dfe14616424c1ec279bb74cf2a9#diff-75b9144a15674b1f9c5c6acbf32e8ed9R1814 HTH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 09:47:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 07:47:50 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 --- Comment #6 from Julian Maurice --- Created attachment 64837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64837&action=edit Bug 18870: Force scalar context for Koha::Club methods These 2 methods are called from the template in list context. However since bug 18539 Koha::Objects->find can no longer be called in list context. Forcing the context to scalar fixes the problem and should not introduced side-effects. Test plan: - Create a club template - Create a club using this template => Without this patch you should no longer get the following error: Template process failed: undef error - Cannot use "->find" in list context at /home/vagrant/kohaclone/Koha/Club.pm line 51. Signed-off-by: Aleisha Amohia Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 09:48:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 07:48:00 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:02:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:02:51 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 --- Comment #9 from Colin Campbell --- (In reply to Katrin Fischer from comment #8) > > With this patch a parameter 'allow_empty_passwords="1" can be added... > > Can we document these kinds of parameters somewhere? Maybe in the example > file? I am worried that these kind of features will remain mostly unknown if > there are not more clues. I wonder if we need to rethink the way SIP configuration is held. I'm not sure that adding options to an xml file is very accessible to many users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:13:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:13:04 +0000 Subject: [Koha-bugs] [Bug 18870] Patron Clubs breaks when creating a club In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18870 Ruth Smalley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rsmalley at livewirewarrington | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:45:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:45:07 +0000 Subject: [Koha-bugs] [Bug 18900] Receiving order with unitprice multiples by 1000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:45:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:45:19 +0000 Subject: [Koha-bugs] [Bug 18900] Receiving order with unitprice multiples by 1000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:46:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:46:22 +0000 Subject: [Koha-bugs] [Bug 18900] Receiving order with unitprice multiples by 1000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #2 from Fridolin SOMERS --- I have a UT that reproduces the bug. For testing in acquisition, one must use Plack mode, I don't understand why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:47:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:47:10 +0000 Subject: [Koha-bugs] [Bug 18900] Receiving order with unitprice multiples by 1000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #3 from Fridolin SOMERS --- Created attachment 64838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64838&action=edit Bug 18900 - add UT to Number/Price.t This patch adds unit tests to t/Number/Price.t in order to valid the problem. It sets in the script locale "en_US.UTF-8" by default so that those tests can be run with any system locale. And adds a test dedicated to this bug. (cherry picked from commit 20b3141bdf750bebb50e837771724324f7a67c1b) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:49:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:49:40 +0000 Subject: [Koha-bugs] [Bug 18900] Receiving order with unitprice multiples by 1000 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64838|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Created attachment 64839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64839&action=edit Bug 18900 - add UT to Number/Price.t This patch adds unit tests to t/Number/Price.t in order to valid the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 10:50:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 08:50:45 +0000 Subject: [Koha-bugs] [Bug 18900] wrong number format in receiving order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Receiving order with |wrong number format in |unitprice multiples by 1000 |receiving order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:01:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:01:02 +0000 Subject: [Koha-bugs] [Bug 18900] wrong number format in receiving order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 --- Comment #5 from Fridolin SOMERS --- Created attachment 64840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64840&action=edit Bug 18900 - wrong number format in receiving order Bug 18471 added number formating in order receive. I found a bug generated by this. Koha::Number::Price defines methods to (un)format price depending on CurrencyFormat syspref. The bug is that for CurrencyFormat US, some params are not defined in this module so there are retrieved from system locale. If system locale is not en_US, the params will be wrong. For example fr_FR will define ',' as decimal and so saved unit price is divided by 1000. To recreate: - On a server with locale 'fr_FR' - With Plack mode - Set CurrencyFormat on 'US' - Open a basket - Place an order for an item - Close basket - Receive order with changing 'Actual Cost' to '1,234' - Note the 'Actual Cost' is now '1.23' - Run unit test t/Number/Price.t without and with patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:03:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:03:03 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 --- Comment #10 from Katrin Fischer --- I agree, but that's probably a bigger issue. I am not sure how granular it is, but I think possibly it should be as granular as per 'sip2 using unit'? Having a commented example file might be quicker to achieve for now and helpful for moving things later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:04:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:04:29 +0000 Subject: [Koha-bugs] [Bug 18900] wrong number format in receiving order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:04:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:04:48 +0000 Subject: [Koha-bugs] [Bug 18900] wrong number format in receiving order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:20:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:20:12 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 --- Comment #5 from Fridolin SOMERS --- (In reply to Alex Buckley from comment #3) > Perhaps this could be a future patch :) Indeed, another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:42:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:42:27 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #3 from Nick Clemens --- Created attachment 64841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64841&action=edit Bug 18213 - DB Update (facet order) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:48:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:48:24 +0000 Subject: [Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Looking at a communication from a user in large public library in the UK, their local authority is standardizing the gender element on online forms as: What is your gender identity? Please select one option only o Male (including Trans man) o Female (including Trans female) o Other gender identity ? please specify: o Prefer not to say That would suggest increasing the options to four and having a separate field for the other field -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:56:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:56:38 +0000 Subject: [Koha-bugs] [Bug 17371] REST API: add CRUD for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 --- Comment #15 from Jiri Kozlovsky --- Created attachment 64842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64842&action=edit Bug 17371 - REST API: add CRUD for biblios QA followup Note: Rebased on master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:58:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:58:01 +0000 Subject: [Koha-bugs] [Bug 17371] REST API: add CRUD for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64842|Bug 17371 - REST API: add |Bug 17371 - REST API: add description|CRUD for biblios |CRUD for biblios (QA | |followup) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 11:58:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 09:58:21 +0000 Subject: [Koha-bugs] [Bug 17371] REST API: add CRUD for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jiri Kozlovsky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 12:02:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 10:02:02 +0000 Subject: [Koha-bugs] [Bug 18577] Importing a batch using a framework not fully set up causes and endless loop In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18577 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- QA: I think you should add a foreign key constraint on marc_subfield_structure.frameworkcode, so that the DBIx schema can be generated by update_dbix_class_files.pl. Is there any reason why you didn't do that ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 12:20:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 10:20:47 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault at biblibre.com --- Comment #16 from Laurence Rault --- tested on sandbox I can't checkout a book DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.has_priority' in 'field list' at /home/koha/src/Koha/Objects.pm line 191 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 13:37:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 11:37:01 +0000 Subject: [Koha-bugs] [Bug 16302] Koha::Logger performance tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16302 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at jns.fi --- Comment #5 from Lari Taskula --- Most test runs are passing for me, however, every now and then it fails at the second test: # Subtest: Log4perl vanilla, 10000 errors ok 1 - Test duration 0.710620880126953 < 0.945125770568848 ok 2 - Log writing confirmed 1..2 ok 1 - Log4perl vanilla, 10000 errors # Subtest: Log4perl Koha::Logger from KOHA_CONF, 10000 errors not ok 1 - Test duration 1.00295996665955 < 0.945125770568848 # Failed test 'Test duration 1.00295996665955 < 0.945125770568848' # at t/Koha/Logger_performance.t line 68. ok 2 - Log writing confirmed 1..2 # Looks like you failed 1 test of 2. not ok 2 - Log4perl Koha::Logger from KOHA_CONF, 10000 errors # Failed test 'Log4perl Koha::Logger from KOHA_CONF, 10000 errors' # at t/Koha/Logger_performance.t line 60. # Subtest: Log4perl Koha::Logger from ENV, 10000 errors ok 1 - Test duration 0.792418956756592 < 0.945125770568848 ok 2 - Log writing confirmed 1..2 ok 3 - Log4perl Koha::Logger from ENV, 10000 errors 1..3 # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 13:45:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 11:45:36 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref / colliding translated preference sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64414|0 |1 is obsolete| | --- Comment #32 from Julian Maurice --- Created attachment 64843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64843&action=edit Bug 18634: Handle colliding translation for preference sections Problem on this report was caused by translating the tabs Privacy and Payments by the same string. This caused overwriting a hash entry. This patch tests if the key already exists and if so, it merges the entries instead of overwriting the old contents. Test plan: [1] Make sure that e.g. Privacy and Payments translate to e.g Vie privee. [2] Run translate install fr-CA (or the language you altered) [3] Without this patch you should loose preferences from either Privacy or Payments. With this patch, they should be merged. Signed-off-by: Marcel de Rooy Tested with fr-CA. Signed-off-by: Blou Reset the .po files, reproduced the problem. Applied the patch and suddenly 'paypal' appeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 13:46:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 11:46:15 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref / colliding translated preference sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64843|0 |1 is obsolete| | --- Comment #33 from Julian Maurice --- Created attachment 64844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64844&action=edit Bug 18634: Handle colliding translation for preference sections Problem on this report was caused by translating the tabs Privacy and Payments by the same string. This caused overwriting a hash entry. This patch tests if the key already exists and if so, it merges the entries instead of overwriting the old contents. Test plan: [1] Make sure that e.g. Privacy and Payments translate to e.g Vie privee. [2] Run translate install fr-CA (or the language you altered) [3] Without this patch you should loose preferences from either Privacy or Payments. With this patch, they should be merged. Signed-off-by: Marcel de Rooy Tested with fr-CA. Signed-off-by: Blou Reset the .po files, reproduced the problem. Applied the patch and suddenly 'paypal' appeared. Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 13:48:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 11:48:35 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref / colliding translated preference sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com --- Comment #34 from Julian Maurice --- There is a problem in how we handle translation here. IMO keys of a hash shouldn't be translatable. But the patch definitely fixes a problem, so passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 13:50:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 11:50:37 +0000 Subject: [Koha-bugs] [Bug 16304] Koha::Logger, lazy load loggers so environment has time to get set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50449|0 |1 is obsolete| | --- Comment #3 from Lari Taskula --- Created attachment 64845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64845&action=edit Bug 16304 - Koha::Logger, lazy load loggers so environment has time to get set If you instantiate Koha::Loggers before having set the C4::Context->interface, their interface defaults to 'opac'. This is rather undesired especially for 'commandline' scripts such as cronjobs. A solution to this is to lazyLoad loggers when they are really needed. LazyLoading might also have a performance boost when using packages that initialize a package-level logger but which never gets used. see t/Koha/Logger.t on how to replicate this issue, but here is a nutshell of how to replicate this issue: @@ file A.pm package A; use Koha::Logger; my $logger = Koha::Logger->get({category => __PACKAGE__}); #interface unknown sub doStuff { $logger->error('My interface is always "opac"'); } @@ script run.pl use C4::Context; C4::Context->interface('commandline'); use A; A::doStuff(); #error is logged using the "opac"-interface instead #of the "commandline"-interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 13:51:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 11:51:09 +0000 Subject: [Koha-bugs] [Bug 16304] Koha::Logger, lazy load loggers so environment has time to get set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at jns.fi --- Comment #4 from Lari Taskula --- Fixed a conflict when applying patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 13:58:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 11:58:18 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Large patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 14:52:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 12:52:28 +0000 Subject: [Koha-bugs] [Bug 18901] New: Sysprefs translation: translate only *.pref files ( not *.pref*) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Bug ID: 18901 Summary: Sysprefs translation: translate only *.pref files (not *.pref*) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Text editors can create temporary files in this folder and this can confuse the translator. For instance, vim can create a file named '.opac.pref.swp' which will make the translator dies with the following error message: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at LangInstaller.pm line 248. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 14:54:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 12:54:16 +0000 Subject: [Koha-bugs] [Bug 18901] Sysprefs translation: translate only *.pref files (not *.pref* ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 --- Comment #1 from Julian Maurice --- Created attachment 64846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64846&action=edit Bug 18901: Sysprefs translation: translate only *.pref files (not *.pref*) Text editors can create temporary files in this folder and this can confuse the translator. For instance, vim can create a file named '.opac.pref.swp' which will make the translator dies with the following error message: Can't use string ("b0VIM 8.0") as a HASH ref while "strict refs" in use at LangInstaller.pm line 248. Test plan: 1. echo 'Oops' > .../en/modules/admin/preferences/whatever.pref.whatever 2. cd misc/translator && ./translate update fr-FR 3. Verify that you have the error message mentioned above 4. Apply patch 5. cd misc/translator && ./translate update fr-FR 6. No more errors! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 14:54:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 12:54:29 +0000 Subject: [Koha-bugs] [Bug 18901] Sysprefs translation: translate only *.pref files (not *.pref* ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 15:08:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 13:08:53 +0000 Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 --- Comment #9 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > (In reply to Tom?s Cohen Arazi from comment #7) > > So the table is more compact and easy to follow. > > Well not really, it is less compact than before. I meant it was more compact than the funds one. Of course it is adding columns to the original one! hehe > I'd like more opinions on this one, Nicolas, S?verine or Sonia maybe (See > comments 5 & 6). Yeah, I think it is important to listen to interested parties. My feeling is that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if it was just duplicating the funds one, I think it is worth doing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 15:29:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 13:29:10 +0000 Subject: [Koha-bugs] [Bug 18801] Merging authorities has an invalid 'Default' type in the merge framework selector In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18801 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 15:31:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 13:31:35 +0000 Subject: [Koha-bugs] [Bug 16690] Installing DB on remote server fails without *.* permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52174|0 |1 is obsolete| | --- Comment #6 from M. Tompsett --- Created attachment 64847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64847&action=edit Bug 16690: SHOW GRANTS fails to detect proper permissions If the DB is on a remote machine, the web server and the db server are different, but the SHOW GRANTS code in installer/install.pl is trying to use the SAME machine. And even if the permissions were allowed accessing from both the web and db servers, MySQL won't return the SHOW GRANTS without access to the mysql.user table. To install *.* permissions became easiest to get working. This makes it so that you can specify the web and db server separately, so the SHOW GRANT will match the machine the user is connected from and return properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 15:31:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 13:31:38 +0000 Subject: [Koha-bugs] [Bug 16690] Installing DB on remote server fails without *.* permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53162|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 64848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64848&action=edit Bug 16690: Follow up etc/koha-conf.xml As per Fr?d?ric Demians feedback in comment #2, made same changes to etc/koha-conf.xml as was made to debian/templates/koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 15:51:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 13:51:20 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 6 15:51:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Jul 2017 13:51:23 +0000 Subject: [Koha-bugs] [Bug 18667] Show a diff view of SQL reports when converting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18667 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63712|0 |1 is obsolete| | --- Comment #5 from Jesse Maseto --- Created attachment 64849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64849&action=edit Bug 18667 [Revised] Show a diff view of SQL reports when converting This patch reformats the SQL conversion before-and-after view so that it shows a diff between the two, just as the Manage MARC Import interface does. This patch also makes a correction to the JavaScript which is triggered by the closing of the modal. In Bootstrap 3 "hidden.bs.modal" is the event name instead of "hidden." To test, apply the patch and find an SQL report in your reports library which requires updating. - Click the "Update SQL" button. - In the modal window, the "existing" and "updated" SQL should be shown side-by-side with colored highlighting of the differece. - Confirm that the "Update" button still works correctly. - Also confirm that if you open the preview of another report, the "Close" button hides the modal and updates the contents of the modal markup. Use your browser's DOM inspector to confirm that
  • [% ELSE %]
  • [% END %]Statistics
  • [% END %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 12:50:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 10:50:23 +0000 Subject: [Koha-bugs] [Bug 19006] New: Nicer formatting of statistics tab in patron account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19006 Bug ID: 19006 Summary: Nicer formatting of statistics tab in patron account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The statistics tab in the patron account in staff shows the codes for collections, locations and itemtypes instead of their description. Libraries are not sure what is shown there and the tab causes a lot of questions. It would be nice if the information shown here was somewhat clearer, maybe including a little explanation on top. The help file is also quite sparse. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 12:54:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 10:54:45 +0000 Subject: [Koha-bugs] [Bug 5471] Quotes in tags cause moderation approval/rejection to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 12:54:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 10:54:48 +0000 Subject: [Koha-bugs] [Bug 5471] Quotes in tags cause moderation approval/rejection to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64208|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 65334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65334&action=edit Bug 5471 - Quotes in tags fail This patch makes changes to the tag moderation template and JavaScript to fix handling of tags with double or single quotes. This patch also moves the tags moderation JavaScript out of the template and into a separate JS file. To test you should have multiple tags awaiting moderation, including tags which contain double and single quotes. - Go to Tools -> Tags. - In the list of tags pending approval, test approving and rejecting tags, including those containing single or double quotes. - The state of the "Approve" or "Reject" buttons should correctly change according to the action you chose. - The label in the status column should update correctly. - In the "Check lists" form, submitting approved, rejected, and unclassified terms should result in the correct message. Signed-off-by: Lee Jamison Works correctly based on test plan. Tested using single- and double-quoted tags. Passes QA Tools. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 12:57:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 10:57:43 +0000 Subject: [Koha-bugs] [Bug 5471] Quotes in tags cause moderation approval/rejection to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- All buttons work as expected and quotes no longer cause errors. In terms of usability I think there may be a little more to do here on a new bug: 1 - Approve a term - it remains on the screen - click 'Reject' at the bottom and the tag is approved and cleared 2 - Repeat qabove but also check the checkbox - tag is reject (though it said approved) Would be nice to possibly have an 'Apply' button and then only show 'reject/approve' if some boxes are checked? Adding an 'undo' might be nice as well in case you click on a tag you aren't ready to approve or reject yet Not failing but leaving those comments for consideration -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:00:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:00:45 +0000 Subject: [Koha-bugs] [Bug 18931] Add a "data corrupted" section on the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18931 --- Comment #29 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:01:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:01:29 +0000 Subject: [Koha-bugs] [Bug 18966] Move of checkouts - Deal with duplicate IDs at DBMS level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966 --- Comment #31 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:02:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:02:21 +0000 Subject: [Koha-bugs] [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910 --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:02:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:02:44 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:03:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:03:07 +0000 Subject: [Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #16 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:03:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:03:35 +0000 Subject: [Koha-bugs] [Bug 15465] README for github In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15465 --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:03:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:03:53 +0000 Subject: [Koha-bugs] [Bug 18663] Missing db update for ExportRemoveFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18663 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:04:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:04:12 +0000 Subject: [Koha-bugs] [Bug 16295] marc_modification_templates permission doesn' t allow access to modify template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16295 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:04:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:04:43 +0000 Subject: [Koha-bugs] [Bug 18204] Authority searches are not saved in Search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18204 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:05:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:05:07 +0000 Subject: [Koha-bugs] [Bug 18600] Missing db update for TalkingTechItivaPhoneNotification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18600 --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:05:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:05:27 +0000 Subject: [Koha-bugs] [Bug 18611] Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #12 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:05:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:05:45 +0000 Subject: [Koha-bugs] [Bug 18669] RewriteCond affecting wrong rule in koha-httpd.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18669 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:06:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:06:05 +0000 Subject: [Koha-bugs] [Bug 5395] C4::Acquisition::SearchOrder POD inconsistent with function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5395 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:07:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:07:11 +0000 Subject: [Koha-bugs] [Bug 18512] GetAuthorisedValues.GetByCode Template plugin should return code ( not empty string) if value not found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:07:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:07:28 +0000 Subject: [Koha-bugs] [Bug 18482] False duplicates detected on adding a batch from a stage file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:08:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:08:39 +0000 Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #6 from Nick Clemens --- In one case you run 3 tests, in another you run 2 - this causes count errors depending on the values set. Wouldn't it be better to mock the pref and test both secnarios? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:13:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:13:11 +0000 Subject: [Koha-bugs] [Bug 18478] Some notices sent via SMS gateway fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18478 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #29 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:15:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:15:37 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:15:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:15:23 +0000 Subject: [Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:16:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:16:01 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:16:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:16:27 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:16:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:16:54 +0000 Subject: [Koha-bugs] [Bug 18974] Adding further selenium tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:17:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:17:15 +0000 Subject: [Koha-bugs] [Bug 13747] Fix problems with frequency descriptions containing quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13747 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:17:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:17:48 +0000 Subject: [Koha-bugs] [Bug 18648] Translatability: Get rid of tt directives in translation for macles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #20 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:17:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:17:57 +0000 Subject: [Koha-bugs] [Bug 18695] Translatability: Get rid of [ %% INCLUDE in translation for circulation.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18695 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:18:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:18:31 +0000 Subject: [Koha-bugs] [Bug 18759] Circulation.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:18:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:18:40 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:19:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:19:17 +0000 Subject: [Koha-bugs] [Bug 18682] Translatability: Get rid of [ %% in translation for 2 files av-build-dropbox.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18682 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:19:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:19:26 +0000 Subject: [Koha-bugs] [Bug 18644] Translatability: Get rid of pure template directives in translation for memberentrygen.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18644 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:20:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:20:03 +0000 Subject: [Koha-bugs] [Bug 18690] Typos in Koha database description (Table "borrowers") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:20:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:20:11 +0000 Subject: [Koha-bugs] [Bug 18675] Translatability: Get rid of [ %% in translation for csv-profiles.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:20:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:20:18 +0000 Subject: [Koha-bugs] [Bug 18746] Text_CSV_Various.t parse failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18746 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:21:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:21:03 +0000 Subject: [Koha-bugs] [Bug 18722] Subtotal information not showing fund source In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18722 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:21:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:21:11 +0000 Subject: [Koha-bugs] [Bug 18689] Fix calendar error with double quotes in title or description of holiday In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18689 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #15 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:21:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:21:19 +0000 Subject: [Koha-bugs] [Bug 18727] System preferences loose part of values because of double quotes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18727 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:22:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:22:04 +0000 Subject: [Koha-bugs] [Bug 18706] subfields to delete not disabled anymore in batch item modification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18706 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:21:57 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:21:57 +0000 Subject: [Koha-bugs] [Bug 18767] Useless debugging info in GetDailyQuote.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18767 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:22:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:22:16 +0000 Subject: [Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #19 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:23:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:23:47 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:24:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:24:00 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 --- Comment #6 from Nick Clemens --- Created attachment 65335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65335&action=edit Bug 15352 Follow - Use default text if pref not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:24:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:24:00 +0000 Subject: [Koha-bugs] [Bug 18752] Automatic item modifications by age should allow 'blank' values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:24:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:24:21 +0000 Subject: [Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:24:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:24:44 +0000 Subject: [Koha-bugs] [Bug 18761] AutomaticItemModificationByAge.t tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18761 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:26:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:26:09 +0000 Subject: [Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:26:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:26:19 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #28 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:26:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:26:39 +0000 Subject: [Koha-bugs] [Bug 11235] Names for reports and dictionary are cut off when quotes are used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11235 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:27:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:27:04 +0000 Subject: [Koha-bugs] [Bug 18804] Selenium tests are failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18804 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #25 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:30:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:30:17 +0000 Subject: [Koha-bugs] [Bug 18699] Get rid of %%] in translation for edi_accounts.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18699 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:30:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:30:55 +0000 Subject: [Koha-bugs] [Bug 18806] Cannot revert a batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:31:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:31:17 +0000 Subject: [Koha-bugs] [Bug 18807] www/batch.t is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18807 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #21 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:31:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:31:38 +0000 Subject: [Koha-bugs] [Bug 17181] Patron card creator replaces existing image when uploading image with same name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #13 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:32:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:32:05 +0000 Subject: [Koha-bugs] [Bug 18607] Fix date calculations for monthly frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:31:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:31:54 +0000 Subject: [Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:33:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:33:08 +0000 Subject: [Koha-bugs] [Bug 15352] a way not to show the full url in the holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Added a followup to add default text, however, it seems we need to test for item.uri now as otherwise in the case of 1 items with a link/uri all other items get a blank targeted link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:33:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:33:30 +0000 Subject: [Koha-bugs] [Bug 18800] Patron card images: Add some more explanation to upload page and fix small translatability issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18800 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:33:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:33:20 +0000 Subject: [Koha-bugs] [Bug 18697] Fix date calculations for day/week frequencies in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #24 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:33:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:33:39 +0000 Subject: [Koha-bugs] [Bug 18214] Cannot edit list permissions of a private list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:33:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:33:47 +0000 Subject: [Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:33:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:33:58 +0000 Subject: [Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref / colliding translated preference sections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #38 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:53:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:53:06 +0000 Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65330|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 65336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65336&action=edit Bug 18996: Handle data corruption from old_issues at SIP checkin As per bug 18966 AddReturn returns false with a DataCorrupted message when the issue_id at hand already occurs in the old_issues table. This should be handled when returning an item via SIP too. SIP should not pretend that the checkin was successful, since this item needs special care. The following six different situations are handled: [1] An attempt to checkin an invalid barcode is handled as before. The ok flag is false; the screen message shows 'Invalid Item'. [2] We receive a DataCorrupted message: the alert type is set to the unused 98 code to indicate this new error condition. The ok flag is false; the screen message shows 'Checkin failed: data problem'. [3] The item checked in was not checked out AND the option checked_in_ok is active. The ok flag is set to true; no screen message. [4] The item checked in was not checked out AND the option checked_in_ok is not active. The ok flag is not changed (normally false); the screen message shows 'Item not checked out'. [5] (The regular checkin) The item was checked out and AddReturn returned true. The ok flag is true; no screen message. [6] ("Otherwise") The item was checked out, but AddReturn returned false. The ok flag is false; the screen message shows 'Checkin failed'. Note: Currently this case only refers to the Wrongbranch and withdrawn messages from AddReturn (where doreturn==0). Note: Situation 1 and 5 are unchanged. Behavior is slightly changed for situation 3 and 4; the option is only used when the item was not checked out. Situation 2 and situation 6 are changed. After bug 18966 SIP returned OK in case of data corruption (while checkin failed). In the remaining cases under [6] SIP also returned OK while checkin failed. Test plan: [1] Test all six cases listed above. In order to simulate data corruption insert the issue_id at hand in old_issues before you check in. In cases 3 and 4 you need to toggle the option in your SIPconfig.xml and restart the SIP server. Case 6 can be tested by checking out at branch A, adjusting the value of pref AllowReturnToBranch and checking in at branch B. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 13:55:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 11:55:13 +0000 Subject: [Koha-bugs] [Bug 18996] SIP sets ok flag to true for refused checkin for data corruption In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 --- Comment #14 from Marcel de Rooy --- Tiny change: remove uninitialized warn on alert_type and reworded syslog message for case [6]. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:00:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:00:45 +0000 Subject: [Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:01:04 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:01:04 +0000 Subject: [Koha-bugs] [Bug 14572] insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14572 --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:00:55 +0000 Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:01:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:01:13 +0000 Subject: [Koha-bugs] [Bug 18830] Message to user is poorly constructed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18830 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:01:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:01:24 +0000 Subject: [Koha-bugs] [Bug 18400] Noisy warns in opac-search.pl during itemtype sorting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #16 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:05:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:05:45 +0000 Subject: [Koha-bugs] [Bug 17969] Refactor the way <> is generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 17969: Refactor the way <> is generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:13:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:13:29 +0000 Subject: [Koha-bugs] [Bug 18898] Some permissions for Reports can be bypassed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18898 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:13:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:13:31 +0000 Subject: [Koha-bugs] [Bug 18898] Some permissions for Reports can be bypassed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18898 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65320|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 65337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65337&action=edit Bug 18898 - Some permissions for Reports can be bypassed If you manually visit the following links when you only have permission to run reports, you'll still be able to access the ability to create and edit reports: /cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL /cgi-bin/koha/reports/guided_reports.pl?phase=Edit%20SQL This patch ties these 2 unaccounted for phases to the create_reports permission. With patch, issue no longer can be reproduced. Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:14:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:14:55 +0000 Subject: [Koha-bugs] [Bug 18554] Adjust a few typos including responsability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:15:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:15:02 +0000 Subject: [Koha-bugs] [Bug 18858] Warn when deleting a borrower debarment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:15:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:15:13 +0000 Subject: [Koha-bugs] [Bug 18934] Warns in Admin -> SMS providers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18934 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:15:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:15:21 +0000 Subject: [Koha-bugs] [Bug 17639] Remove white filling inside of Koha logo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17639 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:15:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:15:29 +0000 Subject: [Koha-bugs] [Bug 18901] Sysprefs translation: translate only *.pref files (not *.pref* ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18901 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:16:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:16:02 +0000 Subject: [Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #14 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:16:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:16:36 +0000 Subject: [Koha-bugs] [Bug 18955] autocomplete is on in OPAC password recovery In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #7 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:42:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:42:25 +0000 Subject: [Koha-bugs] [Bug 18351] No warning when deleting budgets that have funds attached In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18351 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Nick Clemens --- Sorry Aleisha, should have caught this last pass. The patch does prevent the button from cancelling the deletion, however, deletion is still allowed when forcing the URL: /cgi-bin/koha/admin/aqbudgetperiods.pl?op=delete_confirm& budget_period_id=## We should either add the check in the script as well, or offer the option to delete the funds too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:49:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:49:34 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Barton Chittenden --- Created attachment 65338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65338&action=edit SQL which generates error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:50:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:50:27 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 --- Comment #2 from Barton Chittenden --- Created attachment 65339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65339&action=edit Resultant URI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:52:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:52:23 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 --- Comment #3 from Barton Chittenden --- A report with a very long query cannot be downloaded as CSV, giving the error 'Request-URI Too Long'. I'm escalating the priority to normal because this is no longer simply a cosmetic issue; it affects the operation of koha itself. See the attached sql and uri files. To replicate: 1) Paste the contents of the attached 'bug-18497-sql.sql' into a report. 2) Save and run the report 3) On the report page, click Download and select 'Comma separated text' 4) The resulting URI is as contained in 'bug-18497-uri.txt' (adjusting for server name), and gives the error message Request-URI Too Long The requested URL's length exceeds the capacity limit for this server. Apache/2.4.10 (Debian) Server at catalog.bywatersolutions.com Port 443 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:52:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:52:39 +0000 Subject: [Koha-bugs] [Bug 18857] Have "actions" at both ends of the circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18857 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:52:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:52:41 +0000 Subject: [Koha-bugs] [Bug 18857] Have "actions" at both ends of the circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18857 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64700|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 65340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65340&action=edit Bug 18857 - Add buttons to left hand side of circ rules table To test: * Apply this patch * Define some rules in the interface using the left hand buttons * Define some rules in the interface using the right hand buttons (scroll to see) * Delete some rules in the interface using the left hand buttons * Delete some rules in the interface using the right hand buttons (scroll to see) * Choose a rule to edit using the left hand buttons * Edit the rule, saving using the left hand button * Edit a rule, but clear the values using the left hand buttons * Choose a rule to edit using the right hand buttons (scroll to see) * Edit the rule, saving using the right hand buttons (scroll to see) * Edit a rule, but clear the values using the right hand buttons (scroll to see) Signed-off-by: Guillaume Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:53:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:53:28 +0000 Subject: [Koha-bugs] [Bug 18497] Downloading a report passes the constructed SQL as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 14:54:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 12:54:44 +0000 Subject: [Koha-bugs] [Bug 18857] Have "actions" at both ends of the circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18857 --- Comment #6 from Nick Clemens --- Created attachment 65341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65341&action=edit Bug 18857 (QA Followup) Add title to lower 'Action' header These were showing as blank, for consistency seems like we should label as 'Actions' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:00:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:00:52 +0000 Subject: [Koha-bugs] [Bug 19003] Add a TestBuilder default for borrowers.login_attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19003 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:00:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:00:55 +0000 Subject: [Koha-bugs] [Bug 19003] Add a TestBuilder default for borrowers.login_attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19003 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65329|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 65342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65342&action=edit Bug 19003: Add a TestBuilder default for borrowers.login_attempts Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since TestBuilder fills login_attempts with a random number. (Note: Only when FailedLoginAttempts is non-zero.) Trivial fix: TestBuilder should have a zero default for login_attempts. Test plan: Do not yet apply this patch. Set pref FailedLoginAttempts to say 3. Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ). Apply this patch. Run t/db_dependent/SIP/Message.t again. Does not fail anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:17:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:17:29 +0000 Subject: [Koha-bugs] [Bug 19007] New: Allow paypal payments via debit or credit card again Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Bug ID: 19007 Summary: Allow paypal payments via debit or credit card again Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:22:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:22:28 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 --- Comment #1 from Kyle M Hall --- Created attachment 65343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65343&action=edit Screenshot - Pre-patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:22:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:22:58 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Status|NEW |ASSIGNED --- Comment #2 from Kyle M Hall --- Created attachment 65344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65344&action=edit Screenshot - Post-patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:23:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:23:30 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:23:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:23:33 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 --- Comment #3 from Kyle M Hall --- Created attachment 65345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65345&action=edit Bug 19007 - Allow paypal payments via debit or credit card again A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. Test Plan: 1) Enable paypal for your Koha instance 2) Ensure you are not logged in to PayPal 3) Attempt to pay a fine via PayPal 4) Not the the "Pay with Debit or Credit Card" option is missing 5) Apply this patch 6) Refresh opac-account.pl 7) Attempt to make a payment via PayPal again 8) Note the option "Pay with Debit or Credit Card" is now available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:23:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:23:49 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:24:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:24:06 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:24:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:24:12 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:25:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:25:49 +0000 Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #16 from Nick Clemens --- Everything seems to work fine here, however, errors are really noisy if the file is not found - this shouldn't be an issue really since file isn't configurable, but should it be a little quieter? Waiting for answer before PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:26:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:26:43 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #8 from Jonathan Druart --- Same today (July 31) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:57:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:57:45 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65345|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 65346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65346&action=edit Bug 19007 - Allow paypal payments via debit or credit card again A recent change in Paypal has removed the previous default option of paying via debit or credit card without an account. To bring this option back, we need to send an additional parameter to the PayPal API. Test Plan: 1) Enable paypal for your Koha instance 2) Ensure you are not logged in to PayPal 3) Attempt to pay a fine via PayPal 4) Not the the "Pay with Debit or Credit Card" option is missing 5) Apply this patch 6) Refresh opac-account.pl 7) Attempt to make a payment via PayPal again 8) Note the option "Pay with Debit or Credit Card" is now available Signed-off-by: Kyle M Hall Signed-off-by: George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 15:57:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 13:57:42 +0000 Subject: [Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:04:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:04:01 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:05:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:05:28 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65273|0 |1 is obsolete| | Attachment #65274|0 |1 is obsolete| | Attachment #65275|0 |1 is obsolete| | Attachment #65276|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 65347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65347&action=edit Bug 18980: Add remark next to "Anyone seeing this list" permission This is a follow-up of report 18228 that simplifies the permissions for lists. It reapplies the idea behind bug 10865 by adding a remark next to the Anyone permission if it is not actually effective. A next patch will make it behave dynamically. Note: The Anyone permission is not relevant if it is a private list that has no shares. Note that looking at the prefs OpacAllowPublicListCreation and/or OpacAllowSharingPrivateLists is not decisive. You should look at list permissions and shares in the database; turning off the Sharing pref does not automatically remove all shares in the system. It only blocks creating new shares. We only need changes in opac-shelves.tt and virtualshelves/shelves.tt. Test plan: [1] Verify that you see the remark now in OPAC and staff. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:05:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:05:26 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:05:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:05:35 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #14 from Nick Clemens --- Created attachment 65349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65349&action=edit Bug 18980: Remove js function Check from opac-shelves This function only serves to check if the shelf name is not empty. It does not even work since it incorrectly refers to f.addshelf (while it should test #shelfname). We can solve this and improve consistency by doing the same as in the staff template with html5 required. Test plan: [1] Without this patch it was possible to add a list without a name in OPAC (with js error: TypeError: f.addshelf is undefined). [2] With this patch, verify that you cannot do this anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:05:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:05:32 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #13 from Nick Clemens --- Created attachment 65348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65348&action=edit Bug 18980: Add js to dynamically show/hide the Anyone remark If we we move from Private to Public or vice versa, this should reflect on the Anyone remark from the first patch. If we go back to a private list without shares, we should show it. Handled in a js sub AdjustRemark, triggered by onchange of the category combo or the permission combo. Test plan: [1] Edit a private list without shares in OPAC. Toggle category and/or permissions. Is the remark shown or hidden accordingly? Note: Include a test with OpacAllowPublicListCreation enabled. [2] Edit a shared list or public list in staff. Toggle category/permissions. You should never see the remark. Signed-off-by: Marcel de Rooy Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:05:38 +0000 Subject: [Koha-bugs] [Bug 18980] Add an explanation when Anyone permission has no actual effect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18980 --- Comment #15 from Nick Clemens --- Created attachment 65350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65350&action=edit Bug 18980: Show distinction between shared and private lists in staff Just as we show this distinction in OPAC, this patch adds a type column in the Your lists tab that displays Private or Shared. It always contains Public in the other tab. Test plan: [1] Check if you see Shared for a private lists with shares in staff. [2] Run t/db_dependent/Utils/Datatables_Virtualshelves.t Signed-off-by: Marcel de Rooy Signed-off-by: Lee Jamison Signed-off-by: Marc V?ron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:10:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:10:02 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Christopher Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tubaclarinet at protonmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:27:34 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:27:34 +0000 Subject: [Koha-bugs] [Bug 19008] New: More database cleanups Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Bug ID: 19008 Summary: More database cleanups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:27:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:27:42 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:31:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:31:33 +0000 Subject: [Koha-bugs] [Bug 19009] New: Circulation.t is still failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 Bug ID: 19009 Summary: Circulation.t is still failing randomly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18759 Bug 18759 was supposed to fix random failures from Circulation.t but some tests can still fail randomly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 [Bug 18759] Circulation.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:31:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:31:33 +0000 Subject: [Koha-bugs] [Bug 18759] Circulation.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19009 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 [Bug 19009] Circulation.t is still failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:58:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:58:14 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #2 from Fridolin SOMERS --- Created attachment 65352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65352&action=edit Bug 19008 - More database cleanups - deleted catalog misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deleted catalog tables. Note that deletedbiblio_metadata is managed by foreign key on biblionumber. Test plan : - Count : select count(*),year(timestamp) from deleteditems group by year(timestamp); select count(*),year(timestamp) from deletedbiblio group by year(timestamp); select count(*),year(timestamp) from deletedbiblioitems group by year(timestamp); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-catalog 30 - Recount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:57:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:57:58 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #1 from Fridolin SOMERS --- Created attachment 65351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65351&action=edit Bug 19008 - More database cleanups - statistics misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for statistics table. Test plan : - Count statistics : select count(*),date(datetime) from statistics group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --statistics 30 - Recount statistics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:58:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:58:29 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #3 from Fridolin SOMERS --- Created attachment 65353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65353&action=edit Bug 19008 - More database cleanups - deleted patrons misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for deletedborrowers table. Test plan : - Count : select count(*),date(updated_on) from deletedborrowers group by date(updated_on); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --delete-patrons 30 - Recount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:58:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:58:42 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #4 from Fridolin SOMERS --- Created attachment 65354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65354&action=edit Bug 19008 - More database cleanups - old issues misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_issues table. Test plan : - Count : select count(*),date(datetime) from old_issues group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-issues 30 - Recount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:58:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:58:54 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #5 from Fridolin SOMERS --- Created attachment 65355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65355&action=edit Bug 19008 - More database cleanups - old reserves misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for old_reserves table. Test plan : - Count : select count(*),date(datetime) from old_reserves group by date(datetime); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-reserves 30 - Recount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 16:59:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 14:59:06 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 --- Comment #6 from Fridolin SOMERS --- Created attachment 65356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65356&action=edit Bug 19008 - More database cleanups - item transfers misc/cronjobs/cleanup_database.pl provides some database cleanup. Yet some tables that could need cleanup are not in this script. This patch adds cleanup for branchtransfers table. Test plan : - Count : select count(*),datearrived from branchtransfers group by datearrived; - Run cleanup : misc/cronjobs/cleanup_database.pl -v --transfers 30 - Recount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:02:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:02:45 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:02:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:02:54 +0000 Subject: [Koha-bugs] [Bug 19008] More database cleanups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:03:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:03:19 +0000 Subject: [Koha-bugs] [Bug 19010] New: When downloading reports, long running reoprts will time out Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19010 Bug ID: 19010 Summary: When downloading reports, long running reoprts will time out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org A long running report, such as SELECT * FROM biblio run on a sufficiently large database, will time out when you click Download and select 'Comma separated text'. There is no way to limit the output nor is there any facility to run the query in the background and get the results later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:12:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:12:09 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:12:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:12:15 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 --- Comment #1 from Jonathan Druart --- Created attachment 65357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65357&action=edit Bug 19009: Fix random failures from Circulation.t >From jenkins output: Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues 1..8 not ok 1 [SKIP] I executed it several times and display the different $error, $alerts and question keys. GNA and RESTRICTED were sometimes set, which block the issue. Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection. Test plan: Execute the tests several times and notice that it fails randomly With this patch they should always pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:16:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:16:18 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:16:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:16:25 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57827|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 65358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65358&action=edit Bug 17699: Add more tests to highlight the problem Add problematic cases to highlight the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:16:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:16:31 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #10 from Jonathan Druart --- Created attachment 65359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65359&action=edit Bug 17699: Use limit as end_of_month >From DateTime::Duration pod: "" For positive durations, the "end_of_month" parameter defaults to wrap. For negative durations, the default is "limit". This should match how most people "intuitively" expect datetime math to work. """" We need end_of_month => limit for positive durations as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:16:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:16:36 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #11 from Jonathan Druart --- Created attachment 65360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65360&action=edit Bug 17699: Add test descriptions Test plan: prove -v t/db_dependent/Koha/Patrons.t Subtest: renew_account 1..30 ok 1 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 2 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 3 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 4 - today + 12 months must be 2017-03-31T00:00:00 ok 5 - today + 12 months must be 2017-03-31T00:00:00 ok 6 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 7 - today + 12 months must be 2017-03-31T00:00:00 ok 8 - today + 12 months must be 2017-03-31T00:00:00 ok 9 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 10 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 11 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 12 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 13 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 14 - today + 12 months must be 2017-11-30T00:00:00 ok 15 - today + 12 months must be 2017-11-30T00:00:00 ok 16 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 17 - today + 12 months must be 2017-11-30T00:00:00 ok 18 - today + 12 months must be 2017-11-30T00:00:00 ok 19 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 20 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 21 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 22 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 23 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 24 - today + 12 months must be 2018-07-31T00:00:00 ok 25 - today + 12 months must be 2018-07-31T00:00:00 ok 26 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 27 - today + 12 months must be 2018-07-31T00:00:00 ok 28 - today + 12 months must be 2018-07-31T00:00:00 ok 29 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 ok 30 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:21:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:21:18 +0000 Subject: [Koha-bugs] [Bug 19011] New: Display patron's own notices for patron user itself Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19011 Bug ID: 19011 Summary: Display patron's own notices for patron user itself Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jvr at fct.unl.pt QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Dear Sir, I am still using version 3.22.07 and I am not aware if the option I trying to implement already exists in newer versions. I want the PATRONS to be able to access to their own notices as staff are able to do in, for example: (https://opac.sitename.com:8443/cgi-bin/koha/members/notices.pl?borrowernumber=16). The reason is that there are too many complains as everybody says that they haven't receiced any notice emails for a million reasons; in other words no one wants to paid the fines... For this information already resides in the Koha's database tables and it is only a matter of querying it for the OPAC user (with authenticated login) please inform me how to acomplish this. Thank you in antecipation for an early reply. Victor do Ros?rio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:22:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:22:25 +0000 Subject: [Koha-bugs] [Bug 19010] When downloading reports, long running reoprts will time out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19010 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- Just a thought; We could add a the ability to schedule reports to be run using runreport.pl. So we could say "run this report at this time with these option ( inline html, attached csv, etc ). Don't think that would be too difficult to implement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:23:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:23:41 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #40 from Nick Clemens --- I like this one a lot, but a few issues: 1 - GetMember has been removed should use Koha::Patrons 2 - The sub should not go into C4:Reserves but should be a class method in Koha::Holds you can get patrons with something like (adding conditions per the pref) Koha::Patrons->search({'item.biblionumber'=>$hold->biblionumber,issue_id=>{'!=' => undef} },{ join => {'issues' => 'item'} }) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:29:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:29:35 +0000 Subject: [Koha-bugs] [Bug 18906] Superlibrarian and budget_manage_all users should always see all funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:29:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:29:38 +0000 Subject: [Koha-bugs] [Bug 18906] Superlibrarian and budget_manage_all users should always see all funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65288|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 65361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65361&action=edit Bug 18906: Display all funds the logged in user can use There are complex conditions to know if a librarian can use a fund, we cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget When this patch is applied then all funds are visible to both superlibrarian patrons and patrons with all acq permissions Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:30:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:30:59 +0000 Subject: [Koha-bugs] [Bug 18906] Superlibrarian and budget_manage_all users should always see all funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18906 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- Permissions could be more thought out, but this ensures that superlibrarians and users that can manage_all_budgets can access any fund to correct permissions/add users/etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:36:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:36:21 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #12 from Jonathan Druart --- Important note: these patches are going to change the existing behaviour (how the dates are calculated), not only fix the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:53:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:53:22 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:53:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:53:24 +0000 Subject: [Koha-bugs] [Bug 12644] Add subtitles to staff client cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12644 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63719|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 65362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65362&action=edit Bug 12644 - Add subtitles to staff client cart This patch adds display of subtitles to the staff client cart. To test you should have some values mapped to subtitle in Administration -> Keyword to MARC Mapping. 1. Apply the patch. 2. Add some records to the staff client cart which have subtitles. 3. Open the cart and onfirm that subtitles display correctly in both the brief and "More details" view. Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:54:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:54:35 +0000 Subject: [Koha-bugs] [Bug 18424] Implement different password strength settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18424 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Marc V?ron --- *** This bug has been marked as a duplicate of bug 12617 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 17:54:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 15:54:35 +0000 Subject: [Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity /difficulty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 --- Comment #2 from Marc V?ron --- *** Bug 18424 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:10:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:10:56 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #5 from Nick Clemens --- Nice! A couple things: 1 - Duplicated code for testing the input and generating the list name - we should really only bother inside the check to create a list or not 2 - We should link from the results page to the newly created list 3 - We may want to optionally include overwritten borrowers in the list, they are sort of imported - I see use case in a school that overwrites patrons to update contact info/expiration and may generate new cards regularly -not blocker but would be nice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:15:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:15:32 +0000 Subject: [Koha-bugs] [Bug 19012] New: Note additional columns that are required during patron import Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Bug ID: 19012 Summary: Note additional columns that are required during patron import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We say 'branchcode' and 'categorycode' are required - this is true, but so are surname and cardnumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:15:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:15:55 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:17:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:17:53 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:17:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:17:55 +0000 Subject: [Koha-bugs] [Bug 19012] Note additional columns that are required during patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19012 --- Comment #1 from Nick Clemens --- Created attachment 65363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65363&action=edit Bug 19012 - Note additional columns that are required during patron import This adds surname and cardnumber to the list of required columns on the import tool screen and help page To test: Read the updated notes, verify it is true and understandable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:23:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:23:12 +0000 Subject: [Koha-bugs] [Bug 16726] Text in Preferences search box does not clear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16726 --- Comment #18 from Owen Leonard --- I would prefer the heading to follow the format of catalog search results, "X result(s) found for 'term'" If that's not possible I think this patch is fine. I don't think the message dialog is the right solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:36:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:36:09 +0000 Subject: [Koha-bugs] [Bug 18973] Auto focus the ISBN field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18973 Father Vlasie changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:39:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:39:13 +0000 Subject: [Koha-bugs] [Bug 17969] Refactor the way <> is generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:39:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:39:18 +0000 Subject: [Koha-bugs] [Bug 17969] Refactor the way <> is generated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17969 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63976|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 65364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65364&action=edit Bug 17969: Refactor the way <> is generated <> is generated 4x in advance_notices.pl and once in overdue_notices.pl It would be better to have it in C4::Letters. It will enforce the fact that it already has the same behavior, make it testable and reusable. Test plan: Use the <> tag for advance and overdue notices. The generated notices must be the same as before this patch. Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:44:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:44:07 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens --- Hi Marc, 1 - I am not sure where that closing div goes - #newcheckout does seem to close properly unless I missed something 2 - Why not use Koha.Preference TT plugin instead of passing the pref? -Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:48:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:48:48 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65358|0 |1 is obsolete| | Attachment #65359|0 |1 is obsolete| | Attachment #65360|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 65365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65365&action=edit Bug 17699: Add more tests to highlight the problem Add problematic cases to highlight the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:48:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:48:58 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #15 from Jonathan Druart --- Created attachment 65367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65367&action=edit Bug 17699: Add test descriptions Test plan: prove -v t/db_dependent/Koha/Patrons.t Subtest: renew_account 1..30 ok 1 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 2 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 3 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 4 - today + 12 months must be 2017-03-31T00:00:00 ok 5 - today + 12 months must be 2017-03-31T00:00:00 ok 6 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 7 - today + 12 months must be 2017-03-31T00:00:00 ok 8 - today + 12 months must be 2017-03-31T00:00:00 ok 9 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 10 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 11 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 12 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 13 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 14 - today + 12 months must be 2017-11-30T00:00:00 ok 15 - today + 12 months must be 2017-11-30T00:00:00 ok 16 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 17 - today + 12 months must be 2017-11-30T00:00:00 ok 18 - today + 12 months must be 2017-11-30T00:00:00 ok 19 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 20 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 21 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 22 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 23 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 24 - today + 12 months must be 2018-07-31T00:00:00 ok 25 - today + 12 months must be 2018-07-31T00:00:00 ok 26 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 27 - today + 12 months must be 2018-07-31T00:00:00 ok 28 - today + 12 months must be 2018-07-31T00:00:00 ok 29 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 ok 30 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:48:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:48:54 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #14 from Jonathan Druart --- Created attachment 65366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65366&action=edit Bug 17699: Use limit as end_of_month >From DateTime::Duration pod: "" For positive durations, the "end_of_month" parameter defaults to wrap. For negative durations, the default is "limit". This should match how most people "intuitively" expect datetime math to work. """" We need end_of_month => limit for positive durations as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:50:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:50:50 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I still get one failure: t/db_dependent/Circulation.t .. 68/96 # Failed test 'days_in_advance is 7 in GetUpcomingDueIssues if not provided' # at t/db_dependent/Circulation.t line 894. # got: '3' # expected: '2' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:53:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:53:38 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64993|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 65368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65368&action=edit Bug 18851: Fix few other tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:53:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:53:55 +0000 Subject: [Koha-bugs] [Bug 18851] use Test::DBIx::Class in tests breaks packaging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 18:57:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 16:57:24 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 --- Comment #3 from Jonathan Druart --- I have never seen this one. Does it fail randomly? If not it should be fixed on another bug report, it's certainly data dependent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:05:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:05:19 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #16 from Owen Leonard --- Created attachment 65369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65369&action=edit [SIGNED-OFF] Bug 17699: Add test descriptions Test plan: prove -v t/db_dependent/Koha/Patrons.t Subtest: renew_account 1..30 ok 1 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 2 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 3 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 4 - today + 12 months must be 2017-03-31T00:00:00 ok 5 - today + 12 months must be 2017-03-31T00:00:00 ok 6 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 7 - today + 12 months must be 2017-03-31T00:00:00 ok 8 - today + 12 months must be 2017-03-31T00:00:00 ok 9 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 10 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 11 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 12 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 13 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 14 - today + 12 months must be 2017-11-30T00:00:00 ok 15 - today + 12 months must be 2017-11-30T00:00:00 ok 16 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 17 - today + 12 months must be 2017-11-30T00:00:00 ok 18 - today + 12 months must be 2017-11-30T00:00:00 ok 19 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 20 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 21 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 22 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 23 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 24 - today + 12 months must be 2018-07-31T00:00:00 ok 25 - today + 12 months must be 2018-07-31T00:00:00 ok 26 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 27 - today + 12 months must be 2018-07-31T00:00:00 ok 28 - today + 12 months must be 2018-07-31T00:00:00 ok 29 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 ok 30 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 Signed-off-by: Owen Leonard All tests successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:05:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:05:30 +0000 Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18545 --- Comment #11 from Marc V?ron --- This solution does no longer work on top of Bug 18545 because the JavaScript is triggered by classes "brief", "detail" etc., and they display the original sprites / icons. As a result, we get two icons if we add the Famfamfam icons. For the original aim of this bug see comment #1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:05:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:05:30 +0000 Subject: [Koha-bugs] [Bug 18545] Remove use of onclick from OPAC Cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18545 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18546 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:05:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:05:43 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:07:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:07:21 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65365|0 |1 is obsolete| | --- Comment #17 from Owen Leonard --- Created attachment 65370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65370&action=edit [SIGNED-OFF] Bug 17699: Add more tests to highlight the problem Add problematic cases to highlight the problem. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:07:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:07:24 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #18 from Owen Leonard --- Created attachment 65371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65371&action=edit [SIGNED-OFF] Bug 17699: Use limit as end_of_month >From DateTime::Duration pod: "" For positive durations, the "end_of_month" parameter defaults to wrap. For negative durations, the default is "limit". This should match how most people "intuitively" expect datetime math to work. """" We need end_of_month => limit for positive durations as well. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:07:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:07:27 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 --- Comment #19 from Owen Leonard --- Created attachment 65372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65372&action=edit [SIGNED-OFF] Bug 17699: Add test descriptions Test plan: prove -v t/db_dependent/Koha/Patrons.t Subtest: renew_account 1..30 ok 1 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 2 - 2016-02-29T00:00:00 + 12 months must be 2017-02-28T00:00:00 ok 3 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 4 - today + 12 months must be 2017-03-31T00:00:00 ok 5 - today + 12 months must be 2017-03-31T00:00:00 ok 6 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 7 - today + 12 months must be 2017-03-31T00:00:00 ok 8 - today + 12 months must be 2017-03-31T00:00:00 ok 9 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 10 - 2016-04-30T00:00:00 + 12 months must be 2017-04-30T00:00:00 ok 11 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 12 - 2016-10-30T00:00:00 + 12 months must be 2017-10-30T00:00:00 ok 13 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 14 - today + 12 months must be 2017-11-30T00:00:00 ok 15 - today + 12 months must be 2017-11-30T00:00:00 ok 16 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 17 - today + 12 months must be 2017-11-30T00:00:00 ok 18 - today + 12 months must be 2017-11-30T00:00:00 ok 19 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 20 - 2016-12-30T00:00:00 + 12 months must be 2017-12-30T00:00:00 ok 21 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 22 - 2017-06-30T00:00:00 + 12 months must be 2018-06-30T00:00:00 ok 23 - With BorrowerLogs, Koha::Patron->renew_account should have logged ok 24 - today + 12 months must be 2018-07-31T00:00:00 ok 25 - today + 12 months must be 2018-07-31T00:00:00 ok 26 - Without BorrowerLogs, Koha::Patron->renew_account should not have logged ok 27 - today + 12 months must be 2018-07-31T00:00:00 ok 28 - today + 12 months must be 2018-07-31T00:00:00 ok 29 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 ok 30 - 2017-08-31T00:00:00 + 12 months must be 2018-08-31T00:00:00 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:07:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:07:50 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:07:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:07:53 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:08:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:08:28 +0000 Subject: [Koha-bugs] [Bug 17699] DateTime durations are not correctly subtracted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:08:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:08:40 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:08:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:08:47 +0000 Subject: [Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:10:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:10:44 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:11:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:11:10 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 --- Comment #4 from Owen Leonard --- Sorry, tester error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:12:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:12:22 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:12:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:12:24 +0000 Subject: [Koha-bugs] [Bug 19009] Circulation.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19009 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65357|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 65373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65373&action=edit [SIGNED-OFF] Bug 19009: Fix random failures from Circulation.t >From jenkins output: Subtest: CanBookBeIssued + Koha::Patron->is_debarred<7c>has_overdues 1..8 not ok 1 [SKIP] I executed it several times and display the different $error, $alerts and question keys. GNA and RESTRICTED were sometimes set, which block the issue. Reading the code it seems that some patron's attributes must be removed to avoid the checkin rejection. Test plan: Execute the tests several times and notice that it fails randomly With this patch they should always pass. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:21:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:21:02 +0000 Subject: [Koha-bugs] [Bug 18555] Create patron list from patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #6 from Marc V?ron --- (In reply to Nick Clemens from comment #5) > Nice! A couple things: > > 1 - Duplicated code for testing the input and generating the list name - we > should really only bother inside the check to create a list or not > 2 - We should link from the results page to the newly created list > 3 - We may want to optionally include overwritten borrowers in the list, > they are sort of imported - I see use case in a school that overwrites > patrons to update contact info/expiration and may generate new cards > regularly -not blocker but would be nice Hi Nick Can you elaborate a little bit what you mean by 1) ? 2) and 3) could go to a new bug based on this one - I have not much time ATM. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:24:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:24:31 +0000 Subject: [Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381 --- Comment #8 from Marc V?ron --- Hi Nick I have no time ATM - If you like feel free to provide a follow-up. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 19:26:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 17:26:33 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:11:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:11:41 +0000 Subject: [Koha-bugs] [Bug 19013] New: sample_data.sql inserts patrons with guarantorid that do not exist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013 Bug ID: 19013 Summary: sample_data.sql inserts patrons with guarantorid that do not exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org MariaDB [koha_kohadev]> select borrowernumber, guarantorid from borrowers where guarantorid is not null; +----------------+-------------+ | borrowernumber | guarantorid | +----------------+-------------+ | 6 | 102 | | 7 | 104 | | 8 | 112 | | 15 | 131 | | 18 | 160 | | 21 | 177 | | 30 | 254 | | 35 | 287 | | 36 | 288 | | 37 | 289 | | 40 | 320 | | 42 | 337 | +----------------+-------------+ MariaDB [koha_kohadev]> select max(borrowernumber) from borrowers; +---------------------+ | max(borrowernumber) | +---------------------+ | 50 | +---------------------+ That breaks randomly tests on Jenkins (Koha/Patrons.t) # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 85. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 88. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 95. # got: '3' # expected: '2' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 98. # got: '3' # expected: '2' # Looks like you failed 4 tests of 8. # Failed test 'guarantees' # at t/db_dependent/Koha/Patrons.t line 100. # Failed test 'Delete should have deleted the patron' # at t/db_dependent/Koha/Patrons.t line 905. # got: '51' # expected: '52' # Looks like you failed 2 tests of 22. [16:26:26] t/db_dependent/Koha/Patrons.t ................................ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:14:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:14:25 +0000 Subject: [Koha-bugs] [Bug 19013] sample_data.sql inserts patrons with guarantorid that do not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013 --- Comment #1 from Jonathan Druart --- Created attachment 65374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65374&action=edit Bug 19013: Fix borrowers.guarantorid in sammple_patrons.sql That breaks randomly tests on Jenkins (Koha/Patrons.t) It certainly affects data in other languages but I did not find a quick and easy way to modify this file (replace all guarantorid values with NULL) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:14:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:14:21 +0000 Subject: [Koha-bugs] [Bug 19013] sample_data.sql inserts patrons with guarantorid that do not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:26:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:26:37 +0000 Subject: [Koha-bugs] [Bug 19013] sample_data.sql inserts patrons with guarantorid that do not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:34:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:34:51 +0000 Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:34:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:34:56 +0000 Subject: [Koha-bugs] [Bug 18802] Circulation.t fails if finesMode != "Do not calculate" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65327|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 65375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65375&action=edit Bug 18802: Fix Circulation.t if finesMode ne 'production' If finesMode is not set to production, only 1 fine will be created (the renewal one will not). This is what assumes the tests. If set to 'production', the tests will fail because the fines will not be deleted (because of the DBIx::Class) warning. Now we mock the value before charging. prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 16/95 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at t/db_dependent/Circulation.t line 491 t/db_dependent/Circulation.t .. 56/95 # Failed test 'Can auto renew, OPACFineNoRenewals=10, patron has 10' # at t/db_dependent/Circulation.t line 670. # got: 'auto_too_much_oweing' # expected: 'auto_renew' # Looks like you failed 1 test of 6. Test plan: prove t/db_dependent/Circulation.t should return green whatever the value of finesMode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:45:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:45:55 +0000 Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com --- Comment #38 from Jonathan Druart --- *** Bug 18953 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:45:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:45:55 +0000 Subject: [Koha-bugs] [Bug 18953] Cannot use internal login after ldap failure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #5 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 18880 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:49:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:49:28 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 MetaBiblioteca Colombia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- CC| |felipe.gomez3 at gmail.com --- Comment #9 from MetaBiblioteca Colombia --- Hello, In Koha 17.X (0,1,2) This error still persists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:49:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:49:29 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Bug 7172 depends on bug 16760, which changed state. Bug 16760 Summary: Circulation Statistics wizard not populating itemtype correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:59:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:59:19 +0000 Subject: [Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |FIXED --- Comment #10 from Jonathan Druart --- (In reply to MetaBiblioteca Colombia from comment #9) > Hello, In Koha 17.X (0,1,2) This error still persists Please open a new bug report and describe the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 31 21:59:20 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2017 19:59:20 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Bug 7172 depends on bug 16760, which changed state. Bug 16760 Summary: Circulation Statistics wizard not populating itemtype correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.