From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 00:20:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Jun 2017 22:20:48 +0000
Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for
IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64742|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 00:50:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Jun 2017 22:50:17 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
--- Comment #13 from Marc V?ron ---
(In reply to Marcel de Rooy from comment #12)
> Applying: Bug 18881: Remove dead code in circ/view_holdsqueue.pl
> fatal: sha1 information is lacking or useless (circ/view_holdsqueue.pl).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
Re-tested, applies cleanly here (on top of Bug 18859).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 01:45:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 30 Jun 2017 23:45:17 +0000
Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another
patron prints a slip but does not update hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798
--- Comment #7 from Nick Clemens ---
(In reply to Katrin Fischer from comment #6)
> > To my understanding, this is what happened :
> >
> > Situation 1 (regular)
> >
> > - Patron A put a hold on Book A
> > - Book A is returned. Hold is confirmed.
> > - Patron B checkout Book A
> > - Koha says "This book is on hold for Patron A, what do you want to do?"
> > - The button "Don't checkout and print" allows you to cancel the process and
> > print a slip.
> > - It keeps the book on hold for Patron A. It's actually already on hold so
> > there should be no reason to update it.
>
> If the item is already on hold for the patron it will allow to reprint the
> hold slip. Sounds good.
>
>
> > BUT, here comes situation 2 (exception)
> >
> > - Patron A put a hold on Book A
> > - Book A is returned. Hold is NOT confirmed (Library wants to confirm the
> > hold later to control when the confirmation email is sent, or library had
> > forgotten, etc.)
> > - Patron B checkout Book A
> > - Koha says "This book is on hold for Patron A, what do you want to do?"
> > - The button "Don't checkout and print" allows you to cancel the process and
> > print a slip.
> > - The hold is not confirmed and this button doesn?t update it.
>
> I think that's wrong - you should not have a hold slip if no email is
> generated and the hold is not set to waiting. The slip should only happen if
> the hold is waiting or set to waiting - otherwise you end up with
> 'available' items on the hold shelf.
>
> I wonder if the message could be better as on hold sounds like it's already
> waiting, but it's not. We should have different messages for already waiting
> and having a hold on it that's not yet confirmed.
>
> I think what Nick describes is a 3rd option: hold for A, don't confirm hold,
> try to checkout to A. In this case, the item was not waiting and should be
> set to waiting.
Yes, as I follow things this is correct - I was thinking of the situation
where:
A places a hold from home
B picks up the book off the shelf before a hold list is checked
Try to checkout to B, print slip, hold never confirmed
I think you are getting at language something like:
this item has a hold for Patron A
versus
this item is on hold for Patron A
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:22:04 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 00:22:04 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #2 from M. Tompsett ---
I figured the test added should fail under master, so:
git bz apply 18755
git checkout origin/master -- C4/SIP/Sip/MsgType.pm
prove t/db_dependent/SIP/Message.t
-- fails as expected
git reset --hard origin/master
git bz apply 18755
prove t/db_dependent/SIP/Message.t
-- passes as expected.
This change is fully tested by the test that is added, so I'm going to sign
off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:22:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 00:22:55 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:22:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 00:22:57 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64101|0 |1
is obsolete| |
--- Comment #3 from M. Tompsett ---
Created attachment 64762
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64762&action=edit
Bug 18755 Allow empty passwords in Patron Info to return OK
With this patch a parameter 'allow_empty_passwords="1" can be added to a
login in the SIP configuration file to allow the behaviour as was normal
before the patch for bug 16610 was applied. Some sip clients rely on
this behaviour sending an empty password field when they wish to
validate to user but do not have the password.
If a password is supplied it will be validated
A test has been added to Message.t to confirm this behaviour
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:59:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 00:59:01 +0000
Subject: [Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
CC| |mtompset at hotmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 02:58:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 00:58:50 +0000
Subject: [Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785
--- Comment #2 from M. Tompsett ---
Comment on attachment 64197
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64197
Bug 18785: Add Koha::Subscription::biblio
Review of attachment 64197:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18785&attachment=64197)
-----------------------------------------------------------------
::: Koha/Subscription.pm
@@ +44,5 @@
> +
> +sub biblio {
> + my ($self) = @_;
> +
> + return Koha::Biblios->find($self->biblionumber);
There are a bunch of other bugzilla issues related to ->find and a scalar
context.
Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or
I think others get lazy ->find( scalar $self->biblionumber )... or was it
return scalar Koha::Biblios->find($self->biblionumber);
Hmmm... anyways, this isn't right, as far as I can tell.
Plus if it is singular, then why Biblios? This is the part I don't understand
in this and other code.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 05:25:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 03:25:57 +0000
Subject: [Koha-bugs] [Bug 9409] koha-create --request-db should be able to
accept a dbhost option
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9409
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|tomascohen at gmail.com |mtompset at hotmail.com
--- Comment #4 from M. Tompsett ---
Thanks for the sign off, LeeJ. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 05:50:38 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 03:50:38 +0000
Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for
IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743
--- Comment #3 from Alex Buckley ---
Created attachment 64763
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64763&action=edit
Bug 18743 - Removed library filter in Acquisition suggestions when
IndependentBranches enabled
Also ensured that when a superlibrarian is logged in then suggestions from
all branches are displayed with IndependentBranches being either on or off, as
this
syspref does not affect what suggestions superlibrarians can see.
But when non-superlibrarian user with access to the acquisitions module
visits it when IndependentBranches is enabled then only suggestions of
the branch they are logged in with are displayed.
If non-superlibrarian users log in when IndependentBranches is not
enabled then suggestions from all branches are displayed.
Note: The library filter in the 'Organize by' area (which is displayed when
multiple branches suggestions are displayed according to the aforementioned
logic) successfully splits the suggestions into different tabs with the correct
number of suggestions for each branch
displayed in each tab.
Test plan:
1. Create 2 suggestions a library branch (which I will refer to in this
test plan as branch A)
2. Create 1 suggestion for a different branch (which I will refer to as
branch B)
3. Log into staff client as superlibrarian with either branch and ensure the
IndependentBranches syspref is set to 'yes'
4. Go to Acquisitions->Suggestions Management
5. Notice that suggestions from branch A and B are displayed
6. In the Organize by are click to filter by library and click go
7. Notice that one tab says (2) whilst the other tab
says (1) with each tab containing the relevant
suggestions to that branch
8. Now change the IndependentBranches syspref to 'no'
9. Repeat steps 4, 5, 6, 7 noticing the same outcome in step 7
10. Log out and log back into staff client in branch A as a non-superlibrarian
user
who has access to the Acquisitions module
11. Currently IndependentBranches is set to 'no' so go to
Acquisitions->Suggestions Management
12. Repeat steps 5, 6, 7 and notice the same outcome as step 7
13. Change IndependentBranches to 'yes'
14. Go to Acquisitions->Suggestions Management
15. Notice that only suggestions from branch A (the branch you are
logged in with) are displayed. This is because when IndependentBranches
is enabled non-superlibrarians do not need to see suggestions from other
branches
16. Also noticethat there is no 'library' option in the 'Organized by'
area. This is because only suggestions from the current branch are
displayed and so organizing by library is redundant.
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 11:17:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 09:17:56 +0000
Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in
onboarding tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Jul 1 11:19:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 09:19:05 +0000
Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules',
use for 'max_holds' rules
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 00:02:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 22:02:25 +0000
Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 00:02:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 22:02:30 +0000
Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64676|0 |1
is obsolete| |
--- Comment #2 from Alex Buckley ---
Created attachment 64764
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64764&action=edit
Bug 18861 - branch_transfer_limits needs keys
The branch transfers limits are edited in :
/cgi-bin/koha/admin/branch_transfer_limits.pl
This page calls a loop on IsBranchTransferAllowed with all destination branches
and codes (ccodes or itemtypes).
This can takes a huge time because table branch_transfer_limits has no keys.
Since ccode or itemtype may be used, this patch adds a key on both combinaison
: ccode/fromBranch/toBranch and itemtype/fromBranch/toBranch.
Tested on a table with 66000 entries, time whent from 26 second to less than 1
second.
Test plan :
- Go to Administration > Library transfer limits
- Check page load is faster
- Uncheck a checkbox
- Save
=> Verify save is OK
- Change branch and same tests
Followed test plan which worked as intended
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 00:05:32 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 01 Jul 2017 22:05:32 +0000
Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alexbuckley at catalyst.net.nz
Status|Signed Off |In Discussion
--- Comment #3 from Alex Buckley ---
Hi Frindolin
Your patch works well, one thing I noticed was that it would be logical for the
checkbox of the current branch not to be displayed.
i.e. if I am looking at the Fairfield checkin and transfer policy then the
fairfield checkbox should not be displayed because when you uncheck the
fairfield box then save the page it reloads with fairfield checked again.
Perhaps this could be a future patch :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 10:28:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jul 2017 08:28:10 +0000
Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to
be embedded in Acquisitions to help the users set up Acquisitions for the
first time
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64732|0 |1
is obsolete| |
--- Comment #46 from Alex Buckley ---
Created attachment 64765
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64765&action=edit
Bug 18002 - Created an acquisition onboarding tool to be displayed when no
currency, budget, or fund exists
Implemented scrolling for acquisition onboarding tool.
Hidden the active checkbox for currencies and budget, and made exchange
rate readonly (displayed).
Same test plan as comment 29.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 12:28:58 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jul 2017 10:28:58 +0000
Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users
through setting up labels for the first time
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64733|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 12:29:25 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jul 2017 10:29:25 +0000
Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users
through setting up labels for the first time
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060
--- Comment #11 from Alex Buckley ---
Created attachment 64766
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64766&action=edit
Bug 18060 - Label onboarding tool to be displayed when no labels or templates
exist
Updated to apply cleanly with bug 18002
Please follow the test plan on comment 8
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 12:41:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jul 2017 10:41:42 +0000
Subject: [Koha-bugs] [Bug 18621] After duplicate message system picks
category expiry date rather than manual defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |alexbuckley at catalyst.net.nz
|ity.org |
CC| |alexbuckley at catalyst.net.nz
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Jul 2 16:30:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 02 Jul 2017 14:30:05 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 02:20:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 00:20:46 +0000
Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in
onboarding tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888
--- Comment #1 from Alex Buckley ---
Created attachment 64767
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64767&action=edit
Bug 18888 - Currency defined in new onboardingstep6.tt after installation
Test plan:
1. Restart memcached and drop and recreate your database
2. Go through the Koha web installer making sure to install all data
except the currencies
3. Run through the onboarding tool noticing that after creating the
circulation rule the complete page appears and you can click to log into
Koha with the superlibrarian user you have created in the onboarding
tool
4. Apply patch
5. Repeat step 1, and 2
6. Run through the onboarding tool and notice that after creating the
circulation rule, a screen appears for you to define a currency
7. Write in the currency name and symbol (notice: you cannot edit the
exchange rate of 1) and submit the form
8. Notice the complete screen appears and you can log in with the
superlibrarian account created in the onboarding tool
9. Go to Administration->Currencies and exchange rates and notice that
the currency you created in the onboarding tool is displayed as active
10. Repeat step 1
11. Go through the Koha web installer making sure to install all data
including currencies
12. Run through the onboarding tool and notice that after creating the
circulation rule then the complete screen appears and click to log into
Koha with your superlibrarian account
13. Run qa tool and all tests should be successful
14. Sign off
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 02:21:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 00:21:24 +0000
Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in
onboarding tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 07:26:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 05:26:23 +0000
Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for
IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743
Alex Buckley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64763|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 07:27:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 05:27:01 +0000
Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for
IndependentBranches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743
--- Comment #4 from Alex Buckley ---
Created attachment 64768
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64768&action=edit
Bug 18743 - Removed library filter in Acquisition suggestions when
IndependentBranches enabled
Also ensured that when a superlibrarian is logged in then suggestions from
all branches are displayed with IndependentBranches being either on or off, as
this
syspref does not affect what suggestions superlibrarians can see.
But when non-superlibrarian user with access to the acquisitions module
visits it when IndependentBranches is enabled then only suggestions of
the branch they are logged in with are displayed.
If non-superlibrarian users log in when IndependentBranches is not
enabled then suggestions from all branches are displayed.
Note: The library filter in the 'Organize by' area (which is displayed when
multiple branches suggestions are displayed according to the aforementioned
logic) successfully splits the suggestions into different tabs with the correct
number of suggestions for each branch
displayed in each tab.
Test plan:
1. Relicate the bug described in description comment
2. Apply patch
3. Create 2 suggestions a library branch (which I will refer to in this
test plan as branch A)
4. Create 1 suggestion for a different branch (which I will refer to as
branch B)
5. Log into staff client as superlibrarian with either branch and ensure the
IndependentBranches syspref is set to 'yes'
6. Go to Acquisitions->Suggestions Management
7. Notice that suggestions from branch A and B are displayed
8. In the Organize by are click to filter by library and click go
9. Notice that one tab says (2) whilst the other tab
says (1) with each tab containing the relevant
suggestions to that branch
10. In the Acquisition information filter select branch A and then click
'Go' and notice that it successfully filters the results and shows 2
suggestions of branch A only
11. Now change the IndependentBranches syspref to 'no'
12. Repeat steps 6, 7, 8, 9, 10 noticing the same outcome in step 9 and
10
13. Log out and log back into staff client in branch A as a non-superlibrarian
user
who has access to the Acquisitions module
14. Currently IndependentBranches is set to 'no' so go to
Acquisitions->Suggestions Management
15. Repeat steps 6, 7, 8, 9, 10 and notice the same outcome as step 9
and 10
16. Change IndependentBranches to 'yes'
17. Go to Acquisitions->Suggestions Management
18. Notice that only suggestions from branch A (the branch you are
logged in with) are displayed. This is because when IndependentBranches
is enabled non-superlibrarians do not need to see suggestions from other
branches
19. Also notice that there is no 'library' option in the 'Organized by'
area and there is no library filter in the acquisition information area. This
is because only suggestions from the current branch are displayed and so
organizing/filtering by library is redundant.
Sponsored-by: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:20:11 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:20:11 +0000
Subject: [Koha-bugs] [Bug 18811] Visibility settings inconsistent between
framework and authority editor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18811
--- Comment #13 from Marcel de Rooy ---
(In reply to Michael Cabus from comment #12)
> When I run perl misc/maintenance/auth_show_hidden_data.pl -c I get this
> error:
>
> DBIx::Class::ResultSet::find(): find() expects either a column/value
> hashref, or a list of values corresponding to the columns of the specified
> unique constraint 'primary' at /home/vagrant/kohaclone/Koha/Objects.pm line
> 85
>
> Checked Authorities schema and all seemed well.
Hi Michael,
Thanks for testing. I guess that you are using kohadevbox to test, but I wonder
if you have a configuration issue. Line 85 of Koha/Objects in master is not the
DBIx find call, but only the first line of the sub with me.
Please check if your paths are in order. The perl library path should also
point to current master not to the older instance installed on your devbox. Do
you use dev_install in your koha-conf?
Marcel
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:36:15 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:36:15 +0000
Subject: [Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799
--- Comment #21 from Baptiste ---
Hum ok.. So the settings:
item-level_itype => biblio record
XSLTDetailsDisplay, XSLTListsDisplay , XSLTResultsDisplay => "default"
DisplayIconsXSLT => show
noItemTypeImages => show
I can find icons on this page
http://pro.user03-koha.sandbox.biblibre.eu/cgi-bin/koha/catalogue/detail.pl?biblionumber=384&searchid=scs_1499067251739
but with all others settings it works
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:49:34 +0000
Subject: [Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds
Queue
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |RESOLVED
--- Comment #3 from Marcel de Rooy ---
Good catch, Aleisha.
I am moving the solution to 18881 as Marc expanded it.
*** This bug has been marked as a duplicate of bug 18881 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:49:34 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aleisha at catalyst.net.nz
--- Comment #14 from Marcel de Rooy ---
*** Bug 18859 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:36 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:49:36 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Bug 18881 depends on bug 18859, which changed state.
Bug 18859 Summary: Warns when accessing Circulation -> Holds Queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |RESOLVED
Resolution|--- |DUPLICATE
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:49:49 +0000
Subject: [Koha-bugs] [Bug 18859] Warns when accessing Circulation -> Holds
Queue
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|18881 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
[Bug 18881] Remove dead code in circ/view_holdsqueue.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:49:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:49:49 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|18859 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18859
[Bug 18859] Warns when accessing Circulation -> Holds Queue
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:51:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:51:27 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
--- Comment #15 from Marcel de Rooy ---
Created attachment 64769
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64769&action=edit
Bug 18881: Remove dead code from view_holdsqueue.pl
Aleisha spotted the typo in $itemtypes and proposed a correction on bug 18859.
The description was not even used. Template calls GetDescription.
To test:
Verify that viewing the holds queue still works as expected.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:51:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:51:31 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
--- Comment #16 from Marcel de Rooy ---
Created attachment 64770
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64770&action=edit
Bug 18881: [QA Follow-up] Remove even more
Removing the commented section from the template: If it does not work, it
should not be here.
When it works again, put it back in.
Since @itemtypesloop is not used, remove it from the script too.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:51:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:51:48 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64761|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:54:10 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:54:45 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
--- Comment #17 from Marcel de Rooy ---
Taking the liberty to move this directly into PQA now
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:54:52 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:54:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:54:57 +0000
Subject: [Koha-bugs] [Bug 18881] Remove dead code in circ/view_holdsqueue.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18881
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:57:54 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:57:54 +0000
Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in
onboarding tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64767|0 |1
is obsolete| |
--- Comment #2 from Marc V?ron ---
Created attachment 64771
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64771&action=edit
Bug 18888 - Currency defined in new onboardingstep6.tt after installation
Test plan:
1. Restart memcached and drop and recreate your database
2. Go through the Koha web installer making sure to install all data
except the currencies
3. Run through the onboarding tool noticing that after creating the
circulation rule the complete page appears and you can click to log into
Koha with the superlibrarian user you have created in the onboarding
tool
4. Apply patch
5. Repeat step 1, and 2
6. Run through the onboarding tool and notice that after creating the
circulation rule, a screen appears for you to define a currency
7. Write in the currency name and symbol (notice: you cannot edit the
exchange rate of 1) and submit the form
8. Notice the complete screen appears and you can log in with the
superlibrarian account created in the onboarding tool
9. Go to Administration->Currencies and exchange rates and notice that
the currency you created in the onboarding tool is displayed as active
10. Repeat step 1
11. Go through the Koha web installer making sure to install all data
including currencies
12. Run through the onboarding tool and notice that after creating the
circulation rule then the complete screen appears and click to log into
Koha with your superlibrarian account
13. Run qa tool and all tests should be successful
14. Sign off
Sponsored-by: Catalyst IT
Folloewe test plan, works as expected.
Signed-off-by: Marc V?ron
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:58:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:58:10 +0000
Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in
onboarding tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:59:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:59:10 +0000
Subject: [Koha-bugs] [Bug 16610] Regression in SIP2 user password handling
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16610
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=18755
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 09:59:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 07:59:10 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=16610
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:22:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 08:22:41 +0000
Subject: [Koha-bugs] [Bug 18002] Make onboarding tool include framework to
be embedded in Acquisitions to help the users set up Acquisitions for the
first time
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002
--- Comment #47 from Marc V?ron ---
Hi Alex
It works great. Two small issues:
- The modal box now shows sliders (inactive), they are not necessary. I think
it's in #onboardingModal (overflow) or something with the dimensions.
- The rate can not be changed, that is ok now, but users can enter oter values
and try to save. They will need an explanation why the exchange rate can not be
changed. Or maybe better hide the exchange rate?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:34:23 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 08:34:23 +0000
Subject: [Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all
staff members / no specific permission
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911
Ruth Smalley changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rsmalley at livewirewarrington
| |.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:43:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 08:43:08 +0000
Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users
through setting up labels for the first time
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #12 from Marc V?ron ---
Sorry, after applying the patch (on top of 18002, refresh memcahed and plack),
I get an Internal error.
Plack error log says:
Variable "$layout" is not available at /home/marc/koha/labels/label-home.pl
line 55.
Can't call method "get_attr" on an undefined value at
/home/marc/koha/labels/label-home.pl line 55.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:48:06 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 08:48:06 +0000
Subject: [Koha-bugs] [Bug 12355] Print quick slip should not print items
renewed in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12355
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:48:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 08:48:30 +0000
Subject: [Koha-bugs] [Bug 12355] Print quick slip should not print items
renewed in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12355
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=18527
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:48:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 08:48:30 +0000
Subject: [Koha-bugs] [Bug 18527] Add a system preference to exclude renewals
from the quick slip
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=12355
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 10:54:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 08:54:50 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
pay fines screen if borrower has outstanding fines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058
--- Comment #25 from Marc V?ron ---
Still valid?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:31:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 09:31:01 +0000
Subject: [Koha-bugs] [Bug 18889] New: Item number in biblio description in
fine page
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889
Bug ID: 18889
Summary: Item number in biblio description in fine page
Change sponsored?: ---
Product: Koha
Version: 17.05
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: vimal0212 at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Created attachment 64772
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64772&action=edit
Fines
Dear Friends,
Very useful to see the item number (barcode) along with bibliographic details
in fines page. If barcode appears along with book details easy identify the
specific book. For example, in law libraries books with the same title by many
authors (e.g. Constitution of India). Please see the screenshot.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:31:21 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 09:31:21 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889
vimal kumar changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P1 - high
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:43:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 09:43:31 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
--- Comment #21 from Nick Clemens ---
Created attachment 64773
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64773&action=edit
Bug 18434 - Followup fix tests for sorting and factes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:59:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 09:59:37 +0000
Subject: [Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785
Julian Maurice changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--- Comment #3 from Julian Maurice ---
(In reply to M. Tompsett from comment #2)
> There are a bunch of other bugzilla issues related to ->find and a scalar
> context.
> Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or
> I think others get lazy ->find( scalar $self->biblionumber )... or was it
> return scalar Koha::Biblios->find($self->biblionumber);
> Hmmm... anyways, this isn't right, as far as I can tell.
I assume you are talking about bug 18179, but the patch I wrote doesn't make
any call to 'find' in a list context. Plus, there is a check in
Koha::Objects::find that prevents it to be used in a list context, so I think
we're good. Callers of Koha::Subsbcription::biblio will be the ones to have to
make sure it's called in scalar context.
> Plus if it is singular, then why Biblios? This is the part I don't
> understand in this and other code.
The 'find' subroutine is defined in Koha::Objects, not Koha::Object.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 11:59:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 09:59:55 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
--- Comment #4 from Marcel de Rooy ---
Colin: What about Patron Status now?
If you provide no AD field, Patron Status responds with a CQN (without Invalid
password). Should it return a CQ?
Same for empty AD; receive CQN. Should the new option change behavior here?
Note:
Patron Info without AD does not return a CQ. (Should it?)
And an empty AD with allow_e_p returns a CQY.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 12:42:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 10:42:29 +0000
Subject: [Koha-bugs] [Bug 18735] Print Barcode as soon as adding an item
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18735
Marc V?ron changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |veron at veron.ch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 14:20:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 12:20:30 +0000
Subject: [Koha-bugs] [Bug 18890] New: REST API: Fix fetching operation spec
in route chain
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890
Bug ID: 18890
Summary: REST API: Fix fetching operation spec in route chain
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Web services
Assignee: koha-bugs at lists.koha-community.org
Reporter: lari.taskula at jns.fi
QA Contact: testopia at bugs.koha-community.org
Mojolicious::Plugin::OpenAPI version 1.17 added a feature for fetching API spec
in route chain. For us, this type of functionality is used in authentication
with our own workaround introduced in Bug 18137. Our own workaround no longer
works if M::P::OpenAPI version >=1.17.
When upgrading Mojolicious::Plugin::OpenAPI dependency, this patch will fix
the issue.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 14:55:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 12:55:39 +0000
Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in
route chain
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890
--- Comment #1 from Lari Taskula ---
Created attachment 64774
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64774&action=edit
Bug 18890: REST API: Fix fetching operation spec in route chain
Mojolicious::Plugin::OpenAPI version 1.17 added a feature for fetching API spec
in route chain. For us, this type of functionality is used in authentication
with
our own workaround introduced in Bug 18137. Our own workaround no longer works
if
M::P::OpenAPI version >=1.17.
When upgrading Mojolicious::Plugin::OpenAPI dependency, this patch will fix
the issue.
To test:
1. prove t/db_dependent/api/v1
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:29:12 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 14:29:12 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
management
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #40000|0 |1
is obsolete| |
Attachment #40001|0 |1
is obsolete| |
Attachment #40002|0 |1
is obsolete| |
Attachment #42157|0 |1
is obsolete| |
Attachment #43181|0 |1
is obsolete| |
Attachment #43546|0 |1
is obsolete| |
--- Comment #52 from Nick Clemens ---
Created attachment 64775
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64775&action=edit
Bug 12768 - Updated schema files
Signed-off-by: Eivin Giske Skaaren
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:29:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 14:29:18 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
management
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768
--- Comment #53 from Nick Clemens ---
Created attachment 64776
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64776&action=edit
Bug 12768 - Replacement cost and processing fee management
Signed-off-by: Eivin Giske Skaaren
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:29:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 14:29:08 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
management
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:33:40 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 14:33:40 +0000
Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee
management
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768
--- Comment #54 from Nick Clemens ---
Rebased, addressed QA concerns, squashed for readability, added more tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:52:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 14:52:17 +0000
Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in
route chain
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890
--- Comment #2 from Lari Taskula ---
Created attachment 64777
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64777&action=edit
Bug 18890: Fix cities.t
The update also causes some tests authorization tests to fail with HTTP 400
response instead of the expected 401/403. It seems that the parameters were
not properly validated before and the tests were mistakenly passing.
To test:
1. prove t/db_dependent/api/v1/cities.t
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:52:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 14:52:31 +0000
Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in
route chain
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890
--- Comment #3 from Lari Taskula ---
Created attachment 64778
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64778&action=edit
Bug 18890: Fix holds.t
The update also causes some tests authorization tests to fail with HTTP 400
response instead of the expected 401/403. It seems that the parameters were
not properly validated before and the tests were mistakenly passing.
To test:
1. prove t/db_dependent/api/v1/holds.t
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 16:59:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 14:59:47 +0000
Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
--- Comment #6 from Lari Taskula ---
(In reply to Mike from comment #5)
> Hi Lari,
> any progress on it? Jiri propably will ready to join us again and do some
> code on REST. So, we need to know actual state of Your work.
>
> Thank You.
Hi! Sorry for late answer, I was on holidays. Yes, I have some code ready,
attaching it by tomorrow so you can review it. Nice to hear Jiri is joining you
again!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 17:06:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 15:06:43 +0000
Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in
route chain
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |18137
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 17:06:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 15:06:43 +0000
Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from
Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |18890
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890
[Bug 18890] REST API: Fix fetching operation spec in route chain
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 17:07:19 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 15:07:19 +0000
Subject: [Koha-bugs] [Bug 18890] REST API: Fix fetching operation spec in
route chain
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18890
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |lari.taskula at jns.fi
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:08:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 16:08:46 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:08:49 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 16:08:49 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64478|0 |1
is obsolete| |
--- Comment #36 from Nick Clemens ---
Created attachment 64779
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64779&action=edit
[SIGNED-OFF] Bug 14567: Add a browse interface to the OPAC
This is an interface for quick and efficient browsing through records.
It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to
enter the prefix of an author, title, or subject and it'll give you a
list of the options that match that. You can then scroll through these
and select the one you're after. Selecting it provides a list of records
that match that particular search.
To Test:
1 - Have ES running and some records in it
2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url
for your site)
3 - Test searching for author, title, and subject
4 - Verify that results are returned in expected order
5 - Experiment with fuzziness
6 - Click any result and verify specific titles are correct
7 - Click through title to record and verify it is the correct record
Signed-off-by: Sebastian Hierl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:30:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 16:30:43 +0000
Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large
CB files
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685
Jason Robb changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jrobb at sekls.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:32:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 16:32:14 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #12 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #10)
> If I select say Author and set them all to Facetable No in the Search fields
> list on the Biblios tab, I would not expect Author to be still in the Facet
> order list?
I agree, this is not ideal, but I think that comes when we stop hardcoding the
displayable facets all together - I would say beyond the scope of this bug
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 18:52:42 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 16:52:42 +0000
Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317
Blou changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #79 from Blou ---
Should have been in Need Signoff for a month, now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:02:37 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:02:39 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64505|0 |1
is obsolete| |
Attachment #64506|0 |1
is obsolete| |
Attachment #64507|0 |1
is obsolete| |
Attachment #64508|0 |1
is obsolete| |
Attachment #64509|0 |1
is obsolete| |
--- Comment #41 from Nick Clemens ---
Created attachment 64780
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64780&action=edit
Bug 18228: Table revision of virtualshelves
In order to make the permissions easier, we will replace the columns
allow_add, allow_delete_own and allow_delete_other by two new columns
allow_change_from_owner and allow_change_from_others.
The distinction between adding or deleting an entry is no longer made.
If you have change permission, you can do both. Also deleting an entry
does no longer depend on who added the entry.
Formerly, the owner could always add entries. It is now possible to
make a list readonly.
We will not use the combination of owner=no and other=yes. This will
leave us three possibilities:
[1] owner=no, other=no: The list is read-only. No one can change
contents of the list. Naturally, the owner can edit permissions.
[2] owner=yes, other=no: Only the owner can change contents.
[3] owner=yes, other=yes: Anyone seeing the list can change contents.
This especially applies to shared lists and public lists.
The two database columns will be presented in the interface as one
permission field offering the three abovementioned options.
Test plan:
[1] Run the db rev.
Signed-off-by: Marcel de Rooy
Signed-off-by: Jesse Maseto
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:02:44 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
--- Comment #42 from Nick Clemens ---
Created attachment 64781
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64781&action=edit
Bug 18228: DBIx schema changes for Virtualshelve.pm
No test plan.
Signed-off-by: Marcel de Rooy
Signed-off-by: Jesse Maseto
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:02:48 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
--- Comment #43 from Nick Clemens ---
Created attachment 64782
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64782&action=edit
Bug 18228: Implement the new columns in code
The two new columns as mentioned in the commit message of the table
revision must be used in the codebase now.
Highlighting some changes in Koha::VirtualShel[f|ves]:
[1] Additional methods is_public and is_private.
[2] Method add_biblio did not check permissions. Does now. No impact on the
interface, but one call in the unit test was affected.
[3] Method remove_biblios is signficantly simplified. Removed a FIXME.
[4] Method can_biblios_be_removed now redirects to can_biblios_be_added.
A followup report may deal with unifying those routines.
[5] Condition in get_some_shelves changed.
[6] The reference to allow_add in get_shelves_containing_record can simply
be removed.
opac-shelves.pl and shelves.pl now pass the default setting of Owner only
to the template.
Templates shelves.tt and opac-shelves.tt now include the new permission
field with three choices as mentioned in the table revision patch.
opac-addbybiblionumber.pl and addbybiblionumber now need a check on
allow_change_from_owner; search conditions slightly adjusted to the new
permission scheme.
Test plan:
When we refer to visibility in the test plan, please check the Add to-combo
on opac search results and staff results. And check opac-addbybiblionumber
by clicking Save to Lists from opac results.
The step 'Check delete' means: open the list in opac and check if you see
the Delete button below the entries (only check, do not delete).
[ 1] Create private list I01 (perm=Owner)
[ 2] Check visibility: Seen.
[ 3] Add a book. (Change by owner should be allowed.)
[ 4] Check delete: Yes.
[ 5] Edit list I01, set perm=Nobody
[ 6] Check visibility: Not seen.
[ 7] Check delete: No.
[ 8] Share list I01 with another patron.
[ 9] Check visibility for the other patron: Not seen.
[10] Check delete for the other patron: No.
[11] Change permission of list I01 to Anyone (by owner).
[12] Check visibility for the other patron: Seen.
[13] Let other patron add a book (change is allowed).
[14] Let owner delete the same book again (change allowed).
[15] Create public list U01 (perm=Owner)
[16] Check visibility: Seen.
[17] Add a book. (Change by owner should be allowed.)
[18] Login as other user. Check visibility: Not seen. Check delete: No.
[19] Change permission of U01 to Nobody (by owner)
[20] As owner: Check visibility: Not seen. Check delete: No.
[21] As other user: Check visibility: Not seen. Check delete: No.
[22] Create public list U02 (perm=Anyone)
[23] Add a book by owner.
[24] Delete the same book by other user. Add another book.
Signed-off-by: Marcel de Rooy
Signed-off-by: Jesse Maseto
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:02:52 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
--- Comment #44 from Nick Clemens ---
Created attachment 64783
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64783&action=edit
Bug 18228: Adjust Virtualshelves.t
Test plan:
Run t/db_dependent/Virtualshelves.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Eric Gosselin
Signed-off-by: Jesse Maseto
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:02:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:02:57 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
--- Comment #45 from Nick Clemens ---
Created attachment 64784
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64784&action=edit
Bug 18228: Add missing comma in kohastructure.sql
Signed-off-by: Marcel de Rooy
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:03:01 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:03:01 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
--- Comment #46 from Nick Clemens ---
Created attachment 64785
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64785&action=edit
QA Followup - use gender neutral language in new tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 19:40:55 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 17:40:55 +0000
Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--- Comment #4 from Tom?s Cohen Arazi ---
What is the status of this bug? Signed off?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 20:55:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 18:55:43 +0000
Subject: [Koha-bugs] [Bug 18891] New: Download Reports Directly
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18891
Bug ID: 18891
Summary: Download Reports Directly
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Reports
Assignee: koha-bugs at lists.koha-community.org
Reporter: cslone at camdencountylibrary.org
QA Contact: testopia at bugs.koha-community.org
There should be an option to download a report directly, rather than having to
run the report and then choose to download it (effectively running it twice).
This would be especially helpful when dealing with reports that take a while to
load, though it would also be convenient for reports that are run regularly for
distribution and therefore really don't need to be previewed on the screen
before downloading.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:04:43 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:04:43 +0000
Subject: [Koha-bugs] [Bug 17602] Integrate support for
ONeclickDigital/Recorded Books API
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |tomascohen at gmail.com
--- Comment #28 from Tom?s Cohen Arazi ---
Hi everyone here. I tested this with some credentials Nick gave me. I have a
couple observations about this one.
Important
=========
- I first tested opac-oneclick-search.pl using the q= query param. That way I
found stuff in Oneclick. The searched on the main opac search for a term I knew
should give results (q=1776), and I got (the first time) "Error searching
OneClickDigital collection: Not Found". I then reloaded the results page, and
got "Found 1 results in OneClickDigital collection". This one seemed ok
- When clicking in the '1 results' link, I got a red message "Error searching
OneClickDigital collection: Not Found", on reloading, I got the search results
for 1776.
=> FAIL: It seems there's a problem on the first query, or a throttling stuff
getting in the middle.
Moderate
========
=> FAIL: The search results on opac-oneclick-search.pl have a different styling
than Koha's search results. They look nicer, but I think the same XSLT's shold
be used.
I understood that this is a transition until this search results are displayed
inline along with the regular (local) search results. I wouldn't say the second
item is a blocker, but it might be a reason for others to vote against its
inclusion.
Minor
=====
- Another (minor) thing I would consider changing is the wording for the
sysprefs description. I think they should clearly match what Oneclick provides
the user to configure Koha (LibraryID vs. library #)
- Warnings are logged:
Use of uninitialized value in concatenation (.) or string at
/usr/local/share/perl/5.20.2/WebService/ILS/OneClickDigital/PartnerPatron.pm
line 58.
Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/Koha/ExternalContent/OneClickDigital.pm line 73.
QA scripts
==========
The QA scripts complain about oneclick-checkout.inc
=>
FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/oneclick-checkout.inc
FAIL forbidden patterns
forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 1)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:20 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:07:20 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #63477|0 |1
is obsolete| |
--- Comment #22 from Tom?s Cohen Arazi ---
Created attachment 64786
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64786&action=edit
Bug 18434: Add tests for K:SE:E::get_fixer_rules
This patch tries to introduce exhaustive tests for this class method.
I didn't try to provide a regression test for the current bug per-se, but
cover the current method behaviour as much as I could.
(kidclamp) I added a quick test of _convert_marc_to_json to use the mocking
here
and illuminate what the change does, before the patches this should
fail (fields are indexed in place of one another), after it should succeed (new
indexed fields are appended).
A minor bug is highlighted by this new tests, I'll provide a followup for it.
To test:
- Run:
$ sudo koha-shell kohadev
k$ de kohaclone
k$ prove t/db_dependent/Koha_Elasticsearch.t
=> FAIL: The returned fixer rules are not the expected ones
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:07:27 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #63478|0 |1
is obsolete| |
--- Comment #23 from Tom?s Cohen Arazi ---
Created attachment 64787
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64787&action=edit
Bug 18434: Elasticsearch indexing broken with newer catmandu version
To test:
1 - Make sure you have latest koha deps, catmandu versions should be:
libcatmandu-marc-perl 1.09-1~kohadev1
libcatmandu-perl 1.0304-2~kohadev1
2 - Reindex elastic
3 - Try searching and likely notice odd results
4 - Try:
curl -XGET
'http://localhost:9200/koha_kohadev_biblios/data/792?pretty=true'
with a known biblionumber and notice some null fields
5 - Apply patch
6 - Reindex
7 - Note fields are populated and search works as expected
Signed-off-by: Chris Cormack
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:07:33 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #63479|0 |1
is obsolete| |
--- Comment #24 from Tom?s Cohen Arazi ---
Created attachment 64788
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64788&action=edit
Bug 18434: (QA followup) Move _convert_marc_to_json tests into Indexer.t
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:07:39 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64386|0 |1
is obsolete| |
--- Comment #25 from Tom?s Cohen Arazi ---
Created attachment 64789
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64789&action=edit
Bug 18434 - Followup - same changes for sort and facet fields
To test:
1 - Index some stuff with multiple fields defined for sorting
i.e. Authorites - make heading sortable - default is 110a and 111a for
heading - a record with 111a empty will make the sort field empty
2 - view the record:
curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true
3 - Note the blank field
4 - Apply patch
5 - Reindex
6 - Fields should be correctly populated
Unit tests to follow (once I have the originals working for all)
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:07:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:07:45 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64773|0 |1
is obsolete| |
--- Comment #26 from Tom?s Cohen Arazi ---
Created attachment 64790
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64790&action=edit
Bug 18434 - Followup fix tests for sorting and factes
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:08:48 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:08:48 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #27 from Tom?s Cohen Arazi ---
The last two patches for this one overlap with my patches for bug 18610, this
ones are
ok and i'm closing the other as duplicate.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:09:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:09:14 +0000
Subject: [Koha-bugs] [Bug 18610] ElasticSearch indexing of facets needs to
be updated for newer Catmandu versions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |RESOLVED
Resolution|--- |DUPLICATE
--- Comment #3 from Tom?s Cohen Arazi ---
*** This bug has been marked as a duplicate of bug 18434 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Jul 3 21:09:14 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 19:09:14 +0000
Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer
catmandu version
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
--- Comment #28 from Tom?s Cohen Arazi ---
*** Bug 18610 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 01:39:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 23:39:52 +0000
Subject: [Koha-bugs] [Bug 17875] Linking to series authority records fails
when a space precedes the semicolon
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=16804
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 01:39:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 03 Jul 2017 23:39:52 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
containing semicolons in XSLT
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=17875
CC| |liz at catalyst.net.nz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 02:21:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 00:21:52 +0000
Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid
cardnumber
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267
--- Comment #18 from M. Tompsett ---
Comment on attachment 62934
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62934
[SIGNED OFF] Bug 10267: Show error message if user tries to enter too many
characters for cardnumber
Review of attachment 62934:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10267&attachment=62934)
-----------------------------------------------------------------
::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +621,4 @@
> [% END %]
> [% IF minlength_cardnumber == maxlength_cardnumber %]
>
> + [% IF mandatorycardnumber and not autoMemberNum %]Required[% END %]Card number must not be more than [% maxlength_cardnumber %] characters.
It is impossible to enter more than maxlength_cardnumber characters because the
maxlength attribute of the input line makes it impossible. I believe bug 13178,
providing flexibility of the max size based on the schema which should be
regenerated as needed to match the table's field size, makes this bug obsolete.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 03:10:41 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 01:10:41 +0000
Subject: [Koha-bugs] [Bug 18624] Software error when searching authorities
in Elasticsearch - incorrect parameter "any" should be "all"
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18624
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 03:23:44 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 01:23:44 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
containing semicolons in XSLT
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
--- Comment #1 from Liz Rea ---
Hi Kyle,
Using the MODS url-encode works when you transfer it over to slimUtils, is that
what you had in mind or something else?
Seems like it sorts the problem nicely.
Cheers,
Liz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:36:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 05:36:17 +0000
Subject: [Koha-bugs] [Bug 18817] Screenshots not appearing in the manual
linked to the Help tab
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|major |minor
--- Comment #10 from Katrin Fischer ---
The screenshots/images on manual.koha-community.org have been fixed, so this is
no longer major.
Maybe we should switch all links on master for the 17.11 release - as it can't
be done automatically (changed headings/achors) and it's a lot of help files to
fix. This here will only link from the start page to the new manual.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:37:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 05:37:30 +0000
Subject: [Koha-bugs] [Bug 18847] Add "Save and continue" option to notice
editing
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18847
--- Comment #4 from Katrin Fischer ---
+1 - nice idea!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:39:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 05:39:34 +0000
Subject: [Koha-bugs] [Bug 18876] Broken links in Koha documentation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18876
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz,
| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 07:47:56 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 05:47:56 +0000
Subject: [Koha-bugs] [Bug 18876] Broken links in Koha documentation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18876
--- Comment #1 from Katrin Fischer ---
Hi Pablo,
thx for reporting and for the list. We are aware that a lot of links need to be
fixed with the change to Sphinx as the headings/anchors have changed. Please
take a look at https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual for
some of the ongoing work on the manual :)
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 08:01:39 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 06:01:39 +0000
Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication
fallback for all external authentications
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|critical |blocker
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
Updating severity as this is a blocker issue for libraries using one of those
external methods with no passwords in the db for their users.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:41:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 08:41:51 +0000
Subject: [Koha-bugs] [Bug 16719] LDAP: Using empty strings as 'failsafe'
attribute mapping defeats database constraints
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16719
--- Comment #6 from Oliver Bock ---
Any update on this? Could you reproduce the issue?
Thanks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:50:59 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 08:50:59 +0000
Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause
error when updated on authentication
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625
--- Comment #21 from Oliver Bock ---
IMHO, this can be closed.
Thanks again!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:51:17 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 08:51:17 +0000
Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute
updates to silently fail and corrupt existing data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615
--- Comment #35 from Oliver Bock ---
IMHO, this can be closed.
Thanks again!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 10:58:09 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 08:58:09 +0000
Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all
libraries
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137
--- Comment #15 from Alex Arnaud ---
Created attachment 64791
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64791&action=edit
Bug 8137 - Add default issuing rule for all branches.
This patch does the same that for 'Default checkout limit by patron
category'.
test plan:
- Create an issuing rule a patron category and itemtype. make it has
priority,
- create more permissive issuing rules for all other branches,
- check that the priority rule is taken into account for this category
and itemtype.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 14:00:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 12:00:03 +0000
Subject: [Koha-bugs] [Bug 18228] Make list permissions easier to
use/understand
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18228
--- Comment #47 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #45)
> Signed-off-by: Nick Clemens
Great! Thanks, Nick.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 14:26:29 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 12:26:29 +0000
Subject: [Koha-bugs] [Bug 17380] Resolve several problems related to Default
authority framework
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17380
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Cannot edit authorities |Resolve several problems
|with authtypecode = default |related to Default
| |authority framework
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 16:15:50 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 14:15:50 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
source of import
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
David Gustafsson changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #61736|0 |1
is obsolete| |
--- Comment #57 from David Gustafsson ---
Created attachment 64792
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64792&action=edit
Bug 14957 - Rule based permission for MARC fields
Add a rule based permission system for MARC field modifications.
Test plan:
1. Apply this patch
2. Run updatedatabase.pl
3. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
button with a question mark, click this for more information about the
rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.
Sponsored-by: Halland County Library
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 16:51:37 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 14:51:37 +0000
Subject: [Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large
CB files
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685
DEVINIM changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kohadevinim at devinim.com.tr
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 16:56:05 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 14:56:05 +0000
Subject: [Koha-bugs] [Bug 17615] LDAP Auth: regression causes attribute
updates to silently fail and corrupt existing data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17615
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #36 from Katrin Fischer ---
After releases we move older bugs from "RESOLVED FIXED" to "CLOSED FIXED" in a
big bulk edit, but if you tested, it's ok to just do it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:01:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 15:01:30 +0000
Subject: [Koha-bugs] [Bug 14625] LDAP: mapped ExtendedPatronAttributes cause
error when updated on authentication
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Stable |CLOSED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:01:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 15:01:31 +0000
Subject: [Koha-bugs] [Bug 18587] LDAP: update_local is entirely untested!
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587
Bug 18587 depends on bug 14625, which changed state.
Bug 14625 Summary: LDAP: mapped ExtendedPatronAttributes cause error when updated on authentication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14625
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Stable |CLOSED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:04:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 15:04:03 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
source of import
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
--- Comment #58 from David Gustafsson ---
The last change (adding the $options parameter) contained several mistakes,
(hopefully) fixed those now. Have run the tests and did some manual testing
(which I apparently did not do last time).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 17:24:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 15:24:08 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
--- Comment #5 from Colin Campbell ---
(In reply to Marcel de Rooy from comment #4)
> Colin: What about Patron Status now?
>
> If you provide no AD field, Patron Status responds with a CQN (without
> Invalid
> password). Should it return a CQ?
> Same for empty AD; receive CQN. Should the new option change behavior here?
>
> Note:
> Patron Info without AD does not return a CQ. (Should it?)
> And an empty AD with allow_e_p returns a CQY.
Patron status is a bit odd the CQ is like patron info in being an optional
field, but unlike patron info the AD password field is a required field so I
assume that a missing AD should provoke an invalid password in return.
basically the behaviour has remained unchanged. In practice I cant recall
seeing any kind of unit that uses patron status, I think when sip 2 was
released patron info effectively superceded it. So I think we should leave
functionality as is, just in case anything relies on the current behaviour. ( I
tested on a very old sip software before any of the patches affecting patron
info to confirm that behaviour hadnt been inadvertantly changed by other
patches)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 20:21:57 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 18:21:57 +0000
Subject: [Koha-bugs] [Bug 16662] Letsencrypt II: Return of the cryptosaurus.
( make it work for existing instances)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:04:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 21:04:13 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #52 from Philippe Audet-Fortin ---
Created attachment 64793
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64793&action=edit
Cam 722: Permet a n'importe quelle categorie d'avoir un garant (bz12446)
Il s'agit du code du bz 12446 collapse en un commit.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:07:46 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 21:07:46 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Philippe Audet-Fortin changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64793|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:12:22 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 21:12:22 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Philippe Audet-Fortin changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #63214|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:18:18 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 21:18:18 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Philippe Audet-Fortin changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #60934|0 |1
is obsolete| |
--- Comment #53 from Philippe Audet-Fortin ---
Created attachment 64794
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64794&action=edit
Bug 12446 - Enable an adult to have a guarantor
Concflicts has been fixed. Also attributes in system preference :
AdditionalGuarantorField are now displayed correctly in all scenerios.
I have rebased every patch.
This includes all the features from the previous patches.
Removed the dollar signs and stopped using C4::Category
On the patron category page, there is a new field to specify whether patrons
can be guarantee or not.
The atomic update SQL script adds this new field and sets it to true for
categories of type "C" and "P".
1) Apply the patch
2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and
canbeguarantee to categories.
3) Go to patron category administration, edit a category and change the value
of Can Be Guarantee to yes (for Child and Professional mostly to set it by
default)
4) See below to test various scenarios
- Enable an adult to have a guarantor:
0.0) Create or edit a patron category of type 'A'.
0.1) Set the "Can be guarantee" field to "Yes" and save.
1) Select an adult patron -> details tab;
2) Click edit button;
3) validate "guarantor information" fieldset;
- Shows guarantees' fines in the guarantor's page:
4) Click Set to patron button and select a guarantor;
5) Generate a fine;
6) Select guarantor patron -> details tab;
7) Validate guarantee's fine information.
- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;
- Transfer some guarantor's information to the guarantee while creating a new
patron
0) Select an adult patron;
1) Insert all information;
2) Add a new adult patron;
3) Click "Set to patron" button;
4) Select the adult patron from 0);
5) Validade Garantor information/Main address/Contact fieldsets filled;
- Transfer some guarantor's information to the guarantee while adding a
guarantiee:
0) Select an adult patron;
1) Insert all information;
2) Click Add guarantiee bouton;
3) Validade Garantor information/Main address/Contact fieldsets filled;
- Transfer guarantor's alternate address/contact to the guarantee while
creating a new patron:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
2) Select an adult patron;
3) Insert all information;
4) Add a new adult patron;
5) Click "Set to patron" button;
6) Select the adult patron from 0);
7) Validade Garantor information/Main address/Contact fieldsets filled;
8) Validade Garantor additional alternate address/contact filled;
- Transfer guarantor's alternate address/contact to the guarantee while adding
a guarantiee:
0) Search AdditionalGuarantorField preference;
1) Insert some additional database columns from alternate address/contact to be
transferred from guarantor;
3) Select an adult patron;
4) Insert all information;
5) Click Add guarantiee bouton;
6) Validade Garantor information/Main address/Contact fieldsets filled;
7) Validade Garantor additional alternate address/contact filled;
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Jul 4 23:19:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 21:19:24 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Philippe Audet-Fortin changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #63149|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 00:26:03 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 04 Jul 2017 22:26:03 +0000
Subject: [Koha-bugs] [Bug 18892] New: RDA fields not searchable as Publisher
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18892
Bug ID: 18892
Summary: RDA fields not searchable as Publisher
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Searching
Assignee: koha-bugs at lists.koha-community.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Bug 14198 - RDA: Indexing 264 field (Zebra) added an index called 'Provider'
(with a CCL mapping of 'pv').
However, this does not allow bibs cataloged under RDA to be searched using the
'Publisher' search.
Library of congress shows that 264 indicator 2 can be used to distinguish
manufacture and distribution vs. publication:
Second Indicator - Function of entity
0 - Production
Field contains a statement relating to the inscription, fabrication,
construction, etc., of a resource in an unpublished form.
1 - Publication
Field contains a statement relating to the publication, release, or issuing of
a resource.
2 - Distribution
Field contains a statement relating to the distribution of a resource.
3 - Manufacture
Field contains a statement relating to the printing, duplicating, casting,
etc., of a resource in a published form.
4 - Copyright notice date
Field contains a date associated with a notice of protection under copyright or
a similar regime. Copyright dates include phonogram dates (i.e., dates
associated with claims of protection for sound recordings).
... so indicator 2 values of 1 or 4 should correspond to publisher. We have the
ability to specify indicator values when indexing; we should use it in this
case.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 08:06:10 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 06:06:10 +0000
Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count
only suggestions of current branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449
--- Comment #23 from Katrin Fischer ---
Thinking about this some more:
We had a similar, but not quite the same problem with patron modification
requests. It was solved with the system preference
IndependentBranchesPatronModifications.
So we could have a setting to see suggestions from all branches and a setting
to see only your own. Ideally the suggestions page should reflect that as well
in the preset filter.
But patron modification requests always have a branch - suggestions do not. So
'only your own' does not quite work.
Maybe the solution is to change the text of the message on the dashboard for
this setting, so that it's clearer. I am not quite sure what would work here
best. Thinking of something like:
1 suggestion for your branch [and 2 for any branch] are pending.
I also like Fridolin's idea to make the selected option more visible as this
has caused confusion in our libraries too. Instead of moving the acquisition
filters to the top, I suggest having the branch filter outside and always
visible, putting it below or over the tab organization filter.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 09:24:08 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 07:24:08 +0000
Subject: [Koha-bugs] [Bug 18799] XSLTresultsdisplay hides the icons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18799
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |In Discussion
--- Comment #22 from Fridolin SOMERS ---
I have tested, works well.
But with biblio level item type, the image is displayed right of record text.
Without patch it is left.
Shouldn't it be CSS :
.result-biblio-itemtype { float: left; ...
?
I think display is better with image left.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 10:18:47 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 08:18:47 +0000
Subject: [Koha-bugs] [Bug 18880] Regression breaks local authentication
fallback for all external authentications
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880
--- Comment #2 from Oliver Bock ---
Given the relative urgency, can we assign this bug directly to the original
author of the lines in question? He, Jonathan Druart, should be able to verify
my assertions and fix the issue in no time.
Thanks
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 11:42:51 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 09:42:51 +0000
Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
--- Comment #45 from Lari Taskula ---
Created attachment 64795
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64795&action=edit
Bug 17499: (follow-up) Add information on digest being the only option to
get_options
If a library wants to force digest on a message type, add this information to
Koha::Patron::Message::Preferences->get_options.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 11:59:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 09:59:28 +0000
Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 11:59:30 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 09:59:30 +0000
Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
--- Comment #7 from Lari Taskula ---
Created attachment 64796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64796&action=edit
Bug 17505: REST API route for messaging preferences
Get patron's / category's messaging preferences:
GET /messaging_preferences?borrowernumber=123
- allowed if getting own preferences
- otherwise borrowers flag required
GET /messaging_preferences?categorycode=K
- borrowers flag required
Modify patron's / category's messaging preferences:
PUT /messaging_preferences?borrowernumber=123
- allowed if modifying own preferences
- otherwise borrowers flag required
PUT /messaging_preferences?categorycode=K
- borrowers flag required
Returns the following JSON object (same for PUT except for readOnly values):
{
"Advanced_Notice": {
"days_in_advance": {
"configurable": true,
"value": 20
},
"digest": {
"configurable": true,
"value": true
},
"transport_types": {
"email": true,
"sms": false
}
},
"Another_Message_Name": {
"days_in_advance": {
"configurable": false,
"value": null
},
"digest": { ...
},
...
}
To test:
1. prove t/db_dependent/api/v1/messagingpreferences.t
2. Send GET and PUT requests to /api/v1/messaging_preferences
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 12:00:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 10:00:34 +0000
Subject: [Koha-bugs] [Bug 17505] REST API: Add route for messaging
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |18137
--- Comment #8 from Lari Taskula ---
Depends on Bug 18137 and 17499. These Bugs will conflict in Koha/Exceptions.pm
but should be easily fixable.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 12:00:34 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 10:00:34 +0000
Subject: [Koha-bugs] [Bug 18137] REST API: Migrate from
Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
Lari Taskula changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17505
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505
[Bug 17505] REST API: Add route for messaging preferences
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:08:45 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:08:45 +0000
Subject: [Koha-bugs] [Bug 18893] The dateformat sys pref not used everywhere
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18893
Fiona Borthwick changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fiona.borthwick at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:08:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:08:33 +0000
Subject: [Koha-bugs] [Bug 18893] New: The dateformat sys pref not used
everywhere
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18893
Bug ID: 18893
Summary: The dateformat sys pref not used everywhere
Change sponsored?: ---
Product: Koha
Version: 16.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs at lists.koha-community.org
Reporter: fiona.borthwick at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
CC: frederic at tamil.fr
The dateformat system preference is set to dd/mm/yyyy but this does not carry
through to every screen.
Examples noted are:
Batch item modification - after entering barcodes the second screen shows date
formats as 2017-07-03
Also the specific due date helper in checkout displays the chosen date in a
different format.
It should be consistent.
Tested at 16.11 and 17.05.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:31 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:12:31 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:33 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:12:33 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #64762|0 |1
is obsolete| |
--- Comment #6 from Marcel de Rooy ---
Created attachment 64797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64797&action=edit
Bug 18755: Allow empty passwords in Patron Info to return OK
With this patch a parameter 'allow_empty_passwords="1" can be added to a
login in the SIP configuration file to allow the behaviour as was normal
before the patch for bug 16610 was applied. Some sip clients rely on
this behaviour sending an empty password field when they wish to
validate to user but do not have the password.
If a password is supplied it will be validated
A test has been added to Message.t to confirm this behaviour
Signed-off-by: Mark Tompsett
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:28 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:12:28 +0000
Subject: [Koha-bugs] [Bug 8016] Items are not tie to the transaction using
"global" action.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8016
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
--- Comment #3 from Kyle M Hall ---
Chris, can you file a separate bug for your report? I sounds like a related but
separate issue to me.
As for the initial issue of not having the relationship between fees and
payments stored, I do believe Bug 14826 will solve the underlying problem, and
one it is pushed we can work on revealing this data in the interface.
(In reply to Chris Slone from comment #2)
> Hi,
>
> This is still an issue and is in need of fixing as it presents a potentially
> more severe problem when paying the replacement charge for an item if the
> item is still checked-out to the patron. So, for example, if your cronjob is
> set to mark an item lost and you charge patron's for lost items, using
> anything other than the 'pay' button will not remove the item from the
> patron's checkouts after the charge has been paid.
>
> To replicate:
>
> 1.) Set preference WhenLostChargeReplacementFee to 'Charge'
> 2.) Edit the record of a checked-out item to the lost status indicated by
> your DefaultLongOverdueChargeValue. Note: To keep the item checked-out, this
> must be done by opening and editing the item's record (not directly from the
> items tab of the bibliographic record). You can also use an item that your
> longoverdue cronjob marked.
> 3.) Confirm that the item is still checked-out to the patron and that the
> replacement fee was charged.
> 4.) Use pay selected, pay amount, write off, or write off all with the
> replacement charge and confirm the action as normal.
> 5.) The charge will be removed but the item will still be checked-out to the
> patron's record.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:12:52 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:12:52 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:13:27 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:13:27 +0000
Subject: [Koha-bugs] [Bug 18755] Allow empty password fields in Patron Info
requests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18755
--- Comment #7 from Marcel de Rooy ---
(In reply to Colin Campbell from comment #5)
> (In reply to Marcel de Rooy from comment #4)
> Patron status is a bit odd the CQ is like patron info in being an optional
> field, but unlike patron info the AD password field is a required field so I
> assume that a missing AD should provoke an invalid password in return.
> basically the behaviour has remained unchanged. In practice I cant recall
> seeing any kind of unit that uses patron status, I think when sip 2 was
> released patron info effectively superceded it. So I think we should leave
> functionality as is, just in case anything relies on the current behaviour.
> ( I tested on a very old sip software before any of the patches affecting
> patron info to confirm that behaviour hadnt been inadvertantly changed by
> other patches)
Clear enough. Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:54:13 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:54:13 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Philippe Audet-Fortin changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--- Comment #54 from Philippe Audet-Fortin ---
I corrected my old mistake (hope it doesn't affect the rest of the code :)) and
rebase it. Now the patch apply.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 5 13:55:24 2017
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 05 Jul 2017 11:55:24 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #55 from Philippe Audet-Fortin ---
Comment on attachment 64793
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64793
Cam 722: Permet a n'importe quelle categorie d'avoir un garant (bz12446)
>From 0ca1ba90904daea5fac5285799b38f8dfb0b6265 Mon Sep 17 00:00:00 2001
>From: Paudet
>Date: Tue, 4 Jul 2017 16:41:04 -0400
>Subject: [PATCH] Cam 722: Permet a n'importe quelle categorie d'avoir un
> garant (bz12446)
>
>Il s'agit du code du bz 12446 collapse en un commit.
>---
> C4/Members/Attributes.pm | 19 ++++++++++++-
> C4/Utils/DataTables/Members.pm | 24 +++++++++++-----
> Koha/Schema/Result/Category.pm | 8 ++++++
> admin/categories.pl | 3 ++
> .../atomicupdate/bug_12446-EnableAdultGarantee.sql | 11 ++++++++
> installer/data/mysql/kohastructure.sql | 3 +-
> installer/data/mysql/sysprefs.sql | 4 ++-
> .../prog/en/modules/admin/categories.tt | 15 ++++++++++
> .../prog/en/modules/admin/preferences/patrons.pref | 5 ++++
> .../prog/en/modules/common/patron_search.tt | 7 +++--
> .../prog/en/modules/members/memberentrygen.tt | 6 ++--
> .../prog/en/modules/members/moremember.tt | 30 ++++++++++++--------
> .../en/modules/members/tables/guarantor_search.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/members.js | 18 ++++--------
> members/memberentry.pl | 20 +++++++------
> members/moremember.pl | 33 ++++++++++++++++++++--
> svc/members/search | 2 ++
> 17 files changed, 156 insertions(+), 54 deletions(-)
> create mode 100644 installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql
>
>diff --git a/C4/Members/Attributes.pm b/C4/Members/Attributes.pm
>index ab43a7c..2f3bd49 100644
>--- a/C4/Members/Attributes.pm
>+++ b/C4/Members/Attributes.pm
>@@ -32,7 +32,7 @@ BEGIN {
> @EXPORT_OK = qw(GetBorrowerAttributes GetBorrowerAttributeValue CheckUniqueness SetBorrowerAttributes
> DeleteBorrowerAttribute UpdateBorrowerAttribute
> extended_attributes_code_value_arrayref extended_attributes_merge
>- SearchIdMatchingAttribute);
>+ SearchIdMatchingAttribute get_guarantor_shared_attributes);
> %EXPORT_TAGS = ( all => \@EXPORT_OK );
> }
>
>@@ -383,6 +383,23 @@ sub _sort_by_code {
> return $x->{code} cmp $y->{code} || $x->{value} cmp $y->{value};
> }
>
>+=head2 get_guarantor_shared_attributes
>+
>+ $guarantor_attributes = get_guarantor_attributes();
>+
>+ returns an array reference containing attributes to be shared between guarantor and guarantee.
>+
>+=cut
>+
>+sub get_guarantor_shared_attributes{
>+ my @attributes = qw( streetnumber address address2 city state zipcode country branchcode phone phonepro mobile email emailpro fax );
>+ if( my @additional = split(/\|/, C4::Context->preference("AdditionalGuarantorField")) ){
>+ $_ =~ s/(?:^\s+)|(?:\s+$)//g for (@additional); # Trim whitespaces
>+ @attributes = ( @attributes, @additional);
>+ }
>+ return \@attributes;
>+}
>+
> =head1 AUTHOR
>
> Koha Development Team
>diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm
>index 302eaff..846bcb3 100644
>--- a/C4/Utils/DataTables/Members.pm
>+++ b/C4/Utils/DataTables/Members.pm
>@@ -2,6 +2,8 @@ package C4::Utils::DataTables::Members;
>
> use Modern::Perl;
> use C4::Context;
>+use C4::Members;
>+use C4::Members::Attributes qw/get_guarantor_shared_attributes/;
> use C4::Utils::DataTables;
> use Koha::DateUtils;
>
>@@ -47,13 +49,21 @@ sub search {
>
> }
>
>- my $select = "SELECT
>- borrowers.borrowernumber, borrowers.surname, borrowers.firstname,
>- borrowers.streetnumber, borrowers.streettype, borrowers.address,
>- borrowers.address2, borrowers.city, borrowers.state, borrowers.zipcode,
>- borrowers.country, cardnumber, borrowers.dateexpiry,
>- borrowers.borrowernotes, borrowers.branchcode, borrowers.email,
>- borrowers.userid, borrowers.dateofbirth, borrowers.categorycode,
>+ $dbh = C4::Context->dbh;
>+ my @columns = qw( borrowernumber surname firstname streetnumber streettype address address2 city state zipcode country cardnumber dateexpiry borrowernotes branchcode email userid dateofbirth categorycode );
>+ if( my @guarantor_attributes = @{ get_guarantor_shared_attributes() }){
>+ foreach my $item (@guarantor_attributes) {
>+ if (! grep {$_ eq $item} @columns) {
>+ push @columns, $item;
>+ }
>+ }
>+ };
>+ my $borrowers_columns = "";
>+ foreach my $item (@columns) {
>+ $borrowers_columns .= "borrowers." . $item . ", ";
>+ }
>+
>+ my $select = "SELECT " . $borrowers_columns . "
> categories.description AS category_description, categories.category_type,
> branches.branchname";
> my $from = "FROM borrowers
>diff --git a/Koha/Schema/Result/Category.pm b/Koha/Schema/Result/Category.pm
>index fc26a7d..f655fd9 100644
>--- a/Koha/Schema/Result/Category.pm
>+++ b/Koha/Schema/Result/Category.pm
>@@ -109,6 +109,12 @@ __PACKAGE__->table("categories");
> default_value: -1
> is_nullable: 0
>
>+=head2 canbeguarantee
>+
>+ data_type: 'tinyint'
>+ default_value: 0
>+ is_nullable: 0
>+
> =head2 default_privacy
>
> data_type: 'enum'
>@@ -161,6 +167,8 @@ __PACKAGE__->add_columns(
> default_value => -1,
> is_nullable => 0,
> },
>+ "canbeguarantee",
>+ { data_type => "tinyint", default_value => 0, is_nullable => 0},
> "default_privacy",
> {
> data_type => "enum",
>diff --git a/admin/categories.pl b/admin/categories.pl
>index 358ef7d..dbaaf48 100755
>--- a/admin/categories.pl
>+++ b/admin/categories.pl
>@@ -93,6 +93,7 @@ elsif ( $op eq 'add_validate' ) {
> my $checkPrevCheckout = $input->param('checkprevcheckout');
> my $default_privacy = $input->param('default_privacy');
> my @branches = grep { $_ ne q{} } $input->multi_param('branches');
>+ my $canbeguarantee = $input->param('canbeguarantee');
>
> my $is_a_modif = $input->param("is_a_modif");
>
>@@ -119,6 +120,7 @@ elsif ( $op eq 'add_validate' ) {
> $category->hidelostitems($hidelostitems);
> $category->overduenoticerequired($overduenoticerequired);
> $category->category_type($category_type);
>+ $category->canbeguarantee($canbeguarantee);
> $category->BlockExpiredPatronOpacActions($BlockExpiredPatronOpacActions);
> $category->checkprevcheckout($checkPrevCheckout);
> $category->default_privacy($default_privacy);
>@@ -145,6 +147,7 @@ elsif ( $op eq 'add_validate' ) {
> hidelostitems => $hidelostitems,
> overduenoticerequired => $overduenoticerequired,
> category_type => $category_type,
>+ canbeguarantee => $canbeguarantee,
> BlockExpiredPatronOpacActions => $BlockExpiredPatronOpacActions,
> checkprevcheckout => $checkPrevCheckout,
> default_privacy => $default_privacy,
>diff --git a/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql b/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql
>new file mode 100644
>index 0000000..56462a7
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql
>@@ -0,0 +1,11 @@
>+-- ******** --
>+-- SYSPREFS --
>+-- ******** --
>+INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` )
>+VALUES ('AdditionalGuarantorField','',NULL,'Additional fields name to be transfer from guarantor to guarantee.','free');
>+
>+-- ********* --
>+-- STRUCTURE --
>+-- ********* --
>+ALTER TABLE categories ADD COLUMN `canbeguarantee` tinyint(1) NOT NULL default '0';
>+UPDATE categories SET canbeguarantee = 1 WHERE category_type = 'P' OR category_type = 'C';
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index e9c60aa..7e3bc48 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -331,8 +331,9 @@ CREATE TABLE `categories` ( -- this table shows information related to Koha patr
> `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no)
> `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff)
> `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this category can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BlockExpiredPatronOpacActions
>- `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category
>+ `default_privacy` ENUM( 'default', 'never', 'forever' ) NOT NULL DEFAULT 'default', -- Default privacy setting for this patron category,
> `checkprevcheckout` varchar(7) NOT NULL default 'inherit', -- produce a warning for this patron category if this item has previously been checked out to this patron if 'yes', not if 'no', defer to syspref setting if 'inherit'.
>+ `canbeguarantee` tinyint(1) NOT NULL default '0'
> PRIMARY KEY (`categorycode`),
> UNIQUE KEY `categorycode` (`categorycode`)
> ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 0bd8cac..27173df 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -6,7 +6,9 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('AcquisitionDetails', '1', '', 'Hide/Show acquisition details on the biblio detail page.', 'YesNo'),
> ('AcqViewBaskets','user','user|branch|all','Define which baskets a user is allowed to view: his own only, any within his branch or all','Choice'),
> ('AcqWarnOnDuplicateInvoice','0','','Warn librarians when they try to create a duplicate invoice','YesNo'),
>-('AddressFormat','us','us|de|fr','Choose format to display postal addresses', 'Choice'),
>+('AdditionalGuarantorField','',NULL,'Additional fields name to be transfer from guarantor to guarantee.','free'),
>+('AddPatronLists','categorycode','categorycode|category_type','Allow user to choose what list to pick up from when adding patrons','Choice'),
>+('AddressFormat','us','','Choose format to display postal addresses', 'Choice'),
> ('advancedMARCeditor','0','','If ON, the MARC editor won\'t display field/subfield descriptions','YesNo'),
> ('AdvancedSearchLanguages','','','ISO 639-2 codes of languages you wish to see appear as an Advanced search option. Example: eng|fre|ita','Textarea'),
> ('AdvancedSearchTypes','itemtypes','itemtypes|ccode','Select which set of fields comprise the Type limit in the advanced search','Choice'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>index e33b36f..b115aa4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>@@ -151,6 +151,18 @@
>
> Required
>
>+