[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 64197
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64197
Bug 18785: Add Koha::Subscription::biblio

Review of attachment 64197:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18785&attachment=64197)
-----------------------------------------------------------------

::: Koha/Subscription.pm
@@ +44,5 @@
> +
> +sub biblio {
> +    my ($self) = @_;
> +
> +    return Koha::Biblios->find($self->biblionumber);

There are a bunch of other bugzilla issues related to ->find and a scalar
context.
Perhapts actually using ->find({ biblionumber => $self->biblionumber }); or
I think others get lazy ->find( scalar $self->biblionumber )... or was it
return scalar Koha::Biblios->find($self->biblionumber);
Hmmm... anyways, this isn't right, as far as I can tell.
Plus if it is singular, then why Biblios? This is the part I don't understand
in this and other code.

-- 
You are receiving this mail because:
You are watching all bug changes.