[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #4 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Created attachment 64768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64768&action=edit
Bug 18743 - Removed library filter in Acquisition suggestions when
IndependentBranches enabled

Also ensured that when a superlibrarian is logged in then suggestions from
all branches are displayed with IndependentBranches being either on or off, as
this
syspref does not affect what suggestions superlibrarians can see.

But when non-superlibrarian user with access to the acquisitions module
visits it when IndependentBranches is enabled then only suggestions of
the branch they are logged in with are displayed.

If non-superlibrarian users log in when IndependentBranches is not
enabled then suggestions from all branches are displayed.

Note: The library filter in the 'Organize by' area (which is displayed when
multiple branches suggestions are displayed according to the aforementioned
logic) successfully splits the suggestions into different tabs with the correct
number of suggestions for each branch
displayed in each tab.

Test plan:
1. Relicate the bug described in description comment

2. Apply patch

3. Create 2 suggestions a library branch (which I will refer to in this
test plan as branch A)

4. Create 1 suggestion for a different branch (which I will refer to as
branch B)

5. Log into staff client as superlibrarian with either branch and ensure the
IndependentBranches syspref is set to 'yes'

6. Go to Acquisitions->Suggestions Management

7. Notice that suggestions from branch A and B are displayed

8. In the Organize by are click to filter by library and click go

9. Notice that one tab says <name of branch A> (2) whilst the other tab
says <name of branch B> (1) with each tab containing the relevant
suggestions to that branch

10. In the Acquisition information filter select branch A and then click
'Go' and notice that it successfully filters the results and shows 2
suggestions of branch A only

11. Now change the IndependentBranches syspref to 'no'

12. Repeat steps 6, 7, 8, 9, 10 noticing the same outcome in step 9 and
10

13. Log out and log back into staff client in branch A as a non-superlibrarian
user
who has access to the Acquisitions module

14. Currently IndependentBranches is set to 'no' so go to
Acquisitions->Suggestions Management

15. Repeat steps 6, 7, 8, 9, 10 and notice the same outcome as step 9
and 10

16. Change IndependentBranches to 'yes'

17. Go to Acquisitions->Suggestions Management

18. Notice that only suggestions from branch A (the branch you are
logged in with) are displayed. This is because when IndependentBranches
is enabled non-superlibrarians do not need to see suggestions from other
branches

19. Also notice that there is no 'library' option in the 'Organized by'
area and there is no library filter in the acquisition information area. This
is because only suggestions from the current branch are displayed and so
organizing/filtering by library is redundant.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.