[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |tomascohen at gmail.com

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Hi everyone here. I tested this with some credentials Nick gave me. I have a
couple observations about this one.

Important
=========

- I first tested opac-oneclick-search.pl using the q= query param. That way I
found stuff in Oneclick. The searched on the main opac search for a term I knew
should give results (q=1776), and I got (the first time) "Error searching
OneClickDigital collection: Not Found". I then reloaded the results page, and
got "Found 1 results in OneClickDigital collection". This one seemed ok
- When clicking in the '1 results' link, I got a red message "Error searching
OneClickDigital collection: Not Found", on reloading, I got the search results
for 1776.

=> FAIL: It seems there's a problem on the first query, or a throttling stuff
getting in the middle.

Moderate
========

=> FAIL: The search results on opac-oneclick-search.pl have a different styling
than Koha's search results. They look nicer, but I think the same XSLT's shold
be used.

I understood that this is a transition until this search results are displayed
inline along with the regular (local) search results. I wouldn't say the second
item is a blocker, but it might be a reason for others to vote against its
inclusion.

Minor
=====

- Another (minor) thing I would consider changing is the wording for the
sysprefs description. I think they should clearly match what Oneclick provides
the user to configure Koha (LibraryID vs. library #)

- Warnings are logged:
Use of uninitialized value in concatenation (.) or string at
/usr/local/share/perl/5.20.2/WebService/ILS/OneClickDigital/PartnerPatron.pm
line 58.
Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/Koha/ExternalContent/OneClickDigital.pm line 73.

QA scripts
==========
The QA scripts complain about oneclick-checkout.inc
=>
 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/oneclick-checkout.inc
   FAIL   forbidden patterns
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 1)

-- 
You are receiving this mail because:
You are watching all bug changes.