[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref / colliding translated preference sections

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64414|0                           |1
        is obsolete|                            |

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 64843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64843&action=edit
Bug 18634: Handle colliding translation for preference sections

Problem on this report was caused by translating the tabs Privacy
and Payments by the same string. This caused overwriting a hash entry.

This patch tests if the key already exists and if so, it merges the
entries instead of overwriting the old contents.

Test plan:
[1] Make sure that e.g. Privacy and Payments translate to e.g Vie privee.
[2] Run translate install fr-CA (or the language you altered)
[3] Without this patch you should loose preferences from either Privacy or
    Payments. With this patch, they should be merged.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with fr-CA.

Signed-off-by: Blou <philippe.blouin at inlibro.com>
Reset the .po files, reproduced the problem.  Applied the patch and suddenly
'paypal' appeared.

-- 
You are receiving this mail because:
You are watching all bug changes.