[Koha-bugs] [Bug 16304] Koha::Logger, lazy load loggers so environment has time to get set

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304

Lari Taskula <lari.taskula at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50449|0                           |1
        is obsolete|                            |

--- Comment #3 from Lari Taskula <lari.taskula at jns.fi> ---
Created attachment 64845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64845&action=edit
Bug 16304 - Koha::Logger, lazy load loggers so environment has time to get set

If you instantiate Koha::Loggers before having set the C4::Context->interface,
their interface defaults to 'opac'.

This is rather undesired especially for 'commandline' scripts such as cronjobs.

A solution to this is to lazyLoad loggers when they are really needed.
LazyLoading might also have a performance boost when using packages that
initialize a package-level logger but which never gets used.

see t/Koha/Logger.t on how to replicate this issue, but here is a nutshell
of how to replicate this issue:

@@ file A.pm
package A;

use Koha::Logger;
my $logger = Koha::Logger->get({category => __PACKAGE__}); #interface unknown

sub doStuff {
    $logger->error('My interface is always "opac"');
}

@@ script run.pl
use C4::Context;
C4::Context->interface('commandline');

use A;
A::doStuff(); #error is logged using the "opac"-interface instead
              #of the "commandline"-interface

-- 
You are receiving this mail because:
You are watching all bug changes.