[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64719|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 64862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64862&action=edit
Bug 18880: Regression breaks local authentication fallback for all external
authentications

A regression in commit cfc484b17 / bug #18314 breaks the local
authentication fallback for all external authentications like LDAP, CAS
and Shibboleth. The severity is critical for us as we, while using LDAP
authentication, use the self-service checkout which requires a local
user account. Also non-LDAP staff can't log into the staff pages
anymore.

The regression itself is a logical error as "@return = (0)" is
considered to be "false" when checked with "unless". That's wrong as
"unless" tests the number of elements in a list. Thus the "falsy"
condition has to established with "@return = ()" instead.

Please find attached a proposed patch against "17.05.x". Also, please
make sure the fallback workflow gets test coverage.

-- 
You are receiving this mail because:
You are watching all bug changes.