[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Lee Jamison <ldjamison at marywood.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64877|0                           |1
        is obsolete|                            |

--- Comment #12 from Lee Jamison <ldjamison at marywood.edu> ---
Created attachment 64909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64909&action=edit
Bug 18880: Regression breaks local authentication fallback for all external
authentications

A regression in commit cfc484b17 / bug #18314 breaks the local
authentication fallback for all external authentications like LDAP, CAS
and Shibboleth.

The regression itself is a logical error as "@return = (0)" is
considered to be "false" when checked with "unless" (line 1814). That's
wrong as "unless" tests the number of elements in a list. Thus the
"falsy" condition has to established with "@return = ()" instead.

Signed-off-by: Lee Jamison <ldjamison at marywood.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.