[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

--- Comment #17 from Oliver Bock <oliver.bock at aei.mpg.de> ---
> Both approaches are not bug free.

What's buggy with my approach itself? The overall context notwithstanding,
though.

> Although we already know that we should return false, we are going to call checkpw_internal now since @return is empty! We should not.

Why not? Isn't checkpw_internal meant as a fallback for the external auths?
Jonathan seemed to have this in mind.

> So when @return was (0), return @return did not return a 0 but did return a 1 in scalar context !!

That's precisely my point, hence my fix.

Anyhow, I can't judge the overall implementation, I just fixed an obvious bug
which the original author already agreed on. If there's a general issue besides
the obvious bug I reported shouldn't it be fixed independently?

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.