[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
LDAP behavior should be reverted in the sense of:
-        return 0 if $retval == -1;                                  #
Incorrect password for LDAP login attempt
-        ($retval) and return ( $retval, $retcard, $retuserid );
-    }
Your patch falls back to internal for -1; it should NOT do that.
Internal fallback should be enabled only if retval == 0.

I am also wondering btw if (internal) patron lockout should overrule external
authentification like cas and shibboleth. If not, the code could be simpler.
Just noting that this discussion was not touched on bug 18314. From this
perspective you could even argue about allowing LDAP fallback.
Adding Martin and Tomas in CC for any feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.