[Koha-bugs] [Bug 18966] Move of checkouts - Deal with duplicate IDs at DBMS level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18966

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com
             Blocks|                            |18996

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #24)
> (In reply to Fridolin SOMERS from comment #23)
> > Just, we may use this error message in SIP serveur :
> > C4/SIP/ILS/Transaction/Checkin.pm ?
> 
> What do you mean?
> I do not think we should display a specific message in this case.

It seems that we still have a problem here.
If I check in an item where the issue id is already in old issues (I inserted
this id for testing purposes), AddReturn correctly gives me back me a zero
status and DataCorrupted message.
However, SIP somehow ignores it. It returns a 10 with ok=1 while it should
return a 10 with ok=0.
The problem is in ILS.pm line 219
    $circ->ok( ( $checked_in_ok && $item ) || ( $item && $item->{patron} ) );
In this specific case $circ->ok was already set to false in do_checkin just
before that line. But now this line sets ok back to true.
I guess this is a more fundamental problem. Because if AddReturn did set the ok
flag to false for another reason, the same could happen. So I would propose to
solve it on another report.
I am not fully sure if we can just test if $circ->ok is still true before
running this line 219, and leave it false when it is false. 
@Colin: Could you have a look too ?

Opened bug 18996 for this *issue*.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996
[Bug 18996] SIP sets ok flag to true for refused checkin for data corruption
-- 
You are receiving this mail because:
You are watching all bug changes.