[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #62 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #61)
> Created attachment 65302 [details] [review]
> Bug 17680: [QA Follow-up] dt_from_string failing silently
> 
> This is a trivial fix, but finding the cause for a failing checkin in
> SIPServer surely was not.
> Without this simple change, I could not checkin an item while the SIP server
> just closed the connection and syslog contained nothing useful.
> 
> The error can be easily reproduced without this patch by:
>     use Modern::Perl;
>     use C4::SIP::ILS::Item;
>     my $item = C4::SIP::ILS::Item->new('some_barcode');
> where some_barcode should refer to an item checked out.
> You should trigger the error (with your due date):
>     2017-07-28 23:59:00 is not an object at line 3.
> 
> Why the ILS/Item.pm module still compiles without a warning, is not clear
> though.
> 
> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Nice find - these are painful to locate. Suspect that the reason there is no
compile time warning is because ILS::Item is using autoloading so that the
routine gets resolved at runtime.

-- 
You are receiving this mail because:
You are watching all bug changes.