[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #32 from M. Tompsett <mtompset at hotmail.com> ---
Good progress. Just need to finalize testing the C4/Search.pm changes.
Here is the test plan thus far.

prove -v t/db_dependent/Items.t
C4::Biblio changes (EmbedItemsInMarcBiblio) tested
C4::Items changes (GetHiddentItemnumbers) tested
the Items.t is tested itself too.

perldoc C4::Items
/PERLDOC
-- finds changes

installer/data/mysql/atomicupdate/bug_14385-add_OpacHiddenItemsExceptions_syspref.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
-- run an upgrade
-- log in to staff client
-- home -> koha administration -> global system preferences -> opac
-- should be an added OpacHiddenItemsExceptions under OpacHiddenItems
   in the Policy section.
-- should be able to save various values.

installer/data/mysql/sysprefs.sql
-- drop the db
-- create the db
-- fresh install
-- log in to staff client
-- home -> koha administration -> global system preferences -> opac
-- should be an added OpacHiddenItemsExceptions under OpacHiddenItems
   in the Policy section.
-- should be able to save various values.

opac/opac-search.pl
-- set the OpacHiddenItems to "itype: [BK]"
-- set the OpacHiddenItemsExceptions to "S"
-- make sure to catalogue at least two books, since you dropped everything.
-- Adding from Z39.50 is easiest.
-- do a full reindex
-- in the OPAC, search for "itype:BK"
-- there should be nothing found.
-- log in as the superlibrarian (which you probably set to S for staff)
-- in the OPAC, search for "itype:BK"
-- there should be two entries
-- change OpacHiddenItemsExceptions to "PT"
   (because your superlibrarian is probably S and not PT)
-- in the OPAC, search for "itype:BK"
-- there should be nothing found.

opac/opac-detail.pl
-- As you know there are two books, try a direct URL:
   {OPACBaseURL}/opac-detail.pl?biblionumber=1
-- it should return a 404 page
-- change OpacHiddenItemsExceptions back to "S"
-- try the direct URL again.
-- it should show up.

opac/opac-MARCdetail.pl
-- change the OpacHiddenItemsExceptions back to "PT"
-- try a direct URL:
   {OPACBaseURL}/opac-MARCdetail.pl?biblionumber=1
-- it should return a 404 page
-- change OpacHiddenItemsExceptions back to "S"
-- try the direct URL again.
-- it should show up.

opac/opac-ISBDdetail.pl
-- change the OpacHiddenItemsExceptions back to "PT"
-- try a direct URL:
   {OPACBaseURL}/opac-ISBDdetail.pl?biblionumber=1
-- it should return a 404 page
-- change OpacHiddenItemsExceptions back to "S"
-- try the direct URL again.
-- it should show up.

prove -v t/db_dependent/Search.t
the Search.t itself is proved.

catalogue/search.pl
-- Log in to the staff client
-- search for "itype:BK"
-- two results
-- change OpacHiddenItemsExceptions and OpacHiddenItems as desired
-- two results all the time, because this is the staff client!

cataloguing/addbooks.pl
-- Make sure you have records in the cataloguing reservoir
   This is done by staging at least one MARC record.
-- In the staff client, home -> Cataloguing -> Cataloguing search
-- Search for something that will find some records in the reservoir
-- Make sure results are expected regardless of hidden item
   system preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.