From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 01:12:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 23:12:51 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 01:34:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 31 May 2017 23:34:02 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 05:29:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 03:29:40 +0000 Subject: [Koha-bugs] [Bug 18712] New: Run database_dependent test suite --No ignored Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712 Bug ID: 18712 Summary: Run database_dependent test suite --No ignored Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org Created attachment 63893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63893&action=edit Full log of 'make test' including STDERR and STDOUT Build Koha from the tarball. Answer no to 'run the database-dependent test suite (no, yes) no. Running 'make test' generates many errors trying to access the database. Most of the tests which do generate DBD::mysql::st errors still show up as 'ok'. See the attached log. t/Matcher.t and t/Prices.t do fail Test Summary Report ------------------- t/Matcher.t (Wstat: 768 Tests: 12 Failed: 3) Failed tests: 3-5 Non-zero exit status: 3 t/Prices.t (Wstat: 65280 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 255 Parse errors: Bad plan. You planned 16 tests but ran 5. Files=100, Tests=11528, 95 wallclock secs ( 0.89 usr 0.16 sys + 81.23 cusr 3.06 csys = 85.34 CPU) Result: FAIL Failed 2/100 test programs. 4/11528 subtests failed. Makefile:9572: recipe for target 'test_dynamic' failed make: *** [test_dynamic] Error 255 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 05:29:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 03:29:49 +0000 Subject: [Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 05:30:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 03:30:37 +0000 Subject: [Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 06:28:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 04:28:24 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- +1 Just some questions and ideas: Will the display of new features go to a separate tab on the About page? Will it be translatable? For the (new) system preferences: Will they have a separate tab on the About page as well? Or, as an alternative, will they somehow be highlighted on Home > Administration > System preferences? Maybe have the version number as a search criterium (or a filter) for the (new or changed) system preferences? We could have a new column 'version' in the table 'systempreferences' and include it to the search. Then you could have a link like: .../cgi-bin/koha/admin/preferences.pl?op=search&searchfield=17.05 to display all sysprefs related to this version, and they would appear in the installed languages as appropriate. To announce the new version in staff client: What about creating a 'News' item that appears for all libraries? Such a news item could contain a standard text with the release number, and links to the new features and preferences. Library staff then could edit it, e.g. adding some library specific information ("Please report issues to...") The creaton of such news item could take place at the end of the installation process. The text used would be the translated one for the language chosen at the start of the installation porcess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 06:36:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 04:36:49 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- Whoa, good ideas, but quite a bit of scope creep. :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 06:49:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 04:49:32 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 06:52:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 04:52:36 +0000 Subject: [Koha-bugs] [Bug 14302] Remove GRS1 indexing related code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14302 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 07:01:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 05:01:38 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 --- Comment #3 from Alex Buckley --- Hi Marc Thanks very much for your feedback/ideas I like the ideas, I am thinking it would be good to put them in a separate bug report, just so there isn't too much in a single bug report because having done the onboarding tool I found that the bigger the patch the longer it takes to get through QA and it would be good to get both this enhancement and the recommendation enhancement pushed for the Koha 17.11 release :) For this patch I was planning to have the new sysprefs, links to release notes (and Koha manual where applicable) to be displayed on a new page after the user logs in following an update. So it is available to admins immediately after upgrade. I can write up a bug report for your ideas to depend on this bug report now if you'd like -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 07:50:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 05:50:08 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #7 from David Cook --- (In reply to Magnus Enger from comment #6) > At least the Fuseki triplestore has different endpoints for reading and > writing data. With Fuseki as the triplestore, this bug only adds a read > RDF::Trine::Model object. Would it be possible to do a followup that would > aloow us to create both read and write objects? (As two separate objects.) Hi Magnus, I'm not sure why you think it adds a read-only object. I can 100% assure you that the RDF::Trine::Model object is both read and write. The URL you provide is to the dataset (e.g. http://semantikoha.libriotech.no:3030/david-koha-test). >From there, RDF::Trine::Model will build the "update" and "query" URLs dynamically for reading and writing using the SPARQL 1.1 standard. (In fact, this is why RDF::Trine doesn't work with older versions of Virtuoso, since Virtuoso before 6.1.7 or so didn't comply with SPARQL 1.1.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 07:59:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 05:59:49 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #8 from David Cook --- (In reply to David Cook from comment #7) > (In reply to Magnus Enger from comment #6) > > At least the Fuseki triplestore has different endpoints for reading and > > writing data. With Fuseki as the triplestore, this bug only adds a read > > RDF::Trine::Model object. Would it be possible to do a followup that would > > aloow us to create both read and write objects? (As two separate objects.) > > Hi Magnus, > > I'm not sure why you think it adds a read-only object. I can 100% assure you > that the RDF::Trine::Model object is both read and write. The URL you > provide is to the dataset (e.g. > http://semantikoha.libriotech.no:3030/david-koha-test). From there, > RDF::Trine::Model will build the "update" and "query" URLs dynamically for > reading and writing using the SPARQL 1.1 standard. (In fact, this is why > RDF::Trine doesn't work with older versions of Virtuoso, since Virtuoso > before 6.1.7 or so didn't comply with SPARQL 1.1.) Actually, as I read through the code at http://cpansearch.perl.org/src/GWILLIAMS/RDF-Trine-1.016/lib/RDF/Trine/Store/SPARQL.pm, it looks like they don't dynamically change the URL. Rather, they just use the "update" and "query" parameters depending on the operation specified, but it's all using the same URL which as I mentioned above is just to the dataset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:04:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:04:48 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #9 from David Cook --- Looking at https://jena.apache.org/documentation/serving_data/, it looks like "/data" is a read/write endpoint, and after visiting http://semantikoha.libriotech.no:3030/david-koha-test/ and http://semantikoha.libriotech.no:3030/david-koha-test/data, it seems that both map to the same place. In which case... maybe it is worthwhile having separate read and write endpoints in the configuration file... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:05:23 +0000 Subject: [Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |17.05 CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:05:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:05:53 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #10 from David Cook --- However, RDF::Trine::Store::Memory is read/write and I imagine RDF::Trine::Store::DBI is as well. Maybe worth looking at a few triplestores to see what the norm is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:08:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:08:44 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #11 from David Cook --- Virtuoso still seems to have the wrong parameters but looks like it has a read/write endpoint (https://virtuoso.openlinksw.com/dataspace/doc/dav/wiki/Main/VOSSparqlProtocol#HTTP Request Methods). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:09:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:09:10 +0000 Subject: [Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712 --- Comment #1 from Mason James --- > t/Matcher.t and t/Prices.t do fail > > Test Summary Report > ------------------- > t/Matcher.t (Wstat: 768 Tests: 12 Failed: 3) > Failed tests: 3-5 > Non-zero exit status: 3 > t/Prices.t (Wstat: 65280 Tests: 5 Failed: 1) > Failed test: 5 > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 16 tests but ran 5. > Files=100, Tests=11528, 95 wallclock secs ( 0.89 usr 0.16 sys + 81.23 cusr > 3.06 csys = 85.34 CPU) > Result: FAIL > Failed 2/100 test programs. 4/11528 subtests failed. > Makefile:9572: recipe for target 'test_dynamic' failed > make: *** [test_dynamic] Error 255 the Prices.t test does seem to be currently failing on jenkins.. https://jenkins.koha-community.org/job/Koha_Master_U16/lastBuild/consoleText Build #171 (31-May-2017 02:11:06) # Failed test 'No tests run for subtest "Configuration 1: 0 0"' # at t/Prices.t line 155. Can't call method "listincgst" on an undefined value at /srv/jenkins/workspace/Koha_Master_U16/C4/Acquisition.pm line 2883. # Looks like your test exited with 255 just after 5. [23:35:52] t/Prices.t ................................................ Dubious, test returned 255 (wstat 65280, 0xff00) Failed 12/16 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:14:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:14:28 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #12 from David Cook --- More info about Virtuoso even though we can't use it anyway with RDF::Trine (https://virtuoso.openlinksw.com/dataspace/doc/dav/wiki/Main/VirtTipsAndTricksGuideSPARQLEndpoints). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:28:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:28:11 +0000 Subject: [Koha-bugs] [Bug 18713] New: Add support for named graphs and rfds:seeAlso to Koha:: RDF Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Bug ID: 18713 Summary: Add support for named graphs and rfds:seeAlso to Koha::RDF Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When I download RDFXML via OAI-PMH, I delete existing named graphs and create new named graphs. This functionality isn't specific to OAI-PMH, so I'm putting it in Koha::RDF. There is also a method for adding rdfs:seeAlso to a $subject and an $object. In my case, I'm linking a Koha record to an imported record. It's a generic relationship though, which will be useful in many other scenarios, so it's going in Koha::RDF too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:28:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:28:29 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10787, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18586 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:28:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:28:29 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18713 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:28:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:28:29 +0000 Subject: [Koha-bugs] [Bug 10787] Linked Data/RDF Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10787 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18713 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:28:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:28:41 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 [Bug 18586] Create module to mint RDF subject URIs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:28:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:28:41 +0000 Subject: [Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:48:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:48:50 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 08:48:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 06:48:53 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #1 from David Cook --- Created attachment 63894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63894&action=edit Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF This patch adds methods to Koha::RDF that creates or deletes a named graph by removing/adding RDF quads from/to a triplestore. This patch also can create a rdfs:seeAlso relationship between two RDF entities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:04:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 07:04:50 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:09:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 07:09:17 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #13 from Magnus Enger --- Thanks for clarifying, David! I think the problem was that I put http://example.com/david-koha-test/query in the config, and that made the object read only. On the other hand, having separate read and read/write objects could perhaps make some sense, like using the read only object when you know you are only going to display data, like in the OPAC. (Especially for my librarian-configurable queries, to protect against people doing stupid/evil things :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:32:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 07:32:43 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 09:44:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 07:44:24 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #2 from David Cook --- Working on unit tests now but have found a bug in RDF::Trine::Store::SPARQL so will have to do a workaround tomorrow for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 10:19:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 08:19:33 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 --- Comment #4 from Marc V?ron --- (In reply to Alex Buckley from comment #3) > Hi Marc > > Thanks very much for your feedback/ideas I like the ideas, I am thinking it > would be good to put them in a separate bug report, just so there isn't too > much in a single bug report because having done the onboarding tool I found > that the bigger the patch the longer it takes to get through QA and it would > be good to get both this enhancement and the recommendation enhancement > pushed for the Koha 17.11 release :) > > For this patch I was planning to have the new sysprefs, links to release > notes (and Koha manual where applicable) to be displayed on a new page after > the user logs in following an update. So it is available to admins > immediately after upgrade. > > I can write up a bug report for your ideas to depend on this bug report now > if you'd like Hi Alex and Liz Thanks for the comments. I agree that my suggestions would be out of scope of your initial intentions for this bug. If you have time to put the suggestions in a new bug report - please go ahead. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 12:01:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 10:01:18 +0000 Subject: [Koha-bugs] [Bug 1887] Managing Suggestions - hold books for patron who requested In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1887 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 13:56:29 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 11:56:29 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 13:56:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 11:56:32 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63878|0 |1 is obsolete| | --- Comment #34 from Lari Taskula --- Created attachment 63895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63895&action=edit Bug 17499: (follow-up) Bugfix for validation, 2 Remove duplicate validation for digest availability. This is already checked in $preference->validate(). Set values for current object before validating messaging transport types, not the other way around as it was before this patch. Also prevents a crash when patron has messaging transport type selected for a message for which it should not be available. This patch logs it with as a warning, and only throws an exception when attempting to set it. To test: 1. prove t/db_dependent/Koha/Patron/Message/* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:27:50 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 12:27:50 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63877|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 63896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63896&action=edit Bug 18708 [Revised] Show itemBarcodeFallbackSearch results in a modal window This patch modifies the circulation template so that itemBarcodeFallbackSearch results show in a modal window. To test, enable the itemBarcodeFallbackSearch system preference and open a patron's account in circulation. - Submit a string which will return search results. When the page reloads a modal should display showing a table of title search results. - Test the "Check out" button and confirm that the correct item is submitted. - Test closing the modal and re-displaying it using the new "Show matching titles" button. - Confirm that the "Add record using fast cataloging" button still works correctly. - Submit a string which will return no results. No modal window should display, and only the "Add record" button should appear. - Confirm that normal checkout works correctly. - Test with itemBarcodeFallbackSearch disabled, and with a user who lacks Fast Cataloging permission. Revision removes a heading which was made redundant by the modal markup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:39:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 12:39:44 +0000 Subject: [Koha-bugs] [Bug 18646] Recommendation system for OPAC which integrates with the Mana database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18646 Baptiste changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski at biblibr | |e.com --- Comment #1 from Baptiste --- Hi ! I think this is what I already worked on in Bug 18618 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 14:44:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 12:44:41 +0000 Subject: [Koha-bugs] [Bug 18714] New: tracklinks.pl redirects failing under https Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18714 Bug ID: 18714 Summary: tracklinks.pl redirects failing under https Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When a site is using https the CGI->redirect() command in tracklinks.pl receives a url with "http" but sends the uder via "https" and some links fail To test: 1 - Enable https 2 - Add an url to a record that is accessible only via http 3 - Enable track links system preference 4 - Click the link from the opac 5 - Security failure or timeout (as you are redirected to https -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:02:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 13:02:46 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com Summary|Mana - Add reading |Mana - Add reading |suggestions (crontab - |suggestions (crontab and |scripts) |scripts for Koha) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:06:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 13:06:36 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #3 from Paul Poulain --- FYI: we've setup this cron for one of our customer (a modified version, with hardcoded token). It's harvesting pairs since more than 2 weeks now. We'll add 10 more in the next days. Most of them having about 100 to 1000 issues/day The mana-side code is available here : https://git.biblibre.com/biblibre/koha-mana. It's been deployed already on mana-kb and mana-test.koha-community.org (this has no consequence on existing API. It just add new routes for managing reading suggestions) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 15:07:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 13:07:13 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:11:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 14:11:58 +0000 Subject: [Koha-bugs] [Bug 18434] Elasticsearch indexing broken with newer catmandu version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 16:59:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 14:59:59 +0000 Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131 --- Comment #10 from Julian Maurice --- Comment on attachment 62087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62087 Bug 18131: ES - Fix matching staged records Review of attachment 62087: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18131&attachment=62087) ----------------------------------------------------------------- ::: C4/Matcher.pm @@ +673,5 @@ > + else { > + if ( C4::Context->preference('SearchEngine') eq 'Elasticsearch' ) { > + foreach my $matched ( @{$searchresults} ) { > + my ( $biblionumber_tag, $biblionumber_subfield ) = C4::Biblio::GetMarcFromKohaField( "biblio.biblionumber", $marcframework_used ); > + my $id = $matched->field($biblionumber_tag)->subfield($biblionumber_subfield); This fails on a UNIMARC setup where $biblionumber_tag is 001 (should use ->data()) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:03:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:03:28 +0000 Subject: [Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Also, this is weird that search_result_compat returns different result depending on the search engine. Shouldn't we fix one of Koha::SearchEngine::*::Search::search_result_compat ? Failing QA for comment 10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:10:32 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:10:32 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #6 from Fridolin SOMERS --- Ahhhh, I did not see that the TT vars where different : messaging_preference.transport_sms and messaging_preference.transport[s]_sms I will correct my path. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:30:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:30:21 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:30:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:30:33 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63814|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:31:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:31:03 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #7 from Fridolin SOMERS --- Created attachment 63897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63897&action=edit Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column. Bug 6458 has broken this. The SMS column is missing an else case with cell containing only "-" like other columns. Test plan : - set SMSSendDriver preference empty - go to OPAC patron messaging - column SMS should not be visible - set SMSSendDriver preference not empty - go to OPAC patron messaging - column SMS appears with checkboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:31:18 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:31:18 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 --- Comment #8 from Fridolin SOMERS --- Created attachment 63898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63898&action=edit Bug 18692 - same with syspref TalkingTechItivaPhone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:34:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:34:14 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 --- Comment #8 from Fridolin SOMERS --- Created attachment 63899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63899&action=edit Bug 18692 - same with syspref TalkingTechItivaPhone Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:35:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:35:42 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63899|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS --- Comment on attachment 63899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63899 Bug 18692 - same with syspref TalkingTechItivaPhone oups, git bz error sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:36:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:36:43 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63898|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS --- Created attachment 63900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63900&action=edit Bug 18692 - same with syspref TalkingTechItivaPhone Fixes misplaced columns introduced by previous patch and adds the "-" for phone transport type. To test: 1. Set SMSSendDriver system preference on 2. Go to intra and OPAC messaging preferences 3. By default you should see checkboxes for all messages for SMS 4. Ensure columns are not misplaced (pushing one column too much to the right) 5. Delete sms method from one of the messages in message_transports table 6. Observe that "-" is displayed instead of checkbox for that message for SMS 7. Repeat same for TalkingTechItivaPhoneNotification system preference. By default it may not have transports in message_transports, so make sure to assign some in order to have the checkboxes visible. https://bugs.koha-community.org/show_bug.cgi?id=8692 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 17:37:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 15:37:05 +0000 Subject: [Koha-bugs] [Bug 18692] When SMS is enabled the OPAC messaging table is misaligned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18692 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Fridolin SOMERS --- @Lari Taskula, I have adapted you patch. Tell me if its ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 1 22:25:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 20:25:42 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_14786=5D__Use_text_=C2=ABMARC_file?= =?utf-8?q?=C2=BB_instead_of_=C2=ABISO2709=C2=BB_everywhere?= In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14786 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 01:15:49 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 23:15:49 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #3 from David Cook --- Actually the workaround might be more inefficient so I'd rather just patch RDF::Trine::Store::SPARQL... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 01:59:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 23:59:09 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18715 [Bug 18715] Enhance Koha feature release change tool by making sysprefs searchable, and announce the new version in staff client with translatable news item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 01:59:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Jun 2017 23:59:09 +0000 Subject: [Koha-bugs] [Bug 18715] New: Enhance Koha feature release change tool by making sysprefs searchable, and announce the new version in staff client with translatable news item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18715 Bug ID: 18715 Summary: Enhance Koha feature release change tool by making sysprefs searchable, and announce the new version in staff client with translatable news item Change sponsored?: Sponsored Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: alexbuckley at catalyst.net.nz Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 18645 Take the bug 18645 new feature and add the following three enhancements: * Display the new sysprefs of the current version in a new tab in the About page for easy future access. * Make version number a search criterion for system preferences through adding a new column 'version' to the 'systempreference' table and including it in the search url * Announcing the new version on the staff client through creating a news item at the end of the installation process, this news item will appear for all libraries. This news item will contain standard text with the release number and links to new features and preferences. Library staff will be able to edit it adding some library specific information. The text will be translated to the language chosen at the start of the installation process. Thanks to Marc Veron for these ideas Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 03:48:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 01:48:12 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #4 from David Cook --- (In reply to David Cook from comment #3) > Actually the workaround might be more inefficient so I'd rather just patch > RDF::Trine::Store::SPARQL... Well actually... I thought of a different workaround which will be fine for now, and I've sent a pull request with a patch for RDF::Trine::Store::SPARQL (https://github.com/kasei/perlrdf/pull/150). The author of RDF::Trine has already said that he'd welcome a patch for the bug, so that's good. For the previous bug I found in RDF::Trine::Store::SPARQL, I sent a pull request 23 days ago, it was merged into master 14 days ago, and a new version of RDF::Trine was posted on CPAN 1 day ago (a dev release was on CPAN on May 19th so 14 days ago). So I imagine that by the time we're at Koha 17.11, the updated version will be on CPAN and be easy to package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 03:52:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 01:52:52 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #14 from David Cook --- (In reply to Magnus Enger from comment #13) > Thanks for clarifying, David! I think the problem was that I put > http://example.com/david-koha-test/query in the config, and that made the > object read only. > > On the other hand, having separate read and read/write objects could perhaps > make some sense, like using the read only object when you know you are only > going to display data, like in the OPAC. (Especially for my > librarian-configurable queries, to protect against people doing stupid/evil > things :-) That's very true, and that's something that I had been thinking about before and totally forgot about! I think using a read-only endpoint for the librarian-configurable queries is a great idea, and closes off a security hole. Does Fuseki allow you to configure permissions for user accounts as well? So even if you do use a read/write endpoint, only certain users can insert or delete triples? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 04:51:54 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 02:51:54 +0000 Subject: [Koha-bugs] [Bug 18716] New: CGI::param in list context warns in updatesupplier.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18716 Bug ID: 18716 Summary: CGI::param in list context warns in updatesupplier.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 04:52:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 02:52:00 +0000 Subject: [Koha-bugs] [Bug 18716] CGI::param in list context warns in updatesupplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18716 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 04:56:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 02:56:58 +0000 Subject: [Koha-bugs] [Bug 18716] CGI::param in list context warns in updatesupplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18716 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 04:57:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 02:57:03 +0000 Subject: [Koha-bugs] [Bug 18716] CGI::param in list context warns in updatesupplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18716 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 63901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63901&action=edit Bug 18716: Remove CGI::param warns from updatesupplier.pl This script floods the logs with this kind of warnings. To test: - Run: $ koha-plack-err - Edit a vendor in the acquisitions module - Save => FAIL: Logs show lots of warnings that look like: CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_updatesupplier_2epl - Apply this patch - Run: $ restart_all $ koha-plack-err - Edit a vendor, add/delete vendor contacts => SUCESS: No more warnings - Verify editing and storing vendor contacts works as expected. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 04:57:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 02:57:23 +0000 Subject: [Koha-bugs] [Bug 18716] CGI::param in list context warns in updatesupplier.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18716 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 04:58:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 02:58:52 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #15 from David Cook --- I'm thinking a little bit about what this would look like... I'm thinking maybe: Code: C4::Context::triplestore($model_name) Config: model_name: query module: url: username: password: realm: model_name: update module: url: username: password: realm: model_name: custom module: url: username: password: realm: #NOTE: I doubt we'd ever use custom... but the flexibility would be there. Maybe there will be a case where in the future we want to be able to connect to multiple triplestores for some reason. Who knows? -- This would actually work well with how RDF::Trine::Store::DBI is set up since it uses "model name" in its constructor. http://search.cpan.org/dist/RDF-Trine/lib/RDF/Trine/Store/DBI.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 05:27:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 03:27:42 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 05:27:46 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 03:27:46 +0000 Subject: [Koha-bugs] [Bug 12365] Notes for rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #5 from Aleisha Amohia --- Created attachment 63902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63902&action=edit Bug 12365: [FOLLOW-UP] Follow-up patch This patch fixes merge conflicts and removes an existing note from the input field (as per Comment 3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 05:38:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 03:38:17 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #8 from Aleisha Amohia --- Created attachment 63903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63903&action=edit Bug 12691: [FOLLOW-UP] Follow-up patch This patch fixes merge conflicts and fixes the problems in Comment 7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 05:38:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 03:38:13 +0000 Subject: [Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 06:17:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 04:17:05 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58787|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia --- Created attachment 63905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63905&action=edit Bug 15326: [FOLLOW-UP] Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 06:16:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 04:16:58 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58608|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia --- Created attachment 63904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63904&action=edit Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 06:17:53 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 04:17:53 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #13 from Aleisha Amohia --- Merge conflicts fixed, ready for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 06:33:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 04:33:13 +0000 Subject: [Koha-bugs] [Bug 12145] Lock for Move up buttons with Marc tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 06:33:16 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 04:33:16 +0000 Subject: [Koha-bugs] [Bug 12145] Lock for Move up buttons with Marc tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12145 --- Comment #3 from Aleisha Amohia --- Created attachment 63906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63906&action=edit Bug 12145: [FOLLOW-UP] Separating buttons and tags This patch fixes the issue in Comment 2. The move-up buttons were inside the element that gets hidden when 'Show tags' is off, therefore removing their functionality and making the 'Lock subfield positions' button useless. This patch separates the buttons and the tags into two separate span elements, and adds the appropriate CSS. To test: Confirm that 'Lock subfield positions' still works when 'Show tags' is off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 07:17:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 05:17:28 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 07:17:31 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 05:17:31 +0000 Subject: [Koha-bugs] [Bug 18708] Show itemBarcodeFallbackSearch results in a modal window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18708 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63896|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 63907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63907&action=edit [SIGNED-OFF] Bug 18708 [Revised] Show itemBarcodeFallbackSearch results in a modal window This patch modifies the circulation template so that itemBarcodeFallbackSearch results show in a modal window. To test, enable the itemBarcodeFallbackSearch system preference and open a patron's account in circulation. - Submit a string which will return search results. When the page reloads a modal should display showing a table of title search results. - Test the "Check out" button and confirm that the correct item is submitted. - Test closing the modal and re-displaying it using the new "Show matching titles" button. - Confirm that the "Add record using fast cataloging" button still works correctly. - Submit a string which will return no results. No modal window should display, and only the "Add record" button should appear. - Confirm that normal checkout works correctly. - Test with itemBarcodeFallbackSearch disabled, and with a user who lacks Fast Cataloging permission. Revision removes a heading which was made redundant by the modal markup. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 07:36:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 05:36:07 +0000 Subject: [Koha-bugs] [Bug 16834] Changing the "Set Inventory Date to" date doesn't do anything, date last seen always defaults to current date. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16834 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |FIXED --- Comment #15 from Marcel de Rooy --- Closed in favor of bug 14399 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:17:14 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:17:14 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63894|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 63908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63908&action=edit Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF This patch adds methods to Koha::RDF that creates or deletes a named graph by removing/adding RDF quads from/to a triplestore. This patch also can create a rdfs:seeAlso relationship between two RDF entities. This patch includes unit tests for both of these changes. _TEST PLAN_ 1) Run "prove t/Koha/RDF.t" 2) Note that all tests have run successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:18:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:18:30 +0000 Subject: [Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63908|0 |1 is obsolete| | --- Comment #6 from David Cook --- Created attachment 63909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63909&action=edit Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF This patch adds methods to Koha::RDF that creates or deletes a named graph by removing/adding RDF quads from/to a triplestore. This patch also can create a rdfs:seeAlso relationship between two RDF entities. This patch includes unit tests for both of these changes. _TEST PLAN_ 1) Run "prove t/Koha/RDF.t" 2) Note that all tests have run successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:48:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:48:47 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:48:51 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:48:51 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:48:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:48:55 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:48:43 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:48:43 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:48:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:48:58 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:49:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:49:02 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63052|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:49:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:49:06 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63053|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:49:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:49:10 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:49:13 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:49:13 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63055|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:49:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:49:17 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:52:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:52:27 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #102 from Marcel de Rooy --- Rearranging extensive number of (qa) follow-ups according to this plan: Patch 1 Original start Patch 3 + 5 + 6 Change table design Patch 4 DBIx Schema Patch 7 + Patch 8 + Patch 10a Module fixes Patch 2 + Patch 9 + Patch 10b Unit test Patch 11 New QA follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:53:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:53:42 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #103 from Marcel de Rooy --- Created attachment 63910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63910&action=edit Bug 8612: Use CSV profile for exporting basket This patch allows the user to use a CSV export profile to create the fields to export the basket as CSV in a basket page. Test plan: 1) Apply the patch 2) Go to Tools ? CSV export profiles and create a profile of type "SQL for basket export in acquisition" example: biblionumber=biblio.biblionumber|auteur=biblio.author|titre=biblio.title|date=biblioitems.copyrightdate|editeur=biblioitems.publishercode|isbn=biblioitems.isbn|quantite=aqorders.quantity|prix=aqorders.rrp|panier=aqorders.basketno 3) In acquisition module, create a new basket and add an order to the basket 4) On basket detail page, there should be the split button labelled "Export to CSV" 5) Try to use the button and export CSV with your CSV profile you defined in step 2 6) Validate the CSV file. 7) Repeat 4-6 with a closed basket. a) close the basket b) View the basket c) validate that there is an export button d) test it with an export 8) prove t/db_dependent/Acquisition/GetBasketAsCSV.t t/db_dependent/Koha/CsvProfiles.t Initial work: Sponsored by: CCSR Signed-off-by: Josef Moravec Signed-off-by: mehdi Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:53:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:53:48 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #104 from Marcel de Rooy --- Created attachment 63911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63911&action=edit Bug 8612: [Follow-up] Make usage and type different columns in table Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:54:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:54:01 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #105 from Marcel de Rooy --- Created attachment 63912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63912&action=edit Bug 8612: [Follow-up] Update DBIx schema Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:54:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:54:08 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #106 from Marcel de Rooy --- Created attachment 63913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63913&action=edit Bug 8612: [Follow-up] Fix regular expression Fix regular expression to do what is described in the comment Make header in CSV profile definition optional Strip white chars from csv profile definition Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:54:15 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:54:15 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #107 from Marcel de Rooy --- Created attachment 63914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63914&action=edit Bug 8612: [Follow-up] Fix unit test GetBasketAsCSV.t Test plan: Run t/db_dependent/Acquisition/GetBasketAsCSV.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:54:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:54:22 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #108 from Marcel de Rooy --- Created attachment 63915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63915&action=edit Bug 8612: [QA Follow-up] Remove two newlines from template output When using the Default profile from the basket form, the resulting csv file has an additional newline after the headers and at the end. This patch removes them. Unit test adjusted accordingly. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:55:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:55:58 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:56:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:56:52 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #109 from Marcel de Rooy --- Another report may still deal with this warn: Use of uninitialized value in string eq at C4/Acquisition.pm line 318. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 08:59:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 06:59:45 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #110 from Marcel de Rooy --- And: die "There is no valid csv profile given" unless $csv_profile; Being liberal now. But we should actually use Koha::Exceptions now according to a new rule in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:02:05 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:02:05 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #40 from Marcel de Rooy --- No longer applies and typo mentioned in previous comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:02:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:02:41 +0000 Subject: [Koha-bugs] [Bug 18717] New: Use of uninitialized value in string eq at C4/ Acquisition.pm line 318 after bug 8612 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18717 Bug ID: 18717 Summary: Use of uninitialized value in string eq at C4/Acquisition.pm line 318 after bug 8612 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org (In reply to Marcel de Rooy from comment #109) > Another report may still deal with this warn: > Use of uninitialized value in string eq at C4/Acquisition.pm line 318. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:03:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:03:25 +0000 Subject: [Koha-bugs] [Bug 18717] Use of uninitialized value in string eq at C4/ Acquisition.pm line 318 after bug 8612 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18717 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com Depends on| |8612 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 [Bug 8612] CSV export profile to have custom fields in export csv basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:03:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:03:25 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18717 [Bug 18717] Use of uninitialized value in string eq at C4/Acquisition.pm line 318 after bug 8612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:04:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:04:25 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #111 from Josef Moravec --- (In reply to Marcel de Rooy from comment #109) > Another report may still deal with this warn: > Use of uninitialized value in string eq at C4/Acquisition.pm line 318. I filled new bug 18717 for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:05:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:05:23 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:05:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:05:26 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61975|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 63916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63916&action=edit Bug 18278: C4::Items - Remove GetItemLocation This subroutine is no longer in used. It was previously call from serials/serials-recieve.pl, which was not used and has been removed by commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 Bug 13423: Remove unused serials-recieve Test plan: git grep GetItemLocation Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:05:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:05:38 +0000 Subject: [Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:14:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:14:39 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:14:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:14:23 +0000 Subject: [Koha-bugs] [Bug 18585] Connect to RDF triplestore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 --- Comment #16 from David Cook --- I ran out of time today and it's Friday, but I'll look at posting a revised patch on Monday. The patch needed to be rebased anyway because of some changes to koha-conf.xml I believe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:14:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:14:42 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 --- Comment #8 from Marcel de Rooy --- Created attachment 63917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63917&action=edit Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy bsoletes: 63887 - [SIGNED-OFF] Bug 18295: C4::Items - get_itemnumbers_of -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:14:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:14:56 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:15:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:15:38 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63887|0 |1 is obsolete| | Attachment #63917|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 63918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63918&action=edit Bug 18295: C4::Items - get_itemnumbers_of The code from scripts and subroutines using this subroutine was not very elegant. Most of the time the code was unnecessarily complex. This patch removes this subroutine and adapt the code to use Koha::Items instead. 1. C4::Items::get_hostitemnumbers_of I did not understand why the code was so complicated, it seems that we only want to know if a given item has a given biblionumber 2. cataloguing/merge.pl We want to retrieve the itemnumber for a given biblio. We could also have done that with: Koha::Biblios->find( $biblionumber )->items; 3. labels/label-item-search.pl We want to loop over the items for a given biblio, no need to use get_itemnumbers_of and GetItemInfosOf. We just need to use: Koha::Items->search({ biblionumber => $biblionumber }) 4. reserve/request.pl We want to retrieve the itemnumbers of the biblio's items We could also have done that with: Koha::Biblios->find( $biblionumber )->items->get_column('itemnumber'); Test plan: 1.You need to create analytical record relationships ( EasyAnalyticalRecords needs to be set). Link an item to a biblio using the 'Edit > Link to host item' menu from the biblio detail page. >From the staff interface place a hold on the biblio. You should see the items from the biblio and the one you just linked 2. Merge two bibliographic records (with items), the resulting record should contain items from both original records 3. Create a new label batch, edit it. Add items to this batch ('Add items' button). Fill the input with a barcode. You should see all the items of a biblio. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 09:18:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 07:18:08 +0000 Subject: [Koha-bugs] [Bug 18295] C4::Items - Remove get_itemnumbers_of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18295 --- Comment #10 from Marcel de Rooy --- QA Comment: Looks good to me. Being liberal on unit tests here, but I know some QAers would certainly fail qa on this patch because get_hostitemnumbers_of is changed but not tested :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:26:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:26:07 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:26:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:26:10 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61191|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63919&action=edit Bug 18279: Remove C4::Items::GetLostItems The JOIN done by this subroutine are not always useful (depending on item-level_itypes). They also search with LIKE when it is not needed. Since we have now Koha::Items, we can replace this subroutine with a call to Koha::Items->search with the correct parameters. A change in previous behaviours can happen: If a items.itemlost contains a value that is not defined as a LOST authorised value, the item will not be displayed. I think it's the expected behaviour, even if it should not happen in correctly configured installations. Test plan: To test with item-level_itypes set to item and biblio: List the lost items you have on your system, using the different filters available. The result table should contain the correct item's info. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:28:25 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:28:25 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 --- Comment #6 from Marcel de Rooy --- Created attachment 63920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63920&action=edit Bug 18279: [QA Follow-up] Correct @EXPORT Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:30:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:30:28 +0000 Subject: [Koha-bugs] [Bug 18718] New: Language selector in staff header menu similar to OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Bug ID: 18718 Summary: Language selector in staff header menu similar to OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The OPAC has the possibility to display a language selector in both header and/or footer, configured by syspref OpacLangSelectorMode. Implement the same for the staff client. - System preference StaffLangSelectorMode, defaulting to: 'only footer' - Language menu in header (at the left of "Help") that appears if syspref is set to 'Top' or 'Both' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:30:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:30:47 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:34:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:34:44 +0000 Subject: [Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- QA Comment: Looks good to me. In the lost script, this construction is little bit strange: my $loststatusfilter = $params->{'loststatusfilter'} || undef; Normally you would expect something as: my $loststatusfilter = $params->{'loststatusfilter'} // ''; In this particular case, it might have a weird side effect. If you add a LOST status for value 0 in auth values, and you select that lost value on the report form, it will return you the lost items instead of the items with value 0. But adding a LOST auth value for 0 is not really useful. Selecting the not lost items on the lost form makes no sense too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:35:21 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:35:21 +0000 Subject: [Koha-bugs] [Bug 18719] New: Manage staged MARC records, the Job progress bar stuck at 0% Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18719 Bug ID: 18719 Summary: Manage staged MARC records, the Job progress bar stuck at 0% Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: joseanjos at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Following: http://koha.1045719.n5.nabble.com/Problem-on-Staged-MARC-management-td5935206.html#a5935320 I can upload the Unimarc file, then "Stage for import", but then when I import this batch into the catalog on "Manage staged MARC records", the Job progress bar will keep 0% forever. If I refresh page it shows that the record was staged ok. The problem is related with the Items because when I choose NO on "Check for embedded item record data?" it works, the Job progress bar will go to 100% I've tried other files and with mysql 5.7 or mariDB On /var/log/koha/koha/intranet-error.log [cgi:error] [pid 1580] [client xx.xx.xx.xx:35538] AH01215: [Tue May 30 14:34:16 2017] stage-marc-import.pl: Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 397, <__ANONIO__> chunk 2.: /usr/share/koha/intranet/cgi-bin/tools/stage-marc-import.pl, referer: http://yy.yy.yy.yy::8080/cgi-bin/koha/tools/stage-marc-import.pl Trying with bulkmarcimport.pl I have this message: bib-64150.marcxml deleting biblios DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign key constraint (`koha_koha`.`aqorders`, CONSTRAINT `aqorders_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `koha_koha`.`biblio` (`biblionumber`)) [for Statement "truncate biblio"] at /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 150. DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign key constraint (`koha_koha`.`items`, CONSTRAINT `items_ibfk_1` FOREIGN KEY (`biblioitemnumber`) REFERENCES `koha_koha`.`biblioitems` (`biblioitemnumber`)) [for Statement "truncate biblioitems"] at /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 151. DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign key constraint (`koha_koha`.`accountlines`, CONSTRAINT `accountlines_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `koha_koha`.`items` (`itemnumber`)) [for Statement "truncate items"] at /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 152. Characteristic MARC flavour: UNIMARC . 1 MARC records done in 0.147950887680054 seconds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:39:37 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:39:37 +0000 Subject: [Koha-bugs] [Bug 18296] C4::Items - Remove GetItemInfosOf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18296 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- Cannot apply this on top of 18295. Regardless of applying 18279 in between or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:44:12 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:44:12 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63860|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63921&action=edit Bug 18700 Fix grammar (data cannot be pluralized) data is a mass noun or plural of datum - datas is ungrammatical and jarring for a native speaker. Split the awkward sounding sentence into two for more clarity, thanks to Marc V?ron for the suggestion. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:44:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:44:23 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:44:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:44:10 +0000 Subject: [Koha-bugs] [Bug 18700] Fix ungrammatical sentence In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:46:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:46:38 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:46:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:46:41 +0000 Subject: [Koha-bugs] [Bug 13913] Renewal error message in OPAC is confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63321|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 63922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63922&action=edit Bug 13913 - Renewal error message in OPAC is confusing This patch adds some formatting to the error message a patron receives when there are renewal failures in the OPAC. This is pretty much the least which could be done to address this problem. However, I don't think the issue can be fixed without re-thinking how renewals are processed. Sending error messages back to opac-user.pl via URL parameter isn't flexible enough. To test, apply the patch and attempt to renew multiple items in the OPAC which cannot be renewed for some reason, for instance because they have been renewed too many times. The error messages should appear in a list rather than strung together in one long block of text. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:50:19 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:50:19 +0000 Subject: [Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:50:22 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:50:22 +0000 Subject: [Koha-bugs] [Bug 18430] Plugins page should have a link to viewing other types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62151|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 63923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63923&action=edit Bug 18430 - Plugins page should have a link to viewing other types To test: Go to the plugins page from Reports->Report plugins Tools->Tool plugins Admin->Manage plugins Ensure that you have a 'View plugins by class button' Ensure the button does what you would expect Signed-off-by: Christopher Brannon Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:58:48 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:58:48 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:58:52 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:58:52 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63309|0 |1 is obsolete| | --- Comment #57 from Marcel de Rooy --- Created attachment 63924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63924&action=edit Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from admin/itemtypes.pl Removed the sql code from Itemtypes.pm and replaced it with DBIx database query in the itemtypes.pl administrative script Test plan: 1. In the staff interface, stage and manage MARC records for import 2. Try to delete an itemtype. If there are items of that itemtype in the database then a message telling you the number of items of that itemtype there are will be displayed. 3. Record that number 4. View the admin/itemtpes.pl script and confirm that there is sql code written in this file. 5. Apply this patch 6. View the admin/itemtypes.pl script and observe that there is no sql in this file. There is however DBIx code, for example $schema->resultset('Item')->search({ 'itype' => $itemtype_code} ); which is searching for items with the itype value matching $itemtype_code value. 7. In the staff interface try to delete the same itemtype 8. Record the number of items there are with that itemtype in the resulting message 9. The numbers recorded in steps 3 and 8 should match showing that the DBIx code is working as intended Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:58:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:58:58 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63310|0 |1 is obsolete| | --- Comment #58 from Marcel de Rooy --- Created attachment 63925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63925&action=edit Bug 17944: QA follow-up - Remove an unused use statement - Fix pod - Use snake_case - Fix test "An itemtype cannot be deleted if and only if there is biblioitem linked with it" Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 10:59:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 08:59:09 +0000 Subject: [Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:03:41 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:03:41 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:03:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:03:44 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63606|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63926&action=edit Bug 18643: Remove dead code in reports/statistics 'Till reconciliation' File koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt contains a link to /cgi-bin/koha/reports/stats.screen.pl with label 'Till reconciliation' that is commented out since years. Remove this link and the related files: cgi-bin/koha/reports/stats.screen.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/stats_screen.tt To test: - Apply patch - Verify that Koha > Reports still display the same - Verify that two files stats.screen.pl and stats_screen.tt are gone and thet they are not used anywhere in the Koha codebase Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:04:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:04:01 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:04:33 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:04:33 +0000 Subject: [Koha-bugs] [Bug 18717] Use of uninitialized value in string eq at C4/ Acquisition.pm line 318 after bug 8612 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18717 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:04:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:04:35 +0000 Subject: [Koha-bugs] [Bug 18717] Use of uninitialized value in string eq at C4/ Acquisition.pm line 318 after bug 8612 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18717 --- Comment #1 from Josef Moravec --- Created attachment 63927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63927&action=edit Bug 18717: Check existence of variables Test plan: 0) Apply the patches from bug 8612 1) Have basket with some orders - at least one biblio should NOT have isbn filled 2) Define custom CSV profile of tpe SQL and Usage "Basket export in acquisition" 2) Go to basket detail and download basket as CSV using this custom CSV profile 3) Read the log --> without this patch you see the warning about uninitialized variables --> with patch the warning shouldn't be logged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:09:00 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:09:00 +0000 Subject: [Koha-bugs] [Bug 16696] Rename "Publisher" to "Published" on detail and result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #5 from Marcel de Rooy --- Moving to In Discussion. Not ready for inclusion. Do you have another idea, Aleisha? Or someone else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:10:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:10:35 +0000 Subject: [Koha-bugs] [Bug 18720] New: Get rid of "die" in favor of exceptions in C4:: Acquisition::GetBasketAsCsv Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 Bug ID: 18720 Summary: Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org See bug 8612: (Marcel de Rooy from comment #110) > And: > die "There is no valid csv profile given" unless $csv_profile; > Being liberal now. But we should actually use Koha::Exceptions now according > to a new rule in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:11:01 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:11:01 +0000 Subject: [Koha-bugs] [Bug 18720] Get rid of "die" in favor of exceptions in C4::Acquisition:: GetBasketAsCsv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:11:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:11:08 +0000 Subject: [Koha-bugs] [Bug 18720] Get rid of "die" in favor of exceptions in C4::Acquisition:: GetBasketAsCsv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 [Bug 8612] CSV export profile to have custom fields in export csv basket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:11:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:11:08 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18720 [Bug 18720] Get rid of "die" in favor of exceptions in C4::Acquisition::GetBasketAsCsv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:12:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:12:28 +0000 Subject: [Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #112 from Josef Moravec --- (In reply to Marcel de Rooy from comment #110) > And: > die "There is no valid csv profile given" unless $csv_profile; > Being liberal now. But we should actually use Koha::Exceptions now according > to a new rule in the coding guidelines. I filled new bug 18720 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:15:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:15:06 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:15:10 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:15:10 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63608|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 63928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63928&action=edit Bug 18641 - Translatability: Get rid of template directives in translations for *reserves.tt files Template directives should not be exposed in translation, but lines like the following pop up in the translation tool: Cancel [% IF TransferWhenCancelAllWaitingHolds %]and Transfer [% END %] All This patch fixes it. To test: - Apply patch - Verify that code changes make sense - Verify that submit buttons of pendingreserves.tt and waitingreserves.tt still work and display the same string as before Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:15:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:15:28 +0000 Subject: [Koha-bugs] [Bug 18641] Translatability: Get rid of template directives in translations for *reserves.tt files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:19:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:19:45 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:19:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:19:47 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63776|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 63929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63929&action=edit Bug 18650 - Translatability: Get rid of tt directive in translation for cat-toolbar.inc Translation tool shows [% count %] item(s) are... in translation for koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc This patch fixes it. To test: - Apply patch - Go to a biblio record with at least 1 item attached - Verify that tooltip for 'Edit > Delete record' shows same text as before (n item(s) are attached...) (Amended to remove superfluous chomps 2017-05-27 mv) Followed test plan and everything worked as intended Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:19:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:19:58 +0000 Subject: [Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:23:45 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:23:45 +0000 Subject: [Koha-bugs] [Bug 18673] News author does not display on staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:23:47 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:23:47 +0000 Subject: [Koha-bugs] [Bug 18673] News author does not display on staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63775|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63930&action=edit Bug 18673: News author does not display on staff client home page News authors do not display on staff client homepage, independently of syspref 'NewsAuthorDisplay'. This patch fixes the issue. To verify: - Create news with display location 'All' - Set syspref NewsAuthorDisplay to 'Staff client only' or 'Both OPAC and staff client' - Go to staff client - Verify that news author does not appear (but it should) To test: - Applly patch - Verify that news author is displayed as expected Followed test plan works as intended Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:24:06 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:24:06 +0000 Subject: [Koha-bugs] [Bug 18673] News author does not display on staff client home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18673 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:27:27 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:27:27 +0000 Subject: [Koha-bugs] [Bug 18652] Get rid of tt directive in translation for uncertainprice.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:27:30 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:27:30 +0000 Subject: [Koha-bugs] [Bug 18652] Get rid of tt directive in translation for uncertainprice.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63772|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 63931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63931&action=edit Bug 18652: Get rid of tt directive in translation for uncertainprice.tt Translation tool shows toe following for ncertainprice.tt 0; url=[% scriptname %]?booksellerid=[% booksellerid %] This patch fixes it. To test: - Apply patch - Verify that code change makes sense - Verify that Home > Acquisitions > [vendor] > Uncertain prices for [vendor] works as before Followed test plan and patch worked as intended Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:27:38 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:27:38 +0000 Subject: [Koha-bugs] [Bug 18652] Get rid of tt directive in translation for uncertainprice.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18652 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:30:39 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:30:39 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:30:42 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:30:42 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63892|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 63932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63932&action=edit Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel To test: 1 - Save a csv of biblionumber from MS/Excel 2 - Attempt to export records using this file 3 - It fails (mimetype is appliction/vnd.ms-excel) 4 - Apply patch 5 - Try again 6 - It succeeds! Signed-off-by: Jason Palmer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:30:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:30:58 +0000 Subject: [Koha-bugs] [Bug 18704] File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:33:24 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:33:24 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #8 from Marcel de Rooy --- Marc, I understand your explanation, but you did not respond to my question about the trailing IF. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:35:36 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:35:36 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:40:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:40:40 +0000 Subject: [Koha-bugs] [Bug 18721] New: C4::Installer uses Koha::Database instead Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18721 Bug ID: 18721 Summary: C4::Installer uses Koha::Database instead Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org C4::Installer->new() duplicates code from Koha::Database->_new_schema() Fixing by making C4::Installer get the db connection the normal way. TEST PLAN: use misc/devel/populate_db.pl or installer/install_automatic.pl whichever you have to deploy the default database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:41:55 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:41:55 +0000 Subject: [Koha-bugs] [Bug 18721] C4::Installer uses Koha::Database instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18721 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 63933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63933&action=edit Bug 18721 - C4::Installer uses Koha::Database instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:43:02 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:43:02 +0000 Subject: [Koha-bugs] [Bug 18721] C4::Installer uses Koha::Database instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18721 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:43:56 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:43:56 +0000 Subject: [Koha-bugs] [Bug 11974] Enable unix socket connections for database connections. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|CLOSED |REOPENED --- Comment #22 from Olli-Antti Kivilahti --- Beating a dead horse which might not be dead for long. Bug 18721 refactors the installer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:44:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:44:17 +0000 Subject: [Koha-bugs] [Bug 11974] Enable unix socket connections for database connections. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18721 [Bug 18721] C4::Installer uses Koha::Database instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:44:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:44:17 +0000 Subject: [Koha-bugs] [Bug 18721] C4::Installer uses Koha::Database instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18721 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 [Bug 11974] Enable unix socket connections for database connections. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:47:28 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:47:28 +0000 Subject: [Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #18 from Marcel de Rooy --- ping Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:50:35 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:50:35 +0000 Subject: [Koha-bugs] [Bug 11974] Enable non-default unix socket location for database connections. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enable unix socket |Enable non-default unix |connections for database |socket location for |connections. |database connections. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:51:09 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:51:09 +0000 Subject: [Koha-bugs] [Bug 18199] Proxy support for UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18199 Tolsti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60792|0 |1 is obsolete| | --- Comment #2 from Tolsti --- Created attachment 63934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63934&action=edit Updated patch to reflect changes in the latest debian packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 11:54:59 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 09:54:59 +0000 Subject: [Koha-bugs] [Bug 17807] Use XSLT_Handler in oai.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17807 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63464|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 63935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63935&action=edit Bug 17807: Use XSLT_Handler in Koha::OAI Replacing some code in the OAI modules by a call to an existing module. Note that the xmldoc format is used in the transform call to get a xml document object. The stylesheet method of Repository now only returns the name of the xsl file to be used instead of a cached xslt object. Similar functionality inside XSLT_Handler is used when calling transform. Note: We still lack unit tests in this area. I did not see the need for adding something for stylesheet since it only returns a simple string. The other change is made in Record::new; there are no tests for this module yet and the heart of the change here is actually tested already in XSLT_Handler.t. Note: I benchmarked calls to Repository in the old and the new situation and did not see significant changes. Test plan: [1] Run t/db_dependent/OAI/Server.t [2] Run oai.pl with ListRecords and marcxml. [3] Run oai.pl with ListRecords and oai_dc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 12:23:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 10:23:11 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 --- Comment #1 from Marc V?ron --- Created attachment 63936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63936&action=edit Bug 18718: Language selector in staff header menu similar to OPAC This patch adds a language selector menu to the top menu of staff client similar to the OPAC. Display of language selectors at top, bottom or both can be configured with system preference StaffLangSelectorModer. It defaults to bottom. To test: - Apply patch - Udate database - Restart plack and memchached - Go to staff client, verify that language selector displays at the bottom of the page (as before) - Go to system preferences, verify that there is a new preference StaffLanguageSelectorMode (name similar to the sypref ror OPAC), and that it is set to 'footer' - Change mode for top, both and footer and verify, go to staff client and verify for each that the language selector displays as appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 12:24:07 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 10:24:07 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 12:36:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 10:36:17 +0000 Subject: [Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 12:36:17 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 10:36:17 +0000 Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 [Bug 18606] Move rotating collections code to Koha::Object -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 12:49:26 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 10:49:26 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #9 from Marc V?ron --- (In reply to Marcel de Rooy from comment #8) > Marc, > I understand your explanation, but you did not respond to my question about > the trailing IF. Ah, sorry, I must have skipped the main part... If you do a translate create for a "language" aa-AA and then examine the file, you find: #. INPUT type=text name=enrolmentperiod #: intranet-tmpl/prog/en/modules/admin/categories.tt:92 #: intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt:104 msgid "" "[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" msgstr "" If you apply the patch and translate create again, these line are gone. The problem occurs because there is more than one tt statement inside a value attribute for a form field: value="[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" If the attribute is changed to have one statement only, the translation tool does not pick it. That's why I changed it to have a trailing IF. And yes, we have a little bit less readability for programmers, but no more disturbing tt directives for translators. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 12:51:40 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 10:51:40 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #10 from Marcel de Rooy --- (In reply to Marc V?ron from comment #9) > (In reply to Marcel de Rooy from comment #8) > > Marc, > > I understand your explanation, but you did not respond to my question about > > the trailing IF. > > Ah, sorry, I must have skipped the main part... > > If you do a translate create for a "language" aa-AA and then examine the > file, you find: > > #. INPUT type=text name=enrolmentperiod > #: intranet-tmpl/prog/en/modules/admin/categories.tt:92 > #: intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt:104 > msgid "" > "[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END %]" > msgstr "" > > If you apply the patch and translate create again, these line are gone. > > The problem occurs because there is more than one tt statement inside a > value attribute for a form field: > value="[% IF category.enrolmentperiod %][% category.enrolmentperiod %][% END > %]" > > If the attribute is changed to have one statement only, the translation tool > does not pick it. That's why I changed it to have a trailing IF. > > And yes, we have a little bit less readability for programmers, but no more > disturbing tt directives for translators. Sure :) But why not just [% category.enrolmentperiod %] ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 13:11:03 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 11:11:03 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #11 from Marc V?ron --- Oh... Hmm... That's true for the original line as well... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 13:19:11 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 11:19:11 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 --- Comment #12 from Marc V?ron --- Created attachment 63937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63937&action=edit Bug 18649: [QA followup] Simplify If and remove chomps in admin/categories.tt As of comment #3, the chomps are not needed because the directive has no surrounding white space that should be removed. As of comment #10, the IF statement can be implified (Amended 2017-06-02 mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 13:19:58 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 11:19:58 +0000 Subject: [Koha-bugs] [Bug 18649] Translatability: Get rid of tt directive in translation for admin/ categories.tt and onboardingstep2.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18649 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 14:13:23 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 12:13:23 +0000 Subject: [Koha-bugs] [Bug 18570] Password recovery e-mail only sent after message queue is processed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18570 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 14:16:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 12:16:44 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 14:17:08 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 12:17:08 +0000 Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the 'active' switch on budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 2 14:53:44 2017 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Jun 2017 12:53:44 +0000 Subject: [Koha-bugs] [Bug 18718] Language selector in staff header menu similar to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18718 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- This looks good, but I suggest one small change. Add a "dropdown-menu-right" class so that the menu doesn't disappear off the right side of the browser window with some installed languages with long labels like "English United Kingdom"